Re: [SSSD] [PATCH] SDAP: Remove unused function

2015-09-11 Thread Jakub Hrozek 
On Wed, Sep 09, 2015 at 12:19:28PM +0200, Pavel Reichl wrote:
> 
> 
> On 09/08/2015 05:41 PM, Jakub Hrozek wrote:
> >On Fri, Sep 04, 2015 at 03:12:06PM +0200, Pavel Reichl wrote:
> >>
> >>
> >>On 09/02/2015 04:21 PM, Pavel Reichl wrote:
> >>>
> >>>On 09/02/2015 04:16 PM, Jakub Hrozek wrote:
> Unused code is broken code, remove it :)
> 
> 
> 
> ___
> sssd-devel mailing list
> sssd-devel@lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> 
> >>>Should we improve comment in remove_ldap_connection_callbacks() which 
> >>>mentions sdap_mark_offline()?
> >>>___
> >>>sssd-devel mailing list
> >>>sssd-devel@lists.fedorahosted.org
> >>>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >>
> >>OK, I don't want to stall the patch.
> >>
> >>CI passed (with exception of unrelated issues on rawhide):
> >>http://sssd-ci.duckdns.org/logs/job/24/38/summary.html
> >>
> >>ACK
> >
> >No, you were right the first time, I just didn't have time to respin the
> >patch. New one is attached.
> OK, thanks.
> 
> ci passed: http://sssd-ci.duckdns.org/logs/job/25/63/summary.html
> ACK

* master: 63fb0857378c450d9806b1a3c6bb5657f00a8ba1
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] SDAP: Remove unused function

2015-09-09 Thread Pavel Reichl 



On 09/08/2015 05:41 PM, Jakub Hrozek wrote:

On Fri, Sep 04, 2015 at 03:12:06PM +0200, Pavel Reichl wrote:



On 09/02/2015 04:21 PM, Pavel Reichl wrote:


On 09/02/2015 04:16 PM, Jakub Hrozek wrote:

Unused code is broken code, remove it :)



___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


Should we improve comment in remove_ldap_connection_callbacks() which mentions 
sdap_mark_offline()?
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


OK, I don't want to stall the patch.

CI passed (with exception of unrelated issues on rawhide):
http://sssd-ci.duckdns.org/logs/job/24/38/summary.html

ACK


No, you were right the first time, I just didn't have time to respin the
patch. New one is attached.

OK, thanks.

ci passed: http://sssd-ci.duckdns.org/logs/job/25/63/summary.html
ACK
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] SDAP: Remove unused function

2015-09-08 Thread Jakub Hrozek 
On Fri, Sep 04, 2015 at 03:12:06PM +0200, Pavel Reichl wrote:
> 
> 
> On 09/02/2015 04:21 PM, Pavel Reichl wrote:
> >
> >On 09/02/2015 04:16 PM, Jakub Hrozek wrote:
> >>Unused code is broken code, remove it :)
> >>
> >>
> >>
> >>___
> >>sssd-devel mailing list
> >>sssd-devel@lists.fedorahosted.org
> >>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >>
> >Should we improve comment in remove_ldap_connection_callbacks() which 
> >mentions sdap_mark_offline()?
> >___
> >sssd-devel mailing list
> >sssd-devel@lists.fedorahosted.org
> >https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> 
> OK, I don't want to stall the patch.
> 
> CI passed (with exception of unrelated issues on rawhide):
> http://sssd-ci.duckdns.org/logs/job/24/38/summary.html
> 
> ACK

No, you were right the first time, I just didn't have time to respin the
patch. New one is attached.
>From c5c4ed60d9d7132a7af092a6961e0b0e2a3162dd Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Tue, 1 Sep 2015 17:50:32 +0200
Subject: [PATCH] SDAP: Remove unused function

---
 src/providers/ldap/ldap_common.c| 5 -
 src/providers/ldap/ldap_common.h| 2 --
 src/providers/ldap/sdap_fd_events.c | 4 ++--
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/providers/ldap/ldap_common.c b/src/providers/ldap/ldap_common.c
index 
840a0987180935b16c774b8ea8dc0aaca0f846b1..aa4c6cb851a5735e051ef2c024ca0171a4f61148
 100644
--- a/src/providers/ldap/ldap_common.c
+++ b/src/providers/ldap/ldap_common.c
@@ -44,11 +44,6 @@ void sdap_handler_done(struct be_req *req, int dp_err,
 return be_req_terminate(req, dp_err, error, errstr);
 }
 
-void sdap_mark_offline(struct sdap_id_ctx *ctx)
-{
-be_mark_offline(ctx->be);
-}
-
 int ldap_id_setup_tasks(struct sdap_id_ctx *ctx)
 {
 return sdap_id_setup_tasks(ctx->be, ctx, ctx->opts->sdom,
diff --git a/src/providers/ldap/ldap_common.h b/src/providers/ldap/ldap_common.h
index 
8294d1db23bdca8d94a098533d93405c4d55226b..716aaa08ef83b8fca3779b830fdef20bbdb14937
 100644
--- a/src/providers/ldap/ldap_common.h
+++ b/src/providers/ldap/ldap_common.h
@@ -210,8 +210,6 @@ errno_t ldap_setup_cleanup(struct sdap_id_ctx *id_ctx,
 errno_t ldap_id_cleanup(struct sdap_options *opts,
 struct sdap_domain *sdom);
 
-void sdap_mark_offline(struct sdap_id_ctx *ctx);
-
 struct tevent_req *groups_get_send(TALLOC_CTX *memctx,
struct tevent_context *ev,
struct sdap_id_ctx *ctx,
diff --git a/src/providers/ldap/sdap_fd_events.c 
b/src/providers/ldap/sdap_fd_events.c
index 
cfd656ff94c898dcecb574293e70aaff34f199ea..eeb4c9528c0024bddca9c6703492ec6300c544fc
 100644
--- a/src/providers/ldap/sdap_fd_events.c
+++ b/src/providers/ldap/sdap_fd_events.c
@@ -49,8 +49,8 @@ int get_fd_from_ldap(LDAP *ldap, int *fd)
 
 int remove_ldap_connection_callbacks(struct sdap_handle *sh)
 {
-/* sdap_fd_events might be NULL here if sdap_mark_offline()
- * was called before a connection was established.
+/* sdap_fd_events might be NULL here if the back end was marked offline
+ * before a connection was established.
  */
 if (sh->sdap_fd_events) {
 #ifdef HAVE_LDAP_CONNCB
-- 
2.4.3

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] SDAP: Remove unused function

2015-09-04 Thread Pavel Reichl 



On 09/02/2015 04:21 PM, Pavel Reichl wrote:


On 09/02/2015 04:16 PM, Jakub Hrozek wrote:

Unused code is broken code, remove it :)



___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


Should we improve comment in remove_ldap_connection_callbacks() which mentions 
sdap_mark_offline()?
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


OK, I don't want to stall the patch.

CI passed (with exception of unrelated issues on rawhide):
http://sssd-ci.duckdns.org/logs/job/24/38/summary.html

ACK
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] SDAP: Remove unused function

2015-09-02 Thread Pavel Reichl 


On 09/02/2015 04:16 PM, Jakub Hrozek wrote:

Unused code is broken code, remove it :)



___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Should we improve comment in remove_ldap_connection_callbacks() which 
mentions sdap_mark_offline()?

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] SDAP: Remove unused function

2015-09-02 Thread Jakub Hrozek 
Unused code is broken code, remove it :)
>From e3d8eda8dcf32adbdd001915d0308f16f6e45dfb Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Tue, 1 Sep 2015 17:50:32 +0200
Subject: [PATCH] SDAP: Remove unused function

---
 src/providers/ldap/ldap_common.c | 5 -
 src/providers/ldap/ldap_common.h | 2 --
 2 files changed, 7 deletions(-)

diff --git a/src/providers/ldap/ldap_common.c b/src/providers/ldap/ldap_common.c
index 
840a0987180935b16c774b8ea8dc0aaca0f846b1..aa4c6cb851a5735e051ef2c024ca0171a4f61148
 100644
--- a/src/providers/ldap/ldap_common.c
+++ b/src/providers/ldap/ldap_common.c
@@ -44,11 +44,6 @@ void sdap_handler_done(struct be_req *req, int dp_err,
 return be_req_terminate(req, dp_err, error, errstr);
 }
 
-void sdap_mark_offline(struct sdap_id_ctx *ctx)
-{
-be_mark_offline(ctx->be);
-}
-
 int ldap_id_setup_tasks(struct sdap_id_ctx *ctx)
 {
 return sdap_id_setup_tasks(ctx->be, ctx, ctx->opts->sdom,
diff --git a/src/providers/ldap/ldap_common.h b/src/providers/ldap/ldap_common.h
index 
8294d1db23bdca8d94a098533d93405c4d55226b..716aaa08ef83b8fca3779b830fdef20bbdb14937
 100644
--- a/src/providers/ldap/ldap_common.h
+++ b/src/providers/ldap/ldap_common.h
@@ -210,8 +210,6 @@ errno_t ldap_setup_cleanup(struct sdap_id_ctx *id_ctx,
 errno_t ldap_id_cleanup(struct sdap_options *opts,
 struct sdap_domain *sdom);
 
-void sdap_mark_offline(struct sdap_id_ctx *ctx);
-
 struct tevent_req *groups_get_send(TALLOC_CTX *memctx,
struct tevent_context *ev,
struct sdap_id_ctx *ctx,
-- 
2.4.3

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel