Re: [SSSD] [PATCH] SDAP: Remove unused sdap_id_ctx from sdap_id_conn_cache_create

2015-11-02 Thread Lukas Slebodnik 
On (02/11/15 13:20), Pavel Reichl wrote:
>On 11/02/2015 12:07 PM, Pavel Reichl wrote:
>>On 11/02/2015 11:50 AM, Lukas Slebodnik wrote:
>>>ehlo,
>>>
>>>simple patch is attached.
>>>
>>>LS
>>>
>>
>>LGTM, compiles fine. I'll just postpone acking until CI results arrive...
>
>ACK ci passed: http://sssd-ci.duckdns.org/logs/job/31/80/summary.html
>
master:
* ba17e124aa7003a92680eda5df0a9b5292c8c19c

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] SDAP: Remove unused sdap_id_ctx from sdap_id_conn_cache_create

2015-11-02 Thread Lukas Slebodnik 
ehlo,

simple patch is attached.

LS
>From 08cea9235d8b51d0d8174969c73f93a17cf992e8 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik 
Date: Sat, 24 Oct 2015 00:02:01 +0200
Subject: [PATCH] SDAP: Remove unused sdap_id_ctx from
 sdap_id_conn_cache_create

---
 src/providers/ldap/ldap_common.c | 2 +-
 src/providers/ldap/sdap_id_op.c  | 1 -
 src/providers/ldap/sdap_id_op.h  | 1 -
 3 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/providers/ldap/ldap_common.c b/src/providers/ldap/ldap_common.c
index 
aa4c6cb851a5735e051ef2c024ca0171a4f61148..35de9c0a7929990fbf7a7a194fac3c8e0c9c31f2
 100644
--- a/src/providers/ldap/ldap_common.c
+++ b/src/providers/ldap/ldap_common.c
@@ -938,7 +938,7 @@ sdap_id_ctx_conn_add(struct sdap_id_ctx *id_ctx,
 conn->id_ctx = id_ctx;
 
 /* Create a connection cache */
-ret = sdap_id_conn_cache_create(conn, id_ctx, conn, >conn_cache);
+ret = sdap_id_conn_cache_create(conn, conn, >conn_cache);
 if (ret != EOK) {
 talloc_free(conn);
 return NULL;
diff --git a/src/providers/ldap/sdap_id_op.c b/src/providers/ldap/sdap_id_op.c
index 
0474a9cb7828ef43ef76cf6bebac077315296875..6ad7e8188dc6211907cac88e90e4feff5080695c
 100644
--- a/src/providers/ldap/sdap_id_op.c
+++ b/src/providers/ldap/sdap_id_op.c
@@ -102,7 +102,6 @@ static void sdap_id_op_connect_done(struct tevent_req 
*subreq);
 
 /* Create a connection cache */
 int sdap_id_conn_cache_create(TALLOC_CTX *memctx,
-  struct sdap_id_ctx *id_ctx,
   struct sdap_id_conn_ctx *id_conn,
   struct sdap_id_conn_cache** conn_cache_out)
 {
diff --git a/src/providers/ldap/sdap_id_op.h b/src/providers/ldap/sdap_id_op.h
index 
b808dd89aebb096b7163c10df39784a54b7e0b03..f7f230a734a4090af07c62d1884beefe5ebba750
 100644
--- a/src/providers/ldap/sdap_id_op.h
+++ b/src/providers/ldap/sdap_id_op.h
@@ -38,7 +38,6 @@ struct sdap_id_op;
 
 /* Create a connection cache */
 int sdap_id_conn_cache_create(TALLOC_CTX *memctx,
-  struct sdap_id_ctx *id_ctx,
   struct sdap_id_conn_ctx *id_conn,
   struct sdap_id_conn_cache** conn_cache_out);
 
-- 
2.5.0

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] SDAP: Remove unused sdap_id_ctx from sdap_id_conn_cache_create

2015-11-02 Thread Pavel Reichl 

On 11/02/2015 11:50 AM, Lukas Slebodnik wrote:

ehlo,

simple patch is attached.

LS



___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel



LGTM, compiles fine. I'll just postpone acking until CI results arrive...
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] SDAP: Remove unused sdap_id_ctx from sdap_id_conn_cache_create

2015-11-02 Thread Pavel Reichl 

On 11/02/2015 12:07 PM, Pavel Reichl wrote:

On 11/02/2015 11:50 AM, Lukas Slebodnik wrote:

ehlo,

simple patch is attached.

LS



___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel



LGTM, compiles fine. I'll just postpone acking until CI results arrive...


ACK ci passed: http://sssd-ci.duckdns.org/logs/job/31/80/summary.html

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel