Re: [SSSD] [PATCH] sbus codegen tests: free ctx

[Lukas Slebodnik]

On (02/10/15 08:54), Lukas Slebodnik wrote:
>On (01/10/15 15:25), Lukas Slebodnik wrote:
>>On (01/10/15 14:36), Pavel Březina wrote:
>>>https://fedorahosted.org/sssd/ticket/2759
>>
>>>From ad00807733ed3150d06615de035c6662af067673 Mon Sep 17 00:00:00 2001
>>>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
>>>Date: Thu, 1 Oct 2015 14:34:51 +0200
>>>Subject: [PATCH] sbus codegen tests: free ctx
>>>
>>>Memory context was not freed therefore we got stuck in tevent loop
>>>that mocks D-Bus.
>>>
>>>Resolves:
>>>https://fedorahosted.org/sssd/ticket/2759
>>>---
>>> src/tests/sbus_codegen_tests.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>>diff --git a/src/tests/sbus_codegen_tests.c b/src/tests/sbus_codegen_tests.c
>>>index 
>>>4637b92b84459041806bb5950e969e988716bec8..86424116bb01bb431137009a38416ce652001623
>>> 100644
>>>--- a/src/tests/sbus_codegen_tests.c
>>>+++ b/src/tests/sbus_codegen_tests.c
>>>@@ -1193,6 +1193,8 @@ START_TEST(test_get_array_dict_sas)
>>> ck_assert_str_eq(value, exp_values[1]);
>>> dbus_message_iter_next(_dict);
>>> }
>>>+
>>>+talloc_free(ctx);
>>> }
>>> END_TEST
>>
>>Seems that it fixed failure.
>>It's not vivible from output, but i finally recieved mail without
>>FAILURE in subject. I just need to test on rawhide. there was failures
>>as well.
>>
>Tests passed
>
>>http://sssd-ci.duckdns.org/logs/job/28/27/summary.html
>>Tentative ACK
>>
>ACK
>
>and pushed to master
>* e51143e3e67c70b86dd9a67cb7e802dd96f989e1
>
also pushed to 1-13 because we track 1.13 branch in out CI

sssd-1-13:
* 72745686b273fbb6847dafb097eac3b210b35335

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sbus codegen tests: free ctx

[Lukas Slebodnik]

On (01/10/15 15:25), Lukas Slebodnik wrote:
>On (01/10/15 14:36), Pavel Březina wrote:
>>https://fedorahosted.org/sssd/ticket/2759
>
>>From ad00807733ed3150d06615de035c6662af067673 Mon Sep 17 00:00:00 2001
>>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
>>Date: Thu, 1 Oct 2015 14:34:51 +0200
>>Subject: [PATCH] sbus codegen tests: free ctx
>>
>>Memory context was not freed therefore we got stuck in tevent loop
>>that mocks D-Bus.
>>
>>Resolves:
>>https://fedorahosted.org/sssd/ticket/2759
>>---
>> src/tests/sbus_codegen_tests.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>>diff --git a/src/tests/sbus_codegen_tests.c b/src/tests/sbus_codegen_tests.c
>>index 
>>4637b92b84459041806bb5950e969e988716bec8..86424116bb01bb431137009a38416ce652001623
>> 100644
>>--- a/src/tests/sbus_codegen_tests.c
>>+++ b/src/tests/sbus_codegen_tests.c
>>@@ -1193,6 +1193,8 @@ START_TEST(test_get_array_dict_sas)
>> ck_assert_str_eq(value, exp_values[1]);
>> dbus_message_iter_next(_dict);
>> }
>>+
>>+talloc_free(ctx);
>> }
>> END_TEST
>
>Seems that it fixed failure.
>It's not vivible from output, but i finally recieved mail without
>FAILURE in subject. I just need to test on rawhide. there was failures
>as well.
>
Tests passed

>http://sssd-ci.duckdns.org/logs/job/28/27/summary.html
>Tentative ACK
>
ACK

and pushed to master
* e51143e3e67c70b86dd9a67cb7e802dd96f989e1

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sbus codegen tests: free ctx

[Lukas Slebodnik]

On (01/10/15 14:36), Pavel Březina wrote:
>https://fedorahosted.org/sssd/ticket/2759

>From ad00807733ed3150d06615de035c6662af067673 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
>Date: Thu, 1 Oct 2015 14:34:51 +0200
>Subject: [PATCH] sbus codegen tests: free ctx
>
>Memory context was not freed therefore we got stuck in tevent loop
>that mocks D-Bus.
>
>Resolves:
>https://fedorahosted.org/sssd/ticket/2759
>---
> src/tests/sbus_codegen_tests.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/src/tests/sbus_codegen_tests.c b/src/tests/sbus_codegen_tests.c
>index 
>4637b92b84459041806bb5950e969e988716bec8..86424116bb01bb431137009a38416ce652001623
> 100644
>--- a/src/tests/sbus_codegen_tests.c
>+++ b/src/tests/sbus_codegen_tests.c
>@@ -1193,6 +1193,8 @@ START_TEST(test_get_array_dict_sas)
> ck_assert_str_eq(value, exp_values[1]);
> dbus_message_iter_next(_dict);
> }
>+
>+talloc_free(ctx);
> }
> END_TEST

BTW we had similar problem a year ago.

commit ba99aa00a305d298f65379e3add7536553c82455
Author: Pavel Březina 
Date:   Thu Jun 5 11:16:04 2014 +0200

sbus_codegen_tests: free memory context

The memory context was not freed and therefore a destructor that
closes connection to D-Bus and performs cleanup task was not executed.

Resolves:
https://fedorahosted.org/sssd/ticket/2347


What we can do to prevent such mistakes in future?

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sbus codegen tests: free ctx

[Lukas Slebodnik]

On (01/10/15 14:36), Pavel Březina wrote:
>https://fedorahosted.org/sssd/ticket/2759

>From ad00807733ed3150d06615de035c6662af067673 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
>Date: Thu, 1 Oct 2015 14:34:51 +0200
>Subject: [PATCH] sbus codegen tests: free ctx
>
>Memory context was not freed therefore we got stuck in tevent loop
>that mocks D-Bus.
>
>Resolves:
>https://fedorahosted.org/sssd/ticket/2759
>---
> src/tests/sbus_codegen_tests.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/src/tests/sbus_codegen_tests.c b/src/tests/sbus_codegen_tests.c
>index 
>4637b92b84459041806bb5950e969e988716bec8..86424116bb01bb431137009a38416ce652001623
> 100644
>--- a/src/tests/sbus_codegen_tests.c
>+++ b/src/tests/sbus_codegen_tests.c
>@@ -1193,6 +1193,8 @@ START_TEST(test_get_array_dict_sas)
> ck_assert_str_eq(value, exp_values[1]);
> dbus_message_iter_next(_dict);
> }
>+
>+talloc_free(ctx);
> }
> END_TEST

Seems that it fixed failure.
It's not vivible from output, but i finally recieved mail without
FAILURE in subject. I just need to test on rawhide. there was failures
as well.

http://sssd-ci.duckdns.org/logs/job/28/27/summary.html
Tentative ACK

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] sbus codegen tests: free ctx

[Pavel Březina]

https://fedorahosted.org/sssd/ticket/2759
>From ad00807733ed3150d06615de035c6662af067673 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
Date: Thu, 1 Oct 2015 14:34:51 +0200
Subject: [PATCH] sbus codegen tests: free ctx

Memory context was not freed therefore we got stuck in tevent loop
that mocks D-Bus.

Resolves:
https://fedorahosted.org/sssd/ticket/2759
---
 src/tests/sbus_codegen_tests.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/tests/sbus_codegen_tests.c b/src/tests/sbus_codegen_tests.c
index 4637b92b84459041806bb5950e969e988716bec8..86424116bb01bb431137009a38416ce652001623 100644
--- a/src/tests/sbus_codegen_tests.c
+++ b/src/tests/sbus_codegen_tests.c
@@ -1193,6 +1193,8 @@ START_TEST(test_get_array_dict_sas)
 ck_assert_str_eq(value, exp_values[1]);
 dbus_message_iter_next(_dict);
 }
+
+talloc_free(ctx);
 }
 END_TEST
 
-- 
1.9.3

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel