[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-06 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a 
per-client section

lslebodn commented:
"""
master:
* e8bad995fb1219df2a4fef8f55c80284c6ab36d3
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/295#issuecomment-327384091
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a 
per-client section

jhrozek commented:
"""
quote added. I'm away tomorrow, so please push yourself..
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/295#issuecomment-327290962
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a 
per-client section

lslebodn commented:
"""
BTW we might use at least element quote for `[secrets/users/123] ` 
`[secrets/users/$uid] ` `[secrets]`
or something like in application domain 
https://pagure.io/SSSD/sssd/blob/master/f/src/man/sssd.conf.5.xml#_2880

Otherwise LGTM
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/295#issuecomment-327235856
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread justin-stephenson 
  URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a 
per-client section

justin-stephenson commented:
"""
@jhrozek Looks good from my perspective.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/295#issuecomment-327229190
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a 
per-client section

jhrozek commented:
"""
@justin-stephenson does the new patch version look better?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/295#issuecomment-327217505
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-04 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a 
per-client section

jhrozek commented:
"""
A new version has been pushed, therefore removing the Changes requested label.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/295#issuecomment-327014532
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-07-27 Thread justin-stephenson 
  URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a 
per-client section

justin-stephenson commented:
"""
I think it could be useful to add something like "The secrets responder is 
configured with a global [secrets] section and an optional per-user 
[secrets/users/$uid] section in sssd.conf"  just under `CONFIGURATION OPTIONS` 
or in some easy to spot location. 

Also I wonder if it is worth mentioning herein the provider section(instead of 
only at the bottom of the man page) that the `provider = proxy` can only be 
used in the per-user section, not the global [secrets] section.

Otherwise looks okay from my side.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/295#issuecomment-318368728
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-07-19 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a 
per-client section

jhrozek commented:
"""
New patch pushed to this PR..
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/295#issuecomment-316427926
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-06-06 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/295
Title: #295: MAN: Document that the secrets provider can only be specified in a 
per-client section

fidencio commented:
"""
I'm adding the "Changes Requested" label per [@lslebodn's 
comment](https://github.com/SSSD/sssd/pull/295#discussion_r119560316).
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/295#issuecomment-306410211
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org