[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder jhrozek commented: """ * master: 3996e391054a1c02ab62e1541ae21a8204bd5d0a """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-319914348 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder fidencio commented: """ ACK! I'll add the "Accepted" label as soon as the CI passes. """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-319152525 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder fidencio commented: """ Removing the "Changes Requested" label as @amitkumar50 updates his patch. """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-318817958 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder fidencio commented: """ Adding the "Changes Requested". """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-318753252 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder amitkumar50 commented: """ @fidencio Done changes .. """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-318623610 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder fidencio commented: """ @amitkumar50, please, do not merge the branches. Just rebase your patches on top of git master. The workflow that I follow is: - fork the SSSD's github repo - clone the forked repo, as in your case would be: `git clone g...@github.com:amitkumar50/sssd.git` - add the upstream repo as a remote: `git remote add ghsssd https://github.com/SSSD/sssd` - update the remote: `git remote update ghsssd` - rebase my patches on top of the ghsssd/master: `git rebase ghsssd/master` With that workflow, merge is not needed and our git history is way cleaner. Please, try to do that and re-submit the patches. Feel free to ping me in case with have issues with the described workflow. """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-318607764 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder fidencio commented: """ Although we may not do it properly, we try our best to keep our files grouped together and alphabetically ordered. So, please, group together the lines containing src/shared/... instead of leaving them in the middle of the src/util/... files. Also, please, try to follow our commit template (https://github.com/SSSD/sssd/blob/master/.git-commit-template) when writing the commit message. I'm adding the "Changes Requested" label as per this review. """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-318360161 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder amitkumar50 commented: """ @lslebodn Thanks for comment.. I have removed `src/util/util_safealign.h`. it left on local Local repo mistakenly, Now pushed to fork. """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-317351251 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder fidencio commented: """ Removing the "Changes requested" label as @amitkumar50 updated the patchset. @amitkumar50 also said that "I don't have permissions" (for changing the label). :-\ """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-317350048 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder lslebodn commented: """ Is there a reason why `src/util/util_safealign.h` stil exist? """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-317207332 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-317205361 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#333][comment] Move header files consumed by both server and client to special folder
URL: https://github.com/SSSD/sssd/pull/333 Title: #333: Move header files consumed by both server and client to special folder centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/333#issuecomment-317205358 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
