[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-21 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

jhrozek commented:
"""
* master:

- 7892b2ac065654a2e14df218d20339908406f3f6  

  
- 2e4b13fd3f2519c4966153927f8eadb8844b70d5
- 6c4ca93e62da0a2850388c4ff04f04c5ffd97a0c
- 94ca189126f71afe6464a9b208c5a264c65ca4d9
- 5c9f5e460cb1e2f9ccb09563555cbbc4b0c992ef
- 9df6ad9546399a337d907b0b33bfbbcc6a7e588d
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-346134888
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-21 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

jhrozek commented:
"""
No, sorry, I thought I already put my ACK, but I think I did not mention it 
explicitly when I found the Coverity issues.

So, once again: ACK to Pavel's patches.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-346058691
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-21 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

pbrezina commented:
"""
Right. You can review them as well if you have a time.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-346048458
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-21 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

fidencio commented:
"""
Okay, so, in this PR the only missing part is @jhrozek's ack on @pbrezina's 
patches, right?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-346044652
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-21 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

pbrezina commented:
"""
Ack. Thank you.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-345995947
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-20 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

jhrozek commented:
"""
removed the changes requested label since new patches were pushed
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-345812922
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-19 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

jhrozek commented:
"""
one:
```
diff --git a/src/tools/sssctl/sssctl_access_report.c 
b/src/tools/sssctl/sssctl_access_report.c
index 25889f582..8cf1a8a87 100644
--- a/src/tools/sssctl/sssctl_access_report.c
+++ b/src/tools/sssctl/sssctl_access_report.c
@@ -282,15 +282,17 @@ static errno_t refresh_hbac_rules(struct sss_tool_ctx 
*tool_ctx,
 return ENOMEM;
 }
 
-path = sbus_opath_compose(tool_ctx, IFP_PATH_DOMAINS, domain->name);
+path = sbus_opath_compose(tmp_ctx, IFP_PATH_DOMAINS, domain->name);
 if (path == NULL) {
 printf(_("Out of memory!\n"));
-return ENOMEM;
+ret = ENOMEM;
+goto done;
 }
 
 error = sssctl_sifp_init(tool_ctx, &sifp);
 if (error != SSS_SIFP_OK) {
 sssctl_sifp_error(sifp, error, "Unable to connect to the InfoPipe");
+ret = EIO;
 goto done;
 }
```

two:
```
diff --git a/src/providers/ipa/ipa_access.c b/src/providers/ipa/ipa_access.c
index 110cde26b..de9f68170 100644
--- a/src/providers/ipa/ipa_access.c
+++ b/src/providers/ipa/ipa_access.c
@@ -711,7 +711,6 @@ ipa_refresh_access_rules_send(TALLOC_CTX *mem_ctx,
 struct ipa_refresh_access_rules_state *state;
 struct tevent_req *subreq;
 struct tevent_req *req;
-errno_t ret;
 
 DEBUG(SSSDBG_TRACE_FUNC, "Refreshing HBAC rules\n");
 
@@ -724,7 +723,7 @@ ipa_refresh_access_rules_send(TALLOC_CTX *mem_ctx,
 
 subreq = ipa_fetch_hbac_send(state, params->ev, params->be_ctx, 
access_ctx);
 if (subreq == NULL) {
-tevent_req_error(req, ret);
+tevent_req_error(req, ENOMEM);
 tevent_req_post(req, params->ev);
 return req;
 }
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-345524613
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-19 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

jhrozek commented:
"""
I squashed in two trivial patches for the Coverity issues..
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-345524521
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-17 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

jhrozek commented:
"""
Self-nack, coverity found some issues:
```
Error: UNINIT (CWE-457):
sssd-1.16.1/src/providers/ipa/ipa_access.c:714: var_decl: Declaring variable 
"ret" without initializer.
sssd-1.16.1/src/providers/ipa/ipa_access.c:727: uninit_use_in_call: Using 
uninitialized value "ret" when calling "_tevent_req_error".
#  725|   subreq = ipa_fetch_hbac_send(state, params->ev, params->be_ctx, 
access_ctx);
#  726|   if (subreq == NULL) {
#  727|-> tevent_req_error(req, ret);
#  728|   tevent_req_post(req, params->ev);
#  729|   return req;

Error: UNINIT (CWE-457):
sssd-1.16.1/src/tools/sssctl/sssctl_access_report.c:277: var_decl: Declaring 
variable "ret" without initializer.
sssd-1.16.1/src/tools/sssctl/sssctl_access_report.c:315: uninit_use: Using 
uninitialized value "ret".
#  313|   done:
#  314|   talloc_free(tmp_ctx);
#  315|-> return ret;
#  316|   }
#  317|   

Error: COMPILER_WARNING:
sssd-1.16.1/src/tools/sssctl/sssctl_access_report.c: scope_hint: In function 
'sssctl_ipa_access_report'
sssd-1.16.1/src/tools/sssctl/sssctl_access_report.c:340:8: warning: 'ret' may 
be used uninitialized in this function [-Wmaybe-uninitialized]
# if (ret != EOK) {
#^
#  338|   /* Run the pam account phase to make sure the rules are fetched 
by SSSD */
#  339|   ret = refresh_hbac_rules(tool_ctx, domain);
#  340|-> if (ret != EOK) {
#  341|   ERROR("Unable to refresh HBAC rules, using cached content\n");
#  342|   /* Non-fatal */
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-345361656
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-16 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

pbrezina commented:
"""
Ack to Jakub's part of the patch set.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-344927528
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-06 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

pbrezina commented:
"""
I pushed new patches with these two things fixed to my repo:
https://github.com/pbrezina/sssd/commits/sssctl

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-342116441
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-03 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

fidencio commented:
"""
@pbrezina: Do you plan to update this PR? As @jhrozek is not working Today, 
someone has to do that if we want to have it merged.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-341704588
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-03 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

pbrezina commented:
"""
On 11/03/2017 09:56 AM, fidencio wrote:
> *@fidencio* commented on this pull request.
>
> And I've also found something a little bit weird in the code.
>
> 
>
> In src/providers/ipa/ipa_access.c
> :
>
>> +DEBUG(SSSDBG_CRIT_FAILURE, "Unable to create tevent request!\n");
> +return NULL;
> +}
> +
> +subreq = ipa_fetch_hbac_send(state, params->ev, params->be_ctx, 
> access_ctx);
> +if (subreq == NULL) {
> +ret = ENOMEM;
> +goto done;
> +}
> +
> +tevent_req_set_callback(subreq, ipa_refresh_access_rules_done, req);
> +
> +ret = EAGAIN;
> +
> +done:
> +if (ret == EOK) {
>
> I've failed to understand how ret == EOK can happen here.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or
> mute the thread
> .
>

It can't. It's a copy/paste error.


"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-341682921
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-03 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report

fidencio commented:
"""
CI with the whitespace changes fixed: 
http://vm-031.{$abc}/logs/job/80/33/summary.html
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/424#issuecomment-341652442
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org