[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-10 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

lslebodn commented:
"""
master:
* 20d18db36096e3fa2636143a83a12a2e3a7f26d6
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/442#issuecomment-343581840
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-10 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

lslebodn commented:
"""
There were some random failures which I did not see before. But it worked well 
after re-executing problematic jobs 5 times. I hope it was not related :-)
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/442#issuecomment-343581633
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-10 Thread sumit-bose
  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

sumit-bose commented:
"""
@lslebodn, thanks, shall I set the Accepted flag or will you do it?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/442#issuecomment-343489393
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-10 Thread lslebodn
  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

lslebodn commented:
"""
@sumit-bose  I'm waiting for results of tests.

I'll push the patch after good results with your ACK

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/442#issuecomment-343483473
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-09 Thread sumit-bose
  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

sumit-bose commented:
"""
The patch makes sense and passes the CI (with the current exception on F27 and 
rawhide caused by the newer libldb). ACK

@fidencio, please let me know when you have the results of the regression test.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/442#issuecomment-343213441
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org


[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-08 Thread fidencio
  URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

fidencio commented:
"""
I've ran two downstream tests and both passed successfully:
- 2131430 (the one that found this regression)
- 2131429 (the one recommended by Jakub when the first patch was pushed)

If you guys have some idea about a better set of downstream tests to run, 
please, ping me in private with the link that I could clone.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/442#issuecomment-342749395
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org