[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ master: cf5357ae83cc9fe2240038b8bdccec2cb98991fc sssd-1-14: e1c2aead482cd4bf83a7fe5e68630a981389e82b If any of the maintainers think we should apply the patch to sssd-1-13 as well, please just cherry-pick the patch. """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-258108034 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups sumit-bose commented: """ Thank you for the patch, ACK """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-258102535 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ On Thu, Oct 27, 2016 at 08:48:46AM -0700, taupehat wrote: > @jhrozek I did not intend to remove anything from the last iteration. It's > possible that I used the editor wrong. Do I need to delete the prior pull > request and just create a new one with all changes in place? I normally just update the old commit and force-push the branch, github should be able to pick up the changes. Like this: vi path/to/file # hack, hack, hack # try to build the manpage with "make" to be sure the XML validates # when finished: git add /path/to/file git commit --amend git push $yourgithubfork $yourbranch --force """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256849283 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups taupehat commented: """ @jhrozek I did not intend to remove anything from the last iteration. It's possible that I used the editor wrong. Do I need to delete the prior pull request and just create a new one with all changes in place? """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256684610 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups sumit-bose commented: """ Just a small nitpick. Can you put the URL into a element like e.g. in https://github.com/SSSD/sssd/blob/master/src/man/sssd-ldap.5.xml#L1047 ? This will make sure the URL is formatted correctly with different output format. """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256583607 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ The documentation now looks correct, I just wonder why did you remove the example paragraph in the last iteration of the patch? IMO it would be useful.. """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256576929 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups amitkumar50 commented: """ Thanks Islebodn . Conflicts are resolved.. Posting What I did may help some one. Steps for 1. Getting source Code 2. Doing Code Changes 3. Running Integration Tests... [root@dlp] dnf -y install git [root@dlp] git config --global user.name "GIVENNAME SURNAME" [root@dlp] git config --global user.email "usern...@domain.com" [root@dlp] git config --global color.ui auto//Enable Syntax highlighting [root@dlp] dnf -y install meld//Tool for resolving Merge conflicts [root@dlp] git config --global merge.tool meld [root@dlp]# git clone https://git.fedorahosted.org/git/sssd.git [root@dlp]# cd sssd [root@dlp sssd]# . contrib/fedora/bashrc_sssd [root@dlp sssd]# dnf -y install rpm-build dnf-plugins-core libldb-devel [root@dlp sssd]# contrib/fedora/make_srpm.sh//Create source rpm [root@dlp sssd]# dnf builddep rpmbuild/SRPMS/sssd-*.src.rpm //Install sssd dependencies [root@dlp sssd]# reconfig && chmake make[1]: Leaving directory '/root/sssd/x86_64' [root@dlp x86_64]# pwd<=See Directory Changed Automatically /root/sssd/x86_64 [root@dlp x86_64]# [root@dlp x86_64]# dnf install -y openldap-servers fakeroot [root@dlp x86_64]# vim../src/providers/ipa/access_ipa.c //Do some changes... [root@dlp x86_64]# make [root@dlp x86_64]# make intgcheck === 119 passed in 302.77 seconds === make[1]: Leaving directory '/root/sssd/x86_64' [root@dlp x86_64]# """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256557508 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups lslebodn commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256445927 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups amitkumar50 commented: """ On latest clone of project. # make intgcheck checking for style of include used by make... GNU checking whether make supports nested variables... yes configure: error: source directory already configured; run "make distclean" there first Makefile:27077: recipe for target 'intgcheck-prepare' failed make: *** [intgcheck-prepare] Error 1 # """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256438804 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups taupehat commented: """ Could we get a rebuild on this? The previous failed with an error indicating trouble with the build host: make-intgcheck: Write failed: Broken pipe """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256436456 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups taupehat commented: """ Could we get a rebuild on this. The previous failed with an error indicating trouble with the build host: make-intgcheck: Write failed: Broken pipe """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256436456 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups abbra commented: """ Please use this URL: https://msdn.microsoft.com/en-us/library/cc223367.aspx """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-256004734 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ Additionally, if there is some link to MSDN explaining what the OID is, it would be nice to add that link """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-255976616 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups sumit-bose commented: """ Thank you for the patch. Given the related discussion in ticket https://fedorahosted.org/sssd/ticket/3218 I think it would help if you can add a sentence saying that becasue of the ':' characters in the filter part the option must always use the full format with DOM or FOREST and the name. """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-255974002 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-254876611 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-254872627 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
[SSSD] [sssd PR#60][comment] Document ad_access_filter search for nested groups
URL: https://github.com/SSSD/sssd/pull/60 Title: #60: Document ad_access_filter search for nested groups centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/60#issuecomment-254872632 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
