[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider jhrozek commented: """ * master: 2373df99b9ff166bcbdb0c69fe5e28bd32ea43bf 024c1b3ae419791b2382db97c1a3d4ceca3ad3cd fe48bc32d11743a6302d2a97d4120d787e68e37d 241594613f3ef3b428851a7866905e41c967b893 3b19518f18f59cc4fe23625ccfbede62992ef172 ded46b7b7bea7ed6454adca2179e2347609a3321 """ See the full comment at https://github.com/SSSD/sssd/pull/607#issuecomment-403794111 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/U7SYRY6SITALXH2C3UVRVGTDMWYXSAWU/
[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider fidencio commented: """ Done! """ See the full comment at https://github.com/SSSD/sssd/pull/607#issuecomment-403755674 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/JT6S3UAIGDL2UES6HSLW7OWRY54ET5XT/
[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider jhrozek commented: """ Thanks for the quick turnaround, now really the last thing, can you move the definition of is_files_provider from utils.c to domain_info_utils.c so that we keep all the domain-related functions on one place? (The declaration can stay in util.h). """ See the full comment at https://github.com/SSSD/sssd/pull/607#issuecomment-403749486 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/TCY6LNTNLBR5W5XG4RBYFDS7QUXQB5PR/
[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider fidencio commented: """ @jhrozek, patchset has been updated. """ See the full comment at https://github.com/SSSD/sssd/pull/607#issuecomment-403609462 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/MDOREY6OP24JZ4YSQAZOPETAIQPS26L5/
[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider jhrozek commented: """ I'm sorry to ask for a change in such a trivial patch, but I would prefer if the is_files_provider() function took a sss_domain_info parameter and not the string provider directly. The reason is that for a long time I wanted to make sss_domain_info opaque so I would prefer to not add another place that dereferences the domain directly. """ See the full comment at https://github.com/SSSD/sssd/pull/607#issuecomment-403604428 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/4WCOETTVSEIGZIJHFYKTJH2G4SZYVWTG/
[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider sumit-bose commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/pull/607#issuecomment-403466534 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/CQEKQ72HDL3NMZEG27J4P75JONMB4MV5/
[SSSD] [sssd PR#607][comment] Do not apply override_homedir and override_shell to files provider
URL: https://github.com/SSSD/sssd/pull/607 Title: #607: Do not apply override_homedir and override_shell to files provider fidencio commented: """ @jhrozek, thanks for the review. I've updated the patch set and your comments have been addressed. I've also added two patches atop of my original series introducing a "is_files_provider()" helper, as we're doing the check in a few different places. A CI run has ben fired and I'll add the results as soon as I get them. """ See the full comment at https://github.com/SSSD/sssd/pull/607#issuecomment-401705725 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fedorahosted.org/message/XOPZKATWB74HSW7OKBBODCX7YOAZHREB/
