[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask jhrozek commented: """ * master: df9e4802c060fc21d38f238265805092352e5c95 """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-444620631 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask pbrezina commented: """ Where is it implemented? Ack to the patches! """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-42609 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask thalman commented: """ > Where did you get this 60 seconds limit? I can not find it in original code: > > ```c > ad_dyndns_init: > if (period < 60) period = 60; > ``` I removed this part, I found that it is implemented elsewhere different way. """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-442846007 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask thalman commented: """ > Where did you get this 60 seconds limit? I can not find it in original code: > > ```c > ad_dyndns_init: > if (period < 60) period = 60; > ``` > > Also please remove `be_nsupdate_init_timer` as it is now only used in tests > and update tests. > Otherwise it looks good. I removed this part, I found that it is implemented elsewhere different way. """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-442846007 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask thalman commented: """ > Where did you get this 60 seconds limit? I can not find it in original code: > > ```c > ad_dyndns_init: > if (period < 60) period = 60; > ``` > > Also please remove `be_nsupdate_init_timer` as it is now only used in tests > and update tests. > Otherwise it looks good. I removed this part, I found that it is implemented elsewhere different way. """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-442846007 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask pbrezina commented: """ Please remove `be_nsupdate_init_timer` and the whole request `sdap_dyndns_timer_conn_send` from the code since it is not used anymore. However, you need to implement the functionality from `sdap_dyndns_timer_conn_send` in `ad_dyndns_update_send` (same for ipa). `sdap_dyndns_timer_conn_send` calls `sdap_id_op_send` which basically connects to LDAP and populates service attributes (e.g. `ctx->service->sdap->uri`). Since we do not need the other logic that is in `sdap_dyndns_timer_conn_send` you should call `sdap_id_op_send` directly in `ad_dyndns_update_send` and `ipa_dyndns_update_send`. """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-439344093 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask thalman commented: """ This limit was not in code, only in documentation (sssd-ad.5.xml). It is also inconsistent with sssd-ipa where there is no such limit and also default value for dyndns_refresh_interval is 0 in ipa (86400 for AD). """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-436253672 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#690][comment] DYNDNS: Convert dyndns timer to be_ptask
URL: https://github.com/SSSD/sssd/pull/690 Title: #690: DYNDNS: Convert dyndns timer to be_ptask pbrezina commented: """ Where did you get this 60 seconds limit? I can not find it in original code: ```c ad_dyndns_init: if (period < 60) period = 60; ``` Also please remove `be_nsupdate_init_timer` as it is now only used in tests and update tests. Otherwise it looks good. """ See the full comment at https://github.com/SSSD/sssd/pull/690#issuecomment-436246385 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
