[SSSD] [sssd PR#79][comment] LIBSSS_CONFIG: Drop libsss_config

2016-11-23 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config

fidencio commented:
"""
Suggestion taken and changes done, thanks for the review!
I've just pushed a new version of the patch.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/79#issuecomment-262529623
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#79][comment] LIBSSS_CONFIG: Drop libsss_config

2016-11-23 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config

lslebodn commented:
"""
There is a tiny conflict due to change in `src/external/configlib.m4`

There is also typo in commit message `lib_config` and IMHO it might be 
better to use "BUILD"
as a component in commit title rather then `LIBSSS_CONFIG`.

I think you also forgot to remove methods from 
`src/responder/ifp/ifp_iface.xml` which is used
for generating C code.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/79#issuecomment-262518170
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#79][comment] LIBSSS_CONFIG: Drop libsss_config

2016-11-11 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config

fidencio commented:
"""
Change done. Here is the fix up patch that in order to help the reviewer:
```
[ffidenci@cat sssd]$ git diff HEAD
diff --git a/contrib/ci/deps.sh b/contrib/ci/deps.sh
index 9a7098c..387ad1f 100644
--- a/contrib/ci/deps.sh
+++ b/contrib/ci/deps.sh
@@ -69,7 +69,6 @@ if [[ "$DISTRO_BRANCH" == -debian-* ]]; then
 docbook-xsl
 gettext
 krb5-config
-libaugeas-dev
 libc-ares-dev
 libcmocka-dev
 libcollection-dev
diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in
index 2917629..f0b61ec 100644
--- a/contrib/sssd.spec.in
+++ b/contrib/sssd.spec.in
@@ -583,7 +583,6 @@ be used by Python applications.
 Summary: The D-Bus responder of the SSSD
 Group: Applications/System
 License: GPLv3+
-BuildRequires: augeas-devel
 Requires: sssd-common = %{version}-%{release}
 
 %description dbus
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/79#issuecomment-259934118
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#79][comment] LIBSSS_CONFIG: Drop libsss_config

2016-11-11 Thread lslebodn 
  URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config

lslebodn commented:
"""
You forgot to rebuve build dependencies from spec file
and from ci.deps

contrib/ci/deps.sh:libaugeas-dev
contrib/sssd.spec.in:BuildRequires: augeas-devel

LS

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/79#issuecomment-259916977
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#79][comment] LIBSSS_CONFIG: Drop libsss_config

2016-11-10 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/79
Title: #79: LIBSSS_CONFIG: Drop libsss_config

fidencio commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/56/93/summary.html
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/79#issuecomment-259803386
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org