[SSSD] Re: [PATCH] DP: Print warning when the handler is not configured

2016-01-12 Thread Lukas Slebodnik
On (12/01/16 10:14), Jakub Hrozek wrote:
>Hi,
>
>the attached patch fixes a bug spotted by Lukas.

>From 0e2e48102aec5d7ffb15aeec23830e595bc91961 Mon Sep 17 00:00:00 2001
>From: Jakub Hrozek 
>Date: Mon, 11 Jan 2016 14:56:41 +0100
>Subject: [PATCH] DP: Print warning when the handler is not configured
>
>We would previously only print the generic warning, not the
>user-supplied error message.
>---
> src/providers/data_provider_be.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/src/providers/data_provider_be.c 
>b/src/providers/data_provider_be.c
>index 
>41680c73ae6305aa4c9379c7545ab88afdb7ba48..a653acd44153e0c5c433be7c6153011b4bdd0c4f
> 100644
>--- a/src/providers/data_provider_be.c
>+++ b/src/providers/data_provider_be.c
>@@ -272,7 +272,9 @@ static errno_t be_sbus_reply(struct sbus_request *sbus_req,
> safe_err_msg = safe_be_req_err_msg(err_msg, err_maj);
> 
> if (err_maj == DP_ERR_FATAL && err_min == ENODEV) {
>-DEBUG(SSSDBG_TRACE_LIBS, "Handler not configured\n");
>+DEBUG(SSSDBG_TRACE_LIBS,
>+  "Cannot handle request: %s",
>+  err_msg ? err_msg : "Handler not configured\n");
> } else {
> DEBUG(SSSDBG_TRACE_LIBS,
>   "Request processed. Returned [%s]:%d,%d,%s\n",

ACK

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org


[SSSD] Re: [PATCH] DP: Print warning when the handler is not configured

2016-01-12 Thread Jakub Hrozek
On Tue, Jan 12, 2016 at 10:14:42AM +0100, Jakub Hrozek wrote:
> Hi,
> 
> the attached patch fixes a bug spotted by Lukas.

* master: c42bd764452ecda95b7d8d3ce027c70b4ad5982c
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org


[SSSD] Re: [PATCH] DP: Print warning when the handler is not configured

2016-01-12 Thread Petr Cech

On 01/12/2016 10:14 AM, Jakub Hrozek wrote:

Hi,

the attached patch fixes a bug spotted by Lukas.


0001-DP-Print-warning-when-the-handler-is-not-configured.patch


From 0e2e48102aec5d7ffb15aeec23830e595bc91961 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek
Date: Mon, 11 Jan 2016 14:56:41 +0100
Subject: [PATCH] DP: Print warning when the handler is not configured


Hello,

CI tests: http://sssd-ci.duckdns.org/logs/job/35/37/summary.html

=> ACK

Regards
--
Petr^4 Cech
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org