Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-30 Thread Jakub Hrozek 
On Thu, Oct 29, 2015 at 03:45:52PM +0100, Pavel Březina wrote:
> On 10/29/2015 03:44 PM, Pavel Reichl wrote:
> >
> >>The patch is different iw we compare to the initial version.
> >>I think Dad deserves a credit so the author should be Dan.
> >>Will you prepare new patch or shoudl we change it before pushing.
> >>
> >>LS
> >
> >Patch with changed authorship attached.
> 
> Ack.

* master:
* beee2afce4eb18aca7f1268e0184c6c428e817a7
* bbe74392605808f6c7f1fda6e8c3c66fbfb035f4
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-30 Thread Lukas Slebodnik 
On (30/10/15 11:15), Jakub Hrozek wrote:
>On Thu, Oct 29, 2015 at 03:45:52PM +0100, Pavel Březina wrote:
>> On 10/29/2015 03:44 PM, Pavel Reichl wrote:
>> >
>> >>The patch is different iw we compare to the initial version.
>> >>I think Dad deserves a credit so the author should be Dan.
>> >>Will you prepare new patch or shoudl we change it before pushing.
>> >>
>> >>LS
>> >
>> >Patch with changed authorship attached.
>> 
>> Ack.
>
>* master:
>* beee2afce4eb18aca7f1268e0184c6c428e817a7
>* bbe74392605808f6c7f1fda6e8c3c66fbfb035f4

Required for #2736

sssd-1-13:
* 59d20aab85653e246093588f344a360e07f7b7b6
* 7f6f615e88289b60b1c01098dfb9cdef3103ebcd

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-29 Thread Pavel Březina 

On 10/29/2015 03:44 PM, Pavel Reichl wrote:



The patch is different iw we compare to the initial version.
I think Dad deserves a credit so the author should be Dan.
Will you prepare new patch or shoudl we change it before pushing.

LS


Patch with changed authorship attached.


Ack.

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-29 Thread Pavel Reichl 



The patch is different iw we compare to the initial version.
I think Dad deserves a credit so the author should be Dan.
Will you prepare new patch or shoudl we change it before pushing.

LS


Patch with changed authorship attached.
>From 3fc31691499fbee896d78e9f970cb4300d2fb2af Mon Sep 17 00:00:00 2001
From: Dan Lavu 
Date: Wed, 21 Oct 2015 12:28:37 +0200
Subject: [PATCH 1/2] sss_override: Add restart requirements to man page

---
 src/man/sss_override.8.xml | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
index 24c38936984946b3284d1523a7321a7e7f3d7982..5be4295183a78a9e6625b6689cb1003ce1c01541 100644
--- a/src/man/sss_override.8.xml
+++ b/src/man/sss_override.8.xml
@@ -34,8 +34,15 @@
 and groups. This change takes effect only on local machine.
 
 
-Overrides data are stored in SSSD cache. If the cache is deleted
-all local overrides are lost.
+Overrides data are stored in the SSSD cache. If the cache is deleted,
+all local overrides are lost. Please note that after the first
+override is created using any of the following
+user-add, group-add,
+user-import or
+group-import command. SSSD needs to be
+restarted to take effect.
+sss_override prints message when a restart is
+required.
 
 
 
-- 
2.4.3

>From 420adb29a8ab765516c6ef63c397fdff78391c9f Mon Sep 17 00:00:00 2001
From: Pavel Reichl 
Date: Thu, 22 Oct 2015 13:25:45 +0200
Subject: [PATCH 2/2] sss_override: Removed overrides might be in memcache

---
 src/man/sss_override.8.xml | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
index 5be4295183a78a9e6625b6689cb1003ce1c01541..6d6d28477c1304072484bc9def5461fe6332e8ed 100644
--- a/src/man/sss_override.8.xml
+++ b/src/man/sss_override.8.xml
@@ -80,7 +80,10 @@
 
 
 
-Remove user overrides.
+Remove user overrides. However be aware that overridden
+attributes might be returned from memory cache. Please
+see SSSD option memcache_timeout
+for more details.
 
 
 
@@ -150,7 +153,10 @@
 
 
 
-Remove group overrides.
+Remove group overrides. However be aware that overridden
+attributes might be returned from memory cache. Please
+see SSSD option memcache_timeout
+for more details.
 
 
 
-- 
2.4.3

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-23 Thread Lukas Slebodnik 
On (23/10/15 09:54), Pavel Reichl wrote:
>
>
>On 10/23/2015 09:10 AM, Lukas Slebodnik wrote:
>>On (22/10/15 13:35), Pavel Reichl wrote:
>>>On 10/22/2015 12:27 PM, Pavel Březina wrote:
On 10/22/2015 11:23 AM, Pavel Reichl wrote:
>
>
>On 10/21/2015 12:44 PM, Pavel Březina wrote:
>>On 10/21/2015 12:39 PM, Pavel Reichl wrote:
>>>Hello,
>>>
>>>while reviewing integration tests for sss_override Nick noticed that man
>>>page does not mention restart requirements. Attached patch (attempts to)
>>>address that.
>>>
>>>Thanks!
>>
>>LGTM
>
>Pavel it seems to me that after calling user-del SSSD must be also
>restarted, right?

No. But you may be hitting memory cache.
>>>
>>>Oh, thanks. Please see updated patches.
>>>
>>>
>>
>>>From 073155493b06f3805f282843143a4a020e63bfbf Mon Sep 17 00:00:00 2001
>>>From: Pavel Reichl 
>>>Date: Wed, 21 Oct 2015 12:28:37 +0200
>>>Subject: [PATCH 1/2] sss_override: Add restart requirements to man page
>>>
>>>---
>>>src/man/sss_override.8.xml | 11 +--
>>>1 file changed, 9 insertions(+), 2 deletions(-)
>>>
>>>diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
>>>index 
>>>24c38936984946b3284d1523a7321a7e7f3d7982..5be4295183a78a9e6625b6689cb1003ce1c01541
>>> 100644
>>>--- a/src/man/sss_override.8.xml
>>>+++ b/src/man/sss_override.8.xml
>>>@@ -34,8 +34,15 @@
>>> and groups. This change takes effect only on local machine.
>>> 
>>> 
>>>-Overrides data are stored in SSSD cache. If the cache is deleted
>>>-all local overrides are lost.
>>>+Overrides data are stored in the SSSD cache. If the cache is 
>>>deleted,
>>>+all local overrides are lost. Please note that after the first
>>>+override is created using any of the following
>>>+user-add, group-add,
>>>+user-import or
>>>+group-import command. SSSD needs to be
>>>+restarted to take effect.
>>>+sss_override prints message when a restart 
>>>is
>>>+required.
>>> 
>>> 
>>The patch is different iw we compare to the initial version.
>>I think Dad deserves a credit so the author should be Dan.
>>Will you prepare new patch or shoudl we change it before pushing.
>
>Change the author before pushing then.
>
>BTW do I deserve something for my effort? :-)
I filed many tickets for regressions and it's not tracked anywhere.
So, do I deserve something for my effort? :-)

>BTW2: second patch was not acked at all, first should be reacked.
>
I'm not the best person for review of man page changes.
So you might find reviewer somewhere else.

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-23 Thread Lukas Slebodnik 
On (22/10/15 13:35), Pavel Reichl wrote:
>On 10/22/2015 12:27 PM, Pavel Březina wrote:
>>On 10/22/2015 11:23 AM, Pavel Reichl wrote:
>>>
>>>
>>>On 10/21/2015 12:44 PM, Pavel Březina wrote:
On 10/21/2015 12:39 PM, Pavel Reichl wrote:
>Hello,
>
>while reviewing integration tests for sss_override Nick noticed that man
>page does not mention restart requirements. Attached patch (attempts to)
>address that.
>
>Thanks!

LGTM
>>>
>>>Pavel it seems to me that after calling user-del SSSD must be also
>>>restarted, right?
>>
>>No. But you may be hitting memory cache.
>
>Oh, thanks. Please see updated patches.
>
>

>From 073155493b06f3805f282843143a4a020e63bfbf Mon Sep 17 00:00:00 2001
>From: Pavel Reichl 
>Date: Wed, 21 Oct 2015 12:28:37 +0200
>Subject: [PATCH 1/2] sss_override: Add restart requirements to man page
>
>---
> src/man/sss_override.8.xml | 11 +--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
>diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
>index 
>24c38936984946b3284d1523a7321a7e7f3d7982..5be4295183a78a9e6625b6689cb1003ce1c01541
> 100644
>--- a/src/man/sss_override.8.xml
>+++ b/src/man/sss_override.8.xml
>@@ -34,8 +34,15 @@
> and groups. This change takes effect only on local machine.
> 
> 
>-Overrides data are stored in SSSD cache. If the cache is deleted
>-all local overrides are lost.
>+Overrides data are stored in the SSSD cache. If the cache is 
>deleted,
>+all local overrides are lost. Please note that after the first
>+override is created using any of the following
>+user-add, group-add,
>+user-import or
>+group-import command. SSSD needs to be
>+restarted to take effect.
>+sss_override prints message when a restart is
>+required.
> 
> 
The patch is different iw we compare to the initial version.
I think Dad deserves a credit so the author should be Dan.
Will you prepare new patch or shoudl we change it before pushing.

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-23 Thread Pavel Reichl 



On 10/23/2015 09:10 AM, Lukas Slebodnik wrote:

On (22/10/15 13:35), Pavel Reichl wrote:

On 10/22/2015 12:27 PM, Pavel Březina wrote:

On 10/22/2015 11:23 AM, Pavel Reichl wrote:



On 10/21/2015 12:44 PM, Pavel Březina wrote:

On 10/21/2015 12:39 PM, Pavel Reichl wrote:

Hello,

while reviewing integration tests for sss_override Nick noticed that man
page does not mention restart requirements. Attached patch (attempts to)
address that.

Thanks!


LGTM


Pavel it seems to me that after calling user-del SSSD must be also
restarted, right?


No. But you may be hitting memory cache.


Oh, thanks. Please see updated patches.





From 073155493b06f3805f282843143a4a020e63bfbf Mon Sep 17 00:00:00 2001
From: Pavel Reichl 
Date: Wed, 21 Oct 2015 12:28:37 +0200
Subject: [PATCH 1/2] sss_override: Add restart requirements to man page

---
src/man/sss_override.8.xml | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
index 
24c38936984946b3284d1523a7321a7e7f3d7982..5be4295183a78a9e6625b6689cb1003ce1c01541
 100644
--- a/src/man/sss_override.8.xml
+++ b/src/man/sss_override.8.xml
@@ -34,8 +34,15 @@
 and groups. This change takes effect only on local machine.
 
 
-Overrides data are stored in SSSD cache. If the cache is deleted
-all local overrides are lost.
+Overrides data are stored in the SSSD cache. If the cache is 
deleted,
+all local overrides are lost. Please note that after the first
+override is created using any of the following
+user-add, group-add,
+user-import or
+group-import command. SSSD needs to be
+restarted to take effect.
+sss_override prints message when a restart is
+required.
 
 

The patch is different iw we compare to the initial version.
I think Dad deserves a credit so the author should be Dan.
Will you prepare new patch or shoudl we change it before pushing.


Change the author before pushing then.

BTW do I deserve something for my effort? :-)
BTW2: second patch was not acked at all, first should be reacked.



LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-22 Thread Pavel Reichl 

On 10/21/2015 10:01 PM, Dan Lavu wrote:

Pavel,

Here you go, some minor grammatical edits.

---
diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
index 24c3893..785e264 100644
--- a/src/man/sss_override.8.xml
+++ b/src/man/sss_override.8.xml
@@ -34,8 +34,13 @@
  and groups. This change takes effect only on local machine.
  
  
-Overrides data are stored in SSSD cache. If the cache is deleted
-all local overrides are lost.
+Overrides data are stored in the SSSD cache. If the cache is 
deleted,
+all local overrides are lost. Please note that after the first
+override is created using the any of followinguser-add,
+group-add, user-import or group-import  command. SSSD 
needs
+to be restarted to take effect.
+sss_override prints message when a restart is
+required.
  
  
---



Thanks Dan! Updated patch attached.
>From 84eb0a5b6096a336b976df0b47b9ec3e1668042c Mon Sep 17 00:00:00 2001
From: Pavel Reichl 
Date: Wed, 21 Oct 2015 12:28:37 +0200
Subject: [PATCH] sss_override: Add restart requirements to man page

---
 src/man/sss_override.8.xml | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
index 24c38936984946b3284d1523a7321a7e7f3d7982..5be4295183a78a9e6625b6689cb1003ce1c01541 100644
--- a/src/man/sss_override.8.xml
+++ b/src/man/sss_override.8.xml
@@ -34,8 +34,15 @@
 and groups. This change takes effect only on local machine.
 
 
-Overrides data are stored in SSSD cache. If the cache is deleted
-all local overrides are lost.
+Overrides data are stored in the SSSD cache. If the cache is deleted,
+all local overrides are lost. Please note that after the first
+override is created using any of the following
+user-add, group-add,
+user-import or
+group-import command. SSSD needs to be
+restarted to take effect.
+sss_override prints message when a restart is
+required.
 
 
 
-- 
2.4.3

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-22 Thread Pavel Reichl 

On 10/22/2015 12:27 PM, Pavel Březina wrote:

On 10/22/2015 11:23 AM, Pavel Reichl wrote:



On 10/21/2015 12:44 PM, Pavel Březina wrote:

On 10/21/2015 12:39 PM, Pavel Reichl wrote:

Hello,

while reviewing integration tests for sss_override Nick noticed that man
page does not mention restart requirements. Attached patch (attempts to)
address that.

Thanks!


LGTM


Pavel it seems to me that after calling user-del SSSD must be also
restarted, right?


No. But you may be hitting memory cache.


Oh, thanks. Please see updated patches.


>From 073155493b06f3805f282843143a4a020e63bfbf Mon Sep 17 00:00:00 2001
From: Pavel Reichl 
Date: Wed, 21 Oct 2015 12:28:37 +0200
Subject: [PATCH 1/2] sss_override: Add restart requirements to man page

---
 src/man/sss_override.8.xml | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
index 24c38936984946b3284d1523a7321a7e7f3d7982..5be4295183a78a9e6625b6689cb1003ce1c01541 100644
--- a/src/man/sss_override.8.xml
+++ b/src/man/sss_override.8.xml
@@ -34,8 +34,15 @@
 and groups. This change takes effect only on local machine.
 
 
-Overrides data are stored in SSSD cache. If the cache is deleted
-all local overrides are lost.
+Overrides data are stored in the SSSD cache. If the cache is deleted,
+all local overrides are lost. Please note that after the first
+override is created using any of the following
+user-add, group-add,
+user-import or
+group-import command. SSSD needs to be
+restarted to take effect.
+sss_override prints message when a restart is
+required.
 
 
 
-- 
2.4.3

>From 8606d19c1d685b75123086963506e27eb7133b1c Mon Sep 17 00:00:00 2001
From: Pavel Reichl 
Date: Thu, 22 Oct 2015 13:25:45 +0200
Subject: [PATCH 2/2] sss_override: Removed overrides might be in memcache

---
 src/man/sss_override.8.xml | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml
index 5be4295183a78a9e6625b6689cb1003ce1c01541..6d6d28477c1304072484bc9def5461fe6332e8ed 100644
--- a/src/man/sss_override.8.xml
+++ b/src/man/sss_override.8.xml
@@ -80,7 +80,10 @@
 
 
 
-Remove user overrides.
+Remove user overrides. However be aware that overridden
+attributes might be returned from memory cache. Please
+see SSSD option memcache_timeout
+for more details.
 
 
 
@@ -150,7 +153,10 @@
 
 
 
-Remove group overrides.
+Remove group overrides. However be aware that overridden
+attributes might be returned from memory cache. Please
+see SSSD option memcache_timeout
+for more details.
 
 
 
-- 
2.4.3

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-22 Thread Pavel Reichl 



On 10/21/2015 12:44 PM, Pavel Březina wrote:

On 10/21/2015 12:39 PM, Pavel Reichl wrote:

Hello,

while reviewing integration tests for sss_override Nick noticed that man
page does not mention restart requirements. Attached patch (attempts to)
address that.

Thanks!


LGTM


Pavel it seems to me that after calling user-del SSSD must be also restarted, 
right?
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-22 Thread Pavel Březina 

On 10/22/2015 11:23 AM, Pavel Reichl wrote:



On 10/21/2015 12:44 PM, Pavel Březina wrote:

On 10/21/2015 12:39 PM, Pavel Reichl wrote:

Hello,

while reviewing integration tests for sss_override Nick noticed that man
page does not mention restart requirements. Attached patch (attempts to)
address that.

Thanks!


LGTM


Pavel it seems to me that after calling user-del SSSD must be also
restarted, right?


No. But you may be hitting memory cache.

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-21 Thread Dan Lavu 
Pavel, 

Here you go, some minor grammatical edits. 

--- 
diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml 
index 24c3893..785e264 100644 
--- a/src/man/sss_override.8.xml 
+++ b/src/man/sss_override.8.xml 
@@ -34,8 +34,13 @@ 
and groups. This change takes effect only on local machine. 
 
 
- Overrides data are stored in SSSD cache. If the cache is deleted 
- all local overrides are lost. 
+ Overrides data are stored in the SSSD cache. If the cache is deleted, 
+ all local overrides are lost. Please note that after the first 
+ override is created using the any of followinguser-add, 
+ group-add, user-import or group-import  command. SSSD needs 
+ to be restarted to take effect. 
+ sss_override prints message when a restart is 
+ required. 
 
 
--- 


- Original Message -

From: "Pavel Reichl" <prei...@redhat.com> 
To: sssd-devel@lists.fedorahosted.org, "Dan Lavu" <d...@redhat.com> 
Sent: Wednesday, October 21, 2015 1:08:29 PM 
Subject: Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page 

On 10/21/2015 12:39 PM, Pavel Reichl wrote: 
> Hello, 
> 
> while reviewing integration tests for sss_override Nick noticed that man page 
> does not mention restart requirements. Attached patch (attempts to) address 
> that. 
> 
> Thanks! 
> 
> 
> ___ 
> sssd-devel mailing list 
> sssd-devel@lists.fedorahosted.org 
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel 
> 
Dan, can you please check that proposed change is OK (at least from grammar 
point of view)? Thanks! 
___ 
sssd-devel mailing list 
sssd-devel@lists.fedorahosted.org 
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel 

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-21 Thread Pavel Reichl 

On 10/21/2015 12:39 PM, Pavel Reichl wrote:

Hello,

while reviewing integration tests for sss_override Nick noticed that man page 
does not mention restart requirements. Attached patch (attempts to) address 
that.

Thanks!


___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel


Dan, can you please check that proposed change is OK (at least from grammar 
point of view)? Thanks!
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

2015-10-21 Thread Pavel Březina 

On 10/21/2015 12:39 PM, Pavel Reichl wrote:

Hello,

while reviewing integration tests for sss_override Nick noticed that man
page does not mention restart requirements. Attached patch (attempts to)
address that.

Thanks!


LGTM

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel