[SSSD] [sssd PR#483][comment] Password change with two factor authentication

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/483
Title: #483: Password change with two factor authentication

jhrozek commented:
"""
* master:
 * a409fd64abcf67159a69eba7971231e0901b4e8c 

   
 * 011dc535406f5f2fca711380547669a27f0fc63c
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/483#issuecomment-359714676
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#483][closed] Password change with two factor authentication

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/483
Author: sumit-bose
 Title: #483: Password change with two factor authentication
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/483/head:pr483
git checkout pr483
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#483][+Pushed] Password change with two factor authentication

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/483
Title: #483: Password change with two factor authentication

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#483][comment] Password change with two factor authentication

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/483
Title: #483: Password change with two factor authentication

jhrozek commented:
"""
Coverity passed, CI "passed" (except a known failure because of valgrind on 
Debian) and downstream test for "ipa passwd" did not produce new failures 
either (job ID 2263884)

-> ACK
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/483#issuecomment-359709195
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#483][+Accepted] Password change with two factor authentication

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/483
Title: #483: Password change with two factor authentication

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#472][closed] Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/472
Author: fidencio
 Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's 
removed from IPA
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/472/head:pr472
git checkout pr472
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#472][+Pushed] Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's 
removed from IPA

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#472][comment] Remove the 'sshPublicKey' attribute from the cache when it's removed from IPA

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/472
Title: #472: Remove the 'sshPublicKey' attribute from the cache when it's 
removed from IPA

jhrozek commented:
"""
* master:
 * 56f015ef6a161e01681f79e4ea0d1b642f9737b4 

   
 * d0d3631242178f0b6fccf08baeca1a57f28771fa
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/472#issuecomment-359714138
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#501][opened] SDAP: Improve a DEBUG message about GC detection

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/501
Author: jhrozek
 Title: #501: SDAP: Improve a DEBUG message about GC detection
Action: opened

PR body:
"""
It was not entirely clear what the message means. We should improve the
debug message to make it clear that all or none attributes should be
replicated to the Global Catalog.

This patch can be reverted once we fix
https://pagure.io/SSSD/sssd/issue/3538 and only use the GC to look up the
entry DN, not the entry itself.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/501/head:pr501
git checkout pr501
From 7ad992e598a38d7558c480004a3868ef2cc12bff Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Tue, 23 Jan 2018 11:23:37 +0100
Subject: [PATCH] SDAP: Improve a DEBUG message about GC detection

It was not entirely clear what the message means. We should improve the
debug message to make it clear that all or none attributes should be
replicated to the Global Catalog.

This patch can be reverted once we fix
https://pagure.io/SSSD/sssd/issue/3538 and only use the GC to look up
the entry DN, not the entry itself.
---
 src/providers/ldap/sdap_async.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c
index a9bea4f80..ff7289a6c 100644
--- a/src/providers/ldap/sdap_async.c
+++ b/src/providers/ldap/sdap_async.c
@@ -2720,7 +2720,11 @@ static void sdap_gc_posix_check_done(struct tevent_req *subreq)
 
 /* Positive hit is definitve, no need to search other bases */
 if (state->has_posix == true) {
-DEBUG(SSSDBG_FUNC_DATA, "Server has POSIX attributes\n");
+DEBUG(SSSDBG_FUNC_DATA, "Server has POSIX attributes. Global Catalog will "
+"be used for user and group lookups. Note that if "
+"only a subset of POSIX attributes is present "
+"in GC, the non-replicated attributes are "
+"currently not read from the LDAP port\n");
 tevent_req_done(req);
 return;
 }
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#501][+Changes requested] SDAP: Improve a DEBUG message about GC detection

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/501
Title: #501: SDAP: Improve a DEBUG message about GC detection

Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#501][comment] SDAP: Improve a DEBUG message about GC detection

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/501
Title: #501: SDAP: Improve a DEBUG message about GC detection

jhrozek commented:
"""
Probably yes, please add Changes Requested.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/501#issuecomment-359749467
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#501][comment] SDAP: Improve a DEBUG message about GC detection

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/501
Title: #501: SDAP: Improve a DEBUG message about GC detection

fidencio commented:
"""
Adding the "Changes Requested" as it's probably worth to have a mention in the 
manpages as well.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/501#issuecomment-359749841
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#501][comment] SDAP: Improve a DEBUG message about GC detection

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/501
Title: #501: SDAP: Improve a DEBUG message about GC detection

fidencio commented:
"""
Out of curiosity, isn't worth a mention in the manpage as well?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/501#issuecomment-359749067
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#500][opened] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[jhrozek]

   URL: https://github.com/SSSD/sssd/pull/500
Author: jhrozek
 Title: #500: SYSDB: Read the ldb_message from loop's index counter when 
reading subdomain UPNs
Action: opened

PR body:
"""
Related to: https://pagure.io/SSSD/sssd/issue/3431

There was a typo in code that read the UPN suffixes from the subdomain
ldb_message. As a result, the UPN suffixes from the first domain were
always consulted for all domains.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/500/head:pr500
git checkout pr500
From e8e1deb50aa62b485194000b06327c2d46a3c6fe Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Tue, 23 Jan 2018 11:11:14 +0100
Subject: [PATCH] SYSDB: Read the ldb_message from loop's index counter when
 reading subdomain UPNs

Related to:
https://pagure.io/SSSD/sssd/issue/3431

There was a typo in code that read the UPN suffixes from the subdomain
ldb_message. As a result, the UPN suffixes from the first domain were
always consulted for all domains.
---
 src/db/sysdb_subdomains.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/db/sysdb_subdomains.c b/src/db/sysdb_subdomains.c
index 8964712b6..bdd5245f2 100644
--- a/src/db/sysdb_subdomains.c
+++ b/src/db/sysdb_subdomains.c
@@ -386,7 +386,7 @@ errno_t sysdb_update_subdomains(struct sss_domain_info *domain,
  SYSDB_SUBDOMAIN_FOREST, NULL);
 
 upn_suffixes = NULL;
-tmp_el = ldb_msg_find_element(res->msgs[0], SYSDB_UPN_SUFFIXES);
+tmp_el = ldb_msg_find_element(res->msgs[i], SYSDB_UPN_SUFFIXES);
 if (tmp_el != NULL) {
 upn_suffixes = sss_ldb_el_to_string_list(tmp_ctx, tmp_el);
 if (upn_suffixes == NULL) {
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#500][+Accepted] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading 
subdomain UPNs

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading 
subdomain UPNs

jhrozek commented:
"""
Yes, I'm still working on the downstream report for sssd-1-13. Sadly, even my 
latest backport didn't help, so I'll check if maybe this problem was the issue..
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/500#issuecomment-359894434
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#493][+Accepted] nss-idmap: check timed muted return code

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/493
Title: #493: nss-idmap: check timed muted return code

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#493][comment] nss-idmap: check timed muted return code

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/493
Title: #493: nss-idmap: check timed muted return code

jhrozek commented:
"""
CI: http://sssd-ci.$IDM:8080/job/ci/8310/
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/493#issuecomment-359909334
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#502][opened] BUILD: Add missing libs found by -Wl,-z,defs

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/502
Author: lslebodn
 Title: #502: BUILD: Add missing libs found by -Wl,-z,defs
Action: opened

PR body:
"""
It is not possible to fully build sssd with -Wl,-z,defs
because we are using sssd_be as a "library" in some cases

e.g.
src/providers/krb5/.libs/libsss_krb5_common_la-krb5_init_shared.o: In 
function `krb5_child_init':
src/providers/krb5/krb5_init_shared.c:38: undefined reference to 
`_dp_opt_get_bool'
src/providers/krb5/krb5_init_shared.c:47: undefined reference to 
`_dp_opt_get_string'
src/providers/krb5/krb5_init_shared.c:94: undefined reference to 
`_dp_opt_get_cstring'
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/502/head:pr502
git checkout pr502
From 46b1accf0741ad95af830add12cc4f7805166202 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik 
Date: Tue, 23 Jan 2018 11:48:10 +0100
Subject: [PATCH 1/2] BUILD: Add missing libs found by -Wl,-z,defs

It is not possible to fully build sssd with -Wl,-z,defs
because we are using sssd_be as a "library" in some cases

e.g.
src/providers/krb5/.libs/libsss_krb5_common_la-krb5_init_shared.o: In function `krb5_child_init':
src/providers/krb5/krb5_init_shared.c:38: undefined reference to `_dp_opt_get_bool'
src/providers/krb5/krb5_init_shared.c:47: undefined reference to `_dp_opt_get_string'
src/providers/krb5/krb5_init_shared.c:94: undefined reference to `_dp_opt_get_cstring'
---
 Makefile.am | 52 +++-
 1 file changed, 47 insertions(+), 5 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 5917bd904..09f9738f4 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1885,6 +1885,7 @@ libsss_test_common_la_LIBADD = \
 $(TALLOC_LIBS) \
 $(TEVENT_LIBS) \
 $(LDB_LIBS) \
+$(SSSD_INTERNAL_LTLIBS) \
 $(NULL)
 
 if HAVE_CHECK
@@ -1910,10 +1911,12 @@ libdlopen_test_providers_la_CFLAGS = \
 $(CHECK_CFLAGS) \
 -DUNIT_TESTING
 libdlopen_test_providers_la_LIBADD = \
+$(LIBADD_DL) \
 $(PAM_LIBS) \
 $(SSSD_LIBS) \
 $(CARES_LIBS) \
-$(SSSD_INTERNAL_LTLIBS)
+$(SSSD_INTERNAL_LTLIBS) \
+$(NULL)
 if BUILD_SYSTEMTAP
 libdlopen_test_providers_la_LIBADD += stap_generated_probes.lo
 endif
@@ -1936,7 +1939,9 @@ dist_noinst_DATA += src/sss_client/idmap/sss_nss_idmap.unit_tests
 
 libsss_ad_tests_la_SOURCES = $(libsss_ad_la_SOURCES)
 libsss_ad_tests_la_CFLAGS = $(libsss_ad_la_CFLAGS)
-libsss_ad_tests_la_LIBADD = $(libsss_ad_la_LIBADD)
+libsss_ad_tests_la_LIBADD = \
+$(libsss_ad_la_LIBADD) \
+$(NULL)
 libsss_ad_tests_la_LDFLAGS = \
 -shared \
 -rpath $(abs_top_builddir) \
@@ -3804,11 +3809,16 @@ libsss_ldap_common_la_CFLAGS = \
 $(KRB5_CFLAGS) \
 $(NULL)
 libsss_ldap_common_la_LIBADD = \
+$(TALLOC_LIBS) \
+$(TEVENT_LIBS) \
+$(LDB_LIBS) \
 $(OPENLDAP_LIBS) \
+$(DHASH_LIBS) \
 $(KRB5_LIBS) \
 libsss_krb5_common.la \
 libsss_idmap.la \
-libsss_util.la \
+libsss_certmap.la \
+$(SSSD_INTERNAL_LTLIBS) \
 $(NULL)
 libsss_ldap_common_la_LDFLAGS = \
 -avoid-version \
@@ -3852,9 +3862,14 @@ libsss_krb5_common_la_CFLAGS = \
 $(AM_CFLAGS) \
 $(KRB5_CFLAGS)
 libsss_krb5_common_la_LIBADD = \
+$(TALLOC_LIBS) \
+$(TEVENT_LIBS) \
+$(LDB_LIBS) \
 $(KEYUTILS_LIBS) \
 $(DHASH_LIBS) \
-$(KRB5_LIBS)
+$(KRB5_LIBS) \
+$(SSSD_INTERNAL_LTLIBS) \
+$(NULL)
 libsss_krb5_common_la_LDFLAGS = \
 -avoid-version
 
@@ -3865,6 +3880,8 @@ libsss_ldap_la_CFLAGS = \
 $(AM_CFLAGS) \
 $(OPENLDAP_CFLAGS)
 libsss_ldap_la_LIBADD = \
+$(TALLOC_LIBS) \
+$(TEVENT_LIBS) \
 $(OPENLDAP_LIBS) \
 $(SSSD_INTERNAL_LTLIBS) \
 libsss_ldap_common.la \
@@ -3886,7 +3903,15 @@ libsss_proxy_la_SOURCES = \
 libsss_proxy_la_CFLAGS = \
 $(AM_CFLAGS)
 libsss_proxy_la_LIBADD = \
-$(PAM_LIBS)
+$(LIBADD_DL) \
+$(TALLOC_LIBS) \
+$(TEVENT_LIBS) \
+$(LDB_LIBS) \
+$(PAM_LIBS) \
+$(DHASH_LIBS) \
+$(DBUS_LIBS) \
+$(SSSD_INTERNAL_LTLIBS) \
+$(NULL)
 libsss_proxy_la_LDFLAGS = \
 -avoid-version \
 -module
@@ -3901,7 +3926,11 @@ libsss_files_la_CFLAGS = \
 $(AM_CFLAGS) \
 $(NULL)
 libsss_files_la_LIBADD = \
+$(TALLOC_LIBS) \
+$(TEVENT_LIBS) \
+$(LDB_LIBS) \
 $(PAM_LIBS) \
+$(SSSD_INTERNAL_LTLIBS) \
 $(NULL)
 libsss_files_la_LDFLAGS = \
 -avoid-version \
@@ -3913,6 +3942,12 @@ libsss_simple_la_SOURCES = \
 src/providers/simple/simple_access.c
 libsss_simple_la_CFLAGS = \
 $(AM_CFLAGS)
+libsss_simple_la_LIBADD = \
+$(TALLOC_LIBS) \
+$(TEVENT_LIBS) \
+$(LDB_LIBS) \
+$(SSSD_INTERNAL_LTLIBS) \
+$(NULL)
 libsss_simple_la_LDFLAGS = \
 -avoid-version \
 -module
@@ -3924,8 +3959,10 @@ libsss_krb5_la_CFLAGS = \
 $(DHASH_CFLAGS) \
 $(KRB5_CFLAGS)
 libsss_krb5_la_LIBADD = \
+$(TALLOC_LIBS) \
 $(DHASH_LIBS) \
 $(KRB5_LIBS) \
+

[SSSD] [sssd PR#500][+Pushed] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading 
subdomain UPNs

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading 
subdomain UPNs

lslebodn commented:
"""
master:
* a8a3fcbf6f75a7c2665e8bf503c186e07dfab333

sssd-1-14:
* 76957f07f79fb30634d2b5b4bed56cf30307c079
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/500#issuecomment-359866512
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#500][closed] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

   URL: https://github.com/SSSD/sssd/pull/500
Author: jhrozek
 Title: #500: SYSDB: Read the ldb_message from loop's index counter when 
reading subdomain UPNs
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/500/head:pr500
git checkout pr500
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#502][comment] BUILD: Add missing libs found by -Wl,-z,defs

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/502
Title: #502: BUILD: Add missing libs found by -Wl,-z,defs

jhrozek commented:
"""
btw here is the specfile diff:
```
@@ -31,7 +31,7 @@
 
 Name: sssd
 Version: 1.16.0
-Release: 7%{?dist}
+Release: 7%{?dist}.2
 Group: Applications/System
 Summary: System Security Services Daemon
 License: GPLv3+
@@ -125,6 +125,9 @@ Patch0504: 
0504-KCM-temporary-increase-hardcoded-buffers.patch
 Patch0505: 0505-libnfsidmap-Use-public-plugin-header-file-if-availab.patch
 Patch0506: 0506-dyndns_tests-Fix-unit-test-with-missing-features-in-.patch
 
+Patch1000: 1000-BUILD-Add-missing-libs-found-by-Wl-z-defs.patch
+Patch1001: 1001-BUILD-Fix-using-of-libdlopen_test_providers.so-in-te.patch
+
 ### Dependencies ###
 
 Requires: sssd-common = %{version}-%{release}
@@ -684,7 +687,7 @@ done
 %build
 autoreconf -ivf
 
-export LDFLAGS="$(echo %{__global_ldflags} | sed -e 's/-Wl,-z,defs//')"
+#export LDFLAGS="$(echo %{__global_ldflags} | sed -e 's/-Wl,-z,defs//')"
 
 %configure \
 --with-test-dir=/dev/shm \
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/502#issuecomment-359913881
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#502][comment] BUILD: Add missing libs found by -Wl,-z,defs

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/502
Title: #502: BUILD: Add missing libs found by -Wl,-z,defs

jhrozek commented:
"""
How should I test this? I tried to revert (err, comment out) the sed that 
removes the -z flag from linker flags, then apply the two patches, but the 
fedora build on rawhide still failed with:
```
src/util/.libs/child_common.o: In function `write_pipe_handler':
/builddir/build/BUILD/sssd-1.16.0/src/util/child_common.c:389: undefined 
reference to `sss_atomic_io_s'
src/util/.libs/child_common.o: In function `read_pipe_handler':
/builddir/build/BUILD/sssd-1.16.0/src/util/child_common.c:473: undefined 
reference to `sss_atomic_io_s'
src/util/.libs/child_common.o: In function `sss_sigchld_init':
/builddir/build/BUILD/sssd-1.16.0/src/util/child_common.c:73: undefined 
reference to `sss_hash_create'
/builddir/build/BUILD/sssd-1.16.0/src/util/child_common.c:82: undefined 
reference to `BlockSignals'
src/util/.libs/child_common.o: In function `child_debug_init':
/builddir/build/BUILD/sssd-1.16.0/src/util/child_common.c:818: undefined 
reference to `sss_strerror'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:11039: libsss_child.la] Error
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/502#issuecomment-359913557
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#499][comment] dyndns_tests: Fix unit test with missing features in nsupdate

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/499
Title: #499: dyndns_tests: Fix unit test with missing features in nsupdate

jhrozek commented:
"""
I 'reverse-reviewed' the patch by reverting it from Fedora and indeed I saw:
```
FAIL dyndns-tests (exit status: 4)
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/499#issuecomment-359921796
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading 
subdomain UPNs

lslebodn commented:
"""
The patch does not apply to 1.13 branch (probably due to missing other patch :-)
IIRC we have some ticket which should fix UPN related bugs in 1.13.
So we should not forget to backport it.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/500#issuecomment-359867017
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#499][comment] dyndns_tests: Fix unit test with missing features in nsupdate

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/499
Title: #499: dyndns_tests: Fix unit test with missing features in nsupdate

jhrozek commented:
"""
I'll just run CI before Accepting the patch..
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/499#issuecomment-359922035
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#475][comment] AD: Use the right sdap_domain for the forest root

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/475
Title: #475: AD: Use the right sdap_domain for the forest root

lslebodn commented:
"""
Sure I'll run regression tests.

Sorry for late reply. BTW I had an assumption that current version of PR is not 
final
https://github.com/SSSD/sssd/pull/475#issuecomment-358618453.
It's my fault.
:wq
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/475#issuecomment-359796798
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[lslebodn]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading 
subdomain UPNs

lslebodn commented:
"""
That's a really nice catch.

LGTM We might file a ticket to extract 167 lines from for loop to separate 
function to prevent such issues. (if possible)

The but is there since 1.14.1 and I would prefer if @sumit-bose could double 
check 
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/500#issuecomment-359795924
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#500][comment] SYSDB: Read the ldb_message from loop's index counter when reading subdomain UPNs

[sumit-bose]

  URL: https://github.com/SSSD/sssd/pull/500
Title: #500: SYSDB: Read the ldb_message from loop's index counter when reading 
subdomain UPNs

sumit-bose commented:
"""
Yes, this is a typo which should be fixed.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/500#issuecomment-359815902
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#488][comment] Two fixes for certificates in idoverrides

[jhrozek]

  URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides

jhrozek commented:
"""
The patches need to be rebased but the rebase seems easy.

Can you help me check if I test the patches properly? I added a cert to default 
trust view (that's the only view that is relevant for this PR, right?), made 
sure the userCertificate was added to the object, removed the cert and made 
sure the userCertificate is gone.

But what about the mapped cert? What I see in my testing is that both the 
userCertificate and userMappedCertificate are added to the entry on the server, 
but not on the client. Is that expected?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/488#issuecomment-359938852
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org