Re: [Standards] Private Data storage discrepancy

2018-03-17 Thread JC Brand
On Fri, Mar 16, 2018 at 12:32:57PM +0100, Timothée Jaussoin wrote:
> Hi Guus,
> 
> Thanks for the work on Bookmarks :) Indeed that was, I think, a mistake.
> On my side I followed the structure of the 0048 
> (https://github.com/movim/moxl/blob/master/src/Moxl/Stanza/Bookmark.php#L30) 
> which, I
> think is more logical (the storage:bookmarks namespace is defined with this 
>  wrapper).

Like Timothée, in converse.js I also follow the structure of 0048.

As Christian Schudt wrote, it seems that with 0048 the idea is to include all
the bookmarks in one Pubsub item while with 0223 the assumption is that
there'll be one bookmark per item.

I interpret 0048's approach to mean that all bookmarks must be included when
any changes are communicated. That's what converse.js does.

JC

> Le vendredi 16 mars 2018 à 12:03 +0100, Guus der Kinderen a écrit :
> > Hello,
> > 
> > I'm working on migrating Bookmarks 
> > (https://xmpp.org/extensions/xep-0048.html) from Private XML Storage 
> > (https://xmpp.org/extensions/
> > xep-0049.html) to PEP (https://xmpp.org/extensions/xep-0223.html). I'm was 
> > surprised to find a difference between the Pubsub node
> > defined in 0048 example 3 (the published item root element is 'storage', 
> > that itself contains 'conference') and 0233's example 3 (the
> > published item root element is 'conference' directly, without the wrapping 
> > 'storage'). I expected those two examples to have the same
> > structure. What's going on there?
> > 
> > Regards,
> > 
> >   Guus
> > ___
> > Standards mailing list
> > Info: https://mail.jabber.org/mailman/listinfo/standards
> > Unsubscribe: standards-unsubscr...@xmpp.org
> > ___
> ___
> Standards mailing list
> Info: https://mail.jabber.org/mailman/listinfo/standards
> Unsubscribe: standards-unsubscr...@xmpp.org
> ___
___
Standards mailing list
Info: https://mail.jabber.org/mailman/listinfo/standards
Unsubscribe: standards-unsubscr...@xmpp.org
___


Re: [Standards] Private Data storage discrepancy

2018-03-16 Thread Christian Schudt

Hi,

 

although I can't give you a good answer here, this is probably related to the issue I mentioned during the Call for Experience.

 

It's unclear if a single pubsub item should contain only one bookmark or multiple. The one bookmark per item appraoch seems to be favoured by XEP-223:

"the history of all items published to the node provides a complete list of the user's bookmarks"

 

It would explain the lack of the storage element.

 

On the other side 0048 with 0049 uses the storage element with multiple bookmarks.

 

I think they want us to use one pubsub item per bookmark and then aggregate a list of bookmarks when using the pubsub approach.

And when using the 0049 approach we should use the "storage" wrapper element.

 

Technically it's also possible to store all bookmarks in a single pubsub item, but I don't think that was the authors' intention.

 

Nonetheless it's very confusing, how to properly store and aggregate a list of bookmarks.

 

-- Christian

 

 

Gesendet: Freitag, 16. März 2018 um 12:03 Uhr
Von: "Guus der Kinderen" 
An: "XMPP Standards" 
Betreff: [Standards] Private Data storage discrepancy



Hello,

 
I'm working on migrating Bookmarks (https://xmpp.org/extensions/xep-0048.html) from Private XML Storage (https://xmpp.org/extensions/xep-0049.html) to PEP (https://xmpp.org/extensions/xep-0223.html). I'm was surprised to find a difference between the Pubsub node defined in 0048 example 3 (the published item root element is 'storage', that itself contains 'conference') and 0233's example 3 (the published item root element is 'conference' directly, without the wrapping 'storage'). I expected those two examples to have the same structure. What's going on there?

 

Regards,

 

  Guus

___ Standards mailing list Info: https://mail.jabber.org/mailman/listinfo/standards Unsubscribe: standards-unsubscr...@xmpp.org ___



___
Standards mailing list
Info: https://mail.jabber.org/mailman/listinfo/standards
Unsubscribe: standards-unsubscr...@xmpp.org
___


Re: [Standards] Private Data storage discrepancy

2018-03-16 Thread Timothée Jaussoin
Hi Guus,

Thanks for the work on Bookmarks :) Indeed that was, I think, a mistake.
On my side I followed the structure of the 0048 
(https://github.com/movim/moxl/blob/master/src/Moxl/Stanza/Bookmark.php#L30) 
which, I
think is more logical (the storage:bookmarks namespace is defined with this 
 wrapper).

Regards,

Tim

Le vendredi 16 mars 2018 à 12:03 +0100, Guus der Kinderen a écrit :
> Hello,
> 
> I'm working on migrating Bookmarks 
> (https://xmpp.org/extensions/xep-0048.html) from Private XML Storage 
> (https://xmpp.org/extensions/
> xep-0049.html) to PEP (https://xmpp.org/extensions/xep-0223.html). I'm was 
> surprised to find a difference between the Pubsub node
> defined in 0048 example 3 (the published item root element is 'storage', that 
> itself contains 'conference') and 0233's example 3 (the
> published item root element is 'conference' directly, without the wrapping 
> 'storage'). I expected those two examples to have the same
> structure. What's going on there?
> 
> Regards,
> 
>   Guus
> ___
> Standards mailing list
> Info: https://mail.jabber.org/mailman/listinfo/standards
> Unsubscribe: standards-unsubscr...@xmpp.org
> ___
___
Standards mailing list
Info: https://mail.jabber.org/mailman/listinfo/standards
Unsubscribe: standards-unsubscr...@xmpp.org
___