Re: svn commit: r549586 - /incubator/stdcxx/trunk/src/exception.cpp
Farid Zaripov wrote: -Original Message- From: Martin Sebor [mailto:[EMAIL PROTECTED] Sent: Friday, June 22, 2007 3:02 AM To: stdcxx-dev@incubator.apache.org Subject: Re: svn commit: r549586 - /incubator/stdcxx/trunk/src/exception.cpp As you astutely observed in a previous discussion of the issue (at the link below), __rw_free_what_buf() should be extern _RWSTD_EXPORT, to be accessible by user in overridden __rw_throw_proc() otherwise there will be no way for users to avoid a leak in their replacement __rw_throw_proc(). http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg02192.htm l Yes, I remember that. This would be separated patch. Gotcha! Let's make sure to do that (or open a new issue). Also, while it's too late to fix it for this commit, the ChangeLog entry is missing a reference to the Jira issue number it resolves. Please remember to include it future changes, especially those to the library. The bug-fixing patch was here: http://svn.apache.org/viewvc?view=revrev=549584 Ah, okay. Anyway that patch is also related to the STDCXX-293, and is never late to correct the ChangeLog :) http://www.mail-archive.com/[EMAIL PROTECTED]/msg01322 .html We can change the ChangeLog this way but it won't make the Jira Subversion plugin pick up the reference to the patch so the patch won't show up on the Subversion Commits tab. See https://issues.apache.org/jira/browse/INFRA-624 Martin
Re: svn commit: r549586 - /incubator/stdcxx/trunk/src/exception.cpp
Farid Zaripov wrote: -Original Message- From: Martin Sebor [mailto:[EMAIL PROTECTED] Sent: Friday, June 22, 2007 6:07 PM To: stdcxx-dev@incubator.apache.org Subject: Re: svn commit: r549586 - /incubator/stdcxx/trunk/src/exception.cpp Yes, I remember that. This would be separated patch. Gotcha! Let's make sure to do that (or open a new issue). Already done: https://issues.apache.org/jira/browse/STDCXX-454 We can change the ChangeLog this way but it won't make the Jira Subversion plugin pick up the reference to the patch so the patch won't show up on the Subversion Commits tab. See https://issues.apache.org/jira/browse/INFRA-624 Now I understand. Btw why not to extend the JIRA interface to enable to add references to the svn manually? It would cetainly make a lot of sense. I added my vote to the open Jira issues that request this ability. You might want to do the same: http://jira.atlassian.com/browse/SVN-40 http://jira.atlassian.com/browse/SVN-138 Martin
Re: svn commit: r549586 - /incubator/stdcxx/trunk/src/exception.cpp
Hi Farid, As you astutely observed in a previous discussion of the issue (at the link below), __rw_free_what_buf() should be extern _RWSTD_EXPORT, to be accessible by user in overridden __rw_throw_proc() otherwise there will be no way for users to avoid a leak in their replacement __rw_throw_proc(). http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg02192.html Also, while it's too late to fix it for this commit, the ChangeLog entry is missing a reference to the Jira issue number it resolves. Please remember to include it future changes, especially those to the library. Thanks Martin [EMAIL PROTECTED] wrote: Author: faridz Date: Thu Jun 21 11:51:41 2007 New Revision: 549586 URL: http://svn.apache.org/viewvc?view=revrev=549586 Log: 2007-06-21 Farid Zaripov [EMAIL PROTECTED] * exception.cpp (__rw_throw): Don't delete allocated what string because of __rw_throw_proc() takes ownership and must delete what string. Modified: incubator/stdcxx/trunk/src/exception.cpp Modified: incubator/stdcxx/trunk/src/exception.cpp URL: http://svn.apache.org/viewvc/incubator/stdcxx/trunk/src/exception.cpp?view=diffrev=549586r1=549585r2=549586 == --- incubator/stdcxx/trunk/src/exception.cpp (original) +++ incubator/stdcxx/trunk/src/exception.cpp Thu Jun 21 11:51:41 2007 @@ -827,9 +827,6 @@ // throw_proc takes ownership of allocated string __rw_throw_proc (id, what); - -// if throw_proc returns, delete allocated what string -__rw_free_what_buf (what); } }
