Re: [PATCH] Fix spurious failure of AC_STAT64 test
On Mon, Jan 25, 2010 at 11:38:09AM +0100, Andreas Schwab wrote: Here is a better patch, pre-POSIX systems might need sys/types.h before sys/stat.h. I suppose the proposed change fixes a real spurious failure I'm not aware of, but I'd like to know for sure. I'm sorry, but I have to repeat the same question I've already asked before: what is the kernel version and architecture where asm/stat.h isn't self-contained? * acinclude.m4 (AC_STAT64): Include sys/types.h first. -- ldv pgp9XH717sWOl.pgp Description: PGP signature -- The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com___ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
Re: [PATCH] Fix spurious failure of AC_STAT64 test
Dmitry V. Levin ldv-u2l5PoMzF/vg9huczpv...@public.gmane.org writes: On Mon, Jan 25, 2010 at 11:38:09AM +0100, Andreas Schwab wrote: Here is a better patch, pre-POSIX systems might need sys/types.h before sys/stat.h. I suppose the proposed change fixes a real spurious failure I'm not aware of, but I'd like to know for sure. I'm sorry, but I have to repeat the same question I've already asked before: what is the kernel version and architecture where asm/stat.h isn't self-contained? $ grep ino_t --include=stat.h -r arch arch/mips/include/asm/stat.h: ino_t st_ino; arch/parisc/include/asm/stat.h: ino_t st_ino; /* 32 bits */ arch/parisc/include/asm/stat.h: ino_t __unused3; /* network */ arch/parisc/include/asm/stat.h: ino_t st_ino; /* 32 bits */ arch/parisc/include/asm/stat.h: ino_t __unused3; /* network */ arch/powerpc/include/asm/stat.h:ino_t st_ino; arch/sparc/include/asm/stat.h: ino_t st_ino; arch/sparc/include/asm/stat.h: ino_t st_ino; Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. -- The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com ___ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
Re: [PATCH] Fix spurious failure of AC_STAT64 test
On Wed, Jan 27, 2010 at 12:51:01AM +0100, Andreas Schwab wrote: Dmitry V. Levin ldv-u2l5PoMzF/vg9huczpv...@public.gmane.org writes: On Mon, Jan 25, 2010 at 11:38:09AM +0100, Andreas Schwab wrote: Here is a better patch, pre-POSIX systems might need sys/types.h before sys/stat.h. I suppose the proposed change fixes a real spurious failure I'm not aware of, but I'd like to know for sure. I'm sorry, but I have to repeat the same question I've already asked before: what is the kernel version and architecture where asm/stat.h isn't self-contained? $ grep ino_t --include=stat.h -r arch arch/mips/include/asm/stat.h: ino_t st_ino; arch/parisc/include/asm/stat.h: ino_t st_ino; /* 32 bits */ arch/parisc/include/asm/stat.h: ino_t __unused3; /* network */ arch/parisc/include/asm/stat.h: ino_t st_ino; /* 32 bits */ arch/parisc/include/asm/stat.h: ino_t __unused3; /* network */ arch/powerpc/include/asm/stat.h:ino_t st_ino; arch/sparc/include/asm/stat.h: ino_t st_ino; arch/sparc/include/asm/stat.h: ino_t st_ino; OK, it's pretty obvious now, please apply the fix. -- ldv pgpBxO4EHQk5K.pgp Description: PGP signature -- The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com___ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
Re: [PATCH] Fix spurious failure of AC_STAT64 test
Here is a better patch, pre-POSIX systems might need sys/types.h before sys/stat.h. Andreas. From 3de3d6bf5abdf410110aed1f844992304f6ae8b9 Mon Sep 17 00:00:00 2001 From: Andreas Schwab sch...@redhat.com Date: Mon, 25 Jan 2010 11:32:48 +0100 Subject: [PATCH] Fix spurious failure of AC_STAT64 test * acinclude.m4 (AC_STAT64): Include sys/types.h first. --- acinclude.m4 |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 5473b69..da66c64 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -196,7 +196,8 @@ dnl ### A macro to determine whether stat64 is defined. AC_DEFUN([AC_STAT64], [AC_MSG_CHECKING(for stat64 in (asm|sys)/stat.h) AC_CACHE_VAL(ac_cv_type_stat64, -[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#ifdef LINUX +[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include sys/types.h +#ifdef LINUX #include linux/types.h #include asm/stat.h #else -- 1.6.6 -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E And now for something completely different. -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev ___ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
Re: [PATCH] Fix spurious failure of AC_STAT64 test
On Sun, Jan 24, 2010 at 05:32:24PM +, Andreas Schwab wrote: Sorry, I don't understand the sentence. In the AC_STAT64 test, linux/types.h is included before asm/stat.h, and your proposal is to replace linux/types.h with sys/types.h. I'm not sure that any additional headers have to be included before asm/stat.h at all, because it compiles alone: $ echo '#include asm/stat.h' |gcc -xc -c - -o /dev/null -- ldv pgpHeDqAtHF9E.pgp Description: PGP signature -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev___ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
Re: [PATCH] Fix spurious failure of AC_STAT64 test
On Sun, Jan 24, 2010 at 11:08:47PM +0100, Andreas Schwab wrote: $ echo '#include asm/stat.h' |gcc -xc -c - -o /dev/null In file included from stdin:1: /usr/include/asm/stat.h:31: error: expected specifier-qualifier-list before ‘ino_t’ OK, just for the record, what is the kernel version and architecture where asm/stat.h isn't self-contained? -- ldv pgp8HWVs7cW86.pgp Description: PGP signature -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev___ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
Re: [PATCH] Fix spurious failure of AC_STAT64 test
On Sun, 24 Jan 2010 00:20:04 +0100, Andreas Schwab wrote: * acinclude.m4 (AC_STAT64): Include sys/stat.h instead of linux/stat.h. ... [AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#ifdef LINUX -#include linux/types.h +#include sys/types.h #include asm/stat.h #else The ChangeLog entry does not correspond to the patch content. Regards, Jan -- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Conference attendees to learn about information security's most important issues through interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev ___ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
