Re: Close to RC2?
I think the underlying issue was that the DBCP is used to implement the GenericDataSource, which was not deprecated in the last release. http://jakarta.apache.org/struts/doc-1.0.2/api/org/apache/struts/util/GenericDataSource.html I suppose we could fall back to the original implementation, but that was not as good as the DBCP and seems like a drastic change. We might consider making the type required now and deprecating GDS in this release, to leave our options open. At this point, I think the DataSource manager has become a rather neat tool and could even standalone as a way to manage connections to various datasources. But now that there is a DBCP in the Commons, we can prepare to let people acquire that themselves. But for now, it seems like we're stuck :( -T. David Graham wrote: Actually, my original thought was to get rid of DBCP because it's a problem child dependency and not everyone needs it. We could leave the data-sources element because it's useful to those who need it but they would have to provide the implementation class (change the type attribute to required). But we could just leave everything how it is and only use released versions of DBCP after they get the next release of it out. Dave On Mon, 24 Mar 2003, David Graham wrote: Date: Mon, 24 Mar 2003 12:38:01 -0700 From: David Graham [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: Close to RC2? The commons-pool dependency is indeed inherited from commons-dbcp. We can't actually remove GenericDataSource (in 1.1), because it wasn't deprecated in 1.0 -- we'll be able to clean that up next time around if we want (but we should warn people in the struts-config DTD that the whole data-sources element will go away, if that's really what we want to do). Why would the data-sources element have to go away just because GenericDataSource is removed? What would we use instead to implement the data sources? The original question (as I understood it) was how to get rid of commons-pool, which would also require getting rid of commons-dbcp and therefore eliminating the org.apache.commons.dbcp.BasicDataSource implementation class. Craig David Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Struts in Action http://husted.com/struts/book.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Close to RC2?
Well long term ( in order to jettison non MVC features of Struts, which there are a few it could jetison to commons, etc.) , I think data source should not be in Struts-confin, deprecated. (see the confusion in user list + containers provide data source pool) So if the old code works. hack it (with old code) and deprecate maybe? Just a suggestion. .V Ted Husted wrote: I think the underlying issue was that the DBCP is used to implement the GenericDataSource, which was not deprecated in the last release. http://jakarta.apache.org/struts/doc-1.0.2/api/org/apache/struts/util/GenericDataSource.html I suppose we could fall back to the original implementation, but that was not as good as the DBCP and seems like a drastic change. We might consider making the type required now and deprecating GDS in this release, to leave our options open. At this point, I think the DataSource manager has become a rather neat tool and could even standalone as a way to manage connections to various datasources. But now that there is a DBCP in the Commons, we can prepare to let people acquire that themselves. But for now, it seems like we're stuck :( -T. David Graham wrote: Actually, my original thought was to get rid of DBCP because it's a problem child dependency and not everyone needs it. We could leave the data-sources element because it's useful to those who need it but they would have to provide the implementation class (change the type attribute to required). But we could just leave everything how it is and only use released versions of DBCP after they get the next release of it out. Dave On Mon, 24 Mar 2003, David Graham wrote: Date: Mon, 24 Mar 2003 12:38:01 -0700 From: David Graham [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: Close to RC2? The commons-pool dependency is indeed inherited from commons-dbcp. We can't actually remove GenericDataSource (in 1.1), because it wasn't deprecated in 1.0 -- we'll be able to clean that up next time around if we want (but we should warn people in the struts-config DTD that the whole data-sources element will go away, if that's really what we want to do). Why would the data-sources element have to go away just because GenericDataSource is removed? What would we use instead to implement the data sources? The original question (as I understood it) was how to get rid of commons-pool, which would also require getting rid of commons-dbcp and therefore eliminating the org.apache.commons.dbcp.BasicDataSource implementation class. Craig David Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Close to RC2?
Somewhere in this thread my original intention was lost. I never wanted to remove DBCP for 1.1; I was proposing this for 1.2. GenericDataSource is already deprecated. I think a reasonable approach is to make the data-source type= attribute required and let people download DBCP or anything else themselves. Then we won't be dependent on DBCP or Pool which will make future releases easier. David From: Ted Husted [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Close to RC2? Date: Tue, 25 Mar 2003 04:44:44 -0500 I think the underlying issue was that the DBCP is used to implement the GenericDataSource, which was not deprecated in the last release. http://jakarta.apache.org/struts/doc-1.0.2/api/org/apache/struts/util/GenericDataSource.html I suppose we could fall back to the original implementation, but that was not as good as the DBCP and seems like a drastic change. We might consider making the type required now and deprecating GDS in this release, to leave our options open. At this point, I think the DataSource manager has become a rather neat tool and could even standalone as a way to manage connections to various datasources. But now that there is a DBCP in the Commons, we can prepare to let people acquire that themselves. But for now, it seems like we're stuck :( -T. David Graham wrote: Actually, my original thought was to get rid of DBCP because it's a problem child dependency and not everyone needs it. We could leave the data-sources element because it's useful to those who need it but they would have to provide the implementation class (change the type attribute to required). But we could just leave everything how it is and only use released versions of DBCP after they get the next release of it out. Dave On Mon, 24 Mar 2003, David Graham wrote: Date: Mon, 24 Mar 2003 12:38:01 -0700 From: David Graham [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: Close to RC2? The commons-pool dependency is indeed inherited from commons-dbcp. We can't actually remove GenericDataSource (in 1.1), because it wasn't deprecated in 1.0 -- we'll be able to clean that up next time around if we want (but we should warn people in the struts-config DTD that the whole data-sources element will go away, if that's really what we want to do). Why would the data-sources element have to go away just because GenericDataSource is removed? What would we use instead to implement the data sources? The original question (as I understood it) was how to get rid of commons-pool, which would also require getting rid of commons-dbcp and therefore eliminating the org.apache.commons.dbcp.BasicDataSource implementation class. Craig David Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Struts in Action http://husted.com/struts/book.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Close to RC2?
Let's minimize the change events and make the data-source type required when we actually remove GenericDataSource (in whatever future release). As long as it is still in the JAR, we might as well use it for the default. David Graham wrote: Somewhere in this thread my original intention was lost. I never wanted to remove DBCP for 1.1; I was proposing this for 1.2. GenericDataSource is already deprecated. I think a reasonable approach is to make the data-source type= attribute required and let people download DBCP or anything else themselves. Then we won't be dependent on DBCP or Pool which will make future releases easier. David From: Ted Husted [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Close to RC2? Date: Tue, 25 Mar 2003 04:44:44 -0500 I think the underlying issue was that the DBCP is used to implement the GenericDataSource, which was not deprecated in the last release. http://jakarta.apache.org/struts/doc-1.0.2/api/org/apache/struts/util/GenericDataSource.html I suppose we could fall back to the original implementation, but that was not as good as the DBCP and seems like a drastic change. We might consider making the type required now and deprecating GDS in this release, to leave our options open. At this point, I think the DataSource manager has become a rather neat tool and could even standalone as a way to manage connections to various datasources. But now that there is a DBCP in the Commons, we can prepare to let people acquire that themselves. But for now, it seems like we're stuck :( -T. David Graham wrote: Actually, my original thought was to get rid of DBCP because it's a problem child dependency and not everyone needs it. We could leave the data-sources element because it's useful to those who need it but they would have to provide the implementation class (change the type attribute to required). But we could just leave everything how it is and only use released versions of DBCP after they get the next release of it out. Dave On Mon, 24 Mar 2003, David Graham wrote: Date: Mon, 24 Mar 2003 12:38:01 -0700 From: David Graham [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: Close to RC2? The commons-pool dependency is indeed inherited from commons-dbcp. We can't actually remove GenericDataSource (in 1.1), because it wasn't deprecated in 1.0 -- we'll be able to clean that up next time around if we want (but we should warn people in the struts-config DTD that the whole data-sources element will go away, if that's really what we want to do). Why would the data-sources element have to go away just because GenericDataSource is removed? What would we use instead to implement the data sources? The original question (as I understood it) was how to get rid of commons-pool, which would also require getting rid of commons-dbcp and therefore eliminating the org.apache.commons.dbcp.BasicDataSource implementation class. Craig David Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Struts in Action http://husted.com/struts/book.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Struts in Action http://husted.com/struts/book.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Close to RC2?
I agree. When we remove deprecated stuff in 1.2 would be a good time to make this change. David Let's minimize the change events and make the data-source type required when we actually remove GenericDataSource (in whatever future release). As long as it is still in the JAR, we might as well use it for the default. David Graham wrote: Somewhere in this thread my original intention was lost. I never wanted to remove DBCP for 1.1; I was proposing this for 1.2. GenericDataSource is already deprecated. I think a reasonable approach is to make the data-source type= attribute required and let people download DBCP or anything else themselves. Then we won't be dependent on DBCP or Pool which will make future releases easier. David From: Ted Husted [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: Re: Close to RC2? Date: Tue, 25 Mar 2003 04:44:44 -0500 I think the underlying issue was that the DBCP is used to implement the GenericDataSource, which was not deprecated in the last release. http://jakarta.apache.org/struts/doc-1.0.2/api/org/apache/struts/util/GenericDataSource.html I suppose we could fall back to the original implementation, but that was not as good as the DBCP and seems like a drastic change. We might consider making the type required now and deprecating GDS in this release, to leave our options open. At this point, I think the DataSource manager has become a rather neat tool and could even standalone as a way to manage connections to various datasources. But now that there is a DBCP in the Commons, we can prepare to let people acquire that themselves. But for now, it seems like we're stuck :( -T. David Graham wrote: Actually, my original thought was to get rid of DBCP because it's a problem child dependency and not everyone needs it. We could leave the data-sources element because it's useful to those who need it but they would have to provide the implementation class (change the type attribute to required). But we could just leave everything how it is and only use released versions of DBCP after they get the next release of it out. Dave On Mon, 24 Mar 2003, David Graham wrote: Date: Mon, 24 Mar 2003 12:38:01 -0700 From: David Graham [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: Close to RC2? The commons-pool dependency is indeed inherited from commons-dbcp. We can't actually remove GenericDataSource (in 1.1), because it wasn't deprecated in 1.0 -- we'll be able to clean that up next time around if we want (but we should warn people in the struts-config DTD that the whole data-sources element will go away, if that's really what we want to do). Why would the data-sources element have to go away just because GenericDataSource is removed? What would we use instead to implement the data sources? The original question (as I understood it) was how to get rid of commons-pool, which would also require getting rid of commons-dbcp and therefore eliminating the org.apache.commons.dbcp.BasicDataSource implementation class. Craig David Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Struts in Action http://husted.com/struts/book.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ted Husted, Struts in Action http://husted.com/struts/book.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ MSN 8 with e-mail virus protection service: 2 months FREE* http://join.msn.com/?page=features/virus - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Close to RC2?
Ted == Ted Husted [EMAIL PROTECTED] writes: Ted A frequent comment about RC1 is that it did not use the released versions of Ted the Commons packages. Ted I think for RC2 to be a likely release candidate and enable us to go from Ted there to a final release, we will need to lock down the Commons dependencies Ted first. Ted Otherwise, I believe we would just be preordaining a RC3 that deployed the Ted final versions of the Commons packages. Ted So, I would say that as soon as the requisite Commons packages are released, we Ted would be good to go to RC2 (assuming that we have kept our own tickets trimmed, Ted as we have so far). +1 on that amendment. -- === David M. Karr ; Java/J2EE/XML/Unix/C++ [EMAIL PROTECTED] ; SCJP; SCWCD - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Close to RC2?
On Mon, 24 Mar 2003, David Graham wrote: Date: Mon, 24 Mar 2003 07:41:18 -0700 From: David Graham [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: Close to RC2? I was thinking that 1.1 final would come after RC2 with the final versions of dependent jars. Do we have a direct dependency on commons-pool or is that included to support DBCP? I would like to remove the dependency on those packages for 1.2 as they won't be needed to support the deprecated GenericDataSource. The commons-pool dependency is indeed inherited from commons-dbcp. We can't actually remove GenericDataSource (in 1.1), because it wasn't deprecated in 1.0 -- we'll be able to clean that up next time around if we want (but we should warn people in the struts-config DTD that the whole data-sources element will go away, if that's really what we want to do). David Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Close to RC2?
On Mon, 24 Mar 2003, David Graham wrote: Date: Mon, 24 Mar 2003 12:38:01 -0700 From: David Graham [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: Close to RC2? The commons-pool dependency is indeed inherited from commons-dbcp. We can't actually remove GenericDataSource (in 1.1), because it wasn't deprecated in 1.0 -- we'll be able to clean that up next time around if we want (but we should warn people in the struts-config DTD that the whole data-sources element will go away, if that's really what we want to do). Why would the data-sources element have to go away just because GenericDataSource is removed? What would we use instead to implement the data sources? The original question (as I understood it) was how to get rid of commons-pool, which would also require getting rid of commons-dbcp and therefore eliminating the org.apache.commons.dbcp.BasicDataSource implementation class. Craig David Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Close to RC2?
Actually, my original thought was to get rid of DBCP because it's a problem child dependency and not everyone needs it. We could leave the data-sources element because it's useful to those who need it but they would have to provide the implementation class (change the type attribute to required). But we could just leave everything how it is and only use released versions of DBCP after they get the next release of it out. Dave On Mon, 24 Mar 2003, David Graham wrote: Date: Mon, 24 Mar 2003 12:38:01 -0700 From: David Graham [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: Close to RC2? The commons-pool dependency is indeed inherited from commons-dbcp. We can't actually remove GenericDataSource (in 1.1), because it wasn't deprecated in 1.0 -- we'll be able to clean that up next time around if we want (but we should warn people in the struts-config DTD that the whole data-sources element will go away, if that's really what we want to do). Why would the data-sources element have to go away just because GenericDataSource is removed? What would we use instead to implement the data sources? The original question (as I understood it) was how to get rid of commons-pool, which would also require getting rid of commons-dbcp and therefore eliminating the org.apache.commons.dbcp.BasicDataSource implementation class. Craig David Craig - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] _ The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Close to RC2?
Current bug status: Struts - 1 against a nested tag. Validator - 0, probably ready for a 1.0.2 release File Upload - 3, 2 of which should be easy fixes Logging - 8 Pool/DBCP - 7, I think we can remove this dependency for 1.2 So what does everyone think about an RC2 release? We probably need some volunteers to help out over in commons on DBCP and Logging to get those fixed up before we go final but I think an RC2 would be appropriate at this point. David _ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Close to RC2?
+2 if I was allowed to. And hopefully RC2 = 1.1 Final! James -Original Message- From: David Graham [mailto:[EMAIL PROTECTED] Sent: Monday, March 24, 2003 12:12 AM To: [EMAIL PROTECTED] Subject: Close to RC2? Current bug status: Struts - 1 against a nested tag. Validator - 0, probably ready for a 1.0.2 release File Upload - 3, 2 of which should be easy fixes Logging - 8 Pool/DBCP - 7, I think we can remove this dependency for 1.2 So what does everyone think about an RC2 release? We probably need some volunteers to help out over in commons on DBCP and Logging to get those fixed up before we go final but I think an RC2 would be appropriate at this point. David _ The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
