DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-06-18 19:22 ---
*** Bug 19911 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-03-05 21:32 ---
*** Bug 17692 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-03-04 04:45 ---
Fixed in the 20030304 nightly build.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 22:50 ---
It's true that we could release the iterator instance in doEndTag(), but there 
is nothing we can do about the collection. That is an attribute, and releasing 
it explicitly, other than in release() itself, would cause the tag to violate 
the JSP spec. The real problem is that the container - in this case Tomcat 
4.1.18 - it keeping too many instances of the tag in its pool.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 21:34 ---
There is definately an issue with tag pooling enabled and the logic:iterate tag 
not releasing the collection.  This is because the tag remains resident when 
tag pooling is enabled, therefore release is not called and the iterator / 
collection is an instance variable.  The issue in 17165 was resolved when the 
user disabled tag pooling.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 21:32 ---
I must apologize that my first two patches were not using the correct version 
of MessagesTag. The last one I posted is correct. Unfortunately I am behind a 
firewall and cannot simply use the CVS diff command.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 21:27 ---
Created an attachment (id=5131)
Fix for html:messages wrongly outputting footer in tag pooled environment.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 21:23 ---
Created an attachment (id=5130)
Patch for MessagesTag to propertly display footers against CVS version

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 21:19 ---
The bug report you refer to, Edgar, was resolved as invalid because the problem 
was *not* with Struts tags. If there *are* outstanding problems that you are 
aware of when using the Struts tags with tag pooling, please submit bug reports 
for them.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 20:58 ---
Prior discussions have made it clear that the struts tag libraries don't 
support Tomcat's tag pooling function.  If you disable tag pooling, there is no 
issue with the tags.  See bug 17165 

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17165

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 20:49 ---
Great, so all compliant containers must behave that way. I just submitted a 
proposed patch to fix the problem.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 20:48 ---
Created an attachment (id=5129)
Fix for html:messages wrongly outputting footer in tag pooled environment.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 20:37 ---
Mohan is correct - an instance of a tag handler may only be reused for tags 
that specify the same set of attributes. So the scenario you describe, with one 
tag specifying the 'footer' attribute and one not, requires the container to 
use two separate tag handler instances. See the section on Lifecycle on page 
163 of the JSP 1.2 spec.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 20:36 ---
That sounds great. Thanks for that information. It makes sense to pool based on 
the attributes of the tag. Sorry I didn't research that better up front. Not to 
digress too much, but is it reasonable to expect that all Servlet containers 
would behave that way, to make certain that Struts works in the various 
containers in the field?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 20:27 ---
I understand that the tag-pooling is restricted by the attribute-set used. i.e. 
 and  would be pooled separately. 
I dont think these tags should have such problems, only nested was susceptible, 
and i believe, has been fixed.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 19:57 ---
Now you have prompted me to actually read the JSP specification ;-). My concern 
is that with tag pooling in place, one page may set an attribute on 
html:messages, say footer for example. I may have html:messages on another page 
that does not define the attribute footer. The JSP specification dictates that 
undeclared attributes should not be set, so setFooter is never called on the 
second page. So there is a particular instance of MessagesTag in the tag pool 
that has a value set for footer. If the tag that has no footer attribute 
specified happens to use that instance from the tag pool with footer set, it 
will erroneously have a value for footer. The specification recommends that any 
request scope values in the tag should be reset in the method doFinally. I have 
not actually tested this behavior to see if it performs improperly, but after 
examining the JSP specification I believe that it is highly likely.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 19:29 ---
The spec is clear on when attributes are set and not set - see JSP.10.2 in the 
JSP 1.2 spec. (The "Golden Rule" for tag implementors is to never modify the 
attribute values from within the tag implementation itself.) I don't believe 
there's a problem with the attributes in the  tag, with the 
exception of the 'name' attribute.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 19:20 ---
Sorry that I was not more specific. The problem I am reporting is due to 
processed not being reset to false. As for the members with mutator methods, I 
am not sure what the Servlet container is supposed to do if the attribute is 
not present in the tag. Will it call getX(null), hence resetting the member? Or 
does it not call the method at all? If it is the latter, than any members that 
have a chance of having a value when they should not due to the exclusion of 
the attribute in the JSP should be reset to null. Offhand, I am not sure what 
the JSP specification mandates regarding this behavior.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17613] - Problem with html:messages Tag and Tomcat Tag Pooling

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17613

Problem with html:messages Tag and Tomcat Tag Pooling





--- Additional Comments From [EMAIL PROTECTED]  2003-03-03 19:12 ---
You refer "some member variables". Can you be more specific about which ones? 
Just skimming the code, I see two bugs -  'processed' should be set to false at 
the beginning of doStartTag(), and 'name' shouldn't be modified at all - but 
I'd like to make sure I'm not missing any others that you noticed. Thanks.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]