Re: [Fwd: Re: Maven test run]

2003-11-28 Thread Martin Cooper
On Fri, 28 Nov 2003, Ted Husted wrote:

 And, for extra credit, if anyone were interested in trying it, a
 Mavenized version of Martin's very cool release target would be very
 useful. It wraps up both the source and binary distributions in both
 .zip and .gz format, ready for upload. Something like this should
 probably be a Maven plugin, since its something all the Jakarta projects
 need to do.

The maven-dist plugin does this for regular Maven projects. I don't know
what it would take to get it to do the right thing for Struts, though,
since I'm not much of a Maven maven myself.

--
Martin Cooper



 -Ted.

  Original Message 
 Subject: Re: Maven test run
 Date: Fri, 28 Nov 2003 13:55:44 -0500
 From: Ted Husted [EMAIL PROTECTED]
 Reply-To: Struts Developers List [EMAIL PROTECTED]
 Organization: Apache Software Foundation - Jakarta Project
 To: Struts Developers List [EMAIL PROTECTED]
 References: [EMAIL PROTECTED]

 We are interested in fixing the Maven build. The tests seem to run under
 the conventional build, which would imply that the issue may be in the
 Maven setup.

 Along with the core, we would also need a strategy for building the
 various example web applications. I'm thinking we may need a master
 webapps-projects.xml that each application artifact could extend.

 -Ted.

 Tim Chen wrote:
  I submitted a patch recently for the maven build.
  Sorry I didn't get a chance to (aka.. Just been lazy) attach it to a
  formal bugzilla report as Rob had suggested that I do.
  The maven test currently fail because the resources are not provided
  (look at my past post for reference). Unfortunately, even after
  including the source there are still test failures. I posted a sniplet
  of one of the errors before.
  I never bothered to find out if those test failures were due to the
  maven build or because of incorrectly written tests.
  Either way, I'll try to find some time to fix the maven build if anyone
  is interested.
 
  Tim Chen
  [EMAIL PROTECTED]
 
 
  -Original Message-
  From: Ted Husted [mailto:[EMAIL PROTECTED]
  Sent: Friday, November 28, 2003 8:50 AM
  To: Struts Developers List
  Subject: Re: Maven test run
 
 
  Steve Raeburn wrote:
 
 There were no tests found because the test section was commented out!
 (and the example include pattern doesn't match our naming convention).
 
 
 I've enabled the JUnit tests. Using Cactus with Maven is beyond me,
 for now :-)
 
 
  Mea culpa on the comment block. I did that to see if I could get the
  rest of it to run, and then committed it accidentally. head-slap/
 
 
 When Maven runs the tests, TestModuleConfig is throwing a
 NullPointerException that doesn't show up when running from Ant. I'm
 inclined to believe that the Maven configuration requires more work
 rather that it actually being a problem with ModuleConfig.
 
   
 
 The Maven build remains HIGHLY experimental!!
 
 
  I wonder if we could try a compromise? Could we have a Maven build that
  just downloaded the dependencies into the central repository, and a
  build.properties that got everything from there. This would save us from
 
  going back to a struts-library distribution.
 
  I also wonder if it be possible to wrap our existing Ant build as Maven
  goals? The user guide says that any Ant task can be used in the
  maven.xml.
 
  http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml
 
  Another stepping-stone might be to provide Maven projects for the
  examples applications, especially the blank application. I'm thinking
  the cannonical approach here would be to have a master
  webapp-project.xml that we then extended for each application
  artifact.
 
  http://maven.apache.org/reference/user-guide.html#POM%20Inheritance
 
  I'm working on a changelog system now but will come back to this later,
  if no one beats me to it. [Please do, if you can :)]
 
  -Ted.
 
 
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: [Fwd: Re: Maven test run]

2003-11-28 Thread Tim Chen
Patches have been submitted to bugzilla for both project.xml and
maven.xml.
I am able to build struts from a clean download now by using just:
 maven

Attached is a combined patch file.

Tim Chen
[EMAIL PROTECTED]


-Original Message-
From: Martin Cooper [mailto:[EMAIL PROTECTED] 
Sent: Friday, November 28, 2003 3:30 PM
To: Struts Developers List
Subject: Re: [Fwd: Re: Maven test run]


On Fri, 28 Nov 2003, Ted Husted wrote:

 And, for extra credit, if anyone were interested in trying it, a 
 Mavenized version of Martin's very cool release target would be very

 useful. It wraps up both the source and binary distributions in both 
 .zip and .gz format, ready for upload. Something like this should 
 probably be a Maven plugin, since its something all the Jakarta 
 projects need to do.

The maven-dist plugin does this for regular Maven projects. I don't know
what it would take to get it to do the right thing for Struts, though,
since I'm not much of a Maven maven myself.

--
Martin Cooper



 -Ted.

  Original Message 
 Subject: Re: Maven test run
 Date: Fri, 28 Nov 2003 13:55:44 -0500
 From: Ted Husted [EMAIL PROTECTED]
 Reply-To: Struts Developers List [EMAIL PROTECTED]
 Organization: Apache Software Foundation - Jakarta Project
 To: Struts Developers List [EMAIL PROTECTED]
 References: [EMAIL PROTECTED]

 We are interested in fixing the Maven build. The tests seem to run 
 under the conventional build, which would imply that the issue may be 
 in the Maven setup.

 Along with the core, we would also need a strategy for building the 
 various example web applications. I'm thinking we may need a master 
 webapps-projects.xml that each application artifact could extend.

 -Ted.

 Tim Chen wrote:
  I submitted a patch recently for the maven build.
  Sorry I didn't get a chance to (aka.. Just been lazy) attach it to a

  formal bugzilla report as Rob had suggested that I do. The maven 
  test currently fail because the resources are not provided (look at 
  my past post for reference). Unfortunately, even after including the

  source there are still test failures. I posted a sniplet of one of 
  the errors before. I never bothered to find out if those test 
  failures were due to the maven build or because of incorrectly 
  written tests. Either way, I'll try to find some time to fix the 
  maven build if anyone is interested.
 
  Tim Chen
  [EMAIL PROTECTED]
 
 
  -Original Message-
  From: Ted Husted [mailto:[EMAIL PROTECTED]
  Sent: Friday, November 28, 2003 8:50 AM
  To: Struts Developers List
  Subject: Re: Maven test run
 
 
  Steve Raeburn wrote:
 
 There were no tests found because the test section was commented 
 out! (and the example include pattern doesn't match our naming 
 convention).
 
 
 I've enabled the JUnit tests. Using Cactus with Maven is beyond me, 
 for now :-)
 
 
  Mea culpa on the comment block. I did that to see if I could get the

  rest of it to run, and then committed it accidentally. head-slap/
 
 
 When Maven runs the tests, TestModuleConfig is throwing a 
 NullPointerException that doesn't show up when running from Ant. I'm

 inclined to believe that the Maven configuration requires more work 
 rather that it actually being a problem with ModuleConfig.
 
   
 
 The Maven build remains HIGHLY experimental!!
 
 
  I wonder if we could try a compromise? Could we have a Maven build 
  that just downloaded the dependencies into the central repository, 
  and a build.properties that got everything from there. This would 
  save us from
 
  going back to a struts-library distribution.
 
  I also wonder if it be possible to wrap our existing Ant build as 
  Maven goals? The user guide says that any Ant task can be used in 
  the maven.xml.
 
  http://maven.apache.org/reference/user-guide.html#Sample%20maven.xml
 
  Another stepping-stone might be to provide Maven projects for the 
  examples applications, especially the blank application. I'm 
  thinking the cannonical approach here would be to have a master 
  webapp-project.xml that we then extended for each application 
  artifact.
 
  http://maven.apache.org/reference/user-guide.html#POM%20Inheritance
 
  I'm working on a changelog system now but will come back to this 
  later, if no one beats me to it. [Please do, if you can :)]
 
  -Ted.
 
 
 
  
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 
  
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Index: project.xml
===
RCS file: /home/cvspublic/jakarta-struts/project.xml,v