Re: cvs commit: jakarta-struts/src/share/org/apache/struts/valida torValidatorPlugIn.java

[Eddie Bush]

Yes.  My goal was to not create a session just to get at the 
ServletContext though.  That's why I wrote it that way.  I suppose it 
would be better your way though.

In all liklihood, the more I think about it (and think about logger 
output), Struts is going to create a session anyway - for a number of 
other reasons.  So, that's probably not good justification for doing 
things the way I did.  Sorry about that.

Should I submit a patch, or does someone else want to fix it?

Martin Cooper wrote:

The new version of getValidatorResources() added here takes a ServletContext
and an HttpServletRequest. It seems to me that it should only take the
request, since the servlet context can be obtained from that. It would be a
little less error-prone this way, too.

My 2 cents.

--
Martin Cooper

-- 
Eddie Bush




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]

Re: cvs commit: jakarta-struts/src/share/org/apache/struts/valida torValidatorPlugIn.java

[Eddie Bush]

That's brand new - I added it.  ... or are you saying I should have just 
replaced it instead of deprecating?  I'll check the docs :-)  In any 
case, I submitted a patch.  It was my error - should be my correction to 
make.  Of course, if you don't approve of what I've done, feel free to 
do what you like :-)  The important thing is that it works.

Rob Leland wrote:

 I can get to it some time this weekend, though if
 Martin wishes to fix it that is great also...
 Which bring up another question...see [Policy on depreciation vs 
 deleting]
 -Rob 

-- 
Eddie Bush




--
To unsubscribe, e-mail:   mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]