[GitHub] [hadoop-submarine] tangzhankun commented on a change in pull request #8: [SUBMARINE-181] Submarine team manager TeamRestApi
tangzhankun commented on a change in pull request #8: [SUBMARINE-181] Submarine
team manager TeamRestApi
URL: https://github.com/apache/hadoop-submarine/pull/8#discussion_r327419667
##
File path:
submarine-workbench/submarine-server/src/main/java/org/apache/submarine/rest/TeamRestApi.java
##
@@ -119,31 +111,40 @@ public Response add(Team team) {
public Response edit(Team team) {
LOG.info("edit team:{}", team.toString());
-// todo(zhulinhao)
-// 把 team 保存到 team 表中
+// todo: need set update_by value
+try {
+ // update team
+ teamService.updateByPrimaryKeySelective(team);
-List memebers = team.getCollaborators();
-// 将每个 TeamMemeber 保存到 team_member table 中
-// 前端有如下情况：
-// 1. 前端没有对成员进行修改
-// 2. 前端新增了成员
-// 3. 前端删除了成员
+ // TODO
+ // 将新增的成员中inviter=0，并且没有发送过加入 team 邀请信息
Review comment:
Please use English to comment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hadoop-submarine] yuanzac commented on issue #2: Don't merge. Just test Travis CI
yuanzac commented on issue #2: Don't merge. Just test Travis CI URL: https://github.com/apache/hadoop-submarine/pull/2#issuecomment-534369933 Travis is ok now, just close this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hadoop-submarine] yuanzac closed pull request #2: Don't merge. Just test Travis CI
yuanzac closed pull request #2: Don't merge. Just test Travis CI URL: https://github.com/apache/hadoop-submarine/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hadoop-submarine] qiyuezhetian removed a comment on issue #8: [SUBMARINE-181] Submarine team manager TeamRestApi
qiyuezhetian removed a comment on issue #8: [SUBMARINE-181] Submarine team manager TeamRestApi URL: https://github.com/apache/hadoop-submarine/pull/8#issuecomment-534208708 [SUBMARINE-181] Submarine team manager TeamRestApi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hadoop-submarine] qiyuezhetian commented on issue #8: [SUBMARINE-181] Submarine team manager TeamRestApi
qiyuezhetian commented on issue #8: [SUBMARINE-181] Submarine team manager TeamRestApi URL: https://github.com/apache/hadoop-submarine/pull/8#issuecomment-534208708 [SUBMARINE-181] Submarine team manager TeamRestApi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (SUBMARINE-181) [SERVER] Submarine team manager TeamRestApi
[ https://issues.apache.org/jira/browse/SUBMARINE-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SUBMARINE-181: - Labels: pull-request-available (was: ) > [SERVER] Submarine team manager TeamRestApi > --- > > Key: SUBMARINE-181 > URL: https://issues.apache.org/jira/browse/SUBMARINE-181 > Project: Hadoop Submarine > Issue Type: Sub-task >Reporter: zhulinhao >Assignee: zhulinhao >Priority: Major > Labels: pull-request-available > > 1. org.apache.submarine.database.service.TeamService > 2. TeamMapper.xml > 3. org.apache.submarine.rest.TeamRestApi > 4. database table: team, team_member, sys_message; -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hadoop-submarine] qiyuezhetian opened a new pull request #8: [SUBMARINE-181] Submarine team manager TeamRestApi
qiyuezhetian opened a new pull request #8: [SUBMARINE-181] Submarine team manager TeamRestApi URL: https://github.com/apache/hadoop-submarine/pull/8 ### What is this PR for? 1. org.apache.submarine.database.service.TeamService 2. TeamMapper.xml, TeamMemberMapper.xml 3. org.apache.submarine.rest.TeamRestApi 4. database table: team, team_member; ### What type of PR is it? [ Feature ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/SUBMARINE-181 ### How should this be tested? * [CI Pass](https://travis-ci.org/qiyuezhetian/hadoop-submarine/builds/588564587) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUBMARINE-195) Fix the incorrect project name in merge_submarine_pr.py
[ https://issues.apache.org/jira/browse/SUBMARINE-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935685#comment-16935685 ] Xun Liu commented on SUBMARINE-195: --- h3. What is this PR for? When it merges the PR and the committer chose to close Jira, it fails with something like project "HADOOP-SUBMARINE" not be found. Tested that change it to "SUBMARINE" will work. h3. What type of PR is it? Bug Fix h3. What is the Jira issue? https://issues.apache.org/jira/browse/SUBMARINE-195 h3. How should this be tested? use the cicd image to do the PR merge. And also choose yes to update the associated JIRA. It will work with this fix. h3. Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No > Fix the incorrect project name in merge_submarine_pr.py > --- > > Key: SUBMARINE-195 > URL: https://issues.apache.org/jira/browse/SUBMARINE-195 > Project: Hadoop Submarine > Issue Type: Bug >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > Fix For: 0.3.0 > > Time Spent: 20m > Remaining Estimate: 0h > > When it merges the PR and the committer chose to close Jira, it fails with > something like project "HADOOP-SUBMARINE" not be found. Tested that change it > to "SUBMARINE" will work. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SUBMARINE-195) Fix the incorrect project name in merge_submarine_pr.py
[ https://issues.apache.org/jira/browse/SUBMARINE-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang resolved SUBMARINE-195. Fix Version/s: 0.3.0 Resolution: Fixed Issue resolved by pull request 7 [https://github.com/apache/hadoop-submarine/pull/7] > Fix the incorrect project name in merge_submarine_pr.py > --- > > Key: SUBMARINE-195 > URL: https://issues.apache.org/jira/browse/SUBMARINE-195 > Project: Hadoop Submarine > Issue Type: Bug >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > Fix For: 0.3.0 > > Time Spent: 20m > Remaining Estimate: 0h > > When it merges the PR and the committer chose to close Jira, it fails with > something like project "HADOOP-SUBMARINE" not be found. Tested that change it > to "SUBMARINE" will work. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hadoop-submarine] asfgit closed pull request #7: SUBMARINE-195. Fix the incorrect project name in merge_submarine_pr.py
asfgit closed pull request #7: SUBMARINE-195. Fix the incorrect project name in merge_submarine_pr.py URL: https://github.com/apache/hadoop-submarine/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[hadoop-submarine] branch master updated: SUBMARINE-195. Fix the incorrect project name in merge_submarine_pr.py
This is an automated email from the ASF dual-hosted git repository.
ztang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hadoop-submarine.git
The following commit(s) were added to refs/heads/master by this push:
new 4b8e588 SUBMARINE-195. Fix the incorrect project name in
merge_submarine_pr.py
4b8e588 is described below
commit 4b8e588e651c8ddc382d43a762998bfcc5e53687
Author: Zhankun Tang
AuthorDate: Mon Sep 23 15:22:07 2019 +0800
SUBMARINE-195. Fix the incorrect project name in merge_submarine_pr.py
### What is this PR for?
When it merges the PR and the committer chose to close Jira, it fails with
something like project "HADOOP-SUBMARINE" not be found. Tested that change it
to "SUBMARINE" will work.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-195
### How should this be tested?
use the cicd image to do the PR merge. And also choose yes to update the
associated JIRA.
It will work with this fix.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Zhankun Tang
Closes #7 from tangzhankun/submarine-195 and squashes the following commits:
ca52b46 [Zhankun Tang] SUBMARINE-195. Fix the incorrect project name in
merge_submarine_pr.py
---
dev-support/cicd/merge_submarine_pr.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dev-support/cicd/merge_submarine_pr.py
b/dev-support/cicd/merge_submarine_pr.py
index cac8363..486dda8 100755
--- a/dev-support/cicd/merge_submarine_pr.py
+++ b/dev-support/cicd/merge_submarine_pr.py
@@ -243,7 +243,7 @@ def resolve_jira_issue(merge_branches, comment,
default_jira_id=""):
print ("summary\t\t%s\nassignee\t%s\nstatus\t\t%s\nurl\t\t%s/%s\n" % (
cur_summary, cur_assignee, cur_status, JIRA_BASE, jira_id))
-versions = asf_jira.project_versions("HADOOP-SUBMARINE")
+versions = asf_jira.project_versions("SUBMARINE")
versions = sorted(versions, key=lambda x: x.name, reverse=True)
versions = filter(lambda x: x.raw['released'] is False, versions)
# Consider only x.y.z versions
@@ -353,4 +353,4 @@ if JIRA_IMPORTED:
print "Exiting without trying to close the associated JIRA."
else:
print "Could not find jira library. Run 'sudo pip install jira' to
install."
-print "Exiting without trying to close the associated JIRA."
\ No newline at end of file
+print "Exiting without trying to close the associated JIRA."
[GitHub] [hadoop-submarine] tangzhankun commented on issue #7: SUBMARINE-195. Fix the incorrect project name in merge_submarine_pr.py
tangzhankun commented on issue #7: SUBMARINE-195. Fix the incorrect project name in merge_submarine_pr.py URL: https://github.com/apache/hadoop-submarine/pull/7#issuecomment-533987733 Leave a message here to test if this comment will merge to jira. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (SUBMARINE-195) Fix the incorrect project name in merge_submarine_pr.py
[ https://issues.apache.org/jira/browse/SUBMARINE-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SUBMARINE-195: - Labels: pull-request-available (was: ) > Fix the incorrect project name in merge_submarine_pr.py > --- > > Key: SUBMARINE-195 > URL: https://issues.apache.org/jira/browse/SUBMARINE-195 > Project: Hadoop Submarine > Issue Type: Bug >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > > When it merges the PR and the committer chose to close Jira, it fails with > something like project "HADOOP-SUBMARINE" not be found. Tested that change it > to "SUBMARINE" will work. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hadoop-submarine] tangzhankun opened a new pull request #7: SUBMARINE-195. Fix the incorrect project name in merge_submarine_pr.py
tangzhankun opened a new pull request #7: SUBMARINE-195. Fix the incorrect project name in merge_submarine_pr.py URL: https://github.com/apache/hadoop-submarine/pull/7 ### What is this PR for? When it merges the PR and the committer chose to close Jira, it fails with something like project "HADOOP-SUBMARINE" not be found. Tested that change it to "SUBMARINE" will work. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/SUBMARINE-195 ### How should this be tested? use the cicd image to do the PR merge. And also choose yes to update the associated JIRA. It will work with this fix. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SUBMARINE-195) Fix the incorrect project name in merge_submarine_pr.py
Zhankun Tang created SUBMARINE-195: -- Summary: Fix the incorrect project name in merge_submarine_pr.py Key: SUBMARINE-195 URL: https://issues.apache.org/jira/browse/SUBMARINE-195 Project: Hadoop Submarine Issue Type: Bug Reporter: Zhankun Tang Assignee: Zhankun Tang When it merges the PR and the committer chose to close Jira, it fails with something like project "HADOOP-SUBMARINE" not be found. Tested that change it to "SUBMARINE" will work. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SUBMARINE-194) Provide Dockerfile to ease the script usage like merge_submarine_pr.py
[ https://issues.apache.org/jira/browse/SUBMARINE-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang resolved SUBMARINE-194. Fix Version/s: 0.3.0 Resolution: Fixed Issue resolved by pull request 6 [https://github.com/apache/hadoop-submarine/pull/6] > Provide Dockerfile to ease the script usage like merge_submarine_pr.py > -- > > Key: SUBMARINE-194 > URL: https://issues.apache.org/jira/browse/SUBMARINE-194 > Project: Hadoop Submarine > Issue Type: Improvement >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > Fix For: 0.3.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Improve the usability of cicd scripts like merge_submarine_pr.py due to the > python environment installation may be a pain. It's better to run a docker > container and guide the committer to do tasks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[hadoop-submarine] branch master updated: SUBMARINE-194. Provide Dockerfile to ease the script usage
This is an automated email from the ASF dual-hosted git repository.
ztang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hadoop-submarine.git
The following commit(s) were added to refs/heads/master by this push:
new e161000 SUBMARINE-194. Provide Dockerfile to ease the script usage
e161000 is described below
commit e161000310763fc61bbfddaa52b46a54872cc0fd
Author: Zhankun Tang
AuthorDate: Mon Sep 23 14:49:31 2019 +0800
SUBMARINE-194. Provide Dockerfile to ease the script usage
### What is this PR for?
Provide Dockerfile to ease the usage of the cicd scripts.
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-194
### How should this be tested?
1. build the image
2. run the image and do tasks like merge PR
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
Author: Zhankun Tang
Closes #6 from tangzhankun/submarine-194 and squashes the following commits:
3ee3e12 [Zhankun Tang] SUBMARINE-194. Provide Dockerfile to ease the script
usage like merge_submarine_pr.py.
---
dev-support/cicd/Dockerfile | 30 ++
dev-support/cicd/README.md | 28 +
dev-support/cicd/entry.sh | 77 +
3 files changed, 122 insertions(+), 13 deletions(-)
diff --git a/dev-support/cicd/Dockerfile b/dev-support/cicd/Dockerfile
new file mode 100644
index 000..e2475d0
--- /dev/null
+++ b/dev-support/cicd/Dockerfile
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:16.04
+RUN \
+ apt-get update && \
+ apt-get install -y vim python git python-pip && \
+ pip install jira
+RUN \
+ git clone https://gitbox.apache.org/repos/asf/hadoop-submarine.git && \
+ cd hadoop-submarine && \
+ git remote rename origin apache && \
+ git remote add apache-github https://github.com/apache/hadoop-submarine.git
+ADD \
+ entry.sh /entry.sh
+ENV \
+ SUBMARINE_HOME=/hadoop-submarine
+CMD /entry.sh
diff --git a/dev-support/cicd/README.md b/dev-support/cicd/README.md
index 68a0678..b144007 100644
--- a/dev-support/cicd/README.md
+++ b/dev-support/cicd/README.md
@@ -13,18 +13,20 @@
-->
# Introduction
This cicd directory contains several scripts to ease code and release
management.
+To use them more easily, we provide a Docker image to help committer to handle
tasks like committing code and release build.
-## Merge PRs From Github
-The "merge_submarine_pr.py" script is usd for merge PRs without access the
github web portal. It can also automatically merge activities from github to
apache Jira.
+```
+cd /dev-support/cicd
+docker build -t submarine-cicd .
+docker run -it --rm submarine-cicd
+```
-As a committer, you should create a dedicated directory to do below steps
instead of using existing development repo. Doing below steps in a Docker
container with python2 and jira (pip install jira) is preferred:
-
-1. git clone https://gitbox.apache.org/repos/asf/hadoop-submarine.git
-2. cd hadoop-submarine
-3. git remote rename origin apache
-4. git remote add apache-github https://github.com/apache/hadoop-submarine.git
-5. git config --local --add user.name {name}
-6. git config --local --add user.email {username}@apache.org
-7. echo -e "JIRA_USERNAME={jira_username}\nJIRA_PASSWORD={jira_password}" >>
~/.bashrc
-8. source ~/.bashrc
-9. dev-support/cicd/merge_submarine_pr.py
+And you'll see output like below and then you can decide what to accomplish.
+```
+$ docker run -it --rm submarine-cicd
+Menu:
+ 1. Merge PR
+Enter Menu ID:1
+ Merge PR Begin
+Enter Your Apache JIRA User name:
+```
diff --git a/dev-support/cicd/entry.sh b/dev-support/cicd/entry.sh
new file mode 100755
index 000..958947b
--- /dev/null
+++ b/dev-support/cicd/entry.sh
@@ -0,0 +1,77 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF
[GitHub] [hadoop-submarine] asfgit closed pull request #6: SUBMARINE-194. Provide Dockerfile to ease the script usage
asfgit closed pull request #6: SUBMARINE-194. Provide Dockerfile to ease the script usage URL: https://github.com/apache/hadoop-submarine/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (SUBMARINE-194) Provide Dockerfile to ease the script usage like merge_submarine_pr.py
[ https://issues.apache.org/jira/browse/SUBMARINE-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SUBMARINE-194: - Labels: pull-request-available (was: ) > Provide Dockerfile to ease the script usage like merge_submarine_pr.py > -- > > Key: SUBMARINE-194 > URL: https://issues.apache.org/jira/browse/SUBMARINE-194 > Project: Hadoop Submarine > Issue Type: Improvement >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > Labels: pull-request-available > > Improve the usability of cicd scripts like merge_submarine_pr.py due to the > python environment installation may be a pain. It's better to run a docker > container and guide the committer to do tasks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hadoop-submarine] tangzhankun commented on issue #6: SUBMARINE-194. Provide Dockerfile to ease the script usage
tangzhankun commented on issue #6: SUBMARINE-194. Provide Dockerfile to ease the script usage URL: https://github.com/apache/hadoop-submarine/pull/6#issuecomment-533979718 Please review @liuxunorg This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hadoop-submarine] tangzhankun opened a new pull request #6: SUBMARINE-194. Provide Dockerfile to ease the script usage
tangzhankun opened a new pull request #6: SUBMARINE-194. Provide Dockerfile to ease the script usage URL: https://github.com/apache/hadoop-submarine/pull/6 ### What is this PR for? Provide Dockerfile to ease the usage of the cicd scripts. ### What type of PR is it? Feature ### What is the Jira issue? https://issues.apache.org/jira/browse/SUBMARINE-194 ### How should this be tested? 1. build the image 2. run the image and do tasks like merge PR ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (SUBMARINE-194) Provide Dockerfile to ease the script usage like merge_submarine_pr.py
[ https://issues.apache.org/jira/browse/SUBMARINE-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang updated SUBMARINE-194: --- Description: Improve the usability of cicd scripts like merge_submarine_pr.py due to the python environment installation may be a pain. It's better to run a docker container and guide the committer to do tasks. (was: Improve the usability of merge_submarine_pr.py due to the python environment installation may be a pain.) > Provide Dockerfile to ease the script usage like merge_submarine_pr.py > -- > > Key: SUBMARINE-194 > URL: https://issues.apache.org/jira/browse/SUBMARINE-194 > Project: Hadoop Submarine > Issue Type: Improvement >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > > Improve the usability of cicd scripts like merge_submarine_pr.py due to the > python environment installation may be a pain. It's better to run a docker > container and guide the committer to do tasks. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SUBMARINE-194) Provide Dockerfile to ease the script usage like merge_submarine_pr.py
[ https://issues.apache.org/jira/browse/SUBMARINE-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang updated SUBMARINE-194: --- Summary: Provide Dockerfile to ease the script usage like merge_submarine_pr.py (was: Package merge_submarine_pr.py into a docker image) > Provide Dockerfile to ease the script usage like merge_submarine_pr.py > -- > > Key: SUBMARINE-194 > URL: https://issues.apache.org/jira/browse/SUBMARINE-194 > Project: Hadoop Submarine > Issue Type: Improvement >Reporter: Zhankun Tang >Assignee: Zhankun Tang >Priority: Major > > Improve the usability of merge_submarine_pr.py due to the python environment > installation may be a pain. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SUBMARINE-185) [DOC] Add how to contribution docs
[ https://issues.apache.org/jira/browse/SUBMARINE-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhankun Tang resolved SUBMARINE-185. Resolution: Fixed > [DOC] Add how to contribution docs > -- > > Key: SUBMARINE-185 > URL: https://issues.apache.org/jira/browse/SUBMARINE-185 > Project: Hadoop Submarine > Issue Type: Improvement >Reporter: Xun Liu >Assignee: Xun Liu >Priority: Major > Labels: pull-request-available > Fix For: 0.3.0 > > Time Spent: 20m > Remaining Estimate: 0h > > This document is intended to help more people and know-how to participate in > the development of submarine projects. > The documentation includes: > 1. Contribution Guide > 2. Github Workflow > 3. Code Review Guide -- This message was sent by Atlassian Jira (v8.3.4#803005)
[hadoop-submarine] branch master updated: [SUBMARINE-185] Add how to contribution docs
This is an automated email from the ASF dual-hosted git repository. ztang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hadoop-submarine.git The following commit(s) were added to refs/heads/master by this push: new 92de180 [SUBMARINE-185] Add how to contribution docs 92de180 is described below commit 92de1807695ac4b8b8353db66645eefed7d1ee55 Author: Xun Liu AuthorDate: Mon Sep 23 10:29:47 2019 +0800 [SUBMARINE-185] Add how to contribution docs ### What is this PR for? This document is intended to help more people and know-how to participate in the development of submarine projects. The documentation includes: 1. Contribution Guide 2. Github Workflow 3. Code Review Guide ### What type of PR is it? Improvement ### Todos * [ ] - Need add become-a-committer.md * [ ] - Need add contributors.md ### What is the Jira issue? * https://issues.apache.org/jira/browse/SUBMARINE-185 ### How should this be tested? * [CI Pass](https://travis-ci.org/liuxunorg/hadoop-submarine/builds/588083937) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes Author: Xun Liu Closes #5 from liuxunorg/SUBMARINE-185 and squashes the following commits: 3d7f65f [Xun Liu] Fix description error b6dcbaa [Xun Liu] Add index to README.md 28533ce [Xun Liu] [SUBMARINE-185] Add how to contribution docs --- README.md| 11 +- docs/README.md | 4 + docs/community/README.md | 67 + docs/community/become-a-committer.md | 15 ++ docs/community/contributing.md | 263 +++ docs/community/contributors.md | 15 ++ 6 files changed, 370 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index d9fa1b1..5d5631f 100644 --- a/README.md +++ b/README.md @@ -104,13 +104,14 @@ This is a docker image built for submarine development and quick start test. ### Installation and deployment -Read the [Quick Start Guide](./docs/helper/QuickStart.md), - - - - +Read the [Quick Start Guide](./docs/helper/QuickStart.md) +## Apache Hadoop Submarine Community +Read the [Apache Hadoop Submarine Community Guide](./docs/community/README.md) +How to contribute [Contributing Guide](./docs/community/contributing.md) +## License +The Apache Hadoop Submarine project is licensed under the Apache 2.0 License. See the [LICENSE](./LICENSE) file for details. diff --git a/docs/README.md b/docs/README.md index 02f4a5a..e89602f 100644 --- a/docs/README.md +++ b/docs/README.md @@ -24,6 +24,10 @@ Click below contents if you want to understand more. [Build From Code Guide](./development/BuildFromCode.md) +## Apache Hadoop Submarine Community + +[Apache Hadoop Submarine Community Guide](./community/README.md) + ## Examples Here're some examples about Submarine usage. diff --git a/docs/community/README.md b/docs/community/README.md new file mode 100644 index 000..4762f54 --- /dev/null +++ b/docs/community/README.md @@ -0,0 +1,67 @@ + + +## Apache Hadoop Submarine Community + +Welcome to the Apache Hadoop Submarine Community! The main objective is to help members of the Submarine community who share similar interests to learn from and collaborate with each other. + +Your journey of becoming a contributor and committer starts from here: improving docs, improving code, giving talks, organizing meetups, etc. + +## Communicating + +You can reach out to the community members via any one of the following ways: + ++ Slack Developer: [https://the-asf.slack.com/submarine-dev/](https://the-asf.slack.com/submarine-dev/) + ++ Slack User: [https://the-asf.slack.com/submarine-user/](https://the-asf.slack.com/submarine-user/) + ++ Zoom: [https://cloudera.zoom.us/j/880548968](https://cloudera.zoom.us/j/880548968) + ++ Sync Up: [https://docs.google.com/document/d/16pUO3TP4SxSeLduG817GhVAjtiph9HYpRHo_JgduDvw/edit](https://docs.google.com/document/d/16pUO3TP4SxSeLduG817GhVAjtiph9HYpRHo_JgduDvw/edit) + +## Your First Contribution + +You can start by finding an existing issue with the [https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE?filter=allopenissues](https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE?filter=allopenissues) label. These issues are well suited for new contributors. + +If a PR (Pull Request) submitted to the [Hadoop-Submarine](https://github.com/apache/hadoop-submarine) projects by you is approved and merged, then you become a Submarine Contributor. + +If you want to work on a new idea of relatively small scope: + +1. Submit an issue describing your proposed change to the repo in question. + +2. The repo owners will respond to your issue promptly. + +3. Submit a [pull
[GitHub] [hadoop-submarine] asfgit closed pull request #5: [SUBMARINE-185] Add how to contribution docs
asfgit closed pull request #5: [SUBMARINE-185] Add how to contribution docs URL: https://github.com/apache/hadoop-submarine/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
