Re: MXE with Qt5.11.1 and missing map

[Dirk Hohndel]

> On Jul 9, 2018, at 10:32 PM, Stefan Fuchs  wrote:
> 
> Hallo Dirk,
> 
> Refreshing your memory regarding QtPositioning plus finally answering your 
> question below...
> 
> Am 25.06.2018 um 21:46 schrieb Dirk Hohndel  >:
> 
>> 
>>> On Jun 26, 2018, at 2:38 AM, Stefan Fuchs >> > wrote
>>> I tried to do this a few days ago but I now see a issue with map not 
>>> displayed. Instead I do see the "QML module QtLocation and QtPositioning" 
>>> error. But as far as I can see DLLs are there in version 5.11.1
>>> 
>> I saw similar feedback from people building with 5.11 on some Linux flavors. 
>> I upgraded my Arch Linux yesterday and the map worked there - but as I said, 
>> I haven't played with this for MXE. My guess would be that it's not the DLLs 
>> but the qml modules that are missing.
>>> In the shell I have this error:
>>> qrc:/qml/MapWidget.qml:4:1: plugin cannot be loaded for module 
>>> "QtPositioning": Die Bibliothek C:\Program Files 
>>> (x86)\Subsurface\qml\QtPositioning\declarative_positioning.dll kann nicht 
>>> geladen werden: Das angegebene Modul wurde nicht gefunden.
>>> QUrl("qrc:/qml/MapWidget.qml") failed to load with status: 
>>> QQuickWidget::Status(Error)
>>> 
>> I take it back, it clearly is looking for a DLL. And when you look at the 
>> installed version, the library is right where Subsurface is looking for it? 
>> Or is it missing from the installer?
> The new 5.11.1 library file was there in the right position. No clue why Qt 
> complained.

I ran into this on Mac - the error message makes no sense, but it was fixed by 
making sure QtPositioningQuick was included in the bundle. Maybe it's something 
similar on MXE?
Look at this commit: 
https://github.com/Subsurface-divelog/subsurface/commit/4595ccb9f993160eee25f242feb092566dfe3061
 


/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [RFC] UI: Rename "photos"/"images" to a term covering videos as well

[Berthold Stoeger]

On Monday, 9 July 2018 22:55:38 CEST Lubomir I. Ivanov wrote:

> photos, pictures, images, video, audio etc. falls under "media".

Given Stefan's list, I'm not sure that this is perfect in all cases:

"Find moved media": Sounds to me like it would search for missing USB sticks?
"Found %1 media...": Perhaps better "Found %1 files...".

In German, we could use "Multimedia" or "Multimediadateien", the latter being 
a bit unwieldy.

This is tougher than I would have expected.

Berthold


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [RFC] UI: Rename "photos"/"images" to a term covering videos as well

[Stefan Fuchs]

Hallo Lubomir,

>> Am 09.07.2018 um 22:55 schrieb Lubomir I. Ivanov :
>> 
>> On 9 July 2018 at 23:33, Stefan Fuchs  wrote:
>> Hello,
>> 
>> thanks to Berthold we have the video "lite" support in master now. As a
>> reference please see:
>> https://github.com/Subsurface-divelog/subsurface/pull/1463
>> 
>> Now I think we should adapt the UI in a way that we rename almost every
>> occurrence of the term "photos" and "images" to s.th. which covers images
>> and videos.
>> What do you think? How should we adapt it?
> 
> photos, pictures, images, video, audio etc. falls under "media".
Yes, „media“ was also the first idea I had. What do you think, can we simply 
use „media“ standalone in every case or should we write „media file(s)“ in some 
cases like in „Match only media files in selected dive(s)“?

What do the others think?

Best regards 
Stefan 
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: MXE with Qt5.11.1 and missing map

[Stefan Fuchs]

Hallo Dirk,

Refreshing your memory regarding QtPositioning plus finally answering your 
question below...

> Am 25.06.2018 um 21:46 schrieb Dirk Hohndel :
> 
> 
>>> On Jun 26, 2018, at 2:38 AM, Stefan Fuchs  wrote
>> I tried to do this a few days ago but I now see a issue with map not 
>> displayed. Instead I do see the "QML module QtLocation and QtPositioning" 
>> error. But as far as I can see DLLs are there in version 5.11.1
>> 
> I saw similar feedback from people building with 5.11 on some Linux flavors. 
> I upgraded my Arch Linux yesterday and the map worked there - but as I said, 
> I haven't played with this for MXE. My guess would be that it's not the DLLs 
> but the qml modules that are missing.
>> In the shell I have this error:
>> qrc:/qml/MapWidget.qml:4:1: plugin cannot be loaded for module 
>> "QtPositioning": Die Bibliothek C:\Program Files 
>> (x86)\Subsurface\qml\QtPositioning\declarative_positioning.dll kann nicht 
>> geladen werden: Das angegebene Modul wurde nicht gefunden.
>> QUrl("qrc:/qml/MapWidget.qml") failed to load with status: 
>> QQuickWidget::Status(Error)
>> 
> I take it back, it clearly is looking for a DLL. And when you look at the 
> installed version, the library is right where Subsurface is looking for it? 
> Or is it missing from the installer?
The new 5.11.1 library file was there in the right position. No clue why Qt 
complained.___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Mac test build based on Qt5.11.1 - please test

[Berthold Stoeger]

On Tuesday, 10 July 2018 01:43:38 CEST Bryan Oliver wrote:
> Thanks! Sorry about the abbreviation, didn't even think about that but
> yikes, very good point.
> 
> Yes it was with your referenced binary, think I had a typo in my first
> email ("built" instead of "build"). I'll pull the crash log when I get
> home, and make a gif as well.

This is ultimately related to #1445: https://github.com/Subsurface-divelog/
subsurface/issues/1445

The add picture-dialog will access the wrong dive. If there isn't any dive 
yet, it will access a non-existing dive and crash.

desktop-widgets/simplewidgets.cpp, l.383:
QDateTime time_first = QDateTime::fromTime_t(first_selected_dive()->when, 
Qt::UTC);

There is no "first_selected_dive()" -> kaboom.

Berthold


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Mac test build based on Qt5.11.1 - please test

[Bryan Oliver]

Thanks! Sorry about the abbreviation, didn't even think about that but
yikes, very good point.

Yes it was with your referenced binary, think I had a typo in my first
email ("built" instead of "build"). I'll pull the crash log when I get
home, and make a gif as well.

Thanks again!
B

On Mon, Jul 9, 2018, 6:15 PM Dirk Hohndel  wrote:

> Hi Bryan
>
> > On Jul 9, 2018, at 2:29 PM, Bryan Oliver 
> wrote:
> >
> > Hey, I'm new to the mailing list (signed up today!) and to using
> Subsurface (I am however a dev, so figured I'd just jump in head-first when
> I found this project).
>
> Yay! We love seeing new users and even more love seeing new developers!
>
> > I noticed when I ran the QT 5.11.1 built on MBP (High Sierra 10.13.4)
> and clicked:
> >
> > Log => Add Dive => Photos => Load Image(s) from File(s)
> > - then I select an image (jpg) from file explorer, and hit enter
> >
> > Then the app crashes.
>
> So this is with the binary I referenced below, not with something you
> built from source, correct?
>
> > Didn't CC the list, wasn't sure if I should? Mainly wasn't sure if this
> was a real problem or if I'm just a supernoob to SS and screwed something
> up.
>
> Yes, please always Cc the list when you think you find bugs or problems. I
> took the liberty of simply adding the list here.
> And plse don't call the project SS - that's the Schutz Staffel of
> Nazi Germany and some of us (like, err, me) really don't like that
> abbreviation used for Subsurface... If you really have to use an
> abbreviation, ssrf might work. But it's not that many letters, is it?
>
> > Let me know if I should go digging for logs or if you were able to
> replicate. Can also make a mini-video.
>
> Typically when an app crashes on the Mac it offers to report the bug. Take
> it up on that offer and look at the stack traces that it shows - especially
> for the thread that crashed. Then send that stack trace with your report.
> Or dig in and fix the bug :-)
>
> In this case I wasn't able to reproduce your crash here - but that might
> only mean that I didn't quite hit the scenario that you used in the first
> place. Can you give more information, maybe even send a test image plus the
> precise steps to reproduce this?
>
> Thanks so much
>
> And again: WELCOME
>
> /D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Mac test build based on Qt5.11.1 - please test

[Dirk Hohndel]

Hi Bryan

> On Jul 9, 2018, at 2:29 PM, Bryan Oliver  wrote:
> 
> Hey, I'm new to the mailing list (signed up today!) and to using Subsurface 
> (I am however a dev, so figured I'd just jump in head-first when I found this 
> project).

Yay! We love seeing new users and even more love seeing new developers!

> I noticed when I ran the QT 5.11.1 built on MBP (High Sierra 10.13.4) and 
> clicked:
> 
> Log => Add Dive => Photos => Load Image(s) from File(s)
> - then I select an image (jpg) from file explorer, and hit enter
> 
> Then the app crashes.

So this is with the binary I referenced below, not with something you built 
from source, correct?

> Didn't CC the list, wasn't sure if I should? Mainly wasn't sure if this was a 
> real problem or if I'm just a supernoob to SS and screwed something up.

Yes, please always Cc the list when you think you find bugs or problems. I took 
the liberty of simply adding the list here. 
And plse don't call the project SS - that's the Schutz Staffel of Nazi 
Germany and some of us (like, err, me) really don't like that abbreviation used 
for Subsurface... If you really have to use an abbreviation, ssrf might work. 
But it's not that many letters, is it? 

> Let me know if I should go digging for logs or if you were able to replicate. 
> Can also make a mini-video.

Typically when an app crashes on the Mac it offers to report the bug. Take it 
up on that offer and look at the stack traces that it shows - especially for 
the thread that crashed. Then send that stack trace with your report. Or dig in 
and fix the bug :-)

In this case I wasn't able to reproduce your crash here - but that might only 
mean that I didn't quite hit the scenario that you used in the first place. Can 
you give more information, maybe even send a test image plus the precise steps 
to reproduce this?

Thanks so much

And again: WELCOME

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [RFC] UI: Rename "photos"/"images" to a term covering videos as well

[Lubomir I. Ivanov]

On 9 July 2018 at 23:33, Stefan Fuchs  wrote:
> Hello,
>
> thanks to Berthold we have the video "lite" support in master now. As a
> reference please see:
> https://github.com/Subsurface-divelog/subsurface/pull/1463
>
> Now I think we should adapt the UI in a way that we rename almost every
> occurrence of the term "photos" and "images" to s.th. which covers images
> and videos.
> What do you think? How should we adapt it?
>

photos, pictures, images, video, audio etc. falls under "media".

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [RFC] UI: Rename "photos"/"images" to a term covering videos as well

[Dirk Hohndel]

> On Jul 9, 2018, at 1:33 PM, Stefan Fuchs  wrote:
> 
> Hello,
> 
> thanks to Berthold we have the video "lite" support in master now. As a 
> reference please see:
> https://github.com/Subsurface-divelog/subsurface/pull/1463 
> 
> Now I think we should adapt the UI in a way that we rename almost every 
> occurrence of the term "photos" and "images" to s.th . which 
> covers images and videos.
> What do you think? How should we adapt it?
> 
> I tried to quickly extract a list of relevant strings from Transifex. Not 
> sure that I already catched everything. English plus German translations:
> 
> Photos
> Bilder
> Find moved images
> Verschobene Bilder finden
> Found images
> Bilder gefunden
> Match only images in selected dive(s)
> Nur Bilder von ausgewählten Tauchgäng(en) berücksichtigen
> No matching images found
> Keine passenden Bilder gefunden
> Found %1 images at their current place.
> %1 Bilder am ursprünglichen Ort gefunden.
> Found %1 images at new locations:
> %1 Bilder an neuem Ort gefunden:
> Photos
> Bilder
> Toggle pictures
> Bilder umschalten
>  moved images
>  verschobene Bilder
> Recalculate thumbnails if older than image
> Erstelle Miniaturbilder neu wenn es älter ist als das Bild
> Warning!⏎Not all images have timestamps in the range between⏎30 minutes 
> before the start and 30 minutes after the end of any selected dive.
> Achtung!⏎Nicht alle Bilder haben Zeitstempel zwischen 30min vor und 30min 
> nach einem der ausgewählten Tauchgänge.
> Load images even if the time does not match the dive time
> Bilder laden, selbst wenn die Zeit nicht der Tauchzeit entspricht
> Photos
> Bilder
> Delete selected images
> Ausgewählte Bilder löschen
> Delete all images
> Alle Bilder Löschen
> Recalculate selected thumbnails
> Ausgewählte Miniaturbilder neu erstellen
> Deleting Images
> Bilder löschen
> Are you sure you want to delete all images?
> Wirklich alle Bilder löschen?
> Enter URL for images
> URL für Bilder eingeben

That's quite a few strings. And I'm not sure if there is a generic term that 
captures what we are looking for.
In a way, util / unless we actually play videos, it's still just "pictures" and 
"thumbnails", right?
Writing "pictures/videos" is very awkward... I don't really have a bright idea 
here

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: on our way to Qt 5.11.1

[Dirk Hohndel]

> On Jul 9, 2018, at 1:42 PM, Stefan Fuchs  wrote:
> I think they do have 5.11.1:
> https://github.com/mxe/mxe/commit/2de6bde8c4949c67306882f5fe68f1c6db233609 
> 

No idea how I missed that.

> But regarding QtWebKit I think you are right. As far as I can remember I saw 
> an issue with building QtWebKit plus the issue with QtPositioning. So I'm 
> also not very motivated. For the moment I'll join the "wait and see" approach 
> - sorry ;-)

Refresh my memory about QtPositioning, please...

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: on our way to Qt 5.11.1

[Stefan Fuchs]

Hallo Dirk,


Am 09.07.2018 um 21:56 schrieb Dirk Hohndel:
>
> Mac seems to work (and besides my own stupidity making it hard to get
> it into Travis, this one is "done").
> iOS I just started testing, but looks good so far.
>
> MXE is a problem. They don't have 5.11.1, yet, and 5.11.0 breaks
> QtWebKit on MXE (they don't build 5.212 but an older version). Right
> now I think I'll take a "wait and see" approach, unless someone here
> feels motivated to try and figure this out... interesting issues to
> look at
> are https://github.com/mxe/mxe/issues/2160 and 
> https://github.com/mxe/mxe/issues/2070
>
I think they do have 5.11.1:
https://github.com/mxe/mxe/commit/2de6bde8c4949c67306882f5fe68f1c6db233609

But regarding QtWebKit I think you are right. As far as I can remember I
saw an issue with building QtWebKit plus the issue with QtPositioning.
So I'm also not very motivated. For the moment I'll join the "wait and
see" approach - sorry ;-)

Best regards
Stefan

-- 

Stefan Fuchs
E-Mail: sfu...@gmx.de 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

[RFC] UI: Rename "photos"/"images" to a term covering videos as well

[Stefan Fuchs]

Hello,

thanks to Berthold we have the video "lite" support in master now. As a
reference please see:
https://github.com/Subsurface-divelog/subsurface/pull/1463

Now I think we should adapt the UI in a way that we rename almost every
occurrence of the term "photos" and "images" to s.th. which covers
images and videos.
What do you think? How should we adapt it?

I tried to quickly extract a list of relevant strings from Transifex.
Not sure that I already catched everything. English plus German
translations:

Photos
Bilder
Find moved images
Verschobene Bilder finden
Found images
Bilder gefunden
Match only images in selected dive(s)
Nur Bilder von ausgewählten Tauchgäng(en) berücksichtigen
No matching images found
Keine passenden Bilder gefunden
Found %1 images at their current place.
%1Bilder am ursprünglichen Ort gefunden.
Found %1 images at new locations:
%1 Bilder an neuem Ort gefunden:
Photos
Bilder
Toggle pictures
Bilder umschalten
 moved images
 verschobene Bilder
Recalculate thumbnails if older than image
Erstelle Miniaturbilder neu wenn es älter ist als das Bild
Warning!⏎Not all images have timestamps in the range between⏎30 minutes
before the start and 30 minutes after the end of any selected dive.
Achtung!⏎Nicht alle Bilder haben Zeitstempel zwischen 30min vor und
30min nach einem der ausgewählten Tauchgänge.
Load images even if the time does not match the dive time
Bilder laden, selbst wenn die Zeit nicht der Tauchzeit entspricht
Photos
Bilder
Delete selected images
Ausgewählte Bilder löschen
Delete all images
Alle Bilder Löschen
Recalculate selected thumbnails
Ausgewählte Miniaturbilder neu erstellen
Deleting Images
Bilder löschen
Are you sure you want to delete all images?
Wirklich alle Bilder löschen?
Enter URL for images
URL für Bilder eingeben


Best regards
Stefan

-- 

Stefan Fuchs
E-Mail: sfu...@gmx.de 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

on our way to Qt 5.11.1

[Dirk Hohndel]

Mac seems to work (and besides my own stupidity making it hard to get it into 
Travis, this one is "done").
iOS I just started testing, but looks good so far.

MXE is a problem. They don't have 5.11.1, yet, and 5.11.0 breaks QtWebKit on 
MXE (they don't build 5.212 but an older version). Right now I think I'll take 
a "wait and see" approach, unless someone here feels motivated to try and 
figure this out... interesting issues to look at are 
https://github.com/mxe/mxe/issues/2160  
and https://github.com/mxe/mxe/issues/2070 


Haven't looked at Android and Linux/AppImage, yet.

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Mac test build based on Qt5.11.1 - please test

[Dirk Hohndel]

Murillo,

> On Jul 9, 2018, at 10:22 AM, Murillo Bernardes  wrote:
> 
>> http://subsurface-divelog.org/downloads/test/Subsurface-4.8.0-66-g12519af8b434.dmg
>> 
>> I'd really appreciate if the Mac owners could once again give this a good 
>> test. Please especially test things that we don't spend as much time with - 
>> dive computer configuration, FB, user manual, filtering, etc. I haven't 
>> forgotten about the question regarding print quality - it's on my TODO list, 
>> but I first wanted to get the crashes sorted out.
>> 
> 
> - Facebook works, post correctly.
> - User manual works, looks good.
> - Filtering works correctly, although the "clear" icons seems weird,
> but looks like this happens on previous versions as well.
> - Downloads correctly from Shearwater Petrel AI (BLE) and Oceanic OCi 
> (serial).
> - I don't have a computer that can be configured, so not tested.

Thank you so much for that detailed test. That's really appreciated.
I noticed an oddity in the way I build the binaries, so I'm making some changes 
to the build setup and will have another test binary in a little while, but 
this is all very encouraging.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Mac test build based on Qt5.11.1 - please test

[Murillo Bernardes]

On Mon, Jul 9, 2018 at 6:23 PM Dirk Hohndel  wrote:
>
> OK, going back to the beginning of the thread with an update...
>
> It turns out (and I am VERY happy about that) that the Facebook and User 
> Manual crashes were caused by mis-compilation of QtWebKit. With the help of 
> the maintainer I got that sorted and I think I now have a binary that works 
> again.
>

Great news.

> http://subsurface-divelog.org/downloads/test/Subsurface-4.8.0-66-g12519af8b434.dmg
>
> I'd really appreciate if the Mac owners could once again give this a good 
> test. Please especially test things that we don't spend as much time with - 
> dive computer configuration, FB, user manual, filtering, etc. I haven't 
> forgotten about the question regarding print quality - it's on my TODO list, 
> but I first wanted to get the crashes sorted out.
>

- Facebook works, post correctly.
- User manual works, looks good.
- Filtering works correctly, although the "clear" icons seems weird,
but looks like this happens on previous versions as well.
- Downloads correctly from Shearwater Petrel AI (BLE) and Oceanic OCi (serial).
- I don't have a computer that can be configured, so not tested.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Mac test build based on Qt5.11.1 - please test

[Dirk Hohndel]

OK, going back to the beginning of the thread with an update...

It turns out (and I am VERY happy about that) that the Facebook and User Manual 
crashes were caused by mis-compilation of QtWebKit. With the help of the 
maintainer I got that sorted and I think I now have a binary that works again.

http://subsurface-divelog.org/downloads/test/Subsurface-4.8.0-66-g12519af8b434.dmg

I'd really appreciate if the Mac owners could once again give this a good test. 
Please especially test things that we don't spend as much time with - dive 
computer configuration, FB, user manual, filtering, etc. I haven't forgotten 
about the question regarding print quality - it's on my TODO list, but I first 
wanted to get the crashes sorted out.

If this looks stable, I'll aim for a 4.8.1 fairly quickly...

/D

> On Jul 6, 2018, at 10:46 PM, Dirk Hohndel  wrote:
> 
> Hi
> 
> If you have access to a Mac (running macOS 10.11 or newer - 10.10 is no 
> longer supported), I'd appreciate if you could test the latest binary that I 
> have created.
> This still crashes with the user manual, so Qt5.11.1 wasn't the magic fix for 
> that. But this gets us ready to experiment with the QML compiler...
> 
> http://subsurface-divelog.org/downloads/test/Subsurface-4.8.0-48-g03bc40194d26.dmg
> 
> This binary was created on a different Mac - I'm in the process of shifting 
> the infrastructure that I use to build Mac and iOS binaries, so I want to 
> make double certain that this gets well tested.
> 
> I hope I'll have time this weekend to update Travis to also build macOS 
> against the same Qt5.11.1 and then work on migrating iOS to that version as 
> well (including Travis).
> 
> Thanks for your help
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface