Re: Extra Data tab in desktopversion (Willem Ferguson)

[Hartley Horwitz]

-- Forwarded message --

> From: Willem Ferguson 
> To: Subsurface Mailing List 
> Cc:
> Bcc:
> Date: Sun, 14 Apr 2019 09:36:23 +0200
> Subject: Extra Data tab in desktopversion
> This discussion continues the topic of including an editable atmospheric
> pressure textbox in the Notes Tab. The discussion then revolved around
> moving some of the data items to a different tab.
>
> I have five proposals.
>
> 1) Any extraneous information is moved to the existing Extra Info tab.
> For many (if not most) recreational dive computers this tab is not used.
> So, if any information is to be moved out of the Notes Tab an additional
> new tab is probably not warranted. However, this means that there would
> now be a third tab that contains editable data fields (apart from Notes
> and Equipment).
>

[HH]  I'm a recreational and as you've guessed, I don't use the Extra Info
tab.  I'd be ok to move the less used info to that tab.

>
> 2) If the above were true, the UI would be simplified if the tabs with
> editable data fields were grouped together. That would mean rearranging
> the tabs so that Extra Info is in the third position just after Equipment.
>

[HH] Rearranging the order of the tabs is a nice to have, not a must IMO.

>
> 3) I suggest that the two temperature text boxes are moved to the Extra
> Info tab. The water temperature is depicted in great detail on the dive
> profile, so no information is lost.
>

[HH] Agreed.

>
> 4) I expressed an opinion beforehand that any information that affects
> the deco ceiling should be immediately visible. One of these is the dive
> mode. When logging a dive, I often found that Subsurface defaults to a
> wrong dive mode. My Petrel does not provide the information, therefore
> this has to be set by hand using the Dive Mode dropdown box. No fault of
> Subsurface. Therefore my strong preference is for the Dive Mode dropdown
> box to be kept on the Notes tab and not moved to the Extra Info tab. If
> indeed, the Dive Mode dropdown box is moved to the Extra Info tab, I
> would expect (almost 'demand') a clear indication on the dive profile
> that shows the dive mode. (Maybe as part of the deco model info e.g.
> "VPM-B +3  (Open Circuit)" or "GF 40/75 (CCR)").
>

[HH] prior to reading this, I would have suggested moving the Dive Mode off
of the Notes tab, but you have a compelling point.


>
> 5) I propose that the Atmospheric pressure datum remains on the Notes
> tab and is not moved to the Extra Info tab. The reason is that, for
> inland dives, this is likely to be crucial information with respect to
> the deco ceiling. I regard this information as so important that, if
> this datum was indeed moved to the Extra Info tab, that it should also
> be indicated somewhere on the dive profile or on the Notes tab. I must
> confess that I am probably biased because I do many inland dives over
> 1000m. For me this would not make a difference because my dive computer
> records atmospheric pressure in calculating deco. But many other divers
> that dive these same sites do not have access to atmospheric pressure
> and without having done Dive-at-altitude training and I have seen what
> altitude can do to the deco ceiling. Therefore my emphasis on this matter.
>

[HH] as a percentage of users, I'm guessing those needing to adjust
pressure is very small. In that sense, I'd rather see that info moved to
Extra info.  If you want an indicator on the profile that would be ok, but
I guess that's harder to code?   In general, I think the UI should have the
least clutter for 80% of the users, and that's why I think the atmospheric
pressure and air temperature (and water temp) should be moved off the main
Notes tab.


>
>
> Opinions. please.
>
> willem
>
>
...Hartley
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Dive planner: SAC

[Robert Helling]

> On 14. Apr 2019, at 18:45, Berthold Stoeger  
> wrote:
> 
> if I comment out the changes to planner.c introduced in 5e494ce761 (Show a bit
> of surface degassing in the planner), then the scary line goes away.

Yes, this sounds like I screwed up. Will look into this.

Best
Robert


signature.asc
Description: Message signed with OpenPGP
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Problems with Changing Date from Dive

[Berthold Stoeger]

Hi Alexander,

On Sonntag, 14. April 2019 19:30:37 CEST Alexander Maier wrote:
> Today I have seen a problem with changing the date from a imported dive. The
> imported date was 12th April 2019. I changed it to 14th April 2019. After
> saving the dive I have seen 6th April 2019. If I change the date once more
> the saved date is always a week more in the past.

This is a known bug, which will be fixed in the up-coming release. The 
official release should be out any day now, but you can already download it 
(see mailing list thread).

In the broken version, if you want to move your dive forward one week, you 
have to move it back and vice-versa. And no, that doesn't make any sense. :-P

Berthold


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Problems with Changing Date from Dive

[Alexander Maier]

Today I have seen a problem with changing the date from a imported dive. The 
imported date was 12th April 2019. I changed it to 14th April 2019. After 
saving the dive I have seen 6th April 2019. If I change the date once more the 
saved date is always a week more in the past.

I use Subsurface 4.8.5 on Mac and Windows on German systems.

Changing the date on iOS App works well :)

--- 

Alexander Maier
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Options for importing dive sites from XML into Subsurface

[Doug Junkins]

> On Apr 14, 2019, at 10:11 AM, Berthold Stoeger  
> wrote:
> 
> Doug,
> 
> On Sonntag, 14. April 2019 18:43:33 CEST Doug Junkins wrote:
>> I’ve been looking at the code to try to figure out the best way to add the
>> capability to import an XML file of dive sites to the Subsurface dive site
>> table. Looking at the existing dive log import code, it may be possible to
>> simply modify the dive log import code to be able to process an XML file
>> that only includes dive sites.
>> 
>> This would involve modifying the ‘process_imported_dives’ function in
>> core/divelist.c to not filter sites that are not used by the imported dives
>> and to process files even if the number of imported dives is zero. This
>> would keep the XML import code consolidated in one place, but it would blur
>> the separation of dive processing and dive site processing that we are
>> trying to create.
>> 
>> The other alternative is to replicate the ‘process_imported_dives’ function
>> as something like ‘process_imported_divesites’ in core/divesites.c and add
>> a new, separate menu option to import dive site XML files, but then there a
>> lot of duplicate code to maintain.
> 
> I think I would prefer the second option. Conceptually, these are different 
> things and we are more flexible that way. We might present the user different 
> merging options (determine duplicates by name, by distance), prefer data from 
> old or imported dive sites, etc. The whole process_imported_divesites logic 
> is 
> only a few lines. I wonder if we need such a function at all. Checking for 
> duplicates could be done in the UndoCommand. If you give me a day or two I 
> will write such a command. The only thing to do then is to get the parser to 
> return a dive_site_table.

Sounds good, Berthold.

-D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Options for importing dive sites from XML into Subsurface

[Berthold Stoeger]

Doug,

On Sonntag, 14. April 2019 18:43:33 CEST Doug Junkins wrote:
> I’ve been looking at the code to try to figure out the best way to add the
> capability to import an XML file of dive sites to the Subsurface dive site
> table. Looking at the existing dive log import code, it may be possible to
> simply modify the dive log import code to be able to process an XML file
> that only includes dive sites.
> 
> This would involve modifying the ‘process_imported_dives’ function in
> core/divelist.c to not filter sites that are not used by the imported dives
> and to process files even if the number of imported dives is zero. This
> would keep the XML import code consolidated in one place, but it would blur
> the separation of dive processing and dive site processing that we are
> trying to create.
> 
> The other alternative is to replicate the ‘process_imported_dives’ function
> as something like ‘process_imported_divesites’ in core/divesites.c and add
> a new, separate menu option to import dive site XML files, but then there a
> lot of duplicate code to maintain.

I think I would prefer the second option. Conceptually, these are different 
things and we are more flexible that way. We might present the user different 
merging options (determine duplicates by name, by distance), prefer data from 
old or imported dive sites, etc. The whole process_imported_divesites logic is 
only a few lines. I wonder if we need such a function at all. Checking for 
duplicates could be done in the UndoCommand. If you give me a day or two I 
will write such a command. The only thing to do then is to get the parser to 
return a dive_site_table.

Berthold


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Dive planner: SAC

[Berthold Stoeger]

Hi Robert,

On Sonntag, 14. April 2019 15:38:28 CEST Philippe Massart wrote:

> Some strange behavior in the dive planner, between 4.8.6 (released version)
> and the latest master from git

if I comment out the changes to planner.c introduced in 5e494ce761 (Show a bit 
of surface degassing in the planner), then the scary line goes away.

This is code way over my head.

Berthold


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Options for importing dive sites from XML into Subsurface

[Doug Junkins]

I’ve been looking at the code to try to figure out the best way to add the 
capability to import an XML file of dive sites to the Subsurface dive site 
table. Looking at the existing dive log import code, it may be possible to 
simply modify the dive log import code to be able to process an XML file that 
only includes dive sites.

This would involve modifying the ‘process_imported_dives’ function in 
core/divelist.c to not filter sites that are not used by the imported dives and 
to process files even if the number of imported dives is zero. This would keep 
the XML import code consolidated in one place, but it would blur the separation 
of dive processing and dive site processing that we are trying to create.

The other alternative is to replicate the ‘process_imported_dives’ function as 
something like ‘process_imported_divesites’ in core/divesites.c and add a new, 
separate menu option to import dive site XML files, but then there a lot of 
duplicate code to maintain.

Any input would be appreciated.

-Doug
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Extra Data tab in desktopversion

[Peter Zaal]

Hi Willem, Dirk,


On Sun, Apr 14, 2019 at 4:23 PM Dirk Hohndel  wrote:

> Hi Willem,
>
> > On Apr 14, 2019, at 12:36 AM, Willem Ferguson <
> willemfergu...@zoology.up.ac.za> wrote:
> >
> > This discussion continues the topic of including an editable atmospheric
> pressure textbox in the Notes Tab. The discussion then revolved around
> moving some of the data items to a different tab.
> >
> > I have five proposals.
> >
> > 1) Any extraneous information is moved to the existing Extra Info tab.
> For many (if not most) recreational dive computers this tab is not used.
> So, if any information is to be moved out of the Notes Tab an additional
> new tab is probably not warranted. However, this means that there would now
> be a third tab that contains editable data fields (apart from Notes and
> Equipment).
>
> This does change the notion of the Extra data tab a little bit, but the
> way this is defined today maybe only makes sense if you wrote the code -
> from a users perspective this distinction (basically, this tab shows the
> information we get as string data from the dive computer) is maybe less
> obvious - I guess it could be defined as dive computer internals or
> something.
> But let me ask you, why add it to that tab and not use the Information
> tab? This one already contains another (mislabeled, I notice) field that
> some people might want to edit: dive time (which should be dive duration).
> And it contains the atmospheric pressure. So instead of adding this to
> Extra info tab, wouldn't it make more sense to make some of the fields on
> the Info tab editable? I don't think it makes sense to allow users to edit
> things like the Interval or CNS / OTU, but I could see editing duration,
> air pressure (atmospheric pressure would be a better label, but air
> pressure is shorter), water type (specific weight, really) and air
> temperature (oops, that's not in sync with the Notes tab for me) here?
>
> Thoughts?
>

Imho I would indeed not add yet another tab. I fully agree on using the
Information tab to edit some of the data. Although most information is
display-only and/or calculated information, some of the information could
be editable.  (actually I am not sure about CNS and OTU, are these
calculated or imported from the dive computer? But anyway probably not
something you want to edit)

>
> > 2) If the above were true, the UI would be simplified if the tabs with
> editable data fields were grouped together. That would mean rearranging the
> tabs so that Extra Info is in the third position just after Equipment.
>
> That's the position the Information tab is already in, another advantage
> of my proposal.
>

Yes, although one could look at (re)arranging the information, so that
there's a group of display-only and a group of editable information.

> 3) I suggest that the two temperature text boxes are moved to the Extra
> Info tab. The water temperature is depicted in great detail on the dive
> profile, so no information is lost.
>
> They are both already on the Information tab - except, as I said, Air
> temperature is not in sync for me. Need to look at the code why that is.
>

Yes could be editable on the Information tab.
For me personally, I would actually regret to see the temperatures moving
away from the Notes tab. I mean, on a dive site the most frequent asked
questions I hear are usually: what did you see, how was visibility, and
what's the water temperature? Also on recreational dives, which are
problably the most logged dives, the temperature is often displayed on the
main screen of the dive computer. It seems like temperature is seen as one
the more eminent dive characteristics.
I always like to keep note of the air temp myself, because it's nice to
compare over longer period of time (years even) for a dive site, so for me
I like it that it's on the main Notes tab.

Btw, Air temp is in sync with my: editing this on the Notes tab displays
the same value on the Information tab.


> > 4) I expressed an opinion beforehand that any information that affects
> the deco ceiling should be immediately visible. One of these is the dive
> mode. When logging a dive, I often found that Subsurface defaults to a
> wrong dive mode. My Petrel does not provide the information, therefore this
> has to be set by hand using the Dive Mode dropdown box. No fault of
> Subsurface. Therefore my strong preference is for the Dive Mode dropdown
> box to be kept on the Notes tab and not moved to the Extra Info tab. If
> indeed, the Dive Mode dropdown box is moved to the Extra Info tab, I would
> expect (almost 'demand') a clear indication on the dive profile that shows
> the dive mode. (Maybe as part of the deco model info e.g. "VPM-B +3  (Open
> Circuit)" or "GF 40/75 (CCR)").
>
> I like showing this as part of the deco model info.
> And I think the majority of our users are OC-only divers. So we COULD move
> this to be only on the Information tab to de-clutter the Notes tab. But
> then, I don't see this as a 

Re: dive sites, edit undo, and the major steps towards 4.9

[Willem Ferguson]

On 2019/04/14 16:03, Dirk Hohndel wrote:

On Apr 14, 2019, at 1:50 AM, Willem Ferguson  
wrote:

1) The dive site panel makes huge strides towards a robust but flexible 
interface for working with dive sites. The current actions are:

a) Edit a dive site

b) Delete a dive site

For those that have strong feelings about dive sites, one would like to have an 
option of:

c) Create a dive site

I can see the logic in that. I'd be unlikely to use this as that's not how I 
approach diving, but simply with the concept of dive sites as first class 
citizens in mind, this seems entirely reasonable.
Before we go off and do that, let's see if there are people here who WOULD use 
that and what work flow they would like to use.


However, one that I am very likely to use is:

d) Merge dive sites

As was apparent in the discussions on this topic I also have many duplicate 
dive sites and they definitely need reorganisation.

What is the sentiment and/or intentions about having these two additional 
actions on dive sites?

As Berthold mentioned, this exists. And it's a hard to "discover" feature right 
now, so I think it can be improved.
Instead of making this a right click option, why don't we make two relatively 
small changes
(1) as the user clicks on one of those sites, show the corresponding flag in 
the map as well (if necessary, zoom out to include both the site being edited, 
and the one the user selected)
(2) just like the edit and delete column in the main dive list are actually buttons that 
trigger an action, have a column with a "Merge" button

I think that would make the UI much easier to discover.


And, completely unrelated... Berthold - the row selection with the trash can 
not changing background color... that's an odd one :-)

/D.


Two suggestions that I have for the Dive Sites tab.

1) When hitting the + at the top right to add a dive site (thank you, 
Doug), open the dive site edit panel directly. In other words as if, 
after clicking the +, one has also clicked the Edit icon of the new dive 
that has been created.


2) When the dive sites close to a specific site have been selected, in 
other words there are a small number of sites listed in the part of the 
panel for 'Closeby sites', it would be really useful if the geographic 
coordinates for each site are showed in a second column of the table of 
closeby sites.


I support Dirk's suggestion of coordinating the closeby sites with the map.

Kind regars,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Dive planner: SAC

[Berthold Stoeger]

Hi Philippe,

On Sonntag, 14. April 2019 15:38:28 CEST Philippe Massart wrote:
> 
> When doing the same with the latest master from Git (OS X), one line is
> added, with a huge amount of liters! I tested the same from a fresh
> raspberry (Raspbian) compilation from git, same « strange » new  line.

Thanks for your report. This looks like the gases-array is not initialized 
correctly. Probably a fallout from the undo changes. I will try to find the 
cause later today.

Berthold


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: dive sites, edit undo, and the major steps towards 4.9

[Doug Junkins]

> On Apr 14, 2019, at 7:03 AM, Dirk Hohndel  wrote:
> 
> 
>> On Apr 14, 2019, at 1:50 AM, Willem Ferguson 
>>  wrote:
>> 
>> For those that have strong feelings about dive sites, one would like to have 
>> an option of:
>> 
>> c) Create a dive site
> 
> I can see the logic in that. I'd be unlikely to use this as that's not how I 
> approach diving, but simply with the concept of dive sites as first class 
> citizens in mind, this seems entirely reasonable.
> Before we go off and do that, let's see if there are people here who WOULD 
> use that and what work flow they would like to use.

The ‘create dive’ functionality already exists with the small ‘+’ sign near the 
upper right corner of the table on the dive site tab. I think from a usability 
perspective, that could be improved, but that is a UI nit rather than a feature 
request.

-Doug

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Extra Data tab in desktopversion

[Dirk Hohndel]

Hi Willem,

> On Apr 14, 2019, at 12:36 AM, Willem Ferguson 
>  wrote:
> 
> This discussion continues the topic of including an editable atmospheric 
> pressure textbox in the Notes Tab. The discussion then revolved around moving 
> some of the data items to a different tab.
> 
> I have five proposals.
> 
> 1) Any extraneous information is moved to the existing Extra Info tab. For 
> many (if not most) recreational dive computers this tab is not used. So, if 
> any information is to be moved out of the Notes Tab an additional new tab is 
> probably not warranted. However, this means that there would now be a third 
> tab that contains editable data fields (apart from Notes and Equipment).

This does change the notion of the Extra data tab a little bit, but the way 
this is defined today maybe only makes sense if you wrote the code - from a 
users perspective this distinction (basically, this tab shows the information 
we get as string data from the dive computer) is maybe less obvious - I guess 
it could be defined as dive computer internals or something.
But let me ask you, why add it to that tab and not use the Information tab? 
This one already contains another (mislabeled, I notice) field that some people 
might want to edit: dive time (which should be dive duration). And it contains 
the atmospheric pressure. So instead of adding this to Extra info tab, wouldn't 
it make more sense to make some of the fields on the Info tab editable? I don't 
think it makes sense to allow users to edit things like the Interval or CNS / 
OTU, but I could see editing duration, air pressure (atmospheric pressure would 
be a better label, but air pressure is shorter), water type (specific weight, 
really) and air temperature (oops, that's not in sync with the Notes tab for 
me) here?

Thoughts?

> 2) If the above were true, the UI would be simplified if the tabs with 
> editable data fields were grouped together. That would mean rearranging the 
> tabs so that Extra Info is in the third position just after Equipment.

That's the position the Information tab is already in, another advantage of my 
proposal.

> 3) I suggest that the two temperature text boxes are moved to the Extra Info 
> tab. The water temperature is depicted in great detail on the dive profile, 
> so no information is lost.

They are both already on the Information tab - except, as I said, Air 
temperature is not in sync for me. Need to look at the code why that is.

> 4) I expressed an opinion beforehand that any information that affects the 
> deco ceiling should be immediately visible. One of these is the dive mode. 
> When logging a dive, I often found that Subsurface defaults to a wrong dive 
> mode. My Petrel does not provide the information, therefore this has to be 
> set by hand using the Dive Mode dropdown box. No fault of Subsurface. 
> Therefore my strong preference is for the Dive Mode dropdown box to be kept 
> on the Notes tab and not moved to the Extra Info tab. If indeed, the Dive 
> Mode dropdown box is moved to the Extra Info tab, I would expect (almost 
> 'demand') a clear indication on the dive profile that shows the dive mode. 
> (Maybe as part of the deco model info e.g. "VPM-B +3  (Open Circuit)" or "GF 
> 40/75 (CCR)").

I like showing this as part of the deco model info.
And I think the majority of our users are OC-only divers. So we COULD move this 
to be only on the Information tab to de-clutter the Notes tab. But then, I 
don't see this as a requirement since if we do that the tags entry gets quite 
long...
On the flip side - for me the notes field is always too small... so moving tags 
up to be on the same line with date and time (where right now we have air and 
water temp) and have air temp, water temp, and dive mode all on the Information 
tab... that I could easily get behind :-)

> 5) I propose that the Atmospheric pressure datum remains on the Notes tab and 
> is not moved to the Extra Info tab. The reason is that, for inland dives, 
> this is likely to be crucial information with respect to the deco ceiling. I 
> regard this information as so important that, if this datum was indeed moved 
> to the Extra Info tab, that it should also be indicated somewhere on the dive 
> profile or on the Notes tab. I must confess that I am probably biased because 
> I do many inland dives over 1000m. For me this would not make a difference 
> because my dive computer records atmospheric pressure in calculating deco. 
> But many other divers that dive these same sites do not have access to 
> atmospheric pressure and without having done Dive-at-altitude training and I 
> have seen what altitude can do to the deco ceiling. Therefore my emphasis on 
> this matter.

Well, we don't have that on the Notes tab right now. Alternatively to my 
proposal, this could of course be put in the place of the air temperature. 
Unsurprisingly I like my proposal better, but let's see what others think.

To make it clearer, I suggest we have the Notes 

Re: dive sites, edit undo, and the major steps towards 4.9

[Dirk Hohndel]

> On Apr 14, 2019, at 1:50 AM, Willem Ferguson 
>  wrote:
> 
> 1) The dive site panel makes huge strides towards a robust but flexible 
> interface for working with dive sites. The current actions are:
> 
> a) Edit a dive site
> 
> b) Delete a dive site
> 
> For those that have strong feelings about dive sites, one would like to have 
> an option of:
> 
> c) Create a dive site

I can see the logic in that. I'd be unlikely to use this as that's not how I 
approach diving, but simply with the concept of dive sites as first class 
citizens in mind, this seems entirely reasonable.
Before we go off and do that, let's see if there are people here who WOULD use 
that and what work flow they would like to use.

> However, one that I am very likely to use is:
> 
> d) Merge dive sites
> 
> As was apparent in the discussions on this topic I also have many duplicate 
> dive sites and they definitely need reorganisation.
> 
> What is the sentiment and/or intentions about having these two additional 
> actions on dive sites?

As Berthold mentioned, this exists. And it's a hard to "discover" feature right 
now, so I think it can be improved.
Instead of making this a right click option, why don't we make two relatively 
small changes
(1) as the user clicks on one of those sites, show the corresponding flag in 
the map as well (if necessary, zoom out to include both the site being edited, 
and the one the user selected)
(2) just like the edit and delete column in the main dive list are actually 
buttons that trigger an action, have a column with a "Merge" button

I think that would make the UI much easier to discover.


And, completely unrelated... Berthold - the row selection with the trash can 
not changing background color... that's an odd one :-)

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: dive sites, edit undo, and the major steps towards 4.9

[Willem Ferguson]

Thanks so much, Berthold. Wf

On Sun, 14 Apr 2019, 11:57 Berthold Stoeger  Hi Willem,
>
> On Sonntag, 14. April 2019 10:50:50 CEST Willem Ferguson wrote:
>
> > d) Merge dive sites
> >
> > As was apparent in the discussions on this topic I also have many
> > duplicate dive sites and they definitely need reorganisation.
>
> If the dive sites have coordinates, you can do this in current master:
> - Edit the dive site.
> - At the bottom there is a list of "close" sites.
> - You can change the value of "close" to something appropriate (e.g. 1000
> m).
> - Select the sites you want to merge in the list.
> - Right mouse click -> merge sites.
>
> We could extend the list of "close" sites to feature a text filter, if
> that's
> preferred.
>
> I'll try to remember to add the "close site" thing to the CHANGELOG.
>
> Berthold
>
>
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: dive sites, edit undo, and the major steps towards 4.9

[Berthold Stoeger]

Hi Willem,

On Sonntag, 14. April 2019 10:50:50 CEST Willem Ferguson wrote:

> d) Merge dive sites
> 
> As was apparent in the discussions on this topic I also have many
> duplicate dive sites and they definitely need reorganisation.

If the dive sites have coordinates, you can do this in current master:
- Edit the dive site.
- At the bottom there is a list of "close" sites.
- You can change the value of "close" to something appropriate (e.g. 1000 m).
- Select the sites you want to merge in the list.
- Right mouse click -> merge sites. 

We could extend the list of "close" sites to feature a text filter, if that's 
preferred.

I'll try to remember to add the "close site" thing to the CHANGELOG.

Berthold


___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: dive sites, edit undo, and the major steps towards 4.9

[Willem Ferguson]

Question:

1) The dive site panel makes huge strides towards a robust but flexible 
interface for working with dive sites. The current actions are:


a) Edit a dive site

b) Delete a dive site

For those that have strong feelings about dive sites, one would like to 
have an option of:


c) Create a dive site

I would never use this, but the conversation over the last month 
articulated a need for such a facility.


However, one that I am very likely to use is:

d) Merge dive sites

As was apparent in the discussions on this topic I also have many 
duplicate dive sites and they definitely need reorganisation.


What is the sentiment and/or intentions about having these two 
additional actions on dive sites?


Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Extra Data tab in desktopversion

[Willem Ferguson]

This discussion continues the topic of including an editable atmospheric 
pressure textbox in the Notes Tab. The discussion then revolved around 
moving some of the data items to a different tab.


I have five proposals.

1) Any extraneous information is moved to the existing Extra Info tab. 
For many (if not most) recreational dive computers this tab is not used. 
So, if any information is to be moved out of the Notes Tab an additional 
new tab is probably not warranted. However, this means that there would 
now be a third tab that contains editable data fields (apart from Notes 
and Equipment).


2) If the above were true, the UI would be simplified if the tabs with 
editable data fields were grouped together. That would mean rearranging 
the tabs so that Extra Info is in the third position just after Equipment.


3) I suggest that the two temperature text boxes are moved to the Extra 
Info tab. The water temperature is depicted in great detail on the dive 
profile, so no information is lost.


4) I expressed an opinion beforehand that any information that affects 
the deco ceiling should be immediately visible. One of these is the dive 
mode. When logging a dive, I often found that Subsurface defaults to a 
wrong dive mode. My Petrel does not provide the information, therefore 
this has to be set by hand using the Dive Mode dropdown box. No fault of 
Subsurface. Therefore my strong preference is for the Dive Mode dropdown 
box to be kept on the Notes tab and not moved to the Extra Info tab. If 
indeed, the Dive Mode dropdown box is moved to the Extra Info tab, I 
would expect (almost 'demand') a clear indication on the dive profile 
that shows the dive mode. (Maybe as part of the deco model info e.g. 
"VPM-B +3  (Open Circuit)" or "GF 40/75 (CCR)").


5) I propose that the Atmospheric pressure datum remains on the Notes 
tab and is not moved to the Extra Info tab. The reason is that, for 
inland dives, this is likely to be crucial information with respect to 
the deco ceiling. I regard this information as so important that, if 
this datum was indeed moved to the Extra Info tab, that it should also 
be indicated somewhere on the dive profile or on the Notes tab. I must 
confess that I am probably biased because I do many inland dives over 
1000m. For me this would not make a difference because my dive computer 
records atmospheric pressure in calculating deco. But many other divers 
that dive these same sites do not have access to atmospheric pressure 
and without having done Dive-at-altitude training and I have seen what 
altitude can do to the deco ceiling. Therefore my emphasis on this matter.


I could implement any of the above changes without too much problems if 
one of the Qt experts is prepared to verify my code afterwards. However, 
this is the sort of matter that needs some form of broad consensus 
before starting with the changes, otherwise a lot of time can be wasted 
in rewriting code.


Opinions. please.

Kind regards,

willem




--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface