Re: [PATCH 1/7] Separate out buddies into individual entities when exporting to UDDF.
On Wed, Dec 10, 2014 at 11:48 AM, Long, Martin mar...@longhome.co.uk wrote: This extension is something that we need to make sure is available on all the xslt libraries we use. At least Windows and Mac need to be tested. On my Ubuntu it works fine, but how about other Linux distributions? I do remember that I tried to use the node-set in the past but had to give it up as it was not available everywhere, but then again it was different extension than this one. (This would really have made the CSV import easier.) Thanks for all the feedback. node-set should be available across pretty much every linux distro now (it's been in libxslt for over 10 years). This should be good enough for us then. I have a high confidence that it should also be in Win/Mac implementations, as it is quite ubiquitous now. However, it may be under a different namespace. If that's the case could we do a simply string substitution on the xslt on load? Or a build step? The namespace change should be easy enough at build time, if we need to do anything special for it. Is anyone able to help test this on Mac/Win? I could possibly do Windows if I can figure out how to build. It is better to wait for Dirk to provide test builds for Win and Mac as he packages specific version of libxslt in the package. Unless we have Thus self compiled binary might behave differently... miika ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 1/7] Separate out buddies into individual entities when exporting to UDDF.
On Wed, Dec 10, 2014 at 12:31:41PM +0200, Miika Turkia wrote: Thanks for all the feedback. node-set should be available across pretty much every linux distro now (it's been in libxslt for over 10 years). This should be good enough for us then. Definitely I have a high confidence that it should also be in Win/Mac implementations, as it is quite ubiquitous now. However, it may be under a different namespace. If that's the case could we do a simply string substitution on the xslt on load? Or a build step? The namespace change should be easy enough at build time, if we need to do anything special for it. That's what I worry about. I'll try to find time to push these today. Miika, they are all good to go? It seems that at least 6/7 had some issues based on your feedback. Is anyone able to help test this on Mac/Win? I could possibly do Windows if I can figure out how to build. It is better to wait for Dirk to provide test builds for Win and Mac as he packages specific version of libxslt in the package. Unless we have Thus self compiled binary might behave differently... The official Windows binaries are cross-built under Linux. Building Subsurface under Windows is a royal pain (and I think no one but Lubomir ever does so). Once I have the patches applied (and a decent internet connection - the one at the hotel I'm currently at is about 10kbit/s uplink) I'll make new Windows dailies available. The Mac and Ubuntu/LinuxMint dailies are built remotely on other systems with fast internet connections, so those are much easier to upload :-) /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 1/7] Separate out buddies into individual entities when exporting to UDDF.
On 10 December 2014 at 13:25, Dirk Hohndel d...@hohndel.org wrote: On Wed, Dec 10, 2014 at 12:31:41PM +0200, Miika Turkia wrote: Thanks for all the feedback. node-set should be available across pretty much every linux distro now (it's been in libxslt for over 10 years). This should be good enough for us then. Definitely Actually, it looks like libxslt uses a few different namespace. The XT one might not be the 'correct' one, although under the hood they all do the same. I'll likely change this along with the other items. I have a high confidence that it should also be in Win/Mac implementations, as it is quite ubiquitous now. However, it may be under a different namespace. If that's the case could we do a simply string substitution on the xslt on load? Or a build step? The namespace change should be easy enough at build time, if we need to do anything special for it. That's what I worry about. I'll try to find time to push these today. Miika, they are all good to go? It seems that at least 6/7 had some issues based on your feedback. It sounds like libxslt is used across the board though. If that's the case we really shouldn't need to make any changes. Yes, there are a couple of action points, which I'll also aim to fix this evening. Is anyone able to help test this on Mac/Win? I could possibly do Windows if I can figure out how to build. It is better to wait for Dirk to provide test builds for Win and Mac as he packages specific version of libxslt in the package. Unless we have Thus self compiled binary might behave differently... The official Windows binaries are cross-built under Linux. Building Subsurface under Windows is a royal pain (and I think no one but Lubomir ever does so). Once I have the patches applied (and a decent internet connection - the one at the hotel I'm currently at is about 10kbit/s uplink) I'll make new Windows dailies available. The Mac and Ubuntu/LinuxMint dailies are built remotely on other systems with fast internet connections, so those are much easier to upload :-) Presumable a reasonable strategy is going to be to test this out in the dailies on all platforms, and then make the call to keep/rollback? Thanks everyone for the input. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 1/7] Separate out buddies into individual entities when exporting to UDDF.
On Wed, Dec 10, 2014 at 02:33:21PM +, Long, Martin wrote: Presumable a reasonable strategy is going to be to test this out in the dailies on all platforms, and then make the call to keep/rollback? One problem I missed the first time around. None of your commits included a Signed-Off-By: line :-( Instead making you resend all the patches, please respond to this email, copying the list (so we have it in the archive) with something like All seven patches in this series are Signed-Off-By: Your Name y...@email.add Once I have that I'll apply them and send them out. Thanks /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 1/7] Separate out buddies into individual entities when exporting to UDDF.
I need to make a few changes anyway, so I'll just resubmit them all. Unless you want to get a build out to start testing these as they are, in which case: All seven patches in this series are Signed-Off-By: Martin Long mar...@longhome.co.uk ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 1/7] Separate out buddies into individual entities when exporting to UDDF.
On Wed, Dec 10, 2014 at 03:54:06PM +, Long, Martin wrote: I need to make a few changes anyway, so I'll just resubmit them all. Unless you want to get a build out to start testing these as they are, in which case: All seven patches in this series are Signed-Off-By: Martin Long mar...@longhome.co.uk Thank you. I already uploaded builds (oops) hoping for that SOB from you, I'll push the patches in a second. Please send patches relative to that to do any cleanups / fixes. Thanks a lot /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 1/7] Separate out buddies into individual entities when exporting to UDDF.
On Wed, Dec 10, 2014 at 6:10 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Dec 10, 2014 at 08:57:55AM -0700, Dirk Hohndel wrote: On Wed, Dec 10, 2014 at 03:54:06PM +, Long, Martin wrote: I need to make a few changes anyway, so I'll just resubmit them all. Unless you want to get a build out to start testing these as they are, in which case: All seven patches in this series are Signed-Off-By: Martin Long mar...@longhome.co.uk Thank you. I already uploaded builds (oops) hoping for that SOB from you, I'll push the patches in a second. Patches are pushed, Windows and Mac daily binaries are up on the server. I'll build Ubuntu / LinuxMint packages in a minute At least the dive buddy part of export works on windows (node-set). miika ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
