Re: GSoC Status - Week 3 (Customizable prints)
On 20 June 2015 at 08:29, Dirk Hohndel d...@hohndel.org wrote: On Fri, Jun 19, 2015 at 09:15:02PM +0300, Lubomir I. Ivanov wrote: so as you may have seen in the KDE cross mailing list thread (grumble, grumble...) the libGrantlee_Templates.dll needs to where subsurface.exe is, while the plugins need to be in subsurface.exe's path/grantlee/5.0/ grantlee_loadertags.dll grantlee_i18ntags.dll grantlee_defaulttags.dll grantlee_defaultfilters.dll (CCing Dirk for the Win32 crossbuild) OK, I added that and triggered new dailies. But in my quick test I still can't print from the Windows binary - but get no errors / warnings, either. Can you take a look what's wrong there? are you able to print with the Linux version? print options wise only the Dive list print is working. another thing i have in the subsurface.exe folder is the printing_templates folder. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On Jun 20, 2015, at 6:24 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: are you able to print with the Linux version? Yes. The print looks... interesting :-) WIP. in one of my previous emails to Gehad, i recommended to make at least one of the templates to look fancy, which also implies solving the issues with line, font scales and such. Yeah, I saw that. I completely agree with your priorities. print options wise only the Dive list print is working. Yeah, I figured that out :-) another thing i have in the subsurface.exe folder is the printing_templates folder. Would you mind downloading the latest daily build to see what's different from what you have set up? nothing Grantlee related, it seems. i'm able to print with the daily. Oh good. I'm not surprised that there may be issues with my Windows setup :-) /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On Fri, Jun 19, 2015 at 09:15:02PM +0300, Lubomir I. Ivanov wrote: On 19 June 2015 at 14:56, Lubomir I. Ivanov neolit...@gmail.com wrote: On 19 June 2015 at 14:37, Gehad Elrobey gehadelro...@gmail.com wrote: On Jun 19, 2015 12:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 June 2015 at 14:35, Gehad Elrobey gehadelro...@gmail.com wrote: rebased with current master and pushed. for the last batch of patches i've tried printing but i saw blank pages, i though maybe this is still WIP. now looking at the console i get the following errors: 1) Plugin library 'grantlee_defaulttags' not found. even if i have all the grantlee DLLs (including grantlee_defaulttags.dll) in the subsurface folder. My Grantlee plugins are located at (/usr/lib/grantlee/5.0) which is the default search dirs for Grantlee under linux, We can add more search paths by addPluginPath(). so as you may have seen in the KDE cross mailing list thread (grumble, grumble...) the libGrantlee_Templates.dll needs to where subsurface.exe is, while the plugins need to be in subsurface.exe's path/grantlee/5.0/ grantlee_loadertags.dll grantlee_i18ntags.dll grantlee_defaulttags.dll grantlee_defaultfilters.dll (CCing Dirk for the Win32 crossbuild) So these four files need to in the grantlee/5.0 subdirectory of our install path. That shouldn't be too hard. But I shouldn't say that because I still haven't been able to get printing to work on Linux. All I get is missing template. i'm able to see the printouts now and i will also review the patches in a moment. I pulled the patches and will push them in a moment. Thanks for the SOBs. Gehad, how are you building things on Linux that allows you to test this? I have NO_PRINTING=OFF and the grantlee_...so.* files in ./grantlee/5.0 in my build directory. No luck... /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On Fri, Jun 19, 2015 at 09:15:02PM +0300, Lubomir I. Ivanov wrote: so as you may have seen in the KDE cross mailing list thread (grumble, grumble...) the libGrantlee_Templates.dll needs to where subsurface.exe is, while the plugins need to be in subsurface.exe's path/grantlee/5.0/ grantlee_loadertags.dll grantlee_i18ntags.dll grantlee_defaulttags.dll grantlee_defaultfilters.dll (CCing Dirk for the Win32 crossbuild) OK, I added that and triggered new dailies. But in my quick test I still can't print from the Windows binary - but get no errors / warnings, either. Can you take a look what's wrong there? Thanks /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On Sat, Jun 20, 2015 at 6:09 AM, Dirk Hohndel d...@hohndel.org wrote: On Fri, Jun 19, 2015 at 09:15:02PM +0300, Lubomir I. Ivanov wrote: On 19 June 2015 at 14:56, Lubomir I. Ivanov neolit...@gmail.com wrote: On 19 June 2015 at 14:37, Gehad Elrobey gehadelro...@gmail.com wrote: On Jun 19, 2015 12:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 June 2015 at 14:35, Gehad Elrobey gehadelro...@gmail.com wrote: rebased with current master and pushed. for the last batch of patches i've tried printing but i saw blank pages, i though maybe this is still WIP. now looking at the console i get the following errors: 1) Plugin library 'grantlee_defaulttags' not found. even if i have all the grantlee DLLs (including grantlee_defaulttags.dll) in the subsurface folder. My Grantlee plugins are located at (/usr/lib/grantlee/5.0) which is the default search dirs for Grantlee under linux, We can add more search paths by addPluginPath(). so as you may have seen in the KDE cross mailing list thread (grumble, grumble...) the libGrantlee_Templates.dll needs to where subsurface.exe is, while the plugins need to be in subsurface.exe's path/grantlee/5.0/ grantlee_loadertags.dll grantlee_i18ntags.dll grantlee_defaulttags.dll grantlee_defaultfilters.dll (CCing Dirk for the Win32 crossbuild) So these four files need to in the grantlee/5.0 subdirectory of our install path. That shouldn't be too hard. But I shouldn't say that because I still haven't been able to get printing to work on Linux. All I get is missing template. i'm able to see the printouts now and i will also review the patches in a moment. I pulled the patches and will push them in a moment. Thanks for the SOBs. Gehad, how are you building things on Linux that allows you to test this? I have NO_PRINTING=OFF and the grantlee_...so.* files in ./grantlee/5.0 in my build directory. No luck... Our printing templates are copied during installation to install_dir/subsurface/printing_templates and they are referenced by getSubsurfaceDataPath() so I think you may need to make install subsurface. -- regards, Gehad ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On Sat, Jun 20, 2015 at 06:15:57AM +0200, Gehad Elrobey wrote: I pulled the patches and will push them in a moment. Thanks for the SOBs. Gehad, how are you building things on Linux that allows you to test this? I have NO_PRINTING=OFF and the grantlee_...so.* files in ./grantlee/5.0 in my build directory. No luck... Our printing templates are copied during installation to install_dir/subsurface/printing_templates and they are referenced by getSubsurfaceDataPath() so I think you may need to make install subsurface. I never install when building. But it's easy enough, we just need to copy them into the build directory as well. I'll do that (I noticed yesterday that the same is true for the theme directory for the HTML export). /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On Fri, Jun 19, 2015 at 1:37 PM, Gehad Elrobey gehadelro...@gmail.com wrote: On Jun 19, 2015 12:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 June 2015 at 14:35, Gehad Elrobey gehadelro...@gmail.com wrote: rebased with current master and pushed. for the last batch of patches i've tried printing but i saw blank pages, i though maybe this is still WIP. now looking at the console i get the following errors: 1) Plugin library 'grantlee_defaulttags' not found. even if i have all the grantlee DLLs (including grantlee_defaulttags.dll) in the subsurface folder. My Grantlee plugins are located at (/usr/lib/grantlee/5.0) which is the default search dirs for Grantlee under linux, We can add more search paths by addPluginPath http://www.grantlee.org/apidox/classGrantlee_1_1Engine.html#a24622434d92dc4c5c1117c46d492de49 (). Tomaz, any idea who we can ask about this issue? 2) Can't load template even if the folder printing_templates is where the subsurface executable is located. is this related to the 'grantlee_defaulttags' not found thing? I think you need to make install subsurface so that the printing_templates directory is copied and referenced correctly, when I run subsurface from the build directory directly getSubsurfaceDataPath() returns the wrong printing_templates directory. either way, i really want to be able to see how the printouts actually look ATM before commenting further. I ll send you some printouts to check them until we can build on windows correctly. lubomir -- And I forgot to reply to the mailing list. -- regards, Gehad ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On 19 June 2015 at 14:37, Gehad Elrobey gehadelro...@gmail.com wrote: On Jun 19, 2015 12:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 June 2015 at 14:35, Gehad Elrobey gehadelro...@gmail.com wrote: rebased with current master and pushed. for the last batch of patches i've tried printing but i saw blank pages, i though maybe this is still WIP. now looking at the console i get the following errors: 1) Plugin library 'grantlee_defaulttags' not found. even if i have all the grantlee DLLs (including grantlee_defaulttags.dll) in the subsurface folder. My Grantlee plugins are located at (/usr/lib/grantlee/5.0) which is the default search dirs for Grantlee under linux, We can add more search paths by addPluginPath(). what should i do (and where) to experiment with addPluginPath()? the idea would be to try to add the subsurface.exe relative path as search path for the plugins. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On 19 June 2015 at 14:56, Lubomir I. Ivanov neolit...@gmail.com wrote: On 19 June 2015 at 14:37, Gehad Elrobey gehadelro...@gmail.com wrote: On Jun 19, 2015 12:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 June 2015 at 14:35, Gehad Elrobey gehadelro...@gmail.com wrote: rebased with current master and pushed. for the last batch of patches i've tried printing but i saw blank pages, i though maybe this is still WIP. now looking at the console i get the following errors: 1) Plugin library 'grantlee_defaulttags' not found. even if i have all the grantlee DLLs (including grantlee_defaulttags.dll) in the subsurface folder. My Grantlee plugins are located at (/usr/lib/grantlee/5.0) which is the default search dirs for Grantlee under linux, We can add more search paths by addPluginPath(). so as you may have seen in the KDE cross mailing list thread (grumble, grumble...) the libGrantlee_Templates.dll needs to where subsurface.exe is, while the plugins need to be in subsurface.exe's path/grantlee/5.0/ grantlee_loadertags.dll grantlee_i18ntags.dll grantlee_defaulttags.dll grantlee_defaultfilters.dll (CCing Dirk for the Win32 crossbuild) i'm able to see the printouts now and i will also review the patches in a moment. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On Fri, Jun 19, 2015 at 09:15:02PM +0300, Lubomir I. Ivanov wrote: On 19 June 2015 at 14:56, Lubomir I. Ivanov neolit...@gmail.com wrote: On 19 June 2015 at 14:37, Gehad Elrobey gehadelro...@gmail.com wrote: On Jun 19, 2015 12:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 June 2015 at 14:35, Gehad Elrobey gehadelro...@gmail.com wrote: rebased with current master and pushed. for the last batch of patches i've tried printing but i saw blank pages, i though maybe this is still WIP. now looking at the console i get the following errors: 1) Plugin library 'grantlee_defaulttags' not found. even if i have all the grantlee DLLs (including grantlee_defaulttags.dll) in the subsurface folder. My Grantlee plugins are located at (/usr/lib/grantlee/5.0) which is the default search dirs for Grantlee under linux, We can add more search paths by addPluginPath(). so as you may have seen in the KDE cross mailing list thread (grumble, grumble...) the libGrantlee_Templates.dll needs to where subsurface.exe is, while the plugins need to be in subsurface.exe's path/grantlee/5.0/ grantlee_loadertags.dll grantlee_i18ntags.dll grantlee_defaulttags.dll grantlee_defaultfilters.dll (CCing Dirk for the Win32 crossbuild) Grmbl indeed. Yet another thing for my todo list so we get the installer built correctly /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On 18 June 2015 at 15:48, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 18, 2015 at 01:35:16PM +0200, Gehad Elrobey wrote: On Thu, Jun 18, 2015 at 9:52 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 June 2015 at 19:51, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, I have amended the commit I mentioned above, I also added the support to print on many page sizes with different print qualities (This still needs more testing), I have pushed all the commits to my branch. thanks, your branch seems to be missing the patch to fix this: error: 'm__nstance' was not declared in this scope Q_ASSERT_X(m__nstance == NULL, WindowTitleUpdate, WindowTitleUpdate recreat ed!); [Patch] Re-fix silly typo (was Current git no compilee) lubomir -- rebased with current master and pushed. Good - Lubomir are you going to sign off on them again? hello, haven't reviewed yet. will do soon. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On 17 June 2015 at 19:51, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, I have amended the commit I mentioned above, I also added the support to print on many page sizes with different print qualities (This still needs more testing), I have pushed all the commits to my branch. thanks, your branch seems to be missing the patch to fix this: error: 'm__nstance' was not declared in this scope Q_ASSERT_X(m__nstance == NULL, WindowTitleUpdate, WindowTitleUpdate recreat ed!); [Patch] Re-fix silly typo (was Current git no compilee) lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
Hello Lubomir, I have amended the commit I mentioned above, I also added the support to print on many page sizes with different print qualities (This still needs more testing), I have pushed all the commits to my branch. On Sun, Jun 14, 2015 at 6:00 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 June 2015 at 18:59, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 June 2015 at 13:43, Gehad Elrobey gehadelro...@gmail.com wrote: Hello all, This week I was mainly working to add the dive profile to the print output, what I have finished so far: - I have added the dive profile correctly to the templates. - I have added the option to export one dive per page. - I have fixed some printing bugs. what needs fixing before merging into master: - I need to enhance the one dive per page Grantlee template and rebase it. The work I described above is pushed to my Github branch. cool, i will review in detail after you push that last amend that you mention. any chance we can see soon the support for printing in page any size? *any page size lubomir -- -- regards, Gehad ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On 14 June 2015 at 18:59, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 June 2015 at 13:43, Gehad Elrobey gehadelro...@gmail.com wrote: Hello all, This week I was mainly working to add the dive profile to the print output, what I have finished so far: - I have added the dive profile correctly to the templates. - I have added the option to export one dive per page. - I have fixed some printing bugs. what needs fixing before merging into master: - I need to enhance the one dive per page Grantlee template and rebase it. The work I described above is pushed to my Github branch. cool, i will review in detail after you push that last amend that you mention. any chance we can see soon the support for printing in page any size? *any page size lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: GSoC Status - Week 3 (Customizable prints)
On 14 June 2015 at 13:43, Gehad Elrobey gehadelro...@gmail.com wrote: Hello all, This week I was mainly working to add the dive profile to the print output, what I have finished so far: - I have added the dive profile correctly to the templates. - I have added the option to export one dive per page. - I have fixed some printing bugs. what needs fixing before merging into master: - I need to enhance the one dive per page Grantlee template and rebase it. The work I described above is pushed to my Github branch. cool, i will review in detail after you push that last amend that you mention. any chance we can see soon the support for printing in page any size? lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
