Re: Patch for #848
On 17 March 2015 at 01:06, Matthew Vepritskiy matteoficht...@hotmail.com wrote: I made a patch for ticket # 848, but I have a suspicion that somewhere I screwed up. http://trac.subsurface-divelog.org/ticket/848#no2 Patch fixes the problem when you can create a set of points that do not belong to the line. The problem lies in the function fixHandlerIndex (qt-ui / profile / profilewidget2.cpp) - it returns the wrong value. However, this only occurs when the user edits the second diving graph. That is, before he clicked Apply Changes or Discard changes. Given this, should we clean handles every time changes are discarded or applied? i don't think the function should be removed. this bug was supposedly fixed recently and i can't reproduce it with the current GIT version. if not, can you provide the exact steps for the bug to trigger? also, not sure i understand what you mean by second diving graph. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
RE: Patch for #848
Okay. Thank U. Regards, Matthew V. Date: Tue, 17 Mar 2015 14:19:04 +0200 Subject: Re: Patch for #848 From: neolit...@gmail.com To: matteoficht...@hotmail.com CC: subsurface@subsurface-divelog.org On 17 March 2015 at 14:11, Matthew Vepritskiy matteoficht...@hotmail.com wrote: Okay. I see. At least I was right about the handles.:-( This patch is not counted? I have to make another one? yes, please do another one. your patches have to be applied for them to count. also mind that when there is something wrong with a peace of code we a looking for a replacement or a removal instead of commenting it out. here is something related that i just logged: http://trac.subsurface-divelog.org/ticket/857#ticket (if it's too complicated move to something else...) there list of current issues: http://trac.subsurface-divelog.org/report/1 lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Patch for #848
On 17 March 2015 at 13:56, Matthew Vepritskiy matteoficht...@hotmail.com wrote: 4.4.1-241-ge9e9996766a4 this version is before the fix (57374fb9) was applied. if you are building from source please do a: git pull then recompile and try again. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Patch for #848
On 17 March 2015 at 14:11, Matthew Vepritskiy matteoficht...@hotmail.com wrote: Okay. I see. At least I was right about the handles.:-( This patch is not counted? I have to make another one? yes, please do another one. your patches have to be applied for them to count. also mind that when there is something wrong with a peace of code we a looking for a replacement or a removal instead of commenting it out. here is something related that i just logged: http://trac.subsurface-divelog.org/ticket/857#ticket (if it's too complicated move to something else...) there list of current issues: http://trac.subsurface-divelog.org/report/1 lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Patch for #848
On 17 March 2015 at 13:33, Matthew Vepritskiy matteoficht...@hotmail.com wrote: Sorry. Lost in Translation. I caught this bug as follows (pic 1): 1. Add new dive. 2. Discard apply changes. 3. Add another dive. 4. Pull the last point to the left or down. 5. Make it a few more times. this is pretty much the exact same bug i though i fixed a couple of days ago (commit 57374fb9). and i can no longer reproduce it with the current source tree. the fix is not yet in the OS specific installers. are you building from source? what version is shown in Help - About Subsurface? lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
RE: Patch for #848
4.4.1-241-ge9e9996766a4 Regards, Matthew V. Date: Tue, 17 Mar 2015 13:50:47 +0200 Subject: Re: Patch for #848 From: neolit...@gmail.com To: matteoficht...@hotmail.com CC: subsurface@subsurface-divelog.org On 17 March 2015 at 13:33, Matthew Vepritskiy matteoficht...@hotmail.com wrote: Sorry. Lost in Translation. I caught this bug as follows (pic 1): 1. Add new dive. 2. Discard apply changes. 3. Add another dive. 4. Pull the last point to the left or down. 5. Make it a few more times. this is pretty much the exact same bug i though i fixed a couple of days ago (commit 57374fb9). and i can no longer reproduce it with the current source tree. the fix is not yet in the OS specific installers. are you building from source? what version is shown in Help - About Subsurface? lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Patch for #848
On Tue, Mar 17, 2015 at 02:19:04PM +0200, Lubomir I. Ivanov wrote: On 17 March 2015 at 14:11, Matthew Vepritskiy matteoficht...@hotmail.com wrote: Okay. I see. At least I was right about the handles.:-( This patch is not counted? I have to make another one? yes, please do another one. your patches have to be applied for them to count. Let me phrase this differently. If you had sent a solid patch that for some strange reason I ended up not taking, I would certainly have counted it. But commenting out a function isn't exactly a strong submission, wouldn't you agree? The idea of the two patch rule is for you to demonstrate that you can successfully contribute. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
