Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On Mon, Feb 15, 2016 at 07:44:55AM +0100, Joakim Bygdell wrote: > > I know spent about 10 minutes opening all kinds of pages from sub-menus in > > random order, closing them, re-opening them, etc. I have not been able to > > reproduce this one single time. > > It's not that I don't believe you (and you know that), it's just... heck > > if I know how to fix this if I can't reproduce it. > > > > I just spent the better part of my breakfast to pinpoint the sequence that > triggers this issue. Thank you! > The triggering factor seems to be swiping to open the drawer, twice in a > row. That explains why I wasn't able to reproduce this. I never ever swipe to open the drawer. This is one of those guestures that I haven't wrapped my mind around (and sine my main phone is in a case it's almost impossible to do there - the other devices I only use to test Subsurface so I haven't gotten in the habbit there, either). > Taping on the handle to open the drawer always results in the drawer closes > when the selected page opens, even if the overlay issue has been triggered. > Once the issue is triggered it happens every time a drag or swipe action is > used to open the drawer. Marco - any idea? I'm reasonably certain that this has got to be a mobile components issue as from Subsurface's point of view there is no difference in whether a user swiped to open a drawer or tapped the handle... /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
> On Feb 14, 2016, at 12:59 PM, Joakim Bygdellwrote: > > >> On 14 Feb 2016, at 21:21, Dirk Hohndel wrote: >>> >>> The issue is still there, on both -858 and on the one I build my self. >>> Primary targets are Dive list, Show GPS fixes >> >> I tried this on three different devices with all of the pages that you >> mentioned. For me in each and every case the menu drawer reliably closes. >> >> Not quite sure what to say. > > Still present in -861, very consistent behaviour. > The first time a sub page is selected the drawer closes but from the second > time a page is selected the drawer stays open. I know spent about 10 minutes opening all kinds of pages from sub-menus in random order, closing them, re-opening them, etc. I have not been able to reproduce this one single time. It's not that I don't believe you (and you know that), it's just... heck if I know how to fix this if I can't reproduce it. And reading through the code in GlobalDrawer... if you click on one of the child entries, it pops the child menu from the pageRow (so goes back to the main menu) and then explicitly sets root.opened to false... H... If I could reproduce this, I could sprinkle some print(...) commands throughout the code and see where things go wrong. But like this... Hmm... So you can see this with the APK in Google play, right? What device are you on? What Android version? Any way you could create a small video that demonstrates this? Maybe there's something that I'm not doing that you do to trigger this... I'm really running out of ideas :-( /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On Sun, Feb 14, 2016 at 09:24:03AM +0100, Joakim Bygdell wrote: > >> On Sun, Feb 14, 2016 at 08:57:58AM +0100, Joakim Bygdell wrote: > On Sun, Feb 14, 2016 at 08:48:48AM +0100, Joakim Bygdell wrote: > > > Selecting sub-menues does not close the lefthand drawer, > > the page is loaded in the background and the drawer is returned to the > > top level listings. > > * Show GPS fixes > > * App log > > * Divelist > > * Add dive > > That is NOT the case for me with the pre-compiled APK. Is your copy of > plasma-mobile current? > >>> It’s built via the script so plasma changes are synced at every build. > >> > >> Could you humor me and try -858 which I just uploaded? > >> Because for me all of these close the drawer. > > A full uninstall / reinstall fixed the issue. > Apparently I was a bit fast with the answer. > > The issue is still there, on both -858 and on the one I build my self. > Primary targets are Dive list, Show GPS fixes I tried this on three different devices with all of the pages that you mentioned. For me in each and every case the menu drawer reliably closes. Not quite sure what to say. > On -858, hitting the back button while on the dive list does not close the > app. > Instead you end up on the cloud credentials page which you can’t get out of > since the credentials are valid. > Only way to get it back to working order is to hit the save button with wrong > user/pass combination and then > enter the correct one. Yep. Fixed in 859 /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On Sun, Feb 14, 2016 at 09:27:25AM +0100, Salvador Cuñat wrote: > So building from source will have > > > almost everything work as expected - except when you decide to change > > credentials and then change your mind and hit the back key. Oops, you just > > quit Subsurface. That's fixed in my APK and in last of the patches I sent > > to the plasma-devel list :-) > > > This is no exactly what i'm getting. After saving credentials, the screen > is stuck there. One can move to the divelist, see the dives, etc, but on > quitting I always come back to credentials screen and can't exit the app. > Even worse, next time I access the app, the dive list opens, I can do the > usual workflow with the app, but on exiting, the credentials screen is > shown again, so I can't quit the app but killing it. Yes, fixed in -859. I won't respond to the other emails with the same report :) /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On Sun, Feb 14, 2016 at 05:00:27PM +0200, Miika Turkia wrote: > > The keyboard is on top of the action button preventing one from saving > or canceling changes without hiding the keyboard. Yes - I switched us back to Qt 5.6 (without telling anyone) and it seems the crashes at start (while the splashscreen is shown - that's why I switched back to 5.5 for a while) haven't re-occured. With 5.6 we can fix the screen size / keyboard position issue. I know that Sebastian is working on a patch for that (to the mobile components). > I cannot edit gas mix, nor start or end pressures. This is because > unused cylinders from OSTC Sport are included in the log. And this is > erroneously considered to be a dive with multiple cylinders. Yes, I saw that yesterday as well but forgot to mention it here. > Start and end pressure on the details (edit) page are shown as 0 when > diving with air integrated DC. Can you say more about this case? > When going to edit mode, I was shown info from wrong dive. > Unfortunately reproducing this does not seem to be trivial. At least I > have not been able to reproduce the issue. That's strange - we should just switch modes but stay on the same dive. > On the enhancement side, it would be great if the divelist could be > collapsed by trips. This would really make a difference for me as I > tend to do a lot of dives on scuba trips and scrolling through tens or > hundreds of dives to find the specific one would be quite a bit easier > this way. Yes. For the second version we should look at a collapsable list :-) > Also I would not mind if we had an empty sphere as the action button > on the Dive list page. It is kind of handy to be able to drag the menu > from the middle of the page, not that this would be a big issue. But > even more transparent icon would not really bother me. (On the other > hand I a have a 7 inch tablet, so I have no idea how much that would > bother people with a small screen.) I like the fact that the action button goes away when there is no action. But I see the point that this no longer allows you to open the drawer by dragging the action button. Thomas, what are your thoughts on this? /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On Sun, Feb 14, 2016 at 05:39:54PM +0200, Miika Turkia wrote: > One more. Scrolling to the end of the dive list is buggy. Right now I > have the top half of the list blank and bottom showing dives. Usually > scrolling fast to the end ends up in a blank screen and if I try to > scroll again then the list jumps somewhere higher on the list than the > end. Oh wow, yes, I can reproduce this. Sebastian, Marco, any idea what causes that? The list just blanks or partially blanks - and it resets the "scroll point" further back... so let's say I'm at about 90% and keep scrolling down. Sudeenly it goes blank. When I scroll back up a tiny bit I'm not at 80% or so. Help! /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On 14-02-16 21:39, Dirk Hohndel wrote: On Sun, Feb 14, 2016 at 05:39:54PM +0200, Miika Turkia wrote: One more. Scrolling to the end of the dive list is buggy. Right now I have the top half of the list blank and bottom showing dives. Usually scrolling fast to the end ends up in a blank screen and if I try to scroll again then the list jumps somewhere higher on the list than the end. Oh wow, yes, I can reproduce this. Sebastian, Marco, any idea what causes that? The list just blanks or partially blanks - and it resets the "scroll point" further back... so let's say I'm at about 90% and keep scrolling down. Sudeenly it goes blank. When I scroll back up a tiny bit I'm not at 80% or so. Yes, I also see this one, and I wondered if it is related to ticket http://trac.subsurface-divelog.org/ticket/1009. In both cases seemingly random navigation issues in the divelist occur. --jan ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
> On 14 Feb 2016, at 21:21, Dirk Hohndelwrote: >> >> The issue is still there, on both -858 and on the one I build my self. >> Primary targets are Dive list, Show GPS fixes > > I tried this on three different devices with all of the pages that you > mentioned. For me in each and every case the menu drawer reliably closes. > > Not quite sure what to say. Still present in -861, very consistent behaviour. The first time a sub page is selected the drawer closes but from the second time a page is selected the drawer stays open. > > /D /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
> On 14 Feb 2016, at 22:35, Dirk Hohndelwrote: > >> Start and end pressure on the details (edit) page are shown as 0 when >> diving with air integrated DC. > > Can you say more about this case? fixed :) need to grab pressures from samples miika ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On Sun, Feb 14, 2016 at 10:36 AM, David Tillotsonwrote: > On Sun, 14 Feb 2016 00:01:26 -0800 > Dirk Hohndel wrote: >> Could you humor me and try -858 which I just uploaded? >> Because for me all of these close the drawer. > > 858 ends up back in the cloud credentials screen on a clean > install, and hitting the back button from the dive list. From there, all > I can do is kill the app, as the action button, back button, and "Dive > list" menu entry do nothing (although I can get into the developer > sub-menu, about page, and stop/start the location service). Similar experience here. And here are a few notes from brief testing. The keyboard is on top of the action button preventing one from saving or canceling changes without hiding the keyboard. I cannot edit gas mix, nor start or end pressures. This is because unused cylinders from OSTC Sport are included in the log. And this is erroneously considered to be a dive with multiple cylinders. Start and end pressure on the details (edit) page are shown as 0 when diving with air integrated DC. When going to edit mode, I was shown info from wrong dive. Unfortunately reproducing this does not seem to be trivial. At least I have not been able to reproduce the issue. On the enhancement side, it would be great if the divelist could be collapsed by trips. This would really make a difference for me as I tend to do a lot of dives on scuba trips and scrolling through tens or hundreds of dives to find the specific one would be quite a bit easier this way. Also I would not mind if we had an empty sphere as the action button on the Dive list page. It is kind of handy to be able to drag the menu from the middle of the page, not that this would be a big issue. But even more transparent icon would not really bother me. (On the other hand I a have a 7 inch tablet, so I have no idea how much that would bother people with a small screen.) miika ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On Sun, Feb 14, 2016 at 5:00 PM, Miika Turkiawrote: > On Sun, Feb 14, 2016 at 10:36 AM, David Tillotson > wrote: >> On Sun, 14 Feb 2016 00:01:26 -0800 >> Dirk Hohndel wrote: >>> Could you humor me and try -858 which I just uploaded? >>> Because for me all of these close the drawer. >> >> 858 ends up back in the cloud credentials screen on a clean >> install, and hitting the back button from the dive list. From there, all >> I can do is kill the app, as the action button, back button, and "Dive >> list" menu entry do nothing (although I can get into the developer >> sub-menu, about page, and stop/start the location service). > > Similar experience here. And here are a few notes from brief testing. > > The keyboard is on top of the action button preventing one from saving > or canceling changes without hiding the keyboard. > > I cannot edit gas mix, nor start or end pressures. This is because > unused cylinders from OSTC Sport are included in the log. And this is > erroneously considered to be a dive with multiple cylinders. > > Start and end pressure on the details (edit) page are shown as 0 when > diving with air integrated DC. > > When going to edit mode, I was shown info from wrong dive. > Unfortunately reproducing this does not seem to be trivial. At least I > have not been able to reproduce the issue. > > On the enhancement side, it would be great if the divelist could be > collapsed by trips. This would really make a difference for me as I > tend to do a lot of dives on scuba trips and scrolling through tens or > hundreds of dives to find the specific one would be quite a bit easier > this way. > > Also I would not mind if we had an empty sphere as the action button > on the Dive list page. It is kind of handy to be able to drag the menu > from the middle of the page, not that this would be a big issue. But > even more transparent icon would not really bother me. (On the other > hand I a have a 7 inch tablet, so I have no idea how much that would > bother people with a small screen.) One more. Scrolling to the end of the dive list is buggy. Right now I have the top half of the list blank and bottom showing dives. Usually scrolling fast to the end ends up in a blank screen and if I try to scroll again then the list jumps somewhere higher on the list than the end. miika ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On Sun, Feb 14, 2016 at 08:57:58AM +0100, Joakim Bygdell wrote: > > On Sun, Feb 14, 2016 at 08:48:48AM +0100, Joakim Bygdell wrote: > >> Issues found: > >> Cloud credentials page: > >> If you have valid cloud credentials in place it is not possible to go back > >> to the divelist, > >> pressing the action button does nothing and the back button closes the app. > >> You can’t go back by selecting “Dive list” in the menu either. > > > > You compiled from source and didn't use my APK. Use the attched patch for > > plasma-mobile to make the back button work. > > > >> Selecting sub-menues does not close the lefthand drawer, > >> the page is loaded in the background and the drawer is returned to the top > >> level listings. > >> * Show GPS fixes > >> * App log > >> * Divelist > >> * Add dive > > > > That is NOT the case for me with the pre-compiled APK. Is your copy of > > plasma-mobile current? > It’s built via the script so plasma changes are synced at every build. Could you humor me and try -858 which I just uploaded? Because for me all of these close the drawer. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
> On 14 Feb 2016, at 09:04, Joakim Bygdellwrote: > >> >> On 14 Feb 2016, at 09:01, Dirk Hohndel wrote: >> >> On Sun, Feb 14, 2016 at 08:57:58AM +0100, Joakim Bygdell wrote: On Sun, Feb 14, 2016 at 08:48:48AM +0100, Joakim Bygdell wrote: > Issues found: > Cloud credentials page: > If you have valid cloud credentials in place it is not possible to go > back to the divelist, > pressing the action button does nothing and the back button closes the > app. > You can’t go back by selecting “Dive list” in the menu either. You compiled from source and didn't use my APK. Use the attched patch for plasma-mobile to make the back button work. > Selecting sub-menues does not close the lefthand drawer, > the page is loaded in the background and the drawer is returned to the > top level listings. > * Show GPS fixes > * App log > * Divelist > * Add dive That is NOT the case for me with the pre-compiled APK. Is your copy of plasma-mobile current? >>> It’s built via the script so plasma changes are synced at every build. >> >> Could you humor me and try -858 which I just uploaded? >> Because for me all of these close the drawer. > A full uninstall / reinstall fixed the issue. Apparently I was a bit fast with the answer. The issue is still there, on both -858 and on the one I build my self. Primary targets are Dive list, Show GPS fixes On -858, hitting the back button while on the dive list does not close the app. Instead you end up on the cloud credentials page which you can’t get out of since the credentials are valid. Only way to get it back to working order is to hit the save button with wrong user/pass combination and then enter the correct one. > >> >> /D >> > > /Jocke /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
> On 14 Feb 2016, at 09:01, Dirk Hohndelwrote: > > On Sun, Feb 14, 2016 at 08:57:58AM +0100, Joakim Bygdell wrote: >>> On Sun, Feb 14, 2016 at 08:48:48AM +0100, Joakim Bygdell wrote: Issues found: Cloud credentials page: If you have valid cloud credentials in place it is not possible to go back to the divelist, pressing the action button does nothing and the back button closes the app. You can’t go back by selecting “Dive list” in the menu either. >>> >>> You compiled from source and didn't use my APK. Use the attched patch for >>> plasma-mobile to make the back button work. >>> Selecting sub-menues does not close the lefthand drawer, the page is loaded in the background and the drawer is returned to the top level listings. * Show GPS fixes * App log * Divelist * Add dive >>> >>> That is NOT the case for me with the pre-compiled APK. Is your copy of >>> plasma-mobile current? >> It’s built via the script so plasma changes are synced at every build. > > Could you humor me and try -858 which I just uploaded? > Because for me all of these close the drawer. A full uninstall / reinstall fixed the issue. > > /D > /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On Sun, Feb 14, 2016 at 12:01:26AM -0800, Dirk Hohndel wrote: > > Could you humor me and try -858 which I just uploaded? > Because for me all of these close the drawer. Oh, and -858 also fixes the spacing in the top bar (but maybe Marco will help us make that one disappear) and makes the start page more visually balanced. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
> On 14 Feb 2016, at 07:23, Dirk Hohndelwrote: > > > So based on the feedback received and the discussion here on the list, I > decided to go all the way... > > - all the save buttons on the pages are gone > - the action button is used for the main action on any page, including all > the save actions (this is for preferences, credentials, edits, etc) > - the back button is used for the go-back, discard, abort style actions > everywhere (without confirmation dialog) > > In order for this to work a couple of patches to the mobile components are > needed. They were all sent to the plasma-devel mailing list -- actually, > only one is really /needed/ at this point. One is actually no longer > relevant (because we don't use context menus) and one is more a visual > thing and won't prevent functionality. So building from source will have > almost everything work as expected - except when you decide to change > credentials and then change your mind and hit the back key. Oops, you just > quit Subsurface. That's fixed in my APK and in last of the patches I sent > to the plasma-devel list :-) > > Please test. I know, I keep saying that and I have to say I am thrilled > with all the feedback you are giving. I think this is really shaping up to > be a very strong first release. > > I'll give it a day or two for testing and then hopefully I can make a > second beta with the updated UI. Issues found: Cloud credentials page: If you have valid cloud credentials in place it is not possible to go back to the divelist, pressing the action button does nothing and the back button closes the app. You can’t go back by selecting “Dive list” in the menu either. Selecting sub-menues does not close the lefthand drawer, the page is loaded in the background and the drawer is returned to the top level listings. * Show GPS fixes * App log * Divelist * Add dive Canceling the Add dive does not show you the divelist, but the details page of the last dive in the list. > > /D > ___ > subsurface mailing list > subsurface@subsurface-divelog.org > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Subsurface-mobile 854 - now even more Plasma-mobile than ever before
So based on the feedback received and the discussion here on the list, I decided to go all the way... - all the save buttons on the pages are gone - the action button is used for the main action on any page, including all the save actions (this is for preferences, credentials, edits, etc) - the back button is used for the go-back, discard, abort style actions everywhere (without confirmation dialog) In order for this to work a couple of patches to the mobile components are needed. They were all sent to the plasma-devel mailing list -- actually, only one is really /needed/ at this point. One is actually no longer relevant (because we don't use context menus) and one is more a visual thing and won't prevent functionality. So building from source will have almost everything work as expected - except when you decide to change credentials and then change your mind and hit the back key. Oops, you just quit Subsurface. That's fixed in my APK and in last of the patches I sent to the plasma-devel list :-) Please test. I know, I keep saying that and I have to say I am thrilled with all the feedback you are giving. I think this is really shaping up to be a very strong first release. I'll give it a day or two for testing and then hopefully I can make a second beta with the updated UI. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: Subsurface-mobile 854 - now even more Plasma-mobile than ever before
On 14 Feb 2016 17:23, "Dirk Hohndel"wrote: > > > So based on the feedback received and the discussion here on the list, I > decided to go all the way... > > - all the save buttons on the pages are gone > - the action button is used for the main action on any page, including all > the save actions (this is for preferences, credentials, edits, etc) > - the back button is used for the go-back, discard, abort style actions > everywhere (without confirmation dialog) > I played with this for a few minutes and really like it. Which is just as well since you went and redid the button actions to address my comments. > In order for this to work a couple of patches to the mobile components are > needed. They were all sent to the plasma-devel mailing list -- actually, > only one is really /needed/ at this point. One is actually no longer > relevant (because we don't use context menus) and one is more a visual > thing and won't prevent functionality. So building from source will have > almost everything work as expected - except when you decide to change > credentials and then change your mind and hit the back key. Oops, you just > quit Subsurface. That's fixed in my APK and in last of the patches I sent > to the plasma-devel list :-) > > Please test. I know, I keep saying that and I have to say I am thrilled > with all the feedback you are giving. I think this is really shaping up to > be a very strong first release. > > I'll give it a day or two for testing and then hopefully I can make a > second beta with the updated UI. > > /D > ___ > subsurface mailing list > subsurface@subsurface-divelog.org > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface