Re: [sugar] Finale: consider merging a few fun Sugar patches?
On Thu, Sep 18, 2008 at 6:06 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 2:30 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: * At *very* high level the patch sets looks sane. I would be comfortable with them going in if Scott reviews Martin set, and Martin reviews Scott set. * The patches are large and I don't think it's impossible that they would cause regressions. Our release manager should be aware of it and keep loving us if it happens. * I would help by getting packages in the builds and doing a bit of testing. * Both patches contains string additions I guess (hopefully not changes?). Someone would have to sort that out with sayamindu and the localization team. String addtions ?? Now ?? -sdg- -- Sayamindu Dasgupta [http://sayamindu.randomink.org/ramblings] ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Finale: consider merging a few fun Sugar patches?
On Thu, Sep 18, 2008 at 01:23:57PM +0530, Sayamindu Dasgupta wrote: On Thu, Sep 18, 2008 at 6:06 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 2:30 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: * At *very* high level the patch sets looks sane. I would be comfortable with them going in if Scott reviews Martin set, and Martin reviews Scott set. * The patches are large and I don't think it's impossible that they would cause regressions. Our release manager should be aware of it and keep loving us if it happens. * I would help by getting packages in the builds and doing a bit of testing. * Both patches contains string additions I guess (hopefully not changes?). Someone would have to sort that out with sayamindu and the localization team. String addtions ?? Now ?? -sdg- Sigh. I knew I was forgetting something important. I guess these can be first-on-deck for 8.2.1 then. :( Michael ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Finale: consider merging a few fun Sugar patches?
On Thu, Sep 18, 2008 at 04:05:26AM -0400, Michael Stone wrote: On Thu, Sep 18, 2008 at 2:30 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: * At *very* high level the patch sets looks sane. I would be comfortable with them going in if Scott reviews Martin set, and Martin reviews Scott set. [...] I guess these can be first-on-deck for 8.2.1 I'll do my review but Scott need not worry about mine since my patches are already in 0.82.1[1] and 8.2-758[2]. Michael Martin 1. http://dev.laptop.org/git?p=sugar;a=commit;h=434ab0ce729a670a119f033386190eaf6a8827ca 2. http://mock.laptop.org/gitweb/gitweb.cgi?p=repos;a=commitdiff;h=e0489cd6dec4b910445f489632adb44ba136c1c1 pgpGg4oDHBi8H.pgp Description: PGP signature ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Finale: consider merging a few fun Sugar patches?
On Thu, Sep 18, 2008 at 3:53 AM, Sayamindu Dasgupta [EMAIL PROTECTED] wrote: String addtions ?? Now ?? Three words: Triangle, Box, and Spiral. I wonder if a compromise version of the patch might remove all the words and just use icons for the three different layouts. The words don't actually add much (except maybe for Freeform -- but what does that word mean, actually). --scott -- ( http://cscott.net/ ) ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Finale: consider merging a few fun Sugar patches?
On Thu, Sep 18, 2008 at 4:57 PM, C. Scott Ananian [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 8:38 AM, Martin Dengler [EMAIL PROTECTED] wrote: I'll do my review but Scott need not worry about mine since my patches are already in 0.82.1[1] and 8.2-758[2]. Hm, I'm actually a bit disappointed by this, because I'd been hoping (based on just the phrase network feedback which Michael used when describing your patches to me) that this was a quick fix for the connected networks indistinguishable from unconnected network issue in the networks view. Feedback from testers has consistently indicated that this is an issue for them (especially when they are transitioning from an old build). I'd hoped that we could come up with *some* reasonable stop gap, whether it's a halo, or a square in the center of the circle, or *something*. Boo. I agree. I think Eben liked the different icon idea. Eben, can you spec this? (keep it simple) Marco ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Finale: consider merging a few fun Sugar patches?
On Thu, Sep 18, 2008 at 11:43 PM, C. Scott Ananian [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 10:54 AM, C. Scott Ananian [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 3:53 AM, Sayamindu Dasgupta [EMAIL PROTECTED] wrote: String addtions ?? Now ?? Three words: Triangle, Box, and Spiral. I wonder if a compromise version of the patch might remove all the words and just use icons for the three different layouts. The words don't actually add much (except maybe for Freeform -- but what does that word mean, actually). OK, attached is a screenshot of a word-less version; further discussion at http://dev.laptop.org/ticket/7685 --scott Looks good :-). Probably Eben should make the call now . Cheers, Sayamindu -- Sayamindu Dasgupta [http://sayamindu.randomink.org/ramblings] ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
[sugar] Finale: consider merging a few fun Sugar patches?
Folks, We've reached the last call for changes before final test and, in the hopes of ending our development cycle on a playful note, I'd like to ask the sugar team to consider whether they'd be comfortable reviewing and merging a couple of the outstanding UI patches like Scott's alternate layouts patches [1] and Martin's network feedback patches [2]. Sugar team: you can nix the idea if it seems too risky, if the patches aren't baked, or if it would take too much time to accomplish, but if you're willing to step up and handle the review, merge, and testing, then I think it would a joyous finale to a remarkable development cycle. Regards, Michael [1]: http://dev.laptop.org/git?p=users/mdengler/sugar;a=shortlog;h=network-feedback-2866 [2]: http://dev.laptop.org/git/users/cscott/sugar P.S. - (The deadline for this action, should you choose to accept it, would be Friday afternoon.) P.P.S. - Eben mentioned to me that he was concerned that people might falsely interpret some of the new 8.2.0 Sugar APIs as stable when they are, in fact, almost certain to change in the next major release. I would find it commendable if some Sugar developer took this last opportunity to add some bold comments to the relevant APIs warning developers who examine them about this probable future breakage. ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Finale: consider merging a few fun Sugar patches?
On Thu, Sep 18, 2008 at 2:30 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: * At *very* high level the patch sets looks sane. I would be comfortable with them going in if Scott reviews Martin set, and Martin reviews Scott set. * The patches are large and I don't think it's impossible that they would cause regressions. Our release manager should be aware of it and keep loving us if it happens. * I would help by getting packages in the builds and doing a bit of testing. * Both patches contains string additions I guess (hopefully not changes?). Someone would have to sort that out with sayamindu and the localization team. Marco ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Finale: consider merging a few fun Sugar patches?
On Thu, Sep 18, 2008 at 02:30:30AM +0200, Marco Pesenti Gritti wrote: * At *very* high level the patch sets looks sane. I would be comfortable with them going in if Scott reviews Martin set, and Martin reviews Scott set. Sounds good. Hopefully there are a few other sugar volunteers who could chip in to help look for regressions? * The patches are large and I don't think it's impossible that they would cause regressions. Our release manager should be aware of it and keep loving us if it happens. I'm the one who'se suggesting it, so I'd take the blame. * I would help by getting packages in the builds and doing a bit of testing. This can happen immediately, yes? P.P.S. - Eben mentioned to me that he was concerned that people might falsely interpret some of the new 8.2.0 Sugar APIs as stable when they are, in fact, almost certain to change in the next major release. I would find it commendable if some Sugar developer took this last opportunity to add some bold comments to the relevant APIs warning developers who examine them about this probable future breakage. Eben, what APIs are you thinking about? In general the whole Sugar API will need to be reviewed. I have yet to figure out when, how and what kind of backward compatibility we offer. It's something I'll be working on in the next few weeks. Eben specifically mentioned the APIs used by Frame devices, layouts, and Control Panel entries. Michael ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
