Re: [Sugar-devel] [PATCH] Title for 'Rectangular Marquee' tool changed to 'Select Area' (SL 2266)
2010/10/12 Ayush Goyal ay...@seeta.in: From: Ayush Goyal ayush at seeta.in Signed-off-by: Ayush Goyal ayush at seeta.in --- po/Paint.pot | 2 +- po/af.po | 2 +- po/am.po | 2 +- po/ar.po | 2 +- po/ay.po | 2 +- po/bg.po | 2 +- po/bi.po | 2 +- po/bn.po | 2 +- po/bn_IN.po | 2 +- po/ca.po | 2 +- po/cpp.po | 2 +- po/cs.po | 2 +- po/de.po | 2 +- po/dz.po | 2 +- po/el.po | 2 +- po/en.po | 2 +- po/es.po | 2 +- po/fa.po | 2 +- po/fa_AF.po | 2 +- po/ff.po | 2 +- po/fil.po | 2 +- po/fr.po | 2 +- po/gu.po | 2 +- po/ha.po | 2 +- po/he.po | 2 +- po/hi.po | 2 +- po/ht.po | 2 +- po/hu.po | 2 +- po/ig.po | 2 +- po/is.po | 2 +- po/it.po | 2 +- po/ja.po | 2 +- po/km.po | 2 +- po/ko.po | 2 +- po/ko_KO.po | 2 +- po/kos.po | 2 +- po/mg.po | 2 +- po/mk.po | 2 +- po/ml.po | 2 +- po/mn.po | 2 +- po/mr.po | 2 +- po/ms.po | 2 +- po/mvo.po | 2 +- po/na.po | 2 +- po/nb.po | 2 +- po/ne.po | 2 +- po/nl.po | 2 +- po/pa.po | 2 +- po/pap.po | 2 +- po/pis.po | 2 +- po/pl.po | 2 +- po/ps.po | 2 +- po/pseudo.po | 2 +- po/pt.po | 2 +- po/pt_BR.po | 2 +- po/qu.po | 2 +- po/ro.po | 2 +- po/ru.po | 2 +- po/rw.po | 2 +- po/sd.po | 2 +- po/si.po | 2 +- po/sk.po | 2 +- po/sl.po | 2 +- po/sq.po | 2 +- po/sv.po | 2 +- po/sw.po | 2 +- po/ta.po | 2 +- po/te.po | 2 +- po/th.po | 2 +- po/tpi.po | 2 +- po/tr.po | 2 +- po/tvl.po | 2 +- po/tzo.po | 2 +- po/ug.po | 2 +- po/ur.po | 2 +- po/vi.po | 2 +- po/wa.po | 2 +- po/yo.po | 2 +- po/zh_CN.po | 2 +- po/zh_TW.po | 2 +- toolbox.py | 2 +- You should only need to change toolbox.py, the other files will be updated when the maintainer makes a new release, or by Pootle. Regards, Tomeu 81 files changed, 81 insertions(+), 81 deletions(-) diff --git a/po/Paint.pot b/po/Paint.pot index 6bbc6b4..f0d39df 100644 --- a/po/Paint.pot +++ b/po/Paint.pot @@ -89,7 +89,7 @@ msgid Bucket msgstr #: toolbox.py:365 -msgid Rectangular Marquee +msgid Select Area msgstr #: toolbox.py:417 toolbox.py:1049 toolbox.py:1412 diff --git a/po/af.po b/po/af.po index 884b5f4..efc240b 100644 --- a/po/af.po +++ b/po/af.po @@ -89,7 +89,7 @@ msgid Bucket msgstr #: toolbox.py:365 -msgid Rectangular Marquee +msgid Select Area msgstr #: toolbox.py:417 toolbox.py:1049 toolbox.py:1412 diff --git a/po/am.po b/po/am.po index 599b8e8..10dc4b7 100644 --- a/po/am.po +++ b/po/am.po @@ -89,7 +89,7 @@ msgid Bucket msgstr #: toolbox.py:365 -msgid Rectangular Marquee +msgid Select Area msgstr #: toolbox.py:417 toolbox.py:1049 toolbox.py:1412 diff --git a/po/ar.po b/po/ar.po index d0d8609..2ae532d 100644 --- a/po/ar.po +++ b/po/ar.po @@ -94,7 +94,7 @@ msgid Bucket msgstr محفظة #: toolbox.py:365 -msgid Rectangular Marquee +msgid Select Area msgstr معلِّمة مربّعة #: toolbox.py:417 toolbox.py:1049 toolbox.py:1412 diff --git a/po/ay.po b/po/ay.po index 599b8e8..10dc4b7 100644 --- a/po/ay.po +++ b/po/ay.po @@ -89,7 +89,7 @@ msgid Bucket msgstr #: toolbox.py:365 -msgid Rectangular Marquee +msgid Select Area msgstr #: toolbox.py:417 toolbox.py:1049 toolbox.py:1412 diff --git a/po/bg.po b/po/bg.po index 7f45f15..ad8b3ae 100644 --- a/po/bg.po +++ b/po/bg.po @@ -88,7 +88,7 @@ msgid Bucket msgstr Заливка #: toolbox.py:365 -msgid Rectangular Marquee +msgid Select Area msgstr Правоъгълно маркиране #: toolbox.py:417 toolbox.py:1049 toolbox.py:1412 diff --git a/po/bi.po b/po/bi.po index 884b5f4..efc240b 100644 --- a/po/bi.po +++ b/po/bi.po @@ -89,7 +89,7 @@ msgid Bucket msgstr #: toolbox.py:365 -msgid Rectangular Marquee +msgid Select Area msgstr #: toolbox.py:417 toolbox.py:1049 toolbox.py:1412 diff --git a/po/bn.po b/po/bn.po index a163110..d6ac625 100644 --- a/po/bn.po +++ b/po/bn.po @@ -88,7 +88,7 @@ msgid Bucket msgstr ঝুড়ি #: toolbox.py:365 -msgid Rectangular Marquee +msgid Select Area msgstr চতুর্ভূজাকার মার্কিউই #: toolbox.py:417 toolbox.py:1049 toolbox.py:1412 diff --git a/po/bn_IN.po b/po/bn_IN.po index 3af9f60..9cd9249 100644 --- a/po/bn_IN.po +++ b/po/bn_IN.po @@ -90,7 +90,7 @@ msgid Bucket msgstr বাকেট #: toolbox.py:365 -msgid Rectangular Marquee +msgid Select Area msgstr চতুর্ভূজাকার মার্কিউই #: toolbox.py:417 toolbox.py:1049 toolbox.py:1412 diff --git a/po/ca.po b/po/ca.po index 175dc22..8585e5a 100644 ---
Re: [Sugar-devel] [PATCH] Keep aspect has been added in the Paint pot files (SL 2321)
On Tue, Oct 12, 2010 at 20:05, SHACHI PAUL sha...@seeta.in wrote: The Keep aspect has now been added to the Paint pot files. See http://en.wikipedia.org/wiki/GNU_gettext for an explanation of the translation workflow. You should only need to modify the source code. Regards, Tomeu Signed-off-by: SHACHI PAUL sha...@seeta.in --- po/Paint.pot | 4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/po/Paint.pot b/po/Paint.pot index 6bbc6b4..0ef3c2c 100644 --- a/po/Paint.pot +++ b/po/Paint.pot @@ -116,6 +116,10 @@ msgstr msgid Fill Color: msgstr +#: toolbox.py:531 +msgid Keep aspect +msgstr + #: toolbox.py:740 msgid Fill Color msgstr -- 1.7.0.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] add restart option configurable via gconf (#1206)
On Tue, Oct 12, 2010 at 03:13, James Cameron qu...@laptop.org wrote:
Nepal requested reordering and removal of restart, which was patched for
them in 0.82 and implemented in 0.84.
Paraguay and Uruguay detected the change in 0.84 and requested the
restart option be restored.
This patch restores the restart option as a configurable option, using
the gconf key /desktop/sugar/show_restart, default true.
Refer to http://bugs.sugarlabs.org/ticket/1206 for discussion.
Acked-by: Tomeu Vizoso tomeu.viz...@collabora.co.uk
But we cannot push it yet to master because we haven't branched yet.
We need someone to create the 0.90 branches in Pootle before we can
branch in git.
Regards,
Tomeu
---
data/sugar.schemas.in | 12
src/jarabe/view/buddymenu.py | 6 ++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/data/sugar.schemas.in b/data/sugar.schemas.in
index cfa7edf..474753b 100644
--- a/data/sugar.schemas.in
+++ b/data/sugar.schemas.in
@@ -192,6 +192,18 @@
/schema
schema
+ key/schemas/desktop/sugar/show_restart/key
+ applyto/desktop/sugar/show_restart/applyto
+ ownersugar/owner
+ typebool/type
+ defaulttrue/default
+ locale name=C
+ shortShow Restart/short
+ longIf TRUE, Sugar will show a Restart option./long
+ /locale
+ /schema
+
+ schema
key/schemas/desktop/sugar/peripherals/keyboard/layouts/key
applyto/desktop/sugar/peripherals/keyboard/layouts/applyto
ownersugar/owner
diff --git a/src/jarabe/view/buddymenu.py b/src/jarabe/view/buddymenu.py
index 0ba6cc1..8ea2598 100644
--- a/src/jarabe/view/buddymenu.py
+++ b/src/jarabe/view/buddymenu.py
@@ -86,6 +86,12 @@ class BuddyMenu(Palette):
client = gconf.client_get_default()
+ if client.get_bool('/desktop/sugar/show_restart'):
+ item = MenuItem(_('Restart'), 'system-restart')
+ item.connect('activate', self.__reboot_activate_cb)
+ self.menu.append(item)
+ item.show()
+
if client.get_bool('/desktop/sugar/show_logout'):
item = MenuItem(_('Logout'), 'system-logout')
item.connect('activate', self.__logout_activate_cb)
--
1.7.1
--
James Cameron
http://quozl.linux.org.au/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] annotation support in abiword (was Fwd: uwog - r29358 - in abiword/trunk: . plugins/collab/backends/service/xp plugins/collab/core/packet/xp plugins/collab/core/plugin/xp plugins/col
On Mon, Oct 11, 2010 at 14:51, Gary Martin garycmar...@googlemail.com wrote: Hi Tomeu, On 11 Oct 2010, at 09:25, Tomeu Vizoso to...@sugarlabs.org wrote: Hi, would be nice to add support for annotations in Write now that Abiword supports it. True, but only if you promise that the Write UI will get easier to use and not more difficult ;) I think we're falling towards featureitus while not managing complexity. Same thing is happening to Calculate. When I give a talk about Sugar, one of its main features is Clarity. The idea is to avoid saying simplicity because it may seem in conflict with our goal of low floor, no ceiling. I then explain that with clarity I mean that the features are layered in such a way that it's clear to the user how to do what she wants to do in each moment. Regards, Tomeu FWIW, in the Calculate case, I've been considering the need for a really simple calculator activity called Sums, with a very minimal feature set**. Perhaps we could do the same for Write and have a minimal feature set activity called Note (or Text if you don't mind that modern verb usage)? It would just be a simpler wrapper over the Abiword libs. Still not sure this is the right way to go to keep Sugar usable for our younger learners (where I think Sugar is most ideally placed), as having multiple Activities for the same activity does introduce additional maintenance, and testing load. ** Ideally we should try harder to better layer complexity in the Write, Calculate, et al UIs so that you need to drill down to the more complex features while the common/novice features are exposed early at the top level — but it seams there's only so far you can take this (Write and Calculate being on the cusp of this cliff edge). Regards, --Gary Regards, Tomeu -- Forwarded message -- From: J.M. Maurer u...@uwog.net Date: Sat, Oct 9, 2010 at 17:30 Subject: Re: uwog - r29358 - in abiword/trunk: . plugins/collab/backends/service/xp plugins/collab/core/packet/xp plugins/collab/core/plugin/xp plugins/collab/core/session/xp plugins/opendocument plugins/opendocument/exp/xp plugins/opendocument/imp/xp src/af/gr/xp src/text/fmt/xp src/text/ptbl/xp src/wp/impexp/xp test/wp To: abiword-...@abisource.com Hi All! With this merge of Ben Martin's awesome work, AbiWord trunk (what will become AbiWord 2.9.0, the first 2.9 development release) has gained an awesome new feature: support for RDF. For those unfamiliar with RDF, you can read all about it on Wikipedia: http://en.wikipedia.org/wiki/Resource_Description_Framework It defines a metadata standard that AbiWord now supports. This means you can annotate pieces of content with generic metadata. For example you could attach contact data to a person who's name is mentioned in a text document. The use-cases are of course endless, so feel free to come up with cool use-cases, write patches, and we will gladly integrate them into AbiWord (or let you integrate them). A sample document containing RDF is attached. If you build AbiWord with debug support (--enable-debug) then you will find some fun RDF debugging menu items in the Collaborate menu (make sure to compile with --enable-plugins=collab). There is no particular reason why this in the Collaborate menu, it just had to go somewhere temporarily. There is full RDF support in AbiWord's internal model to hold the metadata. This work also supports reading and writing the metadata to AbiWord's native file format .abw and to OpenDocument .odt documents. Adding metadata to a document that is collaboratively being worked on will automatically synchronize the metadata as well. Surely there are certain bugs that need to be hashed out, but that's to be expected in a development release :) Cheers! Marc On Sat, 2010-10-09 at 17:06 +0200, c...@abisource.com wrote: Author: uwog Date: 2010-10-09 17:06:33 +0200 (Sat, 09 Oct 2010) New Revision: 29358 Added: abiword/trunk/plugins/opendocument/exp/xp/ODe_RDFWriter.cpp [snip] abiword/trunk/src/wp/impexp/xp/ie_imp_XML.h Log: svn merge -r29073:29323 svn+ssh://svn.abisource.com/svnroot/abiword/branches/monkeyiqrdf/ . ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] prerequisite skills for contributing code (was Re: [Dextrose] [PATCH v4 sugar] Pulsing icon delayed by 5 seconds or so SL#2080)
On Tue, Oct 12, 2010 at 00:07, Bernie Innocenti ber...@codewiz.org wrote: On Mon, 2010-10-11 at 18:23 -0300, Gonzalo Odiard wrote: In my experience, it's easier start resolving tickets in activities than in the plataform. That worked for me: * start writing a new activity: you can do stupid things, while learn python and the interaction with the platform. * try t resolve easy tickets in activities: there are many in http://bugs.sugarlabs.org/ and http://dev.laptop.org/ * next try to solve problems in Sugar. I completely agree with you. This has been said several times to Seeta developers (and is valid for everybody). Manu, could you please explain what learning are doing Seeta developers before they try to submit a contribution? I'm under the strong impression that people are trying to play football before learning to walk and this isn't helping nobody. Thanks, Tomeu -- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] A little change to www.sugarlabs.org
[adding the IAEP, marketing and systems mailing lists] On Mon, Oct 11, 2010 at 21:05, nanon...@mediagala.com wrote: Tomeu Vizoso wrote: At least in not-ancient versions of Browse, popups open as new tabs. -- Attached is the screen-shot that 400,000 children see in their own XO in Uruguay, using Browse v 101, when they want to download an Activity in SUGARLABS.ORG. Thks PAolo Benini Montevideo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] changes in trac and others
On Sat, Oct 9, 2010 at 08:46, Tabitha Roder tabi...@tabitha.net.nz wrote: What would be the difference between Owner and Developer then? I assumed that owner was the same as maintainer same as developer. Tom tells me that at his work the bug is assigned to an assignee or a team. In either case the team leader is officially the owner but often someone else takes on the owner duties that is not tracked. The other option at his work is cc list for those who want to know what happens. Language is complicated, and I speak English as a first language, must be hard for our friends who speak English as another language to work out what is going on with these titles. Yes, all the webapps we use have different terms for the roles, I'm afraid we cannot do much better than document it clearly in the wiki or so unless we fork them. Regards, Tomeu Tabitha ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] Become a proven Fedora tester
Hi, === Background === in Fedora the QA team is trying to keep the quality high by having different states of update packages intended for a maintained release of Fedora. The updates-testing repository, contains updates scheduled to be released for the maintained releases of Fedora. User testing and feedback provided via Bodhi, on the test mailing list and the relevant Bugzilla is vital to ensure that good updates are released quickly and bad ones kept away from release. Feedback from proven testers [1] is required for critical path package updates. === Task === The Geode video driver in Fedora (XO-1) [2] is one of those critical path packages. As you see from the link, it already has positive feedback, so it needs the '+1' from a proven packager in order to get into the stable repository. If you are interested in helping out with this specific issue and maybe are interested in later testing other olpc/sugar related packages in Fedora that would be great. In case you don't know yet, there are some interesting discussions going on about incorporating Sugar and SoaS testing into the QA process [3]. Regards, Simon [1] https://fedoraproject.org/wiki/Proven_tester [2] https://admin.fedoraproject.org/updates/xorg-x11-drv-geode-2.11.9-1.fc14 [3] http://lists.sugarlabs.org/archive/sugar-devel/2010-September/027105.html ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH v3 Word] Updated translated word when language to translate is changed. (Ticket #2210)
Hi Wish if you could review the patch attached below and let me know your feedback. Thank you for your support. Regards Ishan On Tue, Oct 12, 2010 at 12:32 PM, Ishan Bansal is...@seeta.in wrote: New global variable 'newtotranslate' added to update the translated text when the language to translate is being changed. Signed-off-by: Ishan Bansal is...@seeta.in, Anubhav Aggarwal anub...@seeta.in --- pippy_app.py |4 1 files changed, 4 insertions(+), 0 deletions(-) v1-v2 : Global variable removed and subject updated. v2-v3 : Co-author fields added in accordance with the guidelines for patch submission diff --git a/pippy_app.py b/pippy_app.py index b9a5a25..f9b0be7 100644 --- a/pippy_app.py +++ b/pippy_app.py @@ -49,6 +49,7 @@ class WordsActivity(ViewSourceActivity): self.fromlang = English self.tolang = Spanish self.languagemodel = LanguageModel.LanguageModel() +self.newtotranslate = 'none' # Main layout. hbox = gtk.HBox(homogeneous=True) @@ -151,6 +152,8 @@ class WordsActivity(ViewSourceActivity): def lang2combo_cb(self, combo): self.languagemodel.SetLanguages(English, self.langs[combo.get_active()]) +self.translated.set_text() +self.totranslate_cb(self.newtotranslate) def lang1sel_cb(self, column): # FIXME: Complete the text entry box @@ -177,6 +180,7 @@ class WordsActivity(ViewSourceActivity): def totranslate_cb(self, totranslate): entry = totranslate.get_text() +self.newtotranslate = totranslate # Ask for completion suggestions if not entry: return -- 1.7.0.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH v5 sugar] Pulsing icon delayed by 5 seconds or so SL#2080
When we click on the icon of an activity we see a pulsing icon of that activity before the activity starts and usually there is a time delay between the clicking of the icon and appearance of the pulsing icon , where tha amount of delay differs by the complexity of the icon i.e. more complex the icon is larger is the delay. So In order to minimise the delay we replaced the animation with its raw svg image for the first frame of rendering only there by reducing the rendering timeof the first frame and hence reducing the delay and from the second frame onwards the svg image will be converted into the pulsing icon animation. To stop the pulsing icon from animating for the first frame we stopped the call to the update function for first two times only, as every frame has two update calls associated with it, once the update that preceeds the frame and the other that follows it. --- src/jarabe/view/pulsingicon.py |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) v1-v2 corrected layout according to pep-8 format v2-v3 removed increment operation of variable i in the for loop v3-v4 added the concept of frame skipping v4-v5 changed the first frame of the animation to static svg icon diff --git a/src/jarabe/view/pulsingicon.py b/src/jarabe/view/pulsingicon.py index 43ec358..70040a6 100644 --- a/src/jarabe/view/pulsingicon.py +++ b/src/jarabe/view/pulsingicon.py @@ -30,7 +30,7 @@ class Pulser(object): self._icon = icon self._level = 0 self._phase = 0 - +self._count = 1 def start(self, restart=False): if restart: self._phase = 0 @@ -79,8 +79,9 @@ class Pulser(object): def __pulse_cb(self): self._phase += _STEP self._level = (math.sin(self._phase) + 1) / 2 -self.update() - +if self._count 2: + self.update() +self._count = self._count + 1 return True class PulsingIcon(Icon): -- 1.7.2.3 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] prerequisite skills for contributing code (was Re: [Dextrose] [PATCH v4 sugar] Pulsing icon delayed by 5 seconds or so SL#2080)
Tomeu, On Wed, Oct 13, 2010 at 2:18 PM, Tomeu Vizoso to...@sugarlabs.org wrote: On Tue, Oct 12, 2010 at 00:07, Bernie Innocenti ber...@codewiz.org wrote: On Mon, 2010-10-11 at 18:23 -0300, Gonzalo Odiard wrote: In my experience, it's easier start resolving tickets in activities than in the plataform. That worked for me: * start writing a new activity: you can do stupid things, while learn python and the interaction with the platform. * try t resolve easy tickets in activities: there are many in http://bugs.sugarlabs.org/ and http://dev.laptop.org/ * next try to solve problems in Sugar. I completely agree with you. This has been said several times to Seeta developers (and is valid for everybody). Manu, could you please explain what learning are doing Seeta developers before they try to submit a contribution? Appreciate the feedback. Sure, SEETA developers are going through the following training and patch submission workflow - 1. Revision/learning of Python, PyGTK skills through algorithms and programs; 2. Studying Sugar manual, and getting familiar with using the emulator and jhbuild; 3. James Simmon's guide on activity development (I do agree that this was not done for initial developers. But, every new developer is asked to study it); 4. Patch workflow and documentation on code reviews; 5. Asking the team members to go through certain patches accepted upstream, and submitted by Sascha, you and other team members; 6. Assignment of bugs and initial discussion with Aleksey and Bernie; 7. Submission of test patches in-house for peer review before submission to sugar-devel/dextrose/usr mailing lists; 8. Final submission. Wish if you could provide feedback, and let us know if we are missing on any step. Regards, Manu Thanks, Tomeu -- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] prerequisite skills for contributing code (was Re: [Dextrose] [PATCH v4 sugar] Pulsing icon delayed by 5 seconds or so SL#2080)
On Wed, Oct 13, 2010 at 11:59, Manusheel Gupta m...@seeta.in wrote: Tomeu, On Wed, Oct 13, 2010 at 2:18 PM, Tomeu Vizoso to...@sugarlabs.org wrote: On Tue, Oct 12, 2010 at 00:07, Bernie Innocenti ber...@codewiz.org wrote: On Mon, 2010-10-11 at 18:23 -0300, Gonzalo Odiard wrote: In my experience, it's easier start resolving tickets in activities than in the plataform. That worked for me: * start writing a new activity: you can do stupid things, while learn python and the interaction with the platform. * try t resolve easy tickets in activities: there are many in http://bugs.sugarlabs.org/ and http://dev.laptop.org/ * next try to solve problems in Sugar. I completely agree with you. This has been said several times to Seeta developers (and is valid for everybody). Manu, could you please explain what learning are doing Seeta developers before they try to submit a contribution? Appreciate the feedback. Sure, SEETA developers are going through the following training and patch submission workflow - 1. Revision/learning of Python, PyGTK skills through algorithms and programs; 2. Studying Sugar manual, and getting familiar with using the emulator and jhbuild; 3. James Simmon's guide on activity development (I do agree that this was not done for initial developers. But, every new developer is asked to study it); 4. Patch workflow and documentation on code reviews; 5. Asking the team members to go through certain patches accepted upstream, and submitted by Sascha, you and other team members; 6. Assignment of bugs and initial discussion with Aleksey and Bernie; 7. Submission of test patches in-house for peer review before submission to sugar-devel/dextrose/usr mailing lists; 8. Final submission. Wish if you could provide feedback, and let us know if we are missing on any step. If you provide links to the materials used in each step, people could suggest additions, start a section in the wiki and maybe write a TODO list of the material that needs to be added or improved. Regards, Tomeu Regards, Manu Thanks, Tomeu -- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] prerequisite skills for contributing code (was Re: [Dextrose] [PATCH v4 sugar] Pulsing icon delayed by 5 seconds or so SL#2080)
On Wed, Oct 13, 2010 at 03:29:19PM +0530, Manusheel Gupta wrote: Sure, SEETA developers are going through the following training and patch submission workflow - 1. Revision/learning of Python, PyGTK skills through algorithms and programs; 2. Studying Sugar manual, and getting familiar with using the emulator and jhbuild; 3. James Simmon's guide on activity development (I do agree that this was not done for initial developers. But, every new developer is asked to study it); 4. Patch workflow and documentation on code reviews; 5. Asking the team members to go through certain patches accepted upstream, and submitted by Sascha, you and other team members; 6. Assignment of bugs and initial discussion with Aleksey and Bernie; 7. Submission of test patches in-house for peer review before submission to sugar-devel/dextrose/usr mailing lists; 8. Final submission. Good list of tasks. However, perhaps there should be more assessment along the way. We're seeing people start step 8 either carelessly or without underpinning knowledge from earlier steps. I suggest assessment by peers as well ... it can be quite effective. -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH v3 Word] Updated translated word when language to translate is changed. (Ticket #2210)
On Wed, Oct 13, 2010 at 03:17:27PM +0530, Ishan Bansal wrote: Wish if you could review the patch attached below and let me know your feedback. I didn't understand the patch at all ... why it was done, how it could be tested, why it was needed. -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)
Previously registration url was set hardcoded for XO device.
Modififed the code for same behavior on all devices. Register url is taken from
gconf prop.
If the gconf is empty or unset, registration url falls back to 'schoolserver'.
---
src/jarabe/desktop/schoolserver.py |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/jarabe/desktop/schoolserver.py
b/src/jarabe/desktop/schoolserver.py
index a05f56c..57b7ddf 100644
--- a/src/jarabe/desktop/schoolserver.py
+++ b/src/jarabe/desktop/schoolserver.py
@@ -89,9 +89,12 @@ def register_laptop(url=REGISTER_URL):
else:
sn = generate_serial_number()
uuid_ = str(uuid.uuid1())
-setting_name = '/desktop/sugar/collaboration/jabber_server'
-jabber_server = client.get_string(setting_name)
-store_identifiers(sn, uuid_, jabber_server)
+
+setting_name = '/desktop/sugar/collaboration/jabber_server'
+jabber_server = client.get_string(setting_name)
+store_identifiers(sn, uuid_, jabber_server)
+
+if jabber_server:
url = 'http://' + jabber_server + ':8080/'
nick = client.get_string('/desktop/sugar/user/nick')
--
1.7.0.4
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] Patches Review required for SL2151 : Shutdown and Logout menu items should activate the busy cursor (or provide some other visual feedback)
Team, I have submitted a revised patch for SL # 2151 : Shutdown and Logout menu items should activate the busy cursor (or provide some other visual feedback) at http://patchwork.sugarlabs.org/patch/290/ . I would like get this patch reviewed for any errors or improvements so that i can update my next version of the patch. Regards, Anurag Research Engineer SEETA ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)
On Wed, Oct 13, 2010 at 03:53:22PM +0530, Dipankar Patro wrote:
Previously registration url was set hardcoded for XO device.
Modififed the code for same behavior on all devices. Register url is taken
from gconf prop.
If the gconf is empty or unset, registration url falls back to 'schoolserver'.
Please text wrap your commit message.
--- a/src/jarabe/desktop/schoolserver.py
+++ b/src/jarabe/desktop/schoolserver.py
@@ -89,9 +89,12 @@ def register_laptop(url=REGISTER_URL):
if have_ofw_tree():
sn = read_ofw('mfg-data/SN')
uuid_ = read_ofw('mfg-data/U#')
sn = sn or 'SHF'
uuid_ = uuid_ or '----'
else:
sn = generate_serial_number()
uuid_ = str(uuid.uuid1())
-setting_name = '/desktop/sugar/collaboration/jabber_server'
-jabber_server = client.get_string(setting_name)
-store_identifiers(sn, uuid_, jabber_server)
+
+setting_name = '/desktop/sugar/collaboration/jabber_server'
+jabber_server = client.get_string(setting_name)
+store_identifiers(sn, uuid_, jabber_server)
+
+if jabber_server:
url = 'http://' + jabber_server + ':8080/'
You are effectively repeating the previous if statement but using the
output ... seems a bit obscure.
--
James Cameron
http://quozl.linux.org.au/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [DESIGN] Read: focus after launching
Hi, when working on the issue in Read that the dpad keys do not work directly when in ebook mode [1], I postulated that Read when it comes up should always grab the focus on the view so scrolling using the arrow keys is directly possible. I looked around and when opening a new tab in Firefox, scrolling using the error keys does work out of the box, in open-office and abiword not (you can use for example a wheel of the mouse directly). In evince using the arrow keys does work as well directly after launching. What do others think about it? Maybe there are other ways of dealing with this issue (we should probably look at the evince code what they do). Regards, Simon [1] http://dev.laptop.org/ticket/10396 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] prerequisite skills for contributing code (was Re: [Dextrose] [PATCH v4 sugar] Pulsing icon delayed by 5 seconds or so SL#2080)
On 10/13/2010 12:08 PM, James Cameron wrote: On Wed, Oct 13, 2010 at 03:29:19PM +0530, Manusheel Gupta wrote: Sure, SEETA developers are going through the following training and patch submission workflow - 1. Revision/learning of Python, PyGTK skills through algorithms and programs; 2. Studying Sugar manual, and getting familiar with using the emulator and jhbuild; 3. James Simmon's guide on activity development (I do agree that this was not done for initial developers. But, every new developer is asked to study it); 4. Patch workflow and documentation on code reviews; 5. Asking the team members to go through certain patches accepted upstream, and submitted by Sascha, you and other team members; 6. Assignment of bugs and initial discussion with Aleksey and Bernie; 7. Submission of test patches in-house for peer review before submission to sugar-devel/dextrose/usr mailing lists; 8. Final submission. Good list of tasks. However, perhaps there should be more assessment along the way. We're seeing people start step 8 either carelessly or without underpinning knowledge from earlier steps. I suggest assessment by peers as well ... it can be quite effective. I think having teaching as well in a group is an important step. The developers should review the patches of each other. That should happen before the patches are hitting the other developers. You can do that already on the list if you want. The ones that have already managed to successfully submit a patch should start to train the others. And the feedback you get from the reviews should be spread in this group and should be made available to others, either by adjusting your internal guides or by contributing back to the main guides and help out refining them where needed. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Marketing] A little change to www.sugarlabs.org
On 10/13/2010 10:49 AM, Tomeu Vizoso wrote: [adding the IAEP, marketing and systems mailing lists] Can someone that has access please just make this change. I already asked for that 1 or 2 years ago. Maybe the feedback from the field helps to actually make it happen. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)
Thanks for reviewing it, James.
if have_ofw_tree():
sn = read_ofw('mfg-data/SN')
uuid_ = read_ofw('mfg-data/U#')
sn = sn or 'SHF'
uuid_ = uuid_ or '----'
else:
sn = generate_serial_number()
uuid_ = str(uuid.uuid1())
-setting_name = '/desktop/sugar/collaboration/jabber_server'
-jabber_server = client.get_string(setting_name)
-store_identifiers(sn, uuid_, jabber_server)
+
+setting_name = '/desktop/sugar/collaboration/jabber_server'
+jabber_server = client.get_string(setting_name)
+store_identifiers(sn, uuid_, jabber_server)
+
+if jabber_server:
url = 'http://' + jabber_server + ':8080/'
You are effectively repeating the previous if statement but using the
output ... seems a bit obscure.
^^ Before applying this : The url (url for registration) was set from gconf
only for non-XO devices.
I moved that outside the first if..else you have quoted, so that on all
devices the url is taken from the gconf property
(/desktop/sugar/collaboration/jabber_server)
the second 'if jabber_server:' is put there to check whether the
jabber_server retrieved from the gcnof property is empty or unset. If
jabber_server is a valid one, then change url, other wise keep the url =
initialized one.
I actually went with the above modification due to the chain of mails here :
http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025265.html
Regards,
Dipankar
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Marketing] A little change to www.sugarlabs.org
On Wed, Oct 13, 2010 at 12:57, Simon Schampijer si...@schampijer.de wrote: On 10/13/2010 10:49 AM, Tomeu Vizoso wrote: [adding the IAEP, marketing and systems mailing lists] Can someone that has access please just make this change. I already asked for that 1 or 2 years ago. Maybe the feedback from the field helps to actually make it happen. Actually we already had feedback from the field more than a year ago: http://lists.sugarlabs.org/archive/marketing/2009-April/000910.html Regards, Tomeu Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Design]: SL 2338 (Paint-28 - add custom icons for rest of Shape cursors)
Thanks Ayush and James.
Change commited and ticket closed.
Gonzalo
On Tue, Oct 12, 2010 at 8:48 PM, James Cameron qu...@laptop.org wrote:
On Tue, Oct 12, 2010 at 10:52:29PM +0530, Ayush Goyal wrote:
Wish if you could review the custom icons in the links attached below,
and let me know your feedback -
I've reviewed them and tested them, they work fine. Tested on XO-1 with
Sugar 0.84.
Once they are moved to images/ they work, though the polygon.png file
must be renamed. Here is your contribution in the form of a patch with
reviewed-by and tested-by tags added.
From 7c89a60dfad0dfc9c6b3261c78bc5a52de7b78bc Mon Sep 17 00:00:00 2001
From: Ayush Goyal ay...@seeta.in
Date: Wed, 13 Oct 2010 10:43:36 +1100
Subject: [PATCH] add custom icons for line, freeform and polygon (#2338)
Reviewed-by: James Cameron qu...@laptop.org
Tested-by: James Cameron qu...@laptop.org
---
images/freeform.png| Bin 0 - 1414 bytes
images/line.png| Bin 0 - 1250 bytes
images/polygon_regular.png | Bin 0 - 923 bytes
3 files changed, 0 insertions(+), 0 deletions(-)
create mode 100644 images/freeform.png
create mode 100644 images/line.png
create mode 100644 images/polygon_regular.png
diff --git a/images/freeform.png b/images/freeform.png
new file mode 100644
index
..fe43719bc2e24539b6a35b8cc2a9e55092f04196
GIT binary patch
literal 1414
zcmV;11$p|3P)h;3K|lk000e1njltq001wd001w...@s6jh6lc1b5ch_0itp)
z=Px#24YJ`L;wH)0002_L%V+f000SaNLh0L01FcU01FcV0GgZ_7bV*G`2igh@
z4*)1...@phk00jm~l_t(o!_AnZxdG-#eeg#Jx)lsstejl!yq)3!(}M(GM0)T%q
z...@azngCp`!b!%dw*7D!ZSOqD_kOiVFn1mE0D#s7;s3s!Hm-0rJZ=|n...@-
zo+PF{(n$8bb7zk49z2a$Q$!Zf+8dMgedf2SrhkB#B3TCHN5CZ$qIs#dFQ?~`oX
z7OJW?G}^X}qA19+OfTU$4!K+o!!TOTgzS0VHcLrDk|ZLL2;p$...@mo2#V044YZ
zDv3mbSS;3h~BDs#WoogvO9?hr?`bZP9CFG8xk8G^S~?w6wHq_GBT%HX-dZzwuKL
z1GsYK3IOqVoaU_s;BTsG#pF|?R4TE!xClTj7CY6JTswrrVg4)z...@ymjul$i#kzu
zmSyDwlj|j...@z2|O%um)_+OAafBrn#Y?gF74ZzCEN=uznJFdB``0`Ra)%6fU9H^4i
zMA)({0+Xu|Yg=CSNvzxQr3QWQ?c2A%(lqUHG#W)!Rb*N2Sse~cE*gzK4uwKKsa_g{
zz~nSd^G!i7i2lVUm(k}e;xJ-uE)cN4}+8QJP$=t03;Ki~04_vaAMOYbMq(bCpV^
zz42TFOc*3=RGNFex%fO$55Qlw6RT-jXEktLSGcabXAP|pnwy)GYJRWNvh3g#
zu+r2v3N)9hFMuC`pMigX-+|v`S(aPcm39bd;s5BOZ5wJAqFtC^Lb4TDyDmptMvX
zrho|{1o?a(UDp{J8shBPvlD%NeN(_=;0Uk?P%f7N7#J7`E+vlR1Qp$%UDxIL^XJ^S
zaf5}01x}...@kiz7cn}*mc4ijqmnf;+qZ9d^ym?bi;F0V!nt$jn4FyC=+UFyldJ79
zX`7kYV}E`Qd}|m6v...@x^;_jSZeXdq#hMKZ!)*r^T=xVpOf{p{4H*ek~pUNx
z3a3w=KAPT)cR(dvbnnc0d=zcqjh8y3xczci...@h?j7d4j5{ynolccm{s)?%m_X
zix+X^71mTUcJJ$?cf!n6^p{...@6p-30-ivLr1Y#q`$u(Ns`8nA3x6h`}dI~
z$ybB=hlk0-}...@pyc7^t*toc=?1uht2g%j7}8r+W?q+S;-GnoXx!`RmnQ2+=2m
z(DL~_g+c+_wi^bIjg8?r4zXBlFcOIzZsFhc09BP$RrTsu*|IFym^CR7}P?0{hpee
zo5L^+o4ng=;T5`{d9Ou{Uf$*Q|88^q8E`FZB=l3=lH79!M(xp8e!_K`8(pei
zj7zxdi...@`00^y?@|6`fi1*sfidhsg*d_s?#}...@wrtgwpbols3?k{rhnM{(
zWEdVEZpf9HOon7KiQ_nwN+qeC0jsc...@_*4nh$poe(5lFQ`)NT^ji...@n7r?v
z#iAeIa=9F!brUv$!4v#M7)ynp{5*L4qW(+$IrK79DV=;)}3$K!qquPx=u%8Jx3
zzSU!4VS!XCHSqD{M?gdz=cr77...@lb%lypdldr=dUORvvEW`+(y(bQ-sBwRao`
z(=_v4cy}m...@8^m(3#=XqT_=H?hs8+Q;97M(+C=?Ri3B1jgh10YKMEX5;cr4^
ze0)51`sn96zkcoezfl...@vdeff}!wrfegpr~{j|iJdrcVpr+v)|#oRilQj|3r2NM
U_02#EdT%j07*qoM6N$f#Ic{{R30
literal 0
HcmV?d1
diff --git a/images/line.png b/images/line.png
new file mode 100644
index
..9bfa3637681668bc33580970aa5231d070ceab6d
GIT binary patch
literal 1250
zcmV81ReW{P)h;3K|lk000e1njltq001wd001w...@s6jh6lc1b5ch_0itp)
z=Px#24YJ`L;(K){{a7y{D4^000SaNLh0L01FcU01FcV0GgZ_7bV*G`2igh@
z4k-yp6F9X100d%5L_t(o!_Am6Pa8=T$A7aP*0yAXDGpO0vAQ%VBA`M#DZ*%%9HRn
zxDb$kwfcazcq...@1`?i$am7qxn)KBP1vwTBkwiiY(CvyzzSH3hdR|SqCrJxqH$y
zGb_)}Z{EE3eND0mhwE0Yh...@b5@uDTEM=${LLZj^j|T*F~ez==+^$Hk(RH*)`d0
zHc6#YXqv_-GuId#{jyo~jp76id9...@qnt{2x*mFO6r)@V_6nbN*+IcOfHv;
z_nhZJ~;41t6q`ufxy}fo1qml...@8ol#`)ondppg6?w0%gx-$?...@a)+$0P^`f
zy`cpV236zQ;d@)XUgz-e5P)1R_hVnUex~a|CQYdH_9WPotT2VF3WwbAn38PK@
z^9BINaqxYg{{vJSYH!i*mUP!1?)k...@ufJaa7-rkBpGj+#HL6xMFgk9GqFb|%
zZ+Wv*r4t0...@!jg6lnasOvHj9)JP18nJhZDnPv)OlJV`CxICQ`dxJ)j...@ys
z0m!5qXqpy|Vc+1WZEtTUhYNy$R4SEt^IR?$)=...@uyygbuseninudfh*l@5=UR^qHs
z...@?)eO+KHGy|i~02eyj*1%7kutpk4ow...@v9ym4adydnahfv9dkyiT~dLyI3sR
znx*7a;2XQQNkO*#eP=x;66OQjN)WdY2z*KTQ(Y3r1zqKBZhhQr!E5f#I08G=w
zG))Jv6V=vE01qLB#DW=y!P3%_0xV!V5nShnihGbnyw(?NZEa1JN~OPm=ZQTRVN!9o
za#zO2z#iKX?l8k=wSDS`|4`P*|o?-51X9HTM8_P#MTbR{gM)S`JZDVXcJcE99)
zAGqFf5+q3%QLxq3Rr~7ds=vtSDADERvSHa``c!8EkGw1SX}l_xAQUK0e0tyx7vH
zigzoseag3ws...@dk0rjr1rqu9|QqsXJ=TJ#l^)%yyxomy6}A;(=...@46d$lh#cj-b
zN(i...@qm3qy)N!5;)87a^|n`plqnbev...@nz1kekw{nrme`~s;XA2U2`WVC(5!c
zdPiGA8A_?j=H_N#7=~mYGoLP+T7dlu{L?lo3tn9l*)SNnX5o!G{kYLOIqM65#Uk
zQhfgWnMaQvseCkcHy0)JU4d{o1!qSOP!q?Cg9q#^Su=I1c;!`z$UlQYaLoC$X
zuxqunkwz+^dz59kkl$...@jqcip3(PX#()_;xIkVq(HwOW0v$kEXeySuy0CPX%
zm5d8;$8p{dp!r3lf35~rfl4rhhc+t1...@=wwmp~+V6)4IGSgdhk4uCA^)I5?nI
zt5GNvIx(EQ`-=YQXgn{(JQsr*VpZ*PoMJS$)a~qB1`^H#0MXl(MVZh_?ECaJSTJ
Re: [Sugar-devel] New upstream releases of telepathy-salut and telepathy-gabble
These are in updates-testing but need some more karma ;-) Peter On Sat, Oct 9, 2010 at 11:02 AM, Simon Schampijer si...@schampijer.de wrote: Hi, there have been new releases of telepathy-salut and telepathy-gabble. Those fix #2389, so they are worth considering packaging for a good collaboration experience in Sugar 0.90. telepathy-gabble 0.10.3: http://lists.freedesktop.org/archives/telepathy/2010-October/004957.html telepathy-salut 0.4.0: http://lists.freedesktop.org/archives/telepathy/2010-October/004958.html Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH v3 Word] Updated translated word when language to translate is changed. (Ticket #2210)
Hi I have attached the screenshots to illustrate the bug and the patch for the same. For the bug check [1] http://seeta.in/dextrose/sl2010/initialword1.png [2] http://seeta.in/dextrose/sl2010/initialword2.png To check for the patch [1] http://seeta.in/dextrose/sl2010/finalword1.png [2] http://seeta.in/dextrose/sl2010/finalword2.png Regards ishan On Tue, Oct 12, 2010 at 12:32 PM, Ishan Bansal is...@seeta.in wrote: New global variable 'newtotranslate' added to update the translated text when the language to translate is being changed. Signed-off-by: Ishan Bansal is...@seeta.in, Anubhav Aggarwal anub...@seeta.in --- pippy_app.py |4 1 files changed, 4 insertions(+), 0 deletions(-) v1-v2 : Global variable removed and subject updated. v2-v3 : Co-author fields added in accordance with the guidelines for patch submission diff --git a/pippy_app.py b/pippy_app.py index b9a5a25..f9b0be7 100644 --- a/pippy_app.py +++ b/pippy_app.py @@ -49,6 +49,7 @@ class WordsActivity(ViewSourceActivity): self.fromlang = English self.tolang = Spanish self.languagemodel = LanguageModel.LanguageModel() +self.newtotranslate = 'none' # Main layout. hbox = gtk.HBox(homogeneous=True) @@ -151,6 +152,8 @@ class WordsActivity(ViewSourceActivity): def lang2combo_cb(self, combo): self.languagemodel.SetLanguages(English, self.langs[combo.get_active()]) +self.translated.set_text() +self.totranslate_cb(self.newtotranslate) def lang1sel_cb(self, column): # FIXME: Complete the text entry box @@ -177,6 +180,7 @@ class WordsActivity(ViewSourceActivity): def totranslate_cb(self, totranslate): entry = totranslate.get_text() +self.newtotranslate = totranslate # Ask for completion suggestions if not entry: return -- 1.7.0.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Title for 'Rectangular Marquee' tool changed to 'Select Area' (SL 2266)
But in this case, the change is over a already translated text.
The procedure is the same?
Gonzalo
You should only need to change toolbox.py, the other files will be
updated when the maintainer makes a new release, or by Pootle.
Regards,
Tomeu
#: toolbox.py:417 toolbox.py:1049 toolbox.py:1412
diff --git a/toolbox.py b/toolbox.py
index 90f664d..299181b 100644
--- a/toolbox.py
+++ b/toolbox.py
@@ -434,7 +434,7 @@ class ToolsToolbar(gtk.Toolbar):
-self._tool_marquee_rectangular =
DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Rectangular
Marquee'))
+self._tool_marquee_rectangular =
DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Select
Area'))
self.insert(self._tool_marquee_rectangular, -1)
try:
self._configure_palette(self._tool_marquee_rectangular,
self._TOOL_MARQUEE_RECTANGULAR)
--
1.7.1
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
--
Gonzalo Odiard
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Title for 'Rectangular Marquee' tool changed to 'Select Area' (SL 2266)
On Wed, Oct 13, 2010 at 13:44, Gonzalo Odiard godi...@gmail.com wrote:
But in this case, the change is over a already translated text.
The procedure is the same?
Yes, Pootle will generate a new .pot, will merge it into each existing
.po and will mark the changed strings as fuzzy so they get the
attention of translators.
Regards,
Tomeu
Gonzalo
You should only need to change toolbox.py, the other files will be
updated when the maintainer makes a new release, or by Pootle.
Regards,
Tomeu
#: toolbox.py:417 toolbox.py:1049 toolbox.py:1412
diff --git a/toolbox.py b/toolbox.py
index 90f664d..299181b 100644
--- a/toolbox.py
+++ b/toolbox.py
@@ -434,7 +434,7 @@ class ToolsToolbar(gtk.Toolbar):
- self._tool_marquee_rectangular =
DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Rectangular
Marquee'))
+ self._tool_marquee_rectangular =
DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Select
Area'))
self.insert(self._tool_marquee_rectangular, -1)
try:
self._configure_palette(self._tool_marquee_rectangular,
self._TOOL_MARQUEE_RECTANGULAR)
--
1.7.1
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
--
Gonzalo Odiard
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Become a proven Fedora tester
On Wed, Oct 13, 2010 at 10:11 AM, Simon Schampijer si...@schampijer.de wrote: Hi, === Background === in Fedora the QA team is trying to keep the quality high by having different states of update packages intended for a maintained release of Fedora. The updates-testing repository, contains updates scheduled to be released for the maintained releases of Fedora. User testing and feedback provided via Bodhi, on the test mailing list and the relevant Bugzilla is vital to ensure that good updates are released quickly and bad ones kept away from release. Feedback from proven testers [1] is required for critical path package updates. === Task === The Geode video driver in Fedora (XO-1) [2] is one of those critical path packages. As you see from the link, it already has positive feedback, so it needs the '+1' from a proven packager in order to get into the stable repository. If you are interested in helping out with this specific issue and maybe are interested in later testing other olpc/sugar related packages in Fedora that would be great. In case you don't know yet, there are some interesting discussions going on about incorporating Sugar and SoaS testing into the QA process [3]. I've getting a segfault in X on my Fit-PC. I'll do some more testing this afternoon on both that and an XO-1 Peter ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Keep aspect has been added in the Paint pot files (SL 2321)
This ticket was an error from my part. Closed Gonzalo On Tue, Oct 12, 2010 at 3:05 PM, SHACHI PAUL sha...@seeta.in wrote: The Keep aspect has now been added to the Paint pot files. Signed-off-by: SHACHI PAUL sha...@seeta.in --- po/Paint.pot |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/po/Paint.pot b/po/Paint.pot index 6bbc6b4..0ef3c2c 100644 --- a/po/Paint.pot +++ b/po/Paint.pot @@ -116,6 +116,10 @@ msgstr msgid Fill Color: msgstr +#: toolbox.py:531 +msgid Keep aspect +msgstr + #: toolbox.py:740 msgid Fill Color msgstr -- 1.7.0.4 -- Gonzalo Odiard ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH v5 sugar] Pulsing icon delayed by 5 seconds or so SL#2080
On 13 October 2010 16:28, Anurag Chowdhury anu...@seeta.in wrote: When we click on the icon of an activity we see a pulsing icon of that activity before the activity starts and usually there is a time delay between the clicking of the icon and appearance of the pulsing icon , where tha amount of delay differs by the complexity of the icon i.e. more complex the icon is larger is the delay. So In order to minimise the delay we replaced the animation with its raw svg image for the first frame of rendering Interesting idea. However, I'm not convinced that rendering a raw svg versus rendering a svg with a simple stroke/fill applied is going to result in much difference. I'm happy to be proven wrong - perhaps you could take an activity as an example and measure exactly how long the first self.update() call takes to complete? If you aren't already, it would be a good idea to use a profiler to identify with clarity the exact part of the code that is taking the most time. Thanks, Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] New upstream releases of telepathy-salut and telepathy-gabble
On 10/13/2010 01:40 PM, Peter Robinson wrote: These are in updates-testing but need some more karma ;-) Peter Awesome - Thanks to Brian! (if he can hear us :) /me did his verification testing as well. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH] Downgrading activities not allowed. (#2164)
Downgrading an activity is now made possible. When a .xo file of a version
older than the currently installed version is clicked, a downgrading option is
made available, by popping up of a confirmation alert. Depending upton the
choice selected you can downgrade the activity.
v1 - v2. Named according to the nomenclature suggested,inline function
used,signal emission condition revised,global variables removed.
Signed-off-by: Shanjit Singh Jajmann shan...@seeta.in, Anubhav Aggarwal
anub...@seeta.in
---
src/jarabe/journal/journalactivity.py | 15 +++
src/jarabe/journal/listview.py| 22 ++
src/jarabe/journal/misc.py|8 +---
src/jarabe/model/bundleregistry.py| 11 ++-
4 files changed, 44 insertions(+), 12 deletions(-)
diff --git a/src/jarabe/journal/journalactivity.py
b/src/jarabe/journal/journalactivity.py
index 44cc018..d0af20a 100644
--- a/src/jarabe/journal/journalactivity.py
+++ b/src/jarabe/journal/journalactivity.py
@@ -28,6 +28,7 @@ import os
from sugar.graphics.window import Window
from sugar.graphics.alert import ErrorAlert
+from sugar.graphics.alert import ConfirmationAlert
from sugar.bundle.bundle import ZipExtractException, RegistrationException
from sugar import env
@@ -166,6 +167,7 @@ class JournalActivity(Window):
self._list_view = ListView()
self._list_view.connect('detail-clicked', self.__detail_clicked_cb)
self._list_view.connect('clear-clicked', self.__clear_clicked_cb)
+self._list_view.connect('older-version-clicked',
self.__older_version_clicked_cb)
self._main_view.pack_start(self._list_view)
self._list_view.show()
@@ -204,6 +206,19 @@ class JournalActivity(Window):
def __go_back_clicked_cb(self, detail_view):
self.show_main_view()
+def __older_version_clicked_cb(self,a):
+alert1=ConfirmationAlert()
+alert1.props.title = _('Newer Version Found')
+alert1.props.msg = _('Newer version of the chosen activity is
available do you still want to continue with the installation?
If Yes click Ok and
the activity icon of the older .xo file in the Journal')
+alert1.connect('response',self.__downgrade_alert_response_cb)
+self.add_alert(alert1)
+alert1.show()
+def __downgrade_alert_response_cb(self, alert1, response_id):
+if response_id is gtk.RESPONSE_OK:
+self.remove_alert(alert1)
+self._list_view.downgrade_confirmation()
+elif response_id is gtk.RESPONSE_CANCEL:
+self.remove_alert(alert1)
def _query_changed_cb(self, toolbar, query):
self._list_view.update_with_query(query)
diff --git a/src/jarabe/journal/listview.py b/src/jarabe/journal/listview.py
index 3d6281a..653f400 100644
--- a/src/jarabe/journal/listview.py
+++ b/src/jarabe/journal/listview.py
@@ -27,6 +27,7 @@ import pango
from sugar.graphics import style
from sugar.graphics.icon import CanvasIcon, Icon, CellRendererIcon
from sugar.graphics.xocolor import XoColor
+from sugar.bundle.bundle import AlreadyInstalledException
from sugar import util
from jarabe.journal.listmodel import ListModel
@@ -466,12 +467,17 @@ class ListView(BaseListView):
__gsignals__ = {
'detail-clicked': (gobject.SIGNAL_RUN_FIRST,
gobject.TYPE_NONE,
- ([object]))
+ ([object])),
+'older-version-clicked': (gobject.SIGNAL_RUN_FIRST,
+ gobject.TYPE_NONE,
+ ([]))
}
+
def __init__(self):
BaseListView.__init__(self)
self._is_dragging = False
+self.downgrade = False
self.tree_view.connect('drag-begin', self.__drag_begin_cb)
self.tree_view.connect('button-release-event',
@@ -522,12 +528,20 @@ class ListView(BaseListView):
def __detail_clicked_cb(self, cell, uid):
self.emit('detail-clicked', uid)
-
+def downgrade_confirmation(self):
+self.downgrade = True
def __icon_clicked_cb(self, cell, path):
row = self.tree_view.get_model()[path]
metadata = model.get(row[ListModel.COLUMN_UID])
-misc.resume(metadata)
-
+if not self.downgrade:
+try:
+misc.resume(metadata)
+except AlreadyInstalledException :
+self.emit('older-version-clicked')
+if self.downgrade:
+self.downgrade = False
+misc.resume(metadata,forcing_downgrade=True)
+
def __cell_title_edited_cb(self, cell, path, new_text):
row = self._model[path]
metadata = model.get(row[ListModel.COLUMN_UID])
diff --git a/src/jarabe/journal/misc.py b/src/jarabe/journal/misc.py
index 32a2847..0ae4a1d 100644
--- a/src/jarabe/journal/misc.py
+++ b/src/jarabe/journal/misc.py
@@
Re: [Sugar-devel] New upstream releases of telepathy-salut and telepathy-gabble
http://bugs.sugarlabs.org/ticket/2395#comment:7 Avitars start as x$jabber, form. If you use CP/Mysettings/about me to change color and restart (with keychain password you entered on startup) names are displayd correctly. * Is the first display of F1 Neighborhood occurring before the jabber has responded completely? note that users XO Avitar is displayed twice on first (before restart) screen in same colors and name. one off to the side in f1 field where all others are xx...@jabber format This also occurs in f14-TC1.1 netinstall to HD (done today 5 AM PST) with customize now sugar-desktop installed uses updates-testing repo Tom Gilliard satellit Simon Schampijer wrote: On 10/13/2010 01:40 PM, Peter Robinson wrote: These are in updates-testing but need some more karma ;-) Peter Awesome - Thanks to Brian! (if he can hear us :) /me did his verification testing as well. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] New upstream releases of telepathy-salut and telepathy-gabble
http://bugs.sugarlabs.org/ticket/2395#comment:7 Avitars start as x$jabber, form. If you use CP/Mysettings/about me to change color and restart (with keychain password you entered on startup) names are displayd correctly. * Is the first display of F1 Neighborhood occurring before the jabber has responded completely? note that users XO Avitar is displayed twice on first (before restart) screen in same colors and name. one off to the side in f1 field where all others are xx...@jabber format This also occurs in f14-TC1.1 netinstall to HD (done today 5 AM PST) with customize now sugar-desktop installed uses updates-testing repo Tom Gilliard satellit Simon Schampijer wrote: On 10/13/2010 01:40 PM, Peter Robinson wrote: These are in updates-testing but need some more karma ;-) Peter Awesome - Thanks to Brian! (if he can hear us :) /me did his verification testing as well. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Weekly test request reminders? (was Re: Priorities for testing)
On 09/29/2010 08:47 PM, Tom Parker wrote: On Wed, 2010-09-29 at 14:30 +0200, Simon Schampijer wrote: that would be excellent indeed. We especially need help with 0.90 testing. What hardware and software setup are you using for testing? XOs? Soas? In Auckland we have quite a lot of XO-1s (mostly CL1 models) and a few XO-1.5s (mostly prototypes with the wireless powersaving hardware fault). We have virtualbox and regular laptop hardware, but I don't think we have anything on which wireless works with soas. We also have a schoolserver and good internet connectivity. Wellington has a similar number of XOs, but I'll let Tim describe their soas, virtualbox and other resources. See http://wiki.laptop.org/go/OLPC_New_Zealand Personally, I find XO, SoaS and VirtualBox images easiest to test, we download the night before and re-image our XOs or make new SoaS. For example there is a Sugar 0.90 release email on this list today and I have no idea what I'd do with the source. Hi Tom, the announcements do tell people that the sources are available. Then it has to be packaged by distributions (Fedora, Debian, Ubuntu etc...). From there Spins like Soas or the XO picks them up [1]. I am doing XO builds containing the latest Sugar (0.90) for the XO [2]. So given from your information, that should be a good way for you to test 0.90. I will do a new build by the end of the week. Watch out for the announcement. Thanks, Simon [1] http://wiki.sugarlabs.org/go/0.90/Notes#Update_to_this_version [2] http://lists.sugarlabs.org/archive/sugar-devel/2010-October/027456.html ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Downgrading activities not allowed. (#2164)
On Wed, Oct 13, 2010 at 07:28:51PM +0530, shan...@seeta.in wrote:
Downgrading an activity is now made possible. When a .xo file of a version
older than the currently installed version is clicked, a downgrading option
is made available, by popping up of a confirmation alert. Depending upton the
choice selected you can downgrade the activity.
v1 - v2. Named according to the nomenclature suggested,inline function
used,signal emission condition revised,global variables removed.
As I was talking while IRC discussion, I don't think that processing
downgrade hook in every misc.resume invocation place (you missed
misc.resume call in expandedentry.py, journaltoolbox.py and
palettes.py) is useful, more apriproate is keeping it in one place
(whatevery it will be).
Signed-off-by: Shanjit Singh Jajmann shan...@seeta.in, Anubhav Aggarwal
anub...@seeta.in
---
src/jarabe/journal/journalactivity.py | 15 +++
src/jarabe/journal/listview.py| 22 ++
src/jarabe/journal/misc.py|8 +---
src/jarabe/model/bundleregistry.py| 11 ++-
4 files changed, 44 insertions(+), 12 deletions(-)
diff --git a/src/jarabe/journal/journalactivity.py
b/src/jarabe/journal/journalactivity.py
index 44cc018..d0af20a 100644
--- a/src/jarabe/journal/journalactivity.py
+++ b/src/jarabe/journal/journalactivity.py
@@ -28,6 +28,7 @@ import os
from sugar.graphics.window import Window
from sugar.graphics.alert import ErrorAlert
+from sugar.graphics.alert import ConfirmationAlert
from sugar.bundle.bundle import ZipExtractException, RegistrationException
from sugar import env
@@ -166,6 +167,7 @@ class JournalActivity(Window):
self._list_view = ListView()
self._list_view.connect('detail-clicked', self.__detail_clicked_cb)
self._list_view.connect('clear-clicked', self.__clear_clicked_cb)
+self._list_view.connect('older-version-clicked',
self.__older_version_clicked_cb)
self._main_view.pack_start(self._list_view)
self._list_view.show()
@@ -204,6 +206,19 @@ class JournalActivity(Window):
def __go_back_clicked_cb(self, detail_view):
self.show_main_view()
+def __older_version_clicked_cb(self,a):
+alert1=ConfirmationAlert()
+alert1.props.title = _('Newer Version Found')
+alert1.props.msg = _('Newer version of the chosen activity is
available do you still want to continue with the installation?
If Yes click Ok
and the activity icon of the older .xo file in the Journal')
+alert1.connect('response',self.__downgrade_alert_response_cb)
+self.add_alert(alert1)
+alert1.show()
+def __downgrade_alert_response_cb(self, alert1, response_id):
+if response_id is gtk.RESPONSE_OK:
+self.remove_alert(alert1)
+self._list_view.downgrade_confirmation()
+elif response_id is gtk.RESPONSE_CANCEL:
+self.remove_alert(alert1)
def _query_changed_cb(self, toolbar, query):
self._list_view.update_with_query(query)
diff --git a/src/jarabe/journal/listview.py b/src/jarabe/journal/listview.py
index 3d6281a..653f400 100644
--- a/src/jarabe/journal/listview.py
+++ b/src/jarabe/journal/listview.py
@@ -27,6 +27,7 @@ import pango
from sugar.graphics import style
from sugar.graphics.icon import CanvasIcon, Icon, CellRendererIcon
from sugar.graphics.xocolor import XoColor
+from sugar.bundle.bundle import AlreadyInstalledException
from sugar import util
from jarabe.journal.listmodel import ListModel
@@ -466,12 +467,17 @@ class ListView(BaseListView):
__gsignals__ = {
'detail-clicked': (gobject.SIGNAL_RUN_FIRST,
gobject.TYPE_NONE,
- ([object]))
+ ([object])),
+'older-version-clicked': (gobject.SIGNAL_RUN_FIRST,
+ gobject.TYPE_NONE,
+ ([]))
}
+
def __init__(self):
BaseListView.__init__(self)
self._is_dragging = False
+self.downgrade = False
self.tree_view.connect('drag-begin', self.__drag_begin_cb)
self.tree_view.connect('button-release-event',
@@ -522,12 +528,20 @@ class ListView(BaseListView):
def __detail_clicked_cb(self, cell, uid):
self.emit('detail-clicked', uid)
-
+def downgrade_confirmation(self):
+self.downgrade = True
def __icon_clicked_cb(self, cell, path):
row = self.tree_view.get_model()[path]
metadata = model.get(row[ListModel.COLUMN_UID])
-misc.resume(metadata)
-
+if not self.downgrade:
+try:
+misc.resume(metadata)
+except AlreadyInstalledException :
+
Re: [Sugar-devel] [DESIGN] Read: focus after launching
On 13 October 2010 11:45, Simon Schampijer si...@schampijer.de wrote: Hi, when working on the issue in Read that the dpad keys do not work directly when in ebook mode [1], I postulated that Read when it comes up should always grab the focus on the view so scrolling using the arrow keys is directly possible. Agreed. Activities should set a sensible focus on launch. For example Write focuses the text input area. Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Marketing] A little change to www.sugarlabs.org
/Simon Schampijer wrote: Can someone that has access please just make this change. --/ In Uruguay the new XO 1.5 (high schools) comes with the new Browse activity, that have tabs. But in the schools they still have the XO 1 (sugar 0.82 and browse 101) with no tabs Paolo Benini MOntevideo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Marketing] A little change to www.sugarlabs.org
On Wed, Oct 13, 2010 at 11:24 AM, nanon...@mediagala.com wrote: Simon Schampijer wrote: Can someone that has access please just make this change. -- In Uruguay the new XO 1.5 (high schools) comes with the new Browse activity, that have tabs. But in the schools they still have the XO 1 (sugar 0.82 and browse 101) with no tabs It is not the hardware, it is the version of Sugar/Browse. Once the machines are upgraded to Sugar 0.88, which I believe is the plan of record, the situation will be resolved for the XO 1, but meanwhile, we should change the behavior of www.sl.o. Who has access to these files? -walter Paolo Benini MOntevideo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel -- Walter Bender Sugar Labs http://www.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] Dbus signal when ebook switch is activated
I am trying to catch a event when the ebook switch in a XO-1.5 is activated
and read the switch state.
Using dbus-monitor I have found the signal emited, but the message does not
inform the switch state. It 's odd because send a array of booleans values,
but are always in False.
The signal is emited when the ebook switch or the lid switch are activated.
Simple test code:
[o...@xo-a7-2b-49 ~]$ cat test-dbus.py
#!/usr/bin/env python
#def my_func(account, sender, message, conversation, flags):
def my_func(sender, message):
print sender, said:, message
import dbus, gobject
from dbus.mainloop.glib import DBusGMainLoop
dbus.mainloop.glib.DBusGMainLoop(set_as_default=True)
bus = dbus.SystemBus()
bus.add_signal_receiver(my_func,
dbus_interface=org.freedesktop.Hal.Device,
signal_name=PropertyModified)
loop = gobject.MainLoop()
loop.run()
I see this when activate the switchs:
[o...@xo-a7-2b-49 ~]$ python test-dbus.py
1 said: dbus.Array([dbus.Struct((dbus.String(u'button.state.value'),
dbus.Boolean(False), dbus.Boolean(False)), signature=None)],
signature=dbus.Signature('(sbb)'))
I know I can read the switch state from
/proc/acpi/olpc-switch/ebook/EBK/state and /proc/acpi/button/lid/LID/state
The question is: the dbus message must send the state? i am doing anything
wrong?
Finally, there are a similar procedure to the XO-1?
I am doing all this to http://dev.laptop.org/ticket/10396
Thanks
Gonzalo
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH v5 sugar] Pulsing icon delayed by 5 seconds or so SL#2080
Daniel, Thank you for reviewing the patch. Appreciate it. Wish to inform you that I did try the profiler, and displayed the time slice intervals between rendering of consecutive frames. I did find significant change in the rendering time of first frame. Raw svg icon with colour is timely filled using a sine function, which control its timing, and is updated on every frame of animation. Since, we have a 400 Mhz capacity processor in an XO-1, this has considerable processing lead times associated for completion of the rendering job. My earlier idea of frame dropping is a technique, which can smoothen an already started animation, but does not speed up the start-up. Regards, Anurag ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [ASLO] Release Physics-6
Activity Homepage: http://activities.sugarlabs.org/addon/4193 Sugar Platform: 0.82 - 0.90 Download Now: http://activities.sugarlabs.org/downloads/file/27066/physics-6.xo Release notes: - Physics now idles when in the background to free up the cpu and save power. - Saves thumbnail image of simulation for details view in Journal. - Better behaviour when attempting to create minimum sized triangles, boxes, and circles (SL#1249). - Fixed new toolbars expanding separator from overflowing the Stop icons off the XO toolbar - Fixed the python/gtk/pygame int/float bug affecting F14 based builds (SL#2363). - Includes latest translations. - Switch activity.info from using the depreciated class, to exec. - Source code clean-up. Sugar Labs Activities http://activities.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [RELEASE] Turtle Blocks 100
Nothing as dramatic as v100 would suggest. Just a collection of bug fixes. == Source == http://download.sugarlabs.org/sources/sucrose/fructose/TurtleArt/TurtleArt-100.tar.bz2 == News == * fixed problem with turtle reskin when scale = 1 (#2353) * fixed problems with keyboard commands (#2426) * documented keyboard shortcuts (Thanks to Tony Forster) See http://wiki.sugarlabs.org/go/Activities/TurtleArt#Keyboard_shortcuts * view source shows project code instead of Logo code (#2204) * project code has improved formatting for readability (#2204) * chooser limits choices appropriately, e.g., when looking for Python code, it only shows you .py files. * fixed math Name error problem with imported Python code (#2313) -walter -- Walter Bender Sugar Labs http://www.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Add 'transient' property to Invoker #1742
On 10/11/2010 11:34 AM, Tomeu Vizoso wrote:
Meaning that the palette will be disposed when it pops down.
---
src/sugar/graphics/palette.py |1 +
src/sugar/graphics/palettewindow.py | 20 +---
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/src/sugar/graphics/palette.py b/src/sugar/graphics/palette.py
index d4632eb..d4f844c 100644
--- a/src/sugar/graphics/palette.py
+++ b/src/sugar/graphics/palette.py
@@ -158,6 +158,7 @@ class Palette(PaletteWindow):
self.popdown(immediate=True)
# Break the reference cycle. It looks like the gc is not able to free
# it, possibly because gtk.Menu memory handling is very special.
+self.menu.disconnect_by_func(self.__menu_item_inserted_cb)
self.menu = None
def __show_cb(self, widget):
diff --git a/src/sugar/graphics/palettewindow.py
b/src/sugar/graphics/palettewindow.py
index 22131c2..3c74662 100644
--- a/src/sugar/graphics/palettewindow.py
+++ b/src/sugar/graphics/palettewindow.py
@@ -179,6 +179,7 @@ class PaletteWindow(gtk.Window):
def __destroy_cb(self, palette):
self.set_group_id(None)
+self._mouse_detector.disconnect_by_func(self._mouse_slow_cb)
def set_invoker(self, invoker):
for hid in self._invoker_hids[:]:
@@ -457,6 +458,7 @@ class Invoker(gobject.GObject):
self._cursor_x = -1
self._cursor_y = -1
self._palette = None
+self._transient = False
def attach(self, parent):
self.parent = parent
@@ -639,18 +641,30 @@ class Invoker(gobject.GObject):
def set_palette(self, palette):
if self._palette is not None:
self._palette.popdown(immediate=True)
-
-if self._palette:
self._palette.props.invoker = None
+self._palette.destroy()
self._palette = palette
-if self._palette:
+if self._palette is not None:
self._palette.props.invoker = self
+self._palette.connect('popdown', self.__palette_popdown_cb)
palette = gobject.property(
type=object, setter=set_palette, getter=get_palette)
+def get_transient(self):
+return self._transient
+
+def set_transient(self, transient):
+self._transient = transient
+
+transient = gobject.property(type=object, setter=set_transient,
+ getter=get_transient)
+
+def __palette_popdown_cb(self, palette):
+if self.props.transient:
+self.set_palette(None)
class WidgetInvoker(Invoker):
Hi Tomeu,
thanks for that patch!
As already discussed on IRC naming the attribute to 'cache_palette'
would probably be more descriptive. As well like Sascha suggested it
would be good to add a docstring for it.
As you said already for future work it would be good to do the
following: Palettes very expensive to create or that the user may be
staring at, we should update dynamically but others should be just
disposed when popped down, as we do in your patch.
Another occurrence of the issue we are seeing here is the Journal entry
palette. Example:
- I want to share an entry and open the palette
- Oh, no buddy there to share with, forgot to add him as a friend.
- doing that in the neighborhood view
- going back and trying again, still not there for that entry other
entries do contain the buddy.
In short, we should identify the other occurrences and try to fix them
as well.
Regards,
Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Make sure the buddy palette is disposed after popdown #1742
On 10/11/2010 11:35 AM, Tomeu Vizoso wrote:
---
src/jarabe/view/buddyicon.py |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/jarabe/view/buddyicon.py b/src/jarabe/view/buddyicon.py
index 37b9167..15385bd 100644
--- a/src/jarabe/view/buddyicon.py
+++ b/src/jarabe/view/buddyicon.py
@@ -28,6 +28,8 @@ class BuddyIcon(CanvasIcon):
self._buddy.connect('notify::present', self.__buddy_notify_present_cb)
self._buddy.connect('notify::color', self.__buddy_notify_color_cb)
+self.palette_invoker.transient = True
+
self._update_color()
def create_palette(self):
This does set it to transient for all the buddies palletes, as well the
one from the owner. As the owner palette has no dynamic content I guess
we don't need to.
Regards,
Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] Great Response was Re: [PATCH sugar] Removed hardcoded server url (SL #1976)
On Wed, Oct 13, 2010 at 6:01 AM, Dipankar Patro dipan...@seeta.in wrote:
Thanks for reviewing it, James.
if have_ofw_tree():
sn = read_ofw('mfg-data/SN')
uuid_ = read_ofw('mfg-data/U#')
sn = sn or 'SHF'
uuid_ = uuid_ or '----'
else:
sn = generate_serial_number()
uuid_ = str(uuid.uuid1())
- setting_name = '/desktop/sugar/collaboration/jabber_server'
- jabber_server = client.get_string(setting_name)
- store_identifiers(sn, uuid_, jabber_server)
+
+ setting_name = '/desktop/sugar/collaboration/jabber_server'
+ jabber_server = client.get_string(setting_name)
+ store_identifiers(sn, uuid_, jabber_server)
+
+ if jabber_server:
url = 'http://' + jabber_server + ':8080/'
You are effectively repeating the previous if statement but using the
output ... seems a bit obscure.
^^ Before applying this : The url (url for registration) was set from gconf
only for non-XO devices.
I moved that outside the first if..else you have quoted, so that on all
devices the url is taken from the gconf property
(/desktop/sugar/collaboration/jabber_server)
the second 'if jabber_server:' is put there to check whether the
jabber_server retrieved from the gcnof property is empty or unset. If
jabber_server is a valid one, then change url, other wise keep the url =
initialized one.
I actually went with the above modification due to the chain of mails here :
http://lists.sugarlabs.org/archive/sugar-devel/2010-July/025265.html
Regards,
Dipankar
Great response! You clearly explained what you did, _why_ you did it,
and how you came to that decision.
Now a reviewer can effectively make a decision of 'that makes sense,
ACK' or 'what if you look at it this way?'
david
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCHv2] Title for 'Rectangualar Marquee' tool changed to 'Select Area'
The select tool is less than optimally discoverable in English because
of the name 'Rectangular Marquee'. The name is changed to 'Select
Area'.
Signed-off-by: Ayush Goyal ay...@seeta.in
---
toolbox.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/toolbox.py b/toolbox.py
index 90f664d..299181b 100644
--- a/toolbox.py
+++ b/toolbox.py
@@ -434,7 +434,7 @@ class ToolsToolbar(gtk.Toolbar):
-self._tool_marquee_rectangular =
DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Rectangular
Marquee'))
+self._tool_marquee_rectangular =
DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Select Area'))
self.insert(self._tool_marquee_rectangular, -1)
try:
self._configure_palette(self._tool_marquee_rectangular,
self._TOOL_MARQUEE_RECTANGULAR)
--
1.7.1
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Dextrose] [PATCH v5 sugar] Pulsing icon delayed by 5 seconds or so SL#2080
On Wed, Oct 13, 2010 at 10:29 AM, Anurag Chowdhury anu...@seeta.in wrote: Daniel, Thank you for reviewing the patch. Appreciate it. Wish to inform you that I did try the profiler, and displayed the time slice intervals between rendering of consecutive frames. I did find significant change in the rendering time of first frame. Raw svg icon with colour is timely filled using a sine function, which control its timing, and is updated on every frame of animation. Since, we have a 400 Mhz capacity processor in an XO-1, this has considerable processing lead times associated for completion of the rendering job. My earlier idea of frame dropping is a technique, which can smoothen an already started animation, but does not speed up the start-up. Regards, Anurag Anurag, Based on your background as a game designer you probobly has as much back ground on this particular issue as any one else. Can you create a timer, output the activity start time to the log and report your results back to this list? david ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] Students looking to contribute
Hello, We are 4 students looking to contribute, this semester, for class credit. We are all senior Computer Science majors at Worcester State College and are eager to get started. We have been researching the Wiki and Python for the past couple of weeks and feel that our time might be best spent contributing to bug fixes on the Activities. So if anyone has or knows of any bugs we can work on, please let us know. Or could some one point us in the right direction so we can get coding. Thanks for any help, ~Lindsey L. Jon B. Lee P. George A. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Students looking to contribute
On Wed, Oct 13, 2010 at 12:43 PM, WSU CS401 wsu.cs...@gmail.com wrote: Hello, We are 4 students looking to contribute, this semester, for class credit. We are all senior Computer Science majors at Worcester State College and are eager to get started. We have been researching the Wiki and Python for the past couple of weeks and feel that our time might be best spent contributing to bug fixes on the Activities. So if anyone has or knows of any bugs we can work on, please let us know. Or could some one point us in the right direction so we can get coding. Nice to meet you! Can you tell us a bit more about your background and experience with python, linux, and system programing so we can find appropriate bugs for you? ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Students looking to contribute
On Wed, Oct 13, 2010 at 1:43 PM, WSU CS401 wsu.cs...@gmail.com wrote: Hello, We are 4 students looking to contribute, this semester, for class credit. We are all senior Computer Science majors at Worcester State College and are eager to get started. We have been researching the Wiki and Python for the past couple of weeks and feel that our time might be best spent contributing to bug fixes on the Activities. So if anyone has or knows of any bugs we can work on, please let us know. Or could some one point us in the right direction so we can get coding. Thanks for any help, ~Lindsey L. Jon B. Lee P. George A. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel We maintain a list of bugs know as 'sugar-love' which tend to be introductory in nature. But the best thing to do would be to find an activity you enjoy and contact the maintainer for suggestions. (For example, Im the maintainer of Measure, Turtle Art, Visual Match, Abacus, SlideRule, et al. and I have a long backlog of things I'd like to work on.) -walter -- Walter Bender Sugar Labs http://www.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Students looking to contribute
If you're going to work on Activities you will want to check out Make Your Own Sugar Activities!: http://en.flossmanuals.net/ActivitiesGuideSugar/Introduction You can also download a PDF to read offline from the Internet Archive: http://www.archive.org/details/MakeYourOwnSugarActivities Good luck with your project. James Simmons Date: Wed, 13 Oct 2010 13:43:56 -0400 From: WSU CS401 wsu.cs...@gmail.com To: sugar-devel@lists.sugarlabs.org Subject: [Sugar-devel] Students looking to contribute Message-ID: aanlktik69n3jrhd7j01b_sd3z3cmprhohadov18b6...@mail.gmail.com Content-Type: text/plain; charset=iso-8859-1 Hello, We are 4 students looking to contribute, this semester, for class credit. We are all senior Computer Science majors at Worcester State College and are eager to get started. We have been researching the Wiki and Python for the past couple of weeks and feel that our time might be best spent contributing to bug fixes on the Activities. So if anyone has or knows of any bugs we can work on, please let us know. Or could some one point us in the right direction so we can get coding. Thanks for any help, ~Lindsey L. Jon B. Lee P. George A. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL Bug #2063
Team,
Wish to have your feedback on the design aspect of the ticket 2063 (Sugar
should bring up an alert when an unhandled Python exception occurs) - please
find the git diff attached below. This is an attempt to display an alert
when an unhandled Python exception occurs in the journal. Unfortunately,
when the exception takes place in journalactivity.py , I am neither unable
to notice the Journal Icon (it disappears),
diff --git a/journalactivity.py b/journalactivity.py
index 44cc018..36a2e2e 100644
--- a/journalactivity.py
+++ b/journalactivity.py
@@ -358,8 +358,20 @@ class JournalActivity(Window):
self.show_main_view()
self.search_grab_focus()
+def uncaught_exception_alert(self):
+alert = ErrorAlert(title=Operation could not be performed,
msg=Please check the logviewer activity for details )
+alert.connect('response', self.__alert_response_cb)
+self.add_alert(alert)
+alert.show()
+
_journal = None
+def _alert_excepthook(exc_type, exc_value, traceback):
+logging.exception('Unhandled Python exception: %s', repr((exc_type,
exc_value, traceback)))
+_journal.uncaught_exception_alert()
+
+sys.excepthook = _alert_excepthook
+
def get_journal():
global _journal
if _journal is None:
--
1.7.0.4
I wish to request you to please review the code and suggest desired changes,
if any.
Moreover, I have two important questions regarding the bug.
1. To catch all unhandled python exceptions in sugar, where exactly should
we be looking forward to be the venue for adding the functionality?
Adding it in journalactivity.py doesn't seem to serve all purposes. It
has to be added somewhere which is being used all the time.
2. Wish if you could recommend on the GUI feature that could be used for
displaying the alert message to the user.
Looking forward to for your valuable suggestions,
Regards,
Mukul Gupta
Research Engineer,SEETA
On Tue, Oct 12, 2010 at 12:46 AM, Mukul Gupta mu...@seeta.in wrote:
Team,
I had a discussion with Aleksey this morning at IRC on the feedback
recommended yesterday. Thank you Daniel and Tomeu. Appreciate your ideas and
pointers.
We brainstormed on how the implementation of this functionality could be
done, and found that whenever any uncaught exception is raised, the
interpreter calls the sys.excepthook(type,value,traceback).
Wish to have the feedback on whether excepthook implementation would be
helpful to our use-case both short-term and long-term. Also, it would be
wonderful if feedback could be shared on its implementation in the context
of Sugar, or otherwise.
Looking forward to hearing from you.
Regards,
Mukul Gupta
On Mon, Oct 11, 2010 at 2:14 PM, Manusheel Gupta m...@seeta.in wrote:
Tomeu and Daniel,
On Mon, Oct 11, 2010 at 1:50 PM, Tomeu Vizoso to...@sugarlabs.orgwrote:
On Mon, Oct 11, 2010 at 09:57, Daniel Drake d...@laptop.org wrote:
On 10 October 2010 20:14, Mukul Gupta mu...@seeta.in wrote:
With reference to SL Bug # 2063 which deals with bringing some kind of
notification alert whenever an unhandled python exception occurs, I
had a
few doubts. There are two approaches that I can think of.
Neither of these sounds sensible.
What's wrong with the obvious solution of popping up a dialog when the
exception occurs?
Technically the exceptions are not unhandled, if they were unhandled
then sugar would crash. I guess we're referring to exceptions that are
not handled gracefully and instead fall back to a catch-all handler
which does not have the knowledge to act on them.
This is what abrt does with python (and other) processes, maybe we
could reuse it or at least steal some of the ideas:
https://fedorahosted.org/abrt/
Thank you for the feedback and pointers. Appreciate it.
We'll discuss the approach shared by you this afternoon.
Regards,
Manu
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL Bug #2063
On Wed, Oct 13, 2010 at 2:50 PM, Mukul Gupta mu...@seeta.in wrote:
Team,
Wish to have your feedback on the design aspect of the ticket 2063 (Sugar
should bring up an alert when an unhandled Python exception occurs) - please
find the git diff attached below. This is an attempt to display an alert
when an unhandled Python exception occurs in the journal. Unfortunately,
when the exception takes place in journalactivity.py , I am neither unable
to notice the Journal Icon (it disappears),
diff --git a/journalactivity.py b/journalactivity.py
index 44cc018..36a2e2e 100644
--- a/journalactivity.py
+++ b/journalactivity.py
@@ -358,8 +358,20 @@ class JournalActivity(Window):
self.show_main_view()
self.search_grab_focus()
+ def uncaught_exception_alert(self):
+ alert = ErrorAlert(title=Operation could not be performed,
msg=Please check the logviewer activity for details )
+ alert.connect('response', self.__alert_response_cb)
+ self.add_alert(alert)
+ alert.show()
+
_journal = None
+def _alert_excepthook(exc_type, exc_value, traceback):
+ logging.exception('Unhandled Python exception: %s', repr((exc_type,
exc_value, traceback)))
+ _journal.uncaught_exception_alert()
+
+sys.excepthook = _alert_excepthook
+
def get_journal():
global _journal
if _journal is None:
--
1.7.0.4
I wish to request you to please review the code and suggest desired changes,
if any.
Moreover, I have two important questions regarding the bug.
1. To catch all unhandled python exceptions in sugar, where exactly should
we be looking forward to be the venue for adding the functionality?
Adding it in journalactivity.py doesn't seem to serve all purposes. It
has to be added somewhere which is being used all the time.
2. Wish if you could recommend on the GUI feature that could be used for
displaying the alert message to the user.
Looking forward to for your valuable suggestions,
Regards,
Mukul Gupta
Mukual,
Well asked question.
1. You followed the 'show me the code' principle. That shows that you
have thought through the problem far enough for a draft
implementation.
2. You are asking for specif help on two specif areas. Based on the
draft code and specifc questions, it is easy for a reviewer to give
you the help.
david
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL Bug #2063
Please find my explanations on the code added as comments.
diff --git a/journalactivity.py b/journalactivity.py
index 44cc018..36a2e2e 100644
--- a/journalactivity.py
+++ b/journalactivity.py
@@ -358,8 +358,20 @@ class JournalActivity(Window):
self.show_main_view()
self.search_grab_focus()
''' Defining an Error Alert function in the Journal Activity Class which
displays the message as
Operation could not be performed
Please check the logviewer activity for details
and an OK button
'''
+def uncaught_exception_alert(self):
+alert = ErrorAlert(title=Operation could not be performed,
msg=Please check the logviewer activity for details )
+alert.connect('response', self.__alert_response_cb)
+self.add_alert(alert)
+alert.show()
+
_journal = None
'''
Defining a function which logs the unhandled exception as well as calls the
Error Alert in the Journal whenever any uncaught exception occurs
'''
+def _alert_excepthook(exc_type, exc_value, traceback):
+logging.exception('Unhandled Python exception: %s', repr((exc_type,
exc_value, traceback)))
+_journal.uncaught_exception_alert()
+
'''
When an exception is raised and uncaught, sys.excepthook is called with
three arguments, the exception class, exception instance, and a traceback
object.The function _alert_excepthook is called only when an unhandled
exception occurs.
'''
+sys.excepthook = _alert_excepthook
+
def get_journal():
global _journal
if _journal is None:
--
1.7.0.4
On Thu, Oct 14, 2010 at 1:33 AM, David Farning dfarn...@gmail.com wrote:
On Wed, Oct 13, 2010 at 2:50 PM, Mukul Gupta mu...@seeta.in wrote:
Team,
Wish to have your feedback on the design aspect of the ticket 2063 (Sugar
should bring up an alert when an unhandled Python exception occurs) -
please
find the git diff attached below. This is an attempt to display an alert
when an unhandled Python exception occurs in the journal. Unfortunately,
when the exception takes place in journalactivity.py , I am neither
unable
to notice the Journal Icon (it disappears),
diff --git a/journalactivity.py b/journalactivity.py
index 44cc018..36a2e2e 100644
--- a/journalactivity.py
+++ b/journalactivity.py
@@ -358,8 +358,20 @@ class JournalActivity(Window):
self.show_main_view()
self.search_grab_focus()
+def uncaught_exception_alert(self):
+alert = ErrorAlert(title=Operation could not be performed,
msg=Please check the logviewer activity for details )
+alert.connect('response', self.__alert_response_cb)
+self.add_alert(alert)
+alert.show()
+
_journal = None
+def _alert_excepthook(exc_type, exc_value, traceback):
+logging.exception('Unhandled Python exception: %s', repr((exc_type,
exc_value, traceback)))
+_journal.uncaught_exception_alert()
+
+sys.excepthook = _alert_excepthook
+
def get_journal():
global _journal
if _journal is None:
--
1.7.0.4
I wish to request you to please review the code and suggest desired
changes,
if any.
Moreover, I have two important questions regarding the bug.
1. To catch all unhandled python exceptions in sugar, where exactly
should
we be looking forward to be the venue for adding the functionality?
Adding it in journalactivity.py doesn't seem to serve all purposes.
It
has to be added somewhere which is being used all the time.
2. Wish if you could recommend on the GUI feature that could be used for
displaying the alert message to the user.
Looking forward to for your valuable suggestions,
Regards,
Mukul Gupta
Mukual,
Well asked question.
1. You followed the 'show me the code' principle. That shows that you
have thought through the problem far enough for a draft
implementation.
2. You are asking for specif help on two specif areas. Based on the
draft code and specifc questions, it is easy for a reviewer to give
you the help.
david
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL Bug #2063
David,
Thank you. Appreciate your motivation and feedback.
Regards,
Mukul Gupta
On Thu, Oct 14, 2010 at 1:41 AM, Mukul Gupta mu...@seeta.in wrote:
Please find my explanations on the code added as comments.
diff --git a/journalactivity.py b/journalactivity.py
index 44cc018..36a2e2e 100644
--- a/journalactivity.py
+++ b/journalactivity.py
@@ -358,8 +358,20 @@ class JournalActivity(Window):
self.show_main_view()
self.search_grab_focus()
''' Defining an Error Alert function in the Journal Activity Class which
displays the message as
Operation could not be performed
Please check the logviewer activity for details
and an OK button
'''
+def uncaught_exception_alert(self):
+alert = ErrorAlert(title=Operation could not be performed,
msg=Please check the logviewer activity for details )
+alert.connect('response', self.__alert_response_cb)
+self.add_alert(alert)
+alert.show()
+
_journal = None
'''
Defining a function which logs the unhandled exception as well as calls the
Error Alert in the Journal whenever any uncaught exception occurs
'''
+def _alert_excepthook(exc_type, exc_value, traceback):
+logging.exception('Unhandled Python exception: %s', repr((exc_type,
exc_value, traceback)))
+_journal.uncaught_exception_alert()
+
'''
When an exception is raised and uncaught, sys.excepthook is called with
three arguments, the exception class, exception instance, and a traceback
object.The function _alert_excepthook is called only when an unhandled
exception occurs.
'''
+sys.excepthook = _alert_excepthook
+
def get_journal():
global _journal
if _journal is None:
--
1.7.0.4
On Thu, Oct 14, 2010 at 1:33 AM, David Farning dfarn...@gmail.com wrote:
On Wed, Oct 13, 2010 at 2:50 PM, Mukul Gupta mu...@seeta.in wrote:
Team,
Wish to have your feedback on the design aspect of the ticket 2063
(Sugar
should bring up an alert when an unhandled Python exception occurs) -
please
find the git diff attached below. This is an attempt to display an alert
when an unhandled Python exception occurs in the journal. Unfortunately,
when the exception takes place in journalactivity.py , I am neither
unable
to notice the Journal Icon (it disappears),
diff --git a/journalactivity.py b/journalactivity.py
index 44cc018..36a2e2e 100644
--- a/journalactivity.py
+++ b/journalactivity.py
@@ -358,8 +358,20 @@ class JournalActivity(Window):
self.show_main_view()
self.search_grab_focus()
+def uncaught_exception_alert(self):
+alert = ErrorAlert(title=Operation could not be performed,
msg=Please check the logviewer activity for details )
+alert.connect('response', self.__alert_response_cb)
+self.add_alert(alert)
+alert.show()
+
_journal = None
+def _alert_excepthook(exc_type, exc_value, traceback):
+logging.exception('Unhandled Python exception: %s', repr((exc_type,
exc_value, traceback)))
+_journal.uncaught_exception_alert()
+
+sys.excepthook = _alert_excepthook
+
def get_journal():
global _journal
if _journal is None:
--
1.7.0.4
I wish to request you to please review the code and suggest desired
changes,
if any.
Moreover, I have two important questions regarding the bug.
1. To catch all unhandled python exceptions in sugar, where exactly
should
we be looking forward to be the venue for adding the functionality?
Adding it in journalactivity.py doesn't seem to serve all purposes.
It
has to be added somewhere which is being used all the time.
2. Wish if you could recommend on the GUI feature that could be used for
displaying the alert message to the user.
Looking forward to for your valuable suggestions,
Regards,
Mukul Gupta
Mukual,
Well asked question.
1. You followed the 'show me the code' principle. That shows that you
have thought through the problem far enough for a draft
implementation.
2. You are asking for specif help on two specif areas. Based on the
draft code and specifc questions, it is easy for a reviewer to give
you the help.
david
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL Bug #2063
On 14 October 2010 08:50, Mukul Gupta mu...@seeta.in wrote:
Team,
Wish to have your feedback on the design aspect of the ticket 2063 (Sugar
should bring up an alert when an unhandled Python exception occurs) - please
find the git diff attached below. This is an attempt to display an alert
when an unhandled Python exception occurs in the journal. Unfortunately,
when the exception takes place in journalactivity.py , I am neither unable
to notice the Journal Icon (it disappears),
diff --git a/journalactivity.py b/journalactivity.py
index 44cc018..36a2e2e 100644
--- a/journalactivity.py
+++ b/journalactivity.py
@@ -358,8 +358,20 @@ class JournalActivity(Window):
self.show_main_view()
self.search_grab_focus()
+def uncaught_exception_alert(self):
+alert = ErrorAlert(title=Operation could not be performed,
msg=Please check the logviewer activity for details )
We can improve the helpfulness of this message. For example, we can tell
people which file to open in the log. I would like to give some recommended
steps to help get problems fixed, but I haven't included it here. Also, if
they don't have the log viewer activity, then they may feel helpless:
def uncaught_exception_alert(self):
from glob import glob
from os import system
logger = ... # should be easy to find
recentlog = glob({0}*.format(logger.filename))[-1]
last_log_line = system(tail -n 1 {0}.format(recentlog))
alert = ErrorAlert(title=_(Sorry, something went wrong),
msg = _(Please check the file {0} for details.\nThe last line of
that file is:\n{1}).format(
recentlog,
last_log_line))
...
I also don't like the function name uncaught_exception_alert. Functions
should generally begin with verbs. Perhaps handle_uncaught_exception?
_journal = None
+def _alert_excepthook(exc_type, exc_value, traceback):
+logging.exception('Unhandled Python exception: %s', repr((exc_type,
exc_value, traceback)))
+_journal.uncaught_exception_alert()
+
+sys.excepthook = _alert_excepthook
+
def get_journal():
global _journal
if _journal is None:
--
1.7.0.4
I wish to request you to please review the code and suggest desired
changes, if any.
Moreover, I have two important questions regarding the bug.
1. To catch all unhandled python exceptions in sugar, where exactly should
we be looking forward to be the venue for adding the functionality?
Adding it in journalactivity.py doesn't seem to serve all purposes. It
has to be added somewhere which is being used all the time.
2. Wish if you could recommend on the GUI feature that could be used for
displaying the alert message to the user.
Looking forward to for your valuable suggestions,
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [ASLO] Release Jukebox-20
Activity Homepage: http://activities.sugarlabs.org/addon/4045 Sugar Platform: 0.84 - 0.90 Download Now: http://activities.sugarlabs.org/downloads/file/27050/jukebox-20.xo Release notes: New translations updated in this release. Sugar Labs Activities http://activities.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)
On Wed, Oct 13, 2010 at 04:31:00PM +0530, Dipankar Patro wrote: Thanks for reviewing it, James. Sorry, it was late, and I misunderstood the code you had written ... I withdraw my comment You are effectively repeating the previous if statement but using the output ... seems a bit obscure. Apart from the lack of text wrap in the commit message, I've no issues with the patch. Reviewed-by: James Cameron qu...@laptop.org -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL Bug #2063
Hi Sorry if I do not fully understand this. The proposal is that an ErrorAlert will be created which must be dismissed by its OK button. Is there any possibility that a large number of errors can be created, each needing to be manually dismissed? We can improve the helpfulness of this message. For example, we can tell people which file to open in the log. I would like to give some recommended steps to help get problems fixed, but I haven't included it here. Also, if they don't have the log viewer activity, then they may feel helpless Option 1, example Operation could not be performed Please check the logviewer activity for details Option 2 example Sorry, something went wrong Please check the file shell.log for details. The last line of that file is: TypeError: integer expected got float It is very unlikely that primary school students will be able to make any sense of the log and not much better for secondary school students. Anybody who could interpret the log would probably know about the Log activity. So I wouldn't ask them with please check but rather offer it as a possibility. My suggested rewording: Sorry, something went wrong. For more information, use the Log Activity to view the file shell.log. The last line of that file is: TypeError: integer expected got float ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [ASLO] Release Physics-7
Activity Homepage: http://activities.sugarlabs.org/addon/4193 Sugar Platform: 0.82 - 0.90 Download Now: http://activities.sugarlabs.org/downloads/file/27067/physics-7.xo Release notes: - Fix for cpu idling events when in background special case for Sugar 0.84. Sugar Labs Activities http://activities.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [RELEASE] Physics-7
== Source == http://download.sugarlabs.org/sources/honey/Physics/Physics-7.tar.bz2 == News == - Fix for cpu idling events when in background special case for Sugar 0.84. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] Dangerous comments in activities.sugarlabs.org?
I don't know who can check this: http://activities.sugarlabs.org/es-ES/sugar/user/2394 Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Dangerous comments in activities.sugarlabs.org?
On Wed, Oct 13, 2010 at 10:22 PM, Gonzalo Odiard gonz...@laptop.org wrote: I don't know who can check this: http://activities.sugarlabs.org/es-ES/sugar/user/2394 Thanks for the heads up. I think I got it taken care of. -walter Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel -- Walter Bender Sugar Labs http://www.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
