Re: [Sugar-devel] [DESIGN] Proposal: Multi-Selection and Batch Operations on Journal entries
On Fri, Aug 3, 2012 at 8:53 PM, Ajay Garg a...@activitycentral.com wrote: Thanks a ton Gary. This is REALLY useful :) Please find the comments inline. On Fri, Aug 3, 2012 at 6:29 PM, Gary Martin garycmar...@googlemail.comwrote: Hi Ajay/Anish, On 18 Jul 2012, at 11:57, Anish Mangal an...@activitycentral.com wrote: I would like to propose the long-discussed-finally-implemented ;-) journal entry batch operation and multi selection feature for inclusion in sugar-0.98. All the necessary and relevant details should be present in the associated feature page: http://wiki.sugarlabs.org/go/Features/Multi_selection_screenshots AFAIK, This feature was initially brought up in discussions in EDUJam in 2011 and an initial implementation was made by Martin Abente. The current implementation, done by Ajay, has been derived from that keeping the UI experience largely the same while significantly speeding up operations like select/deselect. Should you have any design related questions about this, feel free to reply to this thread. At last Tuesday's design meeting we didn't make it back around to this agenda item, so here's my feedback/notes after testing the DX3 image with the new rpms: - FIXED. Once in multi-select mode, the favourite stars no longer visibly updates, though changes update later once multi-select mode is exited. Great !! - FIXED. Auto deselection after batch operation. Great !! - UNRESOLVED BUG. Tick-box slow/erratic behaviour in dx3ng143 with latest rpm fixes image on XO1, still needs mouse movement to redraw. This is also an issue when using the Select all toobar button, as the list view tick-boxes do not update until after the Select all. You have selected N entries. (Ok) dialogue is clicked. Yep.. this is becoming a real pain. I have tried the solutions listed at http://lists.sugarlabs.org/archive/sugar-devel/2012-July/038626.html, but none seem to work :-\ Anyways, I am still trying .. [Ajay ACTION 1] : Fix this. - NEW BUG. Renaming an entry while in multi-select mode does not display the name change, only updates the name displayed after multi-select mode is exited. Thanks. Reproduced the bug at my side. [Ajay ACTION 2] : Will fix. - NEW BUG. If you rename while in multi-select and then try to copy, the entry can't be copied and raises an error Entries without a filename cannot be copied. Hmm.. I think this is a false-negative. I tried the following :: * Entered multi-select mode. * Selected an entry (by ticking the check-box). * Re-named the entry (however, the rename was not immediately visible, due to the above bug). * Copied the entry to Documents. * Exited multi-select mode. * Clicked Documents icon. * The entry (WITH THE MODIFIED NAME) was present. I guess the error message Entries without a file cannot be copied occurred on an entry, that would have anyways given this message, even if you hadn't renamed the entry. [Gary ACTION 1] : Please let me know if you still face the error :) - UNRESOLVED DESIGN QUESTION. Should filters continue to work once in multi-select mode e.g: Filter for star favourite items in Journal; multi select all stared items; un-favourite some entries while in multi-select mode. Should they be removed from the multi-select view, or stay? Currently they stay, but this causes a visual 'jump' when exiting multi-select mode as the initial filter is re-applied to the view. Same issue if filtering the Journal by title, and you rename some entries while in multi-select mode. Well, I would say not to effect the change during multi-select mode, because of the following reasons :: * Currently, the code is tightly bound to having the current listmodel entries in the cache. A re-fresh, would cause the cached entries to be re-distributed, requiring a very major code change. * The original motive of allowing the user to set/unset favorite status, and rename entry, is to help the user do the processing on the entry, as she selects the entry. So, I guess it would be ok to effect the filters of these secondary features, AFTER the original action (copy, erase) is completed, and multi-select mode exited. [Gary ACTION 2] : Anyhow, please let me know if you think otherwise :) - FEEDBACK. In multi-select mode the toolbar button string 'Select none' would be better renamed as 'Deselect all'. Ok. [Ajay ACTION 3] : Will fix. - TESTING. A loaded Journal with ~100 items, and a USB stick with 900+ items was tested. Selecting individual items one by one is reasonable (ignoring the above unresolved redraw/event bug). Batch selecting, deselecting, erasing operations are pretty quick (batch feedback progress is helpful especially for the 900+ item case). Batch
[Sugar-devel] [sugar 0.98 PATCH v2] sl#3528: Keep the Sugar keyword untranslated.
===
Changes of version-2 over version-1 :
===
Version-1 had Sugar keyword in concatenation with rest of string. Rest of the
string was translated and then concatenated with Sugar keyword. Version-1
patch presumes that grammatical order is the same across all translated
languages(Thanks Samuel Greenfeld). So now in Version-2, translator comment has
been used to tell translator to translate the sentence except token
Sugar(Thanks Chris Leonard). This will preserve the grammatical meaning of
the sentence. (Thanks Ajay Garg for supporting and guiding me to resolve this).
Signed-off-by: Kartik Perisetla kartik.p...@gmail.com
---
extensions/cpsection/aboutcomputer/view.py |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/extensions/cpsection/aboutcomputer/view.py
b/extensions/cpsection/aboutcomputer/view.py
index 6b16005..6d59102 100644
--- a/extensions/cpsection/aboutcomputer/view.py
+++ b/extensions/cpsection/aboutcomputer/view.py
@@ -181,7 +181,7 @@ class AboutComputer(SectionView):
label_copyright.set_line_wrap(True)
label_copyright.show()
vbox_copyright.pack_start(label_copyright, expand=False)
-
+# TRANS: Do not translate the token Sugar. Translate rest of sentence.
info_text = _('Sugar is the graphical user interface that you are'
' looking at. Sugar is free software, covered by the'
' GNU General Public License, and you are welcome to'
--
1.7.10.4
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [DESIGN] Proposal: Multi-Selection and Batch Operations on Journal entries
Hi Ajay, On 4 Aug 2012, at 10:21, Ajay Garg a...@activitycentral.com wrote: On Fri, Aug 3, 2012 at 8:53 PM, Ajay Garg a...@activitycentral.com wrote: Thanks a ton Gary. This is REALLY useful :) Fab :) Please find the comments inline. On Fri, Aug 3, 2012 at 6:29 PM, Gary Martin garycmar...@googlemail.com wrote: Hi Ajay/Anish, On 18 Jul 2012, at 11:57, Anish Mangal an...@activitycentral.com wrote: I would like to propose the long-discussed-finally-implemented ;-) journal entry batch operation and multi selection feature for inclusion in sugar-0.98. All the necessary and relevant details should be present in the associated feature page: http://wiki.sugarlabs.org/go/Features/Multi_selection_screenshots AFAIK, This feature was initially brought up in discussions in EDUJam in 2011 and an initial implementation was made by Martin Abente. The current implementation, done by Ajay, has been derived from that keeping the UI experience largely the same while significantly speeding up operations like select/deselect. Should you have any design related questions about this, feel free to reply to this thread. At last Tuesday's design meeting we didn't make it back around to this agenda item, so here's my feedback/notes after testing the DX3 image with the new rpms: - FIXED. Once in multi-select mode, the favourite stars no longer visibly updates, though changes update later once multi-select mode is exited. Great !! - FIXED. Auto deselection after batch operation. Great !! - UNRESOLVED BUG. Tick-box slow/erratic behaviour in dx3ng143 with latest rpm fixes image on XO1, still needs mouse movement to redraw. This is also an issue when using the Select all toobar button, as the list view tick-boxes do not update until after the Select all. You have selected N entries. (Ok) dialogue is clicked. Yep.. this is becoming a real pain. I have tried the solutions listed at http://lists.sugarlabs.org/archive/sugar-devel/2012-July/038626.html, but none seem to work :-\ Anyways, I am still trying .. [Ajay ACTION 1] : Fix this. - NEW BUG. Renaming an entry while in multi-select mode does not display the name change, only updates the name displayed after multi-select mode is exited. Thanks. Reproduced the bug at my side. [Ajay ACTION 2] : Will fix. - NEW BUG. If you rename while in multi-select and then try to copy, the entry can't be copied and raises an error Entries without a filename cannot be copied. Hmm.. I think this is a false-negative. I tried the following :: * Entered multi-select mode. * Selected an entry (by ticking the check-box). * Re-named the entry (however, the rename was not immediately visible, due to the above bug). * Copied the entry to Documents. * Exited multi-select mode. * Clicked Documents icon. * The entry (WITH THE MODIFIED NAME) was present. I guess the error message Entries without a file cannot be copied occurred on an entry, that would have anyways given this message, even if you hadn't renamed the entry. [Gary ACTION 1] : Please let me know if you still face the error :) OK, sorry I must have missed an extra step (I can't reproduce this just now). Will email you if I can find a reliable way to reproduce it. However, I seem to have found a more nasty bug, while trying to test... Switch to the Journal Documents view; select an item; rename the selected item; the selected item will be deselected – though you'll still be in multi-select mode (but with nothing selected); click the toolbar button Select none; Journal will now be in a bad/unusable state, spinning busy cursor, can't escape multi select mode, shell log shows tracebacks IOError: Couldn't open metadata directory. I needed to restart Sugar to get back to normal. I'll post some shell logs in a separate email to you. - UNRESOLVED DESIGN QUESTION. Should filters continue to work once in multi-select mode e.g: Filter for star favourite items in Journal; multi select all stared items; un-favourite some entries while in multi-select mode. Should they be removed from the multi-select view, or stay? Currently they stay, but this causes a visual 'jump' when exiting multi-select mode as the initial filter is re-applied to the view. Same issue if filtering the Journal by title, and you rename some entries while in multi-select mode. Well, I would say not to effect the change during multi-select mode, because of the following reasons :: * Currently, the code is tightly bound to having the current listmodel entries in the cache. A re-fresh, would cause the cached entries to be re-distributed, requiring a very major code change. * The original motive of allowing the user to set/unset favorite status,
