Re: [Sugar-devel] [DESIGN] Background selection in Journal

[Ignacio Rodríguez]

So, I'm working on this right now.

But I'm stuck at ObjectChooser part.. I can create it, but it takes
too much time for appear (I mean, more than normal.. Maybe it doubles
the time.), and I suspect that it doesnt have focus

Im testing the code in a XO-4..
(I don't have sugar build in this laptop, and I don't have the space
required for install it)

Here is my current code [1]
Also it would be good if I can get tips to where insert the "Choose
from journal" button.

[1] (branch background2)  https://github.com/i5o/sugar/tree/background2
Greetings,
Ignacio

2015-08-07 14:01 GMT-03:00, Ignacio Rodríguez :
> Thanks for the comments Gonzalo
> I think all agree to get images from Journal in control panel
> So I will try to made it.
>
> About destination_path, was needed in case the image were copied to
> /home/user/Documents/lalala, but if we copy to a static path it wouldn't be
> needed
>
> So if we are going to replace GtkMenu would be better to don't touch the
> journal palette then.
>
> Thanks again, I will do some work, and send a new pr, for see what you
> guys, thinks.
>
> Greetings,
>
> Ignacio Rodríguez
> SugarLabs at Facebook
> 
>
> 2015-08-07 11:39 GMT-03:00 Gonzalo Odiard :
>
>> These are the reasons I would prefer add a option to get images from the
>> Journal in the control panel,
>> than add a option to set the image as background in the Journal Object
>> palette:
>> * Performance: create the Object palette is a relatively slow task. This
>> feature add the need of check
>> the mime type of the object, and is slow too.
>> * Would be much easier to implement, and keep the background feature code
>> contained.
>> * The Journal code is already complex enough.
>> * The actual implementation is a quick hack: in particular on this patch
>> [1]:
>>   * Use get_uid_list_cb as a function to get the list of uid selected,
>> and
>> do not work in that way,
>> think on multiple selections in the Journal.
>>   * Modify VolumeMenu adding a parameter to set if will set the
>> background. Would be better
>> create another class and keep the code separated.
>>   * The modifications on model.py need a deep review. But by example the
>> destination_path
>>  is not returned for all the operations.
>>
>> If we land the replacement of the GtkMenu, then we would solve the
>> performance part of the problem,
>> because we delay the check of the mimetype until the Modal window is
>> created.
>> Would be good have a  cleaner implementation anyway.
>>
>> [1]
>> https://github.com/i5o/sugar/commit/d43c95d6b44e33d7cc2b71e7fd4e9cf7ad01b487
>>
>> [2] http://wiki.sugarlabs.org/go/Features/Replace_GtkMenu
>>
>> On Wed, Aug 5, 2015 at 8:38 PM, James Cameron 
>> wrote:
>>
>>> G'day,
>>>
>>> Thanks for asking.
>>>
>>> In 0.106 we have a background control panel which offers images from
>>> either the system or the documents path.
>>>
>>> So for the learner to use a photograph in the journal as background
>>> they must open the journal, locate the photograph, copy it to the
>>> documents directory, then switch to home view, and open the control
>>> panel, choose background, and then locate the photograph again, where
>>> it appears twice instead of once.
>>>
>>> I'd like to see "Use as background" in the journal, because it is a
>>> learner-desired method of a journal object, and the journal lists the
>>> objects.  It will lower the barrier for learning and save time.
>>>
>>> At the moment, the journal object context menu has Resume, Resume
>>> with, Copy to, Duplicate, Send to, View Details, and Erase.
>>>
>>> I'd like to see "Use as background" in this menu, or in the "Copy to"
>>> submenu as you suggest.
>>>
>>> Also, after or in combination with the above, I'd like to see "Choose
>>> from journal" feature in the background control panel.  It will be a
>>> redundant feature, providing an extra path to the same function.  We
>>> already have several instances of redundant usage paths, and they
>>> serve a good purpose.
>>>
>>> I'd like to see either a button to press which opens the object
>>> picker, or the background control panel to show three groups of
>>> images; journal, documents, system.
>>>
>>> There is an opportunity to review common uses of the object picker to
>>> ensure they are all included in the journal object context menu.
>>>
>>> The other questions you ask are uninteresting implementation details
>>> unrelated to design:
>>>
>>> - whether it qualifies as a Feature in the release process, instead of
>>>   a defect, (to my mind it is a defect, because you will have added
>>>   nothing new to Sugar, only fixed a learner experience problem),
>>>
>>> - moving code around,
>>>
>>> - access to background model by activities,
>>>
>>> - whether to keep a redundant copy of the background separate to where
>>>   it was chosen from.
>>>
>>> --
>>> James Cameron
>>> 

Re: [Sugar-devel] [DESIGN] Background selection in Journal

[James Cameron]

I've tested your branch, thanks.

Yes, I see the problem; you've hit the modal dialogs.  A modal dialog
is a window that forces the keyboard and mouse to the window only.

What you are trying to do is open a new window on top of the control
panel.  I've tried this with software update, and it doesn't work.

The control panel was changed to be modal a long time ago.

If you can't use the object chooser, then change the background
control panel to show images from four sources; Journal, Documents,
mounted media, and system.  At the moment it only shows system
and Documents backgrounds, see BACKGROUNDS_DIRS.

On Mon, Sep 28, 2015 at 08:05:15PM -0300, Ignacio Rodríguez wrote:
> So, I'm working on this right now.
> 
> But I'm stuck at ObjectChooser part.. I can create it, but it takes
> too much time for appear (I mean, more than normal.. Maybe it doubles
> the time.), and I suspect that it doesnt have focus
> 
> Im testing the code in a XO-4..
> (I don't have sugar build in this laptop, and I don't have the space
> required for install it)
> 
> Here is my current code [1]
> Also it would be good if I can get tips to where insert the "Choose
> from journal" button.
> 
> [1] (branch background2)  https://github.com/i5o/sugar/tree/background2
> Greetings,
> Ignacio
> 
> 2015-08-07 14:01 GMT-03:00, Ignacio Rodríguez :
> > Thanks for the comments Gonzalo
> > I think all agree to get images from Journal in control panel
> > So I will try to made it.
> >
> > About destination_path, was needed in case the image were copied to
> > /home/user/Documents/lalala, but if we copy to a static path it wouldn't be
> > needed
> >
> > So if we are going to replace GtkMenu would be better to don't touch the
> > journal palette then.
> >
> > Thanks again, I will do some work, and send a new pr, for see what you
> > guys, thinks.
> >
> > Greetings,
> >
> > Ignacio Rodríguez
> > SugarLabs at Facebook
> > 
> >
> > 2015-08-07 11:39 GMT-03:00 Gonzalo Odiard :
> >
> >> These are the reasons I would prefer add a option to get images from the
> >> Journal in the control panel,
> >> than add a option to set the image as background in the Journal Object
> >> palette:
> >> * Performance: create the Object palette is a relatively slow task. This
> >> feature add the need of check
> >> the mime type of the object, and is slow too.
> >> * Would be much easier to implement, and keep the background feature code
> >> contained.
> >> * The Journal code is already complex enough.
> >> * The actual implementation is a quick hack: in particular on this patch
> >> [1]:
> >>   * Use get_uid_list_cb as a function to get the list of uid selected,
> >> and
> >> do not work in that way,
> >> think on multiple selections in the Journal.
> >>   * Modify VolumeMenu adding a parameter to set if will set the
> >> background. Would be better
> >> create another class and keep the code separated.
> >>   * The modifications on model.py need a deep review. But by example the
> >> destination_path
> >>  is not returned for all the operations.
> >>
> >> If we land the replacement of the GtkMenu, then we would solve the
> >> performance part of the problem,
> >> because we delay the check of the mimetype until the Modal window is
> >> created.
> >> Would be good have a  cleaner implementation anyway.
> >>
> >> [1]
> >> https://github.com/i5o/sugar/commit/d43c95d6b44e33d7cc2b71e7fd4e9cf7ad01b487
> >>
> >> [2] http://wiki.sugarlabs.org/go/Features/Replace_GtkMenu
> >>
> >> On Wed, Aug 5, 2015 at 8:38 PM, James Cameron 
> >> wrote:
> >>
> >>> G'day,
> >>>
> >>> Thanks for asking.
> >>>
> >>> In 0.106 we have a background control panel which offers images from
> >>> either the system or the documents path.
> >>>
> >>> So for the learner to use a photograph in the journal as background
> >>> they must open the journal, locate the photograph, copy it to the
> >>> documents directory, then switch to home view, and open the control
> >>> panel, choose background, and then locate the photograph again, where
> >>> it appears twice instead of once.
> >>>
> >>> I'd like to see "Use as background" in the journal, because it is a
> >>> learner-desired method of a journal object, and the journal lists the
> >>> objects.  It will lower the barrier for learning and save time.
> >>>
> >>> At the moment, the journal object context menu has Resume, Resume
> >>> with, Copy to, Duplicate, Send to, View Details, and Erase.
> >>>
> >>> I'd like to see "Use as background" in this menu, or in the "Copy to"
> >>> submenu as you suggest.
> >>>
> >>> Also, after or in combination with the above, I'd like to see "Choose
> >>> from journal" feature in the background control panel.  It will be a
> >>> redundant feature, providing an extra path to the same function.  We
> >>> already have several instances of redundant usage paths, and they
> >>> serve a good purpose.
> 

Re: [Sugar-devel] [DESIGN] Background selection in Journal

[Gonzalo Odiard]

These are the reasons I would prefer add a option to get images from the
Journal in the control panel,
than add a option to set the image as background in the Journal Object
palette:
* Performance: create the Object palette is a relatively slow task. This
feature add the need of check
the mime type of the object, and is slow too.
* Would be much easier to implement, and keep the background feature code
contained.
* The Journal code is already complex enough.
* The actual implementation is a quick hack: in particular on this patch
[1]:
  * Use get_uid_list_cb as a function to get the list of uid selected, and
do not work in that way,
think on multiple selections in the Journal.
  * Modify VolumeMenu adding a parameter to set if will set the background.
Would be better
create another class and keep the code separated.
  * The modifications on model.py need a deep review. But by example the
destination_path
 is not returned for all the operations.

If we land the replacement of the GtkMenu, then we would solve the
performance part of the problem,
because we delay the check of the mimetype until the Modal window is
created.
Would be good have a  cleaner implementation anyway.

[1]
https://github.com/i5o/sugar/commit/d43c95d6b44e33d7cc2b71e7fd4e9cf7ad01b487

[2] http://wiki.sugarlabs.org/go/Features/Replace_GtkMenu

On Wed, Aug 5, 2015 at 8:38 PM, James Cameron qu...@sugarlabs.org wrote:

 G'day,

 Thanks for asking.

 In 0.106 we have a background control panel which offers images from
 either the system or the documents path.

 So for the learner to use a photograph in the journal as background
 they must open the journal, locate the photograph, copy it to the
 documents directory, then switch to home view, and open the control
 panel, choose background, and then locate the photograph again, where
 it appears twice instead of once.

 I'd like to see Use as background in the journal, because it is a
 learner-desired method of a journal object, and the journal lists the
 objects.  It will lower the barrier for learning and save time.

 At the moment, the journal object context menu has Resume, Resume
 with, Copy to, Duplicate, Send to, View Details, and Erase.

 I'd like to see Use as background in this menu, or in the Copy to
 submenu as you suggest.

 Also, after or in combination with the above, I'd like to see Choose
 from journal feature in the background control panel.  It will be a
 redundant feature, providing an extra path to the same function.  We
 already have several instances of redundant usage paths, and they
 serve a good purpose.

 I'd like to see either a button to press which opens the object
 picker, or the background control panel to show three groups of
 images; journal, documents, system.

 There is an opportunity to review common uses of the object picker to
 ensure they are all included in the journal object context menu.

 The other questions you ask are uninteresting implementation details
 unrelated to design:

 - whether it qualifies as a Feature in the release process, instead of
   a defect, (to my mind it is a defect, because you will have added
   nothing new to Sugar, only fixed a learner experience problem),

 - moving code around,

 - access to background model by activities,

 - whether to keep a redundant copy of the background separate to where
   it was chosen from.

 --
 James Cameron
 http://quozl.linux.org.au/
 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel




-- 
Gonzalo Odiard

SugarLabs - Software [for | by] children learning
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [DESIGN] Background selection in Journal

[Ignacio Rodríguez]

Thanks for the comments Gonzalo
I think all agree to get images from Journal in control panel
So I will try to made it.

About destination_path, was needed in case the image were copied to
/home/user/Documents/lalala, but if we copy to a static path it wouldn't be
needed

So if we are going to replace GtkMenu would be better to don't touch the
journal palette then.

Thanks again, I will do some work, and send a new pr, for see what you
guys, thinks.

Greetings,

Ignacio Rodríguez
SugarLabs at Facebook
https://www.facebook.com/pages/SugarLabs/187845102582

2015-08-07 11:39 GMT-03:00 Gonzalo Odiard godi...@sugarlabs.org:

 These are the reasons I would prefer add a option to get images from the
 Journal in the control panel,
 than add a option to set the image as background in the Journal Object
 palette:
 * Performance: create the Object palette is a relatively slow task. This
 feature add the need of check
 the mime type of the object, and is slow too.
 * Would be much easier to implement, and keep the background feature code
 contained.
 * The Journal code is already complex enough.
 * The actual implementation is a quick hack: in particular on this patch
 [1]:
   * Use get_uid_list_cb as a function to get the list of uid selected, and
 do not work in that way,
 think on multiple selections in the Journal.
   * Modify VolumeMenu adding a parameter to set if will set the
 background. Would be better
 create another class and keep the code separated.
   * The modifications on model.py need a deep review. But by example the
 destination_path
  is not returned for all the operations.

 If we land the replacement of the GtkMenu, then we would solve the
 performance part of the problem,
 because we delay the check of the mimetype until the Modal window is
 created.
 Would be good have a  cleaner implementation anyway.

 [1]
 https://github.com/i5o/sugar/commit/d43c95d6b44e33d7cc2b71e7fd4e9cf7ad01b487

 [2] http://wiki.sugarlabs.org/go/Features/Replace_GtkMenu

 On Wed, Aug 5, 2015 at 8:38 PM, James Cameron qu...@sugarlabs.org wrote:

 G'day,

 Thanks for asking.

 In 0.106 we have a background control panel which offers images from
 either the system or the documents path.

 So for the learner to use a photograph in the journal as background
 they must open the journal, locate the photograph, copy it to the
 documents directory, then switch to home view, and open the control
 panel, choose background, and then locate the photograph again, where
 it appears twice instead of once.

 I'd like to see Use as background in the journal, because it is a
 learner-desired method of a journal object, and the journal lists the
 objects.  It will lower the barrier for learning and save time.

 At the moment, the journal object context menu has Resume, Resume
 with, Copy to, Duplicate, Send to, View Details, and Erase.

 I'd like to see Use as background in this menu, or in the Copy to
 submenu as you suggest.

 Also, after or in combination with the above, I'd like to see Choose
 from journal feature in the background control panel.  It will be a
 redundant feature, providing an extra path to the same function.  We
 already have several instances of redundant usage paths, and they
 serve a good purpose.

 I'd like to see either a button to press which opens the object
 picker, or the background control panel to show three groups of
 images; journal, documents, system.

 There is an opportunity to review common uses of the object picker to
 ensure they are all included in the journal object context menu.

 The other questions you ask are uninteresting implementation details
 unrelated to design:

 - whether it qualifies as a Feature in the release process, instead of
   a defect, (to my mind it is a defect, because you will have added
   nothing new to Sugar, only fixed a learner experience problem),

 - moving code around,

 - access to background model by activities,

 - whether to keep a redundant copy of the background separate to where
   it was chosen from.

 --
 James Cameron
 http://quozl.linux.org.au/
 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel




 --
 Gonzalo Odiard

 SugarLabs - Software [for | by] children learning

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [DESIGN] Background selection in Journal

[Ignacio Rodríguez]

Hi everyone.

Finally I got time for start to work on the features/patches that I
submitted time ago. (Too much time in school, but well, worth it :) )
In this case I would like to discuss the selection of background in Journal
[1] patch (maybe it’s a Feature)

The base idea is to add a option to the Copy to journal volume menu, for
make it more easy for new users..

Also move code for background settings to jarabe.model, so the apps would
be able to change the background (Not really needed in apps, but yes in
this patch)

Here [2] is a screenshot of how it looks

XFCE have a option for set as wallpaper [3]

I don't remember if gnome have one too

Right now it copy the image to “/home/user/Documents” for be able to see it
in Control Panel, but Sam suggested to copy it to somewhere in
“/home/user/.sugar” folder.

I like that idea, I think we can copy it to .sugar/background.[jpg/png]
(Also we can copy the  selected one in controlpanel for avoid problems if
the user remove it in Journal - maybe another patch)

Comments are gratefully received.

[1] https://github.com/sugarlabs/sugar/pull/466
[2] http://people.sugarlabs.org/ignacio/Set%20as%20wallpaper-Sugar.png
[3] http://people.sugarlabs.org/ignacio/Set%20as%20wallpaper-XFCE.png
Greetings,

Ignacio Rodríguez
SugarLabs at Facebook
https://www.facebook.com/pages/SugarLabs/187845102582
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [DESIGN] Background selection in Journal

[Sam P.]

Hi Ignacio,

On Thu, 6 Aug 2015 7:46 am Ignacio Rodríguez igna...@sugarlabs.org wrote:

Hi everyone.

Finally I got time for start to work on the features/patches that I
submitted time ago. (Too much time in school, but well, worth it :) )
In this case I would like to discuss the selection of background in Journal
[1] patch (maybe it’s a Feature)

Does this have a feature page?

The base idea is to add a option to the Copy to journal volume menu, for
make it more easy for new users..

Also move code for background settings to jarabe.model, so the apps would
be able to change the background (Not really needed in apps, but yes in
this patch)

Here [2] is a screenshot of how it

looks

Looks good.

XFCE have a option for set as wallpaper [3]

I don't remember if gnome have one too

Right now it copy the image to “/home/user/Documents” for be able to see it
in Control Panel, but Sam suggested to copy it to somewhere in
“/home/user/.sugar” folder.

I like that idea, I think we can copy it to .sugar/background.[jpg/png]
(Also we can copy the  selected one in controlpanel for avoid problems if
the user remove it in Journal - maybe another patch)

Maybe we could copy it to .sugar/user-backgrounds folder?  Then we could
just add that in the search path in the cpanel and not do to many fancy
things?   Maybe that is less code.

Thanks,
Sam

Comments are gratefully received.

[1] https://github.com/sugarlabs/sugar/pull/466
[2] http://people.sugarlabs.org/ignacio/Set%20as%20wallpaper-Sugar.png
[3] http://people.sugarlabs.org/ignacio/Set%20as%20wallpaper-XFCE.png

Greetings,

Ignacio Rodríguez

SugarLabs at Facebook
https://www.facebook.com/pages/SugarLabs/187845102582

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [DESIGN] Background selection in Journal

[Ignacio Rodríguez]

Hi Sam :)

Does this have a feature page?


Not yet I will write one.

Maybe we could copy it to .sugar/user-backgrounds folder?


Sure

  Then we could just add that in the search path in the cpanel and not do
 to many fancy things?   Maybe that is less code.


I think we should set the background anyway when clicking -Copy to
background- or maybe just remove the Copy to background, and add
Set as background/wallpaper what do you think?

Greetings,

Ignacio Rodríguez
SugarLabs at Facebook
https://www.facebook.com/pages/SugarLabs/187845102582

2015-08-05 19:04 GMT-03:00 Sam P. sam@sam.today:

 Hi Ignacio,

 On Thu, 6 Aug 2015 7:46 am Ignacio Rodríguez igna...@sugarlabs.org
 wrote:

 Hi everyone.

 Finally I got time for start to work on the features/patches that I
 submitted time ago. (Too much time in school, but well, worth it :) )
 In this case I would like to discuss the selection of background in
 Journal [1] patch (maybe it’s a Feature)

 Does this have a feature page?

 The base idea is to add a option to the Copy to journal volume menu, for
 make it more easy for new users..

 Also move code for background settings to jarabe.model, so the apps would
 be able to change the background (Not really needed in apps, but yes in
 this patch)

 Here [2] is a screenshot of how it

 looks

 Looks good.

 XFCE have a option for set as wallpaper [3]

 I don't remember if gnome have one too

 Right now it copy the image to “/home/user/Documents” for be able to see
 it in Control Panel, but Sam suggested to copy it to somewhere in
 “/home/user/.sugar” folder.

 I like that idea, I think we can copy it to .sugar/background.[jpg/png]
 (Also we can copy the  selected one in controlpanel for avoid problems if
 the user remove it in Journal - maybe another patch)

 Maybe we could copy it to .sugar/user-backgrounds folder?  Then we could
 just add that in the search path in the cpanel and not do to many fancy
 things?   Maybe that is less code.

 Thanks,
 Sam

 Comments are gratefully received.

 [1] https://github.com/sugarlabs/sugar/pull/466
 [2] http://people.sugarlabs.org/ignacio/Set%20as%20wallpaper-Sugar.png
 [3] http://people.sugarlabs.org/ignacio/Set%20as%20wallpaper-XFCE.png

 Greetings,

 Ignacio Rodríguez

 SugarLabs at Facebook
 https://www.facebook.com/pages/SugarLabs/187845102582

 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel



___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [DESIGN] Background selection in Journal

[James Cameron]

G'day,

Thanks for asking.

In 0.106 we have a background control panel which offers images from
either the system or the documents path.

So for the learner to use a photograph in the journal as background
they must open the journal, locate the photograph, copy it to the
documents directory, then switch to home view, and open the control
panel, choose background, and then locate the photograph again, where
it appears twice instead of once.

I'd like to see Use as background in the journal, because it is a
learner-desired method of a journal object, and the journal lists the
objects.  It will lower the barrier for learning and save time.

At the moment, the journal object context menu has Resume, Resume
with, Copy to, Duplicate, Send to, View Details, and Erase.

I'd like to see Use as background in this menu, or in the Copy to
submenu as you suggest.

Also, after or in combination with the above, I'd like to see Choose
from journal feature in the background control panel.  It will be a
redundant feature, providing an extra path to the same function.  We
already have several instances of redundant usage paths, and they
serve a good purpose.

I'd like to see either a button to press which opens the object
picker, or the background control panel to show three groups of
images; journal, documents, system.

There is an opportunity to review common uses of the object picker to
ensure they are all included in the journal object context menu.

The other questions you ask are uninteresting implementation details
unrelated to design:

- whether it qualifies as a Feature in the release process, instead of
  a defect, (to my mind it is a defect, because you will have added
  nothing new to Sugar, only fixed a learner experience problem),

- moving code around,

- access to background model by activities,

- whether to keep a redundant copy of the background separate to where
  it was chosen from.

-- 
James Cameron
http://quozl.linux.org.au/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel