[Sugar-devel] [Dextrose] [PATCH v4 sugar] Pulsing icon delayed by 5 seconds or so SL#2080
> > Bernie, > > Appreciate your timely feedback and support. Thank you so much. > > I wish to give one final shot solving this issue, before shifting to the > other bugs assigned to me. I spend last night thinking about the pointers > provided by your kind self. I have tried to inculcate them in my update > patch. Hope you are not offended by this action. > > In my updated patch, I have tried to reduce the delay by changing the first > frame of the animation to its raw svg icon. Then, followed it up with > rendering the pulsing icon animation. This has reduced the delay > significantly - the time required to render the first frame is the time > required to render a static svg image of the activity icon. It seems to me > that this would be the minimum time required to start the animation. Hence, > minimize the delay. > > Regards, > > Anurag > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Dextrose] [PATCH v4 sugar] Pulsing icon delayed by 5 seconds or so SL#2080
On Mon, 2010-10-11 at 18:23 -0300, Gonzalo Odiard wrote: > In my experience, it's easier start resolving tickets in activities > than in the plataform. > That worked for me: > * start writing a new activity: you can do stupid things, while learn > python and the interaction with the platform. > * try t resolve easy tickets in activities: there are many in > http://bugs.sugarlabs.org/ and http://dev.laptop.org/ > * next try to solve problems in Sugar. I completely agree with you. -- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Dextrose] [PATCH v4 sugar] Pulsing icon delayed by 5 seconds or so SL#2080
In my experience, it's easier start resolving tickets in activities than in the plataform. That worked for me: * start writing a new activity: you can do stupid things, while learn python and the interaction with the platform. * try t resolve easy tickets in activities: there are many in http://bugs.sugarlabs.org/ and http://dev.laptop.org/ * next try to solve problems in Sugar. Regards Gonzalo I recommend switching to an easier bug. > > -- > // Bernie Innocenti - http://codewiz.org/ > \X/ Sugar Labs - http://sugarlabs.org/ > > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Dextrose] [PATCH v4 sugar] Pulsing icon delayed by 5 seconds or so SL#2080
On Tue, 2010-10-12 at 05:42 +0530, Anurag Chowdhury wrote: > diff --git a/src/sugar/graphics/animator.py b/src/sugar/graphics/animator.py > index 8fb298b..e3a3503 100644 > --- a/src/sugar/graphics/animator.py > +++ b/src/sugar/graphics/animator.py > @@ -136,7 +136,7 @@ class Animation(object): > start = self.start > change = self.end - self.start > > -if t == duration: > +if fps < 20: > # last frame > frame = self.end Ugh. 1) Where does this magic number 20 come from? 2) Isn't "fps" the *desired* frame-rate set by client code when creating the Animator instance? 3) The variable fps isn't even available within the Animator.do_frame(). Are you familiar with variable scoping OOP languages? 4) The patch isn't *adding* the check, it's *replacing* the existing check to terminate the animation normally. 5) Finally, have you executed Sugar at least once with the patch applied to check that it fixes the bug without introducing new problems? Because of (3), it will simply cause an exception. Even if it worked, it would make Sugar skip all animations at <20fps and turn all the others into infinite loops, which is hardly the desired effect. I recommend switching to an easier bug. -- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
