Re: [Sugar-devel] [FEATURE] Automatic activity updates
On Sat, Jun 15, 2013 at 6:42 PM, Daniel Narvaez dwnarv...@gmail.com wrote: Cool. I'd say it's in then... Added a feature page https://github.com/sugarlabs/roadmap/issues/9 Thanks for being open to this. The implementation is ready for review. https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/11 https://github.com/sugarlabs/sugar/pull/40 Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
Cool. I'd say it's in then... Added a feature page https://github.com/sugarlabs/roadmap/issues/9 On 13 June 2013 01:42, Manuel Quiñones ma...@laptop.org wrote: 2013/6/12 Daniel Narvaez dwnarv...@gmail.com: On 12 June 2013 22:19, Daniel Drake d...@laptop.org wrote: On Wed, Jun 12, 2013 at 2:10 PM, Daniel Narvaez dwnarv...@gmail.com wrote: Hi, we are going to code freeze on Sep 4, and that's when it would also probably make sense to branch master. Which is a bit later than you would like to land it. Though I wonder if we should consider this feature for 0.100 since * There is still a considerable amount of time left. Freeze dates seems to be compatible with your goals. * Part of the work seems to be cleaning up the existing mess. * A few of the features we planned for 0.100 seems a bit stalled (3g modems, multiple journal selection, multiple home views). * The web activities work, which is where most of the changes are going, is not affecting much the existing code. Glad to hear that you are interested. I had mentioned August previously in order to not be too demanding! I expect to submit quite a bit sooner and if speedy feedback is possible then this could hopefully be closed quickly. If the maintainers are happy to merge it into 0.100 I have no objections of course. Simon, Manuel, what do you think? Is an excellent feature, and the solution looks very well thought and with the users in mind. I'm +1 for this on 0.100 . -- .. manuq .. -- Daniel Narvaez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
cc'ing Ajay On 13 June 2013 00:56, James Cameron qu...@laptop.org wrote: On Thu, Jun 13, 2013 at 01:54:24AM -0300, Gonzalo Odiard wrote: Yes, but somebody should provide patches, and do any change needed when the maintainers do the review, to be sure we have the quality needed upstream. Maintainers could do this themselves if they wanted to. I'd caution against change given the stability of the feature in the dextrose deployments. And that stability should increase the chances of it being accepted. I'm sure the maintainers would also like to hear from users of the feature. http://wiki.sugarlabs.org/go/Features/3G_Support seems complete and is in the version of Sugar used by OLPC OS. Opps... Sorry, please have a look at the Dextrose page: http://wiki.sugarlabs.org/go/Features/3G_Support/Database_Support and the patches were submitted to the mailing list: http://lists.sugarlabs.org/archive/sugar-devel/2012-August/038916.html http://lists.sugarlabs.org/archive/sugar-devel/2012-August/038900.html Perhaps Ajay can fill in the details better that me. http://wiki.sugarlabs.org/go/Features/3G_Support/Share looks incomplete, and would be interesting. The feature works for me here. Ajay, any chance on whipping up a set of patches for review? Jerry -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
On 13 June 2013 07:56, James Cameron qu...@laptop.org wrote: On Thu, Jun 13, 2013 at 01:54:24AM -0300, Gonzalo Odiard wrote: Yes, but somebody should provide patches, and do any change needed when the maintainers do the review, to be sure we have the quality needed upstream. Maintainers could do this themselves if they wanted to. They could or they could have other priorities, which I suspect is the case here. I'd caution against change given the stability of the feature in the dextrose deployments. These patches needs to be reviewed, like any other patch that makes it into the sugar code base. Even assuming they are rock stable, it's not just matter of stability but also of code quality, how do they integrate with existing code etc. If reviewers feels like they are not able to review them in the form they have been submitted, someone needs to refactor them. No way around that. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
On 13 June 2013 11:33, Jerry Vonau je...@laptop.org.au wrote: cc'ing Ajay On 13 June 2013 00:56, James Cameron qu...@laptop.org wrote: On Thu, Jun 13, 2013 at 01:54:24AM -0300, Gonzalo Odiard wrote: Yes, but somebody should provide patches, and do any change needed when the maintainers do the review, to be sure we have the quality needed upstream. Maintainers could do this themselves if they wanted to. I'd caution against change given the stability of the feature in the dextrose deployments. And that stability should increase the chances of it being accepted. I'm sure the maintainers would also like to hear from users of the feature. http://wiki.sugarlabs.org/go/Features/3G_Support seems complete and is in the version of Sugar used by OLPC OS. Opps... Sorry, please have a look at the Dextrose page: http://wiki.sugarlabs.org/go/Features/3G_Support/Database_Support and the patches were submitted to the mailing list: http://lists.sugarlabs.org/archive/sugar-devel/2012-August/038916.html http://lists.sugarlabs.org/archive/sugar-devel/2012-August/038900.html Perhaps Ajay can fill in the details better that me. http://wiki.sugarlabs.org/go/Features/3G_Support/Share looks incomplete, and would be interesting. The feature works for me here. Ajay, any chance on whipping up a set of patches for review? Please submit them as a github pull request. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
Daniel, what you say makes sense for small-but-critical patches (like it happens in the linux-kernel world, where there is rarely a patch more than 10 lines long. Moreover, the linux-kernel code is cleanly segregated into different modules, so there are rarely clashes in people's work, as far as touching the same code is concerned.) However, here in sugar, code is being modified on quite a military basis everyday (which is a good state to be in, during the development-process :-) ). This makes it very tedious to work :: * Externally on a patch (as it will be needed to be rebased everyday on the mainline branch, if not sooner). * Ensure that nothing breaks (in the new feature) in every iteration of the patch. Thus, I agree with James. If there is a feature that is rock-solid in its working, we must think of including in the mainline/master branch right away (of course, after ensuring that it does not mass-break things), *and then* make changes (if at all required). This serves the additional following purposes :: * This ensures that the code-change-and-then-commit cycle is always upto date with the latest mainline code. * This ensures that nothing breaks in every code-iteration (or if it does, have a log and state in git, where it worked fine). Of course, even an averagely smart developer will at least gauge the broad-level architecture of the newly written feature, just by skimming through the code. If that bigger picture architecture is good enough (in addition to the fact that the feature is rock-solid), I think it makes all the more sense to include the feature right away in mainline/master (of course, if it does not mass-break things), *and then* continue working on the minor tweaks (if at all necessary). My 2 cents :) On Thu, Jun 13, 2013 at 3:26 PM, Daniel Narvaez dwnarv...@gmail.com wrote: On 13 June 2013 07:56, James Cameron qu...@laptop.org wrote: On Thu, Jun 13, 2013 at 01:54:24AM -0300, Gonzalo Odiard wrote: Yes, but somebody should provide patches, and do any change needed when the maintainers do the review, to be sure we have the quality needed upstream. Maintainers could do this themselves if they wanted to. They could or they could have other priorities, which I suspect is the case here. I'd caution against change given the stability of the feature in the dextrose deployments. These patches needs to be reviewed, like any other patch that makes it into the sugar code base. Even assuming they are rock stable, it's not just matter of stability but also of code quality, how do they integrate with existing code etc. If reviewers feels like they are not able to review them in the form they have been submitted, someone needs to refactor them. No way around that. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel -- Regards, Ajay ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
On Thursday, 13 June 2013, Ajay Garg wrote: Daniel, what you say makes sense for small-but-critical patches (like it happens in the linux-kernel world, where there is rarely a patch more than 10 lines long. Moreover, the linux-kernel code is cleanly segregated into different modules, so there are rarely clashes in people's work, as far as touching the same code is concerned.) Heh patch reviews are used by the vast majority of open source projects, certainly not just the kernel. However, here in sugar, code is being modified on quite a military basis everyday (which is a good state to be in, during the development-process :-) ). This makes it very tedious to work :: * Externally on a patch (as it will be needed to be rebased everyday on the mainline branch, if not sooner). * Ensure that nothing breaks (in the new feature) in every iteration of the patch. It only becomes tedious if you fail to upstream the patch. It is good practice to split up big changes in many small logical commits, if you had done that the code would probably be upstream by now and you wouldn't need to rebase it. Thus, I agree with James. If there is a feature that is rock-solid in its working, we must think of including in the mainline/master branch right away (of course, after ensuring that it does not mass-break things), *and then* make changes (if at all required). We had this discussion multiple times already and we are not making any progress. In the end it's up to the maintainers to decide how code should be accepted into the tree. And, like them or not, I'd say the rules are pretty clear these days. As release manager, I need to know if you intend to keep working on the two features you proposed by playing to the current rules. If you want to convince maintainers to change them you can try but please let's keep that as a separate topic. -- Daniel Narvaez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
+1 Very nice idea and very good analysis of drawbacks of the old updates process. Lionel. -- Message: 3 Date: Tue, 11 Jun 2013 16:42:11 -0600 From: Daniel Drake d...@laptop.org To: Sugar Devel sugar-devel@lists.sugarlabs.org Subject: [Sugar-devel] [FEATURE] Automatic activity updates Message-ID: CAMLZHHSbUyfFqM_HDcp+ohHXuEYFRYkuFzuMt9jnah=py8p...@mail.gmail.com Content-Type: text/plain; charset=ISO-8859-1 Hi, Over the last few months I have been slowly developing a much needed field feature, the final piece in the automatic system upgrade puzzle. Now I am getting close, I would like to open the formalities... http://wiki.sugarlabs.org/go/Features/Automatic_activity_updates At this point I've iterated the design once or twice and implemented most of this locally. I will hopefully publish the full patch series in the next couple of weeks. I understand this is too late for 0.100. What I would hope for is a review and (after feedback) merge into a master branch before the end of August. Then I will run a live field test and send in any necessary refinements. This would then likely be deployed large scale in Nicaragua at the end of the year or the start of the next. Comments welcome. Thanks Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
Great news, Let me know if I can help! On Wed, Jun 12, 2013 at 3:18 PM, lio...@olpc-france.org wrote: +1 Very nice idea and very good analysis of drawbacks of the old updates process. Lionel. -- Message: 3 Date: Tue, 11 Jun 2013 16:42:11 -0600 From: Daniel Drake d...@laptop.org To: Sugar Devel sugar-devel@lists.sugarlabs.org Subject: [Sugar-devel] [FEATURE] Automatic activity updates Message-ID: CAMLZHHSbUyfFqM_HDcp+ohHXuEYFRYkuFzuMt9jnah= py8p...@mail.gmail.com Content-Type: text/plain; charset=ISO-8859-1 Hi, Over the last few months I have been slowly developing a much needed field feature, the final piece in the automatic system upgrade puzzle. Now I am getting close, I would like to open the formalities... http://wiki.sugarlabs.org/go/Features/Automatic_activity_updates At this point I've iterated the design once or twice and implemented most of this locally. I will hopefully publish the full patch series in the next couple of weeks. I understand this is too late for 0.100. What I would hope for is a review and (after feedback) merge into a master branch before the end of August. Then I will run a live field test and send in any necessary refinements. This would then likely be deployed large scale in Nicaragua at the end of the year or the start of the next. Comments welcome. Thanks Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
Hi, we are going to code freeze on Sep 4, and that's when it would also probably make sense to branch master. Which is a bit later than you would like to land it. Though I wonder if we should consider this feature for 0.100 since * There is still a considerable amount of time left. Freeze dates seems to be compatible with your goals. * Part of the work seems to be cleaning up the existing mess. * A few of the features we planned for 0.100 seems a bit stalled (3g modems, multiple journal selection, multiple home views). * The web activities work, which is where most of the changes are going, is not affecting much the existing code. Ideally we would have discussed this earlier but pragmatically I don't see strong reasons to keep this code out of tree until the next release. On 12 June 2013 00:42, Daniel Drake d...@laptop.org wrote: Hi, Over the last few months I have been slowly developing a much needed field feature, the final piece in the automatic system upgrade puzzle. Now I am getting close, I would like to open the formalities... http://wiki.sugarlabs.org/go/Features/Automatic_activity_updates At this point I've iterated the design once or twice and implemented most of this locally. I will hopefully publish the full patch series in the next couple of weeks. I understand this is too late for 0.100. What I would hope for is a review and (after feedback) merge into a master branch before the end of August. Then I will run a live field test and send in any necessary refinements. This would then likely be deployed large scale in Nicaragua at the end of the year or the start of the next. Comments welcome. Thanks Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel -- Daniel Narvaez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
On Wed, Jun 12, 2013 at 2:10 PM, Daniel Narvaez dwnarv...@gmail.com wrote: Hi, we are going to code freeze on Sep 4, and that's when it would also probably make sense to branch master. Which is a bit later than you would like to land it. Though I wonder if we should consider this feature for 0.100 since * There is still a considerable amount of time left. Freeze dates seems to be compatible with your goals. * Part of the work seems to be cleaning up the existing mess. * A few of the features we planned for 0.100 seems a bit stalled (3g modems, multiple journal selection, multiple home views). * The web activities work, which is where most of the changes are going, is not affecting much the existing code. Glad to hear that you are interested. I had mentioned August previously in order to not be too demanding! I expect to submit quite a bit sooner and if speedy feedback is possible then this could hopefully be closed quickly. If the maintainers are happy to merge it into 0.100 I have no objections of course. Thanks Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
On 12 June 2013 22:19, Daniel Drake d...@laptop.org wrote: On Wed, Jun 12, 2013 at 2:10 PM, Daniel Narvaez dwnarv...@gmail.com wrote: Hi, we are going to code freeze on Sep 4, and that's when it would also probably make sense to branch master. Which is a bit later than you would like to land it. Though I wonder if we should consider this feature for 0.100 since * There is still a considerable amount of time left. Freeze dates seems to be compatible with your goals. * Part of the work seems to be cleaning up the existing mess. * A few of the features we planned for 0.100 seems a bit stalled (3g modems, multiple journal selection, multiple home views). * The web activities work, which is where most of the changes are going, is not affecting much the existing code. Glad to hear that you are interested. I had mentioned August previously in order to not be too demanding! I expect to submit quite a bit sooner and if speedy feedback is possible then this could hopefully be closed quickly. If the maintainers are happy to merge it into 0.100 I have no objections of course. Simon, Manuel, what do you think? ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
On 12 June 2013 15:10, Daniel Narvaez dwnarv...@gmail.com wrote: Hi, we are going to code freeze on Sep 4, and that's when it would also probably make sense to branch master. Which is a bit later than you would like to land it. Though I wonder if we should consider this feature for 0.100 since * There is still a considerable amount of time left. Freeze dates seems to be compatible with your goals. * Part of the work seems to be cleaning up the existing mess. * A few of the features we planned for 0.100 seems a bit stalled (3g modems, multiple journal selection, multiple home views). FWIW, 3g modem[1], and 3g sharing[2] both work in Dextrose4, perhaps you could look to see how AC implemented their version. 1. http://wiki.sugarlabs.org/go/Features/3G_Support 2. http://wiki.sugarlabs.org/go/Features/3G_Support/Share Jerry * The web activities work, which is where most of the changes are going, is not affecting much the existing code. Ideally we would have discussed this earlier but pragmatically I don't see strong reasons to keep this code out of tree until the next release. On 12 June 2013 00:42, Daniel Drake d...@laptop.org wrote: Hi, Over the last few months I have been slowly developing a much needed field feature, the final piece in the automatic system upgrade puzzle. Now I am getting close, I would like to open the formalities... http://wiki.sugarlabs.org/go/Features/Automatic_activity_updates At this point I've iterated the design once or twice and implemented most of this locally. I will hopefully publish the full patch series in the next couple of weeks. I understand this is too late for 0.100. What I would hope for is a review and (after feedback) merge into a master branch before the end of August. Then I will run a live field test and send in any necessary refinements. This would then likely be deployed large scale in Nicaragua at the end of the year or the start of the next. Comments welcome. Thanks Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel -- Daniel Narvaez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
FWIW, 3g modem[1], and 3g sharing[2] both work in Dextrose4, perhaps you could look to see how AC implemented their version. 1. http://wiki.sugarlabs.org/go/Features/3G_Support 2. http://wiki.sugarlabs.org/go/Features/3G_Support/Share Jerry Yes, but somebody should provide patches, and do any change needed when the maintainers do the review, to be sure we have the quality needed upstream. Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
On Thu, Jun 13, 2013 at 01:54:24AM -0300, Gonzalo Odiard wrote: Yes, but somebody should provide patches, and do any change needed when the maintainers do the review, to be sure we have the quality needed upstream. Maintainers could do this themselves if they wanted to. I'd caution against change given the stability of the feature in the dextrose deployments. And that stability should increase the chances of it being accepted. I'm sure the maintainers would also like to hear from users of the feature. http://wiki.sugarlabs.org/go/Features/3G_Support seems complete and is in the version of Sugar used by OLPC OS. http://wiki.sugarlabs.org/go/Features/3G_Support/Share looks incomplete, and would be interesting. -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [FEATURE] Automatic activity updates
Hi, Over the last few months I have been slowly developing a much needed field feature, the final piece in the automatic system upgrade puzzle. Now I am getting close, I would like to open the formalities... http://wiki.sugarlabs.org/go/Features/Automatic_activity_updates At this point I've iterated the design once or twice and implemented most of this locally. I will hopefully publish the full patch series in the next couple of weeks. I understand this is too late for 0.100. What I would hope for is a review and (after feedback) merge into a master branch before the end of August. Then I will run a live field test and send in any necessary refinements. This would then likely be deployed large scale in Nicaragua at the end of the year or the start of the next. Comments welcome. Thanks Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
+1 to the idea :) 2013/6/11 Daniel Drake d...@laptop.org Hi, Over the last few months I have been slowly developing a much needed field feature, the final piece in the automatic system upgrade puzzle. Now I am getting close, I would like to open the formalities... http://wiki.sugarlabs.org/go/Features/Automatic_activity_updates At this point I've iterated the design once or twice and implemented most of this locally. I will hopefully publish the full patch series in the next couple of weeks. I understand this is too late for 0.100. What I would hope for is a review and (after feedback) merge into a master branch before the end of August. Then I will run a live field test and send in any necessary refinements. This would then likely be deployed large scale in Nicaragua at the end of the year or the start of the next. Comments welcome. Thanks Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel -- Ignacio Rodríguez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [FEATURE] Automatic activity updates
+1 providing the back-end supports proxies. I recall the native updater in sugar didn't in the past, haven't tested lately. Jerry On Tue, 2013-06-11 at 16:42 -0600, Daniel Drake wrote: Hi, Over the last few months I have been slowly developing a much needed field feature, the final piece in the automatic system upgrade puzzle. Now I am getting close, I would like to open the formalities... http://wiki.sugarlabs.org/go/Features/Automatic_activity_updates At this point I've iterated the design once or twice and implemented most of this locally. I will hopefully publish the full patch series in the next couple of weeks. I understand this is too late for 0.100. What I would hope for is a review and (after feedback) merge into a master branch before the end of August. Then I will run a live field test and send in any necessary refinements. This would then likely be deployed large scale in Nicaragua at the end of the year or the start of the next. Comments welcome. Thanks Daniel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
