Re: [Sugar-devel] [PATCH] Make sure the buddy palette is disposed after popdown #1742

2010-10-14 Thread Tomeu Vizoso 
On Wed, Oct 13, 2010 at 18:29, Simon Schampijer si...@schampijer.de wrote:
 On 10/11/2010 11:35 AM, Tomeu Vizoso wrote:

 ---
  src/jarabe/view/buddyicon.py |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

 diff --git a/src/jarabe/view/buddyicon.py b/src/jarabe/view/buddyicon.py
 index 37b9167..15385bd 100644
 --- a/src/jarabe/view/buddyicon.py
 +++ b/src/jarabe/view/buddyicon.py
 @@ -28,6 +28,8 @@ class BuddyIcon(CanvasIcon):
          self._buddy.connect('notify::present',
 self.__buddy_notify_present_cb)
          self._buddy.connect('notify::color',
 self.__buddy_notify_color_cb)

 +        self.palette_invoker.transient = True
 +
          self._update_color()

      def create_palette(self):

 This does set it to transient for all the buddies palletes, as well the one
 from the owner. As the owner palette has no dynamic content I guess we don't
 need to.

It's no big deal, but I think we should stop caching as many palettes
as possible.

Regards,

Tomeu

 Regards,
   Simon
 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [PATCH] Make sure the buddy palette is disposed after popdown #1742

2010-10-14 Thread Tomeu Vizoso 
---
 src/jarabe/view/buddyicon.py |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/jarabe/view/buddyicon.py b/src/jarabe/view/buddyicon.py
index 37b9167..332c0c8 100644
--- a/src/jarabe/view/buddyicon.py
+++ b/src/jarabe/view/buddyicon.py
@@ -28,6 +28,8 @@ class BuddyIcon(CanvasIcon):
 self._buddy.connect('notify::present', self.__buddy_notify_present_cb)
 self._buddy.connect('notify::color', self.__buddy_notify_color_cb)
 
+self.palette_invoker.cache_palette = False
+
 self._update_color()
 
 def create_palette(self):
-- 
1.7.2.3

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Make sure the buddy palette is disposed after popdown #1742

2010-10-14 Thread Sascha Silbe 
Excerpts from Tomeu Vizoso's message of Thu Oct 14 18:03:33 +0200 2010:

 It's no big deal, but I think we should stop caching as many palettes
 as possible.

+1 in general. Natural exceptions are palettes that are (potentially)
expensive to create - e.g. the ones in activity tool bars.

Sascha

--
http://sascha.silbe.org/
http://www.infra-silbe.de/


signature.asc
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Make sure the buddy palette is disposed after popdown #1742

2010-10-13 Thread Simon Schampijer 

On 10/11/2010 11:35 AM, Tomeu Vizoso wrote:

---
  src/jarabe/view/buddyicon.py |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/jarabe/view/buddyicon.py b/src/jarabe/view/buddyicon.py
index 37b9167..15385bd 100644
--- a/src/jarabe/view/buddyicon.py
+++ b/src/jarabe/view/buddyicon.py
@@ -28,6 +28,8 @@ class BuddyIcon(CanvasIcon):
  self._buddy.connect('notify::present', self.__buddy_notify_present_cb)
  self._buddy.connect('notify::color', self.__buddy_notify_color_cb)

+self.palette_invoker.transient = True
+
  self._update_color()

  def create_palette(self):


This does set it to transient for all the buddies palletes, as well the 
one from the owner. As the owner palette has no dynamic content I guess 
we don't need to.


Regards,
   Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [PATCH] Make sure the buddy palette is disposed after popdown #1742

2010-10-11 Thread Tomeu Vizoso 
---
 src/jarabe/view/buddyicon.py |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/jarabe/view/buddyicon.py b/src/jarabe/view/buddyicon.py
index 37b9167..15385bd 100644
--- a/src/jarabe/view/buddyicon.py
+++ b/src/jarabe/view/buddyicon.py
@@ -28,6 +28,8 @@ class BuddyIcon(CanvasIcon):
 self._buddy.connect('notify::present', self.__buddy_notify_present_cb)
 self._buddy.connect('notify::color', self.__buddy_notify_color_cb)
 
+self.palette_invoker.transient = True
+
 self._update_color()
 
 def create_palette(self):
-- 
1.7.2.3

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel