Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349
On Mon, Sep 20, 2010 at 22:39, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: Excerpts from Tomeu Vizoso's message of Mon Sep 20 14:56:04 +0200 2010: --- Would have been nice to note that this is a regression and callers expect the contact_id instead of the handle. At first I was worried that this might break other code, but the patch actually makes the listeners work again. Seems like this bug has been there since the signal was added, but indeed I can make explicit that I'm not changing the signal signature but passing the expected argument. Thanks, Tomeu Reviewed-By: Sascha Silbe sascha-...@silbe.org Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349
Excerpts from Tomeu Vizoso's message of Tue Sep 21 09:54:49 +0200 2010: Seems like this bug has been there since the signal was added, but indeed I can make explicit that I'm not changing the signal signature but passing the expected argument. That would be nice. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349
Excerpts from Tomeu Vizoso's message of Tue Sep 21 15:44:05 +0200 2010: I'm proposing this patch for inclusion in master during the hard code freeze period as per http://wiki.sugarlabs.org/go/0.90/Roadmap#Schedule The benefit is a more consistent neighborhood view and the risk is very low. +1 from me, FWIW (I guess only Simons vote matters). Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349
On Tue, Sep 21, 2010 at 17:23, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: Excerpts from Tomeu Vizoso's message of Tue Sep 21 15:44:05 +0200 2010: I'm proposing this patch for inclusion in master during the hard code freeze period as per http://wiki.sugarlabs.org/go/0.90/Roadmap#Schedule The benefit is a more consistent neighborhood view and the risk is very low. +1 from me, FWIW (I guess only Simons vote matters). Yup, maybe you should be part of the release team? Regards, Tomeu Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349
On 09/21/2010 05:32 PM, Tomeu Vizoso wrote: On Tue, Sep 21, 2010 at 17:23, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: Excerpts from Tomeu Vizoso's message of Tue Sep 21 15:44:05 +0200 2010: I'm proposing this patch for inclusion in master during the hard code freeze period as per http://wiki.sugarlabs.org/go/0.90/Roadmap#Schedule The benefit is a more consistent neighborhood view and the risk is very low. +1 from me, FWIW (I guess only Simons vote matters). Yup, maybe you should be part of the release team? Regards, Tomeu +1 from me as well. So far the release team is me and Tomeu - due to historical reasons (maybe Marco wants to get back in at one point :). If you read that at least 2 members need to approve a break [1] the policy might sound a bit funny. I am happy if new people want to jump in the team. You have shown great commitment in reviewing patches and at many other places. I am sure you would be a good fit :) Regards, Simon [1] http://wiki.sugarlabs.org/go/Development_Team/Release#Hard_code_freeze ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349
---
src/jarabe/model/neighborhood.py |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/jarabe/model/neighborhood.py b/src/jarabe/model/neighborhood.py
index 76a0a7d..9d82db3 100644
--- a/src/jarabe/model/neighborhood.py
+++ b/src/jarabe/model/neighborhood.py
@@ -387,8 +387,9 @@ class _Account(gobject.GObject):
if handle in self._buddy_handles:
presence_type, status_, message_ = presence
if presence_type == CONNECTION_PRESENCE_TYPE_OFFLINE:
+contact_id = self._buddy_handles[handle]
del self._buddy_handles[handle]
-self.emit('buddy-removed', handle)
+self.emit('buddy-removed', contact_id)
def __buddy_info_updated_cb(self, handle, properties):
logging.debug('_Account.__buddy_info_updated_cb %r', handle)
--
1.7.2.3
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Pass the contact-id to the buddy-removed signal instead of the handle #2349
Excerpts from Tomeu Vizoso's message of Mon Sep 20 14:56:04 +0200 2010: --- Would have been nice to note that this is a regression and callers expect the contact_id instead of the handle. At first I was worried that this might break other code, but the patch actually makes the listeners work again. Reviewed-By: Sascha Silbe sascha-...@silbe.org Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
