Re: [Sugar-devel] [PATCH PaintActivity] Paint - Rect. Marquee icon changes erratically(OLPC #5882)

2010-10-18 Thread Gonzalo Odiard
I thing is better do:

 if self.tool['name'] in cursors:
 name = cursors[self.tool['name']]
 cursor = gtk.gdk.cursor_new_from_name(display, name)
+elif tool['name'] == 'marquee-rectangular':
+cursor = gtk.gdk.Cursor(gtk.gdk.TCROSS)
 else:
 filename = os.path.join('images', tool['name'] + '.png')
 pixbuf = gtk.gdk.pixbuf_new_from_file(filename)

Can you change it and attach the patch in the ticket?
Thanks

Gonzalo


On Thu, Oct 14, 2010 at 4:26 PM, anub...@seeta.in wrote:

 From: Anubhav Aggarwal anub...@seeta.in

 Earlier the cursor shown on selcting using rectangular marquee, was either
 a
 rectangle with a dashed border or a cross-hairs.Now a if condition has been
 added .
 ---
  Area.py |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

 diff --git a/Area.py b/Area.py
 index 2dca7da..5cbee4c 100644
 --- a/Area.py
 +++ b/Area.py
 @@ -1131,6 +1131,8 @@ class Area(gtk.DrawingArea):
 filename = os.path.join('images', tool['name'] + '.png')
 pixbuf = gtk.gdk.pixbuf_new_from_file(filename)
 cursor = gtk.gdk.Cursor(display, pixbuf, 6, 21)
 +if tool['name'] == 'marquee-rectangular':
 +cursor = gtk.gdk.Cursor(gtk.gdk.TCROSS)
 except gobject.GError:
 cursor = None

 --
 1.7.0.4




-- 
Gonzalo Odiard
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


[Sugar-devel] [PATCH PaintActivity] Paint - Rect. Marquee icon changes erratically(OLPC #5882)

2010-10-14 Thread anubhav
From: Anubhav Aggarwal anub...@seeta.in

Earlier the cursor shown on selcting using rectangular marquee, was either a
rectangle with a dashed border or a cross-hairs.Now a if condition has been
added .
---
 Area.py |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Area.py b/Area.py
index 2dca7da..5cbee4c 100644
--- a/Area.py
+++ b/Area.py
@@ -1131,6 +1131,8 @@ class Area(gtk.DrawingArea):
 filename = os.path.join('images', tool['name'] + '.png')
 pixbuf = gtk.gdk.pixbuf_new_from_file(filename)
 cursor = gtk.gdk.Cursor(display, pixbuf, 6, 21)
+if tool['name'] == 'marquee-rectangular':
+cursor = gtk.gdk.Cursor(gtk.gdk.TCROSS)
 except gobject.GError:
 cursor = None
 
-- 
1.7.0.4

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel