Re: [Sugar-devel] [PATCH sugar] Do not cache the buddy palette in friends tray, SL #3108

2011-09-20 Thread Simon Schampijer 

On 09/19/2011 02:21 PM, Simon Schampijer wrote:

Make the palette on demand as well

Signed-off-by: Simon Schampijersi...@laptop.org


Pushed as: 
http://git.sugarlabs.org/sugar/mainline/commit/069eada75f23398b227affd5252e1408260ca354


Thanks to Gonzalo for testing, Marco for reviewing and Sascha for 
ack'ing (irc).


Regards,
   Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [PATCH sugar] Do not cache the buddy palette in friends tray, SL #3108

2011-09-19 Thread Simon Schampijer 
Make the palette on demand as well

Signed-off-by: Simon Schampijer si...@laptop.org
---
 src/jarabe/frame/friendstray.py |   11 ---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/jarabe/frame/friendstray.py b/src/jarabe/frame/friendstray.py
index 4055340..ee5f815 100644
--- a/src/jarabe/frame/friendstray.py
+++ b/src/jarabe/frame/friendstray.py
@@ -30,10 +30,15 @@ class FriendIcon(TrayIcon):
 TrayIcon.__init__(self, icon_name='computer-xo',
   xo_color=buddy.get_color())
 
+self._buddy = buddy
 self.set_palette_invoker(FrameWidgetInvoker(self))
-self.palette = BuddyMenu(buddy)
-self.palette.props.icon_visible = False
-self.palette.set_group_id('frame')
+#self.palette_invoker.cache_palette = False
+
+def create_palette(self):
+palette = BuddyMenu(self._buddy)
+palette.props.icon_visible = False
+palette.set_group_id('frame')
+return palette
 
 
 class FriendsTray(VTray):
-- 
1.7.4.4

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar] Do not cache the buddy palette in friends tray, SL #3108

2011-09-19 Thread Marco Pesenti Gritti 
On 19 September 2011 12:59, Simon Schampijer si...@schampijer.de wrote:
 +        #self.palette_invoker.cache_palette = False

Leftover?

Looks good to me otherwise.

Marco
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [PATCH sugar] Do not cache the buddy palette in friends tray, SL #3108

2011-09-19 Thread Simon Schampijer 
Make the palette on demand as well

Signed-off-by: Simon Schampijer si...@laptop.org
---
 src/jarabe/frame/friendstray.py |   11 ---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/jarabe/frame/friendstray.py b/src/jarabe/frame/friendstray.py
index 4055340..26a279b 100644
--- a/src/jarabe/frame/friendstray.py
+++ b/src/jarabe/frame/friendstray.py
@@ -30,10 +30,15 @@ class FriendIcon(TrayIcon):
 TrayIcon.__init__(self, icon_name='computer-xo',
   xo_color=buddy.get_color())
 
+self._buddy = buddy
 self.set_palette_invoker(FrameWidgetInvoker(self))
-self.palette = BuddyMenu(buddy)
-self.palette.props.icon_visible = False
-self.palette.set_group_id('frame')
+self.palette_invoker.cache_palette = False
+
+def create_palette(self):
+palette = BuddyMenu(self._buddy)
+palette.props.icon_visible = False
+palette.set_group_id('frame')
+return palette
 
 
 class FriendsTray(VTray):
-- 
1.7.4.4

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar] Do not cache the buddy palette in friends tray, SL #3108

2011-09-19 Thread Simon Schampijer 

On 09/19/2011 02:17 PM, Marco Pesenti Gritti wrote:

On 19 September 2011 12:59, Simon Schampijersi...@schampijer.de  wrote:

+#self.palette_invoker.cache_palette = False


Leftover?

Looks good to me otherwise.

Marco


Outch, was a leftover from testing. We need to set the non-caching 
property of course. Send a new patch.


Thanks for the review,
   Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel