Re: [Sugar-devel] [PATCH sugar-artwork] Remove unused CFLAGS and LIBS
On Mon, Aug 23, 2010 at 8:38 AM, Tomeu Vizoso wrote: > On Sun, Aug 22, 2010 at 02:04, wrote: >> From: Marco Pesenti Gritti >> >> --- >> configure.ac | 5 - >> 1 files changed, 0 insertions(+), 5 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index 3ade698..f92776d 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -25,11 +25,6 @@ fi >> PKG_CHECK_MODULES(GTK2, gtk+-2.0 >= 2.0.0,, >> AC_MSG_ERROR([GTK+-2.0 is required to compile >> sugar-artwork])) >> >> -GDK_PIXBUF2_CFLAGS=`$PKG_CONFIG --cflags gdk-pixbuf-2.0` >> -GDK_PIXBUF2_LIBS=`$PKG_CONFIG --libs gdk-pixbuf-2.0` >> -AC_SUBST(GDK_PIXBUF2_CFLAGS) >> -AC_SUBST(GDK_PIXBUF2_LIBS) >> - > > Hasn't gdk-pixbuf2 been split again from gtk+ since the next stable > release (2.22)? Not sure, but the variables here are not used anyway, so afaict they can do no good. > Btw, may be good to CC Benjamin, I'm not sure he reads the ml regularly. Thanks. Marco ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar-artwork] Remove unused CFLAGS and LIBS
On Sun, Aug 22, 2010 at 02:04, wrote: > From: Marco Pesenti Gritti > > --- > configure.ac | 5 - > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 3ade698..f92776d 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -25,11 +25,6 @@ fi > PKG_CHECK_MODULES(GTK2, gtk+-2.0 >= 2.0.0,, > AC_MSG_ERROR([GTK+-2.0 is required to compile > sugar-artwork])) > > -GDK_PIXBUF2_CFLAGS=`$PKG_CONFIG --cflags gdk-pixbuf-2.0` > -GDK_PIXBUF2_LIBS=`$PKG_CONFIG --libs gdk-pixbuf-2.0` > -AC_SUBST(GDK_PIXBUF2_CFLAGS) > -AC_SUBST(GDK_PIXBUF2_LIBS) > - Hasn't gdk-pixbuf2 been split again from gtk+ since the next stable release (2.22)? Btw, may be good to CC Benjamin, I'm not sure he reads the ml regularly. Regards, Tomeu > PKG_CHECK_MODULES(ENGINE, gtk+-2.0 >= 2.0 gobject-2.0 >= 2.0 cairo >= 0.1.1) > > GTK_VERSION=`$PKG_CONFIG --variable=gtk_binary_version gtk+-2.0` > -- > 1.7.0.4 > > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH sugar-artwork] Remove unused CFLAGS and LIBS
From: Marco Pesenti Gritti --- configure.ac |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 3ade698..f92776d 100644 --- a/configure.ac +++ b/configure.ac @@ -25,11 +25,6 @@ fi PKG_CHECK_MODULES(GTK2, gtk+-2.0 >= 2.0.0,, AC_MSG_ERROR([GTK+-2.0 is required to compile sugar-artwork])) -GDK_PIXBUF2_CFLAGS=`$PKG_CONFIG --cflags gdk-pixbuf-2.0` -GDK_PIXBUF2_LIBS=`$PKG_CONFIG --libs gdk-pixbuf-2.0` -AC_SUBST(GDK_PIXBUF2_CFLAGS) -AC_SUBST(GDK_PIXBUF2_LIBS) - PKG_CHECK_MODULES(ENGINE, gtk+-2.0 >= 2.0 gobject-2.0 >= 2.0 cairo >= 0.1.1) GTK_VERSION=`$PKG_CONFIG --variable=gtk_binary_version gtk+-2.0` -- 1.7.0.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
