Excerpts from Ishan Bansal's message of Thu Sep 30 18:58:06 +0200 2010: > New symbols "×", "÷" and "=" (instead of "*","/" and "Enter" respectively) > defined for the calculator activity in order to give a calculator look to > activity.
No need to mention "the calculator activity" as there's nothing else in
this repository.
Please adjust the summary as well.
> v1 was Reviewed-By Sascha Silbe <sascha-ml-reply-to-201...@silbe.org>
Not really. I reviewed it, but since there were things I wanted to be
changed, I did not "grant" my Reviewed-By: tag. The meaning of that
tag is that I reviewed the patch _and_ believe it to be fit for
inclusion, standing with my reputation behind that judgement (see [1],
section 14).
> v1->v2: Symbol for "x" changed to "×"and bug description changed.
Thanks!
[layout.py]
> - [3, 3, 3, _('Enter'), self.col_gray1, lambda w:
> self._parent.process()],
> + [3, 3, 3, ('='), self.col_gray1, lambda w:
> self._parent.process()],
I just noticed (see below) that we translate the other symbols, so we
should do the same for =. Since I don't know whether there's a reason
for using names (mul_sym / div_sym) instead of the symbols (previously
* and /) for translation, we should use a name for '=' just to be on the
safe side. So please translate '=' the same way the multiplication and
division symbols are translated.
[mathlib.py]
> # TRANS: multiplication symbol (default: '*')
> self.mul_sym = _('mul_sym')
[...]
> # TRANS: division symbol (default: '/')
> self.div_sym = _('div_sym')
Ah, it always pays to give things a second look. ;)
Please adjust these comments as well.
Sascha
[1] http://www.kernel.org/doc/Documentation/SubmittingPatches
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
signature.asc
Description: PGP signature
_______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
