Re: [Sugar-devel] [PATCHv2] Title for 'Rectangualar Marquee' tool changed to 'Select Area'

2010-10-14 Thread Ayush Goyal 

 Gonzalo,

Thanks for your recommendations. I have revised the patch, made the 
changes and resent it again using git send-mail. Please review it.


Regards,
Ayush

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCHv2] Title for 'Rectangualar Marquee' tool changed to 'Select Area'

2010-10-14 Thread Gonzalo Odiard 
In the first line of the header of the patch  you must put the ticket
associated.
We have two different trac instances, then we put SL in the tickets from
bugs.sugarlabs.org and OLPC in the tickets from dev.laptop.org
In this case, the first line will be anything like "fix SL #2266 -
'Retangular Marquee' is not descriptive in English as a title for the
Selection area tool".
Then a blank line and your explanation.
Also you must send your patch with git send-mail or attach the patch,
because i can't commit the patch like is in your mail. git does not accept
it.
Many mail clients corrupt the patch created with git.
Try again :)
May be a little difficult the first time, but the later will be easier :)

Gonzalo


On Wed, Oct 13, 2010 at 1:50 PM, Ayush Goyal  wrote:

> The select tool is less than optimally discoverable in English because
> of the name 'Rectangular Marquee'.  The name is changed to 'Select
> Area'.
>
> Signed-off-by: Ayush Goyal 
> ---
>  toolbox.py |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/toolbox.py b/toolbox.py
> index 90f664d..299181b 100644
> --- a/toolbox.py
> +++ b/toolbox.py
> @@ -434,7 +434,7 @@ class ToolsToolbar(gtk.Toolbar):
>
> """
>
> -self._tool_marquee_rectangular =
> DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Rectangular
> Marquee'))
> +self._tool_marquee_rectangular =
> DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Select
> Area'))
> self.insert(self._tool_marquee_rectangular, -1)
> try:
> self._configure_palette(self._tool_marquee_rectangular,
> self._TOOL_MARQUEE_RECTANGULAR)
> --
> 1.7.1
>
>


-- 
Gonzalo Odiard
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCHv2] Title for 'Rectangualar Marquee' tool changed to 'Select Area'

2010-10-14 Thread Sascha Silbe 
Excerpts from Ayush Goyal's message of Wed Oct 13 18:50:00 +0200 2010:

> The select tool is less than optimally discoverable in English because
> of the name 'Rectangular Marquee'.  The name is changed to 'Select
> Area'.
[...]

Please mention the name of the module (activity in this case) the patch
is aimed for as a tag in the subject line, e.g. [PATCH v2 FooActivity].
Even the diff chunk headers don't give a hint this time.

Sascha

--
http://sascha.silbe.org/
http://www.infra-silbe.de/


signature.asc
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [PATCHv2] Title for 'Rectangualar Marquee' tool changed to 'Select Area'

2010-10-13 Thread Ayush Goyal 
The select tool is less than optimally discoverable in English because
of the name 'Rectangular Marquee'.  The name is changed to 'Select
Area'.

Signed-off-by: Ayush Goyal 
---
 toolbox.py |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/toolbox.py b/toolbox.py
index 90f664d..299181b 100644
--- a/toolbox.py
+++ b/toolbox.py
@@ -434,7 +434,7 @@ class ToolsToolbar(gtk.Toolbar):
 
 """
 
-self._tool_marquee_rectangular = 
DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Rectangular 
Marquee'))
+self._tool_marquee_rectangular = 
DrawToolButton('tool-marquee-rectangular',activity.tool_group,_('Select Area'))
 self.insert(self._tool_marquee_rectangular, -1)
 try:
 self._configure_palette(self._tool_marquee_rectangular, 
self._TOOL_MARQUEE_RECTANGULAR)
-- 
1.7.1

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel