Re: [Sugar-devel] Broken build, terminal
On 05/31/2013 09:39 AM, Daniel Narvaez wrote: Hello, the build is still broken because of this issue. Can we please fix or revert asap? Build bugs should be fixed with the highest priority because they affects everyone, not just your activity. Pushed a tmp-workaround to get the build going: https://git.sugarlabs.org/terminal/mainline/commit/951ebb574bff05b37810b4bfd779a57e8f29f230 However, we still see a segfault on F18 when the activity is closing [1]. The fix needs latest vte. Also it needs gobject-introspection .1.36 and pygobject3 3.8.1 to work, those are in Fedora 19 already. Simon [1] http://fpaste.org/15739/13699988/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Broken build, terminal
On Fri, May 31, 2013 at 12:58 PM, Simon Schampijer si...@schampijer.de wrote: On 05/31/2013 09:39 AM, Daniel Narvaez wrote: Hello, the build is still broken because of this issue. Can we please fix or revert asap? Build bugs should be fixed with the highest priority because they affects everyone, not just your activity. Pushed a tmp-workaround to get the build going: https://git.sugarlabs.org/terminal/mainline/commit/951ebb574bff05b37810b4bfd779a57e8f29f230 However, we still see a segfault on F18 when the activity is closing [1]. The fix needs latest vte. Also it needs gobject-introspection .1.36 and pygobject3 3.8.1 to work, those are in Fedora 19 already. Latest vte being which version? Is 0.34.5 enough? pygobject3 3.8.x will only ever land in F-19+ so we'd need a back port I suspect. Peter ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Broken build, terminal
Back green. Thanks a lot Simon for taking care of this. On Friday, 31 May 2013, Simon Schampijer wrote: On 05/31/2013 09:39 AM, Daniel Narvaez wrote: Hello, the build is still broken because of this issue. Can we please fix or revert asap? Build bugs should be fixed with the highest priority because they affects everyone, not just your activity. Pushed a tmp-workaround to get the build going: https://git.sugarlabs.org/**terminal/mainline/commit/** 951ebb574bff05b37810b4bfd779a5**7e8f29f230https://git.sugarlabs.org/terminal/mainline/commit/951ebb574bff05b37810b4bfd779a57e8f29f230 However, we still see a segfault on F18 when the activity is closing [1]. The fix needs latest vte. Also it needs gobject-introspection .1.36 and pygobject3 3.8.1 to work, those are in Fedora 19 already. Simon [1] http://fpaste.org/15739/**13699988/http://fpaste.org/15739/13699988/ -- Daniel Narvaez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] Broken build, terminal
Traceback (most recent call last): File /home/buildbot/slave/raring-amd64-quick/build/build/out/install/lib/python2.7/site-packages/sugar3/activity/activity.py, line 906, in _prepare_close self.save() File /home/buildbot/slave/raring-amd64-quick/build/build/out/install/lib/python2.7/site-packages/sugar3/activity/activity.py, line 740, in save self.write_file(file_path) File /home/buildbot/slave/raring-amd64-quick/build/build/out/install/share/sugar/activities/Terminal.activity/terminal.py, line 424, in write_file text, attr = page.vt.get_text(is_selected, None) AttributeError: 'Terminal' object has no attribute 'get_text' Caused by commit b90dac1ad2b8916b123e71b73848636f83fa9fe7 Author: Simon Schampijer si...@laptop.org Date: Sat Nov 3 15:17:09 2012 +0100 Get back a working activity history, SL #4131 It breaks on Debian and Ubuntu, it works on Fedora 18 and 19. I guess it's either a Fedora patch or a more recent libvte required? I'd prefer to change the code to work also with old/unpatched libvte then to add a new module to the build for Ubuntu and Debian. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Broken build, terminal
On 05/30/2013 11:14 AM, Daniel Narvaez wrote: Traceback (most recent call last): File /home/buildbot/slave/raring-amd64-quick/build/build/out/install/lib/python2.7/site-packages/sugar3/activity/activity.py, line 906, in _prepare_close self.save() File /home/buildbot/slave/raring-amd64-quick/build/build/out/install/lib/python2.7/site-packages/sugar3/activity/activity.py, line 740, in save self.write_file(file_path) File /home/buildbot/slave/raring-amd64-quick/build/build/out/install/share/sugar/activities/Terminal.activity/terminal.py, line 424, in write_file text, attr = page.vt.get_text(is_selected, None) AttributeError: 'Terminal' object has no attribute 'get_text' Caused by commit b90dac1ad2b8916b123e71b73848636f83fa9fe7 Author: Simon Schampijer si...@laptop.org Date: Sat Nov 3 15:17:09 2012 +0100 Get back a working activity history, SL #4131 It breaks on Debian and Ubuntu, it works on Fedora 18 and 19. I guess it's either a Fedora patch or a more recent libvte required? I'd prefer to change the code to work also with old/unpatched libvte then to add a new module to the build for Ubuntu and Debian. http://bugs.sugarlabs.org/ticket/4131 should point to the upstream fix. And state which upstream has the fix. Which version etc. Gonzalo, can you put some light on it. The upstream ticket was [1]. Simon [1] https://bugzilla.gnome.org/show_bug.cgi?id=676999 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Broken build, terminal
The upstream bug seems to have no activity? https://bugzilla.gnome.org/show_bug.cgi?id=690610 On 30 May 2013 11:40, Simon Schampijer si...@schampijer.de wrote: On 05/30/2013 11:14 AM, Daniel Narvaez wrote: Traceback (most recent call last): File /home/buildbot/slave/raring-**amd64-quick/build/build/out/** install/lib/python2.7/site-**packages/sugar3/activity/**activity.py, line 906, in _prepare_close self.save() File /home/buildbot/slave/raring-**amd64-quick/build/build/out/** install/lib/python2.7/site-**packages/sugar3/activity/**activity.py, line 740, in save self.write_file(file_path) File /home/buildbot/slave/raring-**amd64-quick/build/build/out/** install/share/sugar/**activities/Terminal.activity/**terminal.py, line 424, in write_file text, attr = page.vt.get_text(is_selected, None) AttributeError: 'Terminal' object has no attribute 'get_text' Caused by commit b90dac1ad2b8916b123e71b7384863**6f83fa9fe7 Author: Simon Schampijer si...@laptop.org Date: Sat Nov 3 15:17:09 2012 +0100 Get back a working activity history, SL #4131 It breaks on Debian and Ubuntu, it works on Fedora 18 and 19. I guess it's either a Fedora patch or a more recent libvte required? I'd prefer to change the code to work also with old/unpatched libvte then to add a new module to the build for Ubuntu and Debian. http://bugs.sugarlabs.org/**ticket/4131http://bugs.sugarlabs.org/ticket/4131should point to the upstream fix. And state which upstream has the fix. Which version etc. Gonzalo, can you put some light on it. The upstream ticket was [1]. Simon [1] https://bugzilla.gnome.org/**show_bug.cgi?id=676999https://bugzilla.gnome.org/show_bug.cgi?id=676999 __**_ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.**org Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/**listinfo/sugar-develhttp://lists.sugarlabs.org/listinfo/sugar-devel -- Daniel Narvaez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Broken build, terminal
On 05/30/2013 12:00 PM, Daniel Narvaez wrote: The upstream bug seems to have no activity? https://bugzilla.gnome.org/show_bug.cgi?id=690610 Right, that is why I have no clue what fix Gonzalo means. Anyhow, he will let us know. Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Broken build, terminal
I have closed #690610, because my test case was wrong. The fix is in vte #676999 and pygobject #690041, but also can needed other fixes in the management of GArray in pygobject. I don't know what is the state of these libraries on debian and ubuntu, but can imagine the terminal maintainer will accept a patch to avoid the error if the feature is not available. Probably safer do a try catch, because the method can be available, but non working depending on the libraries state. Gonzalo On Thu, May 30, 2013 at 7:25 AM, Simon Schampijer si...@schampijer.dewrote: On 05/30/2013 12:00 PM, Daniel Narvaez wrote: The upstream bug seems to have no activity? https://bugzilla.gnome.org/**show_bug.cgi?id=690610https://bugzilla.gnome.org/show_bug.cgi?id=690610 Right, that is why I have no clue what fix Gonzalo means. Anyhow, he will let us know. Simon __**_ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.**org Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/**listinfo/sugar-develhttp://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Broken build, terminal
On 30 May 2013 14:11, Gonzalo Odiard gonz...@laptop.org wrote: I have closed #690610, because my test case was wrong. The fix is in vte #676999 and pygobject #690041, but also can needed other fixes in the management of GArray in pygobject. I don't know what is the state of these libraries on debian and ubuntu, but can imagine the terminal maintainer will accept a patch to avoid the error if the feature is not available. Probably safer do a try catch, because the method can be available, but non working depending on the libraries state. Yeah please add a try/catch or revert the patch until we have a fix that doesn't break the build. Thanks. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Broken build, terminal
Not if I understand what you say, but from what I see, the error is in the get_text of Vte.Terminal. That function does not exist for that object. If this is the error to be corrected, you can get the text in the terminal using the clipboard as follows: terminal.select_all() terminal.copy_clipboard() To do the opposite: terminal.paste_clipboard() 2013/5/30 Gonzalo Odiard gonz...@laptop.org I have closed #690610, because my test case was wrong. The fix is in vte #676999 and pygobject #690041, but also can needed other fixes in the management of GArray in pygobject. I don't know what is the state of these libraries on debian and ubuntu, but can imagine the terminal maintainer will accept a patch to avoid the error if the feature is not available. Probably safer do a try catch, because the method can be available, but non working depending on the libraries state. Gonzalo On Thu, May 30, 2013 at 7:25 AM, Simon Schampijer si...@schampijer.dewrote: On 05/30/2013 12:00 PM, Daniel Narvaez wrote: The upstream bug seems to have no activity? https://bugzilla.gnome.org/**show_bug.cgi?id=690610https://bugzilla.gnome.org/show_bug.cgi?id=690610 Right, that is why I have no clue what fix Gonzalo means. Anyhow, he will let us know. Simon __**_ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.**org Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/**listinfo/sugar-develhttp://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] Broken build, terminal
And that will not appear as a icon in the sugar frame? I think now we should do the try catch, until debian updates the libraries. Gonzalo On Thu, May 30, 2013 at 9:28 AM, Flavio Danesse fdane...@gmail.com wrote: Not if I understand what you say, but from what I see, the error is in the get_text of Vte.Terminal. That function does not exist for that object. If this is the error to be corrected, you can get the text in the terminal using the clipboard as follows: terminal.select_all() terminal.copy_clipboard() To do the opposite: terminal.paste_clipboard() 2013/5/30 Gonzalo Odiard gonz...@laptop.org I have closed #690610, because my test case was wrong. The fix is in vte #676999 and pygobject #690041, but also can needed other fixes in the management of GArray in pygobject. I don't know what is the state of these libraries on debian and ubuntu, but can imagine the terminal maintainer will accept a patch to avoid the error if the feature is not available. Probably safer do a try catch, because the method can be available, but non working depending on the libraries state. Gonzalo On Thu, May 30, 2013 at 7:25 AM, Simon Schampijer si...@schampijer.dewrote: On 05/30/2013 12:00 PM, Daniel Narvaez wrote: The upstream bug seems to have no activity? https://bugzilla.gnome.org/**show_bug.cgi?id=690610https://bugzilla.gnome.org/show_bug.cgi?id=690610 Right, that is why I have no clue what fix Gonzalo means. Anyhow, he will let us know. Simon __**_ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.**org Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/**listinfo/sugar-develhttp://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
