Re: [Sugar-devel] SL bug #1520
On Tue, 2010-09-21 at 20:50 +0200, Sascha Silbe wrote: Excerpts from Mukul Gupta's message of Tue Sep 21 20:06:11 +0200 2010: I had a word with Bernie regarding the issue and he says that probably newer versions of the X server actually implement XUngrabKey() with keycode= Any Key as specified in the man-page. He said he had seen the source code and someone (whot) reworked that function sometime back, probably fixing up the bug. What component (package) is that in and which version fixed it? Or which source file and function contains the change so I can try scanning the repo? The X server itself. Grep around for UngrabKeys. Once you've found the file, use git blame. The last person touching that function was, unsurprisingly, Peter Hutterer (whot). -- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL bug #1520
On Tue, Sep 21, 2010 at 20:50, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: Excerpts from Mukul Gupta's message of Tue Sep 21 20:06:11 +0200 2010: I had a word with Bernie regarding the issue and he says that probably newer versions of the X server actually implement XUngrabKey() with keycode= Any Key as specified in the man-page. He said he had seen the source code and someone (whot) reworked that function sometime back, probably fixing up the bug. What component (package) is that in and which version fixed it? Or which source file and function contains the change so I can try scanning the repo? The most relevant changes I have found are: commit ff1d6244eba8367a8d50601ca393e951c60c94b6 Author: Peter Hutterer peter.hutte...@who-t.net Date: Mon Jun 1 12:14:52 2009 +1000 input: add support for XIAnyModifier in passive XI2 grabs. commit 80ea32ad4f1440d068e18db65830f45498703b09 Author: Peter Hutterer peter.hutte...@who-t.net Date: Mon Jun 1 12:06:55 2009 +1000 dix: switch grab checking from unsigned shorts to unsigned ints XIAnyModifier is outside of the unsigned short range. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Regards, Tomeu Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL bug #1520
Tomeu, I had a word with Bernie regarding the issue and he says that probably newer versions of the X server actually implement XUngrabKey() with keycode= Any Key as specified in the man-page. He said he had seen the source code and someone (whot) reworked that function sometime back, probably fixing up the bug. I tested sugar-emulator on Ubuntu Maverick and it seemed the keybindings were working. I tried Alt+ Tab and it worked. It seems the component has already been fixed. Regards, Mukul Gupta Research Engineer, SEETA On Tue, Sep 14, 2010 at 1:11 PM, Tomeu Vizoso to...@sugarlabs.org wrote: On Fri, Sep 10, 2010 at 18:07, Mukul Gupta mu...@seeta.in wrote: Hi, The patch is a temporary fix. According to Bernie,some other component is broken(X server?) and this is just a work around. Ok, it would be very helpful to know which other component is broken and in which way. However, I have filed a bug at gnome-bugzilla ( https://bugzilla.gnome.org/show_bug.cgi?id=629210#c0 ) regarding the same. Note that in GNOME they use a different patch submission process: http://live.gnome.org/Git/Developers#Contributing_patches Basically, you don't put r* flags and use instead the Status combo in the Details page for the patch. Regards, Tomeu Regards, Tomeu Regards, Mukul On Fri, Sep 10, 2010 at 2:27 PM, Tomeu Vizoso to...@sugarlabs.org wrote: On Wed, Sep 8, 2010 at 11:15, Tomeu Vizoso to...@sugarlabs.org wrote: On Tue, Sep 7, 2010 at 20:01, Mukul Gupta mu...@seeta.in wrote: Team, I am working on Bug # 1520 on sugarlabs. http://bugs.sugarlabs.org/ticket/1520 I tried to reproduce the issue on sugar-emulator. I realised that Alt + Tab did nothing. Instead, Alt+Tab functioned for GNOME. I tried to run sugar from sugar-session. Still, Alt+ Tab did nothing. Firstly, I would require some pointers on how to reproduce the bug. Secondly, when I read the comments on the bugs page, I realised that fran pointed out that this functioning of the Alt+Tab as mentioned in the bug can also be considered as a utility rather than a bug. A very similar bug to bug #1520 is #1518. http://bugs.sugarlabs.org/ticket/1518 As far as solving the current bug is concerned I realised that Bernie had created a patch for the same in fedora and that could be implemented on ubuntu. I have studied the patch - http://sascha.silbe.org/patches/metacity-ungrab-keybindings.patch Should this patch go upstream? Ping, the metacity maintainer has shown interest but wants to give it a good deal of testing before pushing and has requested a bug to be filed. I just want to know if this patch is considered a proper fix that can go upstream. Regards, Tomeu Regards, Tomeu Regards, Mukul Gupta Research Engineer, SEETA ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL bug #1520
Excerpts from Mukul Gupta's message of Tue Sep 21 20:06:11 +0200 2010: I had a word with Bernie regarding the issue and he says that probably newer versions of the X server actually implement XUngrabKey() with keycode= Any Key as specified in the man-page. He said he had seen the source code and someone (whot) reworked that function sometime back, probably fixing up the bug. What component (package) is that in and which version fixed it? Or which source file and function contains the change so I can try scanning the repo? Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL bug #1520
On Fri, Sep 10, 2010 at 18:07, Mukul Gupta mu...@seeta.in wrote: Hi, The patch is a temporary fix. According to Bernie,some other component is broken(X server?) and this is just a work around. Ok, it would be very helpful to know which other component is broken and in which way. However, I have filed a bug at gnome-bugzilla ( https://bugzilla.gnome.org/show_bug.cgi?id=629210#c0 ) regarding the same. Note that in GNOME they use a different patch submission process: http://live.gnome.org/Git/Developers#Contributing_patches Basically, you don't put r* flags and use instead the Status combo in the Details page for the patch. Regards, Tomeu Regards, Tomeu Regards, Mukul On Fri, Sep 10, 2010 at 2:27 PM, Tomeu Vizoso to...@sugarlabs.org wrote: On Wed, Sep 8, 2010 at 11:15, Tomeu Vizoso to...@sugarlabs.org wrote: On Tue, Sep 7, 2010 at 20:01, Mukul Gupta mu...@seeta.in wrote: Team, I am working on Bug # 1520 on sugarlabs. http://bugs.sugarlabs.org/ticket/1520 I tried to reproduce the issue on sugar-emulator. I realised that Alt + Tab did nothing. Instead, Alt+Tab functioned for GNOME. I tried to run sugar from sugar-session. Still, Alt+ Tab did nothing. Firstly, I would require some pointers on how to reproduce the bug. Secondly, when I read the comments on the bugs page, I realised that fran pointed out that this functioning of the Alt+Tab as mentioned in the bug can also be considered as a utility rather than a bug. A very similar bug to bug #1520 is #1518. http://bugs.sugarlabs.org/ticket/1518 As far as solving the current bug is concerned I realised that Bernie had created a patch for the same in fedora and that could be implemented on ubuntu. I have studied the patch - http://sascha.silbe.org/patches/metacity-ungrab-keybindings.patch Should this patch go upstream? Ping, the metacity maintainer has shown interest but wants to give it a good deal of testing before pushing and has requested a bug to be filed. I just want to know if this patch is considered a proper fix that can go upstream. Regards, Tomeu Regards, Tomeu Regards, Mukul Gupta Research Engineer, SEETA ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL bug #1520
On Wed, Sep 8, 2010 at 11:15, Tomeu Vizoso to...@sugarlabs.org wrote: On Tue, Sep 7, 2010 at 20:01, Mukul Gupta mu...@seeta.in wrote: Team, I am working on Bug # 1520 on sugarlabs. http://bugs.sugarlabs.org/ticket/1520 I tried to reproduce the issue on sugar-emulator. I realised that Alt + Tab did nothing. Instead, Alt+Tab functioned for GNOME. I tried to run sugar from sugar-session. Still, Alt+ Tab did nothing. Firstly, I would require some pointers on how to reproduce the bug. Secondly, when I read the comments on the bugs page, I realised that fran pointed out that this functioning of the Alt+Tab as mentioned in the bug can also be considered as a utility rather than a bug. A very similar bug to bug #1520 is #1518. http://bugs.sugarlabs.org/ticket/1518 As far as solving the current bug is concerned I realised that Bernie had created a patch for the same in fedora and that could be implemented on ubuntu. I have studied the patch - http://sascha.silbe.org/patches/metacity-ungrab-keybindings.patch Should this patch go upstream? Ping, the metacity maintainer has shown interest but wants to give it a good deal of testing before pushing and has requested a bug to be filed. I just want to know if this patch is considered a proper fix that can go upstream. Regards, Tomeu Regards, Tomeu Regards, Mukul Gupta Research Engineer, SEETA ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL bug #1520
Hi, The patch is a temporary fix. According to Bernie,some other component is broken(X server?) and this is just a work around. However, I have filed a bug at gnome-bugzilla ( https://bugzilla.gnome.org/show_bug.cgi?id=629210#c0 ) regarding the same. Regards, Mukul On Fri, Sep 10, 2010 at 2:27 PM, Tomeu Vizoso to...@sugarlabs.org wrote: On Wed, Sep 8, 2010 at 11:15, Tomeu Vizoso to...@sugarlabs.org wrote: On Tue, Sep 7, 2010 at 20:01, Mukul Gupta mu...@seeta.in wrote: Team, I am working on Bug # 1520 on sugarlabs. http://bugs.sugarlabs.org/ticket/1520 I tried to reproduce the issue on sugar-emulator. I realised that Alt + Tab did nothing. Instead, Alt+Tab functioned for GNOME. I tried to run sugar from sugar-session. Still, Alt+ Tab did nothing. Firstly, I would require some pointers on how to reproduce the bug. Secondly, when I read the comments on the bugs page, I realised that fran pointed out that this functioning of the Alt+Tab as mentioned in the bug can also be considered as a utility rather than a bug. A very similar bug to bug #1520 is #1518. http://bugs.sugarlabs.org/ticket/1518 As far as solving the current bug is concerned I realised that Bernie had created a patch for the same in fedora and that could be implemented on ubuntu. I have studied the patch - http://sascha.silbe.org/patches/metacity-ungrab-keybindings.patch Should this patch go upstream? Ping, the metacity maintainer has shown interest but wants to give it a good deal of testing before pushing and has requested a bug to be filed. I just want to know if this patch is considered a proper fix that can go upstream. Regards, Tomeu Regards, Tomeu Regards, Mukul Gupta Research Engineer, SEETA ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL bug #1520
On Tue, Sep 7, 2010 at 20:01, Mukul Gupta mu...@seeta.in wrote: Team, I am working on Bug # 1520 on sugarlabs. http://bugs.sugarlabs.org/ticket/1520 I tried to reproduce the issue on sugar-emulator. I realised that Alt + Tab did nothing. Instead, Alt+Tab functioned for GNOME. I tried to run sugar from sugar-session. Still, Alt+ Tab did nothing. Firstly, I would require some pointers on how to reproduce the bug. Secondly, when I read the comments on the bugs page, I realised that fran pointed out that this functioning of the Alt+Tab as mentioned in the bug can also be considered as a utility rather than a bug. A very similar bug to bug #1520 is #1518. http://bugs.sugarlabs.org/ticket/1518 As far as solving the current bug is concerned I realised that Bernie had created a patch for the same in fedora and that could be implemented on ubuntu. I have studied the patch - http://sascha.silbe.org/patches/metacity-ungrab-keybindings.patch Should this patch go upstream? Regards, Tomeu Regards, Mukul Gupta Research Engineer, SEETA ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] SL bug #1520
Team, I am working on Bug # 1520 on sugarlabs. http://bugs.sugarlabs.org/ticket/1520 I tried to reproduce the issue on sugar-emulator. I realised that Alt + Tab did nothing. Instead, Alt+Tab functioned for GNOME. I tried to run sugar from sugar-session. Still, Alt+ Tab did nothing. Firstly, I would require some pointers on how to reproduce the bug. Secondly, when I read the comments on the bugs page, I realised that fran pointed out that this functioning of the Alt+Tab as mentioned in the bug can also be considered as a utility rather than a bug. A very similar bug to bug #1520 is #1518. http://bugs.sugarlabs.org/ticket/1518 As far as solving the current bug is concerned I realised that Bernie had created a patch for the same in fedora and that could be implemented on ubuntu. I have studied the patch - http://sascha.silbe.org/patches/metacity-ungrab-keybindings.patch Regards, Mukul Gupta Research Engineer, SEETA ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] SL bug #1520
Bernie, I am working on SL #1520 - http://bugs.sugarlabs.org/ticket/1520 with Dipankar. We have identified the problem with reviews from Sascha and Tomeu. Appreciate your reviews and support. Sascha wrote that you have fixed this issue on Fedora. Can you please provide us the link for the patch so that we could study it, and expedite the process of fixing it in other distributions like Debian? Appreciate your support. Regards, Mukul ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] SL bug #1520
Excerpts from Mukul Gupta's message of Mon Sep 06 19:27:32 +0200 2010: [metacity disable-keybindings not working] Sascha wrote that you have fixed this issue on Fedora. Can you please provide us the link for the patch so that we could study it, and expedite the process of fixing it in other distributions like Debian? I already included the link to the patch in my mail. It might be easy to overlook if you're not used to citations in emails. Check below my greeting (but above the signature), the line starting with [1]. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
