Re: [Sugar-devel] [Feature Freeze] request for exception for Turtle Art

2009-09-21 Thread Tomeu Vizoso
On Sat, Sep 12, 2009 at 17:49, Walter Bender walter.ben...@gmail.com wrote:
 I made a somewhat invasive change to Turtle Art in order to make the
 toolbars backward compatible with Sugar 0.82-0.84. Essentially, I
 catch an exception when trying to create a ToolbarBox. In the
 exception handler, I create the old-style toolbars.

As discussed in IRC, this can be considered a regression fix, so no
exception is required.

Regards,

Tomeu

        try:
            # Use 0.86 toolbar design
            toolbar_box = ToolbarBox()


        except NameError:
            # Use pre-0.86 toolbar design
            self.toolbox = activity.ActivityToolbox(self)
            self.set_toolbox(self.toolbox)

 I had to add a new toolbar for the help menu in the old toolbar
 configuration since I had moved the hover help to a toolbar in the
 0.86 configuration:

            self.helpToolbar = HelpToolbar(self)
            self.toolbox.add_toolbar(_('Help'),self.helpToolbar)

 So I will request an exception for String Freeze as well.

 (I also did a work-around for a Rainbow-related bug with image save.)

 Changes are in:

 http://git.sugarlabs.org/projects/turtleart/repos/walters-clone

 -walter
 --
 Walter Bender
 Sugar Labs
 http://www.sugarlabs.org
 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel




-- 
«Sugar Labs is anyone who participates in improving and using Sugar.
What Sugar Labs does is determined by the participants.» - David
Farning
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [Feature Freeze] Request for exception for Turtle Art

2009-09-09 Thread Tomeu Vizoso
On Tue, Sep 8, 2009 at 16:18, Walter Benderwalter.ben...@gmail.com wrote:
 I updated Turtle Art to use the new toolbars (thanks for all the help,
 Simon) for which I would like an exception to the feature freeze. The
 source tarball is:

 http://download.sugarlabs.org/sources/sucrose/fructose/TurtleArt/TurtleArt-64.tar.bz2

+1 from me because new versions of TA is regularly tested by several
people and Walter is very responsive to reported bugs.

Thanks,

Tomeu

 Thank you fr your consideration.

 -walter

 --
 Walter Bender
 Sugar Labs
 http://www.sugarlabs.org
 ___
 Sugar-devel mailing list
 Sugar-devel@lists.sugarlabs.org
 http://lists.sugarlabs.org/listinfo/sugar-devel




-- 
«Sugar Labs is anyone who participates in improving and using Sugar.
What Sugar Labs does is determined by the participants.» - David
Farning
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [Feature Freeze] Request for exception for Turtle Art

2009-09-09 Thread Simon Schampijer
On 09/09/2009 11:40 AM, Tomeu Vizoso wrote:
 On Tue, Sep 8, 2009 at 16:18, Walter Benderwalter.ben...@gmail.com  wrote:
 I updated Turtle Art to use the new toolbars (thanks for all the help,
 Simon) for which I would like an exception to the feature freeze. The
 source tarball is:

 http://download.sugarlabs.org/sources/sucrose/fructose/TurtleArt/TurtleArt-64.tar.bz2

 +1 from me because new versions of TA is regularly tested by several
 people and Walter is very responsive to reported bugs.

 Thanks,

 Tomeu

Sounds good to me as well. We have an active maintainer and many testers.

Simon

PS: Next time better to wait with a release until the exception is 
handled. Easier to revert it then. You must have been too convinced we 
would accept :)
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [Feature Freeze] Request for exception for Turtle Art

2009-09-08 Thread Walter Bender
I managed to mess up the View Toolbar by accident. This version works:

http://download.sugarlabs.org/sources/sucrose/fructose/TurtleArt/TurtleArt-65.tar.bz2

On Tue, Sep 8, 2009 at 10:18 AM, Walter Benderwalter.ben...@gmail.com wrote:
 I updated Turtle Art to use the new toolbars (thanks for all the help,
 Simon) for which I would like an exception to the feature freeze. The
 source tarball is:

 http://download.sugarlabs.org/sources/sucrose/fructose/TurtleArt/TurtleArt-64.tar.bz2

 Thank you fr your consideration.

 -walter

 --
 Walter Bender
 Sugar Labs
 http://www.sugarlabs.org




-- 
Walter Bender
Sugar Labs
http://www.sugarlabs.org
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel