Re: [Sugar-devel] [PATCH sugar-artwork] Set notebook padding to 0px in the GTK3 CSS #3482

2012-04-26 Thread Simon Schampijer 

On 04/24/2012 06:40 PM, Manuel Quiñones wrote:

This removes the 2 pixel padding that was around all the notebook
page, preventing a confortable use of the scroll bar with the mouse
pointer, as #3482 describes.

Signed-off-by: Manuel Quiñonesma...@laptop.org
---
  gtk3/theme/gtk-widgets.css.em |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
index 6c823b6..dce2a58 100644
--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -279,7 +279,7 @@ SugarPaletteWindowWidget GtkToggleButton.button:active {

  .notebook {
  background-color: @selection_grey;
-border-width: 0px;
+padding: 0px;
  -GtkNotebook-tab-overlap: -2;
  -GtkNotebook-tab-curvature: $default_padding;
  }


Thanks Manuel, works great, pushed as 
http://git.sugarlabs.org/sugar-artwork/mainline/commit/0847edc8e37317fced59cbb1fc35709202ef1ad4


Thanks Anish for testing.

The Terminal has the same issue, we should do the same. I think it is 
fine to do (make sure) when we port Terminal to GTK-3, filed [1].


Regards,
   Simon

[1] http://bugs.sugarlabs.org/ticket/3529
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar-artwork] Set notebook padding to 0px in the GTK3 CSS #3482

2012-04-26 Thread Manuel Quiñones 
El día 26 de abril de 2012 11:25, Simon Schampijer
si...@schampijer.de escribió:
 On 04/24/2012 06:40 PM, Manuel Quiñones wrote:

 This removes the 2 pixel padding that was around all the notebook
 page, preventing a confortable use of the scroll bar with the mouse
 pointer, as #3482 describes.

 Signed-off-by: Manuel Quiñonesma...@laptop.org
 ---
  gtk3/theme/gtk-widgets.css.em |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

 diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
 index 6c823b6..dce2a58 100644
 --- a/gtk3/theme/gtk-widgets.css.em
 +++ b/gtk3/theme/gtk-widgets.css.em
 @@ -279,7 +279,7 @@ SugarPaletteWindowWidget GtkToggleButton.button:active
 {

  .notebook {
      background-color: @selection_grey;
 -    border-width: 0px;
 +    padding: 0px;
      -GtkNotebook-tab-overlap: -2;
      -GtkNotebook-tab-curvature: $default_padding;
  }


 Thanks Manuel, works great, pushed as
 http://git.sugarlabs.org/sugar-artwork/mainline/commit/0847edc8e37317fced59cbb1fc35709202ef1ad4

 Thanks Anish for testing.

 The Terminal has the same issue, we should do the same. I think it is fine
 to do (make sure) when we port Terminal to GTK-3, filed [1].

Nice catch.  Yes, when we port the activity the extra border will be
gone, good to track it in a ticket.

-- 
.. manuq ..
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar-artwork] Set notebook padding to 0px in the GTK3 CSS #3482

2012-04-25 Thread Anish Mangal 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On Tue 24 Apr 2012 10:10:36 PM IST, Manuel Quiñones wrote:
 This removes the 2 pixel padding that was around all the notebook
 page, preventing a confortable use of the scroll bar with the mouse
 pointer, as #3482 describes.

 Signed-off-by: Manuel Quiñones ma...@laptop.org
 ---
  gtk3/theme/gtk-widgets.css.em |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

 diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
 index 6c823b6..dce2a58 100644
 --- a/gtk3/theme/gtk-widgets.css.em
 +++ b/gtk3/theme/gtk-widgets.css.em
 @@ -279,7 +279,7 @@ SugarPaletteWindowWidget GtkToggleButton.button:active {

  .notebook {
  background-color: @selection_grey;
 -border-width: 0px;
 +padding: 0px;
  -GtkNotebook-tab-overlap: -2;
  -GtkNotebook-tab-curvature: $default_padding;
  }

This patch has the desired effect as per sl#3482, tested on
f16/jhbuild/sugar-artwork-0.95.5

Before applying the patch:
http://bugs.sugarlabs.org/attachment/ticket/3482/26.png

After applying the patch:
http://bugs.sugarlabs.org/attachment/ticket/3482/57.png

[Notice the scrollbar at the right edge of screen]

Tested-by: Anish Mangal an...@activitycentral.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPl/s5AAoJEBoxUdDHDZVpzfQH/jm2bxuc+b9/G65BapFx90lw
j15HnlUj+eyTiOU2/4oiSzM+NvP2zHnOC9eQWJ3X+MSfoyP0FQCCDDPqPXGKvG2+
MWO+BeOreppryAMM6aSma+g8JrnyRs6EKO+QGcNtX2bVYz40i+cRTrzlAGg9E5P9
2ngADB9bQ40KnFOPWvhRLnXqcj3NNZbeAvN0AOEL0upszDOoh1CRusvnron0mxL8
H/tmJu3dTcaOrmrZJpZ4sPnhnlMKSPSOJ7eCZBDxdEM2LPHjH8ty6V7v9QUFo9zA
+ht3lfE+6lQLkaWdEqH+Zzw3PQeAQ5BofGwUw14WgjMcrcczWAdI7UJFEqg+XVs=
=voLM
-END PGP SIGNATURE-

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar-artwork] Set notebook padding to 0px in the GTK3 CSS #3482

2012-04-25 Thread Manuel Quiñones 
El día 25 de abril de 2012 10:25, Anish Mangal
an...@activitycentral.com escribió:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1

 On Tue 24 Apr 2012 10:10:36 PM IST, Manuel Quiñones wrote:
 This removes the 2 pixel padding that was around all the notebook
 page, preventing a confortable use of the scroll bar with the mouse
 pointer, as #3482 describes.

Thanks for testing Anish!

-- 
.. manuq ..
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel