svn commit: r367958 - head/bin/getfacl
Author: arrowd (ports committer)
Date: Mon Nov 23 17:00:06 2020
New Revision: 367958
URL: https://svnweb.freebsd.org/changeset/base/367958
Log:
bin/setfacl: Little refactoring, no functional change.
The acl_from_stat function accepts a stat_t * argument, but only uses its
st_mode field. There is no reason to pass the whole struct, so make it accept
a mode_t and rename the function to acl_from_mode.
Linux has non-standard acl_from_mode function in its libacl, so naming the
function this way may help discovering it during porting efforts.
Reviewed by: tsoome, markj
Approved by: markj
Differential Revision:https://reviews.freebsd.org/D27292
Modified:
head/bin/getfacl/getfacl.c
Modified: head/bin/getfacl/getfacl.c
==
--- head/bin/getfacl/getfacl.c Mon Nov 23 16:26:49 2020(r367957)
+++ head/bin/getfacl/getfacl.c Mon Nov 23 17:00:06 2020(r367958)
@@ -85,10 +85,10 @@ getgname(gid_t gid)
/*
* return an ACL corresponding to the permissions
- * contained in struct stat
+ * contained in mode_t
*/
static acl_t
-acl_from_stat(const struct stat *sb)
+acl_from_mode(const mode_t mode)
{
acl_t acl;
acl_entry_t entry;
@@ -111,13 +111,13 @@ acl_from_stat(const struct stat *sb)
return NULL;
/* calculate user mode */
- if (sb->st_mode & S_IRUSR)
+ if (mode & S_IRUSR)
if (acl_add_perm(perms, ACL_READ) == -1)
return NULL;
- if (sb->st_mode & S_IWUSR)
+ if (mode & S_IWUSR)
if (acl_add_perm(perms, ACL_WRITE) == -1)
return NULL;
- if (sb->st_mode & S_IXUSR)
+ if (mode & S_IXUSR)
if (acl_add_perm(perms, ACL_EXECUTE) == -1)
return NULL;
if (acl_set_permset(entry, perms) == -1)
@@ -135,13 +135,13 @@ acl_from_stat(const struct stat *sb)
return NULL;
/* calculate group mode */
- if (sb->st_mode & S_IRGRP)
+ if (mode & S_IRGRP)
if (acl_add_perm(perms, ACL_READ) == -1)
return NULL;
- if (sb->st_mode & S_IWGRP)
+ if (mode & S_IWGRP)
if (acl_add_perm(perms, ACL_WRITE) == -1)
return NULL;
- if (sb->st_mode & S_IXGRP)
+ if (mode & S_IXGRP)
if (acl_add_perm(perms, ACL_EXECUTE) == -1)
return NULL;
if (acl_set_permset(entry, perms) == -1)
@@ -159,13 +159,13 @@ acl_from_stat(const struct stat *sb)
return NULL;
/* calculate other mode */
- if (sb->st_mode & S_IROTH)
+ if (mode & S_IROTH)
if (acl_add_perm(perms, ACL_READ) == -1)
return NULL;
- if (sb->st_mode & S_IWOTH)
+ if (mode & S_IWOTH)
if (acl_add_perm(perms, ACL_WRITE) == -1)
return NULL;
- if (sb->st_mode & S_IXOTH)
+ if (mode & S_IXOTH)
if (acl_add_perm(perms, ACL_EXECUTE) == -1)
return NULL;
if (acl_set_permset(entry, perms) == -1)
@@ -229,9 +229,9 @@ print_acl(char *path, acl_type_t type, int hflag, int
errno = 0;
if (type == ACL_TYPE_DEFAULT)
return(0);
- acl = acl_from_stat();
+ acl = acl_from_mode(sb.st_mode);
if (!acl) {
- warn("%s: acl_from_stat() failed", path);
+ warn("%s: acl_from_mode() failed", path);
return(-1);
}
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r356556 - head/sys/cam/scsi
Author: arrowd (ports committer)
Date: Thu Jan 9 15:21:42 2020
New Revision: 356556
URL: https://svnweb.freebsd.org/changeset/base/356556
Log:
Fix typo: MANGAEMENT_PROTOCOL_OUT -> MANAGEMENT_PROTOCOL_OUT.
Approved by: allanjude
Modified:
head/sys/cam/scsi/scsi_all.h
Modified: head/sys/cam/scsi/scsi_all.h
==
--- head/sys/cam/scsi/scsi_all.hThu Jan 9 15:02:48 2020
(r356555)
+++ head/sys/cam/scsi/scsi_all.hThu Jan 9 15:21:42 2020
(r356556)
@@ -2142,7 +2142,7 @@ struct ata_pass_32 {
#defineCHANGE_ALIASES 0x0B
#defineSET_PRIORITY0x0E
#defineSET_TIMESTAMP 0x0F
-#defineMANGAEMENT_PROTOCOL_OUT 0x10
+#defineMANAGEMENT_PROTOCOL_OUT 0x10
/*
* Device Types
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r356317 - head/contrib/smbfs/lib/smb
Author: arrowd (ports committer)
Date: Fri Jan 3 12:54:14 2020
New Revision: 356317
URL: https://svnweb.freebsd.org/changeset/base/356317
Log:
mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase
characters.
PR: 231656
Approved by: bapt
MFC after:3 days
Differential Revision:https://reviews.freebsd.org/D22289
Modified:
head/contrib/smbfs/lib/smb/rcfile.c
Modified: head/contrib/smbfs/lib/smb/rcfile.c
==
--- head/contrib/smbfs/lib/smb/rcfile.c Fri Jan 3 10:03:36 2020
(r356316)
+++ head/contrib/smbfs/lib/smb/rcfile.c Fri Jan 3 12:54:14 2020
(r356317)
@@ -156,11 +156,19 @@ static struct rcsection *
rc_addsect(struct rcfile *rcp, const char *sectname)
{
struct rcsection *p;
+ const char* sectletter = sectname;
p = rc_findsect(rcp, sectname);
if (p) return p;
p = malloc(sizeof(*p));
if (!p) return NULL;
+ for(sectletter = sectname; *sectletter; sectletter++) {
+ if (islower(*sectletter)) {
+ if (strcmp(sectname, "default"))
+ dprintf(STDERR_FILENO, "warning: section name
[%s] contains lower-case letters\n", sectname);
+ break;
+ }
+ }
p->rs_name = strdup(sectname);
SLIST_INIT(>rs_keys);
SLIST_INSERT_HEAD(>rf_sect, p, rs_next);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r355980 - head/sys/contrib/ncsw/Peripherals/QM
Author: arrowd (ports committer)
Date: Sat Dec 21 11:38:48 2019
New Revision: 355980
URL: https://svnweb.freebsd.org/changeset/base/355980
Log:
Don't shift 32-bit value by more than 32 bits.
PR: 207854
Approved by: emaste
Modified:
head/sys/contrib/ncsw/Peripherals/QM/qm_portal_fqr.c
Modified: head/sys/contrib/ncsw/Peripherals/QM/qm_portal_fqr.c
==
--- head/sys/contrib/ncsw/Peripherals/QM/qm_portal_fqr.cSat Dec 21
07:38:14 2019(r355979)
+++ head/sys/contrib/ncsw/Peripherals/QM/qm_portal_fqr.cSat Dec 21
11:38:48 2019(r355980)
@@ -1468,7 +1468,7 @@ static t_Error CalcWredCurve(t_QmCgWredCurve *p_WredCu
for (tmpA=(uint32_t)(64*pres) ; tmpA<128*pres; tmpA += pres )
for (tmpN=7 ; tmpN<64; tmpN++ )
{
-tmp = ABS((int)(slope - tmpA/(1
svn commit: r348730 - head/usr.bin/calendar/calendars
Author: arrowd (ports committer) Date: Thu Jun 6 08:43:23 2019 New Revision: 348730 URL: https://svnweb.freebsd.org/changeset/base/348730 Log: Add myself (arrowd) to calendar.freebsd. Approved by: bapt Modified: head/usr.bin/calendar/calendars/calendar.freebsd Modified: head/usr.bin/calendar/calendars/calendar.freebsd == --- head/usr.bin/calendar/calendars/calendar.freebsdThu Jun 6 08:12:49 2019(r348729) +++ head/usr.bin/calendar/calendars/calendar.freebsdThu Jun 6 08:43:23 2019(r348730) @@ -423,6 +423,7 @@ 11/09 Antoine Brodin born in Bagnolet, France, 1981 11/10 Gregory Neil Shapiro born in Providence, Rhode Island, United States, 1970 11/11 Danilo E. Gondolfo born in Lobato, Parana, Brazil, 1987 +11/12 Gleb Popov born in Volgograd, Russia, 1991 11/13 John Baldwin born in Stuart, Virginia, United States, 1977 11/14 Jeremie Le Hen born in Nancy, France, 1980 11/15 Lars Engels born in Hilden, Nordrhein-Westfalen, Germany, 1980 ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r334206 - head/share/misc
Author: arrowd (ports committer) Date: Fri May 25 11:49:21 2018 New Revision: 334206 URL: https://svnweb.freebsd.org/changeset/base/334206 Log: Add myself (arrowd) to share/misc/committers-ports.dot Approved by: tcberner (mentor) Modified: head/share/misc/committers-ports.dot Modified: head/share/misc/committers-ports.dot == --- head/share/misc/committers-ports.dotFri May 25 08:44:00 2018 (r334205) +++ head/share/misc/committers-ports.dotFri May 25 11:49:21 2018 (r334206) @@ -55,6 +55,7 @@ amdmi3 [label="Dmitry Marakasov\namd...@freebsd.org\n2 anray [label="Andrey Slusar\nan...@freebsd.org\n2005/12/11"] antoine [label="Antoine Brodin\nanto...@freebsd.org\n2013/04/03"] araujo [label="Marcelo Araujo\nara...@freebsd.org\n2007/04/26"] +arrowd [label="Gleb Popov\narr...@freebsd.org\n2018/05/18"] arved [label="Tilman Linneweh\nar...@freebsd.org\n2002/10/15"] ashish [label="Ashish SHUKLA\nash...@freebsd.org\n2010/06/10"] avilla [label="Alberto Villa\navi...@freebsd.org\n2010/01/24"] @@ -283,6 +284,7 @@ ahze -> shaun ahze -> tmclaugh amdmi3 -> jrm +amdmi3 -> arrowd antoine -> dumbbell @@ -675,6 +677,7 @@ tcberner -> adridg tcberner -> joneum tcberner -> yuri tcberner -> fernape +tcberner -> arrowd thierry -> jadawin thierry -> riggs ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
