svn commit: r352635 - head/sys/conf

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Sep 24 01:56:27 2019
New Revision: 352635
URL: https://svnweb.freebsd.org/changeset/base/352635

Log:
  Clean LINT* kernel configurations for arm*
  
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/conf/makeLINT.mk

Modified: head/sys/conf/makeLINT.mk
==
--- head/sys/conf/makeLINT.mk   Mon Sep 23 22:20:11 2019(r352634)
+++ head/sys/conf/makeLINT.mk   Tue Sep 24 01:56:27 2019(r352635)
@@ -11,6 +11,9 @@ clean:
 .if ${TARGET} == "amd64" || ${TARGET} == "i386"
rm -f LINT-NOINET LINT-NOINET6 LINT-NOIP
 .endif
+.if ${TARGET} == "arm"
+   rm -f LINT-V5 LINT-V7
+.endif
 
 NOTES+=${.CURDIR}/../../conf/NOTES ${.CURDIR}/NOTES
 MAKELINT_SED= ${.CURDIR}/../../conf/makeLINT.sed
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r352516 - head/lib/libarchive/tests

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Sep 19 13:25:19 2019
New Revision: 352516
URL: https://svnweb.freebsd.org/changeset/base/352516

Log:
  Whitespace cleanup, no functional change
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/libarchive/tests/Makefile

Modified: head/lib/libarchive/tests/Makefile
==
--- head/lib/libarchive/tests/Makefile  Thu Sep 19 13:23:25 2019
(r352515)
+++ head/lib/libarchive/tests/Makefile  Thu Sep 19 13:25:19 2019
(r352516)
@@ -520,12 +520,12 @@ ${PACKAGE}FILES+= test_read_format_rar5_blake2.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_compressed.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_different_window_size.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_distance_overflow.rar.uu
-${PACKAGE}FILES+=  test_read_format_rar5_extra_field_version.rar.uu
+${PACKAGE}FILES+=  test_read_format_rar5_extra_field_version.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_fileattr.rar.uu
-${PACKAGE}FILES+=  test_read_format_rar5_hardlink.rar.uu   
-${PACKAGE}FILES+=  test_read_format_rar5_invalid_dict_reference.rar.uu 
-${PACKAGE}FILES+=  test_read_format_rar5_leftshift1.rar.uu 
-${PACKAGE}FILES+=  test_read_format_rar5_leftshift2.rar.uu 
+${PACKAGE}FILES+=  test_read_format_rar5_hardlink.rar.uu
+${PACKAGE}FILES+=  test_read_format_rar5_invalid_dict_reference.rar.uu
+${PACKAGE}FILES+=  test_read_format_rar5_leftshift1.rar.uu
+${PACKAGE}FILES+=  test_read_format_rar5_leftshift2.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_multiarchive.part01.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_multiarchive.part02.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_multiarchive.part03.rar.uu
@@ -541,13 +541,13 @@ ${PACKAGE}FILES+= test_read_format_rar5_multiarchive_s
 ${PACKAGE}FILES+=  test_read_format_rar5_multiple_files.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_multiple_files_solid.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_nonempty_dir_stream.rar.uu
-${PACKAGE}FILES+=  test_read_format_rar5_owner.rar.uu  
-${PACKAGE}FILES+=  test_read_format_rar5_readtables_overflow.rar.uu
+${PACKAGE}FILES+=  test_read_format_rar5_owner.rar.uu
+${PACKAGE}FILES+=  test_read_format_rar5_readtables_overflow.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_solid.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_stored.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_stored_manyfiles.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_symlink.rar.uu
-${PACKAGE}FILES+=  test_read_format_rar5_truncated_huff.rar.uu 
+${PACKAGE}FILES+=  test_read_format_rar5_truncated_huff.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_win32.rar.uu
 ${PACKAGE}FILES+=  test_read_format_raw.bufr.uu
 ${PACKAGE}FILES+=  test_read_format_raw.data.Z.uu
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r352515 - head/lib/libarchive/tests

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Sep 19 13:23:25 2019
New Revision: 352515
URL: https://svnweb.freebsd.org/changeset/base/352515

Log:
  Temporarily add test_write_filter_zstd BROKEN_TESTS as it always fails in CI
  
  There is no trivial way to mark single libarchive test skip currently so just
  add it to BROKEN_TESTS for now.
  
  PR:   240683
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/libarchive/tests/Makefile

Modified: head/lib/libarchive/tests/Makefile
==
--- head/lib/libarchive/tests/Makefile  Thu Sep 19 11:46:43 2019
(r352514)
+++ head/lib/libarchive/tests/Makefile  Thu Sep 19 13:23:25 2019
(r352515)
@@ -305,6 +305,9 @@ BROKEN_TESTS+=  
test_read_disk_directory_traversals
 # (Times out?) [and] crashes
 BROKEN_TESTS+= test_fuzz_rar
 
+# https://bugs.freebsd.org/240683
+BROKEN_TESTS+= test_write_filter_zstd
+
 # Build the test program.
 SRCS.libarchive_test=  \
${TESTS_SRCS}   \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r352463 - head/tests/sys/netpfil/common

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Sep 17 22:09:14 2019
New Revision: 352463
URL: https://svnweb.freebsd.org/changeset/base/352463

Log:
  Temporarily skip sys.netpfil.common.tos.pf_tos on i386 CI as it always fails
  
  PR:   240086
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/netpfil/common/tos.sh

Modified: head/tests/sys/netpfil/common/tos.sh
==
--- head/tests/sys/netpfil/common/tos.shTue Sep 17 22:08:16 2019
(r352462)
+++ head/tests/sys/netpfil/common/tos.shTue Sep 17 22:09:14 2019
(r352463)
@@ -40,6 +40,10 @@ tos_head()
 tos_body()
 {
firewall=$1
+   if [ "$(atf_config_get ci false)" = "true" ] && \
+   [ "$(uname -p)" = "i386" ] && [ "${firewall}" = "pf" ]; then
+   atf_skip "https://bugs.freebsd.org/240086;
+   fi
firewall_init $firewall
 
epair_send=$(vnet_mkepair)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r352462 - head/tests/sys/netpfil/common

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Sep 17 22:08:16 2019
New Revision: 352462
URL: https://svnweb.freebsd.org/changeset/base/352462

Log:
  Temporarily skip sys.netpfil.common.forward.pf_v4 on i386 CI as it always 
fails
  
  PR:   240085
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/netpfil/common/forward.sh

Modified: head/tests/sys/netpfil/common/forward.sh
==
--- head/tests/sys/netpfil/common/forward.shTue Sep 17 20:05:06 2019
(r352461)
+++ head/tests/sys/netpfil/common/forward.shTue Sep 17 22:08:16 2019
(r352462)
@@ -40,6 +40,10 @@ v4_head()
 v4_body()
 {
firewall=$1
+   if [ "$(atf_config_get ci false)" = "true" ] && \
+   [ "$(uname -p)" = "i386" ] && [ "${firewall}" = "pf" ]; then
+   atf_skip "https://bugs.freebsd.org/240085;
+   fi
firewall_init $firewall
 
epair_send=$(vnet_mkepair)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r352448 - head/contrib/netbsd-tests/lib/libc/sys

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Sep 17 14:08:09 2019
New Revision: 352448
URL: https://svnweb.freebsd.org/changeset/base/352448

Log:
  Temporarily skip flakey test case lib.libc.sys.stat_test.stat_socket
  
  PR:   240621
  Sponsored by: The FreeBSD Foundation

Modified:
  head/contrib/netbsd-tests/lib/libc/sys/t_stat.c

Modified: head/contrib/netbsd-tests/lib/libc/sys/t_stat.c
==
--- head/contrib/netbsd-tests/lib/libc/sys/t_stat.c Tue Sep 17 13:58:15 
2019(r352447)
+++ head/contrib/netbsd-tests/lib/libc/sys/t_stat.c Tue Sep 17 14:08:09 
2019(r352448)
@@ -332,6 +332,9 @@ ATF_TC_BODY(stat_socket, tc)
uint32_t iaddr;
int fd, flags;
 
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
+   atf_tc_skip("https://bugs.freebsd.org/240621;);
+
(void)memset(, 0, sizeof(struct stat));
(void)memset(, 0, sizeof(struct sockaddr_in));
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r352315 - head/lib/libc/locale

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Sep 14 08:15:16 2019
New Revision: 352315
URL: https://svnweb.freebsd.org/changeset/base/352315

Log:
  Improve the description of big5(5)
  
  - Fix the statement that big5 is a de facto standard of Traditional Chinese
text [1]
  - Add a BUGS section describes the problem of big5 and suggests use utf8
  
  PR:   189095
  Submitted by: Brennan Vincent  [1]
  Reviewed by:  Ting-Wei Lan 
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D21622

Modified:
  head/lib/libc/locale/big5.5

Modified: head/lib/libc/locale/big5.5
==
--- head/lib/libc/locale/big5.5 Sat Sep 14 03:38:18 2019(r352314)
+++ head/lib/libc/locale/big5.5 Sat Sep 14 08:15:16 2019(r352315)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd August 7, 2003
+.Dd September 12, 2019
 .Dt BIG5 5
 .Os
 .Sh NAME
@@ -37,7 +37,7 @@ encoding for Traditional Chinese text
 .Qq BIG5
 .Sh DESCRIPTION
 .Dq Big Five
-is the de facto standard for encoding Traditional Chinese text.
+is a standard for encoding Traditional Chinese text.
 Each character is represented by either one or two bytes.
 Characters from the
 .Tn ASCII
@@ -49,3 +49,10 @@ the first in the range 0xA1 - 0xFE, the second in the 
 .Xr euc 5 ,
 .Xr gb18030 5 ,
 .Xr utf8 5
+.Sh BUGS
+The range of the second byte overlaps some ASCII characters, including
+0x5C (`\\') and 0x7C (`|') which may cause problems in program execution or
+display.
+Big5 is considered a legacy standard and only preserved for backward
+compatibility reason.
+New documents and systems are suggested using UTF-8 directly.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r352227 - head/contrib/netbsd-tests/lib/libc/regex

[Li-Wen Hsu]

Author: lwhsu
Date: Wed Sep 11 18:40:05 2019
New Revision: 352227
URL: https://svnweb.freebsd.org/changeset/base/352227

Log:
  Only skip problematic test in CI env.
  
  PR:   237450
  Sponsored by: The FreeBSD Foundation

Modified:
  head/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c

Modified: head/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c
==
--- head/contrib/netbsd-tests/lib/libc/regex/t_exhaust.cWed Sep 11 
18:08:40 2019(r352226)
+++ head/contrib/netbsd-tests/lib/libc/regex/t_exhaust.cWed Sep 11 
18:40:05 2019(r352227)
@@ -187,7 +187,8 @@ ATF_TC_BODY(regcomp_too_big, tc)
struct rlimit limit;
 
 #if defined(__i386__)
-   atf_tc_skip("https://bugs.freebsd.org/237450;);
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
+   atf_tc_skip("https://bugs.freebsd.org/237450;);
 #endif
 
limit.rlim_cur = limit.rlim_max = 256 * 1024 * 1024;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r352219 - head/tests/sys/kern

[Li-Wen Hsu]

Author: lwhsu
Date: Wed Sep 11 16:24:03 2019
New Revision: 352219
URL: https://svnweb.freebsd.org/changeset/base/352219

Log:
  Temporarily skip flakey test case sys.kern.ptrace_test.ptrace__getppid
  
  PR:   240510
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/kern/ptrace_test.c

Modified: head/tests/sys/kern/ptrace_test.c
==
--- head/tests/sys/kern/ptrace_test.c   Wed Sep 11 16:16:53 2019
(r352218)
+++ head/tests/sys/kern/ptrace_test.c   Wed Sep 11 16:24:03 2019
(r352219)
@@ -1006,6 +1006,10 @@ ATF_TC_BODY(ptrace__getppid, tc)
int cpipe[2], dpipe[2], status;
char c;
 
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
+   atf_tc_skip("https://bugs.freebsd.org/240510;);
+
+
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((child = fork()) != -1);
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r352132 - head/sys/net

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Sep 10 08:51:11 2019
New Revision: 352132
URL: https://svnweb.freebsd.org/changeset/base/352132

Log:
  Fix build for the platforms where db_expr_t is not long
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/net/rtsock.c

Modified: head/sys/net/rtsock.c
==
--- head/sys/net/rtsock.c   Tue Sep 10 08:28:44 2019(r352131)
+++ head/sys/net/rtsock.c   Tue Sep 10 08:51:11 2019(r352132)
@@ -2226,7 +2226,7 @@ _DB_FUNC(_show, route, db_show_route_cmd, db_show_tabl
 
if (af == AF_INET && db_tok_number > UINT8_MAX) {
db_printf("Not a valid v4 octet: %ld\n",
-   db_tok_number);
+   (long)db_tok_number);
goto exit;
}
hextets[i] = db_tok_number;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r346431 - head/tests/sys/opencrypto

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Apr 20 07:32:29 2019
New Revision: 346431
URL: https://svnweb.freebsd.org/changeset/base/346431

Log:
  Specify using Python2, these .py files have not been converted to use Python3
  yet, but the default Python version in ports has been switched to 3.
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/opencrypto/Makefile
  head/tests/sys/opencrypto/cryptodev.py
  head/tests/sys/opencrypto/cryptotest.py
  head/tests/sys/opencrypto/runtests.sh

Modified: head/tests/sys/opencrypto/Makefile
==
--- head/tests/sys/opencrypto/Makefile  Sat Apr 20 05:31:56 2019
(r346430)
+++ head/tests/sys/opencrypto/Makefile  Sat Apr 20 07:32:29 2019
(r346431)
@@ -14,7 +14,7 @@ ATF_TESTS_C+= blake2_test poly1305_test
 
 PLAIN_TESTS_SH=runtests
 
-TEST_METADATA.runtests+= required_programs="python"
+TEST_METADATA.runtests+= required_programs="python2"
 TEST_METADATA.runtests+= required_user="root"
 
 PYMODULES= cryptodev.py cryptodevh.py cryptotest.py dpkt.py

Modified: head/tests/sys/opencrypto/cryptodev.py
==
--- head/tests/sys/opencrypto/cryptodev.py  Sat Apr 20 05:31:56 2019
(r346430)
+++ head/tests/sys/opencrypto/cryptodev.py  Sat Apr 20 07:32:29 2019
(r346431)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/local/bin/python2
 #
 # Copyright (c) 2014 The FreeBSD Foundation
 # Copyright 2014 John-Mark Gurney

Modified: head/tests/sys/opencrypto/cryptotest.py
==
--- head/tests/sys/opencrypto/cryptotest.py Sat Apr 20 05:31:56 2019
(r346430)
+++ head/tests/sys/opencrypto/cryptotest.py Sat Apr 20 07:32:29 2019
(r346431)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/local/bin/python2
 #
 # Copyright (c) 2014 The FreeBSD Foundation
 # All rights reserved.

Modified: head/tests/sys/opencrypto/runtests.sh
==
--- head/tests/sys/opencrypto/runtests.sh   Sat Apr 20 05:31:56 2019
(r346430)
+++ head/tests/sys/opencrypto/runtests.sh   Sat Apr 20 07:32:29 2019
(r346431)
@@ -61,6 +61,6 @@ done
 oldcdas=$(sysctl -e kern.cryptodevallowsoft)
 sysctl kern.cryptodevallowsoft=1
 
-python $(dirname $0)/cryptotest.py
+python2 $(dirname $0)/cryptotest.py
 
 sysctl "$oldcdas"


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r346160 - head/usr.bin/mandoc

[Li-Wen Hsu]

Author: lwhsu
Date: Fri Apr 12 18:35:14 2019
New Revision: 346160
URL: https://svnweb.freebsd.org/changeset/base/346160

Log:
  Suppress old gcc warning about null format string
  
  This is workaround to make head build on gcc using architectures
  
  Sponsored by: The FreeBSD Foundation
  MFC-with: r346149

Modified:
  head/usr.bin/mandoc/Makefile

Modified: head/usr.bin/mandoc/Makefile
==
--- head/usr.bin/mandoc/MakefileFri Apr 12 18:13:57 2019
(r346159)
+++ head/usr.bin/mandoc/MakefileFri Apr 12 18:35:14 2019
(r346160)
@@ -97,6 +97,8 @@ SRCS= ${LIB_SRCS} \
 WARNS?=3
 CFLAGS+= -DHAVE_CONFIG_H \
 -I${SRCTOP}/lib/libopenbsd/
+# This can be removed after swtiching to newer gcc
+CFLAGS.gcc+=   -Wno-format
 LIBADD=openbsd z
 
 .include 


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r346160 - head/usr.bin/mandoc

[Li-Wen Hsu]

On Sat, Apr 13, 2019 at 3:53 AM Enji Cooper  wrote:
>
>
> > On Apr 12, 2019, at 11:35 AM, Li-Wen Hsu  wrote:
> >
> > Author: lwhsu
> > Date: Fri Apr 12 18:35:14 2019
> > New Revision: 346160
> > URL: https://svnweb.freebsd.org/changeset/base/346160
> >
> > Log:
> >  Suppress old gcc warning about null format string
> >
> >  This is workaround to make head build on gcc using architectures
> >
> >  Sponsored by:The FreeBSD Foundation
> >  MFC-with:r346149
> >
> > Modified:
> >  head/usr.bin/mandoc/Makefile
> >
> > Modified: head/usr.bin/mandoc/Makefile
> > ==
> > --- head/usr.bin/mandoc/Makefile  Fri Apr 12 18:13:57 2019
> > (r346159)
> > +++ head/usr.bin/mandoc/Makefile  Fri Apr 12 18:35:14 2019
> > (r346160)
> > @@ -97,6 +97,8 @@ SRCS=   ${LIB_SRCS} \
> > WARNS?=   3
> > CFLAGS+= -DHAVE_CONFIG_H \
> >-I${SRCTOP}/lib/libopenbsd/
> > +# This can be removed after swtiching to newer gcc
> > +CFLAGS.gcc+= -Wno-format
> > LIBADD=   openbsd z
> >
> > .include 
>
> Couldn’t this be fixed upstream and pulled back in, instead of 
> ignoring the warning?

That's possible, but I don't know how much of the possibility that
upstream is willing to fix a warning that only occurs in old versions
of gcc, and it looks a false positive to me.  I am here to put a
band-aid first.

Best,
Li-Wen


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r346087 - head/sys/modules/nfscommon

[Li-Wen Hsu]

Author: lwhsu
Date: Wed Apr 10 16:48:45 2019
New Revision: 346087
URL: https://svnweb.freebsd.org/changeset/base/346087

Log:
  Fix build in sys/modules/nfscommon
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/modules/nfscommon/Makefile

Modified: head/sys/modules/nfscommon/Makefile
==
--- head/sys/modules/nfscommon/Makefile Wed Apr 10 16:09:06 2019
(r346086)
+++ head/sys/modules/nfscommon/Makefile Wed Apr 10 16:48:45 2019
(r346087)
@@ -7,6 +7,7 @@ SRCS=   vnode_if.h \
nfs_commonkrpc.c \
nfs_commonport.c \
nfs_commonsubs.c \
+   opt_inet.h \
opt_inet6.h \
opt_kgssapi.h \
opt_nfs.h \


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r345632 - in head/sys/modules: efirt iflib nvdimm tpm

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Mar 28 08:59:11 2019
New Revision: 345632
URL: https://svnweb.freebsd.org/changeset/base/345632

Log:
  Fix `make` in sys/modules
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/modules/efirt/Makefile
  head/sys/modules/iflib/Makefile
  head/sys/modules/nvdimm/Makefile
  head/sys/modules/tpm/Makefile

Modified: head/sys/modules/efirt/Makefile
==
--- head/sys/modules/efirt/Makefile Thu Mar 28 08:38:31 2019
(r345631)
+++ head/sys/modules/efirt/Makefile Thu Mar 28 08:59:11 2019
(r345632)
@@ -9,6 +9,7 @@ SRCS+=  efirtc.c
 SRCS+=  device_if.h bus_if.h clock_if.h
 
 .if ${MACHINE_CPUARCH} == "amd64"
+SRCS+= opt_hwpmc_hooks.h opt_kstack_pages.h
 SRCS+= efirt_support.S
 efirt_support.o:   efirt_support.S assym.inc
${CC} -c -x assembler-with-cpp -DLOCORE ${CFLAGS} \

Modified: head/sys/modules/iflib/Makefile
==
--- head/sys/modules/iflib/Makefile Thu Mar 28 08:38:31 2019
(r345631)
+++ head/sys/modules/iflib/Makefile Thu Mar 28 08:59:11 2019
(r345632)
@@ -9,5 +9,6 @@ SRCS= \
mp_ring.c
 SRCS+= ifdi_if.c
 SRCS+= device_if.h bus_if.h pci_if.h pci_iov_if.h ifdi_if.h
+SRCS+= opt_acpi.h opt_inet.h opt_inet6.h opt_sched.h
 
 .include 

Modified: head/sys/modules/nvdimm/Makefile
==
--- head/sys/modules/nvdimm/MakefileThu Mar 28 08:38:31 2019
(r345631)
+++ head/sys/modules/nvdimm/MakefileThu Mar 28 08:59:11 2019
(r345632)
@@ -9,5 +9,6 @@ SRCS=   nvdimm.c \
nvdimm_spa.c
 
 SRCS+= acpi_if.h bus_if.h device_if.h
+SRCS+= opt_acpi.h opt_ddb.h
 
 .include 

Modified: head/sys/modules/tpm/Makefile
==
--- head/sys/modules/tpm/Makefile   Thu Mar 28 08:38:31 2019
(r345631)
+++ head/sys/modules/tpm/Makefile   Thu Mar 28 08:59:11 2019
(r345632)
@@ -8,6 +8,6 @@ SRCS=   tpm.c bus_if.h device_if.h
 #Bus specific stuff.
 SRCS+= tpm_isa.c tpm_acpi.c isa_if.h opt_acpi.h acpi_if.h
 #TPM 2.0
-SRCS+= tpm20.c tpm_crb.c tpm_tis.c
+SRCS+= tpm20.c tpm_crb.c tpm_tis.c opt_tpm.h
 
 .include 


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r345630 - in head/sys/modules: hwpmc_mips24k hwpmc_mips74k

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Mar 28 08:30:45 2019
New Revision: 345630
URL: https://svnweb.freebsd.org/changeset/base/345630

Log:
  Add dependent header files
  
  Reported by:  https://ci.freebsd.org/job/FreeBSD-head-mips-build/6702/console

Modified:
  head/sys/modules/hwpmc_mips24k/Makefile
  head/sys/modules/hwpmc_mips74k/Makefile

Modified: head/sys/modules/hwpmc_mips24k/Makefile
==
--- head/sys/modules/hwpmc_mips24k/Makefile Thu Mar 28 06:10:41 2019
(r345629)
+++ head/sys/modules/hwpmc_mips24k/Makefile Thu Mar 28 08:30:45 2019
(r345630)
@@ -6,9 +6,12 @@
 
 KMOD=  hwpmc_mips24k
 
-SRCS=  hwpmc_mod.c hwpmc_logging.c hwpmc_soft.c vnode_if.h
+SRCS=  bus_if.h device_if.h vnode_if.h
+SRCS+= hwpmc_mod.c hwpmc_logging.c hwpmc_soft.c
 SRCS+= hwpmc_mips.c
 
 SRCS+= hwpmc_mips24k.c
+
+SRCS+= opt_hwpmc_hooks.h
 
 .include 

Modified: head/sys/modules/hwpmc_mips74k/Makefile
==
--- head/sys/modules/hwpmc_mips74k/Makefile Thu Mar 28 06:10:41 2019
(r345629)
+++ head/sys/modules/hwpmc_mips74k/Makefile Thu Mar 28 08:30:45 2019
(r345630)
@@ -6,9 +6,12 @@
 
 KMOD=  hwpmc_mips74k
 
-SRCS=  hwpmc_mod.c hwpmc_logging.c hwpmc_soft.c vnode_if.h
+SRCS=  bus_if.h device_if.h vnode_if.h
+SRCS+= hwpmc_mod.c hwpmc_logging.c hwpmc_soft.c
 SRCS+= hwpmc_mips.c
 
 SRCS+= hwpmc_mips74k.c
+
+SRCS+= opt_hwpmc_hooks.h
 
 .include 


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r351739 - head/tests/sys/sys

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Sep  3 10:49:13 2019
New Revision: 351739
URL: https://svnweb.freebsd.org/changeset/base/351739

Log:
  Temporarily skip sys.sys.qmath_test.qdivq_s64q in CI because it is unstable
  
  PR:   240219
  Discussed with:   trasz
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/sys/qmath_test.c

Modified: head/tests/sys/sys/qmath_test.c
==
--- head/tests/sys/sys/qmath_test.c Tue Sep  3 07:09:04 2019
(r351738)
+++ head/tests/sys/sys/qmath_test.c Tue Sep  3 10:49:13 2019
(r351739)
@@ -275,6 +275,10 @@ ATF_TC_BODY(qdivq_s64q, tc)
double a_dbl, b_dbl, r_dbl, maxe_dbl, delta_dbl;
int error;
 
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
+   atf_tc_skip("https://bugs.freebsd.org/240219;);
+
+
srandomdev();
 
for (int i = 0; i < 10; i++) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r351643 - in head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common: dtraceUtil speculation

[Li-Wen Hsu]

On Mon, Sep 2, 2019 at 11:49 PM Rodney W. Grimes
 wrote:
>
> >
> > > On Aug 31, 2019, at 16:29, Warner Losh  wrote:
> > >
> > >
> > >
> > >> On Sat, Aug 31, 2019 at 5:29 PM Conrad Meyer  wrote:
> > >> Thanks Li-Wen!  Might it be less fragile to have the test fixture
> > >> create a file, if the test(s) will expect one to be present to read?
> > >
> > > Or just use the realpath $0, which you know has to exist :)
> >
> > I don?t know if this would work, with other some of the dtrace tests are 
> > called. Plus, that relies on a FreeBSD utility which doesn?t necessarily 
> > exist on Linux and I don?t think exists on IllumOS.
> >
> > It makes more sense to create a file with mktemp and test for it in the 
> > loop to make the tests portable over to IllumOS, since that?s where they 
> > originally came from and can be contributed back to.
>
> Agreed, especially if these tests are expected to be portable the
> assumption of existance of /COPYRIGHT is a mistake/bug.

Thanks for the inputs.  Indeed, depending on any irrelevant files or
FreeBSD specified tools both do not sound a good solution.  After
reading these test cases again, I feel that creating a temp file might
be slightly over engineering because in the end we also need to take
care of cleaning, in normal and abnormal exiting cases.  In these
tests, we only need someone calls open(2) and read(2).

How about changing them to `cat / > /dev/null` ?

Best,
Li-Wen
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r351648 - in head/lib: libc/tests/stdlib msun/tests

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Aug 31 20:45:45 2019
New Revision: 351648
URL: https://svnweb.freebsd.org/changeset/base/351648

Log:
  Unskip test cases from netbsd-tests by defining __HAVE_FENV
  
  This unskips:
- lib.libc.stdlib.strtod_test.strtod_round
- lib.msun.fe_round_test.t_nofe_round
  
  In lib/msun/tests/Makefile only define on fe_round_test.c because
  lib.msun.ilogb_test.ilogb will get wrong results and needs more examination.
  
  MFC after:1 week
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/libc/tests/stdlib/Makefile
  head/lib/msun/tests/Makefile

Modified: head/lib/libc/tests/stdlib/Makefile
==
--- head/lib/libc/tests/stdlib/Makefile Sat Aug 31 18:04:33 2019
(r351647)
+++ head/lib/libc/tests/stdlib/Makefile Sat Aug 31 20:45:45 2019
(r351648)
@@ -14,6 +14,9 @@ ATF_TESTS_CXX+=   cxa_thread_atexit_test
 ATF_TESTS_CXX+=cxa_thread_atexit_nothr_test
 .endif
 
+# All architectures on FreeBSD have fenv.h
+CFLAGS+=   -D__HAVE_FENV
+
 # Not sure why this isn't defined for all architectures, since most
 # have long double.
 .if ${MACHINE_CPUARCH} == "aarch64" || \

Modified: head/lib/msun/tests/Makefile
==
--- head/lib/msun/tests/MakefileSat Aug 31 18:04:33 2019
(r351647)
+++ head/lib/msun/tests/MakefileSat Aug 31 20:45:45 2019
(r351648)
@@ -99,6 +99,8 @@ ARCH_SUBDIR= ${MACHINE_CPUARCH}
 # precision is.
 CFLAGS+=   -DLDBL_PREC=${LDBL_PREC}
 
+CFLAGS.fe_round_test+= -D__HAVE_FENV
+
 .include 
 
 .include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r351644 - head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Aug 31 15:10:27 2019
New Revision: 351644
URL: https://svnweb.freebsd.org/changeset/base/351644

Log:
  Fix dtrace test case after r351423 due to ping6(8) options changed
  
  Failure test case:
  cddl.usr.sbin.dtrace.common.ip.t_dtrace_contrib.tst_ipv6localicmp_ksh
  
  Sponsored by: The FreeBSD Foundation

Modified:
  
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv6localicmp.ksh

Modified: 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv6localicmp.ksh
==
--- 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv6localicmp.ksh
   Sat Aug 31 14:41:58 2019(r351643)
+++ 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.ipv6localicmp.ksh
   Sat Aug 31 15:10:27 2019(r351644)
@@ -55,7 +55,7 @@ else
removeinet6=0
 fi
 
-$dtrace -c "/sbin/ping6 -q -c 1 -X 3 $local" -qs /dev/stdin ip_daddr == "$local" &&
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r351643 - in head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common: dtraceUtil speculation

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Aug 31 14:41:58 2019
New Revision: 351643
URL: https://svnweb.freebsd.org/changeset/base/351643

Log:
  Fix tests use /etc/motd after r350184 by using an always existing file
  
  Sponsored by: The FreeBSD Foundation

Modified:
  
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
  
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh
  
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe

Modified: 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
==
--- 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
  Sat Aug 31 13:24:22 2019(r351642)
+++ 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
  Sat Aug 31 14:41:58 2019(r351643)
@@ -43,7 +43,7 @@ reader()
while true
do
sleep 0.1
-   cat /etc/motd > /dev/null
+   cat /COPYRIGHT > /dev/null
done
 }
 

Modified: 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh
==
--- 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh
Sat Aug 31 13:24:22 2019(r351642)
+++ 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh
Sat Aug 31 14:41:58 2019(r351643)
@@ -44,7 +44,7 @@ reader()
while true
do
sleep 0.1
-   cat /etc/motd > /dev/null
+   cat /COPYRIGHT > /dev/null
done
 }
 

Modified: 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe
==
--- 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe
   Sat Aug 31 13:24:22 2019(r351642)
+++ 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe
   Sat Aug 31 14:41:58 2019(r351643)
@@ -26,5 +26,5 @@
 while true
 do
sleep 0.1
-   cat /etc/motd > /dev/null
+   cat /COPYRIGHT > /dev/null
 done
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r351450 - in head/tests/sys/netpfil: common pf

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Aug 24 01:28:39 2019
New Revision: 351450
URL: https://svnweb.freebsd.org/changeset/base/351450

Log:
  Fix failure test cases after r351423 due to ping6(8) options changed
  
  Failure test cases:
  sys.netpfil.common.pass_block.pf_v6
  sys.netpfil.pf.pass_block.noalias
  sys.netpfil.pf.pass_block.v6
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/netpfil/common/pass_block.sh
  head/tests/sys/netpfil/pf/pass_block.sh

Modified: head/tests/sys/netpfil/common/pass_block.sh
==
--- head/tests/sys/netpfil/common/pass_block.sh Sat Aug 24 00:35:59 2019
(r351449)
+++ head/tests/sys/netpfil/common/pass_block.sh Sat Aug 24 01:28:39 2019
(r351450)
@@ -99,7 +99,7 @@ v6_body()
"ipf" \
"block in all"
 
-   atf_check -s exit:2 -o ignore ping6 -c 1 -x 1 fd7a:803f:cc4b::2
+   atf_check -s exit:2 -o ignore ping6 -c 1 -W 1 fd7a:803f:cc4b::2

# Pass All
firewall_config "iron" ${firewall} \
@@ -110,7 +110,7 @@ v6_body()
"ipf" \
"pass in all"
 
-   atf_check -s exit:0 -o ignore ping6 -c 1 -x 1 fd7a:803f:cc4b::2
+   atf_check -s exit:0 -o ignore ping6 -c 1 -W 1 fd7a:803f:cc4b::2
 }
 
 v6_cleanup()
@@ -126,4 +126,4 @@ setup_tests "v4" \
"v6" \
"pf" \
"ipfw" \
-   "ipf"
\ No newline at end of file
+   "ipf"

Modified: head/tests/sys/netpfil/pf/pass_block.sh
==
--- head/tests/sys/netpfil/pf/pass_block.sh Sat Aug 24 00:35:59 2019
(r351449)
+++ head/tests/sys/netpfil/pf/pass_block.sh Sat Aug 24 01:28:39 2019
(r351450)
@@ -60,23 +60,23 @@ v6_body()
jexec alcatraz ifconfig ${epair}b inet6 2001:db8:42::2/64 up no_dad
 
# Trivial ping to the jail, without pf
-   atf_check -s exit:0 -o ignore ping6 -c 1 -x 1 2001:db8:42::2
+   atf_check -s exit:0 -o ignore ping6 -c 1 -W 1 2001:db8:42::2
 
# pf without policy will let us ping
jexec alcatraz pfctl -e
-   atf_check -s exit:0 -o ignore ping6 -c 1 -x 1 2001:db8:42::2
+   atf_check -s exit:0 -o ignore ping6 -c 1 -W 1 2001:db8:42::2
 
# Block everything
pft_set_rules alcatraz "block in"
-   atf_check -s exit:2 -o ignore ping6 -c 1 -x 1 2001:db8:42::2
+   atf_check -s exit:2 -o ignore ping6 -c 1 -W 1 2001:db8:42::2
 
# Block everything but ICMP
pft_set_rules alcatraz "block in" "pass in proto icmp6"
-   atf_check -s exit:0 -o ignore ping6 -c 1 -x 1 2001:db8:42::2
+   atf_check -s exit:0 -o ignore ping6 -c 1 -W 1 2001:db8:42::2
 
# Allowing ICMPv4 does not allow ICMPv6
pft_set_rules alcatraz "block in" "pass in proto icmp"
-   atf_check -s exit:2 -o ignore ping6 -c 1 -x 1 2001:db8:42::2
+   atf_check -s exit:2 -o ignore ping6 -c 1 -W 1 2001:db8:42::2
 }
 
 v6_cleanup()
@@ -107,21 +107,21 @@ noalias_body()
| cut -d % -f 1)
 
# Sanity check
-   atf_check -s exit:0 -o ignore ping6 -c 3 -x 1 2001:db8:42::2
-   atf_check -s exit:0 -o ignore ping6 -c 3 -x 1 ${linklocaladdr}%${epair}a
+   atf_check -s exit:0 -o ignore ping6 -c 3 -W 1 2001:db8:42::2
+   atf_check -s exit:0 -o ignore ping6 -c 3 -W 1 ${linklocaladdr}%${epair}a
 
jexec alcatraz pfctl -e
pft_set_rules alcatraz "block out inet6 from (${epair}b:0) to any"
 
-   atf_check -s exit:2 -o ignore ping6 -c 3 -x 1 2001:db8:42::2
+   atf_check -s exit:2 -o ignore ping6 -c 3 -W 1 2001:db8:42::2
 
# We should still be able to ping the link-local address
-   atf_check -s exit:0 -o ignore ping6 -c 3 -x 1 ${linklocaladdr}%${epair}a
+   atf_check -s exit:0 -o ignore ping6 -c 3 -W 1 ${linklocaladdr}%${epair}a
 
pft_set_rules alcatraz "block out inet6 from (${epair}b) to any"
 
# We cannot ping to the link-local address
-   atf_check -s exit:2 -o ignore ping6 -c 3 -x 1 ${linklocaladdr}%${epair}a
+   atf_check -s exit:2 -o ignore ping6 -c 3 -W 1 ${linklocaladdr}%${epair}a
 }
 
 noalias_cleanup()
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r351416 - head/lib/libc/tests/gen

[Li-Wen Hsu]

Author: lwhsu
Date: Fri Aug 23 05:25:21 2019
New Revision: 351416
URL: https://svnweb.freebsd.org/changeset/base/351416

Log:
  lib.libc.gen.getmntinfo_test.getmntinfo_test is unstable since 8/20, skip it
  in CI env temporarily for more offline diagnosis
  
  PR:   240049
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/libc/tests/gen/getmntinfo_test.c

Modified: head/lib/libc/tests/gen/getmntinfo_test.c
==
--- head/lib/libc/tests/gen/getmntinfo_test.c   Fri Aug 23 05:23:45 2019
(r351415)
+++ head/lib/libc/tests/gen/getmntinfo_test.c   Fri Aug 23 05:25:21 2019
(r351416)
@@ -57,6 +57,9 @@ ATF_TC_BODY(getmntinfo_test, tc)
int nmnts;
struct statfs *mntinfo;
 
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
+   atf_tc_skip("https://bugs.freebsd.org/240049;);
+
/* Test bogus mode */
nmnts = getmntinfo(, 199);
ATF_REQUIRE_MSG(nmnts == 0 && errno == EINVAL,
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r351391 - head/tests/sys/netpfil/pf

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Aug 22 12:08:35 2019
New Revision: 351391
URL: https://svnweb.freebsd.org/changeset/base/351391

Log:
  Fix path issues after r351212
  
  This fixes sys.netpfil.pf.forward.v4 and sys.netpfil.pf.icmp.cve_2019_5598
  failures in CI system.
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/netpfil/pf/forward.sh
  head/tests/sys/netpfil/pf/icmp.sh

Modified: head/tests/sys/netpfil/pf/forward.sh
==
--- head/tests/sys/netpfil/pf/forward.shThu Aug 22 11:32:03 2019
(r351390)
+++ head/tests/sys/netpfil/pf/forward.shThu Aug 22 12:08:35 2019
(r351391)
@@ -36,7 +36,7 @@ v4_body()
route add -net 198.51.100.0/24 192.0.2.2
 
# Sanity check, can we forward ICMP echo requests without pf?
-   atf_check -s exit:0 $(atf_get_srcdir)/pft_ping.py \
+   atf_check -s exit:0 ${common_dir}/pft_ping.py \
--sendif ${epair_send}a \
--to 198.51.100.3 \
--recvif ${epair_recv}a

Modified: head/tests/sys/netpfil/pf/icmp.sh
==
--- head/tests/sys/netpfil/pf/icmp.sh   Thu Aug 22 11:32:03 2019
(r351390)
+++ head/tests/sys/netpfil/pf/icmp.sh   Thu Aug 22 12:08:35 2019
(r351391)
@@ -2,6 +2,8 @@
 
 . $(atf_get_srcdir)/utils.subr
 
+common_dir=$(atf_get_srcdir)/../common
+
 atf_test_case "cve_2019_5598" "cleanup"
 cve_2019_5598_head()
 {
@@ -32,7 +34,8 @@ cve_2019_5598_body()
"pass in proto udp to 198.51.100.3 port 53" \
"pass out proto udp to 198.51.100.3 port 53"
 
-   atf_check -s exit:0 $(atf_get_srcdir)/CVE-2019-5598.py \
+   atf_check -s exit:0 env PYTHONPATH=${common_dir} \
+   $(atf_get_srcdir)/CVE-2019-5598.py \
--sendif ${epair_in}a \
--recvif ${epair_out}a \
--src 192.0.2.1 \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350714 - head/share/man/man9

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Aug  8 00:51:17 2019
New Revision: 350714
URL: https://svnweb.freebsd.org/changeset/base/350714

Log:
  Follow r350693 to add a link for sbuf_nl_terminate(9)
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/share/man/man9/Makefile

Modified: head/share/man/man9/Makefile
==
--- head/share/man/man9/MakefileThu Aug  8 00:42:29 2019
(r350713)
+++ head/share/man/man9/MakefileThu Aug  8 00:51:17 2019
(r350714)
@@ -1790,6 +1790,7 @@ MLINKS+=sbuf.9 sbuf_bcat.9 \
sbuf.9 sbuf_new.9 \
sbuf.9 sbuf_new_auto.9 \
sbuf.9 sbuf_new_for_sysctl.9 \
+   sbuf.9 sbuf_nl_terminate.9 \
sbuf.9 sbuf_printf.9 \
sbuf.9 sbuf_printf_drain.9 \
sbuf.9 sbuf_putbuf.9 \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r350512 - head/tests/sys/kern

[Li-Wen Hsu]

On Thu, Aug 8, 2019 at 4:27 AM Mark Johnston  wrote:
>
> On Thu, Aug 01, 2019 at 06:19:16PM +0000, Li-Wen Hsu wrote:
> > Author: lwhsu
> > Date: Thu Aug  1 18:19:16 2019
> > New Revision: 350512
> > URL: https://svnweb.freebsd.org/changeset/base/350512
> >
> > Log:
> >   Only skip test cases sometimes failing in CI when they are running in CI
> >
> >   Suggested by:   jhb
> >   Sponsored by:   The FreeBSD Foundation
>
> This seems to break running the tests manually; atf dies because the
> "ci" variable is not defined.  I have to use an invocation like this to
> avoid that:
>
> $ kyua -v test_suites.FreeBSD.ci=false test ptrace_test
>
> I suspect that share/mk/suite.test.mk needs to be augmented somehow to
> set this variable to "false" by default, so that the CI infrastructure
> can override that.

Thanks for catching this!  I feel that the better approach is using
function that gets this variable with default value, for keeping
things simple.

Best,
Li-Wen
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350700 - head/tests/sys/kern

[Li-Wen Hsu]

Author: lwhsu
Date: Wed Aug  7 21:02:23 2019
New Revision: 350700
URL: https://svnweb.freebsd.org/changeset/base/350700

Log:
  Get configuration variable with default value for not breaking default setting
  
  Reported by:  markj
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/kern/ptrace_test.c

Modified: head/tests/sys/kern/ptrace_test.c
==
--- head/tests/sys/kern/ptrace_test.c   Wed Aug  7 20:36:36 2019
(r350699)
+++ head/tests/sys/kern/ptrace_test.c   Wed Aug  7 21:02:23 2019
(r350700)
@@ -259,7 +259,7 @@ ATF_TC_BODY(ptrace__parent_sees_exit_after_child_debug
int cpipe[2], dpipe[2], status;
char c;
 
-   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
atf_tc_skip("https://bugs.freebsd.org/239399;);
 
ATF_REQUIRE(pipe(cpipe) == 0);
@@ -803,7 +803,7 @@ ATF_TC_BODY(ptrace__follow_fork_both_attached_unrelate
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
-   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
atf_tc_skip("https://bugs.freebsd.org/239397;);
 
ATF_REQUIRE(pipe(cpipe) == 0);
@@ -874,7 +874,7 @@ ATF_TC_BODY(ptrace__follow_fork_child_detached_unrelat
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
-   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
atf_tc_skip("https://bugs.freebsd.org/239292;);
 
ATF_REQUIRE(pipe(cpipe) == 0);
@@ -940,7 +940,7 @@ ATF_TC_BODY(ptrace__follow_fork_parent_detached_unrela
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
-   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
atf_tc_skip("https://bugs.freebsd.org/239425;);
 
ATF_REQUIRE(pipe(cpipe) == 0);
@@ -2089,7 +2089,7 @@ ATF_TC_BODY(ptrace__PT_KILL_competing_stop, tc)
struct ptrace_lwpinfo pl;
struct sched_param sched_param;
 
-   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
atf_tc_skip("https://bugs.freebsd.org/220841;);
 
ATF_REQUIRE((fpid = fork()) != -1);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350512 - head/tests/sys/kern

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Aug  1 18:19:16 2019
New Revision: 350512
URL: https://svnweb.freebsd.org/changeset/base/350512

Log:
  Only skip test cases sometimes failing in CI when they are running in CI
  
  Suggested by: jhb
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/kern/ptrace_test.c

Modified: head/tests/sys/kern/ptrace_test.c
==
--- head/tests/sys/kern/ptrace_test.c   Thu Aug  1 17:59:56 2019
(r350511)
+++ head/tests/sys/kern/ptrace_test.c   Thu Aug  1 18:19:16 2019
(r350512)
@@ -258,7 +258,8 @@ ATF_TC_BODY(ptrace__parent_sees_exit_after_child_debug
int cpipe[2], dpipe[2], status;
char c;
 
-   atf_tc_skip("https://bugs.freebsd.org/239399;);
+   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   atf_tc_skip("https://bugs.freebsd.org/239399;);
 
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((child = fork()) != -1);
@@ -801,7 +802,8 @@ ATF_TC_BODY(ptrace__follow_fork_both_attached_unrelate
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
-   atf_tc_skip("https://bugs.freebsd.org/239397;);
+   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   atf_tc_skip("https://bugs.freebsd.org/239397;);
 
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((fpid = fork()) != -1);
@@ -871,7 +873,8 @@ ATF_TC_BODY(ptrace__follow_fork_child_detached_unrelat
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
-   atf_tc_skip("https://bugs.freebsd.org/239292;);
+   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   atf_tc_skip("https://bugs.freebsd.org/239292;);
 
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((fpid = fork()) != -1);
@@ -936,7 +939,8 @@ ATF_TC_BODY(ptrace__follow_fork_parent_detached_unrela
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
-   atf_tc_skip("https://bugs.freebsd.org/239425;);
+   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   atf_tc_skip("https://bugs.freebsd.org/239425;);
 
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((fpid = fork()) != -1);
@@ -2084,7 +2088,8 @@ ATF_TC_BODY(ptrace__PT_KILL_competing_stop, tc)
struct ptrace_lwpinfo pl;
struct sched_param sched_param;
 
-   atf_tc_skip("https://bugs.freebsd.org/220841;);
+   if (atf_tc_get_config_var_as_bool(tc, "ci"))
+   atf_tc_skip("https://bugs.freebsd.org/220841;);
 
ATF_REQUIRE((fpid = fork()) != -1);
if (fpid == 0) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350322 - head

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Jul 25 07:57:01 2019
New Revision: 350322
URL: https://svnweb.freebsd.org/changeset/base/350322

Log:
  Workaround the build failure on platforms have lib32 after r350301
  
  Error message:
  
  make[5]: make[5]: don't know how to make 
/usr/obj/usr/src/amd64.amd64/obj-lib32/tmp/sys/netinet/in.h. Stop
  
  make[5]: stopped in /usr/src/lib/libsysdecode
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/Makefile.libcompat

Modified: head/Makefile.libcompat
==
--- head/Makefile.libcompat Thu Jul 25 06:48:30 2019(r350321)
+++ head/Makefile.libcompat Thu Jul 25 07:57:01 2019(r350322)
@@ -186,6 +186,7 @@ build${libcompat}: .PHONY
 .endif
mkdir -p ${WORLDTMP}
ln -sf ${.CURDIR}/sys ${WORLDTMP}
+   ln -sf ${.CURDIR}/sys ${LIBCOMPATTMP}
 .for _t in ${_obj} includes
 .for _dir in ${_LC_INCDIRS}
${_+_}cd ${.CURDIR}/${_dir}; ${LIBCOMPATWMAKE} MK_INCLUDES=yes \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350295 - head/tests/sys/kern

[Li-Wen Hsu]

Author: lwhsu
Date: Wed Jul 24 17:41:40 2019
New Revision: 350295
URL: https://svnweb.freebsd.org/changeset/base/350295

Log:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger
  
  PR:   239425
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/kern/ptrace_test.c

Modified: head/tests/sys/kern/ptrace_test.c
==
--- head/tests/sys/kern/ptrace_test.c   Wed Jul 24 16:51:14 2019
(r350294)
+++ head/tests/sys/kern/ptrace_test.c   Wed Jul 24 17:41:40 2019
(r350295)
@@ -936,6 +936,8 @@ ATF_TC_BODY(ptrace__follow_fork_parent_detached_unrela
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
+   atf_tc_skip("https://bugs.freebsd.org/239425;);
+
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((fpid = fork()) != -1);
if (fpid == 0) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350239 - head/tests/sys/kern

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Jul 23 09:39:27 2019
New Revision: 350239
URL: https://svnweb.freebsd.org/changeset/base/350239

Log:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger
  
  PR:   239399
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/kern/ptrace_test.c

Modified: head/tests/sys/kern/ptrace_test.c
==
--- head/tests/sys/kern/ptrace_test.c   Tue Jul 23 09:19:58 2019
(r350238)
+++ head/tests/sys/kern/ptrace_test.c   Tue Jul 23 09:39:27 2019
(r350239)
@@ -258,6 +258,8 @@ ATF_TC_BODY(ptrace__parent_sees_exit_after_child_debug
int cpipe[2], dpipe[2], status;
char c;
 
+   atf_tc_skip("https://bugs.freebsd.org/239399;);
+
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((child = fork()) != -1);
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350238 - head/tests/sys/kern

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Jul 23 09:19:58 2019
New Revision: 350238
URL: https://svnweb.freebsd.org/changeset/base/350238

Log:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger
  
  PR:   239397
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/kern/ptrace_test.c

Modified: head/tests/sys/kern/ptrace_test.c
==
--- head/tests/sys/kern/ptrace_test.c   Tue Jul 23 08:20:52 2019
(r350237)
+++ head/tests/sys/kern/ptrace_test.c   Tue Jul 23 09:19:58 2019
(r350238)
@@ -799,6 +799,8 @@ ATF_TC_BODY(ptrace__follow_fork_both_attached_unrelate
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
+   atf_tc_skip("https://bugs.freebsd.org/239397;);
+
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((fpid = fork()) != -1);
if (fpid == 0) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350237 - stable/12/tests/sys/netpfil/pf

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Jul 23 08:20:52 2019
New Revision: 350237
URL: https://svnweb.freebsd.org/changeset/base/350237

Log:
  MFC r350221
  
  Temporarily skip sys.netpfil.pf.forward.{v4,v6} and sys.netpfil.pf.set_tos.v4
  on i386 as they are flakey on it
  
  PR:   239380
  Sponsored by: The FreeBSD Foundation

Modified:
  stable/12/tests/sys/netpfil/pf/forward.sh
  stable/12/tests/sys/netpfil/pf/set_tos.sh
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/tests/sys/netpfil/pf/forward.sh
==
--- stable/12/tests/sys/netpfil/pf/forward.sh   Tue Jul 23 08:18:08 2019
(r350236)
+++ stable/12/tests/sys/netpfil/pf/forward.sh   Tue Jul 23 08:20:52 2019
(r350237)
@@ -14,6 +14,10 @@ v4_head()
 
 v4_body()
 {
+   if [ `uname -p` = "i386" ]; then
+   atf_skip "https://bugs.freebsd.org/239380;
+   fi
+
pft_init
 
epair_send=$(vnet_mkepair)
@@ -73,6 +77,10 @@ v6_head()
 
 v6_body()
 {
+   if [ `uname -p` = "i386" ]; then
+   atf_skip "https://bugs.freebsd.org/239380;
+   fi
+
pft_init
 
epair_send=$(vnet_mkepair)

Modified: stable/12/tests/sys/netpfil/pf/set_tos.sh
==
--- stable/12/tests/sys/netpfil/pf/set_tos.sh   Tue Jul 23 08:18:08 2019
(r350236)
+++ stable/12/tests/sys/netpfil/pf/set_tos.sh   Tue Jul 23 08:20:52 2019
(r350237)
@@ -14,6 +14,10 @@ v4_head()
 
 v4_body()
 {
+   if [ `uname -p` = "i386" ]; then
+   atf_skip "https://bugs.freebsd.org/239380;
+   fi
+
pft_init
 
epair_send=$(vnet_mkepair)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350236 - stable/12/contrib/netbsd-tests/lib/libc/regex

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Jul 23 08:18:08 2019
New Revision: 350236
URL: https://svnweb.freebsd.org/changeset/base/350236

Log:
  MFC r350219
  
  Temporarily skip lib.libc.regex.exhaust_test.regcomp_too_big and
  lib.libregex.exhaust_test.regcomp_too_big on i386 as they are flakey on it
  
  PR:   237450
  Sponsored by: The FreeBSD Foundation

Modified:
  stable/12/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c
==
--- stable/12/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c   Tue Jul 23 
07:56:42 2019(r350235)
+++ stable/12/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c   Tue Jul 23 
08:18:08 2019(r350236)
@@ -186,6 +186,10 @@ ATF_TC_BODY(regcomp_too_big, tc)
int e;
struct rlimit limit;
 
+#if defined(__i386__)
+   atf_tc_skip("https://bugs.freebsd.org/237450;);
+#endif
+
limit.rlim_cur = limit.rlim_max = 256 * 1024 * 1024;
ATF_REQUIRE(setrlimit(RLIMIT_VMEM, ) != -1);
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350235 - head/tests/sys/kern

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Jul 23 07:56:42 2019
New Revision: 350235
URL: https://svnweb.freebsd.org/changeset/base/350235

Log:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop
  
  PR:   220841
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/kern/ptrace_test.c

Modified: head/tests/sys/kern/ptrace_test.c
==
--- head/tests/sys/kern/ptrace_test.c   Tue Jul 23 02:30:24 2019
(r350234)
+++ head/tests/sys/kern/ptrace_test.c   Tue Jul 23 07:56:42 2019
(r350235)
@@ -2078,6 +2078,8 @@ ATF_TC_BODY(ptrace__PT_KILL_competing_stop, tc)
struct ptrace_lwpinfo pl;
struct sched_param sched_param;
 
+   atf_tc_skip("https://bugs.freebsd.org/220841;);
+
ATF_REQUIRE((fpid = fork()) != -1);
if (fpid == 0) {
trace_me();
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350221 - head/tests/sys/netpfil/pf

[Li-Wen Hsu]

Author: lwhsu
Date: Mon Jul 22 18:54:26 2019
New Revision: 350221
URL: https://svnweb.freebsd.org/changeset/base/350221

Log:
  Temporarily skip sys.netpfil.pf.forward.{v4,v6} and sys.netpfil.pf.set_tos.v4
  on i386 as they are flakey on it
  
  PR:   239380
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/netpfil/pf/forward.sh
  head/tests/sys/netpfil/pf/set_tos.sh

Modified: head/tests/sys/netpfil/pf/forward.sh
==
--- head/tests/sys/netpfil/pf/forward.shMon Jul 22 18:43:46 2019
(r350220)
+++ head/tests/sys/netpfil/pf/forward.shMon Jul 22 18:54:26 2019
(r350221)
@@ -14,6 +14,10 @@ v4_head()
 
 v4_body()
 {
+   if [ `uname -p` = "i386" ]; then
+   atf_skip "https://bugs.freebsd.org/239380;
+   fi
+
pft_init
 
epair_send=$(vnet_mkepair)
@@ -73,6 +77,10 @@ v6_head()
 
 v6_body()
 {
+   if [ `uname -p` = "i386" ]; then
+   atf_skip "https://bugs.freebsd.org/239380;
+   fi
+
pft_init
 
epair_send=$(vnet_mkepair)

Modified: head/tests/sys/netpfil/pf/set_tos.sh
==
--- head/tests/sys/netpfil/pf/set_tos.shMon Jul 22 18:43:46 2019
(r350220)
+++ head/tests/sys/netpfil/pf/set_tos.shMon Jul 22 18:54:26 2019
(r350221)
@@ -14,6 +14,10 @@ v4_head()
 
 v4_body()
 {
+   if [ `uname -p` = "i386" ]; then
+   atf_skip "https://bugs.freebsd.org/239380;
+   fi
+
pft_init
 
epair_send=$(vnet_mkepair)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350220 - head/tests/sys/kern

[Li-Wen Hsu]

Author: lwhsu
Date: Mon Jul 22 18:43:46 2019
New Revision: 350220
URL: https://svnweb.freebsd.org/changeset/base/350220

Log:
  Fix URL.
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/kern/ptrace_test.c

Modified: head/tests/sys/kern/ptrace_test.c
==
--- head/tests/sys/kern/ptrace_test.c   Mon Jul 22 18:42:55 2019
(r350219)
+++ head/tests/sys/kern/ptrace_test.c   Mon Jul 22 18:43:46 2019
(r350220)
@@ -867,7 +867,7 @@ ATF_TC_BODY(ptrace__follow_fork_child_detached_unrelat
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
-   atf_tc_skip("https://bugs.freebsd.org/bug239292;);
+   atf_tc_skip("https://bugs.freebsd.org/239292;);
 
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((fpid = fork()) != -1);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350219 - head/contrib/netbsd-tests/lib/libc/regex

[Li-Wen Hsu]

Author: lwhsu
Date: Mon Jul 22 18:42:55 2019
New Revision: 350219
URL: https://svnweb.freebsd.org/changeset/base/350219

Log:
  Temporarily skip lib.libc.regex.exhaust_test.regcomp_too_big and
  lib.libregex.exhaust_test.regcomp_too_big on i386 as they are flakey on it
  
  PR:   237450
  Sponsored by: The FreeBSD Foundation

Modified:
  head/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c

Modified: head/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c
==
--- head/contrib/netbsd-tests/lib/libc/regex/t_exhaust.cMon Jul 22 
18:27:17 2019(r350218)
+++ head/contrib/netbsd-tests/lib/libc/regex/t_exhaust.cMon Jul 22 
18:42:55 2019(r350219)
@@ -186,6 +186,10 @@ ATF_TC_BODY(regcomp_too_big, tc)
int e;
struct rlimit limit;
 
+#if defined(__i386__)
+   atf_tc_skip("https://bugs.freebsd.org/237450;);
+#endif
+
limit.rlim_cur = limit.rlim_max = 256 * 1024 * 1024;
ATF_REQUIRE(setrlimit(RLIMIT_VMEM, ) != -1);
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350211 - head/tests/sys/kern

[Li-Wen Hsu]

Author: lwhsu
Date: Mon Jul 22 10:37:56 2019
New Revision: 350211
URL: https://svnweb.freebsd.org/changeset/base/350211

Log:
  Temporarily skip flakey test case
  sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger
  
  PR:   239292
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/kern/ptrace_test.c

Modified: head/tests/sys/kern/ptrace_test.c
==
--- head/tests/sys/kern/ptrace_test.c   Mon Jul 22 10:17:59 2019
(r350210)
+++ head/tests/sys/kern/ptrace_test.c   Mon Jul 22 10:37:56 2019
(r350211)
@@ -867,6 +867,8 @@ ATF_TC_BODY(ptrace__follow_fork_child_detached_unrelat
pid_t children[2], fpid, wpid;
int cpipe[2], status;
 
+   atf_tc_skip("https://bugs.freebsd.org/bug239292;);
+
ATF_REQUIRE(pipe(cpipe) == 0);
ATF_REQUIRE((fpid = fork()) != -1);
if (fpid == 0) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350209 - stable/11/tests/sys/opencrypto

[Li-Wen Hsu]

Author: lwhsu
Date: Mon Jul 22 08:27:44 2019
New Revision: 350209
URL: https://svnweb.freebsd.org/changeset/base/350209

Log:
  MFC r346431, r349872
  
  r346431
  Specify using Python2, these .py files have not been converted to use Python3
  yet, but the default Python version in ports has been switched to 3.
  
  Sponsored by:   The FreeBSD Foundation
  
  r349872
  Correct definitions in sys.opencrypto.runtests.main for 32bit platform
  
  Reviewed by:cem, jhb
  MFC after:  3 days
  Sponsored by:   The FreeBSD Foundation
  Differential Revision:  https://reviews.freebsd.org/D20894

Modified:
  stable/11/tests/sys/opencrypto/Makefile
  stable/11/tests/sys/opencrypto/cryptodev.py
  stable/11/tests/sys/opencrypto/cryptotest.py
  stable/11/tests/sys/opencrypto/runtests.sh
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/tests/sys/opencrypto/Makefile
==
--- stable/11/tests/sys/opencrypto/Makefile Mon Jul 22 07:19:46 2019
(r350208)
+++ stable/11/tests/sys/opencrypto/Makefile Mon Jul 22 08:27:44 2019
(r350209)
@@ -7,7 +7,7 @@ BINDIR= ${TESTSDIR}
 
 PLAIN_TESTS_SH=runtests
 
-TEST_METADATA.runtests+= required_programs="python"
+TEST_METADATA.runtests+= required_programs="python2"
 TEST_METADATA.runtests+= required_user="root"
 
 PYMODULES= cryptodev.py cryptodevh.py cryptotest.py dpkt.py

Modified: stable/11/tests/sys/opencrypto/cryptodev.py
==
--- stable/11/tests/sys/opencrypto/cryptodev.py Mon Jul 22 07:19:46 2019
(r350208)
+++ stable/11/tests/sys/opencrypto/cryptodev.py Mon Jul 22 08:27:44 2019
(r350209)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/local/bin/python2
 #
 # Copyright (c) 2014 The FreeBSD Foundation
 # Copyright 2014 John-Mark Gurney
@@ -34,6 +34,7 @@ import array
 import dpkt
 from fcntl import ioctl
 import os
+import platform
 import signal
 from struct import pack as _pack
 
@@ -105,14 +106,19 @@ class CryptAEAD(dpkt.Packet):
 # h2py.py can't handle multiarg macros
 CRIOGET = 3221513060
 CIOCGSESSION = 3224396645
-CIOCGSESSION2 = 3225445226
 CIOCFSESSION = 2147771238
-CIOCCRYPT = 3224396647
 CIOCKEY = 3230688104
 CIOCASYMFEAT = 1074029417
 CIOCKEY2 = 3230688107
 CIOCFINDDEV = 3223610220
-CIOCCRYPTAEAD = 3225445229
+if platform.architecture()[0] == '64bit':
+CIOCGSESSION2 = 3225445226
+CIOCCRYPT = 3224396647
+CIOCCRYPTAEAD = 3225445229
+else:
+CIOCGSESSION2 = 3224396650
+CIOCCRYPT = 3223085927
+CIOCCRYPTAEAD = 3223872365
 
 def _getdev():
fd = os.open('/dev/crypto', os.O_RDWR)

Modified: stable/11/tests/sys/opencrypto/cryptotest.py
==
--- stable/11/tests/sys/opencrypto/cryptotest.pyMon Jul 22 07:19:46 
2019(r350208)
+++ stable/11/tests/sys/opencrypto/cryptotest.pyMon Jul 22 08:27:44 
2019(r350209)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/local/bin/python2
 #
 # Copyright (c) 2014 The FreeBSD Foundation
 # All rights reserved.

Modified: stable/11/tests/sys/opencrypto/runtests.sh
==
--- stable/11/tests/sys/opencrypto/runtests.sh  Mon Jul 22 07:19:46 2019
(r350208)
+++ stable/11/tests/sys/opencrypto/runtests.sh  Mon Jul 22 08:27:44 2019
(r350209)
@@ -61,6 +61,6 @@ done
 oldcdas=$(sysctl -e kern.cryptodevallowsoft)
 sysctl kern.cryptodevallowsoft=1
 
-python $(dirname $0)/cryptotest.py
+python2 $(dirname $0)/cryptotest.py
 
 sysctl "$oldcdas"
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350165 - stable/12/share/man/man9

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Jul 20 08:40:31 2019
New Revision: 350165
URL: https://svnweb.freebsd.org/changeset/base/350165

Log:
  MFC r349543
  
  Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK
  
  Submitted by: Ka Ho Ng 
  Reviewed by:  mckusick
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20695

Modified:
  stable/12/share/man/man9/VOP_GETPAGES.9
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/share/man/man9/VOP_GETPAGES.9
==
--- stable/12/share/man/man9/VOP_GETPAGES.9 Sat Jul 20 07:04:25 2019
(r350164)
+++ stable/12/share/man/man9/VOP_GETPAGES.9 Sat Jul 20 08:40:31 2019
(r350165)
@@ -29,7 +29,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd May 7, 2017
+.Dd June 29, 2019
 .Dt VOP_GETPAGES 9
 .Os
 .Sh NAME
@@ -105,7 +105,7 @@ This could occur via a call to
 which puts such pages onto the head of the inactive queue.
 If
 .Dv VM_PAGER_CLUSTER_OK
-is set, writes may be performed asynchronously, so that related writes
+is set, writes may be delayed, so that related writes
 can be coalesced for efficiency, e.g.,
 using the clustering mechanism of the buffer cache.
 .It Fa rtvals
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350164 - stable/12/tests/sys/opencrypto

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Jul 20 07:04:25 2019
New Revision: 350164
URL: https://svnweb.freebsd.org/changeset/base/350164

Log:
  MFC r349872:
  
  Correct definitions in sys.opencrypto.runtests.main for 32bit platform
  
  Reviewed by:  cem, jhb
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20894

Modified:
  stable/12/tests/sys/opencrypto/cryptodev.py
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/tests/sys/opencrypto/cryptodev.py
==
--- stable/12/tests/sys/opencrypto/cryptodev.py Sat Jul 20 05:21:13 2019
(r350163)
+++ stable/12/tests/sys/opencrypto/cryptodev.py Sat Jul 20 07:04:25 2019
(r350164)
@@ -35,6 +35,7 @@ import array
 import dpkt
 from fcntl import ioctl
 import os
+import platform
 import signal
 from struct import pack as _pack
 
@@ -106,14 +107,19 @@ class CryptAEAD(dpkt.Packet):
 # h2py.py can't handle multiarg macros
 CRIOGET = 3221513060
 CIOCGSESSION = 3224396645
-CIOCGSESSION2 = 3225445226
 CIOCFSESSION = 2147771238
-CIOCCRYPT = 3224396647
 CIOCKEY = 3230688104
 CIOCASYMFEAT = 1074029417
 CIOCKEY2 = 3230688107
 CIOCFINDDEV = 3223610220
-CIOCCRYPTAEAD = 3225445229
+if platform.architecture()[0] == '64bit':
+CIOCGSESSION2 = 3225445226
+CIOCCRYPT = 3224396647
+CIOCCRYPTAEAD = 3225445229
+else:
+CIOCGSESSION2 = 3224396650
+CIOCCRYPT = 3223085927
+CIOCCRYPTAEAD = 3223872365
 
 def _getdev():
fd = os.open('/dev/crypto', os.O_RDWR)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r350044 - in stable/12: share/man/man4 sys/dev/gpio

[Li-Wen Hsu]

On Wed, Jul 17, 2019 at 1:29 AM Andriy Gapon  wrote:
>
> On 16/07/2019 18:52, Andriy Gapon wrote:
> > Author: avg
> > Date: Tue Jul 16 15:52:47 2019
> > New Revision: 350044
> > URL: https://svnweb.freebsd.org/changeset/base/350044
> >
> > Log:
> >   MFC r349460: gpiobus: provide a new hint, pin_list
> >
> >   "pin_list" allows to specify child pins as a list of pin numbers.
> >   Existing hint "pins" serves the same purpose but with a 32-bit wide bit
> >   mask.  One problem with that is that a controller can have more than 32
> >   pins.  One example is amdgpio.  Also, a list of numbers is a little bit
> >   more human friendly than a matching bit mask.  As a side note, it seems
> >   that in FDT pins are typically specified by their numbers as well.
> >
> >   This commit also adds accessors for instance variables (IVARs) that
> >   define the child pins.  My primary goal is to allow a child to be
> >   configured programmatically rather than via hints (assuming that FDT is
> >   not supported on a platform).  Also, while a child should not care about
> >   specific pin numbers that are allocated to it, it could be interested in
> >   how many were actually assigned to it.
> >
> >   While there, I removed "flags" instance variable.  It was unused.
>
> This change (the "flags" removal, specifically) broke build on OFW
> platforms (powerpc).
> I am working on a fix, it should be trivial.

I've merged r349472 and it should be fine now.

Best,
Li-Wen
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350053 - stable/11/sys/dev/gpio

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Jul 16 16:26:51 2019
New Revision: 350053
URL: https://svnweb.freebsd.org/changeset/base/350053

Log:
  MFC r349472:
  
  Follow r349460 to complete removing "flags" in struct gpiobus_ivar
  
  Sponsored by: The FreeBSD Foundation

Modified:
  stable/11/sys/dev/gpio/ofw_gpiobus.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/gpio/ofw_gpiobus.c
==
--- stable/11/sys/dev/gpio/ofw_gpiobus.cTue Jul 16 16:25:27 2019
(r350052)
+++ stable/11/sys/dev/gpio/ofw_gpiobus.cTue Jul 16 16:26:51 2019
(r350053)
@@ -317,10 +317,8 @@ ofw_gpiobus_setup_devinfo(device_t bus, device_t child
ofw_gpiobus_destroy_devinfo(bus, dinfo);
return (NULL);
}
-   for (i = 0; i < devi->npins; i++) {
-   devi->flags[i] = pins[i].flags;
+   for (i = 0; i < devi->npins; i++)
devi->pins[i] = pins[i].pin;
-   }
free(pins, M_DEVBUF);
/* Parse the interrupt resources. */
if (ofw_bus_intr_to_rl(bus, node, >opd_dinfo.rl, NULL) != 0) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r350051 - stable/12/sys/dev/gpio

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Jul 16 16:23:56 2019
New Revision: 350051
URL: https://svnweb.freebsd.org/changeset/base/350051

Log:
  MFC r349472:
  
  Follow r349460 to complete removing "flags" in struct gpiobus_ivar
  
  Sponsored by: The FreeBSD Foundation

Modified:
  stable/12/sys/dev/gpio/ofw_gpiobus.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/gpio/ofw_gpiobus.c
==
--- stable/12/sys/dev/gpio/ofw_gpiobus.cTue Jul 16 16:05:42 2019
(r350050)
+++ stable/12/sys/dev/gpio/ofw_gpiobus.cTue Jul 16 16:23:56 2019
(r350051)
@@ -321,10 +321,8 @@ ofw_gpiobus_setup_devinfo(device_t bus, device_t child
ofw_gpiobus_destroy_devinfo(bus, dinfo);
return (NULL);
}
-   for (i = 0; i < devi->npins; i++) {
-   devi->flags[i] = pins[i].flags;
+   for (i = 0; i < devi->npins; i++)
devi->pins[i] = pins[i].pin;
-   }
free(pins, M_DEVBUF);
/* Parse the interrupt resources. */
if (ofw_bus_intr_to_rl(bus, node, >opd_dinfo.rl, NULL) != 0) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349872 - head/tests/sys/opencrypto

[Li-Wen Hsu]

Author: lwhsu
Date: Wed Jul 10 01:08:08 2019
New Revision: 349872
URL: https://svnweb.freebsd.org/changeset/base/349872

Log:
  Correct definitions in sys.opencrypto.runtests.main for 32bit platform
  
  Reviewed by:  cem, jhb
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20894

Modified:
  head/tests/sys/opencrypto/cryptodev.py

Modified: head/tests/sys/opencrypto/cryptodev.py
==
--- head/tests/sys/opencrypto/cryptodev.py  Tue Jul  9 23:58:12 2019
(r349871)
+++ head/tests/sys/opencrypto/cryptodev.py  Wed Jul 10 01:08:08 2019
(r349872)
@@ -36,6 +36,7 @@ import array
 import binascii
 from fcntl import ioctl
 import os
+import platform
 import random
 import signal
 from struct import pack as _pack
@@ -116,14 +117,19 @@ class CryptAEAD(dpkt.Packet):
 # h2py.py can't handle multiarg macros
 CRIOGET = 3221513060
 CIOCGSESSION = 3224396645
-CIOCGSESSION2 = 3225445226
 CIOCFSESSION = 2147771238
-CIOCCRYPT = 3224396647
 CIOCKEY = 3230688104
 CIOCASYMFEAT = 1074029417
 CIOCKEY2 = 3230688107
 CIOCFINDDEV = 3223610220
-CIOCCRYPTAEAD = 3225445229
+if platform.architecture()[0] == '64bit':
+CIOCGSESSION2 = 3225445226
+CIOCCRYPT = 3224396647
+CIOCCRYPTAEAD = 3225445229
+else:
+CIOCGSESSION2 = 3224396650
+CIOCCRYPT = 3223085927
+CIOCCRYPTAEAD = 3223872365
 
 def _getdev():
 buf = array.array('I', [0])
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349858 - stable/12/tests/sys/netpfil/pf

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Jul  9 09:09:51 2019
New Revision: 349858
URL: https://svnweb.freebsd.org/changeset/base/349858

Log:
  MFC r349539
  
  Skip sys.netpfil.pf.names.names and sys.netpfil.pf.synproxy.synproxy
  temporarily because kernel panics when flushing epair queue.
  
  PR:   238870
  Sponsored by: The FreeBSD Foundation

Modified:
  stable/12/tests/sys/netpfil/pf/names.sh
  stable/12/tests/sys/netpfil/pf/synproxy.sh
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/tests/sys/netpfil/pf/names.sh
==
--- stable/12/tests/sys/netpfil/pf/names.sh Tue Jul  9 08:21:14 2019
(r349857)
+++ stable/12/tests/sys/netpfil/pf/names.sh Tue Jul  9 09:09:51 2019
(r349858)
@@ -11,6 +11,7 @@ names_head()
 
 names_body()
 {
+   atf_skip "Kernel panics when flushing epair queue (bug238870)"
pft_init
 
epair=$(vnet_mkepair)

Modified: stable/12/tests/sys/netpfil/pf/synproxy.sh
==
--- stable/12/tests/sys/netpfil/pf/synproxy.sh  Tue Jul  9 08:21:14 2019
(r349857)
+++ stable/12/tests/sys/netpfil/pf/synproxy.sh  Tue Jul  9 09:09:51 2019
(r349858)
@@ -11,6 +11,7 @@ synproxy_head()
 
 synproxy_body()
 {
+   atf_skip "Kernel panics when flushing epair queue (bug238870)"
pft_init
 
epair=$(vnet_mkepair)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349848 - head/sys/dev/superio

[Li-Wen Hsu]

Author: lwhsu
Date: Mon Jul  8 20:01:28 2019
New Revision: 349848
URL: https://svnweb.freebsd.org/changeset/base/349848

Log:
  - Fix gcc build for superio(4)
  - Change string mapping of SUPERIO_DEV_NONE to distinguish from 
SUPERIO_DEV_MAX
  
  Reviewed by:  imp
  Discussed with:   avg, imp, jhb
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20880

Modified:
  head/sys/dev/superio/superio.c

Modified: head/sys/dev/superio/superio.c
==
--- head/sys/dev/superio/superio.c  Mon Jul  8 19:59:15 2019
(r349847)
+++ head/sys/dev/superio/superio.c  Mon Jul  8 20:01:28 2019
(r349848)
@@ -405,7 +405,7 @@ devtype_to_str(superio_dev_type_t type)
 {
switch (type) {
case SUPERIO_DEV_NONE:
-   return ("invalid");
+   return ("none");
case SUPERIO_DEV_HWM:
return ("HWM");
case SUPERIO_DEV_WDT:
@@ -415,6 +415,7 @@ devtype_to_str(superio_dev_type_t type)
case SUPERIO_DEV_MAX:
return ("invalid");
}
+   return ("invalid");
 }
 
 static int
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349847 - head/sys/dev/cxgbe/tom

[Li-Wen Hsu]

Author: lwhsu
Date: Mon Jul  8 19:59:15 2019
New Revision: 349847
URL: https://svnweb.freebsd.org/changeset/base/349847

Log:
  Fix gcc build for cxgbe(4)
  
  Reviewed by:  jhb
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20879

Modified:
  head/sys/dev/cxgbe/tom/t4_cpl_io.c

Modified: head/sys/dev/cxgbe/tom/t4_cpl_io.c
==
--- head/sys/dev/cxgbe/tom/t4_cpl_io.c  Mon Jul  8 19:46:20 2019
(r349846)
+++ head/sys/dev/cxgbe/tom/t4_cpl_io.c  Mon Jul  8 19:59:15 2019
(r349847)
@@ -1985,7 +1985,7 @@ alloc_aiotx_mbuf(struct kaiocb *job, int len)
last = NULL;
while (len > 0) {
mlen = imin(len, MBUF_PEXT_MAX_PGS * PAGE_SIZE - pgoff);
-   KASSERT(mlen == len || (start + mlen & PAGE_MASK) == 0,
+   KASSERT(mlen == len || ((start + mlen) & PAGE_MASK) == 0,
("%s: next start (%#jx + %#x) is not page aligned",
__func__, (uintmax_t)start, mlen));
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349543 - head/share/man/man9

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Jun 29 14:55:53 2019
New Revision: 349543
URL: https://svnweb.freebsd.org/changeset/base/349543

Log:
  Fix VOP_PUTPAGES(9) in regards to the use of VM_PAGER_CLUSTER_OK
  
  Submitted by: Ka Ho Ng 
  Reviewed by:  mckusick
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20695

Modified:
  head/share/man/man9/VOP_GETPAGES.9

Modified: head/share/man/man9/VOP_GETPAGES.9
==
--- head/share/man/man9/VOP_GETPAGES.9  Sat Jun 29 13:30:05 2019
(r349542)
+++ head/share/man/man9/VOP_GETPAGES.9  Sat Jun 29 14:55:53 2019
(r349543)
@@ -29,7 +29,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd May 7, 2017
+.Dd June 29, 2019
 .Dt VOP_GETPAGES 9
 .Os
 .Sh NAME
@@ -105,7 +105,7 @@ This could occur via a call to
 which puts such pages onto the head of the inactive queue.
 If
 .Dv VM_PAGER_CLUSTER_OK
-is set, writes may be performed asynchronously, so that related writes
+is set, writes may be delayed, so that related writes
 can be coalesced for efficiency, e.g.,
 using the clustering mechanism of the buffer cache.
 .It Fa rtvals
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349539 - head/tests/sys/netpfil/pf

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Jun 29 12:19:57 2019
New Revision: 349539
URL: https://svnweb.freebsd.org/changeset/base/349539

Log:
  Skip sys.netpfil.pf.names.names and sys.netpfil.pf.synproxy.synproxy
  temporarily because kernel panics when flushing epair queue.
  
  PR:   238870
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/netpfil/pf/names.sh
  head/tests/sys/netpfil/pf/synproxy.sh

Modified: head/tests/sys/netpfil/pf/names.sh
==
--- head/tests/sys/netpfil/pf/names.sh  Sat Jun 29 10:58:31 2019
(r349538)
+++ head/tests/sys/netpfil/pf/names.sh  Sat Jun 29 12:19:57 2019
(r349539)
@@ -11,6 +11,7 @@ names_head()
 
 names_body()
 {
+   atf_skip "Kernel panics when flushing epair queue (bug238870)"
pft_init
 
epair=$(vnet_mkepair)

Modified: head/tests/sys/netpfil/pf/synproxy.sh
==
--- head/tests/sys/netpfil/pf/synproxy.sh   Sat Jun 29 10:58:31 2019
(r349538)
+++ head/tests/sys/netpfil/pf/synproxy.sh   Sat Jun 29 12:19:57 2019
(r349539)
@@ -11,6 +11,7 @@ synproxy_head()
 
 synproxy_body()
 {
+   atf_skip "Kernel panics when flushing epair queue (bug238870)"
pft_init
 
epair=$(vnet_mkepair)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349538 - head/lib/libarchive/tests

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Jun 29 10:58:31 2019
New Revision: 349538
URL: https://svnweb.freebsd.org/changeset/base/349538

Log:
  Install missing test data file
  
  MFC with: r349527
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/libarchive/tests/Makefile

Modified: head/lib/libarchive/tests/Makefile
==
--- head/lib/libarchive/tests/Makefile  Sat Jun 29 09:14:53 2019
(r349537)
+++ head/lib/libarchive/tests/Makefile  Sat Jun 29 10:58:31 2019
(r349538)
@@ -512,6 +512,7 @@ ${PACKAGE}FILES+=   test_read_format_rar_subblock.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar_unicode.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar_windows.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_arm.rar.uu
+${PACKAGE}FILES+=  
test_read_format_rar5_arm_filter_on_window_boundary.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_blake2.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_compressed.rar.uu
 ${PACKAGE}FILES+=  test_read_format_rar5_different_window_size.rar.uu
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349472 - head/sys/dev/gpio

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Jun 27 22:18:21 2019
New Revision: 349472
URL: https://svnweb.freebsd.org/changeset/base/349472

Log:
  Follow r349460 to complete removing "flags" in struct gpiobus_ivar
  
  MFC with: r349460
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/dev/gpio/ofw_gpiobus.c

Modified: head/sys/dev/gpio/ofw_gpiobus.c
==
--- head/sys/dev/gpio/ofw_gpiobus.c Thu Jun 27 22:06:41 2019
(r349471)
+++ head/sys/dev/gpio/ofw_gpiobus.c Thu Jun 27 22:18:21 2019
(r349472)
@@ -321,10 +321,8 @@ ofw_gpiobus_setup_devinfo(device_t bus, device_t child
ofw_gpiobus_destroy_devinfo(bus, dinfo);
return (NULL);
}
-   for (i = 0; i < devi->npins; i++) {
-   devi->flags[i] = pins[i].flags;
+   for (i = 0; i < devi->npins; i++)
devi->pins[i] = pins[i].pin;
-   }
free(pins, M_DEVBUF);
/* Parse the interrupt resources. */
if (ofw_bus_intr_to_rl(bus, node, >opd_dinfo.rl, NULL) != 0) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349322 - head/tests/sys/netinet

[Li-Wen Hsu]

Author: lwhsu
Date: Sun Jun 23 19:37:12 2019
New Revision: 349322
URL: https://svnweb.freebsd.org/changeset/base/349322

Log:
  Skip sys.netinet.socket_afinet.socket_afinet_bind_zero temporarily because it
  doesn't work when mac_portacl(4) loaded
  
  PR:   238781
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/netinet/socket_afinet.c

Modified: head/tests/sys/netinet/socket_afinet.c
==
--- head/tests/sys/netinet/socket_afinet.c  Sun Jun 23 19:05:01 2019
(r349321)
+++ head/tests/sys/netinet/socket_afinet.c  Sun Jun 23 19:37:12 2019
(r349322)
@@ -51,6 +51,8 @@ ATF_TC_BODY(socket_afinet_bind_zero, tc)
int sd, rc;
struct sockaddr_in sin;
 
+   atf_tc_skip("doesn't work when mac_portacl(4) loaded (bug238781)");
+
sd = socket(PF_INET, SOCK_DGRAM, 0);
ATF_CHECK(sd >= 0);
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349225 - head/share/timedef

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Jun 20 07:17:16 2019
New Revision: 349225
URL: https://svnweb.freebsd.org/changeset/base/349225

Log:
  Finsh readding Big5 in r317204, which was reverting r315568.  This commit
  reverts r315569.
  
  Reported by:  Ting-Wei Lan 
  Discussed with:   kevlo
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation

Added:
  head/share/timedef/zh_TW.Big5.src
 - copied unchanged from r315568, head/share/timedef/zh_TW.Big5.src
Modified:
  head/share/timedef/Makefile

Modified: head/share/timedef/Makefile
==
--- head/share/timedef/Makefile Thu Jun 20 06:53:59 2019(r349224)
+++ head/share/timedef/Makefile Thu Jun 20 07:17:16 2019(r349225)
@@ -129,6 +129,7 @@ LOCALES+=   zh_CN.GBK
 LOCALES+=  zh_CN.UTF-8
 LOCALES+=  zh_CN.eucCN
 LOCALES+=  zh_HK.UTF-8
+LOCALES+=  zh_TW.Big5
 LOCALES+=  zh_TW.UTF-8
 
 

Copied: head/share/timedef/zh_TW.Big5.src (from r315568, 
head/share/timedef/zh_TW.Big5.src)
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ head/share/timedef/zh_TW.Big5.src   Thu Jun 20 07:17:16 2019
(r349225, copy of r315568, head/share/timedef/zh_TW.Big5.src)
@@ -0,0 +1,87 @@
+# Warning: Do not edit. This file is automatically generated from the
+# tools in /usr/src/tools/tools/locale. The data is obtained from the
+# CLDR project, obtained from http://cldr.unicode.org/
+# -
+#
+# Short month names
+�@
+�@
+�@
+�@
+�@
+�@
+�@
+�@
+�@
+��
+��
+��
+#
+# Long month names (as in a date)
+1��
+2��
+3��
+4��
+5��
+6��
+7��
+8��
+9��
+10��
+11��
+12��
+#
+# Short weekday names
+�g��
+�g�@
+�g�G
+�g�T
+�g�|
+�g��
+�g��
+#
+# Long weekday names
+�P
+�P���@
+�P���G
+�P���T
+�P���|
+�P
+�P
+#
+# X_fmt
+%H��%M��%S��
+#
+# x_fmt
+%Y/%m/%d
+#
+# c_fmt
+%a %b/%e %T %Y
+#
+# AM/PM
+�W��
+�U��
+#
+# date_fmt
+%Y�~%_m��%e�� %A %X %Z
+#
+# Long month names (without case ending)
+1��
+2��
+3��
+4��
+5��
+6��
+7��
+8��
+9��
+10��
+11��
+12��
+#
+# md_order
+md
+#
+# ampm_fmt
+%I:%M:%S %p
+# EOF
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349024 - stable/12/usr.bin/mandoc

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Jun 13 20:16:26 2019
New Revision: 349024
URL: https://svnweb.freebsd.org/changeset/base/349024

Log:
  MFC r346160:
  
  Suppress old gcc warning about null format string
  
  This is workaround to make head build on gcc using architectures
  
  Sponsored by: The FreeBSD Foundation

Modified:
  stable/12/usr.bin/mandoc/Makefile
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/usr.bin/mandoc/Makefile
==
--- stable/12/usr.bin/mandoc/Makefile   Thu Jun 13 20:09:07 2019
(r349023)
+++ stable/12/usr.bin/mandoc/Makefile   Thu Jun 13 20:16:26 2019
(r349024)
@@ -97,6 +97,8 @@ SRCS= ${LIB_SRCS} \
 WARNS?=3
 CFLAGS+= -DHAVE_CONFIG_H \
 -I${SRCTOP}/lib/libopenbsd/
+# This can be removed after swtiching to newer gcc
+CFLAGS.gcc+=   -Wno-format
 LIBADD=openbsd z
 
 .include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r349008 - head/stand/efi/boot1

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Jun 13 03:48:36 2019
New Revision: 349008
URL: https://svnweb.freebsd.org/changeset/base/349008

Log:
  Fix gcc build by removing redeclaration
  
  Reviewed by:  imp
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20622

Modified:
  head/stand/efi/boot1/boot_module.h

Modified: head/stand/efi/boot1/boot_module.h
==
--- head/stand/efi/boot1/boot_module.h  Thu Jun 13 01:23:03 2019
(r349007)
+++ head/stand/efi/boot1/boot_module.h  Thu Jun 13 03:48:36 2019
(r349008)
@@ -109,5 +109,4 @@ extern const boot_module_t zfs_module;
 
 /* Functions available to modules. */
 extern void add_device(dev_info_t **devinfop, dev_info_t *devinfo);
-extern int vsnprintf(char *str, size_t sz, const char *fmt, va_list ap);
 #endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r348454 - head/tests/sys/geom/class/eli

[Li-Wen Hsu]

Author: lwhsu
Date: Fri May 31 04:29:29 2019
New Revision: 348454
URL: https://svnweb.freebsd.org/changeset/base/348454

Log:
  Remove tests for the deprecated algorithms in r348206
  
  The tests are failing because the return value and output have changed, but
  before test code structure adjusted, removing these test cases help people
  be able to focus on more important cases.
  
  Discussed with:   emaste
  MFC with: r348206
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/geom/class/eli/conf.sh
  head/tests/sys/geom/class/eli/init_test.sh

Modified: head/tests/sys/geom/class/eli/conf.sh
==
--- head/tests/sys/geom/class/eli/conf.sh   Fri May 31 03:13:09 2019
(r348453)
+++ head/tests/sys/geom/class/eli/conf.sh   Fri May 31 04:29:29 2019
(r348454)
@@ -37,15 +37,10 @@ for_each_geli_config() {
 
for cipher in aes-xts:128 aes-xts:256 \
aes-cbc:128 aes-cbc:192 aes-cbc:256 \
-   3des-cbc:192 \
-   blowfish-cbc:128 blowfish-cbc:160 blowfish-cbc:192 \
-   blowfish-cbc:224 blowfish-cbc:256 blowfish-cbc:288 \
-   blowfish-cbc:320 blowfish-cbc:352 blowfish-cbc:384 \
-   blowfish-cbc:416 blowfish-cbc:448 \
camellia-cbc:128 camellia-cbc:192 camellia-cbc:256; do
ealgo=${cipher%%:*}
keylen=${cipher##*:}
-   for aalgo in hmac/md5 hmac/sha1 hmac/ripemd160 hmac/sha256 \
+   for aalgo in hmac/sha1 hmac/ripemd160 hmac/sha256 \
hmac/sha384 hmac/sha512; do
for secsize in 512 1024 2048 4096 $MAX_SECSIZE; do
${func} $cipher $aalgo $secsize
@@ -66,11 +61,6 @@ for_each_geli_config_nointegrity() {
md=$(attach_md -t malloc -s $bytes)
for cipher in aes-xts:128 aes-xts:256 \
aes-cbc:128 aes-cbc:192 aes-cbc:256 \
-   3des-cbc:192 \
-   blowfish-cbc:128 blowfish-cbc:160 blowfish-cbc:192 \
-   blowfish-cbc:224 blowfish-cbc:256 blowfish-cbc:288 \
-   blowfish-cbc:320 blowfish-cbc:352 blowfish-cbc:384 \
-   blowfish-cbc:416 blowfish-cbc:448 \
camellia-cbc:128 camellia-cbc:192 camellia-cbc:256; do
ealgo=${cipher%%:*}
keylen=${cipher##*:}

Modified: head/tests/sys/geom/class/eli/init_test.sh
==
--- head/tests/sys/geom/class/eli/init_test.sh  Fri May 31 03:13:09 2019
(r348453)
+++ head/tests/sys/geom/class/eli/init_test.sh  Fri May 31 04:29:29 2019
(r348454)
@@ -308,13 +308,6 @@ init_alias_body()
atf_check dd if=/dev/random of=keyfile bs=512 count=16 status=none
 
for spec in aes:0:AES-XTS:128 aes:128:AES-XTS:128 aes:256:AES-XTS:256 \
-   3des:0:3DES-CBC:192 3des:192:3DES-CBC:192 \
-   blowfish:0:Blowfish-CBC:128 blowfish:128:Blowfish-CBC:128 \
-   blowfish:160:Blowfish-CBC:160 blowfish:192:Blowfish-CBC:192 \
-   blowfish:224:Blowfish-CBC:224 blowfish:256:Blowfish-CBC:256 \
-   blowfish:288:Blowfish-CBC:288 blowfish:352:Blowfish-CBC:352 \
-   blowfish:384:Blowfish-CBC:384 blowfish:416:Blowfish-CBC:416 \
-   blowfish:448:Blowfish-CBC:448 \
camellia:0:CAMELLIA-CBC:128 camellia:128:CAMELLIA-CBC:128 \
camellia:256:CAMELLIA-CBC:256 ; do
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r348445 - head/sys/dev/ixl

[Li-Wen Hsu]

Author: lwhsu
Date: Thu May 30 20:42:36 2019
New Revision: 348445
URL: https://svnweb.freebsd.org/changeset/base/348445

Log:
  Add the missing braces to fix the code not guarded by the if clause and has
  misleading indentation.  This is found by gcc -Wmisleading-indentation
  
  Approved by:  erj
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20428

Modified:
  head/sys/dev/ixl/i40e_common.c

Modified: head/sys/dev/ixl/i40e_common.c
==
--- head/sys/dev/ixl/i40e_common.c  Thu May 30 19:18:01 2019
(r348444)
+++ head/sys/dev/ixl/i40e_common.c  Thu May 30 20:42:36 2019
(r348445)
@@ -383,13 +383,14 @@ void i40e_debug_aq(struct i40e_hw *hw, enum i40e_debug
  **/
 bool i40e_check_asq_alive(struct i40e_hw *hw)
 {
-   if (hw->aq.asq.len)
+   if (hw->aq.asq.len) {
if (!i40e_is_vf(hw))
return !!(rd32(hw, hw->aq.asq.len) &
I40E_PF_ATQLEN_ATQENABLE_MASK);
-   if (i40e_is_vf(hw))
+   else
return !!(rd32(hw, hw->aq.asq.len) &
I40E_VF_ATQLEN1_ATQENABLE_MASK);
+   }
return FALSE;
 }
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r348366 - head/sys/dev/ips

[Li-Wen Hsu]

Author: lwhsu
Date: Wed May 29 18:11:17 2019
New Revision: 348366
URL: https://svnweb.freebsd.org/changeset/base/348366

Log:
  Add the likely missing braces in ips(4).  This is found by gcc warning that
  the code is not guarded by the if clause and has misleading indentation.
  
  Approved by:  scottl
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20427

Modified:
  head/sys/dev/ips/ips.c

Modified: head/sys/dev/ips/ips.c
==
--- head/sys/dev/ips/ips.c  Wed May 29 16:39:52 2019(r348365)
+++ head/sys/dev/ips/ips.c  Wed May 29 18:11:17 2019(r348366)
@@ -287,10 +287,11 @@ static int ips_diskdev_free(ips_softc_t *sc)
int i;
int error = 0;
for(i = 0; i < IPS_MAX_NUM_DRIVES; i++){
-   if(sc->diskdev[i])
+   if(sc->diskdev[i]) {
error = device_delete_child(sc->dev, sc->diskdev[i]);
if(error)
return error;
+   }
}
bus_generic_detach(sc->dev);
return 0;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r348284 - head/sys/netpfil/pf

[Li-Wen Hsu]

Author: lwhsu
Date: Sat May 25 23:58:09 2019
New Revision: 348284
URL: https://svnweb.freebsd.org/changeset/base/348284

Log:
  Remove an uneeded indentation introduced in r223637 to silence gcc warnging
  
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/netpfil/pf/pf.c

Modified: head/sys/netpfil/pf/pf.c
==
--- head/sys/netpfil/pf/pf.cSat May 25 23:36:20 2019(r348283)
+++ head/sys/netpfil/pf/pf.cSat May 25 23:58:09 2019(r348284)
@@ -5260,7 +5260,7 @@ pf_test_state_other(struct pf_state **state, int direc
nk->addr[pd->didx].v4.s_addr,
0);
 
-   break;
+   break;
 #endif /* INET */
 #ifdef INET6
case AF_INET6:
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r348282 - head/usr.sbin/pw

[Li-Wen Hsu]

Author: lwhsu
Date: Sat May 25 21:57:01 2019
New Revision: 348282
URL: https://svnweb.freebsd.org/changeset/base/348282

Log:
  Remove an uneeded indentation introduced in r286196 to silence gcc warnging
  
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation

Modified:
  head/usr.sbin/pw/pw_user.c

Modified: head/usr.sbin/pw/pw_user.c
==
--- head/usr.sbin/pw/pw_user.c  Sat May 25 21:40:27 2019(r348281)
+++ head/usr.sbin/pw/pw_user.c  Sat May 25 21:57:01 2019(r348282)
@@ -589,7 +589,7 @@ print_user(struct passwd * pwd, bool pretty, bool v7)
}
if (pwd->pw_expire > (time_t)0 && (tptr = localtime(>pw_expire)) 
!= NULL)
strftime(acexpire, sizeof acexpire, "%c", tptr);
-   if (pwd->pw_change > (time_t)0 && (tptr = 
localtime(>pw_change)) != NULL)
+   if (pwd->pw_change > (time_t)0 && (tptr = localtime(>pw_change)) 
!= NULL)
strftime(pwexpire, sizeof pwexpire, "%c", tptr);
printf("Login Name: %-15s   #%-12ju Group: %-15s   #%ju\n"
   " Full Name: %s\n"
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r348231 - head/lib/geom/eli

[Li-Wen Hsu]

Author: lwhsu
Date: Fri May 24 06:49:47 2019
New Revision: 348231
URL: https://svnweb.freebsd.org/changeset/base/348231

Log:
  Correct the argument passed to g_eli_algo2str()
  
  MFC with: r348206
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/geom/eli/geom_eli.c

Modified: head/lib/geom/eli/geom_eli.c
==
--- head/lib/geom/eli/geom_eli.cFri May 24 06:27:11 2019
(r348230)
+++ head/lib/geom/eli/geom_eli.cFri May 24 06:49:47 2019
(r348231)
@@ -818,7 +818,7 @@ eli_init(struct gctl_req *req)
case CRYPTO_3DES_CBC:
case CRYPTO_BLF_CBC:
gctl_error(req, "The %s encryption algorithm is deprecated.",
-   g_eli_algo2str(md.md_aalgo));
+   g_eli_algo2str(md.md_ealgo));
return;
}
val = gctl_get_intmax(req, "keylen");
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r347999 - head/lib/libarchive/tests

[Li-Wen Hsu]

Author: lwhsu
Date: Mon May 20 18:07:45 2019
New Revision: 347999
URL: https://svnweb.freebsd.org/changeset/base/347999

Log:
  Install missing data file for
  lib.libarchive.functional_test.test_read_format_zip_utf8_paths
  
  MFC after:2 weeks (with r347989)
  Sponsored by: The FreeBSD Foundation

Modified:
  head/lib/libarchive/tests/Makefile

Modified: head/lib/libarchive/tests/Makefile
==
--- head/lib/libarchive/tests/Makefile  Mon May 20 17:43:58 2019
(r347998)
+++ head/lib/libarchive/tests/Makefile  Mon May 20 18:07:45 2019
(r347999)
@@ -557,6 +557,7 @@ ${PACKAGE}FILES+=   test_read_format_ustar_filename_eucj
 ${PACKAGE}FILES+=  test_read_format_ustar_filename_koi8r.tar.Z.uu
 ${PACKAGE}FILES+=  test_read_format_warc.warc.uu
 ${PACKAGE}FILES+=  test_read_format_zip.zip.uu
+${PACKAGE}FILES+=  test_read_format_zip_7075_utf8_paths.zip.uu
 ${PACKAGE}FILES+=  test_read_format_zip_bz2_hang.zip.uu
 ${PACKAGE}FILES+=  test_read_format_zip_bzip2.zipx.uu
 ${PACKAGE}FILES+=  test_read_format_zip_bzip2_multi.zipx.uu
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r347526 - head/sys/net

[Li-Wen Hsu]

On Mon, May 13, 2019 at 3:38 PM Mark Johnston  wrote:
>
> On Mon, May 13, 2019 at 01:45:29PM +, Andrey V. Elsukov wrote:
> > Author: ae
> > Date: Mon May 13 13:45:28 2019
> > New Revision: 347526
> > URL: https://svnweb.freebsd.org/changeset/base/347526
> >
> > Log:
> >   Rework locking in BPF code to remove rwlock from fast path.
> >
> >   On high packets rate the contention on rwlock in bpf_*tap*() functions
> >   can lead to packets dropping. To avoid this, migrate this code to use
> >   epoch(9) KPI and ConcurrencyKit's lists.
> >
> >   * all lists changed to use CK_LIST;
> >   * reference counting added to bpf_if and bpf_d;
> >   * now bpf_if references ifnet and releases this reference on destroy;
> >   * each bpf_d descriptor references bpf_if when it is attached;
> >   * new struct bpf_program_buffer introduced to keep BPF filter programs;
> >   * bpf_program_buffer, bpf_d and bpf_if structures are freed by
> > epoch_call();
> >   * bpf_freelist and ifnet_departure event are no longer needed, thus
> > both are removed;
> >
> >   Reviewed by:melifaro
> >   Sponsored by:   Yandex LLC
> >   Differential Revision:  https://reviews.freebsd.org/D20224
>
> This seems to introduce a possible recursion on the bpf cdev mutex.  Now
> bpfwrite() holds the mutex over the if_output call, which may enter
> bpf_mtap() via bridge_transmit(), and bpf_mtap() may attempt to
> reacquire the mutex.

It does, the sys.netinet.fibs_test.arpresolve_checks_interface_fib
case can trigger a panic:

root@:/usr/tests/sys/netinet # kyua test
fibs_test:arpresolve_checks_interface_fib
fibs_test:arpresolve_checks_interface_fib -> panic: _mtx_lock_sleep:
recursed on non-recursive mutex bpf @ /usr/src/sys/net/bpf.c:2325
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r347359 - head/contrib/libxo/tests/core/saved

[Li-Wen Hsu]

Author: lwhsu
Date: Wed May  8 18:46:12 2019
New Revision: 347359
URL: https://svnweb.freebsd.org/changeset/base/347359

Log:
  Fix expected output after r347207
  
  While phil is working on fixing in libxo general test parts, updating these
  files to stop the test failure warnings
  
  Approved by:  phil
  MFC with: r347207
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D20188

Modified:
  head/contrib/libxo/tests/core/saved/test_02.E.err
  head/contrib/libxo/tests/core/saved/test_02.H.err
  head/contrib/libxo/tests/core/saved/test_02.HIPx.err
  head/contrib/libxo/tests/core/saved/test_02.HP.err
  head/contrib/libxo/tests/core/saved/test_02.J.err
  head/contrib/libxo/tests/core/saved/test_02.JP.err
  head/contrib/libxo/tests/core/saved/test_02.T.err
  head/contrib/libxo/tests/core/saved/test_02.X.err
  head/contrib/libxo/tests/core/saved/test_02.XP.err

Modified: head/contrib/libxo/tests/core/saved/test_02.E.err
==
--- head/contrib/libxo/tests/core/saved/test_02.E.err   Wed May  8 18:12:38 
2019(r347358)
+++ head/contrib/libxo/tests/core/saved/test_02.E.err   Wed May  8 18:46:12 
2019(r347359)
@@ -1 +1 @@
-test_02.test: key field emitted after normal value field: 'name'
+test_02: key field emitted after normal value field: 'name'

Modified: head/contrib/libxo/tests/core/saved/test_02.H.err
==
--- head/contrib/libxo/tests/core/saved/test_02.H.err   Wed May  8 18:12:38 
2019(r347358)
+++ head/contrib/libxo/tests/core/saved/test_02.H.err   Wed May  8 18:46:12 
2019(r347359)
@@ -1 +1 @@
-test_02.test: key field emitted after normal value field: 'name'
+test_02: key field emitted after normal value field: 'name'

Modified: head/contrib/libxo/tests/core/saved/test_02.HIPx.err
==
--- head/contrib/libxo/tests/core/saved/test_02.HIPx.errWed May  8 
18:12:38 2019(r347358)
+++ head/contrib/libxo/tests/core/saved/test_02.HIPx.errWed May  8 
18:46:12 2019(r347359)
@@ -1 +1 @@
-test_02.test: key field emitted after normal value field: 'name'
+test_02: key field emitted after normal value field: 'name'

Modified: head/contrib/libxo/tests/core/saved/test_02.HP.err
==
--- head/contrib/libxo/tests/core/saved/test_02.HP.err  Wed May  8 18:12:38 
2019(r347358)
+++ head/contrib/libxo/tests/core/saved/test_02.HP.err  Wed May  8 18:46:12 
2019(r347359)
@@ -1 +1 @@
-test_02.test: key field emitted after normal value field: 'name'
+test_02: key field emitted after normal value field: 'name'

Modified: head/contrib/libxo/tests/core/saved/test_02.J.err
==
--- head/contrib/libxo/tests/core/saved/test_02.J.err   Wed May  8 18:12:38 
2019(r347358)
+++ head/contrib/libxo/tests/core/saved/test_02.J.err   Wed May  8 18:46:12 
2019(r347359)
@@ -1 +1 @@
-test_02.test: key field emitted after normal value field: 'name'
+test_02: key field emitted after normal value field: 'name'

Modified: head/contrib/libxo/tests/core/saved/test_02.JP.err
==
--- head/contrib/libxo/tests/core/saved/test_02.JP.err  Wed May  8 18:12:38 
2019(r347358)
+++ head/contrib/libxo/tests/core/saved/test_02.JP.err  Wed May  8 18:46:12 
2019(r347359)
@@ -1 +1 @@
-test_02.test: key field emitted after normal value field: 'name'
+test_02: key field emitted after normal value field: 'name'

Modified: head/contrib/libxo/tests/core/saved/test_02.T.err
==
--- head/contrib/libxo/tests/core/saved/test_02.T.err   Wed May  8 18:12:38 
2019(r347358)
+++ head/contrib/libxo/tests/core/saved/test_02.T.err   Wed May  8 18:46:12 
2019(r347359)
@@ -1,2 +1,2 @@
-test_02.test: key field emitted after normal value field: 'name'
+test_02: key field emitted after normal value field: 'name'
 Shut 'er down, Clancey!  She's a-pumpin' mud!  <>!,"!<>

Modified: head/contrib/libxo/tests/core/saved/test_02.X.err
==
--- head/contrib/libxo/tests/core/saved/test_02.X.err   Wed May  8 18:12:38 
2019(r347358)
+++ head/contrib/libxo/tests/core/saved/test_02.X.err   Wed May  8 18:46:12 
2019(r347359)
@@ -1 +1 @@
-test_02.test: key field emitted after normal value field: 'name'
+test_02: key field emitted after normal value field: 'name'

Modified: head/contrib/libxo/tests/core/saved/test_02.XP.err
==
--- 

svn commit: r346873 - head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip

[Li-Wen Hsu]

Author: lwhsu
Date: Mon Apr 29 03:50:21 2019
New Revision: 346873
URL: https://svnweb.freebsd.org/changeset/base/346873

Log:
  Add a trailing empty line to match the test code output
  
  This is added for letting these long failing test case pass, and for
  consistency.  The test code should be fixed later to not output this extra
  empty line.
  
  Sponsored by: The FreeBSD Foundation

Modified:
  
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.localsctpstate.ksh.out

Modified: 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.localsctpstate.ksh.out
==
--- 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.localsctpstate.ksh.out
  Mon Apr 29 03:31:20 2019(r346872)
+++ 
head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.localsctpstate.ksh.out
  Mon Apr 29 03:50:21 2019(r346873)
@@ -10,3 +10,4 @@ sctp:::state-change to established - yes
 sctp:::state-change to shutdown-sent - yes
 sctp:::state-change to shutdown-received - yes
 sctp:::state-change to shutdown-ack-sent - yes
+
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r346645 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src sys

[Li-Wen Hsu]

On Thu, Apr 25, 2019 at 5:31 AM Tycho Nightingale  wrote:
>
> Author: tychon
> Date: Wed Apr 24 20:30:45 2019
> New Revision: 346645
> URL: https://svnweb.freebsd.org/changeset/base/346645
...
> Modified: head/sys/compat/linuxkpi/common/src/linux_pci.c
> ==
> --- head/sys/compat/linuxkpi/common/src/linux_pci.c Wed Apr 24 19:56:02 
> 2019(r346644)
> +++ head/sys/compat/linuxkpi/common/src/linux_pci.c Wed Apr 24 20:30:45 
> 2019(r346645)
...
> +PCTRIE_DEFINE(LINUX_DMA, linux_dma_obj, dma_addr, linux_dma_trie_alloc,
> +linux_dma_trie_free);

Here we got errors in build on 32-bit platforms use gcc:

/usr/src/sys/compat/linuxkpi/common/src/linux_pci.c:456:1: error:
static_assert failed due to requirement 'sizeof (((struct
linux_dma_obj *)0)->dma_addr) == sizeof(unsigned long long)'
"compile-time assertion failed"
PCTRIE_DEFINE(LINUX_DMA, linux_dma_obj, dma_addr, linux_dma_trie_alloc,
^~~
/usr/src/sys/sys/pctrie.h:41:10: note: expanded from macro 'PCTRIE_DEFINE'
\
^
/usr/src/sys/sys/systm.h:120:21: note: expanded from macro '\
CTASSERT'
#define CTASSERT(x) _Static_assert(x, "compile-time assertion failed")
^  ~
/usr/src/sys/compat/linuxkpi/common/src/linux_pci.c:456:1: error:
incompatible pointer types returning 'dma_addr_t *' (aka 'unsigned int
*') from a function with result type 'uint64_t *' (aka 'unsigned long
long *') [-Werror,-Wincompatible-pointer-types]
PCTRIE_DEFINE(LINUX_DMA, linux_dma_obj, dma_addr, linux_dma_trie_alloc,
^~~
/usr/src/sys/sys/pctrie.h:63:9: note: expanded from macro 'PCTRIE_DEFINE'
return >field; \
   ^~~
2 errors generated.
*** [linux_pci.o] Error code 1

make[4]: stopped in /usr/src/sys/modules/linuxkpi

Can you check this?  Full build log is available at:
https://ci.freebsd.org/job/FreeBSD-head-armv7-build/4250/console

Thanks,
Li-Wen
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r346431 - head/tests/sys/opencrypto

[Li-Wen Hsu]

Author: lwhsu
Date: Sat Apr 20 07:32:29 2019
New Revision: 346431
URL: https://svnweb.freebsd.org/changeset/base/346431

Log:
  Specify using Python2, these .py files have not been converted to use Python3
  yet, but the default Python version in ports has been switched to 3.
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/opencrypto/Makefile
  head/tests/sys/opencrypto/cryptodev.py
  head/tests/sys/opencrypto/cryptotest.py
  head/tests/sys/opencrypto/runtests.sh

Modified: head/tests/sys/opencrypto/Makefile
==
--- head/tests/sys/opencrypto/Makefile  Sat Apr 20 05:31:56 2019
(r346430)
+++ head/tests/sys/opencrypto/Makefile  Sat Apr 20 07:32:29 2019
(r346431)
@@ -14,7 +14,7 @@ ATF_TESTS_C+= blake2_test poly1305_test
 
 PLAIN_TESTS_SH=runtests
 
-TEST_METADATA.runtests+= required_programs="python"
+TEST_METADATA.runtests+= required_programs="python2"
 TEST_METADATA.runtests+= required_user="root"
 
 PYMODULES= cryptodev.py cryptodevh.py cryptotest.py dpkt.py

Modified: head/tests/sys/opencrypto/cryptodev.py
==
--- head/tests/sys/opencrypto/cryptodev.py  Sat Apr 20 05:31:56 2019
(r346430)
+++ head/tests/sys/opencrypto/cryptodev.py  Sat Apr 20 07:32:29 2019
(r346431)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/local/bin/python2
 #
 # Copyright (c) 2014 The FreeBSD Foundation
 # Copyright 2014 John-Mark Gurney

Modified: head/tests/sys/opencrypto/cryptotest.py
==
--- head/tests/sys/opencrypto/cryptotest.py Sat Apr 20 05:31:56 2019
(r346430)
+++ head/tests/sys/opencrypto/cryptotest.py Sat Apr 20 07:32:29 2019
(r346431)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/local/bin/python2
 #
 # Copyright (c) 2014 The FreeBSD Foundation
 # All rights reserved.

Modified: head/tests/sys/opencrypto/runtests.sh
==
--- head/tests/sys/opencrypto/runtests.sh   Sat Apr 20 05:31:56 2019
(r346430)
+++ head/tests/sys/opencrypto/runtests.sh   Sat Apr 20 07:32:29 2019
(r346431)
@@ -61,6 +61,6 @@ done
 oldcdas=$(sysctl -e kern.cryptodevallowsoft)
 sysctl kern.cryptodevallowsoft=1
 
-python $(dirname $0)/cryptotest.py
+python2 $(dirname $0)/cryptotest.py
 
 sysctl "$oldcdas"
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r346160 - head/usr.bin/mandoc

[Li-Wen Hsu]

On Sat, Apr 13, 2019 at 3:53 AM Enji Cooper  wrote:
>
>
> > On Apr 12, 2019, at 11:35 AM, Li-Wen Hsu  wrote:
> >
> > Author: lwhsu
> > Date: Fri Apr 12 18:35:14 2019
> > New Revision: 346160
> > URL: https://svnweb.freebsd.org/changeset/base/346160
> >
> > Log:
> >  Suppress old gcc warning about null format string
> >
> >  This is workaround to make head build on gcc using architectures
> >
> >  Sponsored by:The FreeBSD Foundation
> >  MFC-with:r346149
> >
> > Modified:
> >  head/usr.bin/mandoc/Makefile
> >
> > Modified: head/usr.bin/mandoc/Makefile
> > ==
> > --- head/usr.bin/mandoc/Makefile  Fri Apr 12 18:13:57 2019
> > (r346159)
> > +++ head/usr.bin/mandoc/Makefile  Fri Apr 12 18:35:14 2019
> > (r346160)
> > @@ -97,6 +97,8 @@ SRCS=   ${LIB_SRCS} \
> > WARNS?=   3
> > CFLAGS+= -DHAVE_CONFIG_H \
> >-I${SRCTOP}/lib/libopenbsd/
> > +# This can be removed after swtiching to newer gcc
> > +CFLAGS.gcc+= -Wno-format
> > LIBADD=   openbsd z
> >
> > .include 
>
> Couldn’t this be fixed upstream and pulled back in, instead of 
> ignoring the warning?

That's possible, but I don't know how much of the possibility that
upstream is willing to fix a warning that only occurs in old versions
of gcc, and it looks a false positive to me.  I am here to put a
band-aid first.

Best,
Li-Wen
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r346160 - head/usr.bin/mandoc

[Li-Wen Hsu]

Author: lwhsu
Date: Fri Apr 12 18:35:14 2019
New Revision: 346160
URL: https://svnweb.freebsd.org/changeset/base/346160

Log:
  Suppress old gcc warning about null format string
  
  This is workaround to make head build on gcc using architectures
  
  Sponsored by: The FreeBSD Foundation
  MFC-with: r346149

Modified:
  head/usr.bin/mandoc/Makefile

Modified: head/usr.bin/mandoc/Makefile
==
--- head/usr.bin/mandoc/MakefileFri Apr 12 18:13:57 2019
(r346159)
+++ head/usr.bin/mandoc/MakefileFri Apr 12 18:35:14 2019
(r346160)
@@ -97,6 +97,8 @@ SRCS= ${LIB_SRCS} \
 WARNS?=3
 CFLAGS+= -DHAVE_CONFIG_H \
 -I${SRCTOP}/lib/libopenbsd/
+# This can be removed after swtiching to newer gcc
+CFLAGS.gcc+=   -Wno-format
 LIBADD=openbsd z
 
 .include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r346087 - head/sys/modules/nfscommon

[Li-Wen Hsu]

Author: lwhsu
Date: Wed Apr 10 16:48:45 2019
New Revision: 346087
URL: https://svnweb.freebsd.org/changeset/base/346087

Log:
  Fix build in sys/modules/nfscommon
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/modules/nfscommon/Makefile

Modified: head/sys/modules/nfscommon/Makefile
==
--- head/sys/modules/nfscommon/Makefile Wed Apr 10 16:09:06 2019
(r346086)
+++ head/sys/modules/nfscommon/Makefile Wed Apr 10 16:48:45 2019
(r346087)
@@ -7,6 +7,7 @@ SRCS=   vnode_if.h \
nfs_commonkrpc.c \
nfs_commonport.c \
nfs_commonsubs.c \
+   opt_inet.h \
opt_inet6.h \
opt_kgssapi.h \
opt_nfs.h \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r345632 - in head/sys/modules: efirt iflib nvdimm tpm

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Mar 28 08:59:11 2019
New Revision: 345632
URL: https://svnweb.freebsd.org/changeset/base/345632

Log:
  Fix `make` in sys/modules
  
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/modules/efirt/Makefile
  head/sys/modules/iflib/Makefile
  head/sys/modules/nvdimm/Makefile
  head/sys/modules/tpm/Makefile

Modified: head/sys/modules/efirt/Makefile
==
--- head/sys/modules/efirt/Makefile Thu Mar 28 08:38:31 2019
(r345631)
+++ head/sys/modules/efirt/Makefile Thu Mar 28 08:59:11 2019
(r345632)
@@ -9,6 +9,7 @@ SRCS+=  efirtc.c
 SRCS+=  device_if.h bus_if.h clock_if.h
 
 .if ${MACHINE_CPUARCH} == "amd64"
+SRCS+= opt_hwpmc_hooks.h opt_kstack_pages.h
 SRCS+= efirt_support.S
 efirt_support.o:   efirt_support.S assym.inc
${CC} -c -x assembler-with-cpp -DLOCORE ${CFLAGS} \

Modified: head/sys/modules/iflib/Makefile
==
--- head/sys/modules/iflib/Makefile Thu Mar 28 08:38:31 2019
(r345631)
+++ head/sys/modules/iflib/Makefile Thu Mar 28 08:59:11 2019
(r345632)
@@ -9,5 +9,6 @@ SRCS= \
mp_ring.c
 SRCS+= ifdi_if.c
 SRCS+= device_if.h bus_if.h pci_if.h pci_iov_if.h ifdi_if.h
+SRCS+= opt_acpi.h opt_inet.h opt_inet6.h opt_sched.h
 
 .include 

Modified: head/sys/modules/nvdimm/Makefile
==
--- head/sys/modules/nvdimm/MakefileThu Mar 28 08:38:31 2019
(r345631)
+++ head/sys/modules/nvdimm/MakefileThu Mar 28 08:59:11 2019
(r345632)
@@ -9,5 +9,6 @@ SRCS=   nvdimm.c \
nvdimm_spa.c
 
 SRCS+= acpi_if.h bus_if.h device_if.h
+SRCS+= opt_acpi.h opt_ddb.h
 
 .include 

Modified: head/sys/modules/tpm/Makefile
==
--- head/sys/modules/tpm/Makefile   Thu Mar 28 08:38:31 2019
(r345631)
+++ head/sys/modules/tpm/Makefile   Thu Mar 28 08:59:11 2019
(r345632)
@@ -8,6 +8,6 @@ SRCS=   tpm.c bus_if.h device_if.h
 #Bus specific stuff.
 SRCS+= tpm_isa.c tpm_acpi.c isa_if.h opt_acpi.h acpi_if.h
 #TPM 2.0
-SRCS+= tpm20.c tpm_crb.c tpm_tis.c
+SRCS+= tpm20.c tpm_crb.c tpm_tis.c opt_tpm.h
 
 .include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r345630 - in head/sys/modules: hwpmc_mips24k hwpmc_mips74k

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Mar 28 08:30:45 2019
New Revision: 345630
URL: https://svnweb.freebsd.org/changeset/base/345630

Log:
  Add dependent header files
  
  Reported by:  https://ci.freebsd.org/job/FreeBSD-head-mips-build/6702/console

Modified:
  head/sys/modules/hwpmc_mips24k/Makefile
  head/sys/modules/hwpmc_mips74k/Makefile

Modified: head/sys/modules/hwpmc_mips24k/Makefile
==
--- head/sys/modules/hwpmc_mips24k/Makefile Thu Mar 28 06:10:41 2019
(r345629)
+++ head/sys/modules/hwpmc_mips24k/Makefile Thu Mar 28 08:30:45 2019
(r345630)
@@ -6,9 +6,12 @@
 
 KMOD=  hwpmc_mips24k
 
-SRCS=  hwpmc_mod.c hwpmc_logging.c hwpmc_soft.c vnode_if.h
+SRCS=  bus_if.h device_if.h vnode_if.h
+SRCS+= hwpmc_mod.c hwpmc_logging.c hwpmc_soft.c
 SRCS+= hwpmc_mips.c
 
 SRCS+= hwpmc_mips24k.c
+
+SRCS+= opt_hwpmc_hooks.h
 
 .include 

Modified: head/sys/modules/hwpmc_mips74k/Makefile
==
--- head/sys/modules/hwpmc_mips74k/Makefile Thu Mar 28 06:10:41 2019
(r345629)
+++ head/sys/modules/hwpmc_mips74k/Makefile Thu Mar 28 08:30:45 2019
(r345630)
@@ -6,9 +6,12 @@
 
 KMOD=  hwpmc_mips74k
 
-SRCS=  hwpmc_mod.c hwpmc_logging.c hwpmc_soft.c vnode_if.h
+SRCS=  bus_if.h device_if.h vnode_if.h
+SRCS+= hwpmc_mod.c hwpmc_logging.c hwpmc_soft.c
 SRCS+= hwpmc_mips.c
 
 SRCS+= hwpmc_mips74k.c
+
+SRCS+= opt_hwpmc_hooks.h
 
 .include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r344045 - head/sys/contrib/dev/iwm

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Feb 12 08:16:05 2019
New Revision: 344045
URL: https://svnweb.freebsd.org/changeset/base/344045

Log:
  Remove empty files
  
  Approved by:  markj (mentor)
  Sponsored by: The FreeBSD Foundation

Deleted:
  head/sys/contrib/dev/iwm/iwm-3160-9.fw.uu
  head/sys/contrib/dev/iwm/iwm-7260-9.fw.uu
  head/sys/contrib/dev/iwm/iwm-7265-9.fw.uu
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r343713 - in head/sys: amd64/conf arm64/conf

[Li-Wen Hsu]

On Sun, Feb 3, 2019 at 8:46 PM Andrew Turner  wrote:
>
> Author: andrew
> Date: Sun Feb  3 12:46:27 2019
> New Revision: 343713
> URL: https://svnweb.freebsd.org/changeset/base/343713
>
> Log:
>   Enable COVERAGE and KCOV by default on arm64 and amd64.
>
>   This allows userspace to trace the kernel using the coverage sanitizer
>   found in clang. It will also allow other coverage tools to be built as
>   modules and attach into the same framework.
>
>   Sponsored by: DARPA, AFRL
>
> Modified:
>   head/sys/amd64/conf/GENERIC
>   head/sys/arm64/conf/GENERIC
>
> Modified: head/sys/amd64/conf/GENERIC
> ==
> --- head/sys/amd64/conf/GENERIC Sun Feb  3 11:41:43 2019(r343712)
> +++ head/sys/amd64/conf/GENERIC Sun Feb  3 12:46:27 2019(r343713)
> @@ -102,8 +102,8 @@ options MALLOC_DEBUG_MAXZONES=8 # Separate malloc(9)
>  optionsVERBOSE_SYSINIT=0   # Support debug.verbose_sysinit, off 
> by default
>
>  # Kernel Sanitizers
> -#options   COVERAGE# Generic kernel coverage. Used by 
> KCOV
> -#options   KCOV# Kernel Coverage Sanitizer
> +optionsCOVERAGE# Generic kernel coverage. Used by 
> KCOV
> +optionsKCOV# Kernel Coverage Sanitizer
>  # Warning: KUBSAN can result in a kernel too large for loader to load
>  #options   KUBSAN  # Kernel Undefined Behavior Sanitizer
>
>
> Modified: head/sys/arm64/conf/GENERIC
> ==
> --- head/sys/arm64/conf/GENERIC Sun Feb  3 11:41:43 2019(r343712)
> +++ head/sys/arm64/conf/GENERIC Sun Feb  3 12:46:27 2019(r343713)
> @@ -94,8 +94,8 @@ options   USB_DEBUG   # enable debug msgs
>  optionsVERBOSE_SYSINIT=0   # Support debug.verbose_sysinit, off 
> by default
>
>  # Kernel Sanitizers
> -#options   COVERAGE# Generic kernel coverage. Used by 
> KCOV
> -#options   KCOV# Kernel Coverage Sanitizer
> +optionsCOVERAGE# Generic kernel coverage. Used by 
> KCOV
> +optionsKCOV# Kernel Coverage Sanitizer
>  # Warning: KUBSAN can result in a kernel too large for loader to load
>  #options   KUBSAN  # Kernel Undefined Behavior Sanitizer

This breaks gcc build:
https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/8781/console :

x86_64-unknown-freebsd12.0-gcc: error: unrecognized command line
option '-fsanitize-coverage=trace-pc,trace-cmp'; did you mean
'-fsanitize-coverage=trace-pc'?

We probably need to adjust arguments passed to gcc.

Li-Wen
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r343442 - in head: contrib/netbsd-tests/lib/libm lib/msun/tests

[Li-Wen Hsu]

Author: lwhsu
Date: Fri Jan 25 18:48:20 2019
New Revision: 343442
URL: https://svnweb.freebsd.org/changeset/base/343442

Log:
  Temporarily mark lib.msun.{cbrt_test.cbrtl_powl,trig_test.reduction}
  expected failure after clang700-import merge
  
  PR:   234040
  Reviewed by:  ngie, markj
  Approved by:  markj (mentor)
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D18938

Modified:
  head/contrib/netbsd-tests/lib/libm/t_cbrt.c
  head/lib/msun/tests/trig_test.c

Modified: head/contrib/netbsd-tests/lib/libm/t_cbrt.c
==
--- head/contrib/netbsd-tests/lib/libm/t_cbrt.c Fri Jan 25 18:30:12 2019
(r343441)
+++ head/contrib/netbsd-tests/lib/libm/t_cbrt.c Fri Jan 25 18:48:20 2019
(r343442)
@@ -268,6 +268,10 @@ ATF_TC_BODY(cbrtl_powl, tc)
long double y, z;
size_t i;
 
+#if defined(__amd64__) && defined(__clang__) && __clang_major__ >= 7
+   atf_tc_expect_fail("test fails with clang 7+ - bug 234040");
+#endif
+
for (i = 0; i < __arraycount(x); i++) {
 
y = cbrtl(x[i]);

Modified: head/lib/msun/tests/trig_test.c
==
--- head/lib/msun/tests/trig_test.c Fri Jan 25 18:30:12 2019
(r343441)
+++ head/lib/msun/tests/trig_test.c Fri Jan 25 18:48:20 2019
(r343442)
@@ -160,6 +160,10 @@ ATF_TC_BODY(reduction, tc)
 
unsigned i;
 
+#if defined(__amd64__) && defined(__clang__) && __clang_major__ >= 7
+   atf_tc_expect_fail("test fails with clang 7+ - bug 234040");
+#endif
+
for (i = 0; i < nitems(f_pi_odd); i++) {
ATF_CHECK(fabs(sinf(f_pi_odd[i])) < FLT_EPSILON);
ATF_CHECK(cosf(f_pi_odd[i]) == -1.0);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r341623 - in head: tests/sys/kqueue/libkqueue usr.bin/procstat/tests

[Li-Wen Hsu]

Author: lwhsu
Date: Thu Dec  6 09:22:35 2018
New Revision: 341623
URL: https://svnweb.freebsd.org/changeset/base/341623

Log:
  Temporarily skip flakey test cases
  
  PR:   233586, 233587, 233588
  Approved by:  markj (mentor)
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D18362

Modified:
  head/tests/sys/kqueue/libkqueue/kqueue_test.sh
  head/usr.bin/procstat/tests/procstat_test.sh

Modified: head/tests/sys/kqueue/libkqueue/kqueue_test.sh
==
--- head/tests/sys/kqueue/libkqueue/kqueue_test.sh  Thu Dec  6 08:27:56 
2018(r341622)
+++ head/tests/sys/kqueue/libkqueue/kqueue_test.sh  Thu Dec  6 09:22:35 
2018(r341623)
@@ -2,7 +2,8 @@
 # $FreeBSD$
 
 i=1
-"$(dirname $0)/kqtest" | while read line; do
+# Temporarily disable evfilt_proc tests: https://bugs.freebsd.org/233586
+"$(dirname $0)/kqtest" --no-proc | while read line; do
echo $line | grep -q passed
if [ $? -eq 0 ]; then
echo "ok - $i $line"

Modified: head/usr.bin/procstat/tests/procstat_test.sh
==
--- head/usr.bin/procstat/tests/procstat_test.shThu Dec  6 08:27:56 
2018(r341622)
+++ head/usr.bin/procstat/tests/procstat_test.shThu Dec  6 09:22:35 
2018(r341623)
@@ -79,6 +79,8 @@ command_line_arguments_head()
 }
 command_line_arguments_body()
 {
+   atf_skip "https://bugs.freebsd.org/233587;
+
arguments="my arguments"
 
start_program $arguments
@@ -103,6 +105,8 @@ environment_head()
 }
 environment_body()
 {
+   atf_skip "https://bugs.freebsd.org/233588;
+
var="MY_VARIABLE=foo"
eval "export $var"
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r340286 - head/tests/sys/netpfil/pf

[Li-Wen Hsu]

Author: lwhsu
Date: Fri Nov  9 15:24:24 2018
New Revision: 340286
URL: https://svnweb.freebsd.org/changeset/base/340286

Log:
  Fix test: sys.netpfil.pf.pass_block.noalias
  
  Replace hard-coded epair0b with the variable holds the real epair interface
  used for testing.
  
  Reviewed by:  kp
  Approved by:  emaste, markj (mentors)
  MFC with: r339836
  Sponsored by: The FreeBSD Foundation

Modified:
  head/tests/sys/netpfil/pf/pass_block.sh

Modified: head/tests/sys/netpfil/pf/pass_block.sh
==
--- head/tests/sys/netpfil/pf/pass_block.sh Fri Nov  9 15:02:53 2018
(r340285)
+++ head/tests/sys/netpfil/pf/pass_block.sh Fri Nov  9 15:24:24 2018
(r340286)
@@ -111,14 +111,14 @@ noalias_body()
atf_check -s exit:0 -o ignore ping6 -c 1 -x 1 ${linklocaladdr}%${epair}a
 
jexec alcatraz pfctl -e
-   pft_set_rules alcatraz "block out inet6 from (epair0b:0) to any"
+   pft_set_rules alcatraz "block out inet6 from (${epair}b:0) to any"
 
atf_check -s exit:2 -o ignore ping6 -c 1 -x 1 2001:db8:42::2
 
# We should still be able to ping the link-local address
atf_check -s exit:0 -o ignore ping6 -c 1 -x 1 ${linklocaladdr}%${epair}a
 
-   pft_set_rules alcatraz "block out inet6 from (epair0b) to any"
+   pft_set_rules alcatraz "block out inet6 from (${epair}b) to any"
 
# We cannot ping to the link-local address
atf_check -s exit:2 -o ignore ping6 -c 1 -x 1 ${linklocaladdr}%${epair}a
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r340187 - head/sys/geom

[Li-Wen Hsu]

Hi Maxim,

There are 5 regression tests failing since this change:

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/9184/testReport/

sys.geom.class.*

Can you help check them?

Best,
Li-Wen
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r338851 - head/share/man/man4

[Li-Wen Hsu]

Author: lwhsu
Date: Fri Sep 21 07:36:02 2018
New Revision: 338851
URL: https://svnweb.freebsd.org/changeset/base/338851

Log:
  Mention setting $lines to 0 in ddb can disable paging
  
  Reviewed by:  bcr (earlier version), markj
  Approved by:  re (kib), markj (mentor)
  MFC after:3 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D17068

Modified:
  head/share/man/man4/ddb.4

Modified: head/share/man/man4/ddb.4
==
--- head/share/man/man4/ddb.4   Fri Sep 21 01:37:08 2018(r338850)
+++ head/share/man/man4/ddb.4   Fri Sep 21 07:36:02 2018(r338851)
@@ -60,7 +60,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd June 20, 2018
+.Dd September 7, 2018
 .Dt DDB 4
 .Os
 .Sh NAME
@@ -1280,6 +1280,7 @@ The width of the displayed line.
 .It Va lines
 The number of lines.
 It is used by the built-in pager.
+Setting it to 0 disables paging.
 .It Va tabstops
 Tab stop width.
 .It Va work Ns Ar xx
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r336299 - in head: include lib/msun lib/msun/ld128 lib/msun/ld80 lib/msun/man lib/msun/src

[Li-Wen Hsu]

On Thu, Sep 20, 2018 at 10:06 PM Mark Johnston  wrote:
>
> On Thu, Sep 20, 2018 at 09:39:24AM -0700, John Baldwin wrote:
> > On 9/20/18 8:54 AM, Mark Johnston wrote:
> > > On Sun, Jul 15, 2018 at 12:23:11AM +, Matt Macy wrote:
> > >> Author: mmacy
> > >> Date: Sun Jul 15 00:23:10 2018
> > >> New Revision: 336299
> > >> URL: https://svnweb.freebsd.org/changeset/base/336299
> > >>
> > >> Log:
> > >>   msun: add ld80/ld128 powl, cpow, cpowf, cpowl from openbsd
> > >>
> > >>   This corresponds to the latest status (hasn't changed in 9+
> > >>   years) from openbsd of ld80/ld128 powl, and source cpowf, cpow,
> > >>   cpowl (the complex power functions for float complex, double
> > >>   complex, and long double complex) which are required for C99
> > >>   compliance and were missing from FreeBSD. Also required for
> > >>   some numerical codes using complex numbered Hamiltonians.
> > >>
> > >>   Thanks to jhb for tracking down the issue with making
> > >>   weak_reference compile on powerpc.
> > >>
> > >>   When asked to review, bde said "I don't like it" - but
> > >>   provided no actionable feedback or superior implementations.
> > >>
> > >>   Discussed with: jhb
> > >>   Submitted by: jmd
> > >>   Differential Revision: https://reviews.freebsd.org/D15919
> > >
> > > This seems to have broken the gcc build:
> > > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/
> > >
> > > /workspace/src/lib/msun/ld80/e_powl.c:275:1: error: floating constant 
> > > exceeds range of 'long double' [-Werror=overflow]
> > >   if( y >= LDBL_MAX )
> > >   ^~
> >
> > Which architecture?  i386 doesn't get build with i386-xtoolchain-gcc pending
> > some patches I haven't yet posted for review related to the weirdness we do
> > with floating point on i386.
>
> This is the -m32 build on amd64.  I haven't tested it myself, but Mark
> Millard noted that the issue might be fixed by a gcc update.
>

I suspect this.  Each build is in a fresh created jail with the latest
branch of packages from pkg.freebsd.org.

At the beginning of (warning: 56MB file)
https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/7262/consoleText

There is:

New packages to be INSTALLED:
amd64-xtoolchain-gcc: 0.4_1
amd64-gcc: 6.4.0_2
mpfr: 4.0.1
gmp: 6.1.2
mpc: 1.1.0_1
amd64-binutils: 2.30_5,1

Number of packages to be installed: 6

Or is there a newer version of devel/amd64-gcc I am not aware?

-- 
Li-Wen Hsu 
https://lwhsu.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r338404 - head/sys/conf

[Li-Wen Hsu]

On Fri, Aug 31, 2018 at 3:20 PM Glen Barber  wrote:
>
> On Fri, Aug 31, 2018 at 08:51:29AM -0400, Ed Maste wrote:
> > On 30 August 2018 at 22:46, Glen Barber  wrote:
> > >
> > > As I look closer at the log, I have a sneaking suspicion this may have
> > > been a transient.  I'm redoing the i386 build against the original
> > > r338401 for i386 alone as a test, if nothing else, to see if it fails in
> > > the same place.
> >
> > What's the failure?
>
>  >>> stage 3.1: building everything
>  --
>  In file included from /usr/src/sys/kern/genoffset.c:35:
>  In file included from /usr/src/sys/sys/param.h:96:
>  /usr/src/sys/sys/types.h:46:10: fatal error: 'machine/endian.h' file not 
> found
>  #include 
>   ^~
>  1 error generated.
>  --- genoffset.o ---
>  *** [genoffset.o] Error code 1
>
> So far, 100% reproducible with an empty /usr/obj/.
>
> > I see head/i386 is green in CI.
> >
>
> Does CI prune .OBJDIR for each build?

Yes, each build is a clean build for now.  More precisely, each build
happens in a fresh jail and will be thrown away after the build.

Many people ask for incremental build to speed up but that takes some
further work.  The current plan is still to have clean build but run
less frequently after having incremental build for catching dependence
or race problems.

Best,
Li-Wen

-- 
Li-Wen Hsu 
https://lwhsu.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r338363 - head

[Li-Wen Hsu]

Author: lwhsu
Date: Tue Aug 28 23:56:52 2018
New Revision: 338363
URL: https://svnweb.freebsd.org/changeset/base/338363

Log:
  Fix 'install: symlink usr/src/sys -> /sys: File exists' in distributeworld
  
  Follow r334617, specify ${DISTDIR} (by ${INSTALL_DDIR}), '/base' and add
  ${INSTALLFLAGS} while installing the '/sys' symbolic link.
  
  Reviewed by:  bapt (earlier version), markj
  Approved by:  re (gjb), markj (mentor)
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D16877

Modified:
  head/Makefile.inc1

Modified: head/Makefile.inc1
==
--- head/Makefile.inc1  Tue Aug 28 22:51:45 2018(r338362)
+++ head/Makefile.inc1  Tue Aug 28 23:56:52 2018(r338363)
@@ -1334,7 +1334,7 @@ distributeworld installworld stageworld: _installcheck
METALOG=${METALOG} ${IMAKE_INSTALL} ${IMAKE_MTREE} \
DISTBASE=/base DESTDIR=${DESTDIR}/${DISTDIR}/base \
LOCAL_MTREE=${LOCAL_MTREE:Q} distrib-dirs
-   ${INSTALL_SYMLINK} usr/src/sys ${DESTDIR}/sys
+   ${INSTALL_SYMLINK} ${INSTALLFLAGS} usr/src/sys ${INSTALL_DDIR}/base/sys
 .endif
${_+_}cd ${.CURDIR}; ${IMAKE} re${.TARGET:S/world$//}; \
${IMAKEENV} rm -rf ${INSTALLTMP}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs

[Li-Wen Hsu]

On Fri, Aug 17, 2018 at 7:26 AM John Baldwin  wrote:
>
> On 8/17/18 1:23 AM, Conrad Meyer wrote:
> > Author: cem
> > Date: Fri Aug 17 00:23:50 2018
> > New Revision: 337936
> > URL: https://svnweb.freebsd.org/changeset/base/337936
> >
> > Log:
> >   Bring in libsodium to sys/contrib
> >
> >   Bring in https://github.com/jedisct1/libsodium at
> >   461ac93b260b91db8ad957f5a576860e3e9c88a1 (August 7, 2018), unmodified.
> >
> >   libsodium is derived from Daniel J. Bernstein et al.'s 2011 NaCl
> >   ("Networking and Cryptography Library," pronounced "salt") software 
> > library.
> >   At the risk of oversimplifying, libsodium primarily exists to make it 
> > easier
> >   to use NaCl.  NaCl and libsodium provide high quality implementations of a
> >   number of useful cryptographic concepts (as well as the underlying
> >   primitics) seeing some adoption in newer network protocols.
> >
> >   I considered but dismissed cleaning up the directory hierarchy and
> >   discarding artifacts of other build systems in favor of remaining close to
> >   upstream (and easing future updates).
> >
> >   Nothing is integrated into the build system yet, so in that sense, no
> >   functional change.
>
> Can you import this into the vendor area and then do a bootstrap of
> mergeinfo to sys/contrib?  This permits future updates to use svn to
> merge instead of doing it by hand.  It also permits future imports to
> be done by other developers following our standard, documented process
> for working with third-party code.

There are some files like `builds/msvc/*` probably not very useful for
FreeBSD.  I might be good to have these files listed in FREEBSD-Xlist
and excluded from importing.

Best,
Li-Wen

-- 
Li-Wen Hsu 
https://lwhsu.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r337685 - head/share/misc

[Li-Wen Hsu]

Author: lwhsu
Date: Sun Aug 12 12:58:05 2018
New Revision: 337685
URL: https://svnweb.freebsd.org/changeset/base/337685

Log:
  Adding myself to committers-src.dot
  
  Approved by:  markj (mentor)

Modified:
  head/share/misc/committers-src.dot

Modified: head/share/misc/committers-src.dot
==
--- head/share/misc/committers-src.dot  Sun Aug 12 12:11:29 2018
(r337684)
+++ head/share/misc/committers-src.dot  Sun Aug 12 12:58:05 2018
(r337685)
@@ -240,6 +240,7 @@ lidl [label="Kurt Lidl\nl...@freebsd.org\n2015/10/21"]
 loos [label="Luiz Otavio O Souza\nl...@freebsd.org\n2013/07/03"]
 lstewart [label="Lawrence Stewart\nlstew...@freebsd.org\n2008/10/06"]
 luporl [label="Leandro Lupori\nlup...@freebsd.org\n2018/05/21"]
+lwhsu [label="Li-Wen Hsu\nlw...@freebsd.org\n2018/08/09"]
 manu [label="Emmanuel Vadot\nm...@freebsd.org\n2016/04/24"]
 marcel [label="Marcel Moolenaar\nmar...@freebsd.org\n1999/07/03"]
 marius [label="Marius Strobl\nmar...@freebsd.org\n2004/04/17"]
@@ -499,6 +500,7 @@ emaste -> achim
 emaste -> bwidawsk
 emaste -> dteske
 emaste -> kevans
+emaste -> lwhsu
 emaste -> markj
 emaste -> rstone
 
@@ -684,6 +686,7 @@ marcel -> nwhitehorn
 marcel -> sjg
 
 markj -> cem
+markj -> lwhsu
 markj -> rlibby
 
 markm -> jasone
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r336650 - head/sys/vm

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Mon Jul 23 19:49:54 2018
New Revision: 336650
URL: https://svnweb.freebsd.org/changeset/base/336650

Log:
  Use __riscv to determine building for RISC-V
  
  Reviewed by:  br
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D16398

Modified:
  head/sys/vm/vm_unix.c

Modified: head/sys/vm/vm_unix.c
==
--- head/sys/vm/vm_unix.c   Mon Jul 23 19:39:20 2018(r336649)
+++ head/sys/vm/vm_unix.c   Mon Jul 23 19:49:54 2018(r336650)
@@ -69,7 +69,7 @@ struct break_args {
 int
 sys_break(struct thread *td, struct break_args *uap)
 {
-#if !defined(__aarch64__) && !defined(__riscv__)
+#if !defined(__aarch64__) && !defined(__riscv)
uintptr_t addr;
int error;
 
@@ -78,9 +78,9 @@ sys_break(struct thread *td, struct break_args *uap)
if (error == 0)
td->td_retval[0] = addr;
return (error);
-#else /* defined(__aarch64__) || defined(__riscv__) */
+#else /* defined(__aarch64__) || defined(__riscv) */
return (ENOSYS);
-#endif /* defined(__aarch64__) || defined(__riscv__) */
+#endif /* defined(__aarch64__) || defined(__riscv) */
 }
 
 int
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r336620 - head/contrib/ofed/include

[Li-Wen Hsu]

On Mon, Jul 23, 2018 at 10:38 AM Hans Petter Selasky  wrote:
>
> On 07/23/18 00:35, Li-Wen Hsu wrote:
> > Author: lwhsu (ports committer)
> > Date: Sun Jul 22 22:35:17 2018
> > New Revision: 336620
> > URL: https://svnweb.freebsd.org/changeset/base/336620
> >
> > Log:
> >Add udma_barrier definitions for RISC-V
> >
> >Reviewed by:   kib
> >Sponsored by:  The FreeBSD Foundation
> >
> > Modified:
> >head/contrib/ofed/include/udma_barrier.h
> >
>
> Was this change build tested?

Yes, although it is still not enough for fixing RISC-V build, please
see this one:

https://lists.freebsd.org/pipermail/freebsd-current/2018-July/070279.html

Best,
Li-Wen


-- 
Li-Wen Hsu 
https://lwhsu.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r336620 - head/contrib/ofed/include

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Sun Jul 22 22:35:17 2018
New Revision: 336620
URL: https://svnweb.freebsd.org/changeset/base/336620

Log:
  Add udma_barrier definitions for RISC-V
  
  Reviewed by:  kib
  Sponsored by: The FreeBSD Foundation

Modified:
  head/contrib/ofed/include/udma_barrier.h

Modified: head/contrib/ofed/include/udma_barrier.h
==
--- head/contrib/ofed/include/udma_barrier.hSun Jul 22 22:34:20 2018
(r336619)
+++ head/contrib/ofed/include/udma_barrier.hSun Jul 22 22:35:17 2018
(r336620)
@@ -104,6 +104,10 @@
 #include 
 #include 
 #define udma_to_device_barrier() dmb()
+#elif defined(__riscv)
+#include 
+#include 
+#define udma_to_device_barrier() fence()
 #else
 #error No architecture specific memory barrier defines found!
 #endif
@@ -140,6 +144,8 @@
 #define udma_from_device_barrier() mips_sync()
 #elif defined(__arm__)
 #define udma_from_device_barrier() dmb()
+#elif defined(__riscv)
+#define udma_from_device_barrier() fence()
 #else
 #error No architecture specific memory barrier defines found!
 #endif
@@ -208,6 +214,8 @@
 #define mmio_flush_writes() mips_sync()
 #elif defined(__arm__)
 #define mmio_flush_writes() dmb()
+#elif defined(__riscv)
+#define mmio_flush_writes() fence()
 #else
 #error No architecture specific memory barrier defines found!
 #endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r336526 - head

[Li-Wen Hsu]

On Fri, Jul 20, 2018 at 14:40:56 -0400, Mark Johnston wrote:
> On Fri, Jul 20, 2018 at 11:38:23AM -0600, Ian Lepore wrote:
> > On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> > > Hi Ian,
> > > 
> > > -Original Message-
> > > From:  on behalf of Ian Lepore 
> > > Date: 2018-07-19, Thursday at 17:44
> > > To: , , 
> > > Subject: svn commit: r336526 - head
> > > 
> > > > 
> > > > Author: ian
> > > > Date: Fri Jul 20 00:44:04 2018
> > > > New Revision: 336526
> > > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > > 
> > > > Log:
> > > >   Add ntpd to the list of users/groups to check before installing.
> > > > 
> > > > Modified:
> > > >   head/Makefile.inc1
> > > When trying to installworld:
> > > 
> > > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > > 
> > > But there is no UPDATING entry about this. (Also, shouldn't it be 
> > > ${SRCTOP}/UPDATING?)
> > > 
> > > Thanks,
> > > 
> > > Ravi (rpokala@)
> > 
> > I wondered about that too, when I accidentally stumbled across the
> > CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> > UPDATING for some of the other things in the CHECK_UIDS list to see
> > what had been said about such changes in the past, even searching
> > through old-old svn history, and found nothing.
> > 
> > I finally settled on the thought that the reference to UPDATING was to
> > the stuff at the bottom that never changes. In particular to the
> > section around line 1595 that documents the instalkernel, reboot,
> > mergemaster, installworld sequence. The mergemaster part should take
> > care of the new userid, I guess.
> 
> I thought it would too, but it's bombing out for me:
> 
>   *** Creating the temporary root environment in /var/tmp/temproot
>*** /var/tmp/temproot ready for use
>*** Creating and populating directory structure in /var/tmp/temproot
> 
>   mtree: unknown user `ntpd'
>       mtree: failed at line 49 of the specification
> 
> *** FATAL ERROR: Cannot 'cd' to /home/mark/src/freebsd-dev and 
> install files to
> the temproot environment
> 
> I see that line 49 of BSD.var.dist references the new uids, so I guess
> there's a chicken and egg problem here?

I thought we should use mergemaster or etcupdate with -p for "pre-world"
mode.

Li-Wen

-- 
Li-Wen Hsu 
https://lwhsu.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r336561 - head/sys/modules/spigen

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Fri Jul 20 17:46:55 2018
New Revision: 336561
URL: https://svnweb.freebsd.org/changeset/base/336561

Log:
  Fix `make` in sys/modules/spigen
  
  Reviewed by:  ian
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D16368

Modified:
  head/sys/modules/spigen/Makefile

Modified: head/sys/modules/spigen/Makefile
==
--- head/sys/modules/spigen/MakefileFri Jul 20 17:45:26 2018
(r336560)
+++ head/sys/modules/spigen/MakefileFri Jul 20 17:46:55 2018
(r336561)
@@ -9,6 +9,7 @@ SRCS+=  \
bus_if.h \
device_if.h \
opt_platform.h \
+   opt_spi.h \
spibus_if.h \
 
 .if !empty(OPT_FDT)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r336354 - head/stand/i386/zfsboot

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Mon Jul 16 19:21:50 2018
New Revision: 336354
URL: https://svnweb.freebsd.org/changeset/base/336354

Log:
  zfsboot: fix build with WITHOUT_LOADER_GELI
  
  Reviewed by:  ian
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D16292

Modified:
  head/stand/i386/zfsboot/zfsboot.c

Modified: head/stand/i386/zfsboot/zfsboot.c
==
--- head/stand/i386/zfsboot/zfsboot.c   Mon Jul 16 19:05:50 2018
(r336353)
+++ head/stand/i386/zfsboot/zfsboot.c   Mon Jul 16 19:21:50 2018
(r336354)
@@ -708,7 +708,9 @@ main(void)
 setheap(heap_next, heap_end);
 
 zdsk = malloc(sizeof(struct zfsdsk));
+#ifdef LOADER_GELI_SUPPORT
 zdsk->gdev = NULL;
+#endif
 zdsk->dsk.drive = *(uint8_t *)PTOV(ARGS);
 zdsk->dsk.type = zdsk->dsk.drive & DRV_HARD ? TYPE_AD : TYPE_FD;
 zdsk->dsk.unit = zdsk->dsk.drive & DRV_MASK;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r335382 - head/sys/contrib/libnv

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Tue Jun 19 18:43:02 2018
New Revision: 335382
URL: https://svnweb.freebsd.org/changeset/base/335382

Log:
  Really fix the style.
  
  Approved by:  oshogbo
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/contrib/libnv/nvpair.c

Modified: head/sys/contrib/libnv/nvpair.c
==
--- head/sys/contrib/libnv/nvpair.c Tue Jun 19 18:32:06 2018
(r335381)
+++ head/sys/contrib/libnv/nvpair.c Tue Jun 19 18:43:02 2018
(r335382)
@@ -1979,7 +1979,7 @@ int
 nvpair_append_nvlist_array(nvpair_t *nvp, const nvlist_t *value)
 {
nvpair_t *tmpnvp;
-   nvlist_t *nvl, *prev = NULL;
+   nvlist_t *nvl, *prev;
int flags;
 
NVPAIR_ASSERT(nvp);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r335380 - head/sys/contrib/libnv

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Tue Jun 19 18:25:43 2018
New Revision: 335380
URL: https://svnweb.freebsd.org/changeset/base/335380

Log:
  style(9) fix, I was also going to silence gcc.
  
  Approved by:  emaste, oshogbo
  Sponsored by: The FreeBSD Foundation

Modified:
  head/sys/contrib/libnv/nvpair.c

Modified: head/sys/contrib/libnv/nvpair.c
==
--- head/sys/contrib/libnv/nvpair.c Tue Jun 19 18:09:15 2018
(r335379)
+++ head/sys/contrib/libnv/nvpair.c Tue Jun 19 18:25:43 2018
(r335380)
@@ -1997,6 +1997,7 @@ nvpair_append_nvlist_array(nvpair_t *nvp, const nvlist
nvlist_set_flags(nvl, flags);
 
tmpnvp = NULL;
+   prev = NULL;
if (nvp->nvp_nitems > 0) {
nvlist_t **nvls = (void *)(uintptr_t)nvp->nvp_data;
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r334985 - head/sbin/geom/class/part

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Tue Jun 12 01:50:58 2018
New Revision: 334985
URL: https://svnweb.freebsd.org/changeset/base/334985

Log:
  Follow r333233, add fat32lba description to gpart(8)
  
  Reviewed by:  emaste
  MFC after:3 days
  X-MFC with:   r333233
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D15767

Modified:
  head/sbin/geom/class/part/gpart.8

Modified: head/sbin/geom/class/part/gpart.8
==
--- head/sbin/geom/class/part/gpart.8   Tue Jun 12 01:24:48 2018
(r334984)
+++ head/sbin/geom/class/part/gpart.8   Tue Jun 12 01:50:58 2018
(r334985)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd May 11, 2018
+.Dd June 11, 2018
 .Dt GPART 8
 .Os
 .Sh NAME
@@ -806,6 +806,11 @@ for MBR.
 A partition that contains a FAT32 filesystem.
 The scheme-specific type is
 .Qq Li "!11"
+for MBR.
+.It Cm fat32lba
+A partition that contains a FAT32 (LBA) filesystem.
+The scheme-specific type is
+.Qq Li "!12"
 for MBR.
 .It Cm linux-data
 A Linux partition that contains some filesystem with data.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r333465 - head/sys/cam/ctl

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Thu May 10 17:22:04 2018
New Revision: 333465
URL: https://svnweb.freebsd.org/changeset/base/333465

Log:
  Fix build for platforms using GCC:
  
  - Remove unused or dead store variable
  - Remove unused function ctl_copyin_alloc
  - Add missing curly brackets, this seems a regression in r287720
  
  Reviewed by:  jhibbits
  Differential Revision:https://reviews.freebsd.org/D15383

Modified:
  head/sys/cam/ctl/ctl.c

Modified: head/sys/cam/ctl/ctl.c
==
--- head/sys/cam/ctl/ctl.c  Thu May 10 17:00:33 2018(r333464)
+++ head/sys/cam/ctl/ctl.c  Thu May 10 17:22:04 2018(r333465)
@@ -2454,25 +2454,6 @@ ctl_ioctl_fill_ooa(struct ctl_lun *lun, uint32_t *cur_
mtx_unlock(>lun_lock);
 }
 
-static void *
-ctl_copyin_alloc(void *user_addr, unsigned int len, char *error_str,
-size_t error_str_len)
-{
-   void *kptr;
-
-   kptr = malloc(len, M_CTL, M_WAITOK | M_ZERO);
-
-   if (copyin(user_addr, kptr, len) != 0) {
-   snprintf(error_str, error_str_len, "Error copying %d bytes "
-"from user address %p to kernel address %p", len,
-user_addr, kptr);
-   free(kptr, M_CTL);
-   return (NULL);
-   }
-
-   return (kptr);
-}
-
 /*
  * Escape characters that are illegal or not recommended in XML.
  */
@@ -5070,11 +5051,9 @@ ctl_lun_secondary(struct ctl_be_lun *be_lun)
 int
 ctl_invalidate_lun(struct ctl_be_lun *be_lun)
 {
-   struct ctl_softc *softc;
struct ctl_lun *lun;
 
lun = (struct ctl_lun *)be_lun->ctl_lun;
-   softc = lun->ctl_softc;
 
mtx_lock(>lun_lock);
 
@@ -6270,7 +6249,7 @@ ctl_mode_select(struct ctl_scsiio *ctsio)
 {
struct ctl_lun *lun = CTL_LUN(ctsio);
union ctl_modepage_info *modepage_info;
-   int bd_len, i, header_size, param_len, pf, rtd, sp;
+   int bd_len, i, header_size, param_len, rtd;
uint32_t initidx;
 
initidx = ctl_get_initindex(>io_hdr.nexus);
@@ -6280,9 +6259,7 @@ ctl_mode_select(struct ctl_scsiio *ctsio)
 
cdb = (struct scsi_mode_select_6 *)ctsio->cdb;
 
-   pf = (cdb->byte2 & SMS_PF) ? 1 : 0;
rtd = (cdb->byte2 & SMS_RTD) ? 1 : 0;
-   sp = (cdb->byte2 & SMS_SP) ? 1 : 0;
param_len = cdb->length;
header_size = sizeof(struct scsi_mode_header_6);
break;
@@ -6292,9 +6269,7 @@ ctl_mode_select(struct ctl_scsiio *ctsio)
 
cdb = (struct scsi_mode_select_10 *)ctsio->cdb;
 
-   pf = (cdb->byte2 & SMS_PF) ? 1 : 0;
rtd = (cdb->byte2 & SMS_RTD) ? 1 : 0;
-   sp = (cdb->byte2 & SMS_SP) ? 1 : 0;
param_len = scsi_2btoul(cdb->length);
header_size = sizeof(struct scsi_mode_header_10);
break;
@@ -6417,13 +6392,12 @@ int
 ctl_mode_sense(struct ctl_scsiio *ctsio)
 {
struct ctl_lun *lun = CTL_LUN(ctsio);
-   int pc, page_code, dbd, llba, subpage;
+   int pc, page_code, dbd, subpage;
int alloc_len, page_len, header_len, total_len;
struct scsi_mode_block_descr *block_desc;
struct ctl_page_index *page_index;
 
dbd = 0;
-   llba = 0;
block_desc = NULL;
 
CTL_DEBUG_PRINT(("ctl_mode_sense\n"));
@@ -6457,8 +6431,6 @@ ctl_mode_sense(struct ctl_scsiio *ctsio)
dbd = 1;
else
header_len += sizeof(struct scsi_mode_block_descr);
-   if (cdb->byte2 & SMS10_LLBAA)
-   llba = 1;
pc = (cdb->page & SMS_PAGE_CTRL_MASK) >> 6;
page_code = cdb->page & SMS_PAGE_CODE;
subpage = cdb->subpage;
@@ -8631,10 +8603,11 @@ ctl_hndl_per_res_out_on_other_sc(union ctl_io *io)
if (lun->pr_res_type != SPR_TYPE_EX_AC &&
lun->pr_res_type != SPR_TYPE_WR_EX &&
(lun->MODE_CTRL.queue_flags & SCP_NUAR) == 0) {
-   for (i = softc->init_min; i < softc->init_max; i++)
+   for (i = softc->init_min; i < softc->init_max; i++) {
if (i == residx || ctl_get_prkey(lun, i) == 0)
continue;
ctl_est_ua(lun, i, CTL_UA_RES_RELEASE);
+   }
}
 
lun->flags &= ~CTL_LUN_PR_RESERVED;
@@ -10452,7 +10425,6 @@ ctl_get_event_status(struct ctl_scsiio *ctsio)
struct scsi_get_event_status_header *hdr;
struct scsi_get_event_status *cdb;
uint32_t alloc_len, data_len;
-   int notif_class;
 
cdb = (struct scsi_get_event_status *)ctsio->cdb;
if ((cdb->byte2 & SGESN_POLLED) == 0) {
@@ -10461,7 +10433,6 @@ ctl_get_event_status(struct ctl_scsiio *ctsio)
   

Re: svn commit: r333010 - head/sys/mips/mips

[Li-Wen Hsu]

On Thu, Apr 26, 2018 at 7:59 AM, Ian Lepore <i...@freebsd.org> wrote:
> On Wed, 2018-04-25 at 19:46 +0000, Li-Wen Hsu wrote:
>> Author: lwhsu (ports committer)
>> Date: Wed Apr 25 19:46:39 2018
>> New Revision: 333010
>> URL: https://svnweb.freebsd.org/changeset/base/333010
>>
>> Log:
>>   Fix mips32 build after r332951.
>>
>>   Approved by:jhb
>>
>> Modified:
>>   head/sys/mips/mips/pm_machdep.c
>>
>> Modified: head/sys/mips/mips/pm_machdep.c
>> ==
>> --- head/sys/mips/mips/pm_machdep.c   Wed Apr 25 18:59:29 2018
>> (r333009)
>> +++ head/sys/mips/mips/pm_machdep.c   Wed Apr 25 19:46:39 2018
>> (r333010)
>> @@ -264,7 +264,7 @@ ptrace_single_step(struct thread *td)
>>   va = locr0->pc + 4;
>>   }
>>   if (td->td_md.md_ss_addr) {
>> - printf("SS %s (%d): breakpoint already set at %lx (va %lx)\n",
>> + printf("SS %s (%d): breakpoint already set at %zx (va %zx)\n",
>>   p->p_comm, p->p_pid, td->td_md.md_ss_addr, va); /* XXX */
>>   error = EFAULT;
>>   goto out;
>> @@ -500,7 +500,7 @@ ptrace_clear_single_step(struct thread *td)
>>
>>   if (error != 0) {
>>   log(LOG_ERR,
>> - "SS %s %d: can't restore instruction at %lx: %x\n",
>> + "SS %s %d: can't restore instruction at %zx: %x\n",
>>   p->p_comm, p->p_pid, td->td_md.md_ss_addr,
>>   td->td_md.md_ss_instr);
>>   }
>>
>
> This isn't right either.  %z is for size_t values, both md_ss_addr and
> va are integers and a plain %x should be the right format.

But it will break mips64:

cc1: warnings being treated as errors
/home/lwhsu/src/sys/mips/mips/pm_machdep.c: In function 'ptrace_single_step':
/home/lwhsu/src/sys/mips/mips/pm_machdep.c:268: warning: format '%x'
expects type 'unsigned int', but argument 4 has type 'uintptr_t'
[-Wformat]
/home/lwhsu/src/sys/mips/mips/pm_machdep.c:268: warning: format '%x'
expects type 'unsigned int', but argument 5 has type 'uintptr_t'
[-Wformat]
/home/lwhsu/src/sys/mips/mips/pm_machdep.c: In function
'ptrace_clear_single_step':
/home/lwhsu/src/sys/mips/mips/pm_machdep.c:505: warning: format '%x'
expects type 'unsigned int', but argument 5 has type 'uintptr_t'
[-Wformat]
*** [pm_machdep.o] Error code 1

Another way is cast arguments to uintmax_t and use %jx.  Will that be better?

Li-Wen

-- 
Li-Wen Hsu <lw...@freebsd.org>
https://lwhsu.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r333010 - head/sys/mips/mips

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Wed Apr 25 19:46:39 2018
New Revision: 333010
URL: https://svnweb.freebsd.org/changeset/base/333010

Log:
  Fix mips32 build after r332951.
  
  Approved by:  jhb

Modified:
  head/sys/mips/mips/pm_machdep.c

Modified: head/sys/mips/mips/pm_machdep.c
==
--- head/sys/mips/mips/pm_machdep.c Wed Apr 25 18:59:29 2018
(r333009)
+++ head/sys/mips/mips/pm_machdep.c Wed Apr 25 19:46:39 2018
(r333010)
@@ -264,7 +264,7 @@ ptrace_single_step(struct thread *td)
va = locr0->pc + 4;
}
if (td->td_md.md_ss_addr) {
-   printf("SS %s (%d): breakpoint already set at %lx (va %lx)\n",
+   printf("SS %s (%d): breakpoint already set at %zx (va %zx)\n",
p->p_comm, p->p_pid, td->td_md.md_ss_addr, va); /* XXX */
error = EFAULT;
goto out;
@@ -500,7 +500,7 @@ ptrace_clear_single_step(struct thread *td)
 
if (error != 0) {
log(LOG_ERR,
-   "SS %s %d: can't restore instruction at %lx: %x\n",
+   "SS %s %d: can't restore instruction at %zx: %x\n",
p->p_comm, p->p_pid, td->td_md.md_ss_addr,
td->td_md.md_ss_instr);
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r332989 - head/sys/i386/include

[Li-Wen Hsu]

Author: lwhsu (ports committer)
Date: Wed Apr 25 07:51:41 2018
New Revision: 332989
URL: https://svnweb.freebsd.org/changeset/base/332989

Log:
  Fix i386 build after r332970 by adding IS_BSP() definition.
  
  Approved by:  kib

Modified:
  head/sys/i386/include/pcpu.h

Modified: head/sys/i386/include/pcpu.h
==
--- head/sys/i386/include/pcpu.hWed Apr 25 06:50:19 2018
(r332988)
+++ head/sys/i386/include/pcpu.hWed Apr 25 07:51:41 2018
(r332989)
@@ -240,6 +240,8 @@ __curpcb(void)
 }
 #definecurpcb  (__curpcb())
 
+#defineIS_BSP()(PCPU_GET(cpuid) == 0)
+
 #else /* defined(__GNUCLIKE_ASM) && defined(__GNUCLIKE___TYPEOF) */
 
 #error "this file needs to be ported to your compiler"
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r331606 - in head/sys: amd64/include i386/include x86/x86 x86/xen

[Li-Wen Hsu]

On Mon, Mar 26, 2018 at 20:35:12 -1000, Jeff Roberson wrote:
> The patch has been on my branch for weeks and has been tested by a half 
> dozen people.  I'm sorry it does not work for you.  If you reverted 331605 
> the change that followed should not have built properly.  Did you build 
> cleanly?  Can you share your kernel config?
> 
> I tried with and without EARLY_AP_STARTUP and with and without NUMA.  I'm 
> not having any trouble booting.  Did you make cleandepend && make depend?

It also hangs in our testing system:

https://ci.freebsd.org/job/FreeBSD-head-amd64-test/6817/console
https://ci.freebsd.org/job/FreeBSD-head-i386-test/1000/console

It is built cleanly and uses unmodified GENERIC config.

The artifacts used are available here:

https://artifact.ci.freebsd.org/snapshot/head/r331606/amd64/amd64/
https://artifact.ci.freebsd.org/snapshot/head/r331606/i386/i386/

Hope these information help.

Li-Wen

-- 
Li-Wen Hsu <lw...@freebsd.org>
https://lwhsu.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"