Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt

2017-03-21 Thread Mathieu Arnold
Le 21/03/2017 à 08:27, Gleb Smirnoff a écrit :
> On Tue, Mar 21, 2017 at 08:22:19AM +0100, Baptiste Daroussin wrote:
> B> On Mon, Mar 20, 2017 at 11:54:33PM -0700, Gleb Smirnoff wrote:
> B> > On Tue, Mar 21, 2017 at 07:50:32AM +0100, Antoine Brodin wrote:
> B> > A> >   This change is known to break a ton of ports. More than 100 if
> B> > A> > counting depends. I'm sorry for that and I already started to fix
> B> > A> > them.
> B> > A> >
> B> > A> > Please send all new breakages to me.
> B> > A> 
> B> > A> Hi,
> B> > A> 
> B> > A> Exp-runs should happen before breakage happens, not after.
> B> > A> If you already know that it breaks hundreds of ports, please revert
> B> > A> and request an exp-run.
> B> > 
> B> > The exp-run has already been made:
> B> > 
> B> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210673
> B> > 
> B> > Wasn't very helpful.
> B> > 
> B> 
> B> I disagree it was useful it showed you some ports that were breaking given 
> there
> B> was some high level one you were expected to provide patches to fix them.
>
> I'm working on them right now.

You should have worked on it *before* the patch breaking everything
landed, providing patches for the ports that were reported as broken,
and repeat until all the ports that were building before were building
again.

You should **not** have committed the patch to the src tree before all
those patches were created, and you should have committed all the
patches at once, preferably before committing the patch to the src tree.


-- 
Mathieu Arnold




signature.asc
Description: OpenPGP digital signature


svn commit: r301923 - svnadmin/hooks/scripts

2016-06-15 Thread Mathieu Arnold
Author: mat (doc,ports committer)
Date: Wed Jun 15 09:08:14 2016
New Revision: 301923
URL: https://svnweb.freebsd.org/changeset/base/301923

Log:
  Sync all svnadmin hooks to prevent empty messages, and update with
  current commit hook template lines

Modified:
  svnadmin/hooks/scripts/log-police.py

Modified: svnadmin/hooks/scripts/log-police.py
==
--- svnadmin/hooks/scripts/log-police.pyWed Jun 15 08:34:36 2016
(r301922)
+++ svnadmin/hooks/scripts/log-police.pyWed Jun 15 09:08:14 2016
(r301923)
@@ -46,13 +46,18 @@ def fix_log_message(log_message):
 # should check last paragraph for known headers.
 if line == "PR:": continue
 if line == "Submitted by:": continue
+if line == "Reported by:": continue
 if line == "Reviewed by:": continue
 if line == "Approved by:": continue
 if line == "Obtained from:": continue
 if line == "MFC after:": continue
+if line == "MFH:": continue
 if line == "Relnotes:": continue
 if line == "Security:": continue
+if line == "Changes:": continue
+if line == "With hat:": continue
 if line == "Sponsored by:": continue
+if line == "Differential Revision:": continue
 s = s + line + "\n"
   s = s.rstrip() + "\n"
   return s
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r296465 - in releng/9.3: . crypto/openssl crypto/openssl/apps crypto/openssl/bugs crypto/openssl/crypto crypto/openssl/crypto/aes crypto/openssl/crypto/asn1 crypto/openssl/crypto/bf cr

2016-03-08 Thread Mathieu Arnold


+--On 8 mars 2016 09:01:04 -0800 Bryan Drewery <bdrew...@freebsd.org> wrote:
| On 3/8/2016 8:52 AM, Mathieu Arnold wrote:
|> +--On 8 mars 2016 08:48:27 -0800 Bryan Drewery <bdrew...@freebsd.org>
|> wrote:
|> | On 3/8/2016 8:47 AM, Bryan Drewery wrote:
|> |> On 3/8/2016 8:35 AM, Mathieu Arnold wrote:
|> |>> +--On 8 mars 2016 08:29:41 -0800 Bryan Drewery <bdrew...@freebsd.org>
|> |>> wrote:
|> |>> | On 3/8/2016 8:28 AM, Mathieu Arnold wrote:
|> |>> |> +--On 8 mars 2016 08:25:44 -0800 Bryan Drewery
|> |>> |> <bdrew...@freebsd.org> wrote:
|> |>> |> | On 3/7/2016 4:29 PM, Mathieu Arnold wrote:
|> |>> |> |> +--On 7 mars 2016 16:22:12 + Xin LI <delp...@freebsd.org>
|> |>> |> |> wrote:
|> |>> |> |> | Author: delphij
|> |>> |> |> | Date: Mon Mar  7 16:22:11 2016
|> |>> |> |> | New Revision: 296465
|> |>> |> |> | URL: https://svnweb.freebsd.org/changeset/base/296465
|> |>> |> |> | 
|> |>> |> |> | Log:
|> |>> |> |> |   Fix multiple OpenSSL vulnerabilities.
|> |>> |> |> |   
|> |>> |> |> |   Security:  FreeBSD-SA-16:12.openssl
|> |>> |> |> |   Approved by:   so
|> |>> |> |> 
|> |>> |> |> After that, poudriere bulk fails with:
|> |>> |> |> 
|> |>> |> |> [00:00:07] >> Creating pkgng repository
|> |>> |> |> Creating repository in /tmp/packages: 100%
|> |>> |> |> Packing files for repository:   0%Child process pid=50970
|> |>> |> |> terminated abnormally: Segmentation fault: 11
|> |>> |> |> [00:00:08] >> Cleaning up
|> |>> |> |> 9amd64-pkgng-default: removed
|> |>> |> |> 9amd64-pkgng-default-n: removed
|> |>> |> |> 
|> |>> |> |> pkg-static is the one doing the segfault...
|> |>> |> |> 
|> |>> |> | 
|> |>> |> | Is QEMU involved here?
|> |>> |> | 
|> |>> |> | Do you have PKG_REPO_FROM_HOST or PKG_REPO_SIGNING_KEY set? (Not
|> |>> |> | saying you should)
|> |>> |> 
|> |>> |> No, it's a regular 9amd64 build on a 10.2 amd64 host.
|> |>> |> 
|> |>> | 
|> |>> | Can you please rebuild pkg with debug symbols and then run your 9.3
|> |>> | version against the repo in gdb?
|> |>> 
|> |>> I could yes, but not today, tomorrow at the earliest.  How do I build
|> |>> the port with debug symbols ?
|> |>> 
|> |> 
|> |> WITH_DEBUG=yes make
|> |> 
|> | 
|> | You might need this too: DEBUG_FLAGS="-g -O0"
|> 
|> Mmmm, ok, what commands do I need to run ?
|> 
| 
| (assuming devel/gdb installed)
| gdb710 --args /usr/local/sbin/pkg-static repo 
|# run
| 
|# bt full

Ok, so, it's 9.3, so there's no gdb710, but:


the command ran is:

root@pkg:/tmp/foo # pkg repo . ../repo.key
Creating repository in .: 100%
Packing files for repository:   0%Child process pid=16312 terminated
abnormally: Segmentation fault: 11
root@pkg:/tmp/foo # gdb /usr/local/sbin/pkg pkg.core
GNU gdb 6.1.1 [FreeBSD]
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain
conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "amd64-marcel-freebsd"...
Core was generated by `pkg'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /usr/local/lib/libpkg.so.3...done.
Loaded symbols for /usr/local/lib/libpkg.so.3
Reading symbols from /lib/libutil.so.9...done.
Loaded symbols for /lib/libutil.so.9
Reading symbols from /usr/lib/libssl.so.6...done.
Loaded symbols for /usr/lib/libssl.so.6
Reading symbols from /lib/libcrypto.so.6...done.
Loaded symbols for /lib/libcrypto.so.6
Reading symbols from /lib/libm.so.5...done.
Loaded symbols for /lib/libm.so.5
Reading symbols from /usr/lib/libelf.so.1...done.
Loaded symbols for /usr/lib/libelf.so.1
Reading symbols from /lib/libjail.so.1...done.
Loaded symbols for /lib/libjail.so.1
Reading symbols from /usr/lib/libarchive.so.5...done.
Loaded symbols for /usr/lib/libarchive.so.5
Reading symbols from /lib/libz.so.6...done.
Loaded symbols for /lib/libz.so.6
Reading symbols from /usr/lib/libbz2.so.4...done.
Loaded symbols for /usr/lib/libbz2.so.4
Reading symbols from /usr/lib/liblzma.so.5...done.
Loaded symbols for /usr/lib/liblzma.so.5
Reading symbols from /lib/libc.so.7...done.
Loaded symbols for /lib/libc.so.7
Reading symbols from /lib/libbsdxml.so.4...done

Re: svn commit: r296465 - in releng/9.3: . crypto/openssl crypto/openssl/apps crypto/openssl/bugs crypto/openssl/crypto crypto/openssl/crypto/aes crypto/openssl/crypto/asn1 crypto/openssl/crypto/bf cr

2016-03-08 Thread Mathieu Arnold


+--On 7 mars 2016 22:15:25 -0800 Xin Li <delp...@delphij.net> wrote:
| 
| 
| On 3/7/16 16:29, Mathieu Arnold wrote:
|> +--On 7 mars 2016 16:22:12 + Xin LI <delp...@freebsd.org> wrote:
|> | Author: delphij
|> | Date: Mon Mar  7 16:22:11 2016
|> | New Revision: 296465
|> | URL: https://svnweb.freebsd.org/changeset/base/296465
|> | 
|> | Log:
|> |   Fix multiple OpenSSL vulnerabilities.
|> |   
|> |   Security:FreeBSD-SA-16:12.openssl
|> |   Approved by: so
|> 
|> After that, poudriere bulk fails with:
|> 
|> [00:00:07] >> Creating pkgng repository
|> Creating repository in /tmp/packages: 100%
|> Packing files for repository:   0%Child process pid=50970 terminated
|> abnormally: Segmentation fault: 11
|> [00:00:08] >> Cleaning up
|> 9amd64-pkgng-default: removed
|> 9amd64-pkgng-default-n: removed
|> 
|> pkg-static is the one doing the segfault...
| 
| I can't seem to be able to reproduce this, what ports are you trying to
| bulk?  (Also note that after doing poudriere jail -u, the bulk seems to
| have rebuilt pkg, I'm not sure if that matters, but it's possible, do I
| need to explicitly specify something to avoid this?).

Ok, I use a signed repo, which is why it fails.  When I run pkg repo . it
works, with pkg repo . ../repo.key it cores dump.

-- 
Mathieu Arnold

pgpksmrX17gtR.pgp
Description: PGP signature


Re: svn commit: r296465 - in releng/9.3: . crypto/openssl crypto/openssl/apps crypto/openssl/bugs crypto/openssl/crypto crypto/openssl/crypto/aes crypto/openssl/crypto/asn1 crypto/openssl/crypto/bf cr

2016-03-08 Thread Mathieu Arnold
+--On 8 mars 2016 08:48:27 -0800 Bryan Drewery <bdrew...@freebsd.org> wrote:
| On 3/8/2016 8:47 AM, Bryan Drewery wrote:
|> On 3/8/2016 8:35 AM, Mathieu Arnold wrote:
|>> +--On 8 mars 2016 08:29:41 -0800 Bryan Drewery <bdrew...@freebsd.org>
|>> wrote:
|>> | On 3/8/2016 8:28 AM, Mathieu Arnold wrote:
|>> |> +--On 8 mars 2016 08:25:44 -0800 Bryan Drewery <bdrew...@freebsd.org>
|>> |> wrote:
|>> |> | On 3/7/2016 4:29 PM, Mathieu Arnold wrote:
|>> |> |> +--On 7 mars 2016 16:22:12 + Xin LI <delp...@freebsd.org>
|>> |> |> wrote:
|>> |> |> | Author: delphij
|>> |> |> | Date: Mon Mar  7 16:22:11 2016
|>> |> |> | New Revision: 296465
|>> |> |> | URL: https://svnweb.freebsd.org/changeset/base/296465
|>> |> |> | 
|>> |> |> | Log:
|>> |> |> |   Fix multiple OpenSSL vulnerabilities.
|>> |> |> |   
|>> |> |> |   Security: FreeBSD-SA-16:12.openssl
|>> |> |> |   Approved by:  so
|>> |> |> 
|>> |> |> After that, poudriere bulk fails with:
|>> |> |> 
|>> |> |> [00:00:07] >> Creating pkgng repository
|>> |> |> Creating repository in /tmp/packages: 100%
|>> |> |> Packing files for repository:   0%Child process pid=50970
|>> |> |> terminated abnormally: Segmentation fault: 11
|>> |> |> [00:00:08] >> Cleaning up
|>> |> |> 9amd64-pkgng-default: removed
|>> |> |> 9amd64-pkgng-default-n: removed
|>> |> |> 
|>> |> |> pkg-static is the one doing the segfault...
|>> |> |> 
|>> |> | 
|>> |> | Is QEMU involved here?
|>> |> | 
|>> |> | Do you have PKG_REPO_FROM_HOST or PKG_REPO_SIGNING_KEY set? (Not
|>> |> | saying you should)
|>> |> 
|>> |> No, it's a regular 9amd64 build on a 10.2 amd64 host.
|>> |> 
|>> | 
|>> | Can you please rebuild pkg with debug symbols and then run your 9.3
|>> | version against the repo in gdb?
|>> 
|>> I could yes, but not today, tomorrow at the earliest.  How do I build
|>> the port with debug symbols ?
|>> 
|> 
|> WITH_DEBUG=yes make
|> 
| 
| You might need this too: DEBUG_FLAGS="-g -O0"

Mmmm, ok, what commands do I need to run ?

-- 
Mathieu Arnold

pgpmtwpkK7vN8.pgp
Description: PGP signature


Re: svn commit: r296465 - in releng/9.3: . crypto/openssl crypto/openssl/apps crypto/openssl/bugs crypto/openssl/crypto crypto/openssl/crypto/aes crypto/openssl/crypto/asn1 crypto/openssl/crypto/bf cr

2016-03-08 Thread Mathieu Arnold
+--On 8 mars 2016 08:29:41 -0800 Bryan Drewery <bdrew...@freebsd.org> wrote:
| On 3/8/2016 8:28 AM, Mathieu Arnold wrote:
|> +--On 8 mars 2016 08:25:44 -0800 Bryan Drewery <bdrew...@freebsd.org>
|> wrote:
|> | On 3/7/2016 4:29 PM, Mathieu Arnold wrote:
|> |> +--On 7 mars 2016 16:22:12 + Xin LI <delp...@freebsd.org> wrote:
|> |> | Author: delphij
|> |> | Date: Mon Mar  7 16:22:11 2016
|> |> | New Revision: 296465
|> |> | URL: https://svnweb.freebsd.org/changeset/base/296465
|> |> | 
|> |> | Log:
|> |> |   Fix multiple OpenSSL vulnerabilities.
|> |> |   
|> |> |   Security: FreeBSD-SA-16:12.openssl
|> |> |   Approved by:  so
|> |> 
|> |> After that, poudriere bulk fails with:
|> |> 
|> |> [00:00:07] >> Creating pkgng repository
|> |> Creating repository in /tmp/packages: 100%
|> |> Packing files for repository:   0%Child process pid=50970 terminated
|> |> abnormally: Segmentation fault: 11
|> |> [00:00:08] >> Cleaning up
|> |> 9amd64-pkgng-default: removed
|> |> 9amd64-pkgng-default-n: removed
|> |> 
|> |> pkg-static is the one doing the segfault...
|> |> 
|> | 
|> | Is QEMU involved here?
|> | 
|> | Do you have PKG_REPO_FROM_HOST or PKG_REPO_SIGNING_KEY set? (Not saying
|> | you should)
|> 
|> No, it's a regular 9amd64 build on a 10.2 amd64 host.
|> 
| 
| Can you please rebuild pkg with debug symbols and then run your 9.3
| version against the repo in gdb?

I could yes, but not today, tomorrow at the earliest.  How do I build the
port with debug symbols ?

-- 
Mathieu Arnold

pgpoL9qwXdGtQ.pgp
Description: PGP signature


Re: svn commit: r296465 - in releng/9.3: . crypto/openssl crypto/openssl/apps crypto/openssl/bugs crypto/openssl/crypto crypto/openssl/crypto/aes crypto/openssl/crypto/asn1 crypto/openssl/crypto/bf cr

2016-03-08 Thread Mathieu Arnold
+--On 8 mars 2016 08:25:44 -0800 Bryan Drewery <bdrew...@freebsd.org> wrote:
| On 3/7/2016 4:29 PM, Mathieu Arnold wrote:
|> +--On 7 mars 2016 16:22:12 + Xin LI <delp...@freebsd.org> wrote:
|> | Author: delphij
|> | Date: Mon Mar  7 16:22:11 2016
|> | New Revision: 296465
|> | URL: https://svnweb.freebsd.org/changeset/base/296465
|> | 
|> | Log:
|> |   Fix multiple OpenSSL vulnerabilities.
|> |   
|> |   Security:FreeBSD-SA-16:12.openssl
|> |   Approved by: so
|> 
|> After that, poudriere bulk fails with:
|> 
|> [00:00:07] >> Creating pkgng repository
|> Creating repository in /tmp/packages: 100%
|> Packing files for repository:   0%Child process pid=50970 terminated
|> abnormally: Segmentation fault: 11
|> [00:00:08] >> Cleaning up
|> 9amd64-pkgng-default: removed
|> 9amd64-pkgng-default-n: removed
|> 
|> pkg-static is the one doing the segfault...
|> 
| 
| Is QEMU involved here?
| 
| Do you have PKG_REPO_FROM_HOST or PKG_REPO_SIGNING_KEY set? (Not saying
| you should)

No, it's a regular 9amd64 build on a 10.2 amd64 host.

-- 
Mathieu Arnold

pgpXc6CjaqpLH.pgp
Description: PGP signature


Re: svn commit: r296465 - in releng/9.3: . crypto/openssl crypto/openssl/apps crypto/openssl/bugs crypto/openssl/crypto crypto/openssl/crypto/aes crypto/openssl/crypto/asn1 crypto/openssl/crypto/bf cr

2016-03-08 Thread Mathieu Arnold
+--On 8 mars 2016 08:03:14 -0800 NGie Cooper <yaneurab...@gmail.com> wrote:
|> Well, I was doing a bulk with dns/bind99 dns/bind910, it did rebuild
|> everything needed by them because of the SA, and then pkg crashed while
|> building the repository.
| 
| Mike said similar on the stable/9 commit thread. I think the commit(s)
| should be backed out, fixed, and recommitted once the issue has been
| fixed.

Well, It's not really the commit, it's the SA that seems to have broken
pkg.  So something should be done, yes, sure.  My poudriere follows
9.3-RELEASE, and is updated with freebsd-update :-)

-- 
Mathieu Arnold

pgp0cM4GJahoN.pgp
Description: PGP signature


Re: svn commit: r296465 - in releng/9.3: . crypto/openssl crypto/openssl/apps crypto/openssl/bugs crypto/openssl/crypto crypto/openssl/crypto/aes crypto/openssl/crypto/asn1 crypto/openssl/crypto/bf cr

2016-03-08 Thread Mathieu Arnold


+--On 7 mars 2016 22:15:25 -0800 Xin Li <delp...@delphij.net> wrote:
| 
| 
| On 3/7/16 16:29, Mathieu Arnold wrote:
|> +--On 7 mars 2016 16:22:12 + Xin LI <delp...@freebsd.org> wrote:
|> | Author: delphij
|> | Date: Mon Mar  7 16:22:11 2016
|> | New Revision: 296465
|> | URL: https://svnweb.freebsd.org/changeset/base/296465
|> | 
|> | Log:
|> |   Fix multiple OpenSSL vulnerabilities.
|> |   
|> |   Security:FreeBSD-SA-16:12.openssl
|> |   Approved by: so
|> 
|> After that, poudriere bulk fails with:
|> 
|> [00:00:07] >> Creating pkgng repository
|> Creating repository in /tmp/packages: 100%
|> Packing files for repository:   0%Child process pid=50970 terminated
|> abnormally: Segmentation fault: 11
|> [00:00:08] >> Cleaning up
|> 9amd64-pkgng-default: removed
|> 9amd64-pkgng-default-n: removed
|> 
|> pkg-static is the one doing the segfault...
| 
| I can't seem to be able to reproduce this, what ports are you trying to
| bulk?  (Also note that after doing poudriere jail -u, the bulk seems to
| have rebuilt pkg, I'm not sure if that matters, but it's possible, do I
| need to explicitly specify something to avoid this?).

Well, I was doing a bulk with dns/bind99 dns/bind910, it did rebuild
everything needed by them because of the SA, and then pkg crashed while
building the repository.

-- 
Mathieu Arnold

pgpIFM5L2m0xE.pgp
Description: PGP signature


Re: svn commit: r296465 - in releng/9.3: . crypto/openssl crypto/openssl/apps crypto/openssl/bugs crypto/openssl/crypto crypto/openssl/crypto/aes crypto/openssl/crypto/asn1 crypto/openssl/crypto/bf cr

2016-03-07 Thread Mathieu Arnold
+--On 7 mars 2016 16:22:12 + Xin LI <delp...@freebsd.org> wrote:
| Author: delphij
| Date: Mon Mar  7 16:22:11 2016
| New Revision: 296465
| URL: https://svnweb.freebsd.org/changeset/base/296465
| 
| Log:
|   Fix multiple OpenSSL vulnerabilities.
|   
|   Security:   FreeBSD-SA-16:12.openssl
|   Approved by:so

After that, poudriere bulk fails with:

[00:00:07] >> Creating pkgng repository
Creating repository in /tmp/packages: 100%
Packing files for repository:   0%Child process pid=50970 terminated
abnormally: Segmentation fault: 11
[00:00:08] >> Cleaning up
9amd64-pkgng-default: removed
9amd64-pkgng-default-n: removed

pkg-static is the one doing the segfault...

-- 
Mathieu Arnold

pgp05k6DabGML.pgp
Description: PGP signature


pgpYRcMyP1ADG.pgp
Description: PGP signature


svn commit: r285064 - head

2015-07-02 Thread Mathieu Arnold
Author: mat (doc,ports committer)
Date: Thu Jul  2 22:23:52 2015
New Revision: 285064
URL: https://svnweb.freebsd.org/changeset/base/285064

Log:
  Add repository.callsign, to help arcanist figure out what repo it's
  doing things on when not using Subversion.
  
  With hat: phabric-admin@
  Sponsored by: Absolight

Modified:
  head/.arcconfig

Modified: head/.arcconfig
==
--- head/.arcconfig Thu Jul  2 21:58:10 2015(r285063)
+++ head/.arcconfig Thu Jul  2 22:23:52 2015(r285064)
@@ -1,5 +1,6 @@
 {
project.name: S,
+   repository.callsign : S,
phabricator.uri : https://reviews.freebsd.org/;,
history.immutable : true
 }
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r282985 - in head/sys: arm/annapurna arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm

2015-05-18 Thread Mathieu Arnold
+--On 18 mai 2015 08:04:24 -0600 Ian Lepore i...@freebsd.org wrote:
| On Mon, 2015-05-18 at 10:14 +0200, Mathieu Arnold wrote:
| +--On 18 mai 2015 00:21:43 -0700 Eitan Adler ead...@freebsd.org wrote:
| | On 17 May 2015 at 08:46, Ian Lepore i...@freebsd.org wrote:
| | On Sat, 2015-05-16 at 21:04 -0700, Garrett Cooper wrote:
| |  On May 16, 2015, at 18:45, Adrian Chadd adr...@freebsd.org wrote:
| |  
| |  Did you commit files with DOS newlines in them? :)
| |  
| |  tsk tsk tsk tsk tsk. I think should fix that..
| | 
| | Better yet it should probably be disabled in svn...
| | 
| | 
| | Or flagged by some filter as a diff is uploaded to phabricator, since
| | the web display obscures whitespace.
| | 
| | This is possible.  Would blocking all diffs that match /\r\n$/ work?
| 
| That would crap up all patches that match that, which is a bad idea.
| 
| 
| Why would that be a bad idea?  Do we have files in the system that
| legitimately end with MSDOS line endings that need to be preserved as
| such?
| 
| I'm not sure blocking is the right thing anyway, it would be better if
| it was like a warning dialog...The diff you just uploaded contains DOS
| line endings, continue?

Mmmm, if this can be done only for base, and not for ports, sure, but ports
need to be able to add patches with CRLF endings, because upstream software
comes in all flavors, including CRLF files we need to be able to patch.

The thing is, in that case, the patch files won't be DOS files, they'll be
UNIX files with some lines having \r before the end of line.

-- 
Mathieu Arnold
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r282985 - in head/sys: arm/annapurna arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm

2015-05-18 Thread Mathieu Arnold
+--On 18 mai 2015 00:21:43 -0700 Eitan Adler ead...@freebsd.org wrote:
| On 17 May 2015 at 08:46, Ian Lepore i...@freebsd.org wrote:
| On Sat, 2015-05-16 at 21:04 -0700, Garrett Cooper wrote:
|  On May 16, 2015, at 18:45, Adrian Chadd adr...@freebsd.org wrote:
|  
|  Did you commit files with DOS newlines in them? :)
|  
|  tsk tsk tsk tsk tsk. I think should fix that..
| 
| Better yet it should probably be disabled in svn...
| 
| 
| Or flagged by some filter as a diff is uploaded to phabricator, since
| the web display obscures whitespace.
| 
| This is possible.  Would blocking all diffs that match /\r\n$/ work?

That would crap up all patches that match that, which is a bad idea.

-- 
Mathieu Arnold
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r282985 - in head/sys: arm/annapurna arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm

2015-05-18 Thread Mathieu Arnold
+--On 18 mai 2015 10:52:29 -0400 Ed Maste ema...@freebsd.org wrote:
| On 18 May 2015 at 10:11, Mathieu Arnold m...@absolight.fr wrote:
| 
| Mmmm, if this can be done only for base, and not for ports, sure, but
| ports need to be able to add patches with CRLF endings, because upstream
| software comes in all flavors, including CRLF files we need to be able
| to patch.
| 
| Sure it could, we could configure it however we want.
| 
| Note that we'll likely need to support CRLF in base anyway - one
| obvious example is test cases for CRLF handling in various tools.  I'd
| imagine we could add an SVN keyword like fbsd:crlf=yes, along the
| lines of fbsd:nokeywords=yes.
| 
| Do you know how common CRLF or partial CRLF files are in the ports
| tree?  If it's only a handful that scheme could work there too.

$ ag -l '\r' /usr/ports/|wc -l
  95

there's a bit more than a handful, but it could work, yes.  If you want to
have a look at a typical one, /usr/ports/shells/ibsh/files/patch-Makefile
:-)

But I think Eitan was talking about Phabricator, in this case, it'd need to
work there too.

-- 
Mathieu Arnold
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r270122 - in stable/10: . lib/libopie

2014-10-15 Thread Mathieu Arnold
+--On 11 octobre 2014 00:02:01 +0900 Hiroki Sato h...@freebsd.org wrote:
| Andrey Chernov a...@freebsd.org wrote
|   in 5437f373.1090...@freebsd.org:
| 
| ac On 10.10.2014 18:47, Baptiste Daroussin wrote:
| ac  On Mon, Aug 18, 2014 at 02:42:23AM +, Andrey A. Chernov wrote:
| ac  Author: ache
| ac  Date: Mon Aug 18 02:42:23 2014
| ac  New Revision: 270122
| ac  URL: http://svnweb.freebsd.org/changeset/base/270122
| ac 
| ac  Log:
| acDirect commit to stable/10 reflecting r269961 because the rest
| can't be acmerged.
| ac 
| acBump version because challenge buffer size changed.
| ac 
| ac  Discovered a bit late but it is forbidden to break the ABI in a
| stable branch as ac  it defeats the way we are providing packages for
| users :(
| ac
| ac It is strange that nobody notice that so far. Is there any packages
| ac which builds with libopie? If no, there is no problem. If yes, what
| you
| 
|  cyrus-sasl uses it.

And that is just wha't in the ports tree, companies can have applications
with security features that link with libopie and that will be broken when
they update from 10.0 to 10.1 because the version they had is gone.

-- 
Mathieu Arnold
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r264269 - in head: sys/conf sys/kern sys/modules sys/modules/imgact_binmisc sys/sys usr.sbin usr.sbin/binmiscctl

2014-04-09 Thread Mathieu Arnold
+--On 8 avril 2014 20:10:22 + Sean Bruno sbr...@freebsd.org wrote:
| Log:
|   Add Stacey Son's binary activation patches that allow remapping of
|   execution to a emumation program via parsing of ELF header information.

Can you MFC that to stable/10 one day ?

-- 
Mathieu Arnold
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r260082 - stable/9/sys/vm

2013-12-30 Thread Mathieu Arnold
Hi,

Would you mind committing that on stable/8 too ? The bug must be there too.

+--On 30 décembre 2013 09:04:06 + Konstantin Belousov
k...@freebsd.org wrote:
| Author: kib
| Date: Mon Dec 30 09:04:06 2013
| New Revision: 260082
| URL: http://svnweb.freebsd.org/changeset/base/260082
| 
| Log:
|   MFC r259951:
|   Do not coalesce stack entry. Pass MAP_STACK_GROWS_DOWN and
|   MAP_STACK_GROWS_UP flags to vm_map_insert() from vm_map_stack()
| 
| Modified:
|   stable/9/sys/vm/vm_map.c
| Directory Properties:
|   stable/9/sys/   (props changed)
| 
| Modified: stable/9/sys/vm/vm_map.c
| =
| = --- stable/9/sys/vm/vm_map.cMon Dec 30 08:57:54 2013
(r260081)
| +++ stable/9/sys/vm/vm_map.c  Mon Dec 30 09:04:06 2013(r260082)
| @@ -1230,6 +1230,7 @@ charged:
|   }
|   else if ((prev_entry != map-header) 
|(prev_entry-eflags == protoeflags) 
| +  (cow  (MAP_ENTRY_GROWS_DOWN | MAP_ENTRY_GROWS_UP)) == 0 
|(prev_entry-end == start) 
|(prev_entry-wired_count == 0) 
|(prev_entry-cred == cred ||
| @@ -3341,7 +3342,6 @@ vm_map_stack(vm_map_t map, vm_offset_t a
|* NOTE: We explicitly allow bi-directional stacks.
|*/
|   orient = cow  (MAP_STACK_GROWS_DOWN|MAP_STACK_GROWS_UP);
| - cow = ~orient;
|   KASSERT(orient != 0, (No stack grow direction));
|  
|   if (addrbos  vm_map_min(map) ||
| ___
| svn-src-all@freebsd.org mailing list
| http://lists.freebsd.org/mailman/listinfo/svn-src-all
| To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
| 



-- 
Mathieu Arnold
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org