Re: svn commit: r323304 - stable/11/share/man/man5

[Ngie Cooper]

> On Dec 15, 2017, at 22:57, Herbert J. Skuhra <herb...@mailbox.org> wrote:
> 
>> On Fri, 08 Sep 2017 06:51:16 +0200, Ngie Cooper wrote:
>> 
>> Author: ngie
>> Date: Fri Sep  8 04:51:16 2017
>> New Revision: 323304
>> URL: https://svnweb.freebsd.org/changeset/base/323304
>> 
>> Log:
>>  Regenerate src.conf(5) based on recent changes to src.opts.mk, etc.
>> 
>> Modified:
>>  stable/11/share/man/man5/src.conf.5
>> 
>> Modified: stable/11/share/man/man5/src.conf.5
>> ==
>> --- stable/11/share/man/man5/src.conf.5Fri Sep  8 04:48:25 2017
>> (r323303)
>> +++ stable/11/share/man/man5/src.conf.5Fri Sep  8 04:51:16 2017
>> (r323304)
>> @@ -1,6 +1,6 @@
>> .\" DO NOT EDIT-- this file is generated by tools/build/options/makeman.
>> .\" $FreeBSD$
>> -.Dd August 16, 2017
>> +.Dd September 7, 2017
>> .Dt SRC.CONF 5
>> .Os
>> .Sh NAME
>> @@ -1150,6 +1150,12 @@ and remove
>> entries.
>> .It Va WITHOUT_NLS
>> Set to not build NLS catalogs.
>> +When set, it enforces these options:
>> +.Pp
>> +.Bl -item -compact
>> +.It
>> +.Va WITHOUT_NLS_CATALOGS
>> +.El
>> .It Va WITHOUT_NLS_CATALOGS
>> Set to not build NLS catalog support for
>> .Xr csh 1 .
>> @@ -1237,6 +1243,42 @@ and related files.
>> Set to not build
>> .Xr ppp 8
>> and related programs.
>> +.It Va WITHOUT_PROFILE
>> +Set to not build profiled libraries for use with
>> +.Xr gprof 8 .
>> +.Pp
>> +This is a default setting on
>> +mips/mips64el and mips/mips64.
>> +.It Va WITH_PROFILE
>> +Set to build profiled libraries for use with
>> +.Xr gprof 8 .
>> +.Pp
>> +This is a default setting on
>> +amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64, i386/i386, 
>> mips/mipsel, mips/mips, mips/mipsn32, pc98/i386, powerpc/powerpc, 
>> powerpc/powerpc64 and sparc64/sparc64.
>> +.It Va WITHOUT_PROFILE
>> +Set to not build profiled libraries for use with
>> +.Xr gprof 8 .
>> +.Pp
>> +This is a default setting on
>> +mips/mips64el.
>> +.It Va WITH_PROFILE
>> +Set to build profiled libraries for use with
>> +.Xr gprof 8 .
>> +.Pp
>> +This is a default setting on
>> +amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64, i386/i386, 
>> mips/mipsel, mips/mips, mips/mips64, mips/mipsn32, pc98/i386, 
>> powerpc/powerpc, powerpc/powerpc64 and sparc64/sparc64.
>> +.It Va WITHOUT_PROFILE
>> +Set to not build profiled libraries for use with
>> +.Xr gprof 8 .
>> +.Pp
>> +This is a default setting on
>> +mips/mips64.
>> +.It Va WITH_PROFILE
>> +Set to build profiled libraries for use with
>> +.Xr gprof 8 .
>> +.Pp
>> +This is a default setting on
>> +amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64, i386/i386, 
>> mips/mipsel, mips/mips, mips/mips64el, mips/mipsn32, pc98/i386, 
>> powerpc/powerpc, powerpc/powerpc64 and sparc64/sparc64.
>> .It Va WITHOUT_PROFILE
>> Set to not build profiled libraries for use with
>> .Xr gprof 8 .
> 
> Here something went wrong: multiple (WITH|WITHOUT)_PROFILE entries.

Herbert,
Please file a bug.
Cheers,
-Enji

PS I’m no longer a committer, so my ability to act on freebsd things which I’m 
CCed on is diminished.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r325504 - head/lib/libclang_rt

[Ngie Cooper (yaneurabeya)]

> On Nov 7, 2017, at 11:20, Bryan Drewery <bdrew...@freebsd.org> wrote:
> 
> On 11/6/2017 10:26 PM, Ngie Cooper wrote:
>> Author: ngie
>> Date: Tue Nov  7 06:26:48 2017
>> New Revision: 325504
>> URL: https://svnweb.freebsd.org/changeset/base/325504
>> 
>> Log:
>>  Redo r325502
>> 
>>  :U:Mfoo expands to :Mfoo, apparently. Explicit check for CPUTYPE being
>>  defined, and test for it's value not containing *soft* before calling 
>> CRTARCH
>>  armhf.
>> 
>>  Tested, somewhat. Unfortunately recent changes appear to have affected
>>  cross-builds where it no longer works, per my tests after universe12a being
>>  upgraded from 07/2017 to 11/2017 sources (DESTDIR isn't being used in 
>> WORLDTMP;
>>  MK_SYSTEM_COMPILER might be causing issues right now).
>> 
> 
> In buildworld DESTDIR usually is set to WORLDTMP.  But how does the
> comment relate to CPUTYPE?  What "no longer works" about cross-builds?

If I had my log, I would dig it up, but it’s easy to trigger with “make 
tinderbox TARGETS=arm” on that branch :/.

Basically, it wasn’t looking for libraries in the host toolchain’s directory 
(`/usr/lib/…`), not `/usr/lib/…`.

Cheers,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r325504 - head/lib/libclang_rt

[Ngie Cooper]

Author: ngie
Date: Tue Nov  7 06:26:48 2017
New Revision: 325504
URL: https://svnweb.freebsd.org/changeset/base/325504

Log:
  Redo r325502
  
  :U:Mfoo expands to :Mfoo, apparently. Explicit check for CPUTYPE being
  defined, and test for it's value not containing *soft* before calling CRTARCH
  armhf.
  
  Tested, somewhat. Unfortunately recent changes appear to have affected
  cross-builds where it no longer works, per my tests after universe12a being
  upgraded from 07/2017 to 11/2017 sources (DESTDIR isn't being used in 
WORLDTMP;
  MK_SYSTEM_COMPILER might be causing issues right now).
  
  MFC after:1 week
  MFC with: r325502
  Reported by:  imp

Modified:
  head/lib/libclang_rt/Makefile.inc

Modified: head/lib/libclang_rt/Makefile.inc
==
--- head/lib/libclang_rt/Makefile.inc   Tue Nov  7 05:07:09 2017
(r325503)
+++ head/lib/libclang_rt/Makefile.inc   Tue Nov  7 06:26:48 2017
(r325504)
@@ -3,7 +3,8 @@
 .include 
 
 .if ${MACHINE} == "arm"
-.if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:U:M*soft*} == ""
+.if ${MACHINE_ARCH:Marmv[67]*} != "" && \
+(defined(CPUTYPE) && ${CPUTYPE:M*soft*} == "")
 CRTARCH=   armhf
 .endif
 .endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325502 - head/lib/libclang_rt

[Ngie Cooper]

Author: ngie
Date: Tue Nov  7 05:02:36 2017
New Revision: 325502
URL: https://svnweb.freebsd.org/changeset/base/325502

Log:
  Handle arm/armv[67] hosted/targeted builds gracefully
  
  CPUTYPE (apparently) isn't defined in non-cross-builds, which caused
  arm/armv[67] hosted/targeted builds to fail when evaluating CPUTYPE.
  
  Add the :U modifier to CPUTYPE so it evaluates to "". This allows armv[67] to
  get past the conditional successfully.
  
  MFC after:1 week
  Reported by:  bob prohaska 

Modified:
  head/lib/libclang_rt/Makefile.inc

Modified: head/lib/libclang_rt/Makefile.inc
==
--- head/lib/libclang_rt/Makefile.inc   Tue Nov  7 04:56:53 2017
(r325501)
+++ head/lib/libclang_rt/Makefile.inc   Tue Nov  7 05:02:36 2017
(r325502)
@@ -3,7 +3,7 @@
 .include 
 
 .if ${MACHINE} == "arm"
-.if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:M*soft*} == ""
+.if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:U:M*soft*} == ""
 CRTARCH=   armhf
 .endif
 .endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325501 - head/lib/libclang_rt

[Ngie Cooper]

Author: ngie
Date: Tue Nov  7 04:56:53 2017
New Revision: 325501
URL: https://svnweb.freebsd.org/changeset/base/325501

Log:
  Remove unnecessary src.opts.mk .include
  
  MK_ isn't used in lib/libcompiler_rt/Makefile at all. Remove it to reduce
  namespace pollution.
  
  MFC after:1 week

Modified:
  head/lib/libclang_rt/Makefile

Modified: head/lib/libclang_rt/Makefile
==
--- head/lib/libclang_rt/Makefile   Tue Nov  7 04:55:23 2017
(r325500)
+++ head/lib/libclang_rt/Makefile   Tue Nov  7 04:56:53 2017
(r325501)
@@ -1,7 +1,5 @@
 # $FreeBSD$
 
-.include 
-
 .if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64"
 SUBDIR+=   include
 SUBDIR+=   asan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325500 - head/lib/libclang_rt

[Ngie Cooper]

Author: ngie
Date: Tue Nov  7 04:55:23 2017
New Revision: 325500
URL: https://svnweb.freebsd.org/changeset/base/325500

Log:
  Use bsd.compiler.mk instead of src.opts.mk
  
  - MK_PROFILE is controlled in bsd.opts.mk, which is pulled in via bsd.own.mk,
which is pulled in via bsd.init.mk . All upstream Makefiles which build off
of this one use bsd.init.mk.
  - COMPILER_{TYPE,VERSION} is set via bsd.compiler.mk .
  
  This reduces the namespace pollution/complexity somewhat.
  
  MFC after:1 week

Modified:
  head/lib/libclang_rt/Makefile.inc

Modified: head/lib/libclang_rt/Makefile.inc
==
--- head/lib/libclang_rt/Makefile.inc   Tue Nov  7 04:26:57 2017
(r325499)
+++ head/lib/libclang_rt/Makefile.inc   Tue Nov  7 04:55:23 2017
(r325500)
@@ -1,6 +1,6 @@
 # $FreeBSD$
 
-.include 
+.include 
 
 .if ${MACHINE} == "arm"
 .if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:M*soft*} == ""
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325462 - stable/10/lib/libugidfw

[Ngie Cooper]

Author: ngie
Date: Sun Nov  5 22:36:32 2017
New Revision: 325462
URL: https://svnweb.freebsd.org/changeset/base/325462

Log:
  MFC r324928:
  
  Remove dead stores
  
  The return value of various snprintf calls was stored in `len` and not used
  in many functions.

Modified:
  stable/10/lib/libugidfw/ugidfw.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/lib/libugidfw/ugidfw.c
==
--- stable/10/lib/libugidfw/ugidfw.cSun Nov  5 22:36:02 2017
(r325461)
+++ stable/10/lib/libugidfw/ugidfw.cSun Nov  5 22:36:32 2017
(r325462)
@@ -513,7 +513,6 @@ bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max
uid_t uid1, uid2;
char *spec1, *spec2, *endp;
unsigned long value;
-   size_t len;
 
spec2 = spec;
spec1 = strsep(, ":");
@@ -524,8 +523,7 @@ bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max
else {
value = strtoul(spec1, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid uid: '%s'", spec1);
+   snprintf(errstr, buflen, "invalid uid: '%s'", spec1);
return (-1);
}
uid1 = value;
@@ -542,8 +540,7 @@ bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max
else {
value = strtoul(spec2, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid uid: '%s'", spec2);
+   snprintf(errstr, buflen, "invalid uid: '%s'", spec2);
return (-1);
}
uid2 = value;
@@ -562,7 +559,6 @@ bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max
gid_t gid1, gid2;
char *spec1, *spec2, *endp;
unsigned long value;
-   size_t len;
 
spec2 = spec;
spec1 = strsep(, ":");
@@ -573,8 +569,7 @@ bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max
else {
value = strtoul(spec1, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid gid: '%s'", spec1);
+   snprintf(errstr, buflen, "invalid gid: '%s'", spec1);
return (-1);
}
gid1 = value;
@@ -591,8 +586,7 @@ bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max
else {
value = strtoul(spec2, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid gid: '%s'", spec2);
+   snprintf(errstr, buflen, "invalid gid: '%s'", spec2);
return (-1);
}
gid2 = value;
@@ -614,7 +608,6 @@ bsde_parse_subject(int argc, char *argv[],
uid_t uid_min, uid_max;
gid_t gid_min, gid_max;
int jid;
-   size_t len;
long value;
 
current = 0;
@@ -631,11 +624,11 @@ bsde_parse_subject(int argc, char *argv[],
while (current < argc) {
if (strcmp(argv[current], "uid") == 0) {
if (current + 2 > argc) {
-   len = snprintf(errstr, buflen, "uid short");
+   snprintf(errstr, buflen, "uid short");
return (-1);
}
if (flags & MBS_UID_DEFINED) {
-   len = snprintf(errstr, buflen, "one uid only");
+   snprintf(errstr, buflen, "one uid only");
return (-1);
}
if (bsde_parse_uidrange(argv[current+1],
@@ -649,11 +642,11 @@ bsde_parse_subject(int argc, char *argv[],
current += 2;
} else if (strcmp(argv[current], "gid") == 0) {
if (current + 2 > argc) {
-   len = snprintf(errstr, buflen, "gid short");
+   snprintf(errstr, buflen, "gid short");
return (-1);
}
if (flags & MBS_GID_DEFINED) {
-   len = snprintf(errstr, buflen, "one gid only");
+   snprintf(errstr, buflen, "one gid only");
return (-1);
}
if (bsde_parse_gidrange(argv[current+1],
@@ -667,17 +660,17 @@ bsde_parse_subject(int argc, char *argv[],
current += 2;
} else if (strcmp(argv[current], "jailid") == 0) {
if (current + 2 > argc) {
-   len = snprintf(errstr, buflen, "prison short");
+ 

svn commit: r325461 - stable/11/lib/libugidfw

[Ngie Cooper]

Author: ngie
Date: Sun Nov  5 22:36:02 2017
New Revision: 325461
URL: https://svnweb.freebsd.org/changeset/base/325461

Log:
  MFC r324928,r324929:
  
  r324928:
  
  Remove dead stores
  
  The return value of various snprintf calls was stored in `len` and not used
  in many functions.
  
  r324929:
  
  Clean up trailing whitespace

Modified:
  stable/11/lib/libugidfw/Makefile
  stable/11/lib/libugidfw/ugidfw.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/lib/libugidfw/Makefile
==
--- stable/11/lib/libugidfw/MakefileSun Nov  5 22:34:27 2017
(r325460)
+++ stable/11/lib/libugidfw/MakefileSun Nov  5 22:36:02 2017
(r325461)
@@ -2,7 +2,7 @@
 
 PACKAGE=lib${LIB}
 LIB=   ugidfw
-SHLIB_MAJOR=   5   
+SHLIB_MAJOR=   5
 SRCS=  ugidfw.c
 INCS=  ugidfw.h
 

Modified: stable/11/lib/libugidfw/ugidfw.c
==
--- stable/11/lib/libugidfw/ugidfw.cSun Nov  5 22:34:27 2017
(r325460)
+++ stable/11/lib/libugidfw/ugidfw.cSun Nov  5 22:36:02 2017
(r325461)
@@ -194,7 +194,7 @@ bsde_rule_to_string(struct mac_bsdextended_rule *rule,
cur += len;
}
if (rule->mbr_subject.mbs_flags & MBS_PRISON_DEFINED) {
-   len = snprintf(cur, left, "jailid %d ", 
+   len = snprintf(cur, left, "jailid %d ",
rule->mbr_subject.mbs_prison);
if (len < 0 || len > left)
goto truncated;
@@ -334,7 +334,7 @@ bsde_rule_to_string(struct mac_bsdextended_rule *rule,
&(mntbuf[i].f_fsid),
sizeof(mntbuf[i].f_fsid)) == 0)
break;
-   len = snprintf(cur, left, "filesys %s ", 
+   len = snprintf(cur, left, "filesys %s ",
i == numfs ? "???" : mntbuf[i].f_mntonname);
if (len < 0 || len > left)
goto truncated;
@@ -512,7 +512,6 @@ bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max
uid_t uid1, uid2;
char *spec1, *spec2, *endp;
unsigned long value;
-   size_t len;
 
spec2 = spec;
spec1 = strsep(, ":");
@@ -523,8 +522,7 @@ bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max
else {
value = strtoul(spec1, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid uid: '%s'", spec1);
+   snprintf(errstr, buflen, "invalid uid: '%s'", spec1);
return (-1);
}
uid1 = value;
@@ -541,8 +539,7 @@ bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max
else {
value = strtoul(spec2, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid uid: '%s'", spec2);
+   snprintf(errstr, buflen, "invalid uid: '%s'", spec2);
return (-1);
}
uid2 = value;
@@ -561,7 +558,6 @@ bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max
gid_t gid1, gid2;
char *spec1, *spec2, *endp;
unsigned long value;
-   size_t len;
 
spec2 = spec;
spec1 = strsep(, ":");
@@ -572,8 +568,7 @@ bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max
else {
value = strtoul(spec1, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid gid: '%s'", spec1);
+   snprintf(errstr, buflen, "invalid gid: '%s'", spec1);
return (-1);
}
gid1 = value;
@@ -590,8 +585,7 @@ bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max
else {
value = strtoul(spec2, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid gid: '%s'", spec2);
+   snprintf(errstr, buflen, "invalid gid: '%s'", spec2);
return (-1);
}
gid2 = value;
@@ -613,7 +607,6 @@ bsde_parse_subject(int argc, char *argv[],
uid_t uid_min, uid_max;
gid_t gid_min, gid_max;
int jid = 0;
-   size_t len;
long value;
 
current = 0;
@@ -630,11 +623,11 @@ bsde_parse_subject(int argc, char *argv[],
while (current < argc) {
if (strcmp(argv[current], "uid") == 0) {
if (current + 2 > argc) {
-   len = snprintf(errstr, buflen, "uid 

svn commit: r325460 - stable/10/sys/kern

[Ngie Cooper]

Author: ngie
Date: Sun Nov  5 22:34:27 2017
New Revision: 325460
URL: https://svnweb.freebsd.org/changeset/base/325460

Log:
  MFC r324862:
  
  Clean up trailing whitespace in kdb_thr_ctx(..)

Modified:
  stable/10/sys/kern/subr_kdb.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/kern/subr_kdb.c
==
--- stable/10/sys/kern/subr_kdb.c   Sun Nov  5 22:33:41 2017
(r325459)
+++ stable/10/sys/kern/subr_kdb.c   Sun Nov  5 22:34:27 2017
(r325460)
@@ -515,12 +515,12 @@ kdb_reenter(void)
 
 struct pcb *
 kdb_thr_ctx(struct thread *thr)
-{  
+{
 #if defined(SMP) && defined(KDB_STOPPEDPCB)
struct pcpu *pc;
 #endif
- 
-   if (thr == curthread) 
+
+   if (thr == curthread)
return (_pcb);
 
 #if defined(SMP) && defined(KDB_STOPPEDPCB)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325459 - stable/11/sys/kern

[Ngie Cooper]

Author: ngie
Date: Sun Nov  5 22:33:41 2017
New Revision: 325459
URL: https://svnweb.freebsd.org/changeset/base/325459

Log:
  MFC r324862:
  
  Clean up trailing whitespace in kdb_thr_ctx(..)

Modified:
  stable/11/sys/kern/subr_kdb.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/kern/subr_kdb.c
==
--- stable/11/sys/kern/subr_kdb.c   Sun Nov  5 22:29:45 2017
(r325458)
+++ stable/11/sys/kern/subr_kdb.c   Sun Nov  5 22:33:41 2017
(r325459)
@@ -513,12 +513,12 @@ kdb_reenter(void)
 
 struct pcb *
 kdb_thr_ctx(struct thread *thr)
-{  
+{
 #if defined(SMP) && defined(KDB_STOPPEDPCB)
struct pcpu *pc;
 #endif
- 
-   if (thr == curthread) 
+
+   if (thr == curthread)
return (_pcb);
 
 #if defined(SMP) && defined(KDB_STOPPEDPCB)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325450 - head/bin/rm

[Ngie Cooper]

Author: ngie
Date: Sun Nov  5 21:43:26 2017
New Revision: 325450
URL: https://svnweb.freebsd.org/changeset/base/325450

Log:
  Fix cosmetic nit when printing out "override $mode" and "$owner/$group ..."
  
  The wrong index was being checked for == ' ' in the resulting stringified
  mode from strmode(3) -- it should have been the 11th value, not the 10th.
  
  MFC after:3 days
  PR:   76711
  Submitted by: Vasil Dimov 

Modified:
  head/bin/rm/rm.c

Modified: head/bin/rm/rm.c
==
--- head/bin/rm/rm.cSun Nov  5 20:38:40 2017(r325449)
+++ head/bin/rm/rm.cSun Nov  5 21:43:26 2017(r325450)
@@ -515,7 +515,7 @@ check(const char *path, const char *name, struct stat 
"%s: -P was specified, but file is not writable",
path);
(void)fprintf(stderr, "override %s%s%s/%s %s%sfor %s? ",
-   modep + 1, modep[9] == ' ' ? "" : " ",
+   modep + 1, modep[10] == ' ' ? "" : " ",
user_from_uid(sp->st_uid, 0),
group_from_gid(sp->st_gid, 0),
*flagsp ? flagsp : "", *flagsp ? " " : "",
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325449 - in head: . lib/libclang_rt

[Ngie Cooper]

Author: ngie
Date: Sun Nov  5 20:38:40 2017
New Revision: 325449
URL: https://svnweb.freebsd.org/changeset/base/325449

Log:
  Choose a simpler, more philosophically correct version for CRTARCH with 
armv[67]
  
  This is a rework of r325443.
  
  PR:   222925
  Tested with:  make buildenv with appropriate TARGET/TARGET_ARCH pairs

Modified:
  head/ObsoleteFiles.inc
  head/lib/libclang_rt/Makefile.inc

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Sun Nov  5 20:28:28 2017(r325448)
+++ head/ObsoleteFiles.inc  Sun Nov  5 20:38:40 2017(r325449)
@@ -38,6 +38,21 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
+# 20171105: fixing lib/libclang_rt CRTARCH for arm:armv[67].
+.if ${MACHINE} == "arm"
+.if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:M*soft*} == ""
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan-preinit-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan-arm.a
+OLD_LIBS+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan-arm.so
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan_cxx-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.profile-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.safestack-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.stats-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.stats_client-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.ubsan_standalone-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.ubsan_standalone_cxx-arm.a
+.endif
+.endif
 # 20171104: libcap_random should be in /lib not in /usr/lib
 OLD_LIBS+=usr/lib/libcap_random.so.0
 # 20171104: Casper can work only as shared library

Modified: head/lib/libclang_rt/Makefile.inc
==
--- head/lib/libclang_rt/Makefile.inc   Sun Nov  5 20:28:28 2017
(r325448)
+++ head/lib/libclang_rt/Makefile.inc   Sun Nov  5 20:38:40 2017
(r325449)
@@ -2,7 +2,12 @@
 
 .include 
 
-CRTARCH=   ${MACHINE_CPUARCH:C/amd64/x86_64/}
+.if ${MACHINE} == "arm"
+.if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:M*soft*} == ""
+CRTARCH=   armhf
+.endif
+.endif
+CRTARCH?=  ${MACHINE_CPUARCH:C/amd64/x86_64/}
 CRTSRC=${SRCTOP}/contrib/compiler-rt
 
 .PATH: ${CRTSRC}/lib
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325446 - in head: . lib/libclang_rt share/mk

[Ngie Cooper]

Author: ngie
Date: Sun Nov  5 20:01:00 2017
New Revision: 325446
URL: https://svnweb.freebsd.org/changeset/base/325446

Log:
  Revert r325443
  
  Despite the fact that it's a working solution, it doesn't follow the design
  philosophy of only doing TARGET_* in Makefile.inc1 and special locations in
  the source tree.
  
  PR:   222925
  Requested by: imp

Modified:
  head/ObsoleteFiles.inc
  head/lib/libclang_rt/Makefile.inc
  head/share/mk/sys.mk
Directory Properties:
  head/   (props changed)

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Sun Nov  5 19:52:11 2017(r325445)
+++ head/ObsoleteFiles.inc  Sun Nov  5 20:01:00 2017(r325446)
@@ -38,21 +38,6 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
-# 20171105: fixing lib/libclang_rt CRTARCH for arm:armv[67].
-.if ${MACHINE} == "arm"
-.if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:M*soft*} == ""
-OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan-preinit-arm.a
-OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan-arm.a
-OLD_LIBS+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan-arm.so
-OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan_cxx-arm.a
-OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.profile-arm.a
-OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.safestack-arm.a
-OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.stats-arm.a
-OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.stats_client-arm.a
-OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.ubsan_standalone-arm.a
-OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.ubsan_standalone_cxx-arm.a
-.endif
-.endif
 # 20171104: libcap_random should be in /lib not in /usr/lib
 OLD_LIBS+=usr/lib/libcap_random.so.0
 # 20171104: Casper can work only as shared library

Modified: head/lib/libclang_rt/Makefile.inc
==
--- head/lib/libclang_rt/Makefile.inc   Sun Nov  5 19:52:11 2017
(r325445)
+++ head/lib/libclang_rt/Makefile.inc   Sun Nov  5 20:01:00 2017
(r325446)
@@ -2,14 +2,7 @@
 
 .include 
 
-# NOTE: based on TARGET_ABI/TARGET_CPUTYPE, set in Makefile.inc1 .
-.if ${MACHINE} == "arm"
-.if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:M*soft*} == ""
-CRTARCH=   armhf
-.endif
-.endif
-
-CRTARCH?=  ${TARGET_CPUARCH:C/amd64/x86_64/}
+CRTARCH=   ${MACHINE_CPUARCH:C/amd64/x86_64/}
 CRTSRC=${SRCTOP}/contrib/compiler-rt
 
 .PATH: ${CRTSRC}/lib

Modified: head/share/mk/sys.mk
==
--- head/share/mk/sys.mkSun Nov  5 19:52:11 2017(r325445)
+++ head/share/mk/sys.mkSun Nov  5 20:01:00 2017(r325446)
@@ -15,11 +15,6 @@ unix ?=  We run FreeBSD, not UNIX.
 #
 
__TO_CPUARCH=C/mips(n32|64)?(el)?(hf)?/mips/:C/arm(v[67])?(eb)?/arm/:C/powerpc(64|spe)/powerpc/:C/riscv64(sf)?/riscv/
 MACHINE_CPUARCH=${MACHINE_ARCH:${__TO_CPUARCH}}
-.ifdef TARGET_ARCH
-TARGET_CPUARCH=${TARGET_ARCH:${__TO_CPUARCH}}
-.else
-TARGET_CPUARCH=${MACHINE_CPUARCH}
-.endif
 .endif
 
 __DEFAULT_YES_OPTIONS+= \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r325443 - in head: . lib/libclang_rt share/mk

[Ngie Cooper (yaneurabeya)]

> On Nov 5, 2017, at 11:38, Ngie Cooper <n...@freebsd.org> wrote:
> 
> Author: ngie
> Date: Sun Nov  5 19:38:51 2017
> New Revision: 325443
> URL: https://svnweb.freebsd.org/changeset/base/325443
> 
> Log:
>  Fix paths for cross-built versions of lib/libclang_rt and hardfloat arm 
> variants
> 
>  - Define TARGET_CPUARCH and use in libclang_rt as the basis for CRTARCH
> 
>When cross-compiling, the wrong architecture was being embedded in the
>libclang_rt binary filenames. It should be based on TARGET_ARCH (target), 
> not
>MACHINE_ARCH (host).
> 
>If TARGET_ARCH isn't defined (host-builds), fallback to MACHINE_ARCH.
> 
>  - Define CRTARCH to armhf when TARGET/TARGET_ARCH are set to arm/armv[67]
> 
>TARGET_ABI/TARGET_CPU in Makefile.inc1 sets the ABI to gnueabihf, which
>affects the clang lookup path per `getArchNameForCompilerRTLib(..)` in
>contrib/llvm/tools/clang/lib/Driver/ToolChain.cpp, so chase clang and
>Linux's assumed naming convention for hard-float arm architectures.
> 
>CROSSENV (in Makefile.inc1) sets CPUTYPE/MACHINE(_ARCH)? to the
>TARGET*-relevant values when building the `libraries` target, so test
>those variables instead.
> 
>  - Add OLD_FILES/OLD_LIBS entries for TARGET/TARGET_ARCH == arm/armv[67]. This
>impacts only arm/armv6 and arm/armv7.
> 
>  PR:  222925

MFC after:  2 weeks


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r325442 - in head/lib/libclang_rt: . profile

[Ngie Cooper (yaneurabeya)]

> On Nov 5, 2017, at 11:25, Ngie Cooper <n...@freebsd.org> wrote:
> 
> Author: ngie
> Date: Sun Nov  5 19:25:06 2017
> New Revision: 325442
> URL: https://svnweb.freebsd.org/changeset/base/325442
> 
> Log:
>  Support compiling lib/libclang_rt/profile a bit more with recent versions of 
> gcc
> 
>  Several of the flags were being treated as CFLAGS, when they were actually
>  technically CXXFLAGS. Move them there.
> 
>  Only apply -fno-sanitize=safe-stack with clang.
> 
>  PR: 223179

MFC after:  2 weeks


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r325443 - in head: . lib/libclang_rt share/mk

[Ngie Cooper]

Author: ngie
Date: Sun Nov  5 19:38:51 2017
New Revision: 325443
URL: https://svnweb.freebsd.org/changeset/base/325443

Log:
  Fix paths for cross-built versions of lib/libclang_rt and hardfloat arm 
variants
  
  - Define TARGET_CPUARCH and use in libclang_rt as the basis for CRTARCH
  
When cross-compiling, the wrong architecture was being embedded in the
libclang_rt binary filenames. It should be based on TARGET_ARCH (target), 
not
MACHINE_ARCH (host).
  
If TARGET_ARCH isn't defined (host-builds), fallback to MACHINE_ARCH.
  
  - Define CRTARCH to armhf when TARGET/TARGET_ARCH are set to arm/armv[67]
  
TARGET_ABI/TARGET_CPU in Makefile.inc1 sets the ABI to gnueabihf, which
affects the clang lookup path per `getArchNameForCompilerRTLib(..)` in
contrib/llvm/tools/clang/lib/Driver/ToolChain.cpp, so chase clang and
Linux's assumed naming convention for hard-float arm architectures.
  
CROSSENV (in Makefile.inc1) sets CPUTYPE/MACHINE(_ARCH)? to the
TARGET*-relevant values when building the `libraries` target, so test
those variables instead.
  
  - Add OLD_FILES/OLD_LIBS entries for TARGET/TARGET_ARCH == arm/armv[67]. This
impacts only arm/armv6 and arm/armv7.
  
  PR:   222925

Modified:
  head/ObsoleteFiles.inc
  head/lib/libclang_rt/Makefile.inc
  head/share/mk/sys.mk
Directory Properties:
  head/   (props changed)

Modified: head/ObsoleteFiles.inc
==
--- head/ObsoleteFiles.inc  Sun Nov  5 19:25:06 2017(r325442)
+++ head/ObsoleteFiles.inc  Sun Nov  5 19:38:51 2017(r325443)
@@ -38,6 +38,21 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
+# 20171105: fixing lib/libclang_rt CRTARCH for arm:armv[67].
+.if ${MACHINE} == "arm"
+.if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:M*soft*} == ""
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan-preinit-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan-arm.a
+OLD_LIBS+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan-arm.so
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.asan_cxx-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.profile-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.safestack-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.stats-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.stats_client-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.ubsan_standalone-arm.a
+OLD_FILES+=usr/lib/clang/5.0.0/lib/freebsd/libclang_rt.ubsan_standalone_cxx-arm.a
+.endif
+.endif
 # 20171104: libcap_random should be in /lib not in /usr/lib
 OLD_LIBS+=usr/lib/libcap_random.so.0
 # 20171104: Casper can work only as shared library

Modified: head/lib/libclang_rt/Makefile.inc
==
--- head/lib/libclang_rt/Makefile.inc   Sun Nov  5 19:25:06 2017
(r325442)
+++ head/lib/libclang_rt/Makefile.inc   Sun Nov  5 19:38:51 2017
(r325443)
@@ -2,7 +2,14 @@
 
 .include 
 
-CRTARCH=   ${MACHINE_CPUARCH:C/amd64/x86_64/}
+# NOTE: based on TARGET_ABI/TARGET_CPUTYPE, set in Makefile.inc1 .
+.if ${MACHINE} == "arm"
+.if ${MACHINE_ARCH:Marmv[67]*} != "" && ${CPUTYPE:M*soft*} == ""
+CRTARCH=   armhf
+.endif
+.endif
+
+CRTARCH?=  ${TARGET_CPUARCH:C/amd64/x86_64/}
 CRTSRC=${SRCTOP}/contrib/compiler-rt
 
 .PATH: ${CRTSRC}/lib

Modified: head/share/mk/sys.mk
==
--- head/share/mk/sys.mkSun Nov  5 19:25:06 2017(r325442)
+++ head/share/mk/sys.mkSun Nov  5 19:38:51 2017(r325443)
@@ -15,6 +15,11 @@ unix ?=  We run FreeBSD, not UNIX.
 #
 
__TO_CPUARCH=C/mips(n32|64)?(el)?(hf)?/mips/:C/arm(v[67])?(eb)?/arm/:C/powerpc(64|spe)/powerpc/:C/riscv64(sf)?/riscv/
 MACHINE_CPUARCH=${MACHINE_ARCH:${__TO_CPUARCH}}
+.ifdef TARGET_ARCH
+TARGET_CPUARCH=${TARGET_ARCH:${__TO_CPUARCH}}
+.else
+TARGET_CPUARCH=${MACHINE_CPUARCH}
+.endif
 .endif
 
 __DEFAULT_YES_OPTIONS+= \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325442 - in head/lib/libclang_rt: . profile

[Ngie Cooper]

Author: ngie
Date: Sun Nov  5 19:25:06 2017
New Revision: 325442
URL: https://svnweb.freebsd.org/changeset/base/325442

Log:
  Support compiling lib/libclang_rt/profile a bit more with recent versions of 
gcc
  
  Several of the flags were being treated as CFLAGS, when they were actually
  technically CXXFLAGS. Move them there.
  
  Only apply -fno-sanitize=safe-stack with clang.
  
  PR: 223179

Modified:
  head/lib/libclang_rt/Makefile.inc
  head/lib/libclang_rt/profile/Makefile

Modified: head/lib/libclang_rt/Makefile.inc
==
--- head/lib/libclang_rt/Makefile.inc   Sun Nov  5 18:45:43 2017
(r325441)
+++ head/lib/libclang_rt/Makefile.inc   Sun Nov  5 19:25:06 2017
(r325442)
@@ -20,13 +20,13 @@ CFLAGS+=-DNDEBUG
 CFLAGS+=   ${PICFLAG}
 CFLAGS+=   -fno-builtin
 CFLAGS+=   -fno-exceptions
-CFLAGS+=   -fno-rtti
-.if ${COMPILER_VERSION} >= 30700
+CXXFLAGS+= -fno-rtti
+.if ${COMPILER_TYPE} == clang && ${COMPILER_VERSION} >= 30700
 CFLAGS+=   -fno-sanitize=safe-stack
 .endif
 CFLAGS+=   -fno-stack-protector
 CFLAGS+=   -funwind-tables
-CFLAGS+=   -fvisibility-inlines-hidden
-CFLAGS+=   -fvisibility=hidden
+CXXFLAGS+= -fvisibility-inlines-hidden
+CXXFLAGS+= -fvisibility=hidden
 CFLAGS+=   -I${CRTSRC}/lib
 CXXFLAGS+= -std=c++11

Modified: head/lib/libclang_rt/profile/Makefile
==
--- head/lib/libclang_rt/profile/Makefile   Sun Nov  5 18:45:43 2017
(r325441)
+++ head/lib/libclang_rt/profile/Makefile   Sun Nov  5 19:25:06 2017
(r325442)
@@ -5,7 +5,7 @@
 LIB=   clang_rt.profile-${CRTARCH}
 
 # This is needed for --coverage
-CFLAGS+=   -fvisibility=default
+CXXFLAGS+= -fvisibility=default
 
 SRCS+= profile/GCDAProfiling.c
 SRCS+= profile/InstrProfiling.c
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r325116 - head

[Ngie Cooper (yaneurabeya)]

> On Nov 4, 2017, at 08:31, Bryan Drewery <bdrew...@freebsd.org> wrote:
> 
> On 11/4/2017 12:08 AM, Ngie Cooper (yaneurabeya) wrote:
>>  I just ran into this with bash on universe12a.freebsd.org by doing ^d. 
>> I think the change should be reverted.
>> Thanks,
>> -Ngie
>> 
>> $ exit
>> *** Error code 130
>> 
>> Stop.
>> make[1]: stopped in /scratch/tmp/ngie/svn
>> *** Error code 1
>> 
>> Stop.
>> make: stopped in /scratch/tmp/ngie/svn
>> 
> 
> When you first go into buildenv check 'echo $?'.
> My problem was a construct like '[ -f xxx ] && . xxx' at the end of one
> of my profile scripts.  It needs to be 'if [ -f xxx ]; then . xxx; fi'
> to avoid the bad status.  It's really unrelated to buildenv.

The last line in my ~/.bashrc on my VM is export PATH that doesn’t fail with a 
syntax error, and the last line on my ~/.bashrc on universe12a is an alias set, 
which also doesn’t fail with a syntax error. Both cases set $? = 0.

The issue I reported is caused by doing ^c + ^d (hence the error code 130 in my 
original reply). I guess this is expected, but it’s going to confuse people and 
force them to have to investigate the issue, unnecessarily, when it wasn’t an 
“issue” before.

-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r325116 - head

[Ngie Cooper (yaneurabeya)]

I just ran into this with bash on universe12a.freebsd.org by doing ^d. 
I think the change should be reverted.
Thanks,
-Ngie

$ exit
*** Error code 130

Stop.
make[1]: stopped in /scratch/tmp/ngie/svn
*** Error code 1

Stop.
make: stopped in /scratch/tmp/ngie/svn



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

[Ngie Cooper]

> On Nov 2, 2017, at 06:49, Andriy Gapon  wrote:
> 
> Author: avg
> Date: Thu Nov  2 13:49:08 2017
> New Revision: 325320
> URL: https://svnweb.freebsd.org/changeset/base/325320
> 
> Log:
>  Disable posix_fallocate(2) for ZFS
> 
>  The generic (naive) implementation of posix_fallocate cannot provide the
>  standard mandated guarantee that overwrites would never fail due to the lack
>  of free space.  The fundamental reason is the copy-on-write architecture
>  of ZFS.  Other features like compression and deduplication can also
>  increase the size difference between the (pre-)allocated dummy content
>  and the future content.
> 
>  So, until ZFS can properly implement the feature it's better to report
>  that it is unsupported rather than providing an ersatz implementation.
>  Please note that EINVAL is used to report that the underlying file system
>  does not support the operation (POSIX.1-2008).
> 
>  illumos and ZoL seem to do the same.
> 
>  MFC after:3 weeks
>  Sponsored by:Panzura

It’d be nice if it worked though and was reported via the file system.  Posix 
suggests it should be, as of 2013: http://austingroupbugs.net/view.php?id=687 .

Need to go poking around and see what’s in freebsd later on tonight. Bug filed: 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223383 .

> Modified:
>  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
> 
> Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
> ==
> --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.cThu 
> Nov  2 12:16:50 2017(r325319)
> +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.cThu 
> Nov  2 13:49:08 2017(r325320)
> @@ -6009,6 +6009,7 @@ struct vop_vector zfs_vnodeops = {
>.vop_inactive =zfs_freebsd_inactive,
>.vop_reclaim =zfs_freebsd_reclaim,
>.vop_access =zfs_freebsd_access,
> +.vop_allocate =VOP_EINVAL,
>.vop_lookup =zfs_cache_lookup,
>.vop_cachedlookup =zfs_freebsd_lookup,
>.vop_getattr =zfs_freebsd_getattr,
> 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r325192 - head/etc/mtree

[Ngie Cooper]

> On Oct 30, 2017, at 18:43, Bryan Drewery  wrote:
> 
> Author: bdrewery
> Date: Tue Oct 31 01:43:36 2017
> New Revision: 325192
> URL: https://svnweb.freebsd.org/changeset/base/325192
> 
> Log:
>  Fix installworld/distrib-dirs for pathconv after r325186.

*sigh*

Julian never completed the tests. They’re breaking Jenkins since they’re now 
integrated into the build..

Please test test commits next time (make obj depend all; sudo make check 
install).

I’ll go fix them ;/..

>  Sponsored by:Dell EMC Isilon
> 
> Modified:
>  head/etc/mtree/BSD.tests.dist
> 
> Modified: head/etc/mtree/BSD.tests.dist
> ==
> --- head/etc/mtree/BSD.tests.distTue Oct 31 00:26:42 2017(r325191)
> +++ head/etc/mtree/BSD.tests.distTue Oct 31 01:43:36 2017(r325192)
> @@ -358,6 +358,8 @@
> dlopen
> ..
> ..
> +libpathconv
> +..
> libutil
> ..
> libxo
> 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325208 - head/lib/libcasper/services/cap_grp

[Ngie Cooper]

Author: ngie
Date: Tue Oct 31 04:02:50 2017
New Revision: 325208
URL: https://svnweb.freebsd.org/changeset/base/325208

Log:
  Add `static` to `cap_setgrent` prototype in !WITH_CASPER case
  
  This unbreaks the default powerpc/sparc64 build configuration after r325062.

Modified:
  head/lib/libcasper/services/cap_grp/cap_grp.h

Modified: head/lib/libcasper/services/cap_grp/cap_grp.h
==
--- head/lib/libcasper/services/cap_grp/cap_grp.h   Tue Oct 31 03:47:22 
2017(r325207)
+++ head/lib/libcasper/services/cap_grp/cap_grp.h   Tue Oct 31 04:02:50 
2017(r325208)
@@ -65,7 +65,7 @@ int cap_grp_limit_groups(cap_channel_t *chan, const ch
 
 #definecap_setgroupent(chan, stayopen) etgroupent(stayopen)
 #define endgrent(chan) endgrent()
-inline int
+static inline int
 cap_setgrent(cap_channel_t *chan __unused)
 {
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_

[Ngie Cooper (yaneurabeya)]

> On Oct 28, 2017, at 12:23, Mariusz Zaborski  wrote:
> 
> Author: oshogbo
> Date: Sat Oct 28 19:23:57 2017
> New Revision: 325062
> URL: https://svnweb.freebsd.org/changeset/base/325062
> 
> Log:
>  Introduce caspermocks.
> 
>  The idea behinds mocks is that we don't need to ifdef a lot of code in
>  tools itself but those defines are hidden in the casper library.
>  Right now the mocks are implemented as define/inlines functions.
>  There was a very long discussion how this should be implemented.
>  This approach has some advantages like we don't need to link to any 
> additional
>  libraries. Unfortunately there are also some disadvantages for example it is
>  easy to get library out of sync between two versions of functions or that we
>  need extra define to compile program with casper support.
>  This isn't an ideal solution but it's good enough for now and should simplify
>  capsicumizing programs. This also doesn't close us any other ways to do those
>  mocks and this should evolve in time.
> 
>  Discussed with:  pjd, emaste, ed, rwatson, bapt, cem, bdrewery
>  Differential Revision:https://reviews.freebsd.org/D8753

This change broke tinderbox/Jenkins for powerpc and sparc64: 
https://ci.freebsd.org/job/FreeBSD-head-powerpc-build/1865/console .
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r322951 - head

[Ngie Cooper (yaneurabeya)]

> On Oct 25, 2017, at 13:34, Bryan Drewery  wrote:

…

> I don't understand what you're saying here. If I build with MK_TCSH=yes
> and the host does not have tcsh, a failure occurs AFTER or BEFORE this
> change?
> Neither case makes sense to me.
> What is the failure?
> 
> The change here is to build-tools which just calls 'make build-tools' in
> bin/csh which just builds 'gethost'.

Yes. The relnotes concerns I mentioned are bogus.

Yeah, a ~400 line C file isn’t that bad, I agree.

I really don’t care about arguing this or debating it. Yes, you’re right on all 
counts. It’s a micro optimization.


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r325125 - head/sys/conf

[Ngie Cooper]

Author: ngie
Date: Mon Oct 30 06:51:03 2017
New Revision: 325125
URL: https://svnweb.freebsd.org/changeset/base/325125

Log:
  Remove unnecessary C in .fwo file I accidentally made consistent
  
  MFC after:1 month
  MFC with: r325122, r325124

Modified:
  head/sys/conf/files

Modified: head/sys/conf/files
==
--- head/sys/conf/files Mon Oct 30 06:48:38 2017(r325124)
+++ head/sys/conf/files Mon Oct 30 06:51:03 2017(r325125)
@@ -2019,11 +2019,11 @@ iwm8265fw.c optional iwm8265fw | 
iwmfw  \
compile-with"${AWK} -f $S/tools/fw_stub.awk iwm8265.fw:iwm8265fw 
-miwm8265fw -c${.TARGET}" \
no-implicit-rule before-depend local\
clean   "iwm8265fw.c"
-iwm8265Cfw.fwo optional iwm8265fw | iwmfw  \
+iwm8265fw.fwo  optional iwm8265fw | iwmfw  \
dependency  "iwm8265.fw"\
compile-with"${NORMAL_FWO}" \
no-implicit-rule\
-   clean   "iwm8265Cfw.fwo"
+   clean   "iwm8265fw.fwo"
 dev/iwn/if_iwn.c   optional iwn
 iwn1000fw.coptional iwn1000fw | iwnfw  \
compile-with"${AWK} -f $S/tools/fw_stub.awk iwn1000.fw:iwn1000fw 
-miwn1000fw -c${.TARGET}" \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325124 - head/sys/conf

[Ngie Cooper]

Author: ngie
Date: Mon Oct 30 06:48:38 2017
New Revision: 325124
URL: https://svnweb.freebsd.org/changeset/base/325124

Log:
  Fix a bad copy-paste (8000C -> 8265) done in r325122
  
  This fixes the clean rule for "device iwm8265fw".
  
  MFC after:1 month
  MFC with: r325122

Modified:
  head/sys/conf/files

Modified: head/sys/conf/files
==
--- head/sys/conf/files Mon Oct 30 06:43:40 2017(r325123)
+++ head/sys/conf/files Mon Oct 30 06:48:38 2017(r325124)
@@ -2023,7 +2023,7 @@ iwm8265Cfw.fwooptional iwm8265fw | 
iwmfw  \
dependency  "iwm8265.fw"\
compile-with"${NORMAL_FWO}" \
no-implicit-rule\
-   clean   "iwm8000Cfw.fwo"
+   clean   "iwm8265Cfw.fwo"
 dev/iwn/if_iwn.c   optional iwn
 iwn1000fw.coptional iwn1000fw | iwnfw  \
compile-with"${AWK} -f $S/tools/fw_stub.awk iwn1000.fw:iwn1000fw 
-miwn1000fw -c${.TARGET}" \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325123 - head/share/man/man4

[Ngie Cooper]

Author: ngie
Date: Mon Oct 30 06:43:40 2017
New Revision: 325123
URL: https://svnweb.freebsd.org/changeset/base/325123

Log:
  Reference iwm8265fw support in iwm(4) as well
  
  This documentation update is similar to what was done in iwmfw(4) in r325121.
  
  MFC after:1 month
  MFC with: r325121

Modified:
  head/share/man/man4/iwm.4

Modified: head/share/man/man4/iwm.4
==
--- head/share/man/man4/iwm.4   Mon Oct 30 06:35:09 2017(r325122)
+++ head/share/man/man4/iwm.4   Mon Oct 30 06:43:40 2017(r325123)
@@ -25,7 +25,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd July 26, 2016
+.Dd October 29, 2017
 .Dt IWM 4
 .Os
 .Sh NAME
@@ -49,6 +49,7 @@ Choose one from:
 .Cd "device iwm7260fw"
 .Cd "device iwm7265fw"
 .Cd "device iwm8000Cfw"
+.Cd "device iwm8265fw"
 .Ed
 .Pp
 Or you can use
@@ -67,6 +68,7 @@ iwm3160fw_load="YES"
 iwm7260fw_load="YES"
 iwm7265fw_load="YES"
 iwm8000Cfw_load="YES"
+iwm8265fw_load="YES"
 .Ed
 .Sh DESCRIPTION
 The
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325122 - head/sys/conf

[Ngie Cooper]

Author: ngie
Date: Mon Oct 30 06:35:09 2017
New Revision: 325122
URL: https://svnweb.freebsd.org/changeset/base/325122

Log:
  Fill in the blanks for iwm8265fw(4) rules, missed in r324434
  
  Now using "device iwmfw" or "device iwm8265fw" in one's kernel configuration
  will potentially result in a working IWM8265 series wireless SoC.
  
  This is an alternative to the fix that was made in r324470 for
  `sys/modules/iwmfw`.
  
  MFC after:1 month

Modified:
  head/sys/conf/files

Modified: head/sys/conf/files
==
--- head/sys/conf/files Mon Oct 30 06:06:37 2017(r325121)
+++ head/sys/conf/files Mon Oct 30 06:35:09 2017(r325122)
@@ -2010,6 +2010,20 @@ iwm8000C.fw  optional iwm8000Cfw | 
iwmfw \
compile-with"${NORMAL_FW}"  \
no-obj no-implicit-rule \
clean   "iwm8000C.fw"
+iwm8265.fw optional iwm8265fw | iwmfw  \
+   dependency  "$S/contrib/dev/iwm/iwm-8265-22.fw.uu" \
+   compile-with"${NORMAL_FW}"  \
+   no-obj no-implicit-rule \
+   clean   "iwm8265.fw"
+iwm8265fw.coptional iwm8265fw | iwmfw  \
+   compile-with"${AWK} -f $S/tools/fw_stub.awk iwm8265.fw:iwm8265fw 
-miwm8265fw -c${.TARGET}" \
+   no-implicit-rule before-depend local\
+   clean   "iwm8265fw.c"
+iwm8265Cfw.fwo optional iwm8265fw | iwmfw  \
+   dependency  "iwm8265.fw"\
+   compile-with"${NORMAL_FWO}" \
+   no-implicit-rule\
+   clean   "iwm8000Cfw.fwo"
 dev/iwn/if_iwn.c   optional iwn
 iwn1000fw.coptional iwn1000fw | iwnfw  \
compile-with"${AWK} -f $S/tools/fw_stub.awk iwn1000.fw:iwn1000fw 
-miwn1000fw -c${.TARGET}" \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r325121 - head/share/man/man4

[Ngie Cooper]

Author: ngie
Date: Mon Oct 30 06:06:37 2017
New Revision: 325121
URL: https://svnweb.freebsd.org/changeset/base/325121

Log:
  iwmfw(4): update support info
  
  - Document iwm8265fw firmware knobs.
  - Note that 8000 series cards are also covered by the iwmfw(4) firmware module
set.

Modified:
  head/share/man/man4/iwmfw.4

Modified: head/share/man/man4/iwmfw.4
==
--- head/share/man/man4/iwmfw.4 Mon Oct 30 05:52:26 2017(r325120)
+++ head/share/man/man4/iwmfw.4 Mon Oct 30 06:06:37 2017(r325121)
@@ -22,7 +22,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd July 26, 2016
+.Dd October 29, 2017
 .Dt IWMFW 4
 .Os
 .Sh NAME
@@ -46,6 +46,7 @@ of the following:
 .Cd "device iwm7260fw"
 .Cd "device iwm7265fw"
 .Cd "device iwm8000Cfw"
+.Cd "device iwm8265fw"
 .Ed
 .Pp
 Alternatively, to load the driver as a
@@ -57,10 +58,11 @@ iwm7260fw_load="YES"
 iwm7265fw_load="YES"
 iwm7265Dfw_load="YES"
 iwm8000Cfw_load="YES"
+iwm8265fw_load="YES"
 .Ed
 .Sh DESCRIPTION
 This module provides access to firmware sets for the
-Intel Dual Band Wireless WiFi 3160, 3165, 7260, 7265 and 8260 series of
+Intel Dual Band Wireless WiFi 3160, 3165, 7260, 7265, 8000, and 8260 series of
 IEEE 802.11n/11ac adapters.
 It may be
 statically linked into the kernel, or loaded as a module.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r325016 - head/lib/libdevdctl

[Ngie Cooper]

> On Oct 26, 2017, at 10:56, Alan Somers  wrote:
> 
> Author: asomers
> Date: Thu Oct 26 17:56:34 2017
> New Revision: 325016
> URL: https://svnweb.freebsd.org/changeset/base/325016
> 
> Log:
>  Partially revert r325011: restore Guid's default constructor
> 
>  Reported by:ohartmann
>  MFC after:3 weeks
>  X-MFC-With:325011
>  Sponsored by:Spectra Logic Corp
> 
> Modified:
>  head/lib/libdevdctl/guid.h

Or you could satisfy both signatures via optional parameters ;)..
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324929 - head/lib/libugidfw

[Ngie Cooper]

Author: ngie
Date: Mon Oct 23 16:55:22 2017
New Revision: 324929
URL: https://svnweb.freebsd.org/changeset/base/324929

Log:
  Clean up trailing whitespace
  
  MFC after:1 week

Modified:
  head/lib/libugidfw/Makefile
  head/lib/libugidfw/ugidfw.c

Modified: head/lib/libugidfw/Makefile
==
--- head/lib/libugidfw/Makefile Mon Oct 23 16:54:30 2017(r324928)
+++ head/lib/libugidfw/Makefile Mon Oct 23 16:55:22 2017(r324929)
@@ -2,7 +2,7 @@
 
 PACKAGE=lib${LIB}
 LIB=   ugidfw
-SHLIB_MAJOR=   5   
+SHLIB_MAJOR=   5
 SRCS=  ugidfw.c
 INCS=  ugidfw.h
 

Modified: head/lib/libugidfw/ugidfw.c
==
--- head/lib/libugidfw/ugidfw.c Mon Oct 23 16:54:30 2017(r324928)
+++ head/lib/libugidfw/ugidfw.c Mon Oct 23 16:55:22 2017(r324929)
@@ -194,7 +194,7 @@ bsde_rule_to_string(struct mac_bsdextended_rule *rule,
cur += len;
}
if (rule->mbr_subject.mbs_flags & MBS_PRISON_DEFINED) {
-   len = snprintf(cur, left, "jailid %d ", 
+   len = snprintf(cur, left, "jailid %d ",
rule->mbr_subject.mbs_prison);
if (len < 0 || len > left)
goto truncated;
@@ -334,7 +334,7 @@ bsde_rule_to_string(struct mac_bsdextended_rule *rule,
&(mntbuf[i].f_fsid),
sizeof(mntbuf[i].f_fsid)) == 0)
break;
-   len = snprintf(cur, left, "filesys %s ", 
+   len = snprintf(cur, left, "filesys %s ",
i == numfs ? "???" : mntbuf[i].f_mntonname);
if (len < 0 || len > left)
goto truncated;
@@ -972,7 +972,7 @@ bsde_parse_mode(int argc, char *argv[], mode_t *mode, 
snprintf(errstr, buflen, "Unknown mode letter: %c",
argv[0][i]);
return (-1);
-   } 
+   }
}
 
return (0);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324928 - head/lib/libugidfw

[Ngie Cooper]

Author: ngie
Date: Mon Oct 23 16:54:30 2017
New Revision: 324928
URL: https://svnweb.freebsd.org/changeset/base/324928

Log:
  Remove dead stores
  
  The return value of various snprintf calls was stored in `len` and not used
  in many functions.
  
  MFC after:1 week
  Reported by:  clang-scanbuild

Modified:
  head/lib/libugidfw/ugidfw.c

Modified: head/lib/libugidfw/ugidfw.c
==
--- head/lib/libugidfw/ugidfw.c Mon Oct 23 16:50:33 2017(r324927)
+++ head/lib/libugidfw/ugidfw.c Mon Oct 23 16:54:30 2017(r324928)
@@ -512,7 +512,6 @@ bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max
uid_t uid1, uid2;
char *spec1, *spec2, *endp;
unsigned long value;
-   size_t len;
 
spec2 = spec;
spec1 = strsep(, ":");
@@ -523,8 +522,7 @@ bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max
else {
value = strtoul(spec1, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid uid: '%s'", spec1);
+   snprintf(errstr, buflen, "invalid uid: '%s'", spec1);
return (-1);
}
uid1 = value;
@@ -541,8 +539,7 @@ bsde_parse_uidrange(char *spec, uid_t *min, uid_t *max
else {
value = strtoul(spec2, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid uid: '%s'", spec2);
+   snprintf(errstr, buflen, "invalid uid: '%s'", spec2);
return (-1);
}
uid2 = value;
@@ -561,7 +558,6 @@ bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max
gid_t gid1, gid2;
char *spec1, *spec2, *endp;
unsigned long value;
-   size_t len;
 
spec2 = spec;
spec1 = strsep(, ":");
@@ -572,8 +568,7 @@ bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max
else {
value = strtoul(spec1, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid gid: '%s'", spec1);
+   snprintf(errstr, buflen, "invalid gid: '%s'", spec1);
return (-1);
}
gid1 = value;
@@ -590,8 +585,7 @@ bsde_parse_gidrange(char *spec, gid_t *min, gid_t *max
else {
value = strtoul(spec2, , 10);
if (*endp != '\0') {
-   len = snprintf(errstr, buflen,
-   "invalid gid: '%s'", spec2);
+   snprintf(errstr, buflen, "invalid gid: '%s'", spec2);
return (-1);
}
gid2 = value;
@@ -613,7 +607,6 @@ bsde_parse_subject(int argc, char *argv[],
uid_t uid_min, uid_max;
gid_t gid_min, gid_max;
int jid = 0;
-   size_t len;
long value;
 
current = 0;
@@ -630,11 +623,11 @@ bsde_parse_subject(int argc, char *argv[],
while (current < argc) {
if (strcmp(argv[current], "uid") == 0) {
if (current + 2 > argc) {
-   len = snprintf(errstr, buflen, "uid short");
+   snprintf(errstr, buflen, "uid short");
return (-1);
}
if (flags & MBS_UID_DEFINED) {
-   len = snprintf(errstr, buflen, "one uid only");
+   snprintf(errstr, buflen, "one uid only");
return (-1);
}
if (bsde_parse_uidrange(argv[current+1],
@@ -648,11 +641,11 @@ bsde_parse_subject(int argc, char *argv[],
current += 2;
} else if (strcmp(argv[current], "gid") == 0) {
if (current + 2 > argc) {
-   len = snprintf(errstr, buflen, "gid short");
+   snprintf(errstr, buflen, "gid short");
return (-1);
}
if (flags & MBS_GID_DEFINED) {
-   len = snprintf(errstr, buflen, "one gid only");
+   snprintf(errstr, buflen, "one gid only");
return (-1);
}
if (bsde_parse_gidrange(argv[current+1],
@@ -666,17 +659,17 @@ bsde_parse_subject(int argc, char *argv[],
current += 2;
} else if (strcmp(argv[current], "jailid") == 0) {
if (current + 2 > argc) {
-   len = snprintf(errstr, buflen, "prison short");
+   snprintf(errstr, 

Re: svn commit: r324911 - head/share/mk

[Ngie Cooper]

> On Oct 23, 2017, at 01:48, Konstantin Belousov <kostik...@gmail.com> wrote:
> 
>> On Mon, Oct 23, 2017 at 07:56:56AM +, Ngie Cooper wrote:
>> Author: ngie
>> Date: Mon Oct 23 07:56:56 2017
>> New Revision: 324911
>> URL: https://svnweb.freebsd.org/changeset/base/324911
>> 
>> Log:
>>  Fix an omission in a comment
>> 
>>  Soft float API support applies to armv7 too after r324340
> Does it ?  From my understanding, requiring hw float was one of the
> reason for armv7 appearance.

Hah... the comment’s backwards. Classic!

>> 
>> Modified:
>>  head/share/mk/src.opts.mk
>> 
>> Modified: head/share/mk/src.opts.mk
>> ==
>> --- head/share/mk/src.opts.mkMon Oct 23 07:52:16 2017(r324910)
>> +++ head/share/mk/src.opts.mkMon Oct 23 07:56:56 2017(r324911)
>> @@ -271,7 +271,7 @@ __DEFAULT_NO_OPTIONS+=GDB_LIBEXEC
>> .else
>> __DEFAULT_YES_OPTIONS+=GDB_LIBEXEC
>> .endif
>> -# Only doing soft float API stuff on armv6
>> +# Only doing soft float API stuff on armv6 and armv7
>> .if ${__T} != "armv6" && ${__T} != "armv7"
>> BROKEN_OPTIONS+=LIBSOFT
>> .endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324911 - head/share/mk

[Ngie Cooper]

Author: ngie
Date: Mon Oct 23 07:56:56 2017
New Revision: 324911
URL: https://svnweb.freebsd.org/changeset/base/324911

Log:
  Fix an omission in a comment
  
  Soft float API support applies to armv7 too after r324340

Modified:
  head/share/mk/src.opts.mk

Modified: head/share/mk/src.opts.mk
==
--- head/share/mk/src.opts.mk   Mon Oct 23 07:52:16 2017(r324910)
+++ head/share/mk/src.opts.mk   Mon Oct 23 07:56:56 2017(r324911)
@@ -271,7 +271,7 @@ __DEFAULT_NO_OPTIONS+=GDB_LIBEXEC
 .else
 __DEFAULT_YES_OPTIONS+=GDB_LIBEXEC
 .endif
-# Only doing soft float API stuff on armv6
+# Only doing soft float API stuff on armv6 and armv7
 .if ${__T} != "armv6" && ${__T} != "armv7"
 BROKEN_OPTIONS+=LIBSOFT
 .endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r324890 - head/sys/kern

[Ngie Cooper (yaneurabeya)]

> On Oct 22, 2017, at 18:00, Mateusz Guzik  wrote:
> 
> Author: mjg
> Date: Mon Oct 23 01:00:35 2017
> New Revision: 324890
> URL: https://svnweb.freebsd.org/changeset/base/324890
> 
> Log:
>  Bump WITNESS_PENDLIST to accomodate sleepq chain bump.
> 
>  Reported by: ngie

*crosses fingers and waits for next Jenkins run*


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r324870 - in head/sys: amd64/include kern

[Ngie Cooper (yaneurabeya)]

> On Oct 22, 2017, at 13:43, Mateusz Guzik  wrote:
> 
> Author: mjg
> Date: Sun Oct 22 20:43:50 2017
> New Revision: 324870
> URL: https://svnweb.freebsd.org/changeset/base/324870
> 
> Log:
>  Make the sleepq chain hash size configurable per-arch and bump on amd64.
> 
>  While here cache-align chains.
> 
>  This shortens longest found chain during poudriere -j 80 from 32 to 16.
> 
>  Pushing this higher up will probably require allocation on boot.

Hi Mateusz,
This change causes the Jenkins VMs to panic at boot with "panic: 
witness_init: pending locks list is too small, increase WITNESS_PENDLIST” when 
WITNESS is enabled: 
https://ci.freebsd.org/job/FreeBSD-head-amd64-test/4781/console .
Please fix or revert.
Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r324863 - in head/sys: kern sys

[Ngie Cooper (yaneurabeya)]

> On Oct 22, 2017, at 06:42, Mateusz Guzik  wrote:
> 
> Author: mjg
> Date: Sun Oct 22 13:42:56 2017
> New Revision: 324863
> URL: https://svnweb.freebsd.org/changeset/base/324863
> 
> Log:
>  Change kdb_active type to u_char.
> 
>  Fixes warnings from gcc and keeps the small size. Perhaps nesting should be 
> moved
>  to another variablle.
> 
>  Reported by: ngie

Thank you for fixing this.

Question though — since u_char is unsigned, are you concerned about underflow 
(-1 -> 255)?

Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r324872 - stable/10/usr.bin/bsdcat/tests

[Ngie Cooper]

Author: ngie
Date: Sun Oct 22 21:11:59 2017
New Revision: 324872
URL: https://svnweb.freebsd.org/changeset/base/324872

Log:
  Install missing test input file missed in r324418
  
  While here, remove an unnecessary PACKAGE variable definition (only applies to
  ^/stable/11+).
  
  This is a direct commit to ^/stable/10

Modified:
  stable/10/usr.bin/bsdcat/tests/Makefile

Modified: stable/10/usr.bin/bsdcat/tests/Makefile
==
--- stable/10/usr.bin/bsdcat/tests/Makefile Sun Oct 22 21:00:59 2017
(r324871)
+++ stable/10/usr.bin/bsdcat/tests/Makefile Sun Oct 22 21:11:59 2017
(r324872)
@@ -1,7 +1,5 @@
 # $FreeBSD$
 
-PACKAGE=   tests
-
 _LIBARCHIVEDIR=${SRCTOP}/contrib/libarchive
 
 ATF_TESTS_SH+= functional_test
@@ -61,6 +59,7 @@ CLEANFILES+=  list.h list.h.tmp
 FILES+=test_empty.gz.uu
 FILES+=test_empty.lz4.uu
 FILES+=test_empty.xz.uu
+FILES+=test_empty.zst.uu
 FILES+=test_expand.Z.uu
 FILES+=test_expand.bz2.uu
 FILES+=test_expand.gz.uu
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324862 - head/sys/kern

[Ngie Cooper]

Author: ngie
Date: Sun Oct 22 12:12:52 2017
New Revision: 324862
URL: https://svnweb.freebsd.org/changeset/base/324862

Log:
  Clean up trailing whitespace in kdb_thr_ctx(..)
  
  MFC after:1 week

Modified:
  head/sys/kern/subr_kdb.c

Modified: head/sys/kern/subr_kdb.c
==
--- head/sys/kern/subr_kdb.cSun Oct 22 11:45:51 2017(r324861)
+++ head/sys/kern/subr_kdb.cSun Oct 22 12:12:52 2017(r324862)
@@ -513,12 +513,12 @@ kdb_reenter(void)
 
 struct pcb *
 kdb_thr_ctx(struct thread *thr)
-{  
+{
 #if defined(SMP) && defined(KDB_STOPPEDPCB)
struct pcpu *pc;
 #endif
- 
-   if (thr == curthread) 
+
+   if (thr == curthread)
return (_pcb);
 
 #if defined(SMP) && defined(KDB_STOPPEDPCB)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r324789 - in head/sys: kern sys

[Ngie Cooper (yaneurabeya)]

> On Oct 19, 2017, at 21:02, Mateusz Guzik  wrote:
> 
> Author: mjg
> Date: Fri Oct 20 04:02:53 2017
> New Revision: 324789
> URL: https://svnweb.freebsd.org/changeset/base/324789
> 
> Log:
>  Mark kdb_active as __read_frequently and switch to bool to eat less space.
> 
> Modified:
>  head/sys/kern/subr_kdb.c
>  head/sys/sys/kdb.h
> 
> Modified: head/sys/kern/subr_kdb.c
> ==
> --- head/sys/kern/subr_kdb.c  Fri Oct 20 03:38:58 2017(r324788)
> +++ head/sys/kern/subr_kdb.c  Fri Oct 20 04:02:53 2017(r324789)
> @@ -50,7 +50,7 @@ __FBSDID("$FreeBSD$");
> #include 
> #endif
> 
> -int kdb_active = 0;
> +bool __read_frequently kdb_active = 0;
> static void *kdb_jmpbufp = NULL;
> struct kdb_dbbe *kdb_dbbe = NULL;
> static struct pcb kdb_pcb;
> 
> Modified: head/sys/sys/kdb.h
> ==
> --- head/sys/sys/kdb.hFri Oct 20 03:38:58 2017(r324788)
> +++ head/sys/sys/kdb.hFri Oct 20 04:02:53 2017(r324789)
> @@ -59,7 +59,7 @@ struct kdb_dbbe {
>   };  \
>   DATA_SET(kdb_dbbe_set, name##_dbbe)
> 
> -extern int kdb_active;   /* Non-zero while in debugger. 
> */
> +extern bool kdb_active;  /* Non-zero while in debugger. 
> */
> extern int debugger_on_panic; /* enter the debugger on panic. */
> extern struct kdb_dbbe *kdb_dbbe; /* Default debugger backend or NULL. */
> extern struct trapframe *kdb_frame;   /* Frame to kdb_trap(). */

This broke `kdb_active` use in `kdb_trap`. It’s noticed by gcc on 
riscv64: https://ci.freebsd.org/job/FreeBSD-head-riscv64-build/4356/console .
Please fix or revert.
Thanks,
-Ngie



signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r324851 - head/share/man/man5

[Ngie Cooper]

Author: ngie
Date: Sun Oct 22 07:36:28 2017
New Revision: 324851
URL: https://svnweb.freebsd.org/changeset/base/324851

Log:
  Regenerate src.conf(5) after r324340 (armv7 addition)

Modified:
  head/share/man/man5/src.conf.5

Modified: head/share/man/man5/src.conf.5
==
--- head/share/man/man5/src.conf.5  Sun Oct 22 07:25:28 2017
(r324850)
+++ head/share/man/man5/src.conf.5  Sun Oct 22 07:36:28 2017
(r324851)
@@ -1,6 +1,6 @@
 .\" DO NOT EDIT-- this file is generated by tools/build/options/makeman.
 .\" $FreeBSD$
-.Dd October 06, 2017
+.Dd October 10, 2017
 .Dt SRC.CONF 5
 .Os
 .Sh NAME
@@ -162,7 +162,7 @@ Set to build and install binutils (as, ld, objcopy, an
 of the normal system build.
 .Pp
 This is a default setting on
-amd64/amd64, arm/arm, arm/armeb, arm/armv6, i386/i386, mips/mipsel, mips/mips, 
mips/mips64el, mips/mips64, mips/mipsn32, mips/mipselhf, mips/mipshf, 
mips/mips64elhf, mips/mips64hf, powerpc/powerpc, powerpc/powerpc64, 
powerpc/powerpcspe and sparc64/sparc64.
+amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm/armv7, i386/i386, mips/mipsel, 
mips/mips, mips/mips64el, mips/mips64, mips/mipsn32, mips/mipselhf, 
mips/mipshf, mips/mips64elhf, mips/mips64hf, powerpc/powerpc, 
powerpc/powerpc64, powerpc/powerpcspe and sparc64/sparc64.
 .It Va WITHOUT_BINUTILS_BOOTSTRAP
 Set to not build binutils (as, ld, objcopy and objdump)
 as part of the bootstrap process.
@@ -178,7 +178,7 @@ Set build binutils (as, ld, objcopy and objdump)
 as part of the bootstrap process.
 .Pp
 This is a default setting on
-amd64/amd64, arm/arm, arm/armeb, arm/armv6, i386/i386, mips/mipsel, mips/mips, 
mips/mips64el, mips/mips64, mips/mipsn32, mips/mipselhf, mips/mipshf, 
mips/mips64elhf, mips/mips64hf, powerpc/powerpc, powerpc/powerpc64, 
powerpc/powerpcspe and sparc64/sparc64.
+amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm/armv7, i386/i386, mips/mipsel, 
mips/mips, mips/mips64el, mips/mips64, mips/mipsn32, mips/mipselhf, 
mips/mipshf, mips/mips64elhf, mips/mips64hf, powerpc/powerpc, 
powerpc/powerpc64, powerpc/powerpcspe and sparc64/sparc64.
 .It Va WITHOUT_BLACKLIST
 Set this if you do not want to build
 .Xr blacklistd 8
@@ -220,11 +220,6 @@ Set to not build the BSD licensed version of cpio base
 .Xr libarchive 3 .
 .It Va WITH_BSD_GREP
 Install BSD-licensed grep as '[ef]grep' instead of GNU grep.
-.It Va WITHOUT_BSD_GREP_FASTMATCH
-Set this option to exclude the fastmatch implementation from
-.Xr bsdgrep 1 ,
-instead using only
-.Xr regex 3 .
 .It Va WITHOUT_BSNMP
 Set to not build or install
 .Xr bsnmpd 1
@@ -325,7 +320,7 @@ When set, it enforces these options:
 Set to build the Clang C/C++ compiler during the normal phase of the build.
 .Pp
 This is a default setting on
-amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64, i386/i386, 
mips/mipsel, mips/mips, mips/mips64el, mips/mips64, mips/mipsn32, 
mips/mipselhf, mips/mipshf, mips/mips64elhf, mips/mips64hf, powerpc/powerpc, 
powerpc/powerpc64 and powerpc/powerpcspe.
+amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm/armv7, arm64/aarch64, 
i386/i386, mips/mipsel, mips/mips, mips/mips64el, mips/mips64, mips/mipsn32, 
mips/mipselhf, mips/mipshf, mips/mips64elhf, mips/mips64hf, powerpc/powerpc, 
powerpc/powerpc64 and powerpc/powerpcspe.
 .It Va WITHOUT_CLANG_BOOTSTRAP
 Set to not build the Clang C/C++ compiler during the bootstrap phase of
 the build.
@@ -338,7 +333,7 @@ mips/mipsel, mips/mips, mips/mips64el, mips/mips64, mi
 Set to build the Clang C/C++ compiler during the bootstrap phase of the build.
 .Pp
 This is a default setting on
-amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64 and i386/i386.
+amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm/armv7, arm64/aarch64 and 
i386/i386.
 .It Va WITH_CLANG_EXTRAS
 Set to build additional clang and llvm tools, such as bugpoint.
 .It Va WITHOUT_CLANG_FULL
@@ -352,7 +347,7 @@ Set to build the ARCMigrate, Rewriter and StaticAnalyz
 Clang C/C++ compiler.
 .Pp
 This is a default setting on
-amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64, i386/i386, 
mips/mipsel, mips/mips, mips/mips64el, mips/mips64, mips/mipsn32, 
mips/mipselhf, mips/mipshf, mips/mips64elhf, mips/mips64hf, powerpc/powerpc, 
powerpc/powerpc64 and powerpc/powerpcspe.
+amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm/armv7, arm64/aarch64, 
i386/i386, mips/mipsel, mips/mips, mips/mips64el, mips/mips64, mips/mipsn32, 
mips/mipselhf, mips/mipshf, mips/mips64elhf, mips/mips64hf, powerpc/powerpc, 
powerpc/powerpc64 and powerpc/powerpcspe.
 .It Va WITHOUT_CLANG_IS_CC
 Set to install the GCC compiler as
 .Pa /usr/bin/cc ,
@@ -370,7 +365,7 @@ and
 .Pa /usr/bin/cpp .
 .Pp
 This is a default setting on
-amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64 and i386/i386.
+amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm/armv7, arm64/aarch64 and 
i386/i386.
 .It Va WITHOUT_CPP
 Set to not build
 .Xr cpp 1 .
@@ -437,7 +432,7 @@ Set to not build
 .Xr 

Re: svn commit: r324835 - head/etc

[Ngie Cooper (yaneurabeya)]

> On Oct 21, 2017, at 14:58, Brad Davis  wrote:
> 
> Author: brd (doc,ports committer)
> Date: Sat Oct 21 21:58:24 2017
> New Revision: 324835
> URL: https://svnweb.freebsd.org/changeset/base/324835
> 
> Log:
>  Remove a atrun check that is nullified by r318443.
> 
>  Approved by: will

Thanks :).
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r324811 - in head/sys/dev/pms/freebsd/driver: common ini/src

[Ngie Cooper (yaneurabeya)]

> On Oct 21, 2017, at 00:23, Ryan Libby  wrote:
> 
> Author: rlibby
> Date: Sat Oct 21 07:23:45 2017
> New Revision: 324811
> URL: https://svnweb.freebsd.org/changeset/base/324811
> 
> Log:
>  pms/freebsd: fix compiler warnings
> 
>   - A number of unused variable warnings,
>   - a missing prototype warning (actually a dead function),
>   - and a potential use of an uninitialized variable.

You probably should look for the other _fantastic_ fixes that Danny Ryan cooked 
up for the driver. I don’t think you’ve found the branches that result in logic 
errors which trigger corruption yet…
Cheers,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r324692 - stable/10/usr.bin/su

[Ngie Cooper]

Author: ngie
Date: Tue Oct 17 15:53:19 2017
New Revision: 324692
URL: https://svnweb.freebsd.org/changeset/base/324692

Log:
  MFC r324497:
  
  Mute gcc warning about p not being possibly initialized
  
  I'm running into this warning on a tinderbox run with gcc 4.2.1 with mips and
  powerpc.

Modified:
  stable/10/usr.bin/su/su.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/usr.bin/su/su.c
==
--- stable/10/usr.bin/su/su.c   Tue Oct 17 15:52:02 2017(r324691)
+++ stable/10/usr.bin/su/su.c   Tue Oct 17 15:53:19 2017(r324692)
@@ -172,7 +172,7 @@ main(int argc, char *argv[])
au_id_t  auid;
 #endif
 
-   shell = class = cleanenv = NULL;
+   p = shell = class = cleanenv = NULL;
asme = asthem = fastlogin = statusp = 0;
user = "root";
iscsh = UNSET;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324693 - stable/11/usr.bin/su

[Ngie Cooper]

Author: ngie
Date: Tue Oct 17 15:53:22 2017
New Revision: 324693
URL: https://svnweb.freebsd.org/changeset/base/324693

Log:
  MFC r324497:
  
  Mute gcc warning about p not being possibly initialized
  
  I'm running into this warning on a tinderbox run with gcc 4.2.1 with mips and
  powerpc.

Modified:
  stable/11/usr.bin/su/su.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/usr.bin/su/su.c
==
--- stable/11/usr.bin/su/su.c   Tue Oct 17 15:53:19 2017(r324692)
+++ stable/11/usr.bin/su/su.c   Tue Oct 17 15:53:22 2017(r324693)
@@ -172,7 +172,7 @@ main(int argc, char *argv[])
au_id_t  auid;
 #endif
 
-   shell = class = cleanenv = NULL;
+   p = shell = class = cleanenv = NULL;
asme = asthem = fastlogin = statusp = 0;
user = "root";
iscsh = UNSET;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324691 - in stable/11: sbin/growfs/tests tests/sys/geom/class/eli

[Ngie Cooper]

Author: ngie
Date: Tue Oct 17 15:52:02 2017
New Revision: 324691
URL: https://svnweb.freebsd.org/changeset/base/324691

Log:
  MFC r324478:
  
  Check the exit code from fsck_ffs instead of relying on MODIFIED being in the 
output
  
  ^/head@r323923 changed when MODIFIED is printed at exit. It's better to 
follow the
  documented way of determining whether or not a filesystem is clean per 
fsck_ffs, i.e.,
  ensure that the exit code is either 0 or 7.
  
  The pass/fail determination is brittle prior to this commit, and 
^/head@r323923 made
  the issue apparent -- thus this needs to be fixed independent of 
^/head@r323923.
  
  PR:   222780
  MFC with: r323923

Modified:
  stable/11/sbin/growfs/tests/legacy_test.pl
  stable/11/tests/sys/geom/class/eli/resize_test.sh
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sbin/growfs/tests/legacy_test.pl
==
--- stable/11/sbin/growfs/tests/legacy_test.pl  Tue Oct 17 15:49:36 2017
(r324690)
+++ stable/11/sbin/growfs/tests/legacy_test.pl  Tue Oct 17 15:52:02 2017
(r324691)
@@ -2,6 +2,7 @@
 
 use strict;
 use warnings;
+use POSIX;
 use Test::More tests => 19;
 use Fcntl qw(:DEFAULT :seek);
 
@@ -11,6 +12,22 @@ use constant BLKS_PER_MB => 2048;
 my $unit;
 END { system "mdconfig -du$unit" if defined $unit };
 
+sub fsck_md {
+my ($is_clean, $md);
+
+$md = shift;
+
+chomp(my @fsck_output = `fsck_ffs -Ffy ${md}a`);
+$is_clean = WIFEXITED($?) &&
+   (WEXITSTATUS($?) == 0 || WEXITSTATUS($?) == 7);
+ok($is_clean, "checking ${md}a's filesystem");
+if ($is_clean) {
+   diag "filesystem reported clean";
+} else {
+   diag "filesystem not reported clean: " . join("\n", @fsck_output);
+}
+}
+
 sub setsize {
 my ($partszMB, $unitszMB) = @_;
 
@@ -46,9 +63,8 @@ SKIP: {
ok(setsize(10, 40), "Sized ${md}a to 10m");
system "newfs -O $type -U ${md}a >/dev/null";
is($?, 0, "Initialised the filesystem on ${md}a as UFS$type");
-   chomp(my @out = `fsck -tufs -y ${md}a`);
-   ok(!grep(/MODIFIED/, @out), "fsck says ${md}a is clean, " .
-   scalar(@out) . " lines of output");
+
+   fsck_md($md);
}
 
extend20_zeroed: {
@@ -62,9 +78,7 @@ SKIP: {
fill(30 * BLKS_PER_MB - $unallocated, $unallocated, chr(0))
if $unallocated;
 
-   chomp(my @out = `fsck -tufs -y ${md}a`);
-   ok(!grep(/MODIFIED/, @out), "fsck says ${md}a is clean, " .
-   scalar(@out) . " lines of output");
+   fsck_md($md);
}
 
extend30_garbaged: {
@@ -78,9 +92,7 @@ SKIP: {
fill(30 * BLKS_PER_MB - $unallocated, $unallocated, chr(0))
if $unallocated;
 
-   chomp(my @out = `fsck -tufs -y ${md}a`);
-   ok(!grep(/MODIFIED/, @out), "fsck says ${md}a is clean, " .
-   scalar(@out) . " lines of output");
+   fsck_md($md);
}
 }
 

Modified: stable/11/tests/sys/geom/class/eli/resize_test.sh
==
--- stable/11/tests/sys/geom/class/eli/resize_test.sh   Tue Oct 17 15:49:36 
2017(r324690)
+++ stable/11/tests/sys/geom/class/eli/resize_test.sh   Tue Oct 17 15:52:02 
2017(r324691)
@@ -12,6 +12,19 @@ md=$(mdconfig -s40m) || exit 1
 unit=${md#md}
 i=1
 
+fsck_md()
+{
+   local is_clean
+
+   out=$(fsck_ffs -Ffy ${md}a.eli)
+   if [ $? -eq 0 -o $? -eq 7 ]; then
+   echo "ok $i - fsck says ${md}a.eli is clean"
+   else
+   echo "not ok $i - fsck says ${md}a.eli is dirty"
+   fi
+   i=$((i + 1))
+}
+
 setsize() {
 partszMB=$1 unitszMB=$2
 
@@ -38,13 +51,8 @@ i=$((i + 1))
 newfs -U ${md}a.eli >/dev/null || echo -n "not "
 echo ok $i - "Initialised the filesystem on ${md}a.eli"
 i=$((i + 1))
-out=$(fsck -tufs -y ${md}a.eli)
-echo "$out" | fgrep -q MODIFIED && echo -n "not "
-echo ok $i - "fsck says ${md}a.eli is clean," $(echo $(echo "$out" | wc -l)) \
-"lines of output"
-i=$((i + 1))
+fsck_md
 
-
 # Doing a backup, resize & restore must be forced (with -f) as geli
 # verifies that the provider size in the metadata matches the consumer.
 
@@ -78,13 +86,8 @@ growfs -y ${md}a.eli >/dev/null || echo -n "not "
 echo ok $i - "Extended the filesystem on ${md}a.eli"
 i=$((i + 1))
 
-out=$(fsck -tufs -y ${md}a.eli)
-echo "$out" | fgrep -q MODIFIED && echo -n "not "
-echo ok $i - "fsck says ${md}a.eli is clean," $(echo $(echo "$out" | wc -l)) \
-"lines of output"
-i=$((i + 1))
+fsck_md
 
-
 # Now do the resize properly
 
 geli detach ${md}a.eli || echo -n "not "
@@ -110,11 +113,7 @@ growfs -y ${md}a.eli >/dev/null || echo -n "not "
 echo ok $i - "Extended the filesystem on ${md}a.eli"
 i=$((i + 1))
 
-out=$(fsck -tufs -y ${md}a.eli)
-echo "$out" | fgrep -q MODIFIED && echo -n "not "
-echo ok $i - 

svn commit: r324690 - in stable/10: sbin/growfs/tests tests/sys/geom/class/eli

[Ngie Cooper]

Author: ngie
Date: Tue Oct 17 15:49:36 2017
New Revision: 324690
URL: https://svnweb.freebsd.org/changeset/base/324690

Log:
  MFC r324478:
  
  Check the exit code from fsck_ffs instead of relying on MODIFIED being in the 
output
  
  ^/head@r323923 changed when MODIFIED is printed at exit. It's better to 
follow the
  documented way of determining whether or not a filesystem is clean per 
fsck_ffs, i.e.,
  ensure that the exit code is either 0 or 7.
  
  The pass/fail determination is brittle prior to this commit, and 
^/head@r323923 made
  the issue apparent -- thus this needs to be fixed independent of 
^/head@r323923.
  
  PR:   222780
  MFC with: r323923

Modified:
  stable/10/sbin/growfs/tests/legacy_test.pl
  stable/10/tests/sys/geom/class/eli/resize_test.sh
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sbin/growfs/tests/legacy_test.pl
==
--- stable/10/sbin/growfs/tests/legacy_test.pl  Tue Oct 17 15:39:38 2017
(r324689)
+++ stable/10/sbin/growfs/tests/legacy_test.pl  Tue Oct 17 15:49:36 2017
(r324690)
@@ -2,6 +2,7 @@
 
 use strict;
 use warnings;
+use POSIX;
 use Test::More tests => 19;
 use Fcntl qw(:DEFAULT :seek);
 
@@ -11,6 +12,22 @@ use constant BLKS_PER_MB => 2048;
 my $unit;
 END { system "mdconfig -du$unit" if defined $unit };
 
+sub fsck_md {
+my ($is_clean, $md);
+
+$md = shift;
+
+chomp(my @fsck_output = `fsck_ffs -Ffy ${md}a`);
+$is_clean = WIFEXITED($?) &&
+   (WEXITSTATUS($?) == 0 || WEXITSTATUS($?) == 7);
+ok($is_clean, "checking ${md}a's filesystem");
+if ($is_clean) {
+   diag "filesystem reported clean";
+} else {
+   diag "filesystem not reported clean: " . join("\n", @fsck_output);
+}
+}
+
 sub setsize {
 my ($partszMB, $unitszMB) = @_;
 
@@ -46,9 +63,8 @@ SKIP: {
ok(setsize(10, 40), "Sized ${md}a to 10m");
system "newfs -O $type -U ${md}a >/dev/null";
is($?, 0, "Initialised the filesystem on ${md}a as UFS$type");
-   chomp(my @out = `fsck -tufs -y ${md}a`);
-   ok(!grep(/MODIFIED/, @out), "fsck says ${md}a is clean, " .
-   scalar(@out) . " lines of output");
+
+   fsck_md($md);
}
 
extend20_zeroed: {
@@ -62,9 +78,7 @@ SKIP: {
fill(30 * BLKS_PER_MB - $unallocated, $unallocated, chr(0))
if $unallocated;
 
-   chomp(my @out = `fsck -tufs -y ${md}a`);
-   ok(!grep(/MODIFIED/, @out), "fsck says ${md}a is clean, " .
-   scalar(@out) . " lines of output");
+   fsck_md($md);
}
 
extend30_garbaged: {
@@ -78,9 +92,7 @@ SKIP: {
fill(30 * BLKS_PER_MB - $unallocated, $unallocated, chr(0))
if $unallocated;
 
-   chomp(my @out = `fsck -tufs -y ${md}a`);
-   ok(!grep(/MODIFIED/, @out), "fsck says ${md}a is clean, " .
-   scalar(@out) . " lines of output");
+   fsck_md($md);
}
 }
 

Modified: stable/10/tests/sys/geom/class/eli/resize_test.sh
==
--- stable/10/tests/sys/geom/class/eli/resize_test.sh   Tue Oct 17 15:39:38 
2017(r324689)
+++ stable/10/tests/sys/geom/class/eli/resize_test.sh   Tue Oct 17 15:49:36 
2017(r324690)
@@ -12,6 +12,19 @@ md=$(mdconfig -s40m) || exit 1
 unit=${md#md}
 i=1
 
+fsck_md()
+{
+   local is_clean
+
+   out=$(fsck_ffs -Ffy ${md}a.eli)
+   if [ $? -eq 0 -o $? -eq 7 ]; then
+   echo "ok $i - fsck says ${md}a.eli is clean"
+   else
+   echo "not ok $i - fsck says ${md}a.eli is dirty"
+   fi
+   i=$((i + 1))
+}
+
 setsize() {
 partszMB=$1 unitszMB=$2
 
@@ -38,13 +51,8 @@ i=$((i + 1))
 newfs -U ${md}a.eli >/dev/null || echo -n "not "
 echo ok $i - "Initialised the filesystem on ${md}a.eli"
 i=$((i + 1))
-out=$(fsck -tufs -y ${md}a.eli)
-echo "$out" | fgrep -q MODIFIED && echo -n "not "
-echo ok $i - "fsck says ${md}a.eli is clean," $(echo $(echo "$out" | wc -l)) \
-"lines of output"
-i=$((i + 1))
+fsck_md
 
-
 # Doing a backup, resize & restore must be forced (with -f) as geli
 # verifies that the provider size in the metadata matches the consumer.
 
@@ -78,13 +86,8 @@ growfs -y ${md}a.eli >/dev/null || echo -n "not "
 echo ok $i - "Extended the filesystem on ${md}a.eli"
 i=$((i + 1))
 
-out=$(fsck -tufs -y ${md}a.eli)
-echo "$out" | fgrep -q MODIFIED && echo -n "not "
-echo ok $i - "fsck says ${md}a.eli is clean," $(echo $(echo "$out" | wc -l)) \
-"lines of output"
-i=$((i + 1))
+fsck_md
 
-
 # Now do the resize properly
 
 geli detach ${md}a.eli || echo -n "not "
@@ -110,11 +113,7 @@ growfs -y ${md}a.eli >/dev/null || echo -n "not "
 echo ok $i - "Extended the filesystem on ${md}a.eli"
 i=$((i + 1))
 
-out=$(fsck -tufs -y ${md}a.eli)
-echo "$out" | fgrep -q MODIFIED && echo -n "not "
-echo ok $i - 

Re: svn commit: r324666 - head/sys/kern

[Ngie Cooper (yaneurabeya)]

> On Oct 16, 2017, at 09:14, Matt Joras  wrote:
> 
> Author: mjoras
> Date: Mon Oct 16 16:14:50 2017
> New Revision: 324666
> URL: https://svnweb.freebsd.org/changeset/base/324666
> 
> Log:
>  Properly reset the fields in clean_unrhdr.
> 
>  In r324542 I neglected to reset the first and last fields of struct
>  unrhdr. This causes a tmpfs to fail the unr(9) consistency checks with
>  DIAGNOSTIC on. Fix this by resetting the fields by calling init_unrhdr.
>  While here, change a loop to use TAILQ_FOREACH_SAFE since it is more
>  readable and equally fast.

Thanks!


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r324541 - in head: share/man/man9 sys/kern sys/sys

[Ngie Cooper (yaneurabeya)]

> On Oct 11, 2017, at 14:53, Matt Joras  wrote:
> 
> Author: mjoras
> Date: Wed Oct 11 21:53:50 2017
> New Revision: 324541
> URL: https://svnweb.freebsd.org/changeset/base/324541
> 
> Log:
>  Add clearing function for unr(9).
> 
>  Previously before you could call unrhdr_delete you needed to
>  individually free every allocated unit. It is useful to be able to tear
>  down the unr without having to go through this process, as it is
>  significantly faster than freeing the individual units.
> 
>  Reviewed by: cem, lidl
>  Approved by: rstone (mentor)
>  Sponsored by:Dell EMC Isilon
>  Differential Revision:   https://reviews.freebsd.org/D12591
> 
> Modified:
>  head/share/man/man9/Makefile
>  head/share/man/man9/unr.9
>  head/sys/kern/subr_unit.c
>  head/sys/sys/systm.h
> 
> Modified: head/share/man/man9/Makefile
> ==
> --- head/share/man/man9/Makefile  Wed Oct 11 20:36:22 2017
> (r324540)
> +++ head/share/man/man9/Makefile  Wed Oct 11 21:53:50 2017
> (r324541)
> @@ -414,6 +414,7 @@ MAN=  accept_filter.9 \
> MLINKS=   unr.9 alloc_unr.9 \
>   unr.9 alloc_unrl.9 \
>   unr.9 alloc_unr_specific.9 \
> + unr.9 clear_unrhdr.9 \
>   unr.9 delete_unrhdr.9 \
>   unr.9 free_unr.9 \
>   unr.9 new_unrhdr.9
> 
> Modified: head/share/man/man9/unr.9
> ==
> --- head/share/man/man9/unr.9 Wed Oct 11 20:36:22 2017(r324540)
> +++ head/share/man/man9/unr.9 Wed Oct 11 21:53:50 2017(r324541)
> @@ -24,11 +24,12 @@
> .\"
> .\" $FreeBSD$
> .\"
> -.Dd July 5, 2010
> +.Dd October 4, 2017
> .Dt UNR 9
> .Os
> .Sh NAME
> .Nm new_unrhdr ,
> +.Nm clear_unrhdr ,
> .Nm delete_unrhdr ,
> .Nm alloc_unr ,
> .Nm alloc_unr_specific ,
> @@ -39,6 +40,8 @@
> .Ft "struct unrhdr *"
> .Fn new_unrhdr "int low" "int high" "struct mtx *mutex"
> .Ft void
> +.Fn clear_unrhdr "struct unrhdr *uh"
> +.Ft void
> .Fn delete_unrhdr "struct unrhdr *uh"
> .Ft int
> .Fn alloc_unr "struct unrhdr *uh"
> @@ -70,8 +73,16 @@ is not
> .Dv NULL ,
> it is used for locking when allocating and freeing units.
> Otherwise, internal mutex is used.
> +.It Fn clear_unrhdr uh
> +Clear all units from the specified unit number allocator entity.
> +This function resets the entity as if it were just initialized with
> +.Fn new_unrhdr .
> .It Fn delete_unrhdr uh
> -Destroy specified unit number allocator entity.
> +Delete specified unit number allocator entity.
> +This function frees the memory associated with the entity, it does not free
> +any units.
> +To free all units use
> +.Fn clear_unrhdr .
> .It Fn alloc_unr uh
> Return a new unit number.
> The lowest free number is always allocated.
> 
> Modified: head/sys/kern/subr_unit.c
> ==
> --- head/sys/kern/subr_unit.c Wed Oct 11 20:36:22 2017(r324540)
> +++ head/sys/kern/subr_unit.c Wed Oct 11 21:53:50 2017(r324541)
> @@ -366,6 +366,27 @@ delete_unrhdr(struct unrhdr *uh)
>   Free(uh);
> }
> 
> +void
> +clear_unrhdr(struct unrhdr *uh)
> +{
> + struct unr *up, *uq;
> +
> + KASSERT(TAILQ_EMPTY(>ppfree),
> + ("unrhdr has postponed item for free"));
> + up = TAILQ_FIRST(>head);
> + while (up != NULL) {

Could this be done with TAILQ_FOREACH_SAFE?
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r324471 - head/sys/boot

[Ngie Cooper]

> On Oct 9, 2017, at 21:57, Ngie Cooper (yaneurabeya) <yaneurab...@gmail.com> 
> wrote:
> 
> 
>> On Oct 9, 2017, at 21:56, Warner Losh <i...@bsdimp.com> wrote:
>> 
>> DO NOT MAKE EDITS TO sys/boot. YOU ARE CREATING CONFLICTS FOR ME.
>> 
>> DO NOT MAKE ANY COMMITS TO sys/boot.
>> 
>> BACK OFF.
>> 
>> Seriously, though, extra changes create extra friction, and these changes 
>> aren't worth any friction at all. I'm deleting LIBSAU and this guarantees a 
>> conflict when I update.
>> 
>> So please, do not make any edits to sys/boot whatsoever, no matter how 
>> trivial.
>> 
>> At least until I'm done.
> 
> Ok

So... what’s the status?
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324497 - head/usr.bin/su

[Ngie Cooper]

Author: ngie
Date: Tue Oct 10 15:41:35 2017
New Revision: 324497
URL: https://svnweb.freebsd.org/changeset/base/324497

Log:
  Mute gcc warning about p not being possibly initialized
  
  I'm running into this warning on a tinderbox run with gcc 4.2.1 with mips and
  powerpc.
  
  MFC after:1 week

Modified:
  head/usr.bin/su/su.c

Modified: head/usr.bin/su/su.c
==
--- head/usr.bin/su/su.cTue Oct 10 13:06:11 2017(r324496)
+++ head/usr.bin/su/su.cTue Oct 10 15:41:35 2017(r324497)
@@ -172,7 +172,7 @@ main(int argc, char *argv[])
au_id_t  auid;
 #endif
 
-   shell = class = cleanenv = NULL;
+   p = shell = class = cleanenv = NULL;
asme = asthem = fastlogin = statusp = 0;
user = "root";
iscsh = UNSET;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324478 - in head: sbin/growfs/tests tests/sys/geom/class/eli

[Ngie Cooper]

Author: ngie
Date: Tue Oct 10 05:58:33 2017
New Revision: 324478
URL: https://svnweb.freebsd.org/changeset/base/324478

Log:
  Check the exit code from fsck_ffs instead of relying on MODIFIED being in the 
output
  
  ^/head@r323923 changed when MODIFIED is printed at exit. It's better to 
follow the
  documented way of determining whether or not a filesystem is clean per 
fsck_ffs, i.e.,
  ensure that the exit code is either 0 or 7.
  
  The pass/fail determination is brittle prior to this commit, and 
^/head@r323923 made
  the issue apparent -- thus this needs to be fixed independent of 
^/head@r323923.
  
  PR:   222780
  MFC after:1 week
  MFC with: r323923
  Reported by:  Jenkins

Modified:
  head/sbin/growfs/tests/legacy_test.pl
  head/tests/sys/geom/class/eli/resize_test.sh

Modified: head/sbin/growfs/tests/legacy_test.pl
==
--- head/sbin/growfs/tests/legacy_test.pl   Tue Oct 10 05:52:28 2017
(r324477)
+++ head/sbin/growfs/tests/legacy_test.pl   Tue Oct 10 05:58:33 2017
(r324478)
@@ -2,6 +2,7 @@
 
 use strict;
 use warnings;
+use POSIX;
 use Test::More tests => 19;
 use Fcntl qw(:DEFAULT :seek);
 
@@ -11,6 +12,22 @@ use constant BLKS_PER_MB => 2048;
 my $unit;
 END { system "mdconfig -du$unit" if defined $unit };
 
+sub fsck_md {
+my ($is_clean, $md);
+
+$md = shift;
+
+chomp(my @fsck_output = `fsck_ffs -Ffy ${md}a`);
+$is_clean = WIFEXITED($?) &&
+   (WEXITSTATUS($?) == 0 || WEXITSTATUS($?) == 7);
+ok($is_clean, "checking ${md}a's filesystem");
+if ($is_clean) {
+   diag "filesystem reported clean";
+} else {
+   diag "filesystem not reported clean: " . join("\n", @fsck_output);
+}
+}
+
 sub setsize {
 my ($partszMB, $unitszMB) = @_;
 
@@ -46,9 +63,8 @@ SKIP: {
ok(setsize(10, 40), "Sized ${md}a to 10m");
system "newfs -O $type -U ${md}a >/dev/null";
is($?, 0, "Initialised the filesystem on ${md}a as UFS$type");
-   chomp(my @out = `fsck -tufs -y ${md}a`);
-   ok(!grep(/MODIFIED/, @out), "fsck says ${md}a is clean, " .
-   scalar(@out) . " lines of output");
+
+   fsck_md($md);
}
 
extend20_zeroed: {
@@ -62,9 +78,7 @@ SKIP: {
fill(30 * BLKS_PER_MB - $unallocated, $unallocated, chr(0))
if $unallocated;
 
-   chomp(my @out = `fsck -tufs -y ${md}a`);
-   ok(!grep(/MODIFIED/, @out), "fsck says ${md}a is clean, " .
-   scalar(@out) . " lines of output");
+   fsck_md($md);
}
 
extend30_garbaged: {
@@ -78,9 +92,7 @@ SKIP: {
fill(30 * BLKS_PER_MB - $unallocated, $unallocated, chr(0))
if $unallocated;
 
-   chomp(my @out = `fsck -tufs -y ${md}a`);
-   ok(!grep(/MODIFIED/, @out), "fsck says ${md}a is clean, " .
-   scalar(@out) . " lines of output");
+   fsck_md($md);
}
 }
 

Modified: head/tests/sys/geom/class/eli/resize_test.sh
==
--- head/tests/sys/geom/class/eli/resize_test.shTue Oct 10 05:52:28 
2017(r324477)
+++ head/tests/sys/geom/class/eli/resize_test.shTue Oct 10 05:58:33 
2017(r324478)
@@ -12,6 +12,19 @@ md=$(mdconfig -s40m) || exit 1
 unit=${md#md}
 i=1
 
+fsck_md()
+{
+   local is_clean
+
+   out=$(fsck_ffs -Ffy ${md}a.eli)
+   if [ $? -eq 0 -o $? -eq 7 ]; then
+   echo "ok $i - fsck says ${md}a.eli is clean"
+   else
+   echo "not ok $i - fsck says ${md}a.eli is dirty"
+   fi
+   i=$((i + 1))
+}
+
 setsize() {
 partszMB=$1 unitszMB=$2
 
@@ -38,13 +51,8 @@ i=$((i + 1))
 newfs -U ${md}a.eli >/dev/null || echo -n "not "
 echo ok $i - "Initialised the filesystem on ${md}a.eli"
 i=$((i + 1))
-out=$(fsck -tufs -y ${md}a.eli)
-echo "$out" | fgrep -q MODIFIED && echo -n "not "
-echo ok $i - "fsck says ${md}a.eli is clean," $(echo $(echo "$out" | wc -l)) \
-"lines of output"
-i=$((i + 1))
+fsck_md
 
-
 # Doing a backup, resize & restore must be forced (with -f) as geli
 # verifies that the provider size in the metadata matches the consumer.
 
@@ -78,13 +86,8 @@ growfs -y ${md}a.eli >/dev/null || echo -n "not "
 echo ok $i - "Extended the filesystem on ${md}a.eli"
 i=$((i + 1))
 
-out=$(fsck -tufs -y ${md}a.eli)
-echo "$out" | fgrep -q MODIFIED && echo -n "not "
-echo ok $i - "fsck says ${md}a.eli is clean," $(echo $(echo "$out" | wc -l)) \
-"lines of output"
-i=$((i + 1))
+fsck_md
 
-
 # Now do the resize properly
 
 geli detach ${md}a.eli || echo -n "not "
@@ -110,11 +113,7 @@ growfs -y ${md}a.eli >/dev/null || echo -n "not "
 echo ok $i - "Extended the filesystem on ${md}a.eli"
 i=$((i + 1))
 
-out=$(fsck -tufs -y ${md}a.eli)
-echo "$out" | fgrep -q MODIFIED && echo -n "not "
-echo ok $i - "fsck says ${md}a.eli is clean," $(echo $(echo 

Re: svn commit: r324471 - head/sys/boot

[Ngie Cooper (yaneurabeya)]

> On Oct 9, 2017, at 21:56, Warner Losh  wrote:
> 
> DO NOT MAKE EDITS TO sys/boot. YOU ARE CREATING CONFLICTS FOR ME.
> 
> DO NOT MAKE ANY COMMITS TO sys/boot.
> 
> BACK OFF.
> 
> Seriously, though, extra changes create extra friction, and these changes 
> aren't worth any friction at all. I'm deleting LIBSAU and this guarantees a 
> conflict when I update.
> 
> So please, do not make any edits to sys/boot whatsoever, no matter how 
> trivial.
> 
> At least until I'm done.

Ok


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r324471 - head/sys/boot

[Ngie Cooper]

Author: ngie
Date: Tue Oct 10 04:53:26 2017
New Revision: 324471
URL: https://svnweb.freebsd.org/changeset/base/324471

Log:
  Fix typos: `stand alon{e,g}` should be spelled like `standalone`

Modified:
  head/sys/boot/Makefile.inc

Modified: head/sys/boot/Makefile.inc
==
--- head/sys/boot/Makefile.inc  Tue Oct 10 04:50:05 2017(r324470)
+++ head/sys/boot/Makefile.inc  Tue Oct 10 04:53:26 2017(r324471)
@@ -6,11 +6,11 @@
 __BOOT_MAKEFILE_INC__=${MFILE}
 
 SASRC=${SRCTOP}/lib/libstand
-# Normal stand alone library
+# Normal standalone library
 LIBSA=${OBJTOP}/sys/boot/libsa/libstand.a
-# stand alone library compiled for 32-bit version of the processor
+# Standalone library compiled for 32-bit version of the processor
 LIBSA32=${OBJTOP}/sys/boot/libstand32/libstand.a
-# stand along library compiled for userboot
+# Standalone library compiled for userboot
 LIBSAU=${OBJTOP}/sys/boot/userboot/libstand/libstand.a
 
 CFLAGS+=-I${SASRC}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324470 - head/sys/modules/iwmfw

[Ngie Cooper]

Author: ngie
Date: Tue Oct 10 04:50:05 2017
New Revision: 324470
URL: https://svnweb.freebsd.org/changeset/base/324470

Log:
  Add missing SUBDIR needed for iwmfw to load after ^/head@r324434
  
  Submitted by: Pete Wright 
  MFC after:1 month
  MFC with: r324434

Modified:
  head/sys/modules/iwmfw/Makefile

Modified: head/sys/modules/iwmfw/Makefile
==
--- head/sys/modules/iwmfw/Makefile Tue Oct 10 04:47:01 2017
(r324469)
+++ head/sys/modules/iwmfw/Makefile Tue Oct 10 04:50:05 2017
(r324470)
@@ -4,6 +4,7 @@ SUBDIR= iwm3160fw \
iwm7260fw \
iwm7265fw \
iwm7265Dfw \
-   iwm8000Cfw
+   iwm8000Cfw \
+   iwm8265fw
 
 .include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324469 - head/sys/modules/iwmfw

[Ngie Cooper]

Author: ngie
Date: Tue Oct 10 04:47:01 2017
New Revision: 324469
URL: https://svnweb.freebsd.org/changeset/base/324469

Log:
  Sort SUBDIR and put entries on a single list
  
  This is to aid with identifying diffs between commits.
  
  MFC after:3 days

Modified:
  head/sys/modules/iwmfw/Makefile

Modified: head/sys/modules/iwmfw/Makefile
==
--- head/sys/modules/iwmfw/Makefile Tue Oct 10 03:40:38 2017
(r324468)
+++ head/sys/modules/iwmfw/Makefile Tue Oct 10 04:47:01 2017
(r324469)
@@ -1,5 +1,9 @@
 # $FreeBSD$
 
-SUBDIR=iwm3160fw iwm7260fw iwm7265fw iwm8000Cfw iwm7265Dfw
+SUBDIR=iwm3160fw \
+   iwm7260fw \
+   iwm7265fw \
+   iwm7265Dfw \
+   iwm8000Cfw
 
 .include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r324452 - in head/sys/boot: . arm/uboot efi/boot1 efi/loader i386/gptboot i386/gptzfsboot i386/loader i386/zfsboot mips/beri/boot2 mips/beri/loader mips/uboot powerpc/kboot powerpc/ofw

[Ngie Cooper (yaneurabeya)]

> On Oct 9, 2017, at 16:23, John Baldwin  wrote:

…

> s/along/alone/.  bde@ probably prefers that the comments start with a capital
> letter as well.

Also: standalone is one word, not 2.
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r324406 - head/sys/modules/em

[Ngie Cooper (yaneurabeya)]

> On Oct 9, 2017, at 18:54, Ian Lepore  wrote:

...

> I think the right answer here is just
> 
>   LINKS= ${KMODDIR}/${KMOD}.ko ${KMODDIR}/if_igb.ko

That will definitely work and is probably the best pattern.
Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r324406 - head/sys/modules/em

[Ngie Cooper]

> On Oct 7, 2017, at 16:33, Sean Bruno  wrote:
> 
> Author: sbruno
> Date: Sat Oct  7 23:33:14 2017
> New Revision: 324406
> URL: https://svnweb.freebsd.org/changeset/base/324406
> 
> Log:
>  Fix symlink if_igb.ko in -current such that its relative and doesn't
>  end up with non-standard DESTDIR information in its symlink.  This
>  can happen very trivially if the release scripts are used.
> 
>  Sponsored by:Limelight Networks
> 
> Modified:
>  head/sys/modules/em/Makefile
> 
> Modified: head/sys/modules/em/Makefile
> ==
> --- head/sys/modules/em/MakefileSat Oct  7 23:30:57 2017(r324405)
> +++ head/sys/modules/em/MakefileSat Oct  7 23:33:14 2017(r324406)
> @@ -23,6 +23,6 @@ CFLAGS += -I${SRCTOP}/sys/dev/e1000
> #CFLAGS  += -DDEVICE_POLLING
> 
> afterinstall:
> -ln -sf ${DESTDIR}${KMODDIR}/${KMOD}.ko ${DESTDIR}${KMODDIR}/if_igb.ko
> +cd ${DESTDIR}${KMODDIR} && ln -sf if_em.ko if_igb.ko

While this is definitely better, the same thing could be achieved via:

ln -sf if_em.ko ${DESTDIR}/.../if_igb.ko
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324404 - in stable/11/tests: etc/rc.d sys/acl sys/file sys/geom/class/eli sys/geom/class/gate sys/geom/class/mirror sys/geom/class/nop sys/geom/class/uzip sys/kqueue/libkqueue sys/mac/...

[Ngie Cooper]

Author: ngie
Date: Sat Oct  7 23:10:16 2017
New Revision: 324404
URL: https://svnweb.freebsd.org/changeset/base/324404

Log:
  MFC note: tests/sys/kern/coredump_phnum_test.sh changes omitted
  
  MFC r322214:
  
  Make test scripts under tests/... non-executable
  
  Executable bits should be set at install time instead of in the repo.
  Setting executable bits on files triggers false positives with Phabricator.

Modified:
Directory Properties:
  stable/11/   (props changed)
  stable/11/tests/etc/rc.d/routing_test.sh   (props changed)
  stable/11/tests/sys/acl/aclfuzzer.sh   (props changed)
  stable/11/tests/sys/acl/mktrivial.sh   (props changed)
  stable/11/tests/sys/file/flock_test.sh   (props changed)
  stable/11/tests/sys/geom/class/eli/conf.sh   (props changed)
  stable/11/tests/sys/geom/class/eli/init_alias_test.sh   (props changed)
  stable/11/tests/sys/geom/class/gate/ggate_test.sh   (props changed)
  stable/11/tests/sys/geom/class/mirror/8_test.sh   (props changed)
  stable/11/tests/sys/geom/class/mirror/9_test.sh   (props changed)
  stable/11/tests/sys/geom/class/nop/nop_test.sh   (props changed)
  stable/11/tests/sys/geom/class/uzip/conf.sh   (props changed)
  stable/11/tests/sys/kqueue/libkqueue/kqueue_test.sh   (props changed)
  stable/11/tests/sys/mac/portacl/misc.sh   (props changed)
  stable/11/tests/sys/mac/portacl/nobody_test.sh   (props changed)
  stable/11/tests/sys/mac/portacl/root_test.sh   (props changed)
  stable/11/tests/sys/mqueue/mqueue_test.sh   (props changed)
  stable/11/tests/sys/netinet/fibs_test.sh   (props changed)
  stable/11/tests/sys/opencrypto/runtests.sh   (props changed)
  stable/11/tests/sys/vfs/trailing_slash.sh   (props changed)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324403 - stable/11/tests/sys/geom/class/mirror

[Ngie Cooper]

Author: ngie
Date: Sat Oct  7 23:08:36 2017
New Revision: 324403
URL: https://svnweb.freebsd.org/changeset/base/324403

Log:
  MFC r317713:
  r317713 (by markj):
  
  Add regression tests for r317712 and r306743.

Added:
  stable/11/tests/sys/geom/class/mirror/8_test.sh
 - copied unchanged from r317713, head/tests/sys/geom/class/mirror/8_test.sh
  stable/11/tests/sys/geom/class/mirror/9_test.sh
 - copied unchanged from r317713, head/tests/sys/geom/class/mirror/9_test.sh
Modified:
  stable/11/tests/sys/geom/class/mirror/Makefile
Directory Properties:
  stable/11/   (props changed)

Copied: stable/11/tests/sys/geom/class/mirror/8_test.sh (from r317713, 
head/tests/sys/geom/class/mirror/8_test.sh)
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ stable/11/tests/sys/geom/class/mirror/8_test.sh Sat Oct  7 23:08:36 
2017(r324403, copy of r317713, 
head/tests/sys/geom/class/mirror/8_test.sh)
@@ -0,0 +1,53 @@
+#!/bin/sh
+# $FreeBSD$
+
+# Regression test for r317712.
+
+. `dirname $0`/conf.sh
+
+echo 1..1
+
+ddbs=2048
+m1=`mktemp $base.XX` || exit 1
+m2=`mktemp $base.XX` || exit 1
+
+dd if=/dev/zero of=$m1 bs=$ddbs count=1024 >/dev/null 2>&1
+dd if=/dev/zero of=$m2 bs=$ddbs count=1024 >/dev/null 2>&1
+
+us0=$(mdconfig -t vnode -f $m1) || exit 1
+us1=$(mdconfig -t vnode -f $m2) || exit 1
+
+gmirror label $name /dev/$us0 /dev/$us1 || exit 1
+devwait
+
+# Ensure that the mirrors are marked dirty, and then disconnect them.
+# We need to have the gmirror provider open when destroying the MDs since
+# gmirror will automatically mark the mirrors clean when the provider is 
closed.
+exec 9>/dev/mirror/$name
+dd if=/dev/zero bs=$ddbs count=1 >&9 2>/dev/null
+mdconfig -d -u ${us0#md} -o force || exit 1
+mdconfig -d -u ${us1#md} -o force || exit 1
+exec 9>&-
+
+dd if=/dev/random of=$m1 bs=$ddbs count=1 conv=notrunc >/dev/null 2>&1
+us0=$(attach_md -t vnode -f $m1) || exit 1
+devwait # This will take kern.geom.mirror.timeout seconds.
+
+# Re-attach the second mirror and wait for it to synchronize.
+us1=$(attach_md -t vnode -f $m2) || exit 1
+while [ $(gmirror status $name | grep ACTIVE | wc -l) -ne 2 ]; do
+sleep 1
+done
+
+# Verify the two mirrors are identical. Destroy the gmirror first so that
+# the mirror metadata is wiped; otherwise the metadata blocks will fail
+# the comparison. It would be nice to do this with a "gmirror verify"
+# command instead.
+gmirror destroy $name
+if cmp -s ${m1} ${m2}; then
+echo "ok 1"
+else
+echo "not ok 1"
+fi
+
+rm -f $m1 $m2

Copied: stable/11/tests/sys/geom/class/mirror/9_test.sh (from r317713, 
head/tests/sys/geom/class/mirror/9_test.sh)
==
--- /dev/null   00:00:00 1970   (empty, because file is newly added)
+++ stable/11/tests/sys/geom/class/mirror/9_test.sh Sat Oct  7 23:08:36 
2017(r324403, copy of r317713, 
head/tests/sys/geom/class/mirror/9_test.sh)
@@ -0,0 +1,62 @@
+#!/bin/sh
+# $FreeBSD$
+
+# Regression test for r306743.
+
+. `dirname $0`/conf.sh
+
+echo 1..1
+
+ddbs=2048
+m1=`mktemp $base.XX` || exit 1
+m2=`mktemp $base.XX` || exit 1
+m3=`mktemp $base.XX` || exit 1
+
+dd if=/dev/zero of=$m1 bs=$ddbs count=1024 >/dev/null 2>&1
+dd if=/dev/zero of=$m2 bs=$ddbs count=1024 >/dev/null 2>&1
+dd if=/dev/zero of=$m3 bs=$ddbs count=1024 >/dev/null 2>&1
+
+us0=$(attach_md -t vnode -f $m1) || exit 1
+us1=$(attach_md -t vnode -f $m2) || exit 1
+us2=$(attach_md -t vnode -f $m3) || exit 1
+
+gmirror label $name /dev/$us0 /dev/$us1 || exit 1
+devwait
+
+# Break one of the mirrors by forcing a single metadata write error.
+# When dd closes the mirror provider, gmirror will attempt to mark the mirrors
+# clean, and will kick one of the mirrors out upon hitting the error.
+sysctl debug.fail_point.g_mirror_metadata_write='1*return(5)' || exit 1
+dd if=/dev/random of=/dev/mirror/$name bs=$ddbs count=1 >/dev/null 2>&1
+sysctl debug.fail_point.g_mirror_metadata_write='off' || exit 1
+
+# Replace the broken mirror, and then stop the gmirror.
+gmirror forget $name || exit 1
+gmirror insert $name /dev/$us2 || exit 1
+while [ $(gmirror status $name | grep ACTIVE | wc -l) -ne 2 ]; do
+sleep 1
+done
+gmirror stop $name || exit 1
+
+# Restart the gmirror on the original two mirrors. One of them is broken,
+# so we should end up with a degraded gmirror.
+gmirror activate $name /dev/$us0 /dev/$us1 || exit 1
+devwait
+dd if=/dev/random of=/dev/mirror/$name bs=$ddbs count=1 >/dev/null 2>&1
+
+# Re-add the replacement mirror and verify the two mirrors are synchronized.
+# Destroy the gmirror first so that the mirror metadata is wiped; otherwise
+# the metadata blocks will fail the comparison. It would be nice to do this
+# with a "gmirror verify" command instead.
+gmirror activate $name /dev/$us2 || exit 1
+while [ $(gmirror status $name | grep ACTIVE | wc -l) -ne 2 

svn commit: r324402 - stable/11/sys/geom/mirror

[Ngie Cooper]

Author: ngie
Date: Sat Oct  7 23:06:49 2017
New Revision: 324402
URL: https://svnweb.freebsd.org/changeset/base/324402

Log:
  MFC r305508:
  r305508 (by markj):
  
  Add some fail points to gmirror.
  
  These are useful for testing changes to I/O error handling, and for
  reproducing existing bugs in a controlled manner. The fail points are
  
  g_mirror_regular_request_read
  g_mirror_regular_request_write
  g_mirror_sync_request_read
  g_mirror_sync_request_write
  g_mirror_metadata_write
  
  They all effectively allow one to inject an error value into the bio_error
  field of a corresponding BIO request as it is being completed.

Modified:
  stable/11/sys/geom/mirror/g_mirror.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/geom/mirror/g_mirror.c
==
--- stable/11/sys/geom/mirror/g_mirror.cSat Oct  7 22:59:09 2017
(r324401)
+++ stable/11/sys/geom/mirror/g_mirror.cSat Oct  7 23:06:49 2017
(r324402)
@@ -29,6 +29,7 @@ __FBSDID("$FreeBSD$");
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -665,6 +666,7 @@ g_mirror_write_metadata(struct g_mirror_disk *disk,
else
mirror_metadata_encode(md, sector);
}
+   KFAIL_POINT_ERROR(DEBUG_FP, g_mirror_metadata_write, error);
if (error == 0)
error = g_write_data(cp, offset, sector, length);
free(sector, M_MIRROR);
@@ -937,6 +939,13 @@ g_mirror_regular_request(struct bio *bp)
g_topology_unlock();
}
 
+   if (bp->bio_cmd == BIO_READ)
+   KFAIL_POINT_ERROR(DEBUG_FP, g_mirror_regular_request_read,
+   bp->bio_error);
+   else if (bp->bio_cmd == BIO_WRITE)
+   KFAIL_POINT_ERROR(DEBUG_FP, g_mirror_regular_request_write,
+   bp->bio_error);
+
pbp->bio_inbed++;
KASSERT(pbp->bio_inbed <= pbp->bio_children,
("bio_inbed (%u) is bigger than bio_children (%u).", pbp->bio_inbed,
@@ -1331,6 +1340,9 @@ g_mirror_sync_request(struct bio *bp)
{
struct g_consumer *cp;
 
+   KFAIL_POINT_ERROR(DEBUG_FP, g_mirror_sync_request_read,
+   bp->bio_error);
+
if (bp->bio_error != 0) {
G_MIRROR_LOGREQ(0, bp,
"Synchronization request failed (error=%d).",
@@ -1356,6 +1368,9 @@ g_mirror_sync_request(struct bio *bp)
off_t offset;
void *data;
int i;
+
+   KFAIL_POINT_ERROR(DEBUG_FP, g_mirror_sync_request_write,
+   bp->bio_error);
 
if (bp->bio_error != 0) {
G_MIRROR_LOGREQ(0, bp,
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324401 - stable/11/sys/geom/mirror

[Ngie Cooper]

Author: ngie
Date: Sat Oct  7 22:59:09 2017
New Revision: 324401
URL: https://svnweb.freebsd.org/changeset/base/324401

Log:
  MFC r306743,r317712:
  
  r306743 (by markj):
  
  gmirror: Bump the syncid if broken disks are found during startup.
  
  Consider a mirror with two components, m1 and m2. Suppose a hardware error
  results in the removal of m2, with m1's genid bumped. Suppose further that
  a replacement mirror component m3 is created and synchronized, after which
  the system is shut down uncleanly. During a subsequent bootup, if gmirror
  tastes m1 and m2 first, m2 will be removed from the mirror because it is
  broken, but the mirror will be started without bumping the syncid on m1
  because all elements of the mirror are accounted for. Then m3 will be
  added to the already-running mirror with the same syncid as m1, so the
  components will not be synchronized despite the unclean shutdown.
  
  Handle this scenario by bumping the syncid of healthy components if any
  broken mirrors are discovered during mirror startup.
  
  r317712 (by markj):
  
  Synchronize unclean mirrors before adding them to a running gmirror.
  
  During gmirror startup, if component mirrors are found to be dirty as is
  typical after a system crash, the mirrors are synchronized to the mirror
  with highest priority. However if a gmirror starts without all of its
  mirrors present, for example because of some transient delays during
  tasting, the remaining mirrors must be synchronized before they may become
  active.

Modified:
  stable/11/sys/geom/mirror/g_mirror.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/geom/mirror/g_mirror.c
==
--- stable/11/sys/geom/mirror/g_mirror.cSat Oct  7 21:13:54 2017
(r324400)
+++ stable/11/sys/geom/mirror/g_mirror.cSat Oct  7 22:59:09 2017
(r324401)
@@ -2195,7 +2195,9 @@ g_mirror_determine_state(struct g_mirror_disk *disk)
sc = disk->d_softc;
if (sc->sc_syncid == disk->d_sync.ds_syncid) {
if ((disk->d_flags &
-   G_MIRROR_DISK_FLAG_SYNCHRONIZING) == 0) {
+   G_MIRROR_DISK_FLAG_SYNCHRONIZING) == 0 &&
+   (g_mirror_ndisks(sc, G_MIRROR_DISK_STATE_ACTIVE) == 0 ||
+(disk->d_flags & G_MIRROR_DISK_FLAG_DIRTY) == 0)) {
/* Disk does not need synchronization. */
state = G_MIRROR_DISK_STATE_ACTIVE;
} else {
@@ -2267,6 +2269,7 @@ g_mirror_update_device(struct g_mirror_softc *sc, bool
{
struct g_mirror_disk *pdisk, *tdisk;
u_int dirty, ndisks, genid, syncid;
+   bool broken;
 
KASSERT(sc->sc_provider == NULL,
("Non-NULL provider in STARTING state (%s).", sc->sc_name));
@@ -2334,12 +2337,18 @@ g_mirror_update_device(struct g_mirror_softc *sc, bool
/*
 * Remove all disks without the biggest genid.
 */
+   broken = false;
LIST_FOREACH_SAFE(disk, >sc_disks, d_next, tdisk) {
if (disk->d_genid < genid) {
G_MIRROR_DEBUG(0,
"Component %s (device %s) broken, 
skipping.",
g_mirror_get_diskname(disk), sc->sc_name);
g_mirror_destroy_disk(disk);
+   /*
+* Bump the syncid in case we discover a healthy
+* replacement disk after starting the mirror.
+*/
+   broken = true;
}
}
 
@@ -2430,7 +2439,7 @@ g_mirror_update_device(struct g_mirror_softc *sc, bool
/* Reset hint. */
sc->sc_hint = NULL;
sc->sc_syncid = syncid;
-   if (force) {
+   if (force || broken) {
/* Remember to bump syncid on first write. */
sc->sc_bump_id |= G_MIRROR_BUMP_SYNCID;
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324392 - stable/10

[Ngie Cooper]

Author: ngie
Date: Sat Oct  7 18:49:39 2017
New Revision: 324392
URL: https://svnweb.freebsd.org/changeset/base/324392

Log:
  MFC note: MK_LIBSOFT doesn't apply to ^/stable/10 .
  
  MFC r322633,r324143:
  
  r322633:
  
  Honor NO_RTLD for rtld-elf, similar to what's done in libexec/Makefile, with
  libexec/rtld-elf/... for MK_{LIB32,LIBSOFT}.
  
  r324143:
  
  Adjust r322633 to only apply to libexec/rtld-elf, and not usr.bin/ldd,
  when running build32/install32
  
  This unbreaks installing usr.bin/ldd as ldd32 when NO_RTLD is defined.
  
  MFC with:   r322633

Modified:
  stable/10/Makefile.inc1
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/Makefile.inc1
==
--- stable/10/Makefile.inc1 Sat Oct  7 18:46:50 2017(r324391)
+++ stable/10/Makefile.inc1 Sat Oct  7 18:49:39 2017(r324392)
@@ -640,8 +640,10 @@ build32: .PHONY
${_+_}cd ${.CURDIR}; \
${LIB32WMAKE} -f Makefile.inc1 -DNO_FSCHG libraries
 .for _t in obj depend all
+.if !defined(NO_RTLD)
${_+_}cd ${.CURDIR}/libexec/rtld-elf; PROG=ld-elf32.so.1 ${LIB32WMAKE} \
-DNO_FSCHG DIRPRFX=libexec/rtld-elf/ ${_t}
+.endif
${_+_}cd ${.CURDIR}/usr.bin/ldd; PROG=ldd32 ${LIB32WMAKE} \
DIRPRFX=usr.bin/ldd ${_t}
 .endfor
@@ -658,8 +660,10 @@ distribute32 install32: .MAKE .PHONY
 .if ${MK_KERBEROS} != "no"
${_+_}cd ${.CURDIR}/kerberos5/lib; ${LIB32IMAKE} ${.TARGET:S/32$//}
 .endif
+.if !defined(NO_RTLD)
${_+_}cd ${.CURDIR}/libexec/rtld-elf; \
PROG=ld-elf32.so.1 ${LIB32IMAKE} ${.TARGET:S/32$//}
+.endif
${_+_}cd ${.CURDIR}/usr.bin/ldd; PROG=ldd32 ${LIB32IMAKE} \
${.TARGET:S/32$//}
 .endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324391 - stable/11

[Ngie Cooper]

Author: ngie
Date: Sat Oct  7 18:46:50 2017
New Revision: 324391
URL: https://svnweb.freebsd.org/changeset/base/324391

Log:
  MFC r324143:
  
  Adjust r322633 to only apply to libexec/rtld-elf, and not usr.bin/ldd,
  when running build32/install32
  
  This unbreaks installing usr.bin/ldd as ldd32 when NO_RTLD is defined.
  
  MFC with:   r322633

Modified:
  stable/11/Makefile.libcompat
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/Makefile.libcompat
==
--- stable/11/Makefile.libcompatSat Oct  7 18:36:42 2017
(r324390)
+++ stable/11/Makefile.libcompatSat Oct  7 18:46:50 2017
(r324391)
@@ -161,10 +161,12 @@ build${libcompat}: .PHONY
 .endfor
${_+_}cd ${.CURDIR}; \
${LIBCOMPATWMAKE} -f Makefile.inc1 -DNO_FSCHG libraries
-.if ${libcompat} == "32" && !defined(NO_RTLD)
+.if ${libcompat} == "32"
 .for _t in obj all
+.if !defined(NO_RTLD)
${_+_}cd ${.CURDIR}/libexec/rtld-elf; PROG=ld-elf32.so.1 
${LIBCOMPATWMAKE} \
-DNO_FSCHG DIRPRFX=libexec/rtld-elf/ ${_t}
+.endif
${_+_}cd ${.CURDIR}/usr.bin/ldd; PROG=ldd32 ${LIBCOMPATWMAKE} \
DIRPRFX=usr.bin/ldd ${_t}
 .endfor
@@ -174,9 +176,11 @@ distribute${libcompat} install${libcompat}: .PHONY
 .for _dir in ${_LC_LIBDIRS.yes}
${_+_}cd ${.CURDIR}/${_dir}; ${LIBCOMPATIMAKE} 
${.TARGET:S/${libcompat}$//}
 .endfor
-.if ${libcompat} == "32" && !defined(NO_RTLD)
+.if ${libcompat} == "32"
+.if !defined(NO_RTLD)
${_+_}cd ${.CURDIR}/libexec/rtld-elf; \
PROG=ld-elf32.so.1 ${LIBCOMPATIMAKE} ${.TARGET:S/32$//}
+.endif
${_+_}cd ${.CURDIR}/usr.bin/ldd; PROG=ldd32 ${LIBCOMPATIMAKE} \
${.TARGET:S/32$//}
 .endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r324360 - in head/sys/boot/efi: include libefi loader

[Ngie Cooper (yaneurabeya)]

> On Oct 7, 2017, at 09:29, Guy Yur  wrote:
> 
> On 6 October 2017 at 15:21, Warner Losh  wrote:
>> Author: imp
>> Date: Fri Oct  6 12:21:46 2017
>> New Revision: 324360
>> URL: https://svnweb.freebsd.org/changeset/base/324360
>> 
>> Log:
>>  Encapsulate  ZFS preferences into efi_zfs_is_preferred
>> 
>>  Move the retrieval of the image information into loader's main instead
>>  of doing it in efizfs.c
>> 
>>  Differential Revision: https://reviews.freebsd.org/D12564
>>  Submitted by: Eric McCorkle
>> 
>> Modified:
>>  head/sys/boot/efi/include/efizfs.h
>>  head/sys/boot/efi/libefi/efizfs.c
>>  head/sys/boot/efi/loader/main.c
>> 
>> ...
> 
> Hi,
> 
> When setting WITHOUT_ZFS in src.conf the build fails with:
> 
> /usr/src/sys/boot/efi/loader/main.c:78:1: error: no previous prototype
> for function 'efi_zfs_is_preferred'
>  [-Werror,-Wmissing-prototypes]
> efi_zfs_is_preferred(EFI_HANDLE *h)
> ^
> 1 error generated.
> *** Error code 1
> 
> 
> The prototype is under #ifdef EFI_ZFS_BOOT guard but the function is not.

Fixed: r324388.
Thanks!
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r324388 - head/sys/boot/efi/loader

[Ngie Cooper]

Author: ngie
Date: Sat Oct  7 17:40:31 2017
New Revision: 324388
URL: https://svnweb.freebsd.org/changeset/base/324388

Log:
  Unbreak building efiboot with MK_ZFS == no
  
  Wrap `efi_zfs_is_preferred` with `#ifdef EFI_ZFS_BOOT`.
  
  Reported by:  Guy Yur 

Modified:
  head/sys/boot/efi/loader/main.c

Modified: head/sys/boot/efi/loader/main.c
==
--- head/sys/boot/efi/loader/main.c Sat Oct  7 17:32:39 2017
(r324387)
+++ head/sys/boot/efi/loader/main.c Sat Oct  7 17:40:31 2017
(r324388)
@@ -74,12 +74,13 @@ EFI_GUID inputid = SIMPLE_TEXT_INPUT_PROTOCOL;
 
 static EFI_LOADED_IMAGE *img;
 
+#ifdef EFI_ZFS_BOOT
 bool
 efi_zfs_is_preferred(EFI_HANDLE *h)
 {
 return (h == img->DeviceHandle);
 }
-
+#endif
 
 static int
 has_keyboard(void)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324284 - stable/10

[Ngie Cooper]

Author: ngie
Date: Wed Oct  4 16:35:58 2017
New Revision: 324284
URL: https://svnweb.freebsd.org/changeset/base/324284

Log:
  MFC r322951:
  
  Respect MK_TCSH with build-tools and native-xtools
  
  This helps reduce the WORLDTMP footprint slightly.
  
  Based on a patch I submitted 5 years ago to GNATS.
  
  PR:   174051
  Relnotes: yes (anyone who cross-builds with MK_TCSH=yes will run into
 build failures if the host doesn't have tcsh(1))
  Reminded by:  Fabian Keil 

Modified:
  stable/10/Makefile.inc1
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/Makefile.inc1
==
--- stable/10/Makefile.inc1 Wed Oct  4 16:33:22 2017(r324283)
+++ stable/10/Makefile.inc1 Wed Oct  4 16:35:58 2017(r324284)
@@ -1460,9 +1460,13 @@ _gcc_tools= gnu/usr.bin/cc/cc_tools
 _rescue= rescue/rescue
 .endif
 
+.if ${MK_TCSH} != "no"
+_tcsh=bin/csh
+.endif
+
 build-tools: .MAKE
 .for _tool in \
-bin/csh \
+${_tcsh} \
 bin/sh \
 ${_rescue} \
 ${LOCAL_TOOL_DIRS} \
@@ -1580,7 +1584,7 @@ native-xtools: .PHONY
 bin/cat \
 bin/chmod \
 bin/cp \
-bin/csh \
+${_tcsh} \
 bin/echo \
 bin/expr \
 bin/hostname \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324283 - stable/10

[Ngie Cooper]

Author: ngie
Date: Wed Oct  4 16:33:22 2017
New Revision: 324283
URL: https://svnweb.freebsd.org/changeset/base/324283

Log:
  Revert r324132
  
  I accidentally used the wrong commit message
  
  Reported by:  rgrimes

Modified:
  stable/10/Makefile.inc1
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/Makefile.inc1
==
--- stable/10/Makefile.inc1 Wed Oct  4 15:47:16 2017(r324282)
+++ stable/10/Makefile.inc1 Wed Oct  4 16:33:22 2017(r324283)
@@ -1460,14 +1460,9 @@ _gcc_tools= gnu/usr.bin/cc/cc_tools
 _rescue= rescue/rescue
 .endif
 
-.if ${MK_TCSH} != "no"
-_tcsh=bin/csh
-.endif
-
 build-tools: .MAKE
-
 .for _tool in \
-${_tcsh} \
+bin/csh \
 bin/sh \
 ${_rescue} \
 ${LOCAL_TOOL_DIRS} \
@@ -1585,7 +1580,7 @@ native-xtools: .PHONY
 bin/cat \
 bin/chmod \
 bin/cp \
-${_tcsh} \
+bin/csh \
 bin/echo \
 bin/expr \
 bin/hostname \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r324249 - head/lib/libc/net

[Ngie Cooper]

> On Oct 3, 2017, at 23:06, Cy Schubert  wrote:
> 
> Author: cy
> Date: Wed Oct  4 06:06:22 2017
> New Revision: 324249
> URL: https://svnweb.freebsd.org/changeset/base/324249
> 
> Log:
>  Clarify the wording describing the stayopen flag.
> 
>  MFC after:1 week
> 
> Modified:
>  head/lib/libc/net/gethostbyname.3
> 
> Modified: head/lib/libc/net/gethostbyname.3
> ==
> --- head/lib/libc/net/gethostbyname.3Wed Oct  4 03:39:54 2017(r324248)
> +++ head/lib/libc/net/gethostbyname.3Wed Oct  4 06:06:22 2017(r324249)
> @@ -28,7 +28,7 @@
> .\" From: @(#)gethostbyname.38.4 (Berkeley) 5/25/95
> .\" $FreeBSD$
> .\"
> -.Dd May 12, 2006
> +.Dd October 4, 2017
> .Dt GETHOSTBYNAME 3
> .Os
> .Sh NAME
> @@ -189,19 +189,18 @@ function
> may be used to request the use of a connected
> .Tn TCP
> socket for queries.
> -If the
> +Queries will by defaulat use
> +.Tn UDP
> +datagrams. If the

manlint: new sentences must start on new lines.
Cheers,
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r324257 - head/usr.sbin/mountd

[Ngie Cooper]

> On Oct 4, 2017, at 01:43, Emmanuel Vadot  wrote:
> 
> Author: manu
> Date: Wed Oct  4 08:43:56 2017
> New Revision: 324257
> URL: https://svnweb.freebsd.org/changeset/base/324257
> 
> Log:
>  mountd: Convert exportlist to SLIST
> 
>  Use SLIST from sys/queue.h instead of homebrew linked list for the 
> exportlist.
> 
>  Reviewed by:bapt, rmacklem
>  MFC after:1 week
>  Sponsored by:Gandi.net
>  Differential Revision:https://reviews.freebsd.org/D12502
> 
> Modified:
>  head/usr.sbin/mountd/mountd.c

...

> -ep2 = exphead;
> -epp = 
> +SLIST_INSERT_HEAD(, ep, entries);
> 
> -/*
> - * Insert in the list in alphabetical order.
> - */
> -while (ep2 && strcmp(ep2->ex_fsdir, ep->ex_fsdir) < 0) {
> -epp = >ex_next;
> -ep2 = ep2->ex_next;
> -}
> -if (ep2)
> -ep->ex_next = ep2;
> -*epp = ep;
>ep->ex_flag |= EX_LINKED;

The new code isn’t functionally equivalent to the old code: the mount list 
is no longer sorted on insert. Is that intentional?
Thanks,
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324143 - head

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 21:00:08 2017
New Revision: 324143
URL: https://svnweb.freebsd.org/changeset/base/324143

Log:
  Adjust r322633 to only apply to libexec/rtld-elf, and not usr.bin/ldd,
  when running build32/install32
  
  This unbreaks installing usr.bin/ldd as ldd32 when NO_RTLD is defined.
  
  MFC after:  1 week
  MFC with:   r322633

Modified:
  head/Makefile.libcompat

Modified: head/Makefile.libcompat
==
--- head/Makefile.libcompat Sat Sep 30 20:50:31 2017(r324142)
+++ head/Makefile.libcompat Sat Sep 30 21:00:08 2017(r324143)
@@ -179,10 +179,12 @@ build${libcompat}: .PHONY
 .endfor
${_+_}cd ${.CURDIR}; \
${LIBCOMPATWMAKE} -f Makefile.inc1 -DNO_FSCHG libraries
-.if ${libcompat} == "32" && !defined(NO_RTLD)
+.if ${libcompat} == "32"
 .for _t in ${_obj} all
+.if !defined(NO_RTLD)
${_+_}cd ${.CURDIR}/libexec/rtld-elf; PROG=ld-elf32.so.1 
${LIBCOMPATWMAKE} \
-DNO_FSCHG DIRPRFX=libexec/rtld-elf/ ${_t}
+.endif
${_+_}cd ${.CURDIR}/usr.bin/ldd; PROG=ldd32 ${LIBCOMPATWMAKE} \
DIRPRFX=usr.bin/ldd ${_t}
 .endfor
@@ -192,9 +194,11 @@ distribute${libcompat} install${libcompat}: .PHONY
 .for _dir in ${_LC_LIBDIRS.yes}
${_+_}cd ${.CURDIR}/${_dir}; ${LIBCOMPATIMAKE} 
${.TARGET:S/${libcompat}$//}
 .endfor
-.if ${libcompat} == "32" && !defined(NO_RTLD)
+.if ${libcompat} == "32"
+.if !defined(NO_RTLD)
${_+_}cd ${.CURDIR}/libexec/rtld-elf; \
PROG=ld-elf32.so.1 ${LIBCOMPATIMAKE} ${.TARGET:S/32$//}
+.endif
${_+_}cd ${.CURDIR}/usr.bin/ldd; PROG=ldd32 ${LIBCOMPATIMAKE} \
${.TARGET:S/32$//}
 .endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324142 - stable/10/usr.sbin/bootparamd/callbootd

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:50:31 2017
New Revision: 324142
URL: https://svnweb.freebsd.org/changeset/base/324142

Log:
  MFC r322635:
  
  Fix WARNS
  
  - Remove ad hoc inet_ntoa prototype declaration; it's already handled
by the included headers.
  - De-K the function prototypes for eachres_whoami(..),
eachres_getfile(..), and main(..).
  
  PR:   71667
  Tested with:  clang (5.0), gcc (4.2.1, 5)

Modified:
  stable/10/usr.sbin/bootparamd/callbootd/callbootd.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/usr.sbin/bootparamd/callbootd/callbootd.c
==
--- stable/10/usr.sbin/bootparamd/callbootd/callbootd.c Sat Sep 30 20:48:02 
2017(r324141)
+++ stable/10/usr.sbin/bootparamd/callbootd/callbootd.c Sat Sep 30 20:50:31 
2017(r324142)
@@ -32,15 +32,12 @@ int broadcast;
 char cln[MAX_MACHINE_NAME+1];
 char dmn[MAX_MACHINE_NAME+1];
 char path[MAX_PATH_LEN+1];
-extern char *inet_ntoa();
 static void usage(void);
 int printgetfile(bp_getfile_res *);
 int printwhoami(bp_whoami_res *);
 
-bool_t
-eachres_whoami(resultp, raddr)
-bp_whoami_res *resultp;
-struct sockaddr_in *raddr;
+static bool_t
+eachres_whoami(bp_whoami_res *resultp, struct sockaddr_in *raddr)
 {
   struct hostent *he;
 
@@ -51,10 +48,8 @@ struct sockaddr_in *raddr;
   return(0);
 }
 
-bool_t
-eachres_getfile(resultp, raddr)
-bp_getfile_res *resultp;
-struct sockaddr_in *raddr;
+static bool_t
+eachres_getfile(bp_getfile_res *resultp, struct sockaddr_in *raddr)
 {
   struct hostent *he;
 
@@ -67,9 +62,7 @@ struct sockaddr_in *raddr;
 
 
 int
-main(argc, argv)
-int argc;
-char **argv;
+main(int argc, char **argv)
 {
   char *server;
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324141 - stable/10/share/man/man5

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:48:02 2017
New Revision: 324141
URL: https://svnweb.freebsd.org/changeset/base/324141

Log:
  Regenerate src.conf(5) per r324140

Modified:
  stable/10/share/man/man5/src.conf.5

Modified: stable/10/share/man/man5/src.conf.5
==
--- stable/10/share/man/man5/src.conf.5 Sat Sep 30 20:46:34 2017
(r324140)
+++ stable/10/share/man/man5/src.conf.5 Sat Sep 30 20:48:02 2017
(r324141)
@@ -1,7 +1,7 @@
 .\" DO NOT EDIT-- this file is automatically generated.
 .\" from FreeBSD: stable/10/tools/build/options/makeman 318614 2017-05-22 
06:08:20Z ngie
 .\" $FreeBSD$
-.Dd August 5, 2017
+.Dd September 30, 2017
 .Dt SRC.CONF 5
 .Os
 .Sh NAME
@@ -860,6 +860,12 @@ entries.
 .It Va WITHOUT_NLS
 .\" from FreeBSD: stable/10/tools/build/options/WITHOUT_NLS 156932 2006-03-21 
07:50:50Z ru
 Set to not build NLS catalogs.
+When set, it also enforces the following options:
+.Pp
+.Bl -item -compact
+.It
+.Va WITHOUT_NLS_CATALOGS
+.El
 .It Va WITHOUT_NLS_CATALOGS
 .\" from FreeBSD: stable/10/tools/build/options/WITHOUT_NLS_CATALOGS 156932 
2006-03-21 07:50:50Z ru
 Set to not build NLS catalog support for
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324140 - stable/10/share/mk

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:46:34 2017
New Revision: 324140
URL: https://svnweb.freebsd.org/changeset/base/324140

Log:
  MFC r321952:
  
  Allowing MK_NLS_CATALOGS to be enabled if MK_NLS == no doesn't make a whole 
lot
  of sense. Anchor MK_NLS_CATALOGS being enabled off of MK_NLS.

Modified:
  stable/10/share/mk/bsd.own.mk
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/share/mk/bsd.own.mk
==
--- stable/10/share/mk/bsd.own.mk   Sat Sep 30 20:44:25 2017
(r324139)
+++ stable/10/share/mk/bsd.own.mk   Sat Sep 30 20:46:34 2017
(r324140)
@@ -569,6 +569,10 @@ MK_ATM:=   no
 MK_BLUETOOTH:= no
 .endif
 
+.if ${MK_NLS} == "no"
+MK_NLS_CATALOGS:= no
+.endif
+
 .if ${MK_OPENSSL} == "no"
 MK_OPENSSH:=   no
 MK_KERBEROS:=  no
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324139 - in stable/10: bin sbin usr.bin usr.sbin

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:44:25 2017
New Revision: 324139
URL: https://svnweb.freebsd.org/changeset/base/324139

Log:
  MFC r322951:
  
  Respect MK_TCSH with build-tools and native-xtools
  
  This helps reduce the WORLDTMP footprint slightly.
  
  Based on a patch I submitted 5 years ago to GNATS.
  
  PR:   174051
  Relnotes: yes (anyone who cross-builds with MK_TCSH=yes will run into
 build failures if the host doesn't have tcsh(1))
  Reminded by:  Fabian Keil 

Modified:
  stable/10/bin/Makefile
  stable/10/sbin/Makefile
  stable/10/usr.bin/Makefile
  stable/10/usr.sbin/Makefile
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/bin/Makefile
==
--- stable/10/bin/Makefile  Sat Sep 30 20:31:37 2017(r324138)
+++ stable/10/bin/Makefile  Sat Sep 30 20:44:25 2017(r324139)
@@ -58,8 +58,6 @@ SUBDIR+=  tests
 
 .include 
 
-SUBDIR:=   ${SUBDIR:O}
-
 SUBDIR_PARALLEL=
 
 .include 

Modified: stable/10/sbin/Makefile
==
--- stable/10/sbin/Makefile Sat Sep 30 20:31:37 2017(r324138)
+++ stable/10/sbin/Makefile Sat Sep 30 20:44:25 2017(r324139)
@@ -130,8 +130,6 @@ SUBDIR+=tests
 
 .include 
 
-SUBDIR:=   ${SUBDIR:O}
-
 SUBDIR_PARALLEL=
 
 .include 

Modified: stable/10/usr.bin/Makefile
==
--- stable/10/usr.bin/Makefile  Sat Sep 30 20:31:37 2017(r324138)
+++ stable/10/usr.bin/Makefile  Sat Sep 30 20:44:25 2017(r324139)
@@ -415,8 +415,6 @@ SUBDIR+=mkesdb_static
 
 .include 
 
-SUBDIR:=   ${SUBDIR:O}
-
 SUBDIR_PARALLEL=
 
 .include 

Modified: stable/10/usr.sbin/Makefile
==
--- stable/10/usr.sbin/Makefile Sat Sep 30 20:31:37 2017(r324138)
+++ stable/10/usr.sbin/Makefile Sat Sep 30 20:44:25 2017(r324139)
@@ -369,8 +369,6 @@ SUBDIR+=wpa
 
 .include 
 
-SUBDIR:=   ${SUBDIR:O}
-
 SUBDIR_PARALLEL=
 
 .include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324138 - in stable/11/etc: . mtree

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:31:37 2017
New Revision: 324138
URL: https://svnweb.freebsd.org/changeset/base/324138

Log:
  MFC r321444,r321446:
  
  r321444:
  
  Remove ${MTREE} and leverage etc/mtree/Makefile instead with
  "make distribution".
  
  This also fixes the fact that BSD.debug.dist was being installed if/when
  ${MK_DEBUG_FILES} != "no" before this commit.
  
  r321446:
  
  Unconditionally install etc/mtree/BSD.debug.dist again
  
  r279248 unconditionally installed BSD.debug.dist for ease-of-developer-use.
  Restore the previous behavior.
  
  While here, add a comment to note that this is intentional to avoid accidental
  future removal.
  
  MFC with: r321444

Modified:
  stable/11/etc/Makefile
  stable/11/etc/mtree/Makefile
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/etc/Makefile
==
--- stable/11/etc/Makefile  Sat Sep 30 20:31:27 2017(r324137)
+++ stable/11/etc/Makefile  Sat Sep 30 20:31:37 2017(r324138)
@@ -152,20 +152,6 @@ BIN1+= regdomain.xml
 # -rwxr-xr-x root:wheel, for the new cron root:wheel
 BIN2=  netstart pccard_ether rc.suspend rc.resume
 
-MTREE= BSD.debug.dist BSD.include.dist BSD.root.dist BSD.usr.dist BSD.var.dist
-.if ${MK_LIB32} != "no"
-MTREE+=BSD.lib32.dist
-.endif
-.if ${MK_LIBSOFT} != "no"
-MTREE+=BSD.libsoft.dist
-.endif
-.if ${MK_TESTS} != "no"
-MTREE+=BSD.tests.dist
-.endif
-.if ${MK_SENDMAIL} != "no"
-MTREE+=BSD.sendmail.dist
-.endif
-
 PPPCNF=ppp.conf
 
 .if ${MK_SENDMAIL} == "no"
@@ -253,6 +239,7 @@ distribution:
${_+_}cd ${.CURDIR}/defaults; ${MAKE} install
${_+_}cd ${.CURDIR}/devd; ${MAKE} install
${_+_}cd ${.CURDIR}/gss; ${MAKE} install
+   ${_+_}cd ${.CURDIR}/mtree; ${MAKE} install
${_+_}cd ${.CURDIR}/newsyslog.conf.d; ${MAKE} install
 .if ${MK_NTP} != "no"
${_+_}cd ${.CURDIR}/ntp; ${MAKE} install
@@ -306,8 +293,6 @@ distribution:
rm -f ${DESTDIR}/.cshrc; \
ln ${DESTDIR}/root/.cshrc ${DESTDIR}/.cshrc
 .endif
-   cd ${.CURDIR}/mtree; ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 444 \
-   ${MTREE} ${DESTDIR}/etc/mtree
 .if ${MK_MAIL} != "no"
cd ${.CURDIR}/mail; ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \
${ETCMAIL} ${DESTDIR}/etc/mail

Modified: stable/11/etc/mtree/Makefile
==
--- stable/11/etc/mtree/MakefileSat Sep 30 20:31:27 2017
(r324137)
+++ stable/11/etc/mtree/MakefileSat Sep 30 20:31:37 2017
(r324138)
@@ -2,7 +2,9 @@
 
 .include 
 
-FILES= ${_BSD.debug.dist} \
+# NOTE: BSD.debug.dist is unconditionally installed for developer ease-of-use.
+FILES= \
+   BSD.debug.dist \
BSD.include.dist \
BSD.root.dist \
${_BSD.lib32.dist} \
@@ -12,9 +14,6 @@ FILES=${_BSD.debug.dist} \
BSD.usr.dist \
BSD.var.dist
 
-.if ${MK_DEBUG_FILES} != "no"
-_BSD.debug.dist=   BSD.debug.dist
-.endif
 .if ${MK_GROFF} != "no"
 _BSD.groff.dist=   BSD.groff.dist
 .endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324137 - stable/10/crypto/openssh

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:31:27 2017
New Revision: 324137
URL: https://svnweb.freebsd.org/changeset/base/324137

Log:
  MFC r314601:
  r314601 (by des):
  
  Re-apply part of r311585 which was inadvertantly reverted in the upgrade
  to 7.3p1.  The other part (which adds -DLIBWRAP to sshd's CFLAGS) is
  still in place.

Modified:
  stable/10/crypto/openssh/config.h
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/crypto/openssh/config.h
==
--- stable/10/crypto/openssh/config.h   Sat Sep 30 20:28:50 2017
(r324136)
+++ stable/10/crypto/openssh/config.h   Sat Sep 30 20:31:27 2017
(r324137)
@@ -1438,7 +1438,7 @@
 /* #undef LASTLOG_WRITE_PUTUTXLINE */
 
 /* Define if you want TCP Wrappers support */
-#define LIBWRAP 1
+/* #undef LIBWRAP */
 
 /* Define to whatever link() returns for "not supported" if it doesn't return
EOPNOTSUPP. */
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324134 - stable/11/share/mk

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:07:54 2017
New Revision: 324134
URL: https://svnweb.freebsd.org/changeset/base/324134

Log:
  MFC r322441:
  
  Delete trailing whitespace

Modified:
  stable/11/share/mk/bsd.cpu.mk
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/share/mk/bsd.cpu.mk
==
--- stable/11/share/mk/bsd.cpu.mk   Sat Sep 30 20:06:44 2017
(r324133)
+++ stable/11/share/mk/bsd.cpu.mk   Sat Sep 30 20:07:54 2017
(r324134)
@@ -358,7 +358,7 @@ CFLAGS_NO_SIMD= -mno-mmx -mno-sse
 .endif
 CFLAGS_NO_SIMD += ${CFLAGS_NO_SIMD.${COMPILER_TYPE}}
 
-# Add in any architecture-specific CFLAGS.  
+# Add in any architecture-specific CFLAGS.
 # These come from make.conf or the command line or the environment.
 CFLAGS += ${CFLAGS.${MACHINE_ARCH}}
 CXXFLAGS += ${CXXFLAGS.${MACHINE_ARCH}}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324135 - stable/10/share/mk

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:07:57 2017
New Revision: 324135
URL: https://svnweb.freebsd.org/changeset/base/324135

Log:
  MFC r322441:
  
  Delete trailing whitespace

Modified:
  stable/10/share/mk/bsd.cpu.mk
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/share/mk/bsd.cpu.mk
==
--- stable/10/share/mk/bsd.cpu.mk   Sat Sep 30 20:07:54 2017
(r324134)
+++ stable/10/share/mk/bsd.cpu.mk   Sat Sep 30 20:07:57 2017
(r324135)
@@ -288,7 +288,7 @@ CFLAGS_NO_SIMD= -mno-mmx -mno-sse
 .endif
 CFLAGS_NO_SIMD += ${CFLAGS_NO_SIMD.${COMPILER_TYPE}}
 
-# Add in any architecture-specific CFLAGS.  
+# Add in any architecture-specific CFLAGS.
 # These come from make.conf or the command line or the environment.
 CFLAGS += ${CFLAGS.${MACHINE_ARCH}}
 CXXFLAGS += ${CXXFLAGS.${MACHINE_ARCH}}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324133 - stable/11

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:06:44 2017
New Revision: 324133
URL: https://svnweb.freebsd.org/changeset/base/324133

Log:
  MFC r322951:
  
  Respect MK_TCSH with build-tools and native-xtools
  
  This helps reduce the WORLDTMP footprint slightly.
  
  Based on a patch I submitted 5 years ago to GNATS.
  
  PR:   174051
  Relnotes: yes (anyone who cross-builds with MK_TCSH=yes will run into
 build failures if the host doesn't have tcsh(1))
  Reminded by:  Fabian Keil 

Modified:
  stable/11/Makefile.inc1
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/Makefile.inc1
==
--- stable/11/Makefile.inc1 Sat Sep 30 20:06:36 2017(r324132)
+++ stable/11/Makefile.inc1 Sat Sep 30 20:06:44 2017(r324133)
@@ -1780,8 +1780,12 @@ _gcc_tools= gnu/usr.bin/cc/cc_tools
 _rescue=rescue/rescue
 .endif
 
+.if ${MK_TCSH} != "no"
+_tcsh=bin/csh
+.endif
+
 .for _tool in \
-bin/csh \
+${_tcsh} \
 bin/sh \
 ${LOCAL_TOOL_DIRS} \
 lib/ncurses/ncurses \
@@ -1938,7 +1942,7 @@ native-xtools: .PHONY
 bin/cat \
 bin/chmod \
 bin/cp \
-bin/csh \
+${_tcsh} \
 bin/echo \
 bin/expr \
 bin/hostname \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r324132 - stable/10

[Ngie Cooper]

Author: ngie
Date: Sat Sep 30 20:06:36 2017
New Revision: 324132
URL: https://svnweb.freebsd.org/changeset/base/324132

Log:
  MFC r321845:
  
  Standardize on SRCTOP instead of .CURDIR-relative paths

Modified:
  stable/10/Makefile.inc1
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/Makefile.inc1
==
--- stable/10/Makefile.inc1 Sat Sep 30 19:54:30 2017(r324131)
+++ stable/10/Makefile.inc1 Sat Sep 30 20:06:36 2017(r324132)
@@ -1460,9 +1460,14 @@ _gcc_tools= gnu/usr.bin/cc/cc_tools
 _rescue= rescue/rescue
 .endif
 
+.if ${MK_TCSH} != "no"
+_tcsh=bin/csh
+.endif
+
 build-tools: .MAKE
+
 .for _tool in \
-bin/csh \
+${_tcsh} \
 bin/sh \
 ${_rescue} \
 ${LOCAL_TOOL_DIRS} \
@@ -1580,7 +1585,7 @@ native-xtools: .PHONY
 bin/cat \
 bin/chmod \
 bin/cp \
-bin/csh \
+${_tcsh} \
 bin/echo \
 bin/expr \
 bin/hostname \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r324109 - in head: sys/contrib/dev/acpica sys/contrib/dev/acpica/common sys/contrib/dev/acpica/compiler sys/contrib/dev/acpica/components/dispatcher sys/contrib/dev/acpica/components/h

[Ngie Cooper (yaneurabeya)]

> On Sep 30, 2017, at 09:16, Konstantin Belousov  wrote:

Given the number of panic reports, could the commit be reverted and a 
fix be submitted later so others can develop on ^/head?
Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r323960 - head/tests/sys/opencrypto

[Ngie Cooper]

Author: ngie
Date: Sun Sep 24 00:14:48 2017
New Revision: 323960
URL: https://svnweb.freebsd.org/changeset/base/323960

Log:
  Convert some idioms over to py3k-compatible idioms
  
  - Import print_function from __future__ and use print(..) instead of `print 
..`.
  - Use repr instead of backticks when the object needs to be dumped, unless
print(..) can do it lazily. Use str instead of backticks as appropriate
for simplification reasons.
  
  This doesn't fully convert these modules over py3k. It just gets over some of
  the trivial compatibility hurdles.

Modified:
  head/tests/sys/opencrypto/cryptodev.py
  head/tests/sys/opencrypto/cryptotest.py

Modified: head/tests/sys/opencrypto/cryptodev.py
==
--- head/tests/sys/opencrypto/cryptodev.py  Sun Sep 24 00:07:18 2017
(r323959)
+++ head/tests/sys/opencrypto/cryptodev.py  Sun Sep 24 00:14:48 2017
(r323960)
@@ -30,6 +30,7 @@
 # $FreeBSD$
 #
 
+from __future__ import print_function
 import array
 import dpkt
 from fcntl import ioctl
@@ -174,9 +175,9 @@ class Crypto:
if not cipher and not mac:
raise ValueError('one of cipher or mac MUST be 
specified.')
ses.crid = crid
-   #print `ses`
+   #print(ses)
s = array.array('B', ses.pack_hdr())
-   #print `s`
+   #print(s)
ioctl(_cryptodev, CIOCGSESSION2, s, 1)
ses.unpack(s)
 
@@ -206,7 +207,7 @@ class Crypto:
ivbuf = array.array('B', iv)
cop.iv = ivbuf.buffer_info()[0]
 
-   #print 'cop:', `cop`
+   #print('cop:', cop)
ioctl(_cryptodev, CIOCCRYPT, str(cop))
 
s = s.tostring()
@@ -234,7 +235,8 @@ class Crypto:
if tag is None:
tag = array.array('B', [0] * self._maclen)
else:
-   assert len(tag) == self._maclen, `len(tag), 
self._maclen`
+   assert len(tag) == self._maclen, \
+'%d != %d' % (len(tag), self._maclen)
tag = array.array('B', tag)
 
caead.tag = tag.buffer_info()[0]
@@ -288,8 +290,8 @@ class Crypto:
 
signal.signal(signal.SIGALRM, oldalarm)
 
-   print 'time:', end - start
-   print 'perf MB/sec:', (reps * size) / (end - start) / 1024 / 
1024
+   print('time:', end - start)
+   print('perf MB/sec:', (reps * size) / (end - start) / 1024 / 
1024)
 
def encrypt(self, data, iv, aad=None):
if aad is None:
@@ -332,7 +334,7 @@ class KATParser:
if i[0] == '[':
yield i[1:].split(']', 1)[0], self.fielditer()
else:
-   raise ValueError('unknown line: %s' % `i`)
+   raise ValueError('unknown line: %r' % repr(i))
 
def eatblanks(self):
while True:
@@ -362,12 +364,12 @@ class KATParser:
if line == 'FAIL':
f, v = 'FAIL', ''
else:
-   print 'line:', `line`
+   print('line:', repr(line))
raise
v = v.strip()
 
if f in values:
-   raise ValueError('already present: %s' 
% `f`)
+   raise ValueError('already present: %r' 
% repr(f))
values[f] = v
line = self.fp.readline().strip()
if not line:
@@ -377,7 +379,7 @@ class KATParser:
remain = self.fields.copy() - set(values.keys())
# XXX - special case GCM decrypt
if remain and not ('FAIL' in values and 'PT' in remain):
-   raise ValueError('not all fields found: 
%s' % `remain`)
+   raise ValueError('not all fields found: %r' % 
repr(remain))
 
yield values
 
@@ -388,22 +390,22 @@ if __name__ == '__main__':
if True:
try:
crid = Crypto.findcrid('aesni0')
-   print 'aesni:', crid
+   print('aesni:', crid)
except IOError:
-   print 'aesni0 not found'
+   print('aesni0 not found')
 
for i in xrange(10):
try:
name = Crypto.getcridname(i)
-   print '%2d: %s' % (i, `name`)
+ 

Re: svn commit: r323935 - head/sys/kern

[Ngie Cooper (yaneurabeya)]

> On Sep 22, 2017, at 13:01, Conrad Meyer  wrote:
> 
> Author: cem
> Date: Fri Sep 22 20:01:12 2017
> New Revision: 323935
> URL: https://svnweb.freebsd.org/changeset/base/323935
> 
> Log:
>  ddb(4): Add 'show badstacks' command to show witness badstacks
> 
>  Add a DDB command that mirrors sysctl debug.witness.badstacks.
> 
>  Reported by: rstone
>  Reviewed by: rstone
>  Sponsored by:Dell EMC Isilon
>  Differential Revision:   https://reviews.freebsd.org/D12468

This broke GENERIC:

--- subr_witness.o ---
/usr/src/sys/kern/subr_witness.c:2577:4: error: use of undeclared identifier 
'req'
req->oldidx = 0;
^
/usr/src/sys/kern/subr_witness.c:2603:5: error: use of undeclared identifier 
'req'
req->oldidx = 0;
^
/usr/src/sys/kern/subr_witness.c:2662:3: error: use of undeclared identifier 
'req'
req->oldidx = 0;
^


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r323899 - head/tests/sys/opencrypto

[Ngie Cooper (yaneurabeya)]

> On Sep 21, 2017, at 21:41, Conrad Meyer  wrote:
> 
> Author: cem
> Date: Fri Sep 22 04:41:48 2017
> New Revision: 323899
> URL: https://svnweb.freebsd.org/changeset/base/323899
> 
> Log:
>  cryptotest.py: Like r323869, skip SHA HMAC tests on non-SHA drivers
> 
>  Sponsored by:Dell EMC Isilon
> 
> Modified:
>  head/tests/sys/opencrypto/cryptotest.py
> 
> Modified: head/tests/sys/opencrypto/cryptotest.py
> ==
> --- head/tests/sys/opencrypto/cryptotest.py   Fri Sep 22 04:25:44 2017
> (r323898)
> +++ head/tests/sys/opencrypto/cryptotest.py   Fri Sep 22 04:41:48 2017
> (r323899)
> @@ -237,6 +237,7 @@ def GenTestCase(cname):
>   #for i in iglob('SHA1*'):
>   #   self.runSHA(i)
> 
> + @unittest.skipIf(cname not in shamodules, 'skipping SHA on %s' 
> % `name`)

Backticks for stringily’ing things isn’t py3k compatible, FYI.
-Ngie



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r323770 - in stable/11/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf

[Ngie Cooper (yaneurabeya)]

> On Sep 19, 2017, at 09:51, Josh Paetzel  wrote:
> 
> Author: jpaetzel
> Date: Tue Sep 19 16:51:51 2017
> New Revision: 323770
> URL: https://svnweb.freebsd.org/changeset/base/323770
> 
> Log:
>  MFC: 323068
> 
>Allow kldload tcpmd5

Wasn’t this reverted on ^/head ?
Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r323635 - in head/sys: dev/bnxt dev/e1000 kern net sys

[Ngie Cooper (yaneurabeya)]

> On Sep 15, 2017, at 19:41, Stephen Hurd  wrote:
> 
> Author: shurd
> Date: Sat Sep 16 02:41:38 2017
> New Revision: 323635
> URL: https://svnweb.freebsd.org/changeset/base/323635
> 
> Log:
>  Revert r323516 (iflib rollup)
> 
>  This was really too big of a commit even if everything worked, but there
>  are multiple new issues introduced in the one huge commit, so it's not
>  worth keeping this until it's fixed.
> 
>  I'll work on splitting this up into logical chunks and introduce them one
>  at a time over the next week or two.

Thank you,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys

[Ngie Cooper]

> On Sep 12, 2017, at 18:18, Stephen Hurd  wrote:
> 
> Author: shurd
> Date: Wed Sep 13 01:18:42 2017
> New Revision: 323516
> URL: https://svnweb.freebsd.org/changeset/base/323516
> 
> Log:
>  Roll up iflib commits from github.  This pulls in most of the work done
>  by Matt Macy as well as other changes which he has accepted via pull
>  request to his github repo at https://github.com/mattmacy/networking/
> 
>  This should bring -CURRENT and the github repo into close enough sync to
>  allow small feature branches rather than a large chain of interdependant
>  patches being developed out of tree.  The reset of the synchronization
>  should be able to be completed on github by splitting the remaining
>  changes that are not yet ready into short feature branches for later
>  review as smaller commits.
> 
>  Here is a summary of changes included in this patch:
> 
>  1)  More checks when INVARIANTS are enabled for eariler problem
>  detection
>  2)  Group Task Queue cleanups
>  - Fix use of duplicate shortdesc for gtaskqueue malloc type.
>Some interfaces such as memguard(9) use the short description to
>identify malloc types, so duplicates should be avoided.
>  3)  Allow gtaskqueues to use ithreads in addition to taskqueues
>  - In some cases, this can improve performance
>  4)  Better logging when taskqgroup_attach*() fails to set interrupt
>  affinity.
>  5)  Do not start gtaskqueues until they're needed
>  6)  Have mp_ring enqueue function enter the ABDICATED rather than BUSY
>  state.  This moves the TX to the gtaskq and allows processing to
>  continue faster as well as make TX batching more likely.
>  7)  Add an ift_txd_errata function to struct if_txrx.  This allows
>  drivers to inspect/modify mbufs before transmission.
>  8)  Add a new IFLIB_NEED_ZERO_CSUM for drivers to indicate they need
>  checksums zeroed for checksum offload to work.  This avoids modifying
>  packet data in the TX path when possible.
>  9)  Use ithreads for iflib I/O instead of taskqueues
>  10) Clean up ioctl and support async ioctl functions
>  11) Prefetch two cachlines from each mbuf instead of one up to 128B.  We
>  often need to parse packet header info beyond 64B.
>  12) Fix potential memory corruption due to fence post error in
>  bit_nclear() usage.
>  13) Improved hang detection and handling
>  14) If the packet is smaller than MTU, disable the TSO flags.
>  This avoids extra packet parsing when not needed.
>  15) Move TCP header parsing inside the IS_TSO?() test.
>  This avoids extra packet parsing when not needed.
>  16) Pass chains of mbufs that are not consumed by lro to if_input()
>  rather call if_input() for each mbuf.
>  17) Re-arrange packet header loads to get as much work as possible done
>  before a cache stall.
>  18) Lock the context when calling IFDI_ATTACH_PRE()/IFDI_ATTACH_POST()/
>  IFDI_DETACH();
>  19) Attempt to distribute RX/TX tasks across cores more sensibly,
>  especially when RX and TX share an interrupt.  RX will attempt to
>  take the first threads on a core, and TX will attempt to take
>  successive threads.
>  20) Allow iflib_softirq_alloc_generic() to request affinity to the same
>  cpus an interrupt has affinity with.  This allows TX queues to
>  ensure they are serviced by the socket the device is on.
>  21) Add new iflib sysctls to net.iflib:
>  - timer_int - interval at which to run per-queue timers in ticks
>  - force_busdma
>  22) Add new per-device iflib sysctls to dev.X.Y.iflib
>  - rx_budget allows tuning the batch size on the RX path
>  - watchdog_events Count of watchdog events seen since load
>  23) Fix error where netmap_rxq_init() could get called before
>  IFDI_INIT()
>  24) e1000: Fixed version of r323008: post-cold sleep instead of DELAY
>  when waiting for firmware
>  - After interrupts are enabled, convert all waits to sleeps
>  - Eliminates e1000 software/firmware synchronization busy waits after
>startup
>  25) e1000: Remove special case for budget=1 in em_txrx.c
>  - Premature optimization which may actually be incorrect with
>multi-segment packets
>  26) e1000: Split out TX interrupt rather than share an interrupt for
>  RX and TX.
>  - Allows better performance by keeping RX and TX paths separate
>  27) e1000: Separate igb from em code where suitable
>  Much easier to understand separate functions and "if (is_igb)" than
>  previous tests like "if (reg_icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC))"
> 
>  #blamebruno
> 
>  Reviewed by:sbruno
>  Approved by:sbruno (mentor)
>  Sponsored by:Limelight Networks
>  Differential Revision:https://reviews.freebsd.org/D12235

*gasps at the LoC count and number of changed drivers*

Could someone please better break this up in the future..?

Thank you,
-Ngie
___
svn-src-all@freebsd.org 

Re: svn commit: r323508 - head/usr.sbin/bsdinstall/partedit

[Ngie Cooper]

> On Sep 12, 2017, at 15:19, Ravi Pokala  wrote:
> 
> Author: rpokala
> Date: Tue Sep 12 22:19:21 2017
> New Revision: 323508
> URL: https://svnweb.freebsd.org/changeset/base/323508
> 
> Log:
>  When doing a non-interactive installation, don't display an interactive
>  warning about a filesystem which doesn't have a mountpoint. Presumably, the
>  person who wrote the install script knew what they were doing.

This seems very counterintuitive. It should fail citing the error, not 
prompt. This only mutes the prompt.
Thanks,
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r323515 - stable/11/lib/msun/tests

[Ngie Cooper]

> On Sep 12, 2017, at 17:51, Ryan Libby  wrote:
> 
> Author: rlibby
> Date: Wed Sep 13 00:51:36 2017
> New Revision: 323515
> URL: https://svnweb.freebsd.org/changeset/base/323515
> 
> Log:
>  MFC r321483 (by ngie):
> 
>Mask issues with duplicate definitions for __fnstcw, __fldenv, and
>__fldcw on i386 by ignoring -Wmacro-redefined.
> 
>This is a bandaid until the code is fixed and will be reverted before
>MFC.
> 
>  This unbreaks the tinderbox build for i386.  Although the head commit
>  log suggests this would not be MFC'd, it nevertheless is being MFC'd as
>  the commit that enabled the warnings that this silences was MFC'd
>  without any proper fix for the warnings (head r321455, stable/11
>  r323299).

Sorry for the breakage and for fixing this mistake. I forgot to MFC this (I 
usually set the MFC timers properly, but apparently I didn't this time) :/..
Cheers,
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r323365 - in head: cddl/lib/libzpool gnu/usr.bin/binutils/libbfd usr.bin/svn/lib/libsvn_client

[Ngie Cooper (yaneurabeya)]

> On Sep 9, 2017, at 14:51, Konstantin Belousov  wrote:

…

> Then, why peigen.c was left in the SRCS ?

I’m not sure, but you might have thought peigen.c and pepigen.c were the same 
file. If so, they’re not — they have slightly different spelling.
HTH,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r323365 - in head: cddl/lib/libzpool gnu/usr.bin/binutils/libbfd usr.bin/svn/lib/libsvn_client

[Ngie Cooper (yaneurabeya)]

> On Sep 9, 2017, at 11:35, Konstantin Belousov  wrote:
> 
> On Sat, Sep 09, 2017 at 01:18:33PM +, Jonathan Anderson wrote:
>> Author: jonathan
>> Date: Sat Sep  9 13:18:32 2017
>> New Revision: 323365
>> URL: https://svnweb.freebsd.org/changeset/base/323365
>> 
>> Log:
>>  Remove redundant source and object files.
> 
>> Modified: head/gnu/usr.bin/binutils/libbfd/Makefile.amd64
>> ==
>> --- head/gnu/usr.bin/binutils/libbfd/Makefile.amd64  Sat Sep  9 12:50:12 
>> 2017(r323364)
>> +++ head/gnu/usr.bin/binutils/libbfd/Makefile.amd64  Sat Sep  9 13:18:32 
>> 2017(r323365)
>> @@ -9,7 +9,6 @@ DEFAULT_VECTOR=  bfd_elf64_x86_64_freebsd_vec
>> 
>> SRCS+=   elf64-x86-64.c \
>>  efi-app-x86_64.c \
>> -efi-app-ia32.c \
>>  elf64.c \
>>  elf64-gen.c \
>>  elf64-target.h \
> Why did you claimed that x86 efi binfmt is  redundant ?

It’s redundant because of how the Makefile gets .include’d (amd64 
requires i386’s Makefile).
Cheers,
-Ngie

$ grep -r efi-app gnu/usr.bin/binutils/libbfd/
gnu/usr.bin/binutils/libbfd/Makefile.amd64: efi-app-x86_64.c \
gnu/usr.bin/binutils/libbfd/Makefile.amd64: efi-app-ia32.c \
gnu/usr.bin/binutils/libbfd/Makefile.i386:  efi-app-ia32.c \
$ grep include gnu/usr.bin/binutils/libbfd/Makefile.amd64
.include "${.CURDIR}/Makefile.i386”


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r323348 - head/usr.bin/tail/tests

[Ngie Cooper]

Author: ngie
Date: Sat Sep  9 06:24:21 2017
New Revision: 323348
URL: https://svnweb.freebsd.org/changeset/base/323348

Log:
  Unbreak :broken_pipe
  
  - Capture exit code in pipeline and test in output.
  - Drop awk use in favor of `sleep 2`. This helps guarantee the EPIPE
behavior without the potential race.

Modified:
  head/usr.bin/tail/tests/tail_test.sh

Modified: head/usr.bin/tail/tests/tail_test.sh
==
--- head/usr.bin/tail/tests/tail_test.shSat Sep  9 06:04:05 2017
(r323347)
+++ head/usr.bin/tail/tests/tail_test.shSat Sep  9 06:24:21 2017
(r323348)
@@ -222,10 +222,10 @@ broken_pipe_head()
 }
 broken_pipe_body()
 {
-   atf_expect_fail "Can't seem to get testcase to work in test 
environment.  Reproduces easily in interactive shell."
-
atf_check -o save:ints seq -f '%128g' 1 1000
-   atf_check -s exit:1 -o ignore -e "inline:tail: stdout" tail -n 856 ints 
| awk '{ exit }'
+   atf_check -s ignore \
+   -e "inline:tail: stdout\nexit code: 1\n" \
+   -x '(tail -n 856 ints; echo exit code: $? >&2) | sleep 2'
 }
 
 
@@ -243,5 +243,5 @@ atf_init_test_cases()
atf_add_test_case longfile_rc135782
atf_add_test_case longfile_rc145782_longlines
atf_add_test_case longfile_rn2500
-   #atf_add_test_case broken_pipe
+   atf_add_test_case broken_pipe
 }
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r323345 - head/usr.bin/tail/tests

[Ngie Cooper]

Author: ngie
Date: Sat Sep  9 05:50:47 2017
New Revision: 323345
URL: https://svnweb.freebsd.org/changeset/base/323345

Log:
  Check result of seq call and save output via atf_check -o
  
  This ensures that seq outputting to ints will not fail as silently if there's
  an error.

Modified:
  head/usr.bin/tail/tests/tail_test.sh

Modified: head/usr.bin/tail/tests/tail_test.sh
==
--- head/usr.bin/tail/tests/tail_test.shSat Sep  9 05:42:23 2017
(r323344)
+++ head/usr.bin/tail/tests/tail_test.shSat Sep  9 05:50:47 2017
(r323345)
@@ -224,7 +224,7 @@ broken_pipe_body()
 {
atf_expect_fail "Can't seem to get testcase to work in test 
environment.  Reproduces easily in interactive shell."
 
-   seq -f '%128g' 1 1000 > ints
+   atf_check -o save:ints seq -f '%128g' 1 1000
atf_check -s exit:1 -o ignore -e "inline:tail: stdout" tail -n 856 ints 
| awk '{ exit }'
 }
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r323329 - head/sys/sys

[Ngie Cooper (yaneurabeya)]

> On Sep 8, 2017, at 13:09, Mateusz Guzik  wrote:
> 
> Author: mjg
> Date: Fri Sep  8 20:09:14 2017
> New Revision: 323329
> URL: https://svnweb.freebsd.org/changeset/base/323329
> 
> Log:
>  Allow __builtin_memset instead of bzero for small buffers of known size
> 
>  In particular this eliminates function calls and related register 
> save/restore
>  when only few writes would suffice.
> 
>  Example speed up can be seen in a fstat microbenchmark on AMD Ryzen cpus, 
> where
>  the throughput went up by ~4.5%.
> 
>  Thanks to cem@ for benchmarking and reviewing the patch.

This change breaks all platforms that use gcc. If it’s not reverted in the next 
3 hours, I’ll revert it.

Please fix ASAP if possible: 
https://ci.freebsd.org/job/FreeBSD-head-riscv64-build/3668/console .

Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

svn commit: r323304 - stable/11/share/man/man5

[Ngie Cooper]

Author: ngie
Date: Fri Sep  8 04:51:16 2017
New Revision: 323304
URL: https://svnweb.freebsd.org/changeset/base/323304

Log:
  Regenerate src.conf(5) based on recent changes to src.opts.mk, etc.

Modified:
  stable/11/share/man/man5/src.conf.5

Modified: stable/11/share/man/man5/src.conf.5
==
--- stable/11/share/man/man5/src.conf.5 Fri Sep  8 04:48:25 2017
(r323303)
+++ stable/11/share/man/man5/src.conf.5 Fri Sep  8 04:51:16 2017
(r323304)
@@ -1,6 +1,6 @@
 .\" DO NOT EDIT-- this file is generated by tools/build/options/makeman.
 .\" $FreeBSD$
-.Dd August 16, 2017
+.Dd September 7, 2017
 .Dt SRC.CONF 5
 .Os
 .Sh NAME
@@ -1150,6 +1150,12 @@ and remove
 entries.
 .It Va WITHOUT_NLS
 Set to not build NLS catalogs.
+When set, it enforces these options:
+.Pp
+.Bl -item -compact
+.It
+.Va WITHOUT_NLS_CATALOGS
+.El
 .It Va WITHOUT_NLS_CATALOGS
 Set to not build NLS catalog support for
 .Xr csh 1 .
@@ -1237,6 +1243,42 @@ and related files.
 Set to not build
 .Xr ppp 8
 and related programs.
+.It Va WITHOUT_PROFILE
+Set to not build profiled libraries for use with
+.Xr gprof 8 .
+.Pp
+This is a default setting on
+mips/mips64el and mips/mips64.
+.It Va WITH_PROFILE
+Set to build profiled libraries for use with
+.Xr gprof 8 .
+.Pp
+This is a default setting on
+amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64, i386/i386, 
mips/mipsel, mips/mips, mips/mipsn32, pc98/i386, powerpc/powerpc, 
powerpc/powerpc64 and sparc64/sparc64.
+.It Va WITHOUT_PROFILE
+Set to not build profiled libraries for use with
+.Xr gprof 8 .
+.Pp
+This is a default setting on
+mips/mips64el.
+.It Va WITH_PROFILE
+Set to build profiled libraries for use with
+.Xr gprof 8 .
+.Pp
+This is a default setting on
+amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64, i386/i386, 
mips/mipsel, mips/mips, mips/mips64, mips/mipsn32, pc98/i386, powerpc/powerpc, 
powerpc/powerpc64 and sparc64/sparc64.
+.It Va WITHOUT_PROFILE
+Set to not build profiled libraries for use with
+.Xr gprof 8 .
+.Pp
+This is a default setting on
+mips/mips64.
+.It Va WITH_PROFILE
+Set to build profiled libraries for use with
+.Xr gprof 8 .
+.Pp
+This is a default setting on
+amd64/amd64, arm/arm, arm/armeb, arm/armv6, arm64/aarch64, i386/i386, 
mips/mipsel, mips/mips, mips/mips64el, mips/mipsn32, pc98/i386, 
powerpc/powerpc, powerpc/powerpc64 and sparc64/sparc64.
 .It Va WITHOUT_PROFILE
 Set to not build profiled libraries for use with
 .Xr gprof 8 .
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r323303 - stable/11/share/mk

[Ngie Cooper]

Author: ngie
Date: Fri Sep  8 04:48:25 2017
New Revision: 323303
URL: https://svnweb.freebsd.org/changeset/base/323303

Log:
  MFC r321952:
  
  Allowing MK_NLS_CATALOGS to be enabled if MK_NLS == no doesn't make a whole 
lot
  of sense. Anchor MK_NLS_CATALOGS being enabled off of MK_NLS.

Modified:
  stable/11/share/mk/src.opts.mk
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/share/mk/src.opts.mk
==
--- stable/11/share/mk/src.opts.mk  Fri Sep  8 04:46:55 2017
(r323302)
+++ stable/11/share/mk/src.opts.mk  Fri Sep  8 04:48:25 2017
(r323303)
@@ -362,6 +362,10 @@ MK_ATM:=   no
 MK_BLUETOOTH:= no
 .endif
 
+.if ${MK_NLS} == "no"
+MK_NLS_CATALOGS:= no
+.endif
+
 .if ${MK_OPENSSL} == "no"
 MK_OPENSSH:=   no
 MK_KERBEROS:=  no
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r323302 - in stable/11: bin sbin usr.bin usr.sbin

[Ngie Cooper]

Author: ngie
Date: Fri Sep  8 04:46:55 2017
New Revision: 323302
URL: https://svnweb.freebsd.org/changeset/base/323302

Log:
  MFC r320701:
  
  Remove SUBDIR ordering/uniquifying in *bin/Makefile
  
  After the addition of SUBDIR.yes, uniquifying/ordering the SUBDIRs doesn't
  make a whole lot of sense, and it's in effect a half measure.
  
  Ordering SUBDIR (after adding SUBDIR.yes to it) in bsd.subdir.mk is a
  separate change that warrants more discussion/testing, because while
  the SUBDIR_PARALLEL work largely fixed dependency ordering for SUBDIRs,
  there might be downstream FreeBSD consumers that rely on the SUBDIR
  ordering.

Modified:
  stable/11/bin/Makefile
  stable/11/sbin/Makefile
  stable/11/usr.bin/Makefile
  stable/11/usr.sbin/Makefile
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/bin/Makefile
==
--- stable/11/bin/Makefile  Fri Sep  8 04:45:18 2017(r323301)
+++ stable/11/bin/Makefile  Fri Sep  8 04:46:55 2017(r323302)
@@ -47,8 +47,6 @@ SUBDIR.${MK_TESTS}+=  tests
 
 .include 
 
-SUBDIR:=   ${SUBDIR:O}
-
 SUBDIR_PARALLEL=
 
 .include 

Modified: stable/11/sbin/Makefile
==
--- stable/11/sbin/Makefile Fri Sep  8 04:45:18 2017(r323301)
+++ stable/11/sbin/Makefile Fri Sep  8 04:46:55 2017(r323302)
@@ -93,8 +93,6 @@ SUBDIR.${MK_TESTS}+=  tests
 
 .include 
 
-SUBDIR:=   ${SUBDIR:O}
-
 SUBDIR_PARALLEL=
 
 .include 

Modified: stable/11/usr.bin/Makefile
==
--- stable/11/usr.bin/Makefile  Fri Sep  8 04:45:18 2017(r323301)
+++ stable/11/usr.bin/Makefile  Fri Sep  8 04:46:55 2017(r323302)
@@ -311,8 +311,6 @@ SUBDIR+=mkesdb_static
 
 .include 
 
-SUBDIR:=   ${SUBDIR:O:u}
-
 SUBDIR_PARALLEL=
 
 .include 

Modified: stable/11/usr.sbin/Makefile
==
--- stable/11/usr.sbin/Makefile Fri Sep  8 04:45:18 2017(r323301)
+++ stable/11/usr.sbin/Makefile Fri Sep  8 04:46:55 2017(r323302)
@@ -217,8 +217,6 @@ SUBDIR.${MK_TESTS}+=tests
 
 .include 
 
-SUBDIR:=   ${SUBDIR:O}
-
 SUBDIR_PARALLEL=
 
 .include 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r323301 - stable/11/lib/libprocstat

[Ngie Cooper]

Author: ngie
Date: Fri Sep  8 04:45:18 2017
New Revision: 323301
URL: https://svnweb.freebsd.org/changeset/base/323301

Log:
  MFC r321704,r321705,r321706:
  
  r321704:
  
  Add sys/socket.h to SYNOPSIS for libprocstat(3)
  
  sys/socket.h is required for procstat_get_socket_info(3), added in
  r221807.
  
  PR:   217884
  
  r321705:
  
  libprocstat(3): fix reference (typo) to procstat_freeenvv in description for
  procstat_getargv(3)
  
  PR:   217884
  
  r321706:
  
  libprocstat(3): fix arguments list for procstat_getargv(3) and 
procstat_getenvv(3)
  
  Neither libcall takes a fourth argument (`char *errbuf`).
  
  PR:   217884

Modified:
  stable/11/lib/libprocstat/libprocstat.3
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/lib/libprocstat/libprocstat.3
==
--- stable/11/lib/libprocstat/libprocstat.3 Fri Sep  8 04:39:59 2017
(r323300)
+++ stable/11/lib/libprocstat/libprocstat.3 Fri Sep  8 04:45:18 2017
(r323301)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd May 18, 2015
+.Dd July 29, 2017
 .Dt LIBPROCSTAT 3
 .Os
 .Sh NAME
@@ -64,6 +64,7 @@
 .Sh SYNOPSIS
 .In sys/param.h
 .In sys/queue.h
+.In sys/socket.h
 .In libprocstat.h
 .Ft void
 .Fn procstat_close "struct procstat *procstat"
@@ -149,7 +150,6 @@
 .Fa "struct procstat *procstat"
 .Fa "const struct kinfo_proc *kp"
 .Fa "size_t nchr"
-.Fa "char *errbuf"
 .Fc
 .Ft "Elf_Auxinfo *"
 .Fo procstat_getauxv
@@ -162,7 +162,6 @@
 .Fa "struct procstat *procstat"
 .Fa "const struct kinfo_proc *kp"
 .Fa "size_t nchr"
-.Fa "char *errbuf"
 .Fc
 .Ft "struct filestat_list *"
 .Fo procstat_getfiles
@@ -352,7 +351,7 @@ function is similar to
 .Fn procstat_getargv
 but returns the vector of environment strings.
 The caller may free the allocated memory with a subsequent
-.Fn procstat_freeenv
+.Fn procstat_freeenvv
 function call.
 .Pp
 The
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"