Re: svn commit: r223350 - head/sys/dev/e1000
On 21 June 2011 02:59, Jack F Vogel j...@freebsd.org wrote: Author: jfv Date: Mon Jun 20 22:59:29 2011 New Revision: 223350 URL: http://svn.freebsd.org/changeset/base/223350 Log: Eliminate some global tuneables in favor of adapter-specific, particular flow control and dma coalesce. Also improve the sysctl operation on those too. Add IPv6 detection in the ioctl code, this was done for ixgbe first, carrying that over. Add resource ability to disable particular adapter. Add HW TSO capability so vlans can make use of TSO This change breaks LINT-NOINET amd64 and i386 builds. ixgbe is broken in the same way in r222588. Something like this should fix it (not tested). Index: sys/dev/e1000/if_igb.c === --- sys/dev/e1000/if_igb.c (revision 223490) +++ sys/dev/e1000/if_igb.c (working copy) @@ -1049,8 +1049,10 @@ ifp-if_flags |= IFF_UP; if (!(ifp-if_drv_flags IFF_DRV_RUNNING)) igb_init(adapter); +#ifdef INET if (!(ifp-if_flags IFF_NOARP)) arp_ifinit(ifp, ifa); +#endif } else #endif error = ether_ioctl(ifp, command, data); -- wbr, pluknet ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r223350 - head/sys/dev/e1000
On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: Author: jfv Date: Mon Jun 20 22:59:29 2011 New Revision: 223350 URL: http://svn.freebsd.org/changeset/base/223350 Log: Eliminate some global tuneables in favor of adapter-specific, particular flow control and dma coalesce. Also improve the sysctl operation on those too. Add IPv6 detection in the ioctl code, this was done for ixgbe first, carrying that over. Add resource ability to disable particular adapter. Add HW TSO capability so vlans can make use of TSO The tunables are useful for setting defaults for all interfaces. :( I use hw.igb.rx_processing_limit=-1 in loader.conf at work so that we can ensure that all igb interfaces in a given system have that setting. This is more scalable than having to set the right number of entries in /etc/sysctl.conf.local on different machines, etc, without spamming the console during boot with warnings about tweaking non-existing sysctls, etc. Please consider keeping the tunables where the tunables are used to set default settings for all adapters from the loader but per-device sysctls are used post-boot to provide runtime, per-device settings. -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r223350 - head/sys/dev/e1000
On Jun 21, 2011, at 8:07 AM, John Baldwin wrote: On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: Author: jfv Date: Mon Jun 20 22:59:29 2011 New Revision: 223350 URL: http://svn.freebsd.org/changeset/base/223350 Log: Eliminate some global tuneables in favor of adapter-specific, particular flow control and dma coalesce. Also improve the sysctl operation on those too. Add IPv6 detection in the ioctl code, this was done for ixgbe first, carrying that over. Add resource ability to disable particular adapter. Add HW TSO capability so vlans can make use of TSO The tunables are useful for setting defaults for all interfaces. :( I use hw.igb.rx_processing_limit=-1 in loader.conf at work so that we can ensure that all igb interfaces in a given system have that setting. This is more scalable than having to set the right number of entries in /etc/sysctl.conf.local on different machines, etc, without spamming the console during boot with warnings about tweaking non-existing sysctls, etc. Please consider keeping the tunables where the tunables are used to set default settings for all adapters from the loader but per-device sysctls are used post-boot to provide runtime, per-device settings. I agree. Guy This message has been scanned by ComplianceSafe, powered by Palisade's PacketSure. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r223350 - head/sys/dev/e1000
LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer the older for this. What other globals do you think should be retained? Jack On Tue, Jun 21, 2011 at 6:07 AM, John Baldwin j...@freebsd.org wrote: On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: Author: jfv Date: Mon Jun 20 22:59:29 2011 New Revision: 223350 URL: http://svn.freebsd.org/changeset/base/223350 Log: Eliminate some global tuneables in favor of adapter-specific, particular flow control and dma coalesce. Also improve the sysctl operation on those too. Add IPv6 detection in the ioctl code, this was done for ixgbe first, carrying that over. Add resource ability to disable particular adapter. Add HW TSO capability so vlans can make use of TSO The tunables are useful for setting defaults for all interfaces. :( I use hw.igb.rx_processing_limit=-1 in loader.conf at work so that we can ensure that all igb interfaces in a given system have that setting. This is more scalable than having to set the right number of entries in /etc/sysctl.conf.local on different machines, etc, without spamming the console during boot with warnings about tweaking non-existing sysctls, etc. Please consider keeping the tunables where the tunables are used to set default settings for all adapters from the loader but per-device sysctls are used post-boot to provide runtime, per-device settings. -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r223350 - head/sys/dev/e1000
On Jun 21, 2011, at 11:07 AM, Jack Vogel wrote: LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer the older for this. What other globals do you think should be retained? I'd like to be able to set the global default for flow control. I'd also appreciate a global default for disabling TCP checksum offload, but that's above and beyond what we had before :-) Jack On Tue, Jun 21, 2011 at 6:07 AM, John Baldwin j...@freebsd.org wrote: On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: Author: jfv Date: Mon Jun 20 22:59:29 2011 New Revision: 223350 URL: http://svn.freebsd.org/changeset/base/223350 Log: Eliminate some global tuneables in favor of adapter-specific, particular flow control and dma coalesce. Also improve the sysctl operation on those too. Add IPv6 detection in the ioctl code, this was done for ixgbe first, carrying that over. Add resource ability to disable particular adapter. Add HW TSO capability so vlans can make use of TSO The tunables are useful for setting defaults for all interfaces. :( I use hw.igb.rx_processing_limit=-1 in loader.conf at work so that we can ensure that all igb interfaces in a given system have that setting. This is more scalable than having to set the right number of entries in /etc/sysctl.conf.local on different machines, etc, without spamming the console during boot with warnings about tweaking non-existing sysctls, etc. Please consider keeping the tunables where the tunables are used to set default settings for all adapters from the loader but per-device sysctls are used post-boot to provide runtime, per-device settings. -- John Baldwin This message has been scanned by ComplianceSafe, powered by Palisade's PacketSure. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r223350 - head/sys/dev/e1000
There IS a global default for flow control, its just hardcoded.. :) Flow control was something my validation group specifically ragged on me about... and was the reason I changed to a per-adapter setting. Let me think about it. Jack On Tue, Jun 21, 2011 at 9:17 AM, Guy Helmer guy.hel...@palisadesystems.comwrote: On Jun 21, 2011, at 11:07 AM, Jack Vogel wrote: LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer the older for this. What other globals do you think should be retained? I'd like to be able to set the global default for flow control. I'd also appreciate a global default for disabling TCP checksum offload, but that's above and beyond what we had before :-) Jack On Tue, Jun 21, 2011 at 6:07 AM, John Baldwin j...@freebsd.org wrote: On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: Author: jfv Date: Mon Jun 20 22:59:29 2011 New Revision: 223350 URL: http://svn.freebsd.org/changeset/base/223350 Log: Eliminate some global tuneables in favor of adapter-specific, particular flow control and dma coalesce. Also improve the sysctl operation on those too. Add IPv6 detection in the ioctl code, this was done for ixgbe first, carrying that over. Add resource ability to disable particular adapter. Add HW TSO capability so vlans can make use of TSO The tunables are useful for setting defaults for all interfaces. :( I use hw.igb.rx_processing_limit=-1 in loader.conf at work so that we can ensure that all igb interfaces in a given system have that setting. This is more scalable than having to set the right number of entries in /etc/sysctl.conf.local on different machines, etc, without spamming the console during boot with warnings about tweaking non-existing sysctls, etc. Please consider keeping the tunables where the tunables are used to set default settings for all adapters from the loader but per-device sysctls are used post-boot to provide runtime, per-device settings. -- John Baldwin -- *This message has been scanned by ComplianceSafe, powered by Palisade's PacketSure.* ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r223350 - head/sys/dev/e1000
Ahh, I meant to say global tunables. It is nice to have flow control as a per-interface setting also - didn't have that back in FreeBSD 8.1. Thanks, Guy On Jun 21, 2011, at 11:34 AM, Jack Vogel wrote: There IS a global default for flow control, its just hardcoded.. :) Flow control was something my validation group specifically ragged on me about... and was the reason I changed to a per-adapter setting. Let me think about it. Jack On Tue, Jun 21, 2011 at 9:17 AM, Guy Helmer guy.hel...@palisadesystems.com wrote: On Jun 21, 2011, at 11:07 AM, Jack Vogel wrote: LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer the older for this. What other globals do you think should be retained? I'd like to be able to set the global default for flow control. I'd also appreciate a global default for disabling TCP checksum offload, but that's above and beyond what we had before :-) Jack On Tue, Jun 21, 2011 at 6:07 AM, John Baldwin j...@freebsd.org wrote: On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: Author: jfv Date: Mon Jun 20 22:59:29 2011 New Revision: 223350 URL: http://svn.freebsd.org/changeset/base/223350 Log: Eliminate some global tuneables in favor of adapter-specific, particular flow control and dma coalesce. Also improve the sysctl operation on those too. Add IPv6 detection in the ioctl code, this was done for ixgbe first, carrying that over. Add resource ability to disable particular adapter. Add HW TSO capability so vlans can make use of TSO The tunables are useful for setting defaults for all interfaces. :( I use hw.igb.rx_processing_limit=-1 in loader.conf at work so that we can ensure that all igb interfaces in a given system have that setting. This is more scalable than having to set the right number of entries in /etc/sysctl.conf.local on different machines, etc, without spamming the console during boot with warnings about tweaking non-existing sysctls, etc. Please consider keeping the tunables where the tunables are used to set default settings for all adapters from the loader but per-device sysctls are used post-boot to provide runtime, per-device settings. -- John Baldwin This message has been scanned by ComplianceSafe, powered by Palisade's PacketSure. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r223350 - head/sys/dev/e1000
On Tuesday, June 21, 2011 12:07:23 pm Jack Vogel wrote: LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer the older for this. What other globals do you think should be retained? I mostly care about the 'rxd', 'txd', 'rx_processing_limit', 'enable_aim', and 'num_queues'. -- John Baldwin ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
